Re: [PATCH v1.1] c++: tolerate cdtors returning this in constexpr

2022-04-11 Thread Alexandre Oliva via Gcc-patches
g is the actual return, > and your patch works around that. I think that makes sense for now; I > have a patch for GCC 13 to remove cdtor_label entirely. Ah, great, thanks. > Your patch is OK. Here's the adjusted (subject, thanks) patch I'm about to install. c++: Tolerate cdtors return

Re: [PATCH] c++: tolerate cdtors returning this in constexpr

2022-04-08 Thread Jason Merrill via Gcc-patches
On 4/7/22 18:25, Alexandre Oliva wrote: Hello, Jason, On Apr 6, 2022, Jason Merrill wrote: On 4/6/22 15:36, Alexandre Oliva wrote: Please adjust your patch subject lines for the new guidelines adopted as part of the git transition: https://gcc.gnu.org/contribute.html#patches Oh, wow, I

Re: [PATCH] c++: tolerate cdtors returning this in constexpr

2022-04-07 Thread Alexandre Oliva via Gcc-patches
Hello, Jason, On Apr 6, 2022, Jason Merrill wrote: > On 4/6/22 15:36, Alexandre Oliva wrote: > Please adjust your patch subject lines for the new guidelines adopted > as part of the git transition: > https://gcc.gnu.org/contribute.html#patches Oh, wow, I had missed those guidelines entirely!

Re: tolerate cdtors returning this in constexpr

2022-04-06 Thread Jason Merrill via Gcc-patches
On 4/6/22 15:45, Marek Polacek via Gcc-patches wrote: On Wed, Apr 06, 2022 at 04:36:49PM -0300, Alexandre Oliva via Gcc-patches wrote: On targets that return this from cdtors, cxx_eval_call_expression may flag flowing off the end of a dtor. That's preempted for ctors, and avoided entirely

Re: tolerate cdtors returning this in constexpr

2022-04-06 Thread Jason Merrill via Gcc-patches
On 4/6/22 15:36, Alexandre Oliva wrote: Please adjust your patch subject lines for the new guidelines adopted as part of the git transition: https://gcc.gnu.org/contribute.html#patches e.g. [PATCH] c++: tolerate cdtors returning this in constexpr [PRn] On targets that return this from

Re: tolerate cdtors returning this in constexpr

2022-04-06 Thread Alexandre Oliva via Gcc-patches
On Apr 6, 2022, Marek Polacek wrote: > On Wed, Apr 06, 2022 at 04:36:49PM -0300, Alexandre Oliva via Gcc-patches > wrote: >> else >> { >> result = *ctx->global->values.get (res); >> - if (result == NULL_TREE && !*non_constant_p) >> + if (result == NULL_TREE &&

Re: tolerate cdtors returning this in constexpr

2022-04-06 Thread Marek Polacek via Gcc-patches
On Wed, Apr 06, 2022 at 04:36:49PM -0300, Alexandre Oliva via Gcc-patches wrote: > > On targets that return this from cdtors, cxx_eval_call_expression may > flag flowing off the end of a dtor. That's preempted for ctors, and > avoided entirely when dtors return void, but when they return this, >

tolerate cdtors returning this in constexpr

2022-04-06 Thread Alexandre Oliva via Gcc-patches
On targets that return this from cdtors, cxx_eval_call_expression may flag flowing off the end of a dtor. That's preempted for ctors, and avoided entirely when dtors return void, but when they return this, the return value should be conceptually disregarded, without making room for such