Re: vector garbaged collected while still in use

2011-11-14 Thread Jan Hubicka
... probably here. Though I'd also approve a patch that simply removes the ggc_collect call (and the nested parameter). Honza - you probably added the ggc_collect - what's the reason to do it in this lowlevel place? The ggc_collect was always here. Before unit-at-a-time we used to run

Re: vector garbaged collected while still in use

2011-11-14 Thread Jan Hubicka
Here is the revised patch. Bootstrap and regression tested on linux/x86-64. Honza, can you comment on the implication of this change? Well, as I explained in previous email, this was traditinal place where frontends collect garbage while parsing, so you would need to verify that all the

Re: vector garbaged collected while still in use

2011-11-10 Thread Xinliang David Li
Looks like it is fixed already, so there is no need for this patch. David On Wed, Nov 9, 2011 at 12:36 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Nov 8, 2011 at 6:10 PM, Xinliang David Li davi...@google.com wrote: Here is the revised patch. Bootstrap and regression tested

Re: vector garbaged collected while still in use

2011-11-09 Thread Richard Guenther
On Tue, Nov 8, 2011 at 6:10 PM, Xinliang David Li davi...@google.com wrote: Here is the revised patch. Bootstrap and regression tested on linux/x86-64. Honza, can you comment on the implication of this change? Jason also seems to have touched this again, so maybe it's already fixed? thanks,

Re: vector garbaged collected while still in use

2011-11-08 Thread Xinliang David Li
Here is the revised patch. Bootstrap and regression tested on linux/x86-64. Honza, can you comment on the implication of this change? thanks, David On Mon, Nov 7, 2011 at 2:09 PM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, Nov 7, 2011 at 5:41 PM, Xinliang David Li

Re: vector garbaged collected while still in use

2011-11-07 Thread Richard Guenther
On Mon, Nov 7, 2011 at 8:53 AM, Xinliang David Li davi...@google.com wrote: I have seen compiler build error (segmentation fault) in libstdc++-v3. It turns out that a vector allocated in gc memory is GCed before the vector is released. The gc call is from a call to synethesize_method from

Re: vector garbaged collected while still in use

2011-11-07 Thread Xinliang David Li
Here is the stack trace when the watch point is hit (the watch point is on address cleanups-base.prefix.num David #0 memset () at ../sysdeps/x86_64/memset.S:336 #1 0x00d1528d in poison_pages () at /usr/local/google/davidxl/dev/gcc/tot/gcc/ggc-page.c:1983 #2 0x00d15424 in

Re: vector garbaged collected while still in use

2011-11-07 Thread Richard Guenther
On Mon, Nov 7, 2011 at 5:41 PM, Xinliang David Li davi...@google.com wrote: Here is the stack trace when the watch point is hit (the watch point is on address cleanups-base.prefix.num David #0  memset () at ../sysdeps/x86_64/memset.S:336 #1  0x00d1528d in poison_pages () at

vector garbaged collected while still in use

2011-11-06 Thread Xinliang David Li
I have seen compiler build error (segmentation fault) in libstdc++-v3. It turns out that a vector allocated in gc memory is GCed before the vector is released. The gc call is from a call to synethesize_method from cp_finish_decl. The following patch fixes the problem. Compiler bootstraps and