Re: [PATCH, ARM] Fix PR 43872, incorrectly aligned VLAs

2011-03-15 Thread Ramana Radhakrishnan
On 17/02/11 10:01, Chung-Lin Tang wrote: Hi, this PR is a case where we have a leaf function with a zero-size frame, that calls alloca() (here through a C99 VLA). The ARM backend recognizes the leaf-and-no-frame opportunity to save an unneeded stack alignment. But when calling alloca(), the

Re: [PATCH: ARM] PR 45335 Use ldrd and strd to access two consecutive words

2011-03-15 Thread Carrot Wei
The trunk is opened again, could any maintainers continue to review this patch? thanks Carrot On Tue, Jan 18, 2011 at 10:59 PM, Carrot Wei car...@google.com wrote: Ramana's method is to put the instruction output and counting in on place. So it's easy to keep them synchronized. My latest

[libgfortran, build] Remove AC_TRY_* macros from libgfortran configury

2011-03-15 Thread FX
Dear Fortran maintainers, dear autoconf gurus, The attached patch replaces the deprecated AC_TRY_{COMPILE,LINK,RUN} macros in libgfortran configury with their AC_*_IFELSE equivalents. Now (4.7 just branched) seems a good time, and I think I didn't screw it too much because the regenerated

[PATCH] Fix PR48031

2011-03-15 Thread Richard Guenther
We shouldn't create new VLA array accesses via fold when we are in gimple form as we have no way to fixup the gimplified element size and minimal value slots. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk (I'll make my way backwards to the release branches after 4.6.0 is

Ping for two ARM patches

2011-03-15 Thread Richard Sandiford
Now that GCC 4.7 is open, are these two ARM patches OK to commit? http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02266.html PR 47551: neon-related spill failure http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02284.html PR 47553: vld1q_lane_u8 co. don't accept lanes = 8 Thanks,

Re: Fix for PR target/47951

2011-03-15 Thread Bernd Schmidt
On 03/14/2011 01:10 PM, Henderson, Stuart wrote: Hi, The attached patch is an attempt to fix PR 47951, however I'm fairly new to GCC and have little confidence in it. I've done some testing with it and it avoids the problem and doesn't appear to cause any new problems, but I'd appreciate more

[PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jim Meyering
Janne Blomqvist wrote: On Tue, Mar 8, 2011 at 19:53, Jim Meyering j...@meyering.net wrote: Relative to v2, I've added libgo/ to the list of exempt directories and added this recently discussed gfc_free patch, at the request of Tobias Burnus. Also, I corrected an error in fortran's ChangeLog

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jim Meyering
Jakub Jelinek wrote: On Tue, Mar 15, 2011 at 11:02:38AM +0100, Jim Meyering wrote: Instead of please let us know, maybe recommend using __builtin_expect instead? E.g. something like if (__builtin_expect (ptr != NULL, 0)) free (ptr); Good idea. Thanks. Though how about avoiding

[PATCH] Fix PR41490

2011-03-15 Thread Richard Guenther
This fixes store-sinking (finally, broken since alias-improvements merge). To work reliably this adds an unconditional VUSE to all return statements. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-15 Richard Guenther rguent...@suse.de PR

[v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Rainer Orth
I think we agreed that it would be useful to regenerate the Solaris 2 libstdc++ baselines close to the GCC 4.6.0 release, especially given that symbol versioning on Solaris appears in 4.6.0 for the first time and several symbols have been added to the libstdc++.so ABI since the last update. This

Re: [patch gcc c++ c-family java fortan lto]: Fix DOS-filesystem issues

2011-03-15 Thread Pedro Alves
Thanks. On Tuesday 15 March 2011 07:25:10, Kai Tietz wrote: @@ -989,6 +989,13 @@ handle_toplevel_file (directive_handler_ in_fname = read_md_filename; lastsl = strrchr (in_fname, '/'); +#ifdef HAVE_DOS_BASED_FILE_SYSTEM + { +char *lsl2 = strrchr (in_fname, '\\'); +if

Re: [PATCH] Remove -fenable-icf-debug support

2011-03-15 Thread Rainer Orth
Hi Jakub, As Cary said there are no consumers of the .debug_dcall/.debug_vcall sections yet and DW_TAG_GNU_call_site info should contain a superset of that information, this patch removes -fenable-icf-debug support, if you think it is desirable to remove it. this should also fix PR

Re: [PATCH, ARM] Fix PR 43872, incorrectly aligned VLAs

2011-03-15 Thread Chung-Lin Tang
On 2011/3/15 02:41 PM, Ramana Radhakrishnan wrote: On 17/02/11 10:01, Chung-Lin Tang wrote: Hi, this PR is a case where we have a leaf function with a zero-size frame, that calls alloca() (here through a C99 VLA). The ARM backend recognizes the leaf-and-no-frame opportunity to save an

[committed] Fix fallout from snprintf folding patch (PR tree-optimization/48129)

2011-03-15 Thread Jakub Jelinek
Hi! On some targets implicit_built_in_decls[BUILT_IN_SNPRINTF] is NULL, but as we want only the return type of the snprintf function and fold_builtin_snprintf in that case is only used when __builtin_* variant is used explicitly, using built_in_decls is better and avoids the ICE.

Re: [v3] typeinfo tuning

2011-03-15 Thread Jonathan Wakely
On 14 March 2011 17:29, Benjamin Kosnik wrote: I hacked up scripts/check_compile and ran the libstdc++ testsuite to generate 4k+ .s files, and then analyzed the resulting assembly files for vague linkage. Here are the clear wins that are ABI-compatible, or in C++0x code. There are other

Re: [patch gcc c++ c-family java fortan lto]: Fix DOS-filesystem issues

2011-03-15 Thread Kai Tietz
2011/3/15 Pedro Alves pe...@codesourcery.com: Thanks. This looks like lbasename-able as well, getting rid of that HAVE_DOS...-ish foo: Thanks. Yes, that one I missed. Attached updated version of patch. Kai Index: gcc/gcc/c-family/c-ada-spec.c

[PATCH] Fix part of PR48037

2011-03-15 Thread Richard Guenther
This avoids spilling SSE registers to memory just because we access vector components in a C array way. The trick is to simply rewrite those accesses to proper vector selects on the tree level and promote the vector to SSA form. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to

[google] XFAIL execution of libmudflap.c/pass49-frag.c (issue4278049)

2011-03-15 Thread Diego Novillo
When I XFAIL'd this test, I forgot to XFAIL its execution as well. Tested on x86_64. Committed to branch. 2011-03-15 Diego Novillo dnovi...@google.com * testsuite/libmudflap.c/pass49-frag.c: Also XFAIL execution. Index: libmudflap/testsuite/libmudflap.c/pass49-frag.c

Fix PR 45844, gfortran.dg/vect/pr45714-b.f ICE on power7

2011-03-15 Thread Alan Modra
The vsx splat load from memory insns manage to evade reg_offset_addressing_ok_p since their MEM mode is DFmode or DImode, which are not (usually) vector modes. This patch prevents reload damage in rs6000_legitimize_reload_address, and ensures the splat insn predicate is sufficiently strict.

Re: ivopts improvement

2011-03-15 Thread Tom de Vries
Hi Zdenek, I rewrote the patch to remove the use of use_uses_inced_iv. On 03/14/2011 03:03 PM, Zdenek Dvorak wrote: Hi, (since the use_uses_inced_iv test is meaningless). To me it seems use_uses_inced_iv has meaning: - it models something: it states whether the comparison is using the

C++0x PATCH to implement core 1191 (deleted base destructor)

2011-03-15 Thread Jason Merrill
This patch implements the proposed resolution for core issue 1191: base destructors do not affect the triviality of derived constructors, but they do affect the exception specification and deletedness. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: [PATCH gcc/fortran] get rid of gfc_free

2011-03-15 Thread Jim Meyering
Janne Blomqvist wrote: ... Hi Janne, These requested changes are in addition to (and independent of) the changes that I've already posted here. Yes, it was perhaps a bit unreasonable to ask you to fix this. OTOH with your changes gfc_free() was just a wrapper around free() and should thus

Re: [PATCH][bug 48123] Install cpu_defines.h for freestanding C++ library.

2011-03-15 Thread Paolo Carlini
Hi, Hi, This patch fixes the problem in bug 48123. The problem is that some headers include c++config.h, which in turn includes cpu_defines.h but cpu_defines.h is not installed. This has been broken for a long time. Patch was tested by bootstrapping on x86_64 and building a cross-gcc

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Benjamin Kosnik
I think we agreed that it would be useful to regenerate the Solaris 2 libstdc++ baselines close to the GCC 4.6.0 release, especially given that symbol versioning on Solaris appears in 4.6.0 for the first time and several symbols have been added to the libstdc++.so ABI since the last update.

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Benjamin Kosnik
The lines in question are ##_ZTISt16nested_exception (glob) _ZTISt16nested_exception; ##_ZTSSt16nested_exception (glob) _ZTSSt16nested_exception; ##_ZTVSt16nested_exception (glob) _ZTVSt16nested_exception; in CXXABI_1.3.5, but the same symbols are also matched

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Paolo Carlini
On 03/15/2011 08:05 PM, Benjamin Kosnik wrote: I've also changed the bad_function_call exports to not be in libsupc++, or the freestanding version. (ie to GLIBCXX from CXXABI). I think this was probably a simple thinko, right Paolo? Yes, as far as I can see now. Sorry about that and thanks for

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Paolo Carlini
... and I suppose the thinko alone should be fixed in 4_6-branch too, right? Paolo.

[PATCH] Fix fallout of my fold_binary EQ/NE patch (PR middle-end/48136)

2011-03-15 Thread Jakub Jelinek
Hi! The addition of STRIP_NOPS for EQ_EXPR/NE_EXPR revealed a bunch of cases which rely on arg0 and arg1 having the same type. Only the last hunk fixes the testcase, the rest is what I saw and it was possible the types wouldn't match. Tried to construct testcases for the other cases, but didn't

[PATCH][4.5] Fix backport of PR 47862 to 4.5 branch

2011-03-15 Thread Pat Haugen
The following changes are already present on trunk as part of the fix for PR44364. Not having them on 4.5 caused problems with the subject fix when trying to spill FP regs with a stack 32K. Bootstrap/regtest 4.5 branch on powerpc with no new failures, ok for 4.5? -Pat 2011-03-15 Pat

Re: [Patch][AVR]: Support tail calls

2011-03-15 Thread Richard Henderson
On 03/11/2011 05:43 AM, Georg-Johann Lay wrote: I did not find a way to make this work together with -mcall-prologues. Please let me know if you have suggestion on how call prologues can be combine with tail calls. You need a new symbol in libgcc for this. It should be easy enough to have the

Re: [PATCH] Fix RTL DSE compile time hog (PR rtl-optimization/48141)

2011-03-15 Thread Kenneth Zadeck
so how much time does this save? I agree that this is a useful simplification, but it seems unlikely to be that important in real code. it seems like the 5000 store test would in general provide a better safety valve. Kenny On 03/15/2011 07:05 PM, Jakub Jelinek wrote: Hi! On the attached

Re: [PATCH, committed] Refix 48053, do not abort in loading 0 into VSX register under 32-bit

2011-03-15 Thread Michael Meissner
This is a reduced version of the testcase that shows the bug that was fixed. However it is odd, in that the code that triggered the bug is setting hard register FR3 to 0 as a DImode value just before the call to __gcc_qmul to multiply the two long double values, so it needs some more looking into.

[c++] refactor some data structures into cp/parser.h (issue4295052)

2011-03-15 Thread Diego Novillo
This patch refactors some data structures out of cp/parser.c into cp/parser.h and converts the main lexer buffer into a VEC. No functional changes, other than minor data structure tweaks: - The token buffer is now a VEC. - Instead of clobbering purged tokens, we have a purged_p marker

Re: [PATCH] Add check before potentially dividing by 0

2011-03-15 Thread asharif
I have seen an ICE in 4.4.3 when a corrupted profile file causes a division by 0 in gcc. This is the equivalent code in trunk and this check should help fix it. Thoughts? 2011-03-15  Ahmad Sharif  asha...@google.com        * predict.c (probably_never_executed_bb_p): Add check to see       

Re: [PATCH] Updated DW_OP_GNU_entry_value/DW_TAG_GNU_call_site patch

2011-03-15 Thread Richard Henderson
On 03/15/2011 04:19 AM, Jakub Jelinek wrote: Hi! Now that we are back in stage 1, I'd like move on with the entry_value/call_site debug info extensions. Here is the http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01793.html patch updated to current trunk, bootstrapped/regtested on

Re: [PATCH] Updated ENTRY_VALUE patch (PR debug/45882)

2011-03-15 Thread Richard Henderson
On 03/15/2011 04:20 AM, Jakub Jelinek wrote: Here is http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01794.html patch updated to current trunk, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok. r~

Re: [PATCH] Remove -fenable-icf-debug support

2011-03-15 Thread Richard Henderson
On 03/15/2011 04:25 AM, Jakub Jelinek wrote: As Cary said there are no consumers of the .debug_dcall/.debug_vcall sections yet and DW_TAG_GNU_call_site info should contain a superset of that information, this patch removes -fenable-icf-debug support, if you think it is desirable to remove it.

[x32] PATCH: Also check x32 for vect_cmdline_needed target.

2011-03-15 Thread H.J. Lu
x32 is similar to x86-64. I checked this patch into x32 branch. H.J. --- diff --git a/gcc/testsuite/ChangeLog.x32 b/gcc/testsuite/ChangeLog.x32 index 32c3e34..9bcf223 100644 --- a/gcc/testsuite/ChangeLog.x32 +++ b/gcc/testsuite/ChangeLog.x32 @@ -1,5 +1,10 @@ 2011-03-15 H.J. Lu

Re: [libgfortran, build] Remove AC_TRY_* macros from libgfortran configury

2011-03-15 Thread Ralf Wildenhues
* FX wrote on Tue, Mar 15, 2011 at 10:33:01AM CET: The attached patch replaces the deprecated AC_TRY_{COMPILE,LINK,RUN} macros in libgfortran configury with their AC_*_IFELSE equivalents. Now (4.7 just branched) seems a good time, and I think I didn't screw it too much because the regenerated