Re: [PATCH] Add extra location information - PR43486

2012-09-19 Thread Arnaud Charlet
Thanks for your feedback. I also think this is to be preferred. I think of location_t as being, for most of the compiler, an opaque handle to location information. Just as it can now represent information about different concepts of location in the presence of macro expansion, so it's

Re: [PATCH] Add -Og optimization level - optimize for compile-time/debugging experience

2012-09-19 Thread Eric Botcazou
This adds -Og as optimization level targeted at the devel-compile-debug cycle (formerly mostly tied to -O0 due to debug issues with even -O1). Discussion on g...@gcc.gnu.org at least shows interest in this, so this is a formal patch submission with a request for comments on the

Re: Use conditional casting with symtab_node

2012-09-19 Thread Eric Botcazou
The language syntax would bind the conditional into the intializer, as in if (varpool_node *vnode = (node-try_variable () vnode-finalized)) varpool_analyze_node (vnode); which does not type-match. So, if you want the type saftey and performance,

Re: [PATCH] Add extra location information - PR43486

2012-09-19 Thread Jakub Jelinek
On Wed, Sep 19, 2012 at 09:18:39AM +0200, Arnaud Charlet wrote: Thanks for your feedback. I also think this is to be preferred. I think of location_t as being, for most of the compiler, an opaque handle to location information. Just as it can now represent information about different

Re: [PATCH] Changes in mode switching

2012-09-19 Thread Uros Bizjak
On Tue, Sep 18, 2012 at 10:57 PM, Vladimir Yakovlev vbyakov...@gmail.com wrote: Attached files i386.patch contains changes for vzeroupper placement. post_reload.patch contens changes for post reload pass. I have bootstrap problem with post_reload.patch. Does the patch without

Re: [PATCH] OpenBSD/hppa support

2012-09-19 Thread Mark Kettenis
Date: Tue, 18 Sep 2012 14:43:35 -0400 From: John David Anglin d...@hiauly1.hia.nrc.ca On Thu, 06 Sep 2012, Mark Kettenis wrote: Most bits are stolen from Linux, but there are a few subtle differences since our assembler is configured to be slightly more HP-UX-ish. libgcc/:

Re: [testsuite] vect effective targets should use arm_neon_ok

2012-09-19 Thread Richard Earnshaw
On 18/09/12 21:59, Janis Johnson wrote: On 09/18/2012 12:54 PM, Janis Johnson wrote: In most cases a test that requires ARM NEON should use effective target arm_neon, which means that flags run for all tests include NEON support. The result is cached the first time it is checked for a

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Jan Hubicka
Hi, I've integrated all the reviews from this thread (Thank you guys for helping refine this patch). Now the patch can pass all gcc testsuite as well as all spec2006 benchmarks (with LTO). Concerning memory consumption, for extreme benchmarks like tramp3d, this patch incurs around 2%

Re: [PATCH] Add -Og optimization level - optimize for compile-time/debugging experience

2012-09-19 Thread Richard Guenther
On Wed, 19 Sep 2012, Eric Botcazou wrote: This adds -Og as optimization level targeted at the devel-compile-debug cycle (formerly mostly tied to -O0 due to debug issues with even -O1). Discussion on g...@gcc.gnu.org at least shows interest in this, so this is a formal patch submission

[PATCH] Fix PR54132

2012-09-19 Thread Richard Guenther
This fixes PR54132 where loop distribution pattern matching thinks that every loop that copies contiguous memory regions and has a dependence between input and output can be representet by a memmove. Not. Obviously. Thus, fixed by doing proper dependence checks. Bootstrapped and tested on

Re: [PATCH] Fix PR54132

2012-09-19 Thread Jakub Jelinek
On Wed, Sep 19, 2012 at 10:53:00AM +0200, Richard Guenther wrote: + extern void abort (void); + void foo(char *p, int n) + { + int i; + for (i = 1; i n; i++) + p[i] = p[i - 1]; You could turn this into if (n 1) memset (p + 1, p[0], n - 1); if you wanted, though of course that is

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread Richard Guenther
On Wed, Sep 19, 2012 at 3:51 AM, Joern Rennecke amyl...@spamcop.net wrote: I am about to submit the ARCompact target port; this port needs a few patches to target-independent code. There is a move pattern with 20 alternatives; a few of them need a simple function call to decide which output

Re: Use conditional casting with symtab_node

2012-09-19 Thread Richard Guenther
On Wed, Sep 19, 2012 at 9:29 AM, Eric Botcazou ebotca...@adacore.com wrote: The language syntax would bind the conditional into the intializer, as in if (varpool_node *vnode = (node-try_variable () vnode-finalized)) varpool_analyze_node (vnode); which

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Richard Guenther
On Wed, Sep 19, 2012 at 10:48 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, I've integrated all the reviews from this thread (Thank you guys for helping refine this patch). Now the patch can pass all gcc testsuite as well as all spec2006 benchmarks (with LTO). Concerning memory consumption, for

Re: [PATCH] Add -Og optimization level - optimize for compile-time/debugging experience

2012-09-19 Thread Richard Guenther
On Tue, 18 Sep 2012, Ian Lance Taylor wrote: On Tue, Sep 18, 2012 at 4:23 AM, Richard Guenther rguent...@suse.de wrote: This adds -Og as optimization level targeted at the devel-compile-debug cycle (formerly mostly tied to -O0 due to debug issues with even -O1). This needs an entry in

Re: [libbacktrace] Fix bootstrap with gcc 4.4

2012-09-19 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: On Tue, Sep 18, 2012 at 1:32 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: The libbacktrace integration broke Solaris 10 and 11 bootstrap when using gcc 4.4 (any version of gcc without __sync_* support actually): The patch is fine and should

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Martin Jambor
Hi, On Wed, Sep 12, 2012 at 04:17:45PM +0200, Michael Matz wrote: Hi, On Wed, 12 Sep 2012, Michael Matz wrote: Hm, but we shouldn't end up streaming any BLOCKs at this point (nor local TYPE_DECLs). Those are supposed to be in the local function sections only where no fixup for

[PATCH, WWWDOCS] Document AArch64-4.7 branch

2012-09-19 Thread Sofiane Naci
Hi, This patch documents the AArch64-4.7 branch in wwwdocs/htdocs/svn.html. OK? Thanks Sofiane - Proposed ChangeLog: * htdocs/svn.html: Document aarch64-4.7 branch. aarch64-4.7-branch-wwwdocs.patch Description: Binary data

Re: [PATCH, WWWDOCS] Document AArch64-4.7 branch

2012-09-19 Thread Marcus Shawcroft
On 19 Sep 2012, at 11:26, Sofiane Naci sofiane.n...@arm.commailto:sofiane.n...@arm.com wrote: Hi, This patch documents the AArch64-4.7 branch in wwwdocs/htdocs/svn.html. OK? Sofiane, When I posted the equivalent patch for the aarch64-branch Gerald pointed out that someone with write

[patch] split FRAME variables back into pieces

2012-09-19 Thread Eric Botcazou
Hi, this transformation has been in our tree for a couple of years and was originally developed for SPARKSkein (http://www.skein-hash.info/node/48), which is the implementation in SPARK (subset of Ada) of the Skein algorithm. When nested functions access local variables of their parent, the

[PATCH] Simplify get_prop_source_stmt

2012-09-19 Thread Richard Guenther
Pointer conversions are useless for quite some time, so simplify get_prop_source_stmt. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-09-19 Richard Guenther rguent...@suse.de * tree-ssa-forwprop.c (get_prop_source_stmt): Simplify. Index:

[PATCH] Fix scan-dumps in testcase, for -Og

2012-09-19 Thread Richard Guenther
This fixes scans for fab with fab1 which now appears twice after adding -Og. Tested on x86_64-unknown-linux-gnu, applied. Sorry for the breakage, Richard. 2012-09-19 Richard Guenther rguent...@suse.de * gcc.dg/builtin-object-size-10.c: Adjust. *

Re: [patch] split FRAME variables back into pieces

2012-09-19 Thread Richard Guenther
On Wed, Sep 19, 2012 at 12:58 PM, Eric Botcazou ebotca...@adacore.com wrote: Hi, this transformation has been in our tree for a couple of years and was originally developed for SPARKSkein (http://www.skein-hash.info/node/48), which is the implementation in SPARK (subset of Ada) of the Skein

[PATCHv4] rs6000: Add 2 built-ins to read the Time Base Register on PowerPC

2012-09-19 Thread Tulio Magno Quites Machado Filho
Changes since v3: - specified the clobbered CC field; - removed the insn rs6000_get_timebase_ppc64 as it was identical to rs6000_mftb_di; - removed UNSPECV_GETTB as it was identical to UNSPECV_MFTB; - fixed indentation. -- 8 -- Add __builtin_ppc_get_timebase and __builtin_ppc_mftb to read the

Re: [patch] split FRAME variables back into pieces

2012-09-19 Thread Jakub Jelinek
On Wed, Sep 19, 2012 at 01:36:50PM +0200, Richard Guenther wrote: On Wed, Sep 19, 2012 at 12:58 PM, Eric Botcazou ebotca...@adacore.com wrote: I really don't like this to be done outside of SRA (and it is written in a non-MEM_REF way). For the testcase in question we scalarize back 'i' in SRA

Re: [SH] Use more braced strings in MD

2012-09-19 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: Like the topic says. No functional change, just cosmetics. Tested on rev 191342 with make -k check RUNTESTFLAGS=--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} and no new failures. OK to install? OK. Regards,

Re: [SH] PR 54236 - Add another addc case

2012-09-19 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: There is another opportunity where SH's addc insn can be used. Tested on rev 191342 with make -k check RUNTESTFLAGS=--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} and no new failures. OK to install? OK. Regards,

Re: [SH] PR 54089 - Add another rotcr case

2012-09-19 Thread Kaz Kojima
Oleg Endo oleg.e...@t-online.de wrote: There is another opportunity where SH's rotcr insn can be used. Tested on rev 191342 with make -k check RUNTESTFLAGS=--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb} and no new failures. OK to install? OK.

Re: [PATCH] Add option for dumping to stderr (issue6190057)

2012-09-19 Thread Richard Guenther
On Tue, Sep 18, 2012 at 10:48 AM, Sharad Singhai sing...@google.com wrote: In response to the recent comments, I have updated the patch to do the following: - Remove pass handling from -fopt-info - Support additional flags in regular dumps I have massaged the options so that they have the

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread Joern Rennecke
Quoting Richard Guenther richard.guent...@gmail.com: I think that needs to be documented somewhere in the internals manual, I suppose it should logically go to the current end of the Output Statement node in md.texi . Line 668 in revision 191429, just before the Predicates node.

Re: Rewrite lto-symtab to work on symbol table

2012-09-19 Thread Markus Trippelsdorf
On 2012.09.18 at 15:35 +0200, Jan Hubicka wrote: Hi, this patch reorganize lto-symtab to work across symtab's symbol table instead of building its own. This simplifies things a bit and with the previous changes it is rather straighforward - i.e. replace all uses of lto_symtab_entry_t by

Re: Use conditional casting with symtab_node

2012-09-19 Thread Gabriel Dos Reis
On Wed, Sep 19, 2012 at 4:17 AM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Sep 19, 2012 at 9:29 AM, Eric Botcazou ebotca...@adacore.com wrote: The language syntax would bind the conditional into the intializer, as in if (varpool_node *vnode = (node-try_variable ()

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread Richard Guenther
On Wed, Sep 19, 2012 at 2:06 PM, Joern Rennecke amyl...@spamcop.net wrote: Quoting Richard Guenther richard.guent...@gmail.com: I think that needs to be documented somewhere in the internals manual, I suppose it should logically go to the current end of the Output Statement node in md.texi

Make cfun_push and cfun_pop also change current_function_decl

2012-09-19 Thread Martin Jambor
Hi, this is my second attempt to make push_cfun and pop_cfun save and restore current_function_decl, so that code that wants to change the function context does not have to do the latter manually. This of course enforces that cfun and current_function_decl match at push_cfun points which is

Patch ping^3

2012-09-19 Thread Jakub Jelinek
Hi! http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01100.html - C++ -Wsizeof-pointer-memaccess support (C is already in) http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00711.html - PR debug/54519 - first part of partial inlining debug info fixes Jakub

Re: [PATCHv4] rs6000: Add 2 built-ins to read the Time Base Register on PowerPC

2012-09-19 Thread David Edelsohn
On Wed, Sep 19, 2012 at 7:37 AM, Tulio Magno Quites Machado Filho tul...@linux.vnet.ibm.com wrote: Changes since v3: - specified the clobbered CC field; - removed the insn rs6000_get_timebase_ppc64 as it was identical to rs6000_mftb_di; - removed UNSPECV_GETTB as it was identical to

[PATCH] One more fab - fab1

2012-09-19 Thread Richard Guenther
Committed. Richard. 2012-09-19 Richard Guenther rguent...@suse.de * gcc.dg/builtin-unreachable-6.c: Adjust. Index: gcc/testsuite/gcc.dg/builtin-unreachable-6.c === --- gcc/testsuite/gcc.dg/builtin-unreachable-6.c

Re: [patch] Fix PR rtl-optimization/54290

2012-09-19 Thread Ulrich Weigand
Eric Botcazou wrote: 2012-09-18 Eric Botcazou ebotca...@adacore.com PR rtl-optimization/54290 * reload1.c (choose_reload_regs): Also take into account secondary MEMs to remove address replacements for inherited reloads. (replaced_subreg): Move around. Looks good

[PATCH] Move objsz pass for -Og

2012-09-19 Thread Richard Guenther
This moves objsz so basic constant propagation (done by copyprop) propagates its results before we fold the builtins in fab. This fixes execute fails in the builtins testsuite. Bootstrapped on x86_64-unknown-linux-gnu, full testing in progress. Richard. 2012-09-19 Richard Guenther

Re: [libbacktrace] Fix bootstrap with gcc 4.4

2012-09-19 Thread Ian Lance Taylor
On Wed, Sep 19, 2012 at 2:30 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Ian Lance Taylor i...@google.com writes: __sync_* support. Might be worth looking into why the test failed. On i386-pc-solaris2.*, __sync_bool_compare_and_swap_4 is missing. sparc-sun-solaris2.11 is fine,

[PATCH] Add -Og -g to TORTURE_OPTIONS

2012-09-19 Thread Richard Guenther
Which passes testing now. Ok? Thanks, Richard. 2012-09-19 Richard Guenther rguent...@suse.de * lib/c-torture.exp (TORTURE_OPTIONS): Add -Og -g. Index: gcc/testsuite/lib/c-torture.exp === ---

Re: [C++ PATCH] -Wsizeof-pointer-memaccess warning

2012-09-19 Thread Jason Merrill
Hmm. This is a rather intrusive change to work around the problem of early folding, which we'd like to move away from anyway. How does it work to always keep SIZEOF_EXPR unfolded until cxx_eval_constant_expression? Jason

Re: [PATCH] Add -Og -g to TORTURE_OPTIONS

2012-09-19 Thread Jakub Jelinek
On Wed, Sep 19, 2012 at 03:51:56PM +0200, Richard Guenther wrote: Which passes testing now. Ok? Yes. Probably we'll need to retune parallel checking, but we probably need to do it anyway already now, e.g. i386.exp grew too much. Jakub

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Michael Matz
Hi, On Wed, 19 Sep 2012, Martin Jambor wrote: (The patch does not introduce any of the asserts Michael's patch had because, as far as I my grep told me, IS_UNKNOWN_LOCATION is not in trunk yet and I suppose the pre-approval does not cover introducing things like that.) Dehaos patch

Re: [PATCH] Add -Og -g to TORTURE_OPTIONS

2012-09-19 Thread Richard Guenther
On Wed, 19 Sep 2012, Jakub Jelinek wrote: On Wed, Sep 19, 2012 at 03:51:56PM +0200, Richard Guenther wrote: Which passes testing now. Ok? Yes. Probably we'll need to retune parallel checking, but we probably need to do it anyway already now, e.g. i386.exp grew too much. Committed.

[PATCH,committed] AIX 6.1 TARGET_DEFAULT is POWER4

2012-09-19 Thread David Edelsohn
AIX 6.1 no longer supports POWER3 hardware, so this change adds the basic POWER4 capabilities to TARGET_DEFAULTS. Bootstrapped and regression tested on powerpc-ibm-aix7.1.0.0. - David * config/rs6000/aix61.h (TARGET_DEFAULT): Add MASK_PPC_GPOPT, MASK_PPC_GFXOPT, and MASK_MFCRF.

Re: [PATCH] Add extra location information - PR43486

2012-09-19 Thread Joseph S. Myers
On Wed, 19 Sep 2012, Arnaud Charlet wrote: OK, so you mean, instead of knowing the number of locations from the tree kind (e.g. 1 extra sloc for unary exprs, 2 for binary exprs, ...), we would encode this as part of the extra loc info? Note that the number of No, I mean that rather than the

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread Joern Rennecke
Quoting Richard Guenther richard.guent...@gmail.com: Something smaller (but pointless) woudl be nice. I have attached the patch with the example added to the documentation. Again, bootstrapped on i686-pc-linux-gnu. 2011-09-19 Jorn Rennecke joern.renne...@arc.com * genoutput.c

Go patch committed: Ignore byte-order-mark at start of file

2012-09-19 Thread Ian Lance Taylor
For convenience with some Windows editors, the other Go compiler was modified to permit a byte-order-mark (0xfeff) at the start of a .go file. This byte-order-mark is meaningless when using UTF-8, but apparently some editors introduce it anyhow. This patch changes the gccgo frontend to also

[C++ Patch / RFC] PR 52432

2012-09-19 Thread Paolo Carlini
Hi all, Jason, the large testcase attached by Jon to this PR triggers an Internal compiler error: Error reporting routines re-entered. from -fdump-tree-gimple. The immediate cause seems obvious: in one place in tsubst_copy_and_build we are calling unqualified_name_lookup_error

[patch,wwwdocs,4.6,committed]

2012-09-19 Thread Georg-Johann Lay
Applied the following patch that moved the note about the progmem attribute for AVR from the improvements section to caveats. Johann * gcc-4.6/changes.html (avr): Mode note on progmem attribute from improvments to caveats. Index: gcc-4.6/changes.html

[patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-19 Thread Steve Ellcey
While building newlib with -O2 -mips16 I ran into a problem with GCC aborting due to the compiler trying to execute '0 % 0' in mips16_unextended_reference_p. The problem was that the code checked for BLKmode and skipped the modulo operation in that case because GET_MODE_SIZE (BLKmode) is zero but

[Patch] catch builtin_bswap16 construct

2012-09-19 Thread Christophe Lyon
Hi, The attached patch catches C constructs: (A 8) | (A 8) where A is unsigned 16 bits and maps them to builtin_bswap16(A) which can provide more efficient implementations on some targets. The construct above is equivalent to the default bswap16 implementation. I have added a testcase for

Re: [patch, mips] Patch for new mips triplet - mips-mti-elf

2012-09-19 Thread Steve Ellcey
Richard, Here is a new copy of my mips-mti-elf patch. I removed SYSROOT_SUFFIX_SPEC since that was unneeded as you said and changed DRIVER_SELF_SPECS to set the ABI to n32 by default on mips64 targets like mips-sde-elf does. I also updated t-mti-elf to add mips16 and mabi=64 targets and

Re: [patch, mips] Patch for new mips triplet - mips-mti-elf

2012-09-19 Thread Richard Sandiford
Steve Ellcey sell...@mips.com writes: 2012-09-19 Steve Ellcey sell...@mips.com * config.gcc (mips*-mti-elf*): New target. * config/mips/mti-elf.h: New file. * config/mips/t-mti-elf: New file. OK, thanks. Richard

[patch testsuite]: Fix failing test for llp64 in gcc.dg/tree-ssa

2012-09-19 Thread Kai Tietz
Hi, this patch fixes testsuite-failures for llp64 targets in gcc.dg/tree-ssa testsuite. ChangeLog 2012-09-19 Kai Tietz * gcc.dg/tree-ssa/scev-3.c: Add llp64 to xfail. * gcc.dg/tree-ssa/scev-4.c: Likewise. Ok for apply? Regards, Kai Index: scev-3.c

Re: [Patch] catch builtin_bswap16 construct

2012-09-19 Thread Oleg Endo
On Wed, 2012-09-19 at 18:44 +0200, Georg-Johann Lay wrote: This seems overly complicated on 16-bit platforms where (A 8) | (A 8) is the same as rotate:HI (A 8). Does your patch make sure that (A 8) | (A 8) is still mapped to ROTATE on these targets? If I remember correctly, the

Re: [C++ Patch] for c++/54537

2012-09-19 Thread Fabien Chêne
Hi Paolo, 2012/9/19 Paolo Carlini paolo.carl...@oracle.com: On 09/19/2012 01:24 AM, Paolo Carlini wrote: On 09/19/2012 01:12 AM, Paolo Carlini wrote: Hi again, On 09/18/2012 08:33 PM, Paolo Carlini wrote: But I'm not surprised, frankly, I think the conflict is expected, *IF* (please

Re: [testsuite] support using target and xfail together

2012-09-19 Thread Janis Johnson
Ping. On 07/24/2012 11:13 AM, Janis Johnson wrote: This patch allows the use of both target and xfail in the selector of any test directive that currently takes either target or xfail: { target selector1 xfail selector2 } The test is only used if the target selector is matched, and the

Re: [patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-19 Thread Richard Sandiford
Steve Ellcey sell...@mips.com writes: While building newlib with -O2 -mips16 I ran into a problem with GCC aborting due to the compiler trying to execute '0 % 0' in mips16_unextended_reference_p. The problem was that the code checked for BLKmode and skipped the modulo operation in that case

Re: [testsuite] support using target and xfail together

2012-09-19 Thread Mike Stump
On Sep 19, 2012, at 10:35 AM, Janis Johnson janis_john...@mentor.com wrote: On 07/24/2012 11:13 AM, Janis Johnson wrote: This patch allows the use of both target and xfail in the selector of any test directive that currently takes either target or xfail: { target selector1 xfail selector2 }

Re: [testsuite] support using target and xfail together

2012-09-19 Thread Janis Johnson
On 09/19/2012 10:48 AM, Mike Stump wrote: On Sep 19, 2012, at 10:35 AM, Janis Johnson janis_john...@mentor.com wrote: On 07/24/2012 11:13 AM, Janis Johnson wrote: This patch allows the use of both target and xfail in the selector of any test directive that currently takes either target or

[PATCHv5] rs6000: Add 2 built-ins to read the Time Base Register on PowerPC

2012-09-19 Thread Tulio Magno Quites Machado Filho
Changes since v4: - Changed the condition register mode to CC; - Fixed some style issues (removed spaces between operands in asm, included spaces after function names in the testcases and before sentences in the manual) -- 8 -- Add __builtin_ppc_get_timebase and __builtin_ppc_mftb to read

Re: Use conditional casting with symtab_node

2012-09-19 Thread Lawrence Crowl
On 9/19/12, Eric Botcazou ebotca...@adacore.com wrote: The language syntax would bind the conditional into the intializer, as in if (varpool_node *vnode = (node-try_variable () vnode-finalized)) varpool_analyze_node (vnode); which does not

Re: [C++ Patch] for c++/54537

2012-09-19 Thread Paolo Carlini
Hi Fabien, On 09/19/2012 07:29 PM, Fabien Chêne wrote: But I'm afraid this is still not completely correct, because if the user code has a using std::pow in the global namespace and then and include tr1/cmath the latter drags again in namespace std::tr1 the overloads pow (*, int) which we don't

Re: [patch, mips] Fix for PR 54619, GCC aborting with -O -mips16

2012-09-19 Thread Steve Ellcey
On Wed, 2012-09-19 at 18:42 +0100, Richard Sandiford wrote: This hook is never called with an invalid address. Since VOIDmode MEMs aren't valid, I think that should mean it's invalid to call this hook (and rtlanal.c:address_cost) with VOIDmode. I never got time to look at that though.

Re: Use conditional casting with symtab_node

2012-09-19 Thread Lawrence Crowl
On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Sep 19, 2012 Richard Guenther richard.guent...@gmail.com wrote: Indeed. Btw, can we not provide a specialization for dynamic_cast ? This -try_... looks awkward to me compared to the more familiar vnode = dynamic_cast

Re: [Patch, fortran] PR46897 - [OOP] type-bound defined ASSIGNMENT(=) not used for derived type component in intrinsic assign

2012-09-19 Thread Paul Richard Thomas
Dear Mikael, Thanks for the usually thorough review. snip And here comes the next round of comments. snip + e-rank = c c-as ? c-as-rank : 0; This is bogus if e-rank was != 0 previously (think of the case array(:)%scalar_comp). mistaken maybe but not bogus! The c ==

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch

2012-09-19 Thread Michael Meissner
On Tue, Sep 18, 2012 at 08:04:06PM -0400, David Edelsohn wrote: On Mon, Sep 17, 2012 at 3:51 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: This patch has support for all of the additonal cleanups I mentioned in the first patch that I hadn't gotten to. At this point, I am not

[google/gcc-4_7] fix race in __cxa_guard_acquire

2012-09-19 Thread Ollie Wild
This is a merge of r191125 and r191191 from gcc-4_7-branch. It fixes a race in __cxa_guard_acquire which can cause duplicate initialization of static variables within functions. Okay for google/gcc-4_7? Thanks, Ollie Google ref b/7173106. * libsupc++/guard.cc (__cxa_guard_acquire):

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Dehao Chen
This patch was commited as r191494. Thank all for the reviews and helping test. Dehao

Re: [google/gcc-4_7] fix race in __cxa_guard_acquire

2012-09-19 Thread Diego Novillo
On 2012-09-19 15:59 , Ollie Wild wrote: * libsupc++/guard.cc (__cxa_guard_acquire): Exit the loop earlier if we detect that another thread has had success. Don't compare_exchange from a finished state back to a waiting state. Fix up the last argument of the

Re: [Patch, fortran] PR46897 - [OOP] type-bound defined ASSIGNMENT(=) not used for derived type component in intrinsic assign

2012-09-19 Thread Mikael Morin
On 19/09/2012 20:46, Paul Richard Thomas wrote: + || comp1-attr.proc_pointer_comp That one doesn't look right. Why not? It skips any component containing a procedure pointer subcomponent. Actually, from looking at parse.c where the flag is set, it seems that the flag is only set for

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread Georg-Johann Lay
Joern Rennecke a écrit: Index: doc/md.texi === --- doc/md.texi (revision 191429) +++ doc/md.texi (working copy) @@ -665,6 +665,22 @@ (define_insn @end group @end smallexample +If you just need a little bit of C code in one (or

Re: [testsuite] vect effective targets should use arm_neon_ok

2012-09-19 Thread Janis Johnson
On 09/19/2012 01:43 AM, Richard Earnshaw wrote: On 18/09/12 21:59, Janis Johnson wrote: On 09/18/2012 12:54 PM, Janis Johnson wrote: In most cases a test that requires ARM NEON should use effective target arm_neon, which means that flags run for all tests include NEON support. The result is

Top Level GCC change questions

2012-09-19 Thread sellcey
While checking in some changes at the top-level of the GCC tree I remembered that these files are shared with the binutils tree. It looks like there is another patch that has not been checked in to the GCC top level tree but not binutils and a patch in binutils but not GCC. Is there any

Re: Backtrace library [1/3]

2012-09-19 Thread Ryan Mansfield
On 12-09-17 12:39 PM, Ian Lance Taylor wrote: On Thu, Sep 13, 2012 at 1:00 PM, Diego Novillo dnovi...@google.com wrote: On 2012-09-11 18:53 , Ian Lance Taylor wrote: 2012-09-11 Ian Lance Taylor i...@google.com * Initial implementation. OK. Thanks for all the reviews. I have

RE: [PATCH] Merging Cilk Plus into Trunk (Patch 1 of approximately 22)

2012-09-19 Thread Iyer, Balaji V
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Richard Henderson Sent: Tuesday, September 11, 2012 3:12 PM To: Iyer, Balaji V Cc: Richard Guenther; gcc-patches@gcc.gnu.org; Gabriel Dos Reis; Aldy Hernandez (al...@redhat.com);

Re: Use conditional casting with symtab_node

2012-09-19 Thread Gabriel Dos Reis
On Wed, Sep 19, 2012 at 1:39 PM, Lawrence Crowl cr...@googlers.com wrote: On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Sep 19, 2012 Richard Guenther richard.guent...@gmail.com wrote: Indeed. Btw, can we not provide a specialization for dynamic_cast ? This -try_...

Re: Top Level GCC change questions

2012-09-19 Thread DJ Delorie
Is there any automation for this or is it still up to each person checking in files to copy stuff over by hand? There is no automation, as neither project was willing to cede control to the other. In general, any patch applied to one repo should be (and may be) applied to the other, but at

Re: Top Level GCC change questions

2012-09-19 Thread Steve Ellcey
On Wed, 2012-09-19 at 17:15 -0400, DJ Delorie wrote: Is there any automation for this or is it still up to each person checking in files to copy stuff over by hand? There is no automation, as neither project was willing to cede control to the other. In general, any patch applied to one

Re: Use conditional casting with symtab_node

2012-09-19 Thread Lawrence Crowl
On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Wed, Sep 19, 2012 at 1:39 PM, Lawrence Crowl cr...@googlers.com wrote: On 9/19/12, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Sep 19, 2012 Richard Guenther richard.guent...@gmail.com wrote: Indeed. Btw, can we

[Patch, Fortran] PR54618 fix some INTENT(OUT) issues for CLASS

2012-09-19 Thread Tobias Burnus
This patch fixes a couple of issues, I run into when working on FINAL subroutines. a) PR54618: (i) For a nonallocatable CLASS(...),INTENT(OUT), gfortran is setting the the _def_init; however, for OPTIONAL this has to be guarded by an is-present check. (ii) For CLASS(...),ALLOCATABLE,

Re: [google] Added new dump flag -pmu to display pmu data in pass summaries (issue 6489092)

2012-09-19 Thread dehao
FYI. Dehao https://codereview.appspot.com/6489092/diff/4001/gcc/common.opt File gcc/common.opt (right): https://codereview.appspot.com/6489092/diff/4001/gcc/common.opt#newcode1688 gcc/common.opt:1688: -fpmu-profile-use=[pmuprofile.gcda] The pmu profile data file to use for pmu feedback.

Re: Backtrace library [1/3]

2012-09-19 Thread Ian Lance Taylor
On Wed, Sep 19, 2012 at 1:56 PM, Ryan Mansfield rmansfi...@qnx.com wrote: I'm hitting the following build issue /bin/sh ./libtool --tag=CC --mode=compile i686-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../libbacktrace -I ../../libbacktrace/../include -I ../../libbacktrace/../libgcc -I

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Michael Meissner
On Fri, Sep 14, 2012 at 11:03:34AM +0800, Dehao Chen wrote: Hi, I've integrated all the reviews from this thread (Thank you guys for helping refine this patch). Now the patch can pass all gcc testsuite as well as all spec2006 benchmarks (with LTO). Concerning memory consumption, for

Re: Backtrace library [1/3]

2012-09-19 Thread Ryan Mansfield
On 12-09-19 06:17 PM, Ian Lance Taylor wrote: On Wed, Sep 19, 2012 at 1:56 PM, Ryan Mansfield rmansfi...@qnx.com wrote: I'm hitting the following build issue /bin/sh ./libtool --tag=CC --mode=compile i686-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../../libbacktrace -I

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread amylaar
Quoting Georg-Johann Lay g...@gcc.gnu.org: + * return stack_mem_p (operands[0]) ? \push 0 : \clrmem %0\; ---^ Isn't there a backslash missing? Oops, yes, there is.

Re: Backtrace library [1/3]

2012-09-19 Thread Ian Lance Taylor
On Wed, Sep 19, 2012 at 3:31 PM, Ryan Mansfield rmansfi...@qnx.com wrote: $ head config.log This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by configure, which was generated by GNU Autoconf 2.64.

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Dehao Chen
Thanks for reporting. I'll fix them now. Dehao On Thu, Sep 20, 2012 at 6:29 AM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: On Fri, Sep 14, 2012 at 11:03:34AM +0800, Dehao Chen wrote: Hi, I've integrated all the reviews from this thread (Thank you guys for helping refine this

Re: Backtrace library [1/3]

2012-09-19 Thread Ryan Mansfield
On 12-09-19 06:58 PM, Ian Lance Taylor wrote: Thanks for the additional info. I have committed this patch, which should fix the problem. Bootstrapped and ran libbacktrace tests on x86_64-unknown-linux-gnu. Thanks Ian. This patch fixes the issue. Regards, Ryan Mansfield 2012-09-19 Ian

Re: [PATCH] Combine location with block using block_locations

2012-09-19 Thread Dehao Chen
The patch to fix this problem is attached. As I don't have machines other than x86, I cannot test it. But this patch seemed straightforward. I'll check it in in a couple of hours if no objection is received. Thanks, Dehao gcc/ChangeLog: 2012-09-19 Dehao Chen de...@google.com *

RFA: Fix PR rtl-optimization/38449 (patch updated)

2012-09-19 Thread Joern Rennecke
Bootstrapped in revision 191429 on i686-pc-linux-gnu. The arc.c context can be seen here: http://gcc.gnu.org/viewcvs/branches/arc-4_4-20090909-branch/gcc/config/arc/arc.c?content-type=text%2Fplainview=co The relevant code in arc.c hasn't changed in the port updated to GCC 4.8 . 2012-08-14

Go patch committed: Error for byte-order-mark in middle of file

2012-09-19 Thread Ian Lance Taylor
I should have looked at some more of the testsuite before my last patch. This patch to the Go frontend issues an error for a Unicode byte-order-mark in the middle of a Go file, while continuing to ignore it at the beginning of the file. Bootstrapped and ran Go testsuite on

Re: RFA: Process '*' in '@'-output-template alternatives

2012-09-19 Thread amylaar
Quoting Georg-Johann Lay g...@gcc.gnu.org: + * return stack_mem_p (operands[0]) ? \push 0 : \clrmem %0\; ---^ Isn't there a backslash missing? Attached is the amended patch. Again, bootstrapped on i686-pc-linux-gnu . 2011-09-19 Jorn

RE: [PATCH] Enable bbro for -Os

2012-09-19 Thread Zhenqiang Chen
-Original Message- From: Eric Botcazou [mailto:ebotca...@adacore.com] Sent: Thursday, September 13, 2012 10:31 PM To: Zhenqiang Chen Cc: gcc-patches@gcc.gnu.org; 'Steven Bosscher'; 'Richard Guenther' Subject: Re: [PATCH] Enable bbro for -Os The updated patched is attached. Is it

[v3] 28811, 54482

2012-09-19 Thread Benjamin De Kosnik
Fixes for various shared/static/pic issues, see SUBJECT. tested x86_64/linux tested x86_64/linux --with-pic tested x86_64/linux --without-pic* tested x86_64/linux --disable-shared tested x86_64/linux --disable-static earlier versions tested on cross arm-eabisim Most of these do what you'd

Re: [C++ Patch / RFC] PR 52432

2012-09-19 Thread Jason Merrill
OK. Jason

RFA: Fix COND_EXEC handling of dead_or_set_regno_p

2012-09-19 Thread Joern Rennecke
I've seen a number of execution failures with the soon-to-be submitted ARCompact port in the context of gcc 4.8, which where down to an rtlanal.c:dead_or_set_p problem, e.g.: gcc.c-torture/execute/builtin-bitops-1.c -O1 As the comment at the top of dead_or_set_p states, this function should

Go patch committed: Fix struct hash/equality with _ fields

2012-09-19 Thread Ian Lance Taylor
This patch to the Go frontend fixes the handling of struct hash and equality when the struct has _ fields. Those fields should not participate in the hash and equality functions at all. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Will commit to 4.7

  1   2   >