Re: [GSoC] the separate option for all dimensions

2014-08-12 Thread Roman Gareev
Checking for this specific AST may cause failures with future versions of isl that choose a different schedule. Could you write a regular expression that checks that there is no if-condition contained in a for loop? I think this best models the issue that was addressed in the original bug

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Dodji Seketeli
Marek Polacek pola...@redhat.com a écrit: diff --git gcc/testsuite/gcc.dg/concat.c gcc/testsuite/gcc.dg/concat.c index 0b9d6f6..e3bfd46 100644 --- gcc/testsuite/gcc.dg/concat.c +++ gcc/testsuite/gcc.dg/concat.c @@ -1,6 +1,7 @@ /* Copyright (C) 2001 Free Software Foundation, Inc. */

Re: [PATCH, i386] Remove use of vpmacsdql instruction from multiplication.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 7:23 AM, Gopalasubramanian, Ganesh ganesh.gopalasubraman...@amd.com wrote: +2014-06-10 Ganesh Gopalasubramanian +ganesh.gopalasubraman...@amd.com + + * config/i386/i386.c (ix86_expand_sse2_mulvxdi3): Issue +instructions vpmuludq and vpaddq instead of

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Marek Polacek
On Tue, Aug 12, 2014 at 08:17:15AM +0200, Dodji Seketeli wrote: Marek Polacek pola...@redhat.com a écrit: diff --git gcc/testsuite/gcc.dg/concat.c gcc/testsuite/gcc.dg/concat.c index 0b9d6f6..e3bfd46 100644 --- gcc/testsuite/gcc.dg/concat.c +++ gcc/testsuite/gcc.dg/concat.c @@ -1,6

Re: [PATH] Intel offload library

2014-08-12 Thread Andrey Turetskiy
All remarks from https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02166.html are fixed. Updated version of liboffloadmic you can find in GIT branch kyukhin/gomp4-offload: https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/kyukhin/gomp4-offload. Commit: HEAD~3 (Add liboffloadmic with

Re: [PATCH mips] Pass -msoft-float/-mhard-float flags to GAS

2014-08-12 Thread Eric Christopher
On Sat, Aug 9, 2014 at 12:00 PM, Matthew Fortune matthew.fort...@imgtec.com wrote: Moore, Catherine catherine_mo...@mentor.com writes: -Original Message- From: Steve Ellcey [mailto:sell...@mips.com] Sent: Friday, August 08, 2014 3:42 PM To: Moore, Catherine;

Re: [PATCH mips] Do not compile mips16.S in soft-float mode

2014-08-12 Thread Eric Christopher
-#ifdef __mips_micromips +#if defined(__mips_micromips) || defined(__mips_soft_float) /* DO NOTHING */ #else Mind adding a comment here explaining why we don't want to do anything for soft float (and micromips)? OK otherwise. Thanks! -eric

Re: [PATCH 3/3] gcc/ada/socket.c: Add conditionals for RTEMS

2014-08-12 Thread Arnaud Charlet
I think the best place is below this: #if defined (__vxworks) ! defined (__RTP__) #include sys/times.h #else #include sys/time.h #endif And just move the conditional from socket.c with comment. Yes, that looks right to me. Arno

[PATCH] Fix off-by-one in internal-fn.c

2014-08-12 Thread Yury Gribov
This is a fix for off-by-one bug that I've recently introduced in r213806. Bootstrapped, regtested and Asan-boostrapped on x64. Ok to commit? -Y commit cc88579f072240686605783229129700f9eb78a0 Author: Yury Gribov y.gri...@samsung.com Date: Mon Aug 11 19:30:24 2014 +0400 2014-08-12 Yury

Re: [PATCH] Fix off-by-one in internal-fn.c

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 11:17:48AM +0400, Yury Gribov wrote: This is a fix for off-by-one bug that I've recently introduced in r213806. Bootstrapped, regtested and Asan-boostrapped on x64. Ok to commit? Sure. 2014-08-12 Yury Gribov y.gri...@samsung.com gcc/ *

Re: [GSoC] the separate option for all dimensions

2014-08-12 Thread Tobias Grosser
On August 12, 2014 8:15:34 AM CEST, Roman Gareev gareevro...@gmail.com wrote: Checking for this specific AST may cause failures with future versions of isl that choose a different schedule. Could you write a regular expression that checks that there is no if-condition contained in a for loop? I

Re: [PATCH] Fix off-by-one in internal-fn.c

2014-08-12 Thread Yury Gribov
On 08/12/2014 11:20 AM, Jakub Jelinek wrote: This is a fix for off-by-one bug that I've recently introduced in r213806. Bootstrapped, regtested and Asan-boostrapped on x64. Ok to commit? Sure. Done, r213848. -Y

[C++ patch] Reject virt-specifiers on friends and member templates

2014-08-12 Thread Ville Voutilainen
We shouldn't allow friend declarations and member templates to have virt-specifiers, as neither of those can be virtual. Tested on Linux x86-64. Note that the standardese can be squinted at in a way that would allow virt-specifiers on friends, there's a DR coming for that. I do not expect the

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Gary Benson
Jakub Jelinek wrote: On Mon, Aug 11, 2014 at 05:04:20PM +0100, Gary Benson wrote: + case 's': + seed = atoi (optarg); + break; + + case 't': + timeout = atoi (optarg); + break; + + case 'm': + maxcount = atoi (optarg); + break; + } +}

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 10:02:40AM +0100, Gary Benson wrote: I've removed the timeout code. Users can limit the run by setting a maximum number of iterations. That's more consistent for testing anyway: 500 iterations is 500 iterations wherever you run it. How about this one? LGTM,

RE: [PATCH mips] Pass -msoft-float/-mhard-float flags to GAS

2014-08-12 Thread Matthew Fortune
Eric Christopher echri...@gmail.com writes: On Sat, Aug 9, 2014 at 12:00 PM, Matthew Fortune matthew.fort...@imgtec.com wrote: Moore, Catherine catherine_mo...@mentor.com writes: -Original Message- From: Steve Ellcey [mailto:sell...@mips.com] Sent: Friday, August 08, 2014 3:42

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Dodji Seketeli
Marek Polacek pola...@redhat.com a écrit: Thise testcases use predefined identifiers, and without the dg-options, they would compile with -ansi -pedantic-errors and fail. Setting dg-options to makes the -ansi -pedantic-errors go away. Setting it to e.g. -std=gnu99 would work as well. Oh, I

Re: [PATCH, ARM] Keep constants in register when expanding

2014-08-12 Thread Richard Earnshaw
On 05/08/14 10:31, Zhenqiang Chen wrote: Hi, For some large constants, ARM will split them during expanding, which makes impossible to hoist them out the loop or shared by different references (refer the test case in the patch). The patch keeps some constants in registers. If the constant

[PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Thomas Preud'homme
Hi, As mentioned in PR60070, there is many cases when a programmer want to ensure that a program does not use any floating point data type. Other cases to consider is when a target has several floating point ABI and user want to ensure his/her is compatible with all available floating point ABI.

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Gary Benson
Jakub Jelinek wrote: On Tue, Aug 12, 2014 at 10:02:40AM +0100, Gary Benson wrote: I've removed the timeout code. Users can limit the run by setting a maximum number of iterations. That's more consistent for testing anyway: 500 iterations is 500 iterations wherever you run it.

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 05:25:25PM +0800, Thomas Preud'homme wrote: --- a/gcc/c/c-parser.c +++ b/gcc/c/c-parser.c @@ -486,6 +486,15 @@ c_token_starts_typename (c_token *token) case CPP_KEYWORD: switch (token-keyword) { + case RID_FLOAT: + case RID_DOUBLE: +

Re: [RFC/Patch] Latent issue in cp_parser_template_id

2014-08-12 Thread Paolo Carlini
Hi, On 08/11/2014 08:22 PM, Jason Merrill wrote: OK with a comment explaining how we can get there. Thanks. I'm going to apply the below, then. I suppose the simple parser-scope clean up ( https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01000.html) is also Ok, I would rather commit both

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Marek Polacek
On Tue, Aug 12, 2014 at 11:34:35AM +0200, Jakub Jelinek wrote: On Tue, Aug 12, 2014 at 05:25:25PM +0800, Thomas Preud'homme wrote: --- a/gcc/c/c-parser.c +++ b/gcc/c/c-parser.c @@ -486,6 +486,15 @@ c_token_starts_typename (c_token *token) case CPP_KEYWORD: switch

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Marek Polacek
On Tue, Aug 12, 2014 at 05:25:25PM +0800, Thomas Preud'homme wrote: @@ -10078,6 +10078,10 @@ finish_declspecs (struct c_declspecs *specs) } else if (specs-complex_p) { + if (flag_no_float) + error_at (specs-locations[cdw_complex], + use of

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Marc Glisse
On Tue, 12 Aug 2014, Thomas Preud'homme wrote: As mentioned in PR60070, there is many cases when a programmer want to ensure that a program does not use any floating point data type. Other cases to consider is when a target has several floating point ABI and user want to ensure his/her is

Re: [C PATCH] Tidy up pedwarn_c90 (take 2)

2014-08-12 Thread Marek Polacek
This then is the version with both issues fixed (and new test). Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-08-12 Marek Polacek pola...@redhat.com gcc/c-family/ * c-opts.c (sanitize_cpp_opts): Make warn_long_long be set according to warn_c90_c99_compat.

Re: [C PATCH] Implement -Wc99-c11-compat (take 2)

2014-08-12 Thread Marek Polacek
And now the version with two bugs mention elsewhere fixed as well. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-08-12 Marek Polacek pola...@redhat.com * doc/invoke.texi: Document -Wc99-c11-compat. c-family/ * c.opt (Wc99-c11-compat): New option. c/ *

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 11:47:28AM +0200, Marc Glisse wrote: Are you sure you want something that strict? If there are floats in the code but the compiler manages to get rid of them, it won't cause any trouble with the ABI. Besides, if you #include a header that declares a function returning a

[PATCH AArch64 1/2] Add execution tests of vget_low and vget_high

2014-08-12 Thread Alan Lawrence
Following patch replaces the current temporary inline assembler implementation of vget_high. So this patch adds a test first. We don't have any test coverage of vget_low, either, so add that too. Passing on aarch64-none-elf and aarch64_be-none-elf. diff --git

[PATCH AArch64 2/2] Replace temporary inline assembler for vget_high

2014-08-12 Thread Alan Lawrence
This patch replaces the current inline assembler for the vget_high intrinsics in arm_neon.h with a sequence of other calls, in a similar fashion to vget_low. Unlike the assembler, these are all transparent to the front-end, so should enable better optimization through the mid-end. Tested

[PATCH][match-and-simplify] Mark conditional converts with '?'

2014-08-12 Thread Richard Biener
The following patch forces you to write convert?, convert1? or convert2? to get a conditional convert. Committed. Richard. 2014-08-12 Richard Biener rguent...@suse.de * genmatch.c (enum tree_code): Add CONVERT0. (main): Likewise. (parse_operation): Handle conditional

RE: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Thomas Preud'homme
From: Marc Glisse [mailto:marc.gli...@inria.fr] Sent: Tuesday, August 12, 2014 5:47 PM Are you sure you want something that strict? If there are floats in the code but the compiler manages to get rid of them, it won't cause any trouble with the ABI. Besides, if you #include a header that

[PATCH i386 AVX512] [5/n] Adjust register's availabilty, allow wider masks.

2014-08-12 Thread Kirill Yukhin
Hello, Attached patch allows wider mask types. Is it ok for trunk? Bootstrapped. gcc/ * config/i386/i386.c (print_reg): Сorrectly print 64-bit mask registers. (inline_secondary_memory_needed): Allow 64 bit wide mask registers. (ix86_hard_regno_mode_ok): Allow

Re: [PATCH][match-and-simplify] Mark conditional converts with '?'

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 12:15:20PM +0200, Richard Biener wrote: @@ -2422,6 +2441,7 @@ main(int argc, char **argv) add_operator (SYM, # SYM, # TYPE, NARGS); #define END_OF_BASE_TREE_CODES #include tree.def +add_operator (CONVERT1, CONVERT0, tcc_unary, 1); Pasto? Shouldn't that be

[PATCH i386 AVX512] [6/n] Update prefered modes for vectorizer.

2014-08-12 Thread Kirill Yukhin
Hello, Patch allows wider vec int modes. Bootstrapped. Is it ok for trunk? gcc/ * config/i386/i386.c (ix86_preferred_simd_mode): Allow V64QImode and V32HImode. -- Thanks, K diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 5a3b67a..183b7be 100644 ---

Re: [PATCH][match-and-simplify] Mark conditional converts with '?'

2014-08-12 Thread Richard Biener
On Tue, 12 Aug 2014, Jakub Jelinek wrote: On Tue, Aug 12, 2014 at 12:15:20PM +0200, Richard Biener wrote: @@ -2422,6 +2441,7 @@ main(int argc, char **argv) add_operator (SYM, # SYM, # TYPE, NARGS); #define END_OF_BASE_TREE_CODES #include tree.def +add_operator (CONVERT1, CONVERT0,

Re: [GSoC][match-and-simplify] Add abs_expr pattern

2014-08-12 Thread Richard Biener
On Tue, Aug 12, 2014 at 12:58 AM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Add pattern: abs (abs (x)) - abs (x) * match.pd: Add new pattern. Thanks - applied. Richard. [gcc/testsuite/gcc.dg/tree-ssa] * match.c: New test-case. Thanks, Prathamesh

[PATCH i386 AVX512] [7/n] Extend mask logic.

2014-08-12 Thread Kirill Yukhin
Hello, This patch extends support of masking instructions. Bootstrapped. Is it ok for trunk? gcc/ * config/i386/i386.md (define_attr isa): Add avx512bw,noavx512bw. (define_attr enabled): Ditto. (define_split): Add 32/64-bit mask logic. (define_insn

Re: PR tree-optimization/52904 testcase

2014-08-12 Thread Richard Biener
On Tue, Aug 12, 2014 at 4:51 AM, Kugan kugan.vivekanandara...@linaro.org wrote: On 11/08/14 18:03, Richard Biener wrote: On Sat, Aug 9, 2014 at 2:33 PM, Kugan kugan.vivekanandara...@linaro.org wrote: Hi, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52904 Tescase was generating warning:

[build] Restore Sun as COMDAT group support

2014-08-12 Thread Rainer Orth
While looking at another failure, I noticed that COMDAT group support on Solaris with Sun as has been accidentally disabled for quite some time by this patch: https://gcc.gnu.org/ml/gcc-patches/2012-08/msg01847.html Unfortunately, the fix was anything but obvious: by setting

[testsuite] XFAIL g++.dg/debug/dwarf2/nested-4.C on Solaris with Sun as

2014-08-12 Thread Rainer Orth
Once COMDAT group support on Solaris 11+ with Sun as got re-enabled https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01120.html g++.dg/debug/dwarf2/nested-4.C is FAILing in that configuration: FAIL: g++.dg/debug/dwarf2/nested-4.C -std=gnu++98 scan-assembler-times debug_types 2 FAIL:

Re: PR tree-optimization/52904 testcase

2014-08-12 Thread Kugan
Did you verify the testcase fails before the revision that fixed it? Esp. the placement of the dg-bogus looks bogus to me. I tried it on Linaro 4.9 (It should be the same in fsf gcc 4.9 branch) and the test cases is failing there. Passes on trunk. Well, it probably fails because of excess

[PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-12 Thread Kirill Yukhin
Hello, This patch extends substs/subst_attrs to be used with new patterns. Bootstrapped. Is it ok for trunk? gcc/ * config/i386/sse.md: Allow V64QI, V32QI, V32HI, V4HI modes. * config/i386/subst.md (define_mode_iterator SUBST_V): Update. (define_mode_iterator

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Ian Lance Taylor
On Tue, Aug 12, 2014 at 2:02 AM, Gary Benson gben...@redhat.com wrote: +#include demangle.h Include demangle.h with . +int +main (int argc, char *argv[]) +{ + char symbol[2 + MAXLEN + 1] = _Z; + int seed = -1, seed_set = 0; + int count = 0, maxcount = -1; I think that by default the

[PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Joel Sherrill
This didn't get any comments earlier. Is it OK to comment? Somewhere along the way, the Ada run-time Makefile's quit honoring CFLAGS_FOR_TARGET. This just adds it back. 2014-08-12 Joel Sherrill joel.sherr...@oarcorp.com * Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C. ---

[PATCH 2/2] gcc/ada/socket.c, gsocket.h: Add conditionals for RTEMS

2014-08-12 Thread Joel Sherrill
Hopefully this addresses the comments. OK to comment? 2014-08-12 Joel Sherrill joel.sherr...@oarcorp.com * socket.c: For RTEMS, use correct prototype of gethostbyname_r(). * gsocket.h Add include of unistd.h on RTEMS. --- gcc/ada/gsocket.h | 5 + gcc/ada/socket.c | 2 +-

[Patch ARM] Fix PR target/62098 - vcvt generation.

2014-08-12 Thread Ramana Radhakrishnan
Hi, This fixes the issue in PR target/62098 where the pattern is clearly bogus and it's not clear what I was thinking when I ok'd it. The vcvt instruction in this form writes to it's source register and this should have been modelled correctly in the backend in this form rather than the

[PATCH AArch64 1/3] Don't disparage add/sub in SIMD registers

2014-08-12 Thread Alan Lawrence
(It is no more expensive.) gcc/ChangeLog: * config/aarch64/aarch64.md (subdi3, adddi3_aarch64): Don't penalize SIMD reg variant.diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index

[PATCH AArch64 2/3] Add SIMD-reg variants of logical operators and/ior/xor/not

2014-08-12 Thread Alan Lawrence
This patch adds SIMD register variants for and, ior, xor and not - similarly to add/sub, the H/W supports it, and it'll be more efficient if the values are there already, e.g. if passed as [u]int64x1_t parameters. gcc/ChangeLog: * config/aarch64/aarch64.md (optabmode3, one_cmplmode2):

[PATCH AArch64 0/3] Optimizations for 64x1 vectors, also fixes/enables XOR

2014-08-12 Thread Alan Lawrence
Following the change to make arm_neon.h's (u?)int64x1_t types into vectors, these types are now passed in the SIMD registers rather than general purpose registers, which often results in poor quality code in functions taking or returning these types. Often values are moved from vector registers

[PATCH AArch64 3/3] Fix XOR_one_cmpl pattern; add SIMD-reg variants for BIC,ORN,EON

2014-08-12 Thread Alan Lawrence
[When I wrote that xor was broken on GPRs and this fixes it, I meant xor_one_cmpl rather than xor, sorry!] The pattern for xor_one_cmpl never matched, due to the action of combine_simplify_rtx; hence, separate this pattern out from that for ORN/BIC. ORN/BIC have equivalent SIMD-reg variants,

RE: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Joseph S. Myers
On Tue, 12 Aug 2014, Thomas Preud'homme wrote: 3) __builtin_sqrt True, I shall try if it works with builtins. Thanks for the advice. In addition to built-in functions, you have built-in typedefs. I don't think your code would catch uses of __fp16, __float128 etc. (such types are defined

Re: [PATCH AArch64 3/3] Fix XOR_one_cmpl pattern; add SIMD-reg variants for BIC,ORN,EON

2014-08-12 Thread Alan Lawrence
...patch attached... Alan Lawrence wrote: [When I wrote that xor was broken on GPRs and this fixes it, I meant xor_one_cmpl rather than xor, sorry!] The pattern for xor_one_cmpl never matched, due to the action of combine_simplify_rtx; hence, separate this pattern out from that for ORN/BIC.

RE: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Joseph S. Myers
On Tue, 12 Aug 2014, Thomas Preud'homme wrote: However it's true that it prevents including math.h for instance. And stdlib.h (strtod) and time.h (difftime) and wchar.h (wcstod). Is that your intent? Note that glibc stdlib.h has an atof inline definition, it's not just a matter of

[Patch ARM] Fix PR target/61413 - definition of __ARM_SIZEOF_WCHAR_T

2014-08-12 Thread Ramana Radhakrishnan
Hi, The ACLE http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf expects this macro to be defined in terms of byte sizes but we return bit sizes *and* additionally do not handle -fshort-wchar. Applied to trunk. regards Ramana 2014-08-12 Ramana Radhakrishnan

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Marek Polacek
On Mon, Aug 11, 2014 at 01:25:37PM -0400, Jason Merrill wrote: +convert_like_real (location_t loc, conversion *convs, tree expr, tree fn, + int argnum, int inner, bool issue_conversion_warnings, bool c_cast_p, tsubst_flags_t complain) { tree totype =

[patch] Overload std::getline for rvalue streams

2014-08-12 Thread Jonathan Wakely
We're missing these overloads required by C++11. Tested x86_64-linux, committed to trunk. I think this should go on the branches too, any objections? commit c904682994e3c1d77abe16a4a7366e191b6ef6bc Author: Jonathan Wakely jwak...@redhat.com Date: Tue Aug 12 15:24:35 2014 +0100 *

[PATCH 2/2] Emit DW_tag_restrict_type for restrict-qualified pointers.

2014-08-12 Thread Mark Wielaard
Ping. Rebased patch to current gcc master. gcc/ChangeLog PR debug/59051 * dwarf2out.h (modified_type_die): Handle TYPE_QUAL_RESTRICT. gcc/testsuite/ChangeLog PR debug/59051 * gcc.dg/guality/restrict.c: New test. --- gcc/ChangeLog | 5

[PATCH 1/2] dwarf2out.c: Pass one cv_quals argument instead of two for const and volatile.

2014-08-12 Thread Mark Wielaard
Ping. Rebased patch to current gcc master. modified_type_die and add_type_attribute take two separate arguments for whether the type should be const and/or volatile. To help add more type modifiers pass the requested modifiers as one cv_quals argument to these functions. And introduce helper

Add ODR violation warnings about virtual table mismatches

2014-08-12 Thread Jan Hubicka
Hi, this patch adds warning on mismatching virtual tables. It is update/rewrite of my earlier version https://gcc.gnu.org/ml/gcc-patches/2014-02/msg00741.html The main difference is that we no longer stream all variable initializers, so the new code uses ipa-reference instead of walk of the

Re: [PATCH mips] Do not compile mips16.S in soft-float mode

2014-08-12 Thread Steve Ellcey
On Tue, 2014-08-12 at 00:07 -0700, Eric Christopher wrote: -#ifdef __mips_micromips +#if defined(__mips_micromips) || defined(__mips_soft_float) /* DO NOTHING */ #else Mind adding a comment here explaining why we don't want to do anything for soft float (and micromips)? OK

[PATCH 1/2] DWARFv5 Emit DW_TAG_atomic_type.

2014-08-12 Thread Mark Wielaard
Ping. This patch is based on the proposed patches to support the restrict type. But isn't meant to be integrated at this time. DWARFv5 is still only a collection of proposals and hasn't seen any draft yet. But feedback is highly appreciated. Also if there are tips on how (and where) to maintain an

[PATCH 2/2] DWARF5: Add DW_TAG_aligned_type support.

2014-08-12 Thread Mark Wielaard
Ping. As with the patch for DW_TAG_atomic_type this is only experimental at this time, but feedback appreciated. There is a corresponding patch for GDB: https://sourceware.org/ml/gdb-patches/2014-07/msg00199.html gcc/ChangeLog * dwarf2out.c (decl_user_align): New function.

Re: [patch] Overload std::getline for rvalue streams

2014-08-12 Thread Jonathan Wakely
On 12/08/14 16:20 +0100, Jonathan Wakely wrote: We're missing these overloads required by C++11. Tested x86_64-linux, committed to trunk. I missed an 'inline' on one of the new overloads, fixed by this patch, which I'll commit once testing finishes. commit

Re: [PATCH AArch64 1/3] Don't disparage add/sub in SIMD registers

2014-08-12 Thread pinskia
On Aug 12, 2014, at 7:40 AM, Alan Lawrence alan.lawre...@arm.com wrote: (It is no more expensive.) Yes on some processors it could be. Thanks, Andrew gcc/ChangeLog: * config/aarch64/aarch64.md (subdi3, adddi3_aarch64): Don't penalize SIMD reg variant. diff --git

[PING][PATCH] Add patch for debugging compiler ICEs.

2014-08-12 Thread Maxim Ostapenko
Ping. -Maxim Original Message Subject:[PATCH] Add patch for debugging compiler ICEs. Date: Mon, 04 Aug 2014 21:03:22 +0400 From: Maxim Ostapenko m.ostape...@partner.samsung.com To: GCC Patches gcc-patches@gcc.gnu.org CC: Jeff Law l...@redhat.com, Jakub Jelinek

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 11:09 AM, Marek Polacek wrote: One possibility (and I think you mentioned this at Cauldron) would be to create a new tree code, called e.g. LOCATION_EXPR. I don't think it needs a new code: I think we can use VIEW_CONVERT_EXPR for decls and NOP_EXPR for constants. There will

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Paolo Carlini
Hi, On 08/12/2014 05:09 PM, Marek Polacek wrote: Furthermore, the arguments should have their own locations in EXPR_LOCATION; I don't think we need to track them separately. If their locations are wrong that's something to fix directly, rather than adding a special case for function arguments.

Re: [GOOGLE] Do not partition the cold/hot sections of a function with section attribute

2014-08-12 Thread Teresa Johnson
On Mon, Aug 11, 2014 at 1:44 PM, Yi Yang ahyan...@google.com wrote: I ported this to trunk. Shall I commit this patch to the Google 4_8/4_9 branches first? Ok with me. Teresa On Mon, Aug 11, 2014 at 12:46 PM, Teresa Johnson tejohn...@google.com wrote: Ok, thanks. This seems reasonable. Can

Re: [C++ patch] Reject virt-specifiers on friends and member templates

2014-08-12 Thread Ville Voutilainen
On 12 August 2014 11:47, Ville Voutilainen ville.voutilai...@gmail.com wrote: We shouldn't allow friend declarations and member templates to have virt-specifiers, as neither of those can be virtual. Tested on Linux x86-64. Note that the standardese can be squinted at in a way that would allow

Re: [PATCH] Fix for PR62037

2014-08-12 Thread Felix Yang
Hi Richard, I find that you missed the testcase with when committing the patch. GCC 4.8 4.9 branch also has the same issue, may be we need to fix for them too? Cheers, Felix On Mon, Aug 11, 2014 at 7:24 PM, Richard Biener richard.guent...@gmail.com wrote: On Sat, Aug 9, 2014 at 6:28

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Joseph S. Myers
On Tue, 12 Aug 2014, Jason Merrill wrote: On 08/12/2014 11:09 AM, Marek Polacek wrote: One possibility (and I think you mentioned this at Cauldron) would be to create a new tree code, called e.g. LOCATION_EXPR. I don't think it needs a new code: I think we can use VIEW_CONVERT_EXPR for

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 12:48 PM, Joseph S. Myers wrote: For C, it is definitely expected within the front end that anything that is an integer constant expression is an INTEGER_CST and that a NOP_EXPR wrapping an INTEGER_CST is something folded to an integer constant that is neither an integer constant

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 12:22 PM, Paolo Carlini wrote: why wrapping (somebody also suggested a NOP_EXPR at some point ;) instead of simply changing integer_cst co to natively have a location?!? That also seems like a possibility, though I don't know to what extent different parts of the compiler rely

Re: [C++ patch] Reject virt-specifiers on friends and member templates

2014-08-12 Thread Jason Merrill
Applied, thanks. Jason

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Manuel López-Ibáñez
On Tue, 12 Aug 2014, Jason Merrill wrote: On 08/12/2014 11:09 AM, Marek Polacek wrote: One possibility (and I think you mentioned this at Cauldron) would be to create a new tree code, called e.g. LOCATION_EXPR. I don't think it needs a new code: I think we can use VIEW_CONVERT_EXPR for

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Gary Benson
Ian Lance Taylor wrote: On Tue, Aug 12, 2014 at 2:02 AM, Gary Benson gben...@redhat.com wrote: +#include demangle.h Include demangle.h with . Ok. +int +main (int argc, char *argv[]) +{ + char symbol[2 + MAXLEN + 1] = _Z; + int seed = -1, seed_set = 0; + int count = 0,

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Ian Lance Taylor
On Tue, Aug 12, 2014 at 10:11 AM, Gary Benson gben...@redhat.com wrote: Ian Lance Taylor wrote: I think that by default the program should stop. That will make it possible to eventually run as part of make check. Give it some number of iterations that stops it in a second or so. You can

[PATCH] Fix some typos

2014-08-12 Thread Sylvestre Ledru
Hello The patch fixes some typos found by Lintian, the Debian static analyzer. (it is mainly the opportunity to test my commit permissions). Thanks, Sylvestre libstdc++-v3/ChangeLog: 2014-08-12 Sylvestre Ledru sylves...@debian.org * include/profile/impl/profiler_hash_func.h: Fix a

Re: [PATCH 2/2] gcc/ada/socket.c, gsocket.h: Add conditionals for RTEMS

2014-08-12 Thread Arnaud Charlet
Hopefully this addresses the comments. OK to comment? 2014-08-12 Joel Sherrill joel.sherr...@oarcorp.com * socket.c: For RTEMS, use correct prototype of gethostbyname_r(). * gsocket.h Add include of unistd.h on RTEMS. OK

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
This didn't get any comments earlier. Is it OK to comment? This one is a bit tricky so requires more thoughts. On which targets did you test it? Somewhere along the way, the Ada run-time Makefile's quit honoring CFLAGS_FOR_TARGET. This just adds it back. 2014-08-12 Joel Sherrill

Re: [PATCH] Fix some typos

2014-08-12 Thread Arnaud Charlet
gcc/ada/ChangeLog: 2014-08-12 Sylvestre Ledru sylves...@debian.org * 9drpc.adb: Fix a typo * s-interr.ads: Likewise * s-taskin.ads: Likewise * s-traces.ads: Likewise * sysdep.c: Likewise The Ada part is OK.

Re: [PATCH] Fix some typos

2014-08-12 Thread Marc Glisse
On Tue, 12 Aug 2014, Sylvestre Ledru wrote: The patch fixes some typos found by Lintian, the Debian static analyzer. Did you check them yourself? We end up with these information which doesn't seem correct to me. -- Marc Glisse

RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Steve Ellcey
After talking to Jeff Law at the GCC Cauldron I have updated my switch shortcut plugin pass to try and address this optimization in the hopes of getting it added to GCC as a static pass. I fixed the code to build with the various C++ changes that have been happening in GCC but the current version

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Joseph S. Myers
On Sun, 10 Aug 2014, Marek Polacek wrote: We weren't properly diagnosing neither the __func__ (introduced in C99), nor the __FUNCTION__/__PRETTY_FUNCTION__ (GNU extension) predefined identifiers. I believe we should; the compiler ought to have a compile-time switch for turning off

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-12 Thread Joseph S. Myers
On Mon, 11 Aug 2014, Sylvestre Ledru wrote: The test Wmissing-return2.c only has one of the two warnings. But as per -Wreturn-type = Run both, and for backwards compatibility with the existing definition of -Wreturn-type, both warnings should appear for this test. Make sense.

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 01:10 PM, Manuel López-Ibáñez wrote: Wouldn't the folding that already occurs in the FEs prevent this anyway? Currently, probably. But we're planning to delay that folding for other reasons. In any case, we don't need to fix location info for constants/decls in order to fix

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-12 Thread Sylvestre Ledru
On 12/08/2014 19:48, Joseph S. Myers wrote: On Mon, 11 Aug 2014, Sylvestre Ledru wrote: The test Wmissing-return2.c only has one of the two warnings. But as per -Wreturn-type = Run both, and for backwards compatibility with the existing definition of -Wreturn-type, both warnings should

Re: [PATCH i386 AVX512] [5/n] Adjust register's availabilty, allow wider masks.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 12:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, Attached patch allows wider mask types. Is it ok for trunk? Bootstrapped. gcc/ * config/i386/i386.c (print_reg): Сorrectly print 64-bit mask registers.

Re: [PATCH i386 AVX512] [6/n] Update prefered modes for vectorizer.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 12:49 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, Patch allows wider vec int modes. Bootstrapped. Is it ok for trunk? gcc/ * config/i386/i386.c (ix86_preferred_simd_mode): Allow V64QImode and V32HImode. OK. Thanks, Uros.

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 10:46:46AM -0700, Steve Ellcey wrote: --- /dev/null +++ b/gcc/tree-switch-shortcut.c +/* This file implements an optimization where, when a variable is set + to a constant value and there is a path that leads from this definition + to a switch statement that uses

Re: [PATCH mips] Do not compile mips16.S in soft-float mode

2014-08-12 Thread Eric Christopher
Thanks! -eric On Tue, Aug 12, 2014 at 8:33 AM, Steve Ellcey sell...@mips.com wrote: On Tue, 2014-08-12 at 00:07 -0700, Eric Christopher wrote: -#ifdef __mips_micromips +#if defined(__mips_micromips) || defined(__mips_soft_float) /* DO NOTHING */ #else Mind adding a comment

Re: [PATCH i386 AVX512] [7/n] Extend mask logic.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 1:29 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: This patch extends support of masking instructions. Bootstrapped. Is it ok for trunk? gcc/ * config/i386/i386.md (define_attr isa): Add avx512bw,noavx512bw. (define_attr enabled):

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 2:58 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, This patch extends substs/subst_attrs to be used with new patterns. Bootstrapped. Is it ok for trunk? In a couple of places, MODE_SIZE checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Jeff Law
On 08/12/14 11:46, Steve Ellcey wrote: After talking to Jeff Law at the GCC Cauldron I have updated my switch shortcut plugin pass to try and address this optimization in the hopes of getting it added to GCC as a static pass. I fixed the code to build with the various C++ changes that have been

[PATCH] fix FTBFS with --target=i686-pc-cygwin

2014-08-12 Thread Yaakov Selkowitz
There is a syntax error in r213009 causing a FTBFS in trunk with --target=i686-pc-cygwin. Patch attached, with which trunk now builds for said target. -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc. 2014-08-12 Yaakov Selkowitz yselk...@redhat.com *

Re: [PATCH] fix FTBFS with --target=i686-pc-cygwin

2014-08-12 Thread Kai Tietz
2014-08-12 20:34 GMT+02:00 Yaakov Selkowitz yselk...@redhat.com: There is a syntax error in r213009 causing a FTBFS in trunk with --target=i686-pc-cygwin. Patch attached, with which trunk now builds for said target. -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc. Patch

[Patch] Enable libatomic for cygwin targets

2014-08-12 Thread Yaakov Selkowitz
The attached patch enabled libatomic for Cygwin targets. check-target-libatomic for i686-pc-cygwin: Running gcc/libatomic/testsuite/libatomic.c/c.exp ... === libatomic Summary === # of expected passes44 # of unsupported tests 5 check-target-libatomic

Re: [Patch] Enable libatomic for cygwin targets

2014-08-12 Thread Kai Tietz
2014-08-12 20:40 GMT+02:00 Yaakov Selkowitz yselk...@redhat.com: The attached patch enabled libatomic for Cygwin targets. check-target-libatomic for i686-pc-cygwin: Running gcc/libatomic/testsuite/libatomic.c/c.exp ... === libatomic Summary === # of expected passes

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Marek Polacek
On Tue, Aug 12, 2014 at 05:46:09PM +, Joseph S. Myers wrote: On Sun, 10 Aug 2014, Marek Polacek wrote: We weren't properly diagnosing neither the __func__ (introduced in C99), nor the __FUNCTION__/__PRETTY_FUNCTION__ (GNU extension) predefined identifiers. I believe we should; the

  1   2   >