Re: [patch] Why xstrdup cgraph node names for dumpfiles?

2014-08-27 Thread Jan Hubicka
On Tue, Aug 26, 2014 at 10:52 PM, Uros Bizjak wrote: Hello! I noticed most of the cgraph and IPA files use xstrdup for cgraph node names when printing to dump_file. Very leaky... What is the reason for all those xstrdups? I couldn't think of any. Please see [1] and [2]. [1]

[PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
Hi, as reported in PR62248 there is a typo in gcc/config.gcc where --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in config.gcc). Here is the patch to fix it. Thanks, Yvan 2014-08-27 Yvan Roux yvan.r...@linaro.org * config.gcc: Fix fp-armv8 option for arm*-*-*

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
Hi again, On 08/26/2014 08:58 PM, Jason Merrill wrote: On 08/26/2014 12:01 PM, Paolo Carlini wrote: the difference, for the latter and for more complex cases, is that adjust_temp_type calls cp_fold_convert which ends up returning a NOP_EXPR (eg, build in fold_convert_loc). Perhaps we should

[PATCH GCC]Cleanup interface of iv_ca_add_use and the calls to it

2014-08-27 Thread Bin Cheng
Hi, As I analyzed in bug pr62178, current candidate selecting algorithm can't find out the optimal solution in some scenarios. I am trying to improve it but before that, I need to clean up the interface of iv_ca_add_use and the calls to it. The two calls to the function are controlled by a

Re: [PATCH GCC]Cleanup interface of iv_ca_add_use and the calls to it

2014-08-27 Thread Richard Biener
On Wed, Aug 27, 2014 at 10:10 AM, Bin Cheng bin.ch...@arm.com wrote: Hi, As I analyzed in bug pr62178, current candidate selecting algorithm can't find out the optimal solution in some scenarios. I am trying to improve it but before that, I need to clean up the interface of iv_ca_add_use and

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
.. two additional remarks (maybe obvious, I don't know): - It also appears to work - for sure for all the tests in c++/52892 + the tests in c++/52282 not involving data members (eg, the original one) - simply unconditionally calling STRIP_NOPS right after the cxx_eval_constant_expression at

Re: [PATCH i386 AVX512] [19-1/n] Fix shuf*64x2 assembler operand.

2014-08-27 Thread Kirill Yukhin
Hello Uroš, On 20 Aug 15:16, Uros Bizjak wrote: OK with this change. I've discovered a problem with assembler operand of vshuf*64x2 insn. Patch below bootstrapped and avx512-regtested. Is it ok for trunk? gcc/ * config/i386/sse.md (define_mode_attr concat_tg_mode): Move up.

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Richard Earnshaw
On 27/08/14 09:04, Yvan Roux wrote: Hi, as reported in PR62248 there is a typo in gcc/config.gcc where --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in config.gcc). Here is the patch to fix it. Thanks, Yvan 2014-08-27 Yvan Roux yvan.r...@linaro.org *

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Uros Bizjak
Hello! 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set the promoted mode. (promoted_for_signed_and_unsigned_p): New function. (expand_expr_real_1): Check promoted_for_signed_and_unsigned_p and set the

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Richard Biener
On Wed, Aug 27, 2014 at 12:01 PM, Uros Bizjak ubiz...@gmail.com wrote: Hello! 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set the promoted mode. (promoted_for_signed_and_unsigned_p): New function.

[PATCH PR62151]Fix uninitialized register issue caused by distribute_notes in combine pass

2014-08-27 Thread Bin Cheng
Hi As reported in bug pr62151, combine pass may wrongly delete necessary instruction in function distribute_notes thus leaving register uninitialized. This patch is to fix the issue by checking if i2 immediately modifies the register in REG_DEAD note. If yes, set tem_insn accordingly to start

[PATCH][match-and-simplify] Fail more gracefully when encountering EOF

2014-08-27 Thread Richard Biener
This fixes the segfaults when an unexpected EOF occurs. Committed. Richard. 2014-08-27 Richard Biener rguent...@suse.de * genmatch.c (peek): Fail at unexpected EOF. (main): Do not peek at the next token as we do expect EOF at some point. Index: gcc/genmatch.c

Re: [PATCH i386 AVX512] [19-1/n] Fix shuf*64x2 assembler operand.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 11:11 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: OK with this change. I've discovered a problem with assembler operand of vshuf*64x2 insn. Patch below bootstrapped and avx512-regtested. Is it ok for trunk? OK with a couple of nits. Thanks, Uros. gcc/

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Richard Biener
On Wed, Aug 27, 2014 at 12:25 PM, Uros Bizjak ubiz...@gmail.com wrote: On Wed, Aug 27, 2014 at 12:07 PM, Richard Biener richard.guent...@gmail.com wrote: 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 12:07 PM, Richard Biener richard.guent...@gmail.com wrote: 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set the promoted mode. (promoted_for_signed_and_unsigned_p): New function.

Re: [PATCH PR62151]Fix uninitialized register issue caused by distribute_notes in combine pass

2014-08-27 Thread Richard Earnshaw
(distribute_notes): Check i2 if it modifies register in REG_DEAD note immediately, set tem_insn accordingly. pr62151-20140827.txt Index: gcc/combine.c === --- gcc/combine.c (revision 214413) +++ gcc/combine.c

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
On 27 August 2014 11:24, Richard Earnshaw rearn...@arm.com wrote: On 27/08/14 09:04, Yvan Roux wrote: Hi, as reported in PR62248 there is a typo in gcc/config.gcc where --with-fpu doesn't match -mfpu option for fp-armv8 value (fp-arm-v8 in config.gcc). Here is the patch to fix it. Thanks,

Re: [PATCH GCC]Cleanup interface of iv_ca_add_use and the calls to it

2014-08-27 Thread Bin.Cheng
On Wed, Aug 27, 2014 at 4:23 PM, Richard Biener richard.guent...@gmail.com wrote: On Wed, Aug 27, 2014 at 10:10 AM, Bin Cheng bin.ch...@arm.com wrote: Hi, As I analyzed in bug pr62178, current candidate selecting algorithm can't find out the optimal solution in some scenarios. I am trying to

[PATCH] Refactor get_maxval_strlen and gimple_fold_builtin_with_strlen

2014-08-27 Thread Richard Biener
This removes gimple_fold_builtin_with_strlen and makes get_maxval_strlen get an overload with an API that is convenient to use from the actual folders. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2014-08-27 Richard Biener rguent...@suse.de * gimple-fold.c

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
Here is the patch that uses the arm-fpus.def list. Thanks Yvan 2014-08-27 Yvan Roux yvan.r...@linaro.org * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def. On 27 August 2014 12:35, Yvan Roux yvan.r...@linaro.org wrote: On 27 August 2014 11:24, Richard Earnshaw

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
with the PR in the ChangeLog: 2014-08-27 Yvan Roux yvan.r...@linaro.org PR other/62248 * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def. On 27 August 2014 13:10, Yvan Roux yvan.r...@linaro.org wrote: Here is the patch that uses the arm-fpus.def list. Thanks

[PATCH i386 AVX512] [23/n] Add vcvtps2[u]qq patterns.

2014-08-27 Thread Kirill Yukhin
Hello, This patch introduces support for vcvtps2[u]qq. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md (define_mode_iterator VI8_256_512): New. (define_insn

[PATCH][match-and-simplify] Fix type guessing for conversions

2014-08-27 Thread Richard Biener
The following fixes type guessing by handling VIEW_CONVERT_EXPR and by properly passing down unknown for outermost conversions. Btw, a case where we need some explicit type specification support is Convert (T1)(X * Y) into (T1)X * (T1)Y which needs to eventually use an unsigned type for the

[PATCH i386 AVX512] [24/n] Add integer max/min.

2014-08-27 Thread Kirill Yukhin
Hello, This patch introduces integer max/min AVX-512 pattern. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md (define_mode_iterator VI128_256): New. (define_insn mask_codeforcodemode3mask_name):

[PATCH i386 AVX512] [25/n] Add vps[rl]ldq insn patterns.

2014-08-27 Thread Kirill Yukhin
Hello, Proposed patch adds patterns for vps[rl]ldq insns Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md (define_mode_iterator VIMAX_AVX2): Add V4TI mode. (define_insn sse2_avx2_ashlmode3): Add EVEX

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Richard Earnshaw
On 27/08/14 12:35, Yvan Roux wrote: with the PR in the ChangeLog: 2014-08-27 Yvan Roux yvan.r...@linaro.org PR other/62248 * config.gcc (arm*-*-*): Check --with-fpu against arm-fpus.def. OK, thanks. R. On 27 August 2014 13:10, Yvan Roux yvan.r...@linaro.org wrote:

[PATCH i386 AVX512] [26/n] Support 512-bit/masked interleave.

2014-08-27 Thread Kirill Yukhin
Hello, Patch in the bottom extends interleaves toward support of AVX-512. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md (define_insn avx512bw_interleave_highv64qimask_name): New. (define_insn

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Kugan
On 27/08/14 20:01, Uros Bizjak wrote: Hello! 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set the promoted mode. (promoted_for_signed_and_unsigned_p): New function. (expand_expr_real_1): Check

Re: [Patch AArch64] Fix for PR62262

2014-08-27 Thread Richard Earnshaw
On 26/08/14 23:18, Carrot Wei wrote: Hi In insn pattern *andim_ashiftmode_bfiz, if the operands[2] is larger than the size of register, gcc may generate invalid assembler code. If operands[2] is larger than the size of the underlying type of INTVAL, the following insn condition may also be

[PATCH i386 AVX512] [27/n] Add byte/word plus/minus/avg.

2014-08-27 Thread Kirill Yukhin
Hello, Patch extends `plusminus' and `avg' insn patterns toward AVX-512BW,VL support. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ (define_mode_iterator VI12_AVX2): Add V64QI and V32HI modes. (define_expand

Re: [PING^3] Re: [PATCH 1/2] Add -B support to gcc-ar/ranlib/nm

2014-08-27 Thread Andi Kleen
Andi Kleen a...@firstfloor.org writes: PING! Andi Kleen a...@firstfloor.org writes: PING^2 ! Would be nice to make slim bootstrap work, it really speeds it up quite a bit. From: Andi Kleen a...@linux.intel.com To use gcc-{ar,ranlib} for boot strap we need to add a -B option to the

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Jason Merrill
On 08/27/2014 04:41 AM, Paolo Carlini wrote: .. two additional remarks (maybe obvious, I don't know): - It also appears to work - for sure for all the tests in c++/52892 + the tests in c++/52282 not involving data members (eg, the original one) - simply unconditionally calling STRIP_NOPS right

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
Committed on trunk at r214573, and I'll backport it on 4.9 branch. On 27 August 2014 14:26, Richard Earnshaw rearn...@arm.com wrote: On 27/08/14 12:35, Yvan Roux wrote: with the PR in the ChangeLog: 2014-08-27 Yvan Roux yvan.r...@linaro.org PR other/62248 * config.gcc

[PATCH] Steam out non-explicit -fno-tree-loop-distribute-patterns for LTO options

2014-08-27 Thread Kito Cheng
Hi all: This patch basically is extension for r210100[1], stream out non-explicit -fno-tree-loop-distribute-patterns since compile with `-flto -O3 -fno-builtin` still may gen builtin function call during LTO phase. LTO bootstrapped and tested on x86_64-unknown-linux-gnu. 2014-09-27 Kito Cheng

[PATCH] Don't init ira_spilled_reg_stack_slots in ira if using lra.

2014-08-27 Thread Kito Cheng
Hi all: This patch is clean up useless initialize for IRA with LRA. 2014-08-27 Kito Cheng k...@0xlab.org * ira.c (ira): Don't initialize ira_spilled_reg_stack_slots and ira_spilled_reg_stack_slots_num if using lra. (do_reload): Remove release

[PATCH, CPP/23827] standard C++ should not have hex float preprocessing tokens

2014-08-27 Thread Ed Smith-Rowland
This old one says the C++98 ANSI doesn't have hex float literals and should error gracefully. Fixed by changing a language feature flag as suggested by the audit trail and by adding an error message. Built and tested on x86_64-linux. OK? libcpp/ 2014-08-27 Edward Smith-Rowland

Re: [PATCH i386 AVX512] [23/n] Add vcvtps2[u]qq patterns.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 2:04 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: This patch introduces support for vcvtps2[u]qq. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md (define_mode_iterator

Re: [PATCH i386 AVX512] [24/n] Add integer max/min.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 2:16 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: This patch introduces integer max/min AVX-512 pattern. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
Hi, On 08/27/2014 04:19 PM, Jason Merrill wrote: On 08/27/2014 04:41 AM, Paolo Carlini wrote: .. two additional remarks (maybe obvious, I don't know): - It also appears to work - for sure for all the tests in c++/52892 + the tests in c++/52282 not involving data members (eg, the original one)

Re: [PATCH i386 AVX512] [25/n] Add vps[rl]ldq insn patterns.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 2:22 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, Proposed patch adds patterns for vps[rl]ldq insns Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md

Re: [PATCH i386 AVX512] [26/n] Support 512-bit/masked interleave.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 2:47 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, Patch in the bottom extends interleaves toward support of AVX-512. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ * config/i386/sse.md

Re: [PATCH i386 AVX512] [27/n] Add byte/word plus/minus/avg.

2014-08-27 Thread Uros Bizjak
On Wed, Aug 27, 2014 at 3:28 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Patch extends `plusminus' and `avg' insn patterns toward AVX-512BW,VL support. Bootstrapped. AVX-512* tests on top of patch-set all pass under simulator. Is it ok for trunk? gcc/ (define_mode_iterator

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-08-27 Thread Evgeny Stupachenko
The rotate insn appeared right after expand. I've done it similar to define_insn_and_split *avx_vperm_broadcast_mode. I don't see any potential losses on splitting that after reload. On Tue, Aug 26, 2014 at 8:29 PM, Richard Henderson r...@redhat.com wrote: On 08/26/2014 05:59 AM, Evgeny

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread David Malcolm
On Tue, 2014-08-19 at 11:02 -0700, Richard Henderson wrote: On 08/06/2014 10:19 AM, David Malcolm wrote: @@ -2772,11 +2772,11 @@ mn10300_adjust_sched_cost (rtx insn, rtx link, rtx dep, int cost) if (!TARGET_AM33) return 1; - if (GET_CODE (insn) == PARALLEL) -insn =

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread Richard Henderson
On 08/27/2014 08:48 AM, David Malcolm wrote: Alternatively, should this simply use single_set? Yes. (though I think that's a more invasive change, especially since some of the logic is for non-SETs). I don't think that's the case. Take the tests in order: if (mn10300_tune_cpu ==

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread David Malcolm
On Wed, 2014-08-27 at 09:11 -0700, Richard Henderson wrote: On 08/27/2014 08:48 AM, David Malcolm wrote: Alternatively, should this simply use single_set? Yes. (though I think that's a more invasive change, especially since some of the logic is for non-SETs). I don't think that's

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-27 Thread Richard Henderson
On 08/27/2014 09:32 AM, David Malcolm wrote: * gcc/config/mn10300/mn10300.c (is_load_insn): Rename to... (set_is_load_p): ...this, updating to work on a SET pattern rather than an insn. (is_store_insn): Rename to... (set_is_store_p): ...this, updating to work on

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Bernhard Reutner-Fischer
On 27 August 2014 16:22:28 CEST, Yvan Roux yvan.r...@linaro.org wrote: Committed on trunk at r214573, and I'll backport it on 4.9 branch. s/true/:/ ? Thanks,

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
true seems to be used that way for aarch64*-*-* and arm*-*-* is it preferable to change it to ; for all occurrences ? Thanks, Yvan On 27 August 2014 18:51, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 27 August 2014 16:22:28 CEST, Yvan Roux yvan.r...@linaro.org wrote: Committed on

Re: [PATCH libcpp] Use CPP() for Wbuiltin-macro-redefined

2014-08-27 Thread Joseph S. Myers
On Sat, 23 Aug 2014, Manuel L?pez-Ib??ez wrote: The problem with overriding the default in libcpp is fixed by setting Init(1) in c.opt to match the default. However, it is too easy to forget the Init(). It would be better if no Init() meant use the default of libcpp. This would require

Re: [PATCH, ARM] PR62248 - Configure error with --with-fpu=fp-armv8

2014-08-27 Thread Yvan Roux
On 27 August 2014 19:07, Yvan Roux yvan.r...@linaro.org wrote: true seems to be used that way for aarch64*-*-* and arm*-*-* is it preferable to change it to ; for all occurrences ? sorry for the typo, I meant colon and not semicolon. Thanks, Yvan On 27 August 2014 18:51, Bernhard

[patch] libstdc++/62159 install missing freestanding headers for C++11

2014-08-27 Thread Jonathan Wakely
C++11 adds several more headers to the minimum requirements for a freestanding implementation. Tested x86_64-linux, committed to trunk. commit 88367ee23e7a6f23fb339dd938a50a79d4eb7fb3 Author: Jonathan Wakely jwak...@redhat.com Date: Wed Aug 27 15:24:27 2014 +0100 PR libstdc++/62159

[patch] Only configure libstdc++-v3/python dir for hosted builds

2014-08-27 Thread Jonathan Wakely
Currently a freestanding build installs the Python GDB hooks as ${libdir}/libstdc*-gdb.py (with a literal * character in the filename) because there is no libstdc++.so library file and the wildcard doesn't get expanded (see the install-data-local target in the libstdc++-v3/python/Makefile.am

Re: [C/C++ PATCH] Allow __atomic_always_lock_free in a static assert (PR c/62024)

2014-08-27 Thread Joseph S. Myers
On Mon, 25 Aug 2014, Marek Polacek wrote: PR62024 reports that we can't use __atomic_always_lock_free in a static assert, as the FEs say it's not a constant expression. Yet the docs say that the result of __atomic_always_lock_free is a compile time constant. We can fix this pretty easily.

Re: [C/C++ PATCH] Allow __atomic_always_lock_free in a static assert (PR c/62024)

2014-08-27 Thread Jason Merrill
On 08/25/2014 07:43 AM, Marek Polacek wrote: * semantics.c (finish_static_assert): Strip no-op conversions. I think I'd rather strip these in cxx_eval_builtin_function_call so that we don't have to deal with them in various consumers. Jason

Re: [PATCH, CPP/23827] standard C++ should not have hex float preprocessing tokens

2014-08-27 Thread Jason Merrill
OK. Jason

Re: Enable EBX for x86 in 32bits PIC code

2014-08-27 Thread Vladimir Makarov
On 2014-08-26 5:42 PM, Ilya Enkovich wrote: Hi, Here is a patch I tried. I apply it over revision 214215. Unfortunately I do not have a small reproducer but the problem can be easily reproduced on SPEC2000 benchmark 175.vpr. The problem is in read_arch.c:701 where float value is compared

Re: [PATCH 40/50] rtlanal.c:for_each_inc_dec

2014-08-27 Thread Jeff Law
On 08/26/14 13:28, Richard Sandiford wrote: [Jeff, sorry for the duplicate, sent the original from an account that adds disclaimers.] No worries. Given the 3000+ messages that were waiting for me when I got back from PTO, what's another duplicate here and there :-) [ Big snip. ] invalid

Re: [PATCH] Small fix for r214086 Asan regression

2014-08-27 Thread Jeff Law
On 08/26/14 00:35, Yury Gribov wrote: Hi all, Deja pattern in r214086's test is too strict (Asan runtime will not always be able to detect that invalid memory access is use-after-poison). I've cooked a trivial patch to loosen the check so test now also works on i386. Tested on x64 and i386. Ok

[Patch, Fortran] CAF dep (1/3): PR62278 - improve dependency.c's gfc_check_dependency's check (missed-optimization)

2014-08-27 Thread Tobias Burnus
The current gfc_check_dependency check always looked at the pointer attribute - and assumed the worst, if either the LHS or the RHS was true. Thus, it claimed that a and b alias for the following definition: integer, pointer :: p; integer :: a. However, as a has no target (or pointer)

Re: [PATCH 2/5] Existing call graph infrastructure enhancement

2014-08-27 Thread Jeff Law
On 08/25/14 03:55, Martin Liška wrote: Hello, after fixing an issue with callgraph thunk creation, I would like to enhance callgraph API a bit. My problem was that I was trying to expand_thunk after a body of the original function was removed. As a result, I created a call without arguments.

Re: [PATCH v2] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 23 bytes

2014-08-27 Thread Jeff Law
On 08/21/14 15:44, Chen Gang wrote: int_size_in_bytes() returns HOST_WIDE_INT (64-bit), theoretically, the maximized size is 23 -- it is sizeof([-9223372036854775808]) for 0x8000LL. It may not cause real world issue, but if another issues occur, it may lead things worse. It passes

Re: [Patch, Fortran] CAF dep (1/3): PR62278 - improve dependency.c's gfc_check_dependency's check (missed-optimization)

2014-08-27 Thread Tobias Burnus
Tobias Burnus wrote: { + symbol_attribute attr1, attr2; gfc_typespec *ts1 = expr1-symtree-n.sym-ts; - gfc_typespec *ts2 = expr2-symtree-n.sym-ts; + gfc_typespec *ts2 = expr2-symtree-n.sym-ts; [Ignore the ts2-line change: I have accidentally added a

Re: [PATCH] genemit: Print name of splitter to dumpfile

2014-08-27 Thread Jeff Law
On 08/17/14 18:15, Segher Boessenkool wrote: Currently, the splitter dumpfiles only say scanning new insn with uid = N. and deleting insn with uid = N.. This makes it hard to track down which splitter actually fired, especially so if there are many similar splitters and one is slightly broken.

Re: [PATCH libcpp] Use CPP() for Wendif-labels and other flags

2014-08-27 Thread Joseph S. Myers
On Mon, 25 Aug 2014, Manuel L?pez-Ib??ez wrote: This patch is on top of https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02244.html The main issue here is Wendif-labels, since we were not using the correct CPP_W_* flag. The rest are straight-forward. libcpp/ChangeLog: 2014-08-25 Manuel

[Patch, Fortran] CAF dep (2/3): Move code around, prepare for more locking support

2014-08-27 Thread Tobias Burnus
I claim that it is part 2 of 3 of the CAF dep series, but the patch has nothing to do with it, except that it is in the way. Technically, it just moves code from trans-intrinsic.c to trans-expr.c and makes it available. Additionally, I support the case offset == NULL_TREE, which is supposed

[PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Siva Chandra
The attached patch addresses Jonathan Wakely's comments on the previous version of the patch: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02426.html On Tue, Aug 26, 2014 at 10:58 AM, Jonathan Wakely jwak...@redhat.com wrote: Shouldn't there be a change to python/Makefile.am so that xmethods.py

Re: Enable EBX for x86 in 32bits PIC code

2014-08-27 Thread Jeff Law
On 08/26/14 15:42, Ilya Enkovich wrote: diff --git a/gcc/calls.c b/gcc/calls.c index 4285ec1..85dae6b 100644 --- a/gcc/calls.c +++ b/gcc/calls.c @@ -1122,6 +1122,14 @@ initialize_argument_information (int num_actuals ATTRIBUTE_UNUSED, call_expr_arg_iterator iter; tree arg; +if

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Jonathan Wakely
On 27 August 2014 22:39, Siva Chandra wrote: The attached patch addresses Jonathan Wakely's comments on the previous version of the patch: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02426.html On Tue, Aug 26, 2014 at 10:58 AM, Jonathan Wakely jwak...@redhat.com wrote: Shouldn't there be a

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Tom Tromey
Siva == Siva Chandra sivachan...@google.com writes: Siva I had something in hook.in in my very first patch but Tom Tromey said Siva it was not required anymore: Siva https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02405.html What I meant was that there should just be a single function called by

Re: [PATCH] Drop user_defined_section_attribute, directly check DECL_SECTION_NAME instead

2014-08-27 Thread Yi Yang
Ping On Mon, Aug 11, 2014 at 3:10 PM, Yi Yang ahyan...@google.com wrote: Sorry, it is a typo :( Patch v2: -- 2014-08-11 Yi Yang ahyan...@google.com gcc: * bb-reorder.c (pass_partition_blocks::gate): Replace check. * c-family/c-common.c (handle_section_attribute): Remove

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Siva Chandra
On Wed, Aug 27, 2014 at 3:31 PM, Tom Tromey t...@tromey.com wrote: Siva == Siva Chandra sivachan...@google.com writes: Siva I had something in hook.in in my very first patch but Tom Tromey said Siva it was not required anymore: Siva https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02405.html

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Siva Chandra
On Wed, Aug 27, 2014 at 3:19 PM, Jonathan Wakely jwakely@gmail.com wrote: I think I did test with the files installed, but they weren't used. I'll test again with the new patch. You are probably already doing it, but just in case: are you using GDB 7.8 (or later, like ToT) ? You most

[PATCH] libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc: Avoid writing '\0' out of string's border

2014-08-27 Thread Chen Gang
'max_len' is the maximized length of 'name', so for writing '\0' to name[max_len], it is out of string's border, need use max_len - 1 instead of. Pass normal test suite: configure make make check compare, I guess, at present, it is not really used by outside, though. 2014-08-27 Chen Gang

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Tom Tromey
Siva == Siva Chandra sivachan...@google.com writes: Tom What I meant was that there should just be a single function called by Tom the hook file, and that it should handle the xmethod additions by some Tom means as well. Siva I misunderstood then. But, I still do not understand what you mean by

Re: [PATCH v2] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 23 bytes

2014-08-27 Thread Chen Gang
On 08/28/2014 05:19 AM, Jeff Law wrote: On 08/21/14 15:44, Chen Gang wrote: int_size_in_bytes() returns HOST_WIDE_INT (64-bit), theoretically, the maximized size is 23 -- it is sizeof([-9223372036854775808]) for 0x8000LL. It may not cause real world issue, but if another issues

Re: [PATCH] libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc: Avoid writing '\0' out of string's border

2014-08-27 Thread Konstantin Serebryany
[replying text only] Hi Chen, as per https://code.google.com/p/address-sanitizer/wiki/HowToContribute all changes to libsanitizer, even such simple ones, have to go through the LLVM tree first. But, what makes you think there is a bug here? The comment in sanitizer_common/sanitizer_common.h

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Jonathan Wakely
On 27 August 2014 23:38, Siva Chandra wrote: You are probably already doing it, but just in case: are you using GDB 7.8 (or later, like ToT) ? You most likely are as otherwise the tests added by this patch will not be exercised. Yes, I'm testing with both 7.8 (where it should work) and an

Re: [PATCH] libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc: Avoid writing '\0' out of string's border

2014-08-27 Thread Chen Gang
On 08/28/2014 06:51 AM, Konstantin Serebryany wrote: [replying text only] Hi Chen, as per https://code.google.com/p/address-sanitizer/wiki/HowToContribute all changes to libsanitizer, even such simple ones, have to go through the LLVM tree first. OK, thanks, I shall notice about it,

Re: [4.9] PR 62146

2014-08-27 Thread Easwaran Raman
On Mon, Aug 25, 2014 at 3:42 PM, Easwaran Raman era...@google.com wrote: This patch deletes REG_EQUAL note when a src register is replaced by a constant in an assignment. This is to prevent spurious equivalences between the constant and the expression in the REG_EQUAL note. In the bug reported

[patch committed SH] Fix PR target/62261

2014-08-27 Thread Kaz Kojima
I've applied the attached patch to fix PR target/62261 which is a sh64 specific 4.9/5 regression. The patch handles negative shift counts at some shift paterns for shmedia. Tested sh64-elf and sh4-unknown-linux-gnu with no new failures. I'll backport it to 4.9 in a weak or two. Regards,

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Siva Chandra
On Wed, Aug 27, 2014 at 3:45 PM, Tom Tromey t...@tromey.com wrote: Siva I misunderstood then. But, I still do not understand what you mean by Siva single function. I re-read my original note, and I think I wasn't very clear. Sorry about that. All I mean here is that I think it's better to

Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr

2014-08-27 Thread Tom Tromey
Siva My patch is still using a single function to register libstdc++ Siva xmethods. Do you mean there should be a single function for pretty Siva printers and xmethods together? Yeah, that's my view. Tom

Re: [PATCH 4.8] libstdc++ pretty-printers: Backport Python 3 support from mainline

2014-08-27 Thread Samuel Bronson
Ping? (My apologies if this is redundant: I tried to send one yesterday and gnus has your message flagged as Answered, but I don't see that ping on gmane ...) -- Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread!

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-27 Thread Kugan
On 27/08/14 23:02, Kugan wrote: On 27/08/14 20:01, Uros Bizjak wrote: Hello! 2014-08-07 Kugan Vivekanandarajah kug...@linaro.org * calls.c (precompute_arguments): Check promoted_for_signed_and_unsigned_p and set the promoted mode. (promoted_for_signed_and_unsigned_p): New function.

Re: [PATCH PR62151]Fix uninitialized register issue caused by distribute_notes in combine pass

2014-08-27 Thread Bin.Cheng
On Wed, Aug 27, 2014 at 6:34 PM, Richard Earnshaw rearn...@arm.com wrote: On 27/08/14 11:08, Bin Cheng wrote: Hi As reported in bug pr62151, combine pass may wrongly delete necessary instruction in function distribute_notes thus leaving register uninitialized. This patch is to fix the issue