Re: [PATCH] Fix some ICF gimple_call handling issues

2014-11-10 Thread Richard Biener
On November 10, 2014 9:45:27 PM CET, Jakub Jelinek ja...@redhat.com wrote: Hi! As the following two testcases shows, there are lots of issues in ICF compare_gimple_call, in particular, it doesn't handle indirect calls properly (see the ipa-icf-31.c testcase), doesn't handle internal calls

[PATCH][ARM] testsuite, use arm_eabi #2

2014-11-10 Thread Andreas Tobler
Hi all, here a second chunk which uses arm_eabi instead of arm*-*-*eabi* and arm*-*-symbianelf*. As I was told, arm*-*-symbianelf* should be EABI so we can use arm_eabi for all instead of listing each OS. Ok for trunk? TIA, Andreas 2014-11-10 Andreas Tobler andre...@gcc.gnu.org

Re: [PATCH, i386]: Use std::swap

2014-11-10 Thread Richard Biener
On November 10, 2014 9:13:29 PM CET, Uros Bizjak ubiz...@gmail.com wrote: Hello! std::swap was recently mentioned in gcc-patches@ mailing list, so I gave it a try. As can be seen below, a lot of code in config/i386 benefits from this conversion. Surprisingly, I didn't have to include any header

Re: [PATCH, i386]: Use std::swap

2014-11-10 Thread Uros Bizjak
On Mon, Nov 10, 2014 at 10:13 PM, Richard Biener richard.guent...@gmail.com wrote: On November 10, 2014 9:13:29 PM CET, Uros Bizjak ubiz...@gmail.com wrote: Hello! std::swap was recently mentioned in gcc-patches@ mailing list, so I gave it a try. As can be seen below, a lot of code in

patch to fix PR63620 and PR63799

2014-11-10 Thread Vladimir Makarov
Uros reported that my latest patch to fix PR63620 does not fix actually the problem and H.J. reported that the patch resulted in 2 java test failures (PR63799). The following patch fixes PR63620 and PR63799. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63620

Re: [PATCH 2/3] PR other/61321 - demangler crash on casts in template parameters

2014-11-10 Thread Cary Coutant
Ping. I'm getting more reports of this bug internally, and it would be nice to have the fix upstream. -cary On Mon, Oct 13, 2014 at 11:43 AM, Cary Coutant ccout...@google.com wrote: Ping. Jason, do you still think the special-case for conversion ops is inappropriate? -cary On Fri, Jul

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 21:50 +0100, François Dumont wrote: Any news about this one ? Here is another version with additional random tests on algos just to challenge other combinations of tests. PR libstdc++/61107 * include/bits/stl_algo.h (__inplace_stable_partition): Delete.

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Tobias Burnus
Tobias Grosser wrote: On 10.11.2014 20:14, Roman Gareev wrote: Sure. We should drop the flag in these test cases. This seems to make sense, as they now test something different and the flag removal would reflect this. I personally would include this in the same patch. Would this be

Re: [PATCH] libstdc++ - Add xmethods for associative containers (ordered and unordered)

2014-11-10 Thread Jonathan Wakely
On 09/11/14 16:00 -0800, Siva Chandra wrote: Hello, Attached is a patch which adds xmethods for the associative containers (set, map, multiset and multimap) and their unordered versions. I think the GDB Python API is not rich enough to implement xmethods for the more interesting methods like

Re: [PATCH, i386]: Use std::swap

2014-11-10 Thread Marc Glisse
On Mon, 10 Nov 2014, Richard Biener wrote: No extra includes required? utility is already included in wide-int.h and rtl.h, should probably move those. -- Marc Glisse

Re: [PATCH][ARM] testsuite, use arm_eabi #2

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 1:12 PM, Andreas Tobler andreast-l...@fgznet.ch wrote: As I was told, arm*-*-symbianelf* should be EABI so we can use arm_eabi for all instead of listing each OS. Ok for trunk? Ok.

[C PATCH] warn for empty struct -Wc++-compat

2014-11-10 Thread Prathamesh Kulkarni
Hi, For the following test-case: struct A {}; clang -fsyntax-only -Wc++-compat gives following warning and gcc does not: empty-struct.c:1:1: warning: empty struct has size 0 in C, size 1 in C++ [-Wc++-compat] struct F {}; This patch adds the above warning to the C FE. Bootstrapped on

Re: [PATCH][ARM] testsuite, use arm_eabi #2

2014-11-10 Thread Mike Stump
[ sorry for dup, if any ] On Nov 10, 2014, at 1:12 PM, Andreas Tobler andreast-l...@fgznet.ch wrote: As I was told, arm*-*-symbianelf* should be EABI so we can use arm_eabi for all instead of listing each OS. Ok for trunk? Ok.

Re: [PATCH] Fix some ICF gimple_call handling issues

2014-11-10 Thread Jan Hubicka
Hi! As the following two testcases shows, there are lots of issues in ICF compare_gimple_call, in particular, it doesn't handle indirect calls properly (see the ipa-icf-31.c testcase), doesn't handle internal calls properly (see ubsan/ipa-icf-1.c), didn't check gimple_call flags at all.

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-10 Thread Marek Polacek
On Tue, Nov 11, 2014 at 03:24:48AM +0530, Prathamesh Kulkarni wrote: * gcc/c/c-decl.c (warn_cxx_compat_finish_struct): Add new parameter of type location_t. Warn for empty struct. (finish_struct): Pass loc to warn_cxx_compat_finish_struct. * gcc/testsuite/gcc.dg/Wcxx-compat-22.c:

[PATCH][ARM] testsuite, use arm_eabi #3

2014-11-10 Thread Andreas Tobler
Hi all, another one. Here I'm not really sure if there are EABI variants which do _not_ support these test cases. My target succeeds with this patch. Comments? If no (comments), ok for trunk? TIA, Andreas 2014-11-10 Andreas Tobler andre...@gcc.gnu.org *

Re: [patch] OpenACC fortran front end

2014-11-10 Thread Tobias Burnus
Cesar Philippidis wrote: This patch adds support for OpenACC 2.0a, with some omissions, to the fortran front end. It only contains the fortran changes from gomp-4_0-branch, therefore the middle end and runtime changes are a necessary prerequisite for this patch. I'd assume that one could

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread François Dumont
I introduced the random tests after Christopher Jefferson request to have more intensive tests on those algos. Is it the whole stuff of tests using random numbers that you don't like or just the usage of mt19937 ? If second is this new version using the usual random_device I used so far

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 23:14 +0100, François Dumont wrote: I introduced the random tests after Christopher Jefferson request to have more intensive tests on those algos. Is it the whole stuff of tests using random numbers that you don't like or just the usage of mt19937 ? The use of random number in

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-10 Thread David Malcolm
On Sat, 2014-11-08 at 14:56 +0100, Jakub Jelinek wrote: On Sat, Nov 08, 2014 at 01:07:28PM +0100, Richard Biener wrote: To be constructive here - the above case is from within a GIMPLE_ASSIGN case label and thus I'd have expected case GIMPLE_ASSIGN: { gassign *a1

Re: [PATCH 10/11][RS6000] Migrate reduction optabs to reduc_..._scal

2014-11-10 Thread Michael Meissner
On Fri, Oct 24, 2014 at 01:06:41PM +0100, Alan Lawrence wrote: This migrates the reduction patterns in altivec.md and vector.md to the new names. I've not touched paired.md as I wasn't really sure how to fix that (how do I vec_extractv2sf ?), moreover the testing I did didn't seem to exercise

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread François Dumont
No the random tests didn't show any problem. I had demonstrated the problems with the modifications on the existing tests simulating constraint memory context. So unless specified otherwise I will commit tomorrow without the tests using random numbers. François On 10/11/2014 23:20,

Re: [patch] OpenACC fortran front end

2014-11-10 Thread Cesar Philippidis
On 11/10/2014 02:08 PM, Tobias Burnus wrote: Cesar Philippidis wrote: This patch adds support for OpenACC 2.0a, with some omissions, to the fortran front end. It only contains the fortran changes from gomp-4_0-branch, therefore the middle end and runtime changes are a necessary prerequisite

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 23:39 +0100, François Dumont wrote: No the random tests didn't show any problem. I had demonstrated the problems with the modifications on the existing tests simulating constraint memory context. So unless specified otherwise I will commit tomorrow without the tests using random

Re: libstdc++ new deque failures

2014-11-10 Thread Jonathan Wakely
On 05/11/14 17:49 +, Jonathan Wakely wrote: On 5 November 2014 14:14, David Edelsohn wrote: Jonathan, I still am seeing new failures in the libstdc++ deque testsuite as of last night. I don't know if you still are working through the fallout from the earlier patches, but I wanted to make

Re: [PATCH] Fix some ICF gimple_call handling issues

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 10:08:54PM +0100, Richard Biener wrote: @@ -662,9 +662,49 @@ func_checker::compare_gimple_call (gimpl t1 = gimple_call_fndecl (s1); t2 = gimple_call_fndecl (s2); Just drop these and compare gimple_call_fn only. + tree chain1 = gimple_call_chain (s1); +

Re: [PATCH, i386]: Add target i?86-*-* to many tests

2014-11-10 Thread Jakub Jelinek
On Sun, Nov 02, 2014 at 08:31:43PM +0100, Uros Bizjak wrote: Attached (mechanical) patch adds i?86-*-* target to many tests, where only x86_64-*-* is listed. Please note that x86_64-*-* already included lp64 for 64bit specific tests due to -m32 multilib testing. 2014-11-02 Uros Bizjak

Re: [C PATCH] warn for empty struct -Wc++-compat

2014-11-10 Thread Prathamesh Kulkarni
On Tue, Nov 11, 2014 at 3:35 AM, Marek Polacek pola...@redhat.com wrote: On Tue, Nov 11, 2014 at 03:24:48AM +0530, Prathamesh Kulkarni wrote: * gcc/c/c-decl.c (warn_cxx_compat_finish_struct): Add new parameter of type location_t. Warn for empty struct. (finish_struct): Pass loc to

Re: [PATCH x86_64] Optimize access to globals in -fpie -pie builds with copy relocations

2014-11-10 Thread Sriraman Tallam
Ping. On Mon, Oct 6, 2014 at 1:43 PM, Sriraman Tallam tmsri...@google.com wrote: Ping. On Mon, Sep 29, 2014 at 10:57 AM, Sriraman Tallam tmsri...@google.com wrote: Ping. On Fri, Sep 19, 2014 at 2:11 PM, Sriraman Tallam tmsri...@google.com wrote: Hi Richard, I also ran the gcc testsuite

[PATCH, i386]: Revert PR 63620 workaround

2014-11-10 Thread Uros Bizjak
Hello! Now that Vlad fixed the real problem of PR 63620 [1], we can remove the temporary workaround. The patch also adds the testcase from PR. 2014-11-11 Uros Bizjak ubiz...@gmail.com Revert: 2014-10-31 Uros Bizjak ubiz...@gmail.com PR target/63620 *

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-10 Thread Andrew Pinski
On Mon, Nov 10, 2014 at 2:27 PM, David Malcolm dmalc...@redhat.com wrote: On Sat, 2014-11-08 at 14:56 +0100, Jakub Jelinek wrote: On Sat, Nov 08, 2014 at 01:07:28PM +0100, Richard Biener wrote: To be constructive here - the above case is from within a GIMPLE_ASSIGN case label and thus I'd

Re: [PATCH][ARM] testsuite, use arm_eabi #3

2014-11-10 Thread Mike Stump
On Nov 10, 2014, at 2:06 PM, Andreas Tobler andreast-l...@fgznet.ch wrote: another one. Here I'm not really sure if there are EABI variants which do _not_ support these test cases. I think the patch is fine, just watch for any follow-on comments from an eabi/arm expert. Usually they are

[google/gcc-4_9] Backport pending patch to fix demangler crash

2014-11-10 Thread Cary Coutant
Backport pending upstream patch to fix demangler crash. https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02279.html This patch is for the google/gcc-4_9 branch. Google ref: 17891596 -cary 2014-05-27 Pedro Alves pal...@redhat.com include/ * demangle.h (enum demangle_component_type)

Re: [google/gcc-4_9] Backport pending patch to fix demangler crash

2014-11-10 Thread Sterling Augustine
On Mon, Nov 10, 2014 at 3:56 PM, Cary Coutant ccout...@google.com wrote: Backport pending upstream patch to fix demangler crash. https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02279.html This patch is for the google/gcc-4_9 branch. Google ref: 17891596 -cary OK for Google branches.

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-10 Thread Sebastian Pop
Hi Jeff, I have adapted the code generation part from James' patch to current trunk, and the resulting patch gets the 30% speedup on coremark and passes bootstrap of GCC. Ok for trunk? Thanks, Sebastian Sebastian Pop wrote: Sebastian Pop wrote: Jeff Law wrote: On 08/21/14 04:30, Richard

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Jack Howarth
On x86_64-apple-darwin14, the attached patch allows gcc trunk to build against isl 0.14. I assume if we want to retain the... #if defined(__cplusplus) extern C { #endif #if defined(__cplusplus) } #endif wrappers around the include of isl/val_gmp.h, to continue to support isl 0.12.2, isl.m4

[PATCH 1/2] VRP: Simplify logic for checking if any asserts need to be inserted

2014-11-10 Thread Patrick Palka
Hi, This patch tweaks the VRP code to simply inspect the need_assert_for bitmap when determining whether any asserts need to be inserted. Consequently we no longer have to manually keep track of whether a call to register_new_assert_for() was made. This patch is an updated version of a patch

[PATCH 2/2] Simplify and extend VRP edge-assertion code

2014-11-10 Thread Patrick Palka
This patch refactors the VRP edge-assertion code to make it always traverse SSA-name definitions in order to find suitable edge assertions to insert. Currently SSA-name definitions get traversed only when the LHS of the original conditional is a bitwise AND or OR operation which seems like a

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Ed Smith-Rowland
On 11/10/2014 12:10 PM, Jason Merrill wrote: On 11/10/2014 10:55 AM, Ed Smith-Rowland wrote: Would a 4.9 version be accepted? Sure. What do you think about defining the macros for unsupported features to 0 rather than leaving them undefined? The document doesn't seem to specify. Jason

Re: [PATCH] c++ify sreal

2014-11-10 Thread Andrew Pinski
On Fri, Oct 24, 2014 at 1:55 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Oct 24, 2014 at 8:28 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, do $subject, and cleanup for always 64 bit hwi. bootstrapped + regtested

Re: [patch] OpenACC fortran tests

2014-11-10 Thread Tobias Burnus
Cesar Philippidis wrote: This patch contains compile-time tests for OpenACC in gfortran. Is this patch OK for mainline trunk after the OpenACC fortran front end changes make their way in? I browsed the test cases – and they look okay. I didn't try hard to see whether every single one is valid

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:30:38PM +0300, Ilya Verbin wrote: On 06 Nov 19:25, Jakub Jelinek wrote: Oh, one more point, if mic_lib_path is NULL, what is the point to do the alloca/malloc and string copying? Can't you just setenv (MIC_LD_LIBRARY_PATH_ENV, ld_lib_path, 1); in that case

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote: Done, I put them into env vars. +lappend ALWAYS_CFLAGS additional_flags=${offload_additional_options} } Perhaps add this only if offload_additional_options is non-empty? Done. Ok (with appropriate ChangeLog

Re: [PATCH 10/11][RS6000] Migrate reduction optabs to reduc_..._scal

2014-11-10 Thread Segher Boessenkool
On Mon, Nov 10, 2014 at 05:36:24PM -0500, Michael Meissner wrote: However, the double pattern is completely broken. This cannot go in. [snip] It is unacceptable to have to do the inner loop doing a load, vector add, and store in the loop. Before the patch, the final reduction used

Re: [patch] OpenACC fortran front end

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 02:43:38PM -0800, Cesar Philippidis wrote: I'll post a separate patch with the fortran tests later. If anyone wants to test this patch, please use gomp-4_0-branch instead. You don't need a CUDA accelerator to use OpenACC, and some of the runtime tests will fail

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:27:50PM -0500, David Malcolm wrote: On Sat, 2014-11-08 at 14:56 +0100, Jakub Jelinek wrote: On Sat, Nov 08, 2014 at 01:07:28PM +0100, Richard Biener wrote: To be constructive here - the above case is from within a GIMPLE_ASSIGN case label and thus I'd have

FW: [PATCH, aarch64] Add prefetch support

2014-11-10 Thread Gopalasubramanian, Ganesh
PING! I am worried if it goes in stage-1. -Original Message- From: Gopalasubramanian, Ganesh Sent: Thursday, October 30, 2014 2:24 PM To: gcc-patches@gcc.gnu.org Subject: [PATCH, aarch64] Add prefetch support Hi, Below is the patch that implements prefetching support. This patch has

[PING^3][PATCH, AArch64] Add support for -mlong-calls option

2014-11-10 Thread Yangfei (Felix)
Hi, Dose anybody have time to review this? Thanks. Hello, Ping for https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02933.html Thanks

Re: [PATCH] c++ify sreal

2014-11-10 Thread Uros Bizjak
Hello! do $subject, and cleanup for always 64 bit hwi. bootstrapped + regtested x86_64-unknown-linux-gnu, ok? Ok. Can you please replace remaining HOST_WIDE_INT vestiges in there with [u]int64_t please? This patch breaks the build on debian 6.0: ../../gcc/sreal.c: In member function

Fix coverage inaccuracy with return in C/C++

2014-11-10 Thread Eric Botcazou
We just remarked that there is a coverage inaccuracy in C/C++ for something as simple as: void foo (int i) { if (i 1) return; bar (); } The return line is always reported as covered, even at -O0. That's because the return is used as the representative return for the entire function

[PATCH][14/n] Merge from match-and-simplify, more conversion patterns

2014-11-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener rguent...@suse.de * match.pd: Move rest of the conversion combining patterns from tree-ssa-forwprop.c. * tree-ssa-forwprop.c (combine_conversions): Remove.

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Roman Gareev
The patch looks great. The only piece I think we missed is the fgraphite-code-generator flag. I would propose to remove it as well in this commit, as it does not have any effect any more. In this case, we’ll also have to change tests which use fgraphite-code-generator flag

[PATCH GCC]Fix checking on MAX_PENDING_LIST_LENGTH

2014-11-10 Thread Bin Cheng
Hi, There is parameter max-pending-list-length in gcc scheduler, but the parameter is checked using greater than condition. As a result, the real max pending list length is actually max-pending-list-length + 1. This patch fixes this by using = rather than comparison operator. Though it is kind

[PATCH] Fix a few UNRESOLVEDs

2014-11-10 Thread Marek Polacek
This fixes a few UNRESOLVEDs because I forgot to skip -fno-fat-lto-objects when I introduced the tests. Ok for trunk? 2014-11-10 Marek Polacek pola...@redhat.com * c-c++-common/ubsan/align-7.c: Skip for -flto -fno-fat-lto-objects. * c-c++-common/ubsan/align-8.c: Likewise.

Re: [PATCH] AIX: Filename-based shared library versioning for libgcc_s

2014-11-10 Thread Michael Haubenwallner
Am 2014-11-07 20:52, schrieb David Edelsohn: First, please explicitly copy me on AIX or PowerPC patches sent to gcc-patches. I don't have a fundamental objection to including this option, but note that Richi, Honza and I have discovered that using AIX runtime linking option interacts

[PATCH] Fix PR63798

2014-11-10 Thread Richard Biener
The following patch fixes a latent bug uncovered by stmt folding that expansion of FMA_EXPR didn't consider the multiplication commutative when looking for feeding negates. Bootstrap regtest pending. Richard. 2014-11-10 Richard Biener rguent...@suse.de PR middle-end/63798 *

Re: [PATCH] Fix a few UNRESOLVEDs

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 10:41:36AM +0100, Marek Polacek wrote: This fixes a few UNRESOLVEDs because I forgot to skip -fno-fat-lto-objects when I introduced the tests. Ok for trunk? 2014-11-10 Marek Polacek pola...@redhat.com * c-c++-common/ubsan/align-7.c: Skip for -flto

[PATCH] IPA ICF fallout: disable IPA ICF for a test

2014-11-10 Thread Martin Liška
Hello. In gcc.dg/tree-ssa/ldist-19.c, there's a pair of functions (one with 'char' and second with 'unsigned char'). These two functions are merged by IPA ICF on targets that where 'char' == 'unsigned char'. So that it would be easier to disable the optimization. Ready for trunk? Thanks,

[PATCH][15/n] Merge from match-and-simplify, last conversion pattern

2014-11-10 Thread Richard Biener
This merges the last conversion pattern from tree-ssa-forwprop.c. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener rguent...@suse.de * match.pd: Implement pattern from simplify_conversion_from_bitmask. * tree-ssa-forwprop.c

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Richard Biener
On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu hongjiu...@intel.com wrote: Hi, r216964 disables bootstrap for libcc1 which exposed 2 things: 1. libcc1 isn't compiled with LTO even when GCC is configured with --with-build-config=bootstrap-lto. It may be intentional since libcc1 is disabled for

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Richard Biener
On Sun, Nov 9, 2014 at 5:57 PM, Jack Howarth howarth.at@gmail.com wrote: Iain, It doesn't look like it will be that simple. If I replace the proposed patches with a change like... Index: gcc/system.h === ---

Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

2014-11-10 Thread Tobias Grosser
On 10.11.2014 10:03, Roman Gareev wrote: The patch looks great. The only piece I think we missed is the fgraphite-code-generator flag. I would propose to remove it as well in this commit, as it does not have any effect any more. In this case, we’ll also have to change tests which use

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 2:33 AM, Patrick Palka patr...@parcs.ath.cx wrote: PR 63748 reports a false-positive uninitialized warning under the presence of abnormal edges. The statements for which the uninitialized warnings are emitted all look like: buf_117(ab) = buf_317(D)(ab); This PR is

Re: [PATCH GCC]Fix checking on MAX_PENDING_LIST_LENGTH

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 10:16 AM, Bin Cheng bin.ch...@arm.com wrote: Hi, There is parameter max-pending-list-length in gcc scheduler, but the parameter is checked using greater than condition. As a result, the real max pending list length is actually max-pending-list-length + 1. This patch

Re: [PATCH] IPA ICF fallout: disable IPA ICF for a test

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 11:51 AM, Martin Liška mli...@suse.cz wrote: Hello. In gcc.dg/tree-ssa/ldist-19.c, there's a pair of functions (one with 'char' and second with 'unsigned char'). These two functions are merged by IPA ICF on targets that where 'char' == 'unsigned char'. So that it would

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Eric Botcazou
Full bootstrap + regtesting on x86_64-unknown-linux-gnu is in progress. Is this patch OK if testing succeeds with no new regressions? ... ok. But please watch for fallout. I'd do a bootstrap with Ada enabled, the Ada compiler is the only serious user of abnormal edges in GIMPLE on Linux

Re: [PATCH] Fix PR63798

2014-11-10 Thread Václav Zeman
On 10 November 2014 10:55, Richard Biener wrote: The following patch fixes a latent bug uncovered by stmt folding that expansion of FMA_EXPR didn't consider the multiplication commutative when looking for feeding negates. Bootstrap regtest pending. Richard. 2014-11-10 Richard Biener

Re: [RFC] Elimination of zext/sext - type promotion pass

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 12:29 AM, Kugan kugan.vivekanandara...@linaro.org wrote: Well - the best way would be to expose the target specifics to GIMPLE at some point in the optimization pipeline. My guess would be that it's appropriate after loop optimizations (but maybe before induction

[PATCH] Plug SSA stmt operand leak

2014-11-10 Thread Richard Biener
The following patch plugs a leak in SSA stmt operands. finalize_ssa_uses always frees all old operands and then allocates new ones - but in freeing the old operands it only inserts the first freed one into the freelist. The following patch makes us use the same trick as free_stmt_operands to

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread Ilya Enkovich
2014-11-10 14:53 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Sun, Nov 9, 2014 at 5:57 PM, Jack Howarth howarth.at@gmail.com wrote: Iain, It doesn't look like it will be that simple. If I replace the proposed patches with a change like... Index: gcc/system.h

Re: [PATCH 7/8] Model cache auto-prefetcher in scheduler

2014-11-10 Thread Maxim Kuvyrkov
On Oct 21, 2014, at 8:06 AM, Maxim Kuvyrkov maxim.kuvyr...@linaro.org wrote: Hi, This patch adds auto-prefetcher modeling to GCC scheduler. The auto-prefetcher model is currently enabled only for ARM Cortex-A15, since this is the only CPU that I know of to have the hardware

Re: Fix libgomp crash without TLS (PR42616)

2014-11-10 Thread Varvara Rainchik
*Ping* 2014-10-13 14:48 GMT+04:00 Varvara Rainchik varvara.s.rainc...@gmail.com: Now, I wonder on which OS and why does config/tls.m4 CHECK_GCC_TLS actually fail? Can you figure that out? On Android check passes with --disable-tls (standard while building gcc for Android as TLS is not

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread H.J. Lu
On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu hongjiu...@intel.com wrote: Hi, r216964 disables bootstrap for libcc1 which exposed 2 things: 1. libcc1 isn't

[match-and-simplify] operator-lists in expression

2014-11-10 Thread Prathamesh Kulkarni
Hi, This patch adds support for operator-lists to be used in expression. I reuse operator-list as the iterator. This is not really valid since user-defined operator-lists cannot be iterator in 'for', but it was convenient to reuse operator-list as a 'for' iterator and lower_for doesn't care

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: On Sun, Nov 9, 2014 at 5:46 PM, H.J. Lu hongjiu...@intel.com wrote: Hi, r216964 disables

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Richard Biener
On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Nov 10, 2014 at 05:32:32AM -0800, H.J. Lu wrote: On Mon, Nov 10, 2014 at 4:05 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Nov 10, 2014 at 12:50:44PM +0100, Richard Biener wrote: On Sun, Nov 9, 2014 at 5:46

Re: [PATCH] Fix PR 63748

2014-11-10 Thread Patrick Palka
On Mon, Nov 10, 2014 at 7:22 AM, Eric Botcazou ebotca...@adacore.com wrote: Full bootstrap + regtesting on x86_64-unknown-linux-gnu is in progress. Is this patch OK if testing succeeds with no new regressions? ... ok. But please watch for fallout. I'd do a bootstrap with Ada enabled, the

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Dominik Vogt
I'd still like to avoid the rampant duplication if possible. One approach would be to put most of the test in something like nilptr_tests.go marked with // skip. Then we can have top-level nilptrXX.go tests with +build lines that use // run nilptr_tests.go. I fail to see how that could be

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 02:44:55PM +0100, Richard Biener wrote: I admit I haven't tried LTO bootstrap, but from normal bootstrap logs, libcc1 is built normally using libtool using -fPIC only, and linked into libcc1.so.0.0.0 and libcc1plugin.so.0.0.0, and of course against the

[PATCH] Fix PR63800

2014-11-10 Thread Richard Biener
This fixes PR63800 which shows that PRE eliminate() avail handling is too simplistic with the code to avoid vectorization regressions. The following patch makes it properly restore old availability. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard

Re: [PATCH 3/4] Add libgomp plugin for Intel MIC

2014-11-10 Thread Ilya Verbin
On 06 Nov 19:25, Jakub Jelinek wrote: Oh, one more point, if mic_lib_path is NULL, what is the point to do the alloca/malloc and string copying? Can't you just setenv (MIC_LD_LIBRARY_PATH_ENV, ld_lib_path, 1); in that case early? Otherwise LGTM. Done. Thanks, -- Ilya --- diff

Re: Ping: FR-V rtx iterator patches

2014-11-10 Thread Nicholas Clifton
Hi Richard, Ping for these FR-V patches: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02645.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02646.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02647.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02648.html which convert callers of

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-10 Thread Ilya Verbin
On 06 Nov 18:55, Jakub Jelinek wrote: Looks mostly good, but: +# We need more things in site.exp, but automake completely controls the +# creation of that file; there's no way to append to it without messing up +# the dependancy chains. So we overrule automake. This rule is exactly +#

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread FX
Indeed string is a system header and should not have been included from tree-chkp.c but system.h Indeed. My knowledge of C++ is limited, but I think this additional patch to wide-int.h is the proper fix to the issue reported by Jack, no? I’m bootstrapping it right now, it already passed stage

Re: [PATCH][Revisedx2] Fix PR63750

2014-11-10 Thread FX
My knowledge of C++ is limited, but I think this additional patch to wide-int.h is the proper fix to the issue reported by Jack, no? I’m bootstrapping it right now, it already passed stage 2. Boostrapped succeeded on x86_64-apple-darwin14. OK to commit to trunk? string.diff Description:

Re: [testsuite,ARM] PR61153 Fix vbic and vorn tests

2014-11-10 Thread Christophe Lyon
On 30 October 2014 23:02, Christophe Lyon christophe.l...@linaro.org wrote: On 29 October 2014 16:28, Ramana Radhakrishnan ramana@googlemail.com wrote: On Wed, Oct 29, 2014 at 3:26 PM, Christophe Lyon christophe.l...@linaro.org wrote: Hi, In PR61153, the vbic and vorn tests fail because

[PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Joel Sherrill
2014-11-10 Joel Sherrill joel.sherr...@oarcorp.com * src/c++98/mt_allocator.cc: Fix assumption that sizeof(void *) is equal to sizeof(size_t). The m32c breaks this assumption. --- libstdc++-v3/src/c++98/mt_allocator.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[match-and-simplify] Remove supposedly dead code

2014-11-10 Thread Richard Biener
supposedly because there are a few regressions. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener rguent...@suse.de * tree-ssa-forwprop.c (simplify_conversion_from_bitmask): Remove. (associate_plusminus): Likewise.

[PATCH][16/n] Merge from match-and-simplify, simplify_mult pattern

2014-11-10 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2014-11-10 Richard Biener rguent...@suse.de * match.pd: Implement pattern from simplify_mult. * tree-ssa-forwprop.c (simplify_mult): Remove. (pass_forwprop::execute): Do not call simplify_mult.

Re: [PATCH] Reset contexts in possible_polymorphic_call_targets properly

2014-11-10 Thread Jan Hubicka
Hi in a patch I work on I store ipa_polymorphic_call_contexts in a vector and thus they do not get properly constructed, merely memset to zero. This means that I happen to be using know nothing contexts which have their outer_type set to NULL but the various flags are also false, unlike in

[PATCH] Fix for PR63766 (handle removed functions in do_per_function_toporder)

2014-11-10 Thread Ilya Enkovich
Hi, Here is a fix for PR63766. Currently all functions are transformed into SSA before local optimizations and it allows function to be inlined and removed before it goes through local optimzations. But this requires removal of these functions from working queue. Bootstrapped and tested on

Re: Add the latest C++ SD-6 additions.

2014-11-10 Thread Ed Smith-Rowland
On 11/09/2014 11:45 PM, Jason Merrill wrote: On 11/09/2014 08:33 PM, Ed Smith-Rowland wrote: + //cpp_hashnode *node = 0; + //node = token-val.node.node; + //if (node) + // pfile-mi_ind_cmacro = node; Remove this commented-out code? The patch is OK. Jason Here is the committed

Re: [PATCH] AIX: Filename-based shared library versioning for libgcc_s

2014-11-10 Thread David Edelsohn
On Mon, Nov 10, 2014 at 4:59 AM, Michael Haubenwallner michael.haubenwall...@ssi-schaefer.com wrote: Am 2014-11-07 20:52, schrieb David Edelsohn: First, please explicitly copy me on AIX or PowerPC patches sent to gcc-patches. I don't have a fundamental objection to including this option,

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-10 Thread Ian Taylor
On Mon, Nov 10, 2014 at 6:00 AM, Dominik Vogt v...@linux.vnet.ibm.com wrote: I'd still like to avoid the rampant duplication if possible. One approach would be to put most of the test in something like nilptr_tests.go marked with // skip. Then we can have top-level nilptrXX.go tests with

Re: [2/6] nvptx testsuite patches: typed assembly

2014-11-10 Thread Bernd Schmidt
On 10/21/2014 05:32 PM, Bernd Schmidt wrote: On 10/21/2014 05:16 PM, Jeff Law wrote: On 10/21/14 14:15, Bernd Schmidt wrote: Since everything in ptx assembly is typed, KR C is problematic. There are a number of testcases that call functions with the wrong number of arguments, or arguments of

Re: The nvptx port [10/11+] Target files

2014-11-10 Thread Bernd Schmidt
On 10/30/2014 12:35 AM, Jeff Law wrote: A nit -- Richard S. recently removed the need to include the enum for enum machine_mode. I believe he had a script to handle the mundane parts of that change. Please make sure to update the nvptx port to conform to that new convention, obviously feel

[C++ Patch] PR 63265

2014-11-10 Thread Paolo Carlini
Hi, as far as I can see this 4.9/5 regression, where we spuriously warn about the left shifts in the templates, has to do with r208183, where Jason replaced c_inhibit_evaluation_warnings fiddling in tsubst_copy_and_build with two warning_sentinels, on warn_type_limits and warn_div_by_zero.

Re: [C++ Patch] PR 63265

2014-11-10 Thread Jakub Jelinek
On Mon, Nov 10, 2014 at 05:32:49PM +0100, Paolo Carlini wrote: PR c++/63265 * c-family/c.opt ([Wshift-count-negative, Wshift-count-overflow]): Add. Note, c-family/ has its own ChangeLog. Jakub

Re: [PING][PATCH][AARCH64]Fix PR63424 by adding sumaxminv2di3 pattern

2014-11-10 Thread Renlin Li
On 06/11/14 15:00, Renlin Li wrote: Hi all, Dose anybody have time to review this? Kind regards, Renlin Li On 31/10/14 14:51, Renlin Li wrote: Hi all, This is a patch which will fix PR63424. It implements signed/unsigned max/min pattern for V2DI mode in terms of vcondv2div2di pattern.

[PING][PATCH]Partially fix PR61529, bound basic block frequency

2014-11-10 Thread Renlin Li
On 06/11/14 18:07, Renlin Li wrote: On 06/11/14 17:59, Teresa Johnson wrote: Thanks for fixing the test case. Can you also add the comment I suggested to the source change? Please add a comment that this is needed due to insane incoming frequencies. Sorry, I mistakenly add it to the

  1   2   >