Re: [PATCH][AArch64] Implement TARGET_SCHED_MACRO_FUSION_PAIR_P

2014-11-13 Thread Kyrill Tkachov
On 13/11/14 07:24, Andrew Pinski wrote: On Tue, Nov 11, 2014 at 3:55 AM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Hi all, This is the aarch64 implementation of the macro fusion hook, used to fuse mov+movk instructions together. A new field is declared in the tuning struct and as we add

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2014-11-13 Thread Jan Hubicka
Incrementally I would like to handle optimizations nodes same way and change streaming format to be a set of assignments field_name=value. This way we could behave sanely when some field is introduced or removed by either defaulting it or ignoring it. I'm not sure that idea is good

Re: [PATCH] Add a way to mark regions of code which assume that the GC won't run

2014-11-13 Thread David Malcolm
On Thu, 2014-11-13 at 11:22 +0100, Richard Biener wrote: On Wed, Nov 12, 2014 at 11:04 PM, David Malcolm dmalc...@redhat.com wrote: On Wed, 2014-11-12 at 13:16 -0500, David Malcolm wrote: We make assumptions in the codebase about when the GC can run, and when it can't (e.g. within numerous

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 06:46:23AM -0800, Teresa Johnson wrote: --- tree.c (revision 217190) +++ tree.c (working copy) @@ -10330,6 +10330,8 @@ initializer_zerop (const_tree init) { unsigned

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Jan Hubicka
gcc/ChangeLog: 2014-11-12 Martin Liska mli...@suse.cz * Makefile.in: New object file is added. * cgraph.h (symbol_table::allocate_cgraph_symbol): Summary UID is filled up. * cgraph_summary.c: New file. * cgraph_summary.h: New file. Since I am trying to

Re: [PATCH, libgfortran] PR 60324 Unbounded stack allocations in libgfortran

2014-11-13 Thread Marek Polacek
On Thu, Nov 13, 2014 at 02:05:52PM +0200, Janne Blomqvist wrote: Thanks for the quick review, committed as r217480. This broke bootstrap because of implicit declaration of free. The following (untested) should fix it, ok for trunk? 2014-11-13 Marek Polacek pola...@redhat.com *

Re: [PATCH, libgfortran] PR 60324 Unbounded stack allocations in libgfortran

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 04:57:08PM +0100, Marek Polacek wrote: On Thu, Nov 13, 2014 at 02:05:52PM +0200, Janne Blomqvist wrote: Thanks for the quick review, committed as r217480. This broke bootstrap because of implicit declaration of free. The following (untested) should fix it, ok for

Re: [PATCH] Make -fdiagnostics-color= default configurable, default to =auto

2014-11-13 Thread Manuel López-Ibáñez
On 13 November 2014 07:53, Jakub Jelinek ja...@redhat.com wrote: Apart from that, I really cannot understand why someone would want the options none, auto or always: none is equivalent to auto-if-env but without the if-env escape route, and neither auto nor always allow disabling the coloring

RE: [PATCH 1/3, ARM, libgcc, ping5] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2014-11-13 Thread Thomas Preud'homme
[Taking over Tony's patch] Ping? Best regards, Thomas -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Tony Wang Sent: Thursday, August 21, 2014 7:15 AM To: gcc-patches@gcc.gnu.org Subject: [PATCH 1/3,ARM,libgcc]Code size

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

2014-11-13 Thread Jan Hubicka
+ if (!inline_summary_summary) +inline_summary_summary = (inline_summary_cgraph_summary *) inline_summary_cgraph_summary::create_ggc (symtab); Hehe, this is funny naming scheme. Peraps inline_summary_d and inline_summary_t for the data and type? - -static void

RE: [PATCH 2/3, ARM, libgcc, ping5] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2014-11-13 Thread Thomas Preud'homme
[Taking over Tony's patch] Ping? Best regards, Thomas -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Tony Wang Sent: Thursday, August 21, 2014 7:15 AM To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/3,ARM,libgcc]Code size

RE: [PATCH 3/3, ARM, libgcc, ping5] Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2014-11-13 Thread Thomas Preud'homme
[Taking over Tony's patch] Ping? Best regards, Thomas -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Tony Wang Sent: Thursday, August 21, 2014 7:15 AM To: gcc-patches@gcc.gnu.org Subject: [PATCH 3/3,ARM,libgcc]Code size

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 Thread Jason Merrill
On 11/13/2014 05:47 AM, Paolo Carlini wrote: shall we do something like the below? Something similar, yes. Though it would also be nice to avoid the redundant checking in the two functions: we only want to do constexpr folding if we did the tsubst. Kai is working on folding changes, so I

Re: [PR c/52952] More precise locations within format strings

2014-11-13 Thread Manuel López-Ibáñez
On 12 November 2014 15:54, Manuel López-Ibáñez lopeziba...@gmail.com wrote: On 12 November 2014 15:38, Marek Polacek pola...@redhat.com wrote: On Wed, Nov 12, 2014 at 03:35:06PM +0100, Manuel López-Ibáñez wrote: ../../libcpp/line-map.c:667:65: error: suggest braces around empty body in an

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 Thread Kai Tietz
2014-11-13 17:10 GMT+01:00 Jason Merrill ja...@redhat.com: On 11/13/2014 05:47 AM, Paolo Carlini wrote: shall we do something like the below? Something similar, yes. Though it would also be nice to avoid the redundant checking in the two functions: we only want to do constexpr folding if

Re: [patch] OpenACC fortran front end

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 06, 2014 at 02:25:52PM -0800, Cesar Philippidis wrote: * cpp.c (cpp_define_builtins): Conditionally define _OPENACC. * dump-parse-tree.c (show_omp_node): Dump also OpenACC executable statements. Put (show_omp_node): ... and what fits on the same line as *

[c++-concepts] merge from trunk

2014-11-13 Thread Andrew Sutton
I just merged the concepts branch with trunk, after fighting with the testing framework for the past hour. There was a change to gcc/testsuite/lib/prune.exp yesterday that doesn't appear to be compatible with *something* in this branch. It broke the entire test suite, giving the errors below for

[PATCH][ARM] Use Cortex-A17 tuning parameters for Cortex-A12

2014-11-13 Thread Kyrill Tkachov
Hi all, The Cortex-A12 very close to the Cortex-A17 and this patch updates the tuning struct parameters to match the Cortex-A17 ones. This has improved performance in a number of benchmarks that I tried. The instruction scheduling is also changed to match the Cortex-A17 scheduling Tested

[PATCH][ARM] Add Cortex-A17 support

2014-11-13 Thread Kyrill Tkachov
Hi all, This patch adds support for the Cortex-A17 processor to the arm backend. Cortex-A17 is an ARMv7ve core with the same architectural features as the Cortex-A7, A12 and A15 cores. The -m{tune, cpu}=cortex-a17 option is added and a pipeline description for instruction scheduling is

Re: [patch, aarch64] additional bics patterns

2014-11-13 Thread Richard Earnshaw
On 13/11/14 17:05, Ramana Radhakrishnan wrote: On Thu, Nov 13, 2014 at 4:55 PM, Sandra Loosemore san...@codesourcery.com wrote: This patch to the AArch64 back end adds a couple of additional bics patterns to match code of the form if ((x y) == x) ...; This is testing whether the bits

Re: [PR c/52952] More precise locations within format strings

2014-11-13 Thread Jeff Law
On 11/10/14 02:57, Dodji Seketeli wrote: FWIW, I am willing to help with the line map sub-system, of course. Thank you for your confidence. OK, let's go ahead and make that official. Please update MAINTAINERS ;-) jeff

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread Jeff Law
On 11/12/14 03:02, Alexander Ivchenko wrote: Hi, Bionic - Android libc - supports indirect functions right now, but they are disabled in gcc; We cannot do the configure-time check for that, because there is only one version of each compiler shipped in ndk for all Android platforms. On the

Re: [patch, aarch64] additional bics patterns

2014-11-13 Thread Sandra Loosemore
On 11/13/2014 10:27 AM, Richard Earnshaw wrote: On 13/11/14 17:05, Ramana Radhakrishnan wrote: On Thu, Nov 13, 2014 at 4:55 PM, Sandra Loosemore san...@codesourcery.com wrote: This patch to the AArch64 back end adds a couple of additional bics patterns to match code of the form if ((x y)

[PATCH] plugin event for C/C++ function definitions

2014-11-13 Thread Andres Tiraboschi
Hi, this patch adds a new plugin event PLUGIN_START_FUNCTION and PLUGIN_FINISH_FUNCTION that are invoked at start_function and finish_function respectively in the C and C++ frontends. PLUGIN_START_FUNCTION is called before parsing the function body. PLUGIN_FINISH_FUNCTION is called after

Re: [patch, aarch64] additional bics patterns

2014-11-13 Thread Andrew Pinski
On Thu, Nov 13, 2014 at 9:42 AM, Sandra Loosemore san...@codesourcery.com wrote: On 11/13/2014 10:27 AM, Richard Earnshaw wrote: On 13/11/14 17:05, Ramana Radhakrishnan wrote: On Thu, Nov 13, 2014 at 4:55 PM, Sandra Loosemore san...@codesourcery.com wrote: This patch to the AArch64 back

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 Thread Paolo Carlini
Hi, On 11/13/2014 05:42 PM, Jason Merrill wrote: On 11/13/2014 11:10 AM, Jason Merrill wrote: On 11/13/2014 05:47 AM, Paolo Carlini wrote: shall we do something like the below? Something similar, yes. Though it would also be nice to avoid the redundant checking in the two functions: we

Re: [Android] Enable ifuncs on Android

2014-11-13 Thread enh
On Thu, Nov 13, 2014 at 9:36 AM, Jeff Law l...@redhat.com wrote: On 11/12/14 03:02, Alexander Ivchenko wrote: Hi, Bionic - Android libc - supports indirect functions right now, but they are disabled in gcc; We cannot do the configure-time check for that, because there is only one version

Re: [PATCH, libgfortran] PR 60324 Unbounded stack allocations in libgfortran

2014-11-13 Thread Marek Polacek
On Thu, Nov 13, 2014 at 04:59:09PM +0100, Jakub Jelinek wrote: On Thu, Nov 13, 2014 at 04:57:08PM +0100, Marek Polacek wrote: On Thu, Nov 13, 2014 at 02:05:52PM +0200, Janne Blomqvist wrote: Thanks for the quick review, committed as r217480. This broke bootstrap because of implicit

[PATCH PC preprocessor/63831] - [5 Regression] r217292 causes segfaults with -MM

2014-11-13 Thread Ed Smith-Rowland
There were segfaults on preprocess-only involving __has_attribute. -MM and -E both bombed with __has_attribute. Several codebases use __has_attribute this (because of clang). This problem would have been found with the SD-6 macro __has_cpp_attribute as well so just taking out the extra macro

Re: OpenACC middle end changes

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 05:59:11PM +0100, Thomas Schwinge wrote: * should gcc/oacc-builtins.def just be merged into gcc/omp-builtins.def; Why not. The reason why they aren't in gcc/builtins.def is that the Fortran FE doesn't source those, but OpenACC supports the same languages as

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 Thread Jason Merrill
On 11/13/2014 12:48 PM, Paolo Carlini wrote: While we are at it, can you double check that in end_maybe_infinite_loop we really want the non-sfinae version (which in principle can emit hard errors): the inconsistency with begin_maybe_infinite_loop seems weird to me... I agree, let's use the

[google gcc-4.9] FDO build for linux kernel

2014-11-13 Thread Rong Xu
Here is patch that ports our work on FDO linux kernel build support to gcc-4_9. With this patch, kernel will use the libgcov functions to dump the gcda files. This patch also enables LIPO build. But the module grouping is not computed online. We will use gcov-tool to do this offline. Tested with

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-13 Thread Ulrich Weigand
Richard Henderson wrote: On 11/12/2014 09:41 PM, Ulrich Weigand wrote: * optabs.c (prepare_operand): Gracefully fail if the mode of X does not match the operand mode expected by the insn pattern. This is ok. I've checked this in now, thanks. I wondered whether s390 benefit from

Re: Re: OpenACC middle end changes

2014-11-13 Thread Cesar Philippidis
I'll try to respond to the reduction stuff. It's been a while since I started working on it, so I may have lost some state. On 11/13/2014 10:09 AM, Jakub Jelinek wrote: @@ -233,6 +242,90 @@ static tree scan_omp_1_op (tree *, int *, void *); *handled_ops_p = false; \ break;

Re: Re: OpenACC middle end changes

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 11:03:47AM -0800, Cesar Philippidis wrote: @@ -233,6 +242,90 @@ static tree scan_omp_1_op (tree *, int *, void *); *handled_ops_p = false; \ break; +/* Helper function to get the reduction array name */ +static const char * +omp_get_id (tree

PATCH: PR gas/17598: R_X86_64_GOTPLT64 relocation isn't tested

2014-11-13 Thread H.J. Lu
Hi, R_X86_64_GOTPLT64 isn't necessary and R_X86_64_GOT64 should be used instead. I checked in this patch to add assembler support for @gotplt, but treat R_X86_64_GOTPLT64 the same R_X86_64_GOT64. There should be no impact on GCC since GCC never generates R_X86_64_GOTPLT64 and R_X86_64_GOT64 is

Re: PATCH: PR gas/17598: R_X86_64_GOTPLT64 relocation isn't tested

2014-11-13 Thread H.J. Lu
On Thu, Nov 13, 2014 at 11:13 AM, H.J. Lu hongjiu...@intel.com wrote: Hi, R_X86_64_GOTPLT64 isn't necessary and R_X86_64_GOT64 should be used instead. I checked in this patch to add assembler support for @gotplt, but treat R_X86_64_GOTPLT64 the same R_X86_64_GOT64. There should be no

bitmap fix for current

2014-11-13 Thread Mike Stump
I was doing a merge, and it failed to even compile the runtime libraries due to checking in bitmap. bitmap goes to remove set bits from the bitmap (the second hunk in a two hunk set), and it fails to update the current pointer. That memory is freed and then reallocated and a new index is put

Re: [PATCH 01/27] gcc: configure and Makefile changes needed by jit

2014-11-13 Thread Thomas Schwinge
Hi! JIT/GCC as a shared library merged! \o/ On Fri, 31 Oct 2014 13:02:34 -0400, David Malcolm dmalc...@redhat.com wrote: An earlier version of this was posted as: [PATCH 2/5] gcc: configure and Makefile changes needed by jit https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01169.html

Re: [google gcc-4.9] FDO build for linux kernel

2014-11-13 Thread Xinliang David Li
ok. (the way to detect kernel build looks unpolished, but there does not seem to be a consistent way of doing it. Some targets have kernel specific flags ..) On Thu, Nov 13, 2014 at 10:40 AM, Rong Xu x...@google.com wrote: Here is patch that ports our work on FDO linux kernel build support to

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-13 Thread Iain Sandoe
Hello Richard, Joseph, Thanks for your reviews, On 13 Nov 2014, at 07:40, Richard Henderson wrote: On 11/12/2014 10:18 PM, Iain Sandoe wrote: # ifndef USE_ATOMIC #define USE_ATOMIC 1 # endif Why would USE_ATOMIC be defined previously? This was left-over from a mode where I

[PATCH 6/9] fibonacci_heap is used for var-tracking.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * var-tracking.c (vt_find_locations): New fibonacci_node is used. --- gcc/var-tracking.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/gcc/var-tracking.c

[PATCH 3/9] fibonacci_heap is used for bb-reoder purpose.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * bb-reorder.c (mark_bb_visited): New fibonacci_heap is used. (find_traces): Likewise. (find_traces_1_round): Likewise. --- gcc/bb-reorder.c | 54 +++--- 1 file

[PATCH 9/9] ipa-inline uses sreal for as fibonacci_heap template argument.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * ipa-inline.c (edge_badness): long is replaced by sreal as fibonacci_heap template type. (update_edge_key): Likewise. (inline_small_functions): Likewise. * sreal.h (inline sreal operator): New

[PATCH 1/9] New fibonacci heap and sreal enhancement.

2014-11-13 Thread mliska
Hello. Following patch set introduces new template class for fibonacci heap that is mainly utilized by IPA inliner. Apart from that, I also enhanced existing sreal implementation so that it can also handle negative numbers. I was primary motivated by Honza, because current heap implementation in

[PATCH 4/9] tracer ported to new fibonacci_heap data structure.

2014-11-13 Thread mliska
2014-11-13 Martin Liska mli...@suse.cz * tracer.c (tail_duplicate): New fibonacci_heap class is used. --- gcc/tracer.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/gcc/tracer.c b/gcc/tracer.c index b3a412c..cecefdc 100644 ---

[PATCH 5/9] bt-load is ported to fibonacci_heap.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * bt-load.c (add_btr_def): New fibonacci_heap is used. (migrate_btr_defs): Likewise. --- gcc/bt-load.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/gcc/bt-load.c

[PATCH 7/9] Old libiberty fib_heap removed.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * bb-reorder.c (find_traces_1_round): Old fibheap_t type removed. * bt-load.c: Include of fibheap.h is removed. * cgraphunit.c: Likewise. * config/i386/i386.c: Likewise. * ipa-inline.c: Likewise.

Re: libsanitizer merge from upstream r221802

2014-11-13 Thread Konstantin Serebryany
On Thu, Nov 13, 2014 at 1:16 AM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Nov 12, 2014 at 05:35:48PM -0800, Konstantin Serebryany wrote: Here is one more merge of libsanitizer (last one was in Sept). Tested on x86_64 Ubuntu 14.04 like this: rm -rf */{*/,}libsanitizer make -j 50 make -j

[PATCH 2/9] New template fibonacci_heap class introduced.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * fibonacci_heap.h: New file. * ipa-inline.c (update_edge_key): New heap API is used. (update_caller_keys): Likewise. (update_callee_keys): Likewise. (lookup_recursive_calls): Likewise.

[PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread mliska
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * predict.c (propagate_freq): More elegant sreal API is used. (estimate_bb_frequencies): New static constants defined by sreal replace precomputed ones. * sreal.c (sreal::normalize): New function.

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 7:39 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: And for release branches I'd really prefer tree-ssa-strlen.c change. Ok, I started testing the initializer_zerop change on the 4_9 branch, will

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 12:51:05PM -0800, Teresa Johnson wrote: On Thu, Nov 13, 2014 at 7:39 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: And for release branches I'd really prefer tree-ssa-strlen.c change. Ok, I

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-13 Thread Joseph Myers
On Thu, 13 Nov 2014, Ilya Enkovich wrote: You can leave it as a single library - it's just that imposes libgcc-like constraints on what the library does and how it does things, so as to be usable for arbitrary programs built with MPX (e.g. using reserved-namespace names such as __write

Re: Add used_by_single_function flag for static variables

2014-11-13 Thread Bernhard Reutner-Fischer
Honza, On 23 June 2014 06:24, Jan Hubicka hubi...@ucw.cz wrote: --- lto-cgraph.c(revision 211881) +++ lto-cgraph.c(working copy) @@ -614,6 +614,7 @@ lto_output_varpool_node (struct lto_simp /* in_other_partition. */ } bp_pack_value (bp, node-tls_model,

RE: [PATCH, RFC, C] Add -fno-float to forbid floating point data types

2014-11-13 Thread Joseph Myers
On Thu, 13 Nov 2014, Thomas Preud'homme wrote: From: Joseph Myers [mailto:jos...@codesourcery.com] Sent: Wednesday, November 12, 2014 10:11 PM This patch modifies the C parser to give an error if: - any variable or function parameter is declared with a float type or a type

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: On 2014.11.13 at 15:11 +0100, mliska wrote: Just two remarks: +template class T +class GTY((user)) cgraph_summary T * +{ +public: + /* Default construction takes SYMTAB as an argument. */ + cgraph_summary

Re: [C++ Patch] Add maybe_constant_folded_value

2014-11-13 Thread Paolo Carlini
Hi, On 11/13/2014 07:31 PM, Jason Merrill wrote: On 11/13/2014 12:48 PM, Paolo Carlini wrote: While we are at it, can you double check that in end_maybe_infinite_loop we really want the non-sfinae version (which in principle can emit hard errors): the inconsistency with

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 12:55 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 12:51:05PM -0800, Teresa Johnson wrote: On Thu, Nov 13, 2014 at 7:39 AM, Teresa Johnson tejohn...@google.com wrote: On Thu, Nov 13, 2014 at 7:12 AM, Jakub Jelinek ja...@redhat.com wrote: And for

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 01:33:07PM -0800, Teresa Johnson wrote: Supposedly the printfs should have been removed and the #include cstdio isn't needed then either. No need to clutter the test output and log files. On the other side, tests should abort (); or __builtin_abort (); on failure,

[PATCH] -fsanitize=unreachable overhaul (PR sanitizer/63839)

2014-11-13 Thread Marek Polacek
As Richi pointed in the pr audit trail, instrumenting via folding is bad. In this case we changed __builtin_unreachable, created by the inliner, into BUILT_IN_UBSAN_HANDLE_BUILTIN_UNREACHABLE which requires VOPS, which is a no-no in folding. So this patch: - marks

Re: [PATCH][ARM] Add Cortex-A17 support

2014-11-13 Thread Joseph Myers
New -mcpu= values need documenting in invoke.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-13 Thread Teresa Johnson
On Thu, Nov 13, 2014 at 1:45 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Nov 13, 2014 at 01:33:07PM -0800, Teresa Johnson wrote: Supposedly the printfs should have been removed and the #include cstdio isn't needed then either. No need to clutter the test output and log files. On

[PATCH] Remove doubled ECF_LEAF

2014-11-13 Thread Marek Polacek
Bootstrapped/regtested on power8-linux, ok for trunk? 2014-11-13 Marek Polacek pola...@redhat.com * tree.c (build_common_builtin_nodes): Remove doubled ECF_LEAF. diff --git gcc/tree.c gcc/tree.c index cf37a19..5c6fe0b 100644 --- gcc/tree.c +++ gcc/tree.c @@ -9935,7 +9935,7 @@

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-13 Thread Tobias Burnus
Hi all, since everyone seems to agree that it makes in principle sense to have a reduce libgfortran (even though a full one is nicer, if the system permits), let's look at the patch itself ;-) Bernd Schmidt wrote: The ptx port by its nature is lacking features that are expected on normal

Re: OpenACC middle end changes

2014-11-13 Thread Joseph Myers
On Thu, 13 Nov 2014, Thomas Schwinge wrote: gcc/doc/invoke.texi | 14 You're adding documentation for -fopenacc, but I don't see any .opt file changes in this patch, and I'd expect the option to be added in the same patch as its documentation. -- Joseph S. Myers

Re: [PATCH] OpenACC for C front end

2014-11-13 Thread Joseph Myers
On Wed, 5 Nov 2014, James Norris wrote: Hi! This patch represents the changes for OpenACC 2.0 in the C front-end. At present these files will not compile as the changes for the middle end are not present. So will things compile with the combination of this patch and the middle-end patch

[PATCH][COMMITTED] Fix PR63853 - Remove strchrnul to fix bootstrap on non-GNU platforms

2014-11-13 Thread Ilya Verbin
Hi, I committed a patch from Dominique d'Humieres to restore bootsrap broken by our offloading patches. Thanks, -- Ilya 2014-11-13 Dominique Dhumieres domi...@lps.ens.fr PR bootstrap/63853 gcc/ * gcc.c (handle_foffload_option): Replace strchrnul with strchr. *

Re: [PATCH] Disable -fuse-caller-save when -pg is active

2014-11-13 Thread Mike Stump
On Nov 13, 2014, at 9:21 AM, Jeff Law l...@redhat.com wrote: Presumably we can get the same kinds of problems with ports that don't emit prologues/epilogues as RTL? I use prologue/epilogue to emit rtl in my port. I’d like this optimization to kick on in my port, as we do explain everything

Re: [PATCH 3/5] IPA ICF pass

2014-11-13 Thread H.J. Lu
On Wed, Oct 15, 2014 at 10:03 AM, Martin Liška mli...@suse.cz wrote: Hello There's final version of the patch I'm going to commit tomorrow in the morning (CEST). Thank you Honza for the review. Martin This caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63856 -- H.J.

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Markus Trippelsdorf
On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: On 2014.11.13 at 15:11 +0100, mliska wrote: + /* Destructor. */ + virtual ~cgraph_summary () + { +destroy (); + } From

[GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Dehao Chen
In AutoFDO, we increase einline iterations. This could lead to extensive code bloat if we have recursive calls like: dtor() { destroy(node); } destroy(node) { destroy(left) destroy(right) } In this case, the size growth will be around 8 which is smaller than threshold (11). However, if we

Re: [PATCH][AArch64] Implement TARGET_SCHED_MACRO_FUSION_PAIR_P

2014-11-13 Thread Andrew Pinski
On Thu, Nov 13, 2014 at 7:19 AM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: On 13/11/14 07:24, Andrew Pinski wrote: On Tue, Nov 11, 2014 at 3:55 AM, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Hi all, This is the aarch64 implementation of the macro fusion hook, used to fuse mov+movk

Re: [patch] Support embedded zeros in sub_match comparisons (DR 2217)

2014-11-13 Thread Tim Shen
On Thu, Nov 13, 2014 at 2:11 PM, Daniel Krügler daniel.krueg...@gmail.com wrote: + typedef typename sub_match_Bi_iter::string_type string_type; Use _String_type instead of string_type? I'm not 100% sure of this. -- Regards, Tim Shen

Re: [PATCH] Disable -fuse-caller-save when -pg is active

2014-11-13 Thread Jeff Law
On 11/13/14 15:14, Mike Stump wrote: On Nov 13, 2014, at 9:21 AM, Jeff Law l...@redhat.com wrote: Presumably we can get the same kinds of problems with ports that don't emit prologues/epilogues as RTL? I use prologue/epilogue to emit rtl in my port. I’d like this optimization to kick on in

Re: [patch] Support embedded zeros in sub_match comparisons (DR 2217)

2014-11-13 Thread Daniel Krügler
2014-11-13 23:30 GMT+01:00 Tim Shen tims...@google.com: On Thu, Nov 13, 2014 at 2:11 PM, Daniel Krügler daniel.krueg...@gmail.com wrote: + typedef typename sub_match_Bi_iter::string_type string_type; Use _String_type instead of string_type? I'm not 100% sure of this. I thought about

Re: [patch, aarch64] additional bics patterns

2014-11-13 Thread Sandra Loosemore
On 11/13/2014 10:47 AM, Andrew Pinski wrote: On Thu, Nov 13, 2014 at 9:42 AM, Sandra Loosemore san...@codesourcery.com wrote: On 11/13/2014 10:27 AM, Richard Earnshaw wrote: On 13/11/14 17:05, Ramana Radhakrishnan wrote: On Thu, Nov 13, 2014 at 4:55 PM, Sandra Loosemore

Re: [GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Xinliang David Li
Is there a need to have 10 iterations of early inline for autofdo? David On Thu, Nov 13, 2014 at 2:25 PM, Dehao Chen de...@google.com wrote: In AutoFDO, we increase einline iterations. This could lead to extensive code bloat if we have recursive calls like: dtor() { destroy(node); }

Re: [GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Xinliang David Li
After inline summary is recomputed, the large code growth problem will also be better controlled, right? David On Thu, Nov 13, 2014 at 2:48 PM, Xinliang David Li davi...@google.com wrote: Is there a need to have 10 iterations of early inline for autofdo? David On Thu, Nov 13, 2014 at 2:25

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 11:23:31PM +0100, Markus Trippelsdorf wrote: On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: On 2014.11.13 at 15:11 +0100, mliska wrote: + /* Destructor. */ + virtual

Re: [GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Dehao Chen
IIRC, AutoFDO the actual iteration for AutoFDO is mostly 3. But it should not harm to set max iter as 10. On Thu, Nov 13, 2014 at 2:51 PM, Xinliang David Li davi...@google.com wrote: After inline summary is recomputed, the large code growth problem will also be better controlled, right? For

Re: [PATCH] Disable -fuse-caller-save when -pg is active

2014-11-13 Thread Mike Stump
On Nov 13, 2014, at 2:33 PM, Jeff Law l...@redhat.com wrote: We don’t support fprintf prologues anymore, they were removed years ago. Did we ever get all the ports converted? Ah… sorry, I was wrong. We merely hookized it and the tm.h interface is gone. TARGET_ASM_FUNCTION_PROLOGUE and

Re: PATCH: PR bootstrap/63784: [5 Regression] profiledbootstrap failure with bootstrap-lto

2014-11-13 Thread H.J. Lu
On Tue, Nov 11, 2014 at 8:02 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 11:42 AM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Nov 10, 2014 at 5:44 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Nov 10, 2014 at 2:43 PM, Jakub Jelinek ja...@redhat.com wrote: On

Re: [GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Xinliang David Li
On Thu, Nov 13, 2014 at 2:57 PM, Dehao Chen de...@google.com wrote: IIRC, AutoFDO the actual iteration for AutoFDO is mostly 3. But it should not harm to set max iter as 10. On Thu, Nov 13, 2014 at 2:51 PM, Xinliang David Li davi...@google.com wrote: After inline summary is recomputed, the

Re: [PATCH 1/9] New fibonacci heap and sreal enhancement.

2014-11-13 Thread Jan Hubicka
Hello. Following patch set introduces new template class for fibonacci heap that is mainly utilized by IPA inliner. Apart from that, I also enhanced existing sreal implementation so that it can also handle negative numbers. I was primary motivated by Honza, because current heap

Re: [PATCH 2/9] New template fibonacci_heap class introduced.

2014-11-13 Thread Jan Hubicka
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * fibonacci_heap.h: New file. * ipa-inline.c (update_edge_key): New heap API is used. (update_caller_keys): Likewise. (update_callee_keys): Likewise. (lookup_recursive_calls): Likewise.

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Jan Hubicka
Hello, in general I like this addition - I was not aware that sreal has no support for negative values. This would be serious maintainance burden if sreals was used for profile updating - it is very easy to get negative temporaries while dong the updates. gcc/ChangeLog: 2014-11-13 Martin

Re: [PATCH 7/9] Old libiberty fib_heap removed.

2014-11-13 Thread Jan Hubicka
gcc/ChangeLog: 2014-11-13 Martin Liska mli...@suse.cz * bb-reorder.c (find_traces_1_round): Old fibheap_t type removed. * bt-load.c: Include of fibheap.h is removed. * cgraphunit.c: Likewise. * config/i386/i386.c: Likewise. * ipa-inline.c: Likewise.

Re: [GOOGLE] Fix AutoFDO size issue

2014-11-13 Thread Dehao Chen
We do not do sophisticated recursive call detection in einline phase. It only happens in ipa-inline phase. Dehao On Thu, Nov 13, 2014 at 3:18 PM, Xinliang David Li davi...@google.com wrote: On Thu, Nov 13, 2014 at 2:57 PM, Dehao Chen de...@google.com wrote: IIRC, AutoFDO the actual iteration

Re: Add used_by_single_function flag for static variables

2014-11-13 Thread Jan Hubicka
Honza, On 23 June 2014 06:24, Jan Hubicka hubi...@ucw.cz wrote: --- lto-cgraph.c(revision 211881) +++ lto-cgraph.c(working copy) @@ -614,6 +614,7 @@ lto_output_varpool_node (struct lto_simp /* in_other_partition. */ } bp_pack_value (bp,

[PATCH 0/2] Offloading from dlopened libraries

2014-11-13 Thread Ilya Verbin
Hi, This patch fixes offloading from dlopened libraries, part 1 is for libgomp and part 2 is for intelmic plugin (it's not finished yet). How it works: When a library is loaded it calls GOMP_offload_register as usually. At this time some devices may already be initialized, and some may be not.

[PATCH 1/2] Offloading from dlopened libraries: libgomp

2014-11-13 Thread Ilya Verbin
libgomp/ * libgomp.map (GOMP_4.0.1): Add GOMP_offload_unregister. * libgomp_target.h (struct mapping_table): Replace with addr_pair. * target.c (struct gomp_device_descr): Remove register_image_func, get_table_func. Add load_image_func, unload_image_func.

Re: [PATCH 1/5] add an alternative to if_marked using hash_table

2014-11-13 Thread Jeff Law
On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This adds a gty cache attribute that calls user code after marking and before sweeping allowing user code to mark more objects or clear caches as appropriate. User code for hash_table is set up

Re: [PATCH 2/5] remove the remaining uses of if_marked

2014-11-13 Thread Jeff Law
On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, $subject. bootstrapped + regtested x86_64-unknown-linux-gnu, ok? Trev ada/ * gcc-interface/decl.c, gcc-interface/utils.c: replace htab with hash_table. cp/ *

Re: [PATCH 3/5] fix hash_table when empty elements are not 0

2014-11-13 Thread Jeff Law
On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com hi, The problem here is that hash_table used to zero element storage, but if the empty element is not 0 then all elements appear to be in use. bootstrapped + regtested x86_64-unknown-linux-gnu, ok?

Re: LTO streaming of TARGET_OPTIMIZE_NODE

2014-11-13 Thread Jan Hubicka
Hi, here is upated version with bitfields and also tested on PPC64-linux/aix. I hacked configury to use system awk instead of gawk, so the changes are hopefully safe. OK? Honza * optc-save-gen.awk: Output cl_target_option_eq, cl_target_option_hash, cl_target_option_stream_out,

Re: [PATCH 4/5] remove param$N_is usage

2014-11-13 Thread Jeff Law
On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, The only user of this is splay_tree. We only have a couple splay trees in ggc memory, and it wasn't clear to me any of them were tree based instead of hash based for performance reasons, so I chose

Re: [PATCH 5/5] use vec in lto_tree_ref_table

2014-11-13 Thread Jeff Law
On 11/12/14 22:55, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, gengtype fails to create valid user marking functions for this type, which is fixed by using vec here (which seems cleaner anyway). bootstrapped + regtested powerpc64-linux (gcc 110 since gcc20

Re: [PATCH] Make -fdiagnostics-color= default configurable, default to =auto

2014-11-13 Thread Jeff Law
On 11/12/14 15:33, Jakub Jelinek wrote: Hi! This patch makes the -fdiagnostics-color= default configurable, and changes the default (if no configure option is specified for it) to --with-diagnostics-color=auto. The previous behavior can be restored with --with-diagnostics-color=auto-if-env ,

[PATCH 3/3] [AARCH64] Add aligning of functions/loops/jumps

2014-11-13 Thread Andrew Pinski
On ThunderX, I found that aligning functions/loops/jumps to an 8 byte boundary have a slightly better performance because the hardware issue and dispatch matches what GCC's schedule has created. I set generic, cortex-a53 and cortex-a57 also to be 8 byte aligned also. Someone might want to change

<    1   2   3   >