Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Joseph Myers
On Fri, 23 Sep 2016, Marek Polacek wrote: > On Fri, Sep 23, 2016 at 10:22:15AM -0400, Jason Merrill wrote: > > On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek wrote: > > >> This is very close, thanks. Let's give a more helpful warning about > > >> > > >> [[fallthrough]] 0; >

[PATCH] read-rtl.c: split out read_rtx_operand from read_rtx_code

2016-09-23 Thread David Malcolm
This patch moves the body of the RTL operand-parsing loop (about 180 lines of code) from read_rtx_code out into a new function (read_rtx_operand). Hopefully this is a reasonable cleanup in itself, but it's also useful for the RTL frontend I'm working on. Successfully bootstrapped on

Re: [PATCH GCC][v2]Simplify alias check code generation in vectorizer

2016-09-23 Thread Richard Sandiford
"Bin.Cheng" writes: > + gcc_assert (TREE_CODE (DR_STEP (dr_a.dr)) == INTEGER_CST); > + > + bool neg_step = tree_int_cst_compare (DR_STEP (dr_a.dr), size_zero_node) < > 0; > + unsigned HOST_WIDE_INT abs_step = tree_to_uhwi (DR_STEP (dr_a.dr)); > + if (neg_step) > +

Re: Report DejaGnu ERROR messages in dg-extract-results

2016-09-23 Thread Christophe Lyon
On 23 September 2016 at 13:37, Rainer Orth wrote: > Hi Christophe, > >> We recently faced a problem where a DejaGnu error went un-noticed >> (https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01879.html). > > I just noticed that your patch contained an unrelated and

Re: Ping**3! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-23 Thread Fritz Reese
Many thanks. :) Committed revision 240458. Next extension coming soon On Fri, Sep 23, 2016 at 3:15 PM Jerry DeLisle wrote: > > On 09/23/2016 06:17 AM, Fritz Reese wrote: > > https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html > > On Wed, Aug 17, 2016 at 7:20 AM,

Re: C/C++ PATCH to implement -Wbool-operation (PR c/77490)

2016-09-23 Thread Joseph Myers
On Fri, 23 Sep 2016, Marek Polacek wrote: > On Thu, Sep 22, 2016 at 05:24:31PM +, Joseph Myers wrote: > > On Wed, 21 Sep 2016, Marek Polacek wrote: > > > > > > > > And let's refer to "expression of type bool" rather than "boolean > > > > > > expression". > > > > > > > > > > Adjusted (and in

Re: [PR56974] output DWARF-5 markers for ref_qualifiers

2016-09-23 Thread Alexandre Oliva
On Aug 12, 2016, Alexandre Oliva wrote: > When a method or a method or function type has a ref-qualifier, output > DW_AT_reference or DW_AT_rvalue_reference in the subprogram or > subroutine_type tag, as specified in DWARF version 5 drafts, see >

Re: [PR63238] output alignment debug information

2016-09-23 Thread Alexandre Oliva
On Aug 27, 2016, Alexandre Oliva wrote: > Output DWARFv5+ DW_AT_alignment for non-default alignment of > variables, fields and types. > Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? Ping? https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01911.html --

Re: [PR59319] output friends in debug info

2016-09-23 Thread Alexandre Oliva
On Aug 30, 2016, Alexandre Oliva wrote: > Handling non-template friends is kind of easy, but it required a bit > of infrastructure in dwarf2out to avoid (i) forcing debug info for > unused types or functions: DW_TAG_friend DIEs are only emitted if > their DW_AT_friend DIE is

Re: libgo patch committed: Change build procedure to use build tags

2016-09-23 Thread Ian Lance Taylor
On Sun, Sep 4, 2016 at 7:51 AM, Matthias Klose wrote: > On 07.08.2016 17:18, Matthias Klose wrote: >> On 07.08.2016 14:14, Andreas Schwab wrote: >>> That breaks ia64: >>> >>> ../../../libgo/go/internal/syscall/unix/getrandom_linux.go:29:5: error: >>> reference to undefined name

[PATCH/AARCH64] Have the verbose cost model output output be controllable

2016-09-23 Thread Andrew Pinski
Hi, As reported in PR 61367, the aarch64 back-end is too verbose when it is dealing with the cost model. I tend to agree, no other back-end is this verbose. So I decided to add an option to enable this verbose output if requested. I did NOT document it in invoke.texi because I don't feel like

Re: ICE at -O1 and above in both 32-bit and 64-bit modes on x86_64-linux-gnu

2016-09-23 Thread kugan
Hi Richard, There is also one more issue as reported by Pat Haugen. That is, in converting value_range of ssa (which we get from get_range_info) to argument type, my implementation is too simplistic and wrong at times. I can check TYPE_UNSIGNED here but that would be pessimistic. tree-vrp

Re: [PATCH] Use CONSTRUCTOR_NELTS macro some more

2016-09-23 Thread Richard Biener
On Thu, 22 Sep 2016, Jakub Jelinek wrote: > Hi! > > I've noticed lots of vec_safe_length (CONSTRUCTOR_ELTS (...)) uses > in the sources, which IMHO are less readable than the much more often > used CONSTRUCTOR_NELTS (...) macro that does the same thing. > > Bootstrapped/regtested on

[PATCH] Restore bootstrap

2016-09-23 Thread Richard Biener
Committed as obvious. 2016-09-23 Richard Biener * hooks.h (hook_uint_uintp_false): Declare. Index: gcc/hooks.h === --- gcc/hooks.h (revision 240386) +++ gcc/hooks.h (working copy) @@ -76,6 +76,7 @@

Re: [PATCH] Avoid some C++ local statics with constructors

2016-09-23 Thread Richard Biener
On Thu, 22 Sep 2016, Jakub Jelinek wrote: > Hi! > > The discovered 5 unnecessary C++ static locals with ctors prompted me to > look at other cases, which from looking at the optimized or non-optimized > code are just terrible. > We don't need to initialize static vectors with vNULL, because that

[PATCH] gcc: Fix sysroot relative paths for MinGW

2016-09-23 Thread Tadek Kijkowski
Prevent paths relative to sysroot directory from being transformed to Windows form with MSYS prefix. See: http://www.mingw.org/wiki/Posix_path_conversion 2016-09-23 Tadek Kijkowski * gcc/Makefile.in: Fix sysroot relative paths for MinGW Index: gcc/Makefile.in

Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++

2016-09-23 Thread Sebastian Huber
I checked in the following: https://gcc.gnu.org/viewcvs/gcc?view=revision=240387 All m68k BSPs build and link the samples using RTEMS https://git.rtems.org/rtems/commit/?id=8ace7ee42ff50eee4541fd7151bf8ecc32f82384 -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178

Re: [PATCH] Bits from Early LTO debug merge -- move stuff from late to early finish

2016-09-23 Thread Richard Biener
On Thu, 22 Sep 2016, Richard Biener wrote: > > This merges moving of unused type pruning from late to early finish as > well as handling of debug types and dwarf2 dups elimination. It adds > a flag to DIEs so we can mark them as removed in case sth after > early finish tries to lookup a DIE

Re: ICE at -O1 and above in both 32-bit and 64-bit modes on x86_64-linux-gnu

2016-09-23 Thread Richard Biener
On Fri, Sep 23, 2016 at 12:24 AM, kugan wrote: > Hi, > As Richard pointed out in PR77677, TREE_OVERFLOW is not cleared in IPA-VRP. > There are three places in which we set value_range: > > > 1. When value ranges are obtained from SSA_NAME with get_range_info

Re: [PATCH] Fix PR ipa/77653

2016-09-23 Thread Martin Liška
On 09/23/2016 11:19 AM, Richard Biener wrote: > Ok, but the classpath ones are imported from upstream (and is going to > be removed anyway), so please omit those. > > Richard. Good! I installed following. M. >From 6e23669e0e6572d44939fd0539c438c75c9d381e Mon Sep 17 00:00:00 2001 From: marxin

Re: [PATCHv3][ARM] -mpure-code option for ARM

2016-09-23 Thread Andre Vieira (lists)
On 23/09/16 11:04, Jakub Jelinek wrote: > On Thu, Sep 22, 2016 at 10:37:21PM +0200, Uros Bizjak wrote: >> diff --git a/gcc/hooks.c b/gcc/hooks.c >> index >> 99ec4014adb6fcbb073bf538dd00fe8695ee6cb2..1e925645c3173f8d97e104b9b2f480fca2ede438 >> 100644 >> --- a/gcc/hooks.c >> +++ b/gcc/hooks.c >> @@

Re: [PATCHv2][ARM] -mpure-code option for ARM

2016-09-23 Thread Andre Vieira (lists)
On 23/09/16 09:33, Andre Vieira (lists) wrote: > On 23/09/16 02:21, Sandra Loosemore wrote: >> On 09/22/2016 07:52 AM, Richard Earnshaw (lists) wrote: >>> On 11/07/16 17:56, Andre Vieira (lists) wrote: + diff --git a/gcc/target.def b/gcc/target.def index

Re: [PATCH] Use CONSTRUCTOR_NELTS macro some more

2016-09-23 Thread Bernd Schmidt
On 09/22/2016 10:07 PM, Jakub Jelinek wrote: I've noticed lots of vec_safe_length (CONSTRUCTOR_ELTS (...)) uses in the sources, which IMHO are less readable than the much more often used CONSTRUCTOR_NELTS (...) macro that does the same thing. Bootstrapped/regtested on x86_64-linux and

[PATCH v3 0/5] Separate shrink-wrapping

2016-09-23 Thread Segher Boessenkool
A new version of this patch set. This now marks every block without any successors as needing all components. This prevents most previous problem situations from ever happening. The emit hooks now put explicit CFI notes on the instructions. The heuristics dwarf2cfi uses do not work so well for

[PATCH 1/5] separate shrink-wrap: New command-line flag, status flag, hooks, and doc

2016-09-23 Thread Segher Boessenkool
This patch adds a new command-line flag "-fshrink-wrap-separate", a status flag "shrink_wrapped_separate", hooks for abstracting the target components, and documentation for all those. 2016-09-23 Segher Boessenkool * common.opt (-fshrink-wrap-separate):

[PATCH 2/5] dce: Don't dead-code delete separately wrapped restores

2016-09-23 Thread Segher Boessenkool
If there is a separately wrapped register restore on some path that is dead (say, control goes into an endless loop after it), then we cannot delete that restore because that would confuse the DWARF CFI (if there is another path joining after this). This happens with gcc.dg/torture/pr53168.c, for

[PATCH 3/5] regrename: Don't rename restores

2016-09-23 Thread Segher Boessenkool
A restore is supposed to restore some certain register. Restoring it into some other register will not work. Don't. 2016-09-23 Segher Boessenkool * regrename.c (build_def_use): Invalidate chains that have a REG_CFA_RESTORE on some instruction.

Re: [PATCHv2][ARM] -mpure-code option for ARM

2016-09-23 Thread Andre Vieira (lists)
On 23/09/16 02:21, Sandra Loosemore wrote: > On 09/22/2016 07:52 AM, Richard Earnshaw (lists) wrote: >> On 11/07/16 17:56, Andre Vieira (lists) wrote: >>> + >>> diff --git a/gcc/target.def b/gcc/target.def >>> index >>>

Re: ICE at -O1 and above in both 32-bit and 64-bit modes on x86_64-linux-gnu

2016-09-23 Thread kugan
Hi Richard, Thanks for the review. On 23/09/16 17:19, Richard Biener wrote: On Fri, Sep 23, 2016 at 12:24 AM, kugan wrote: Hi, As Richard pointed out in PR77677, TREE_OVERFLOW is not cleared in IPA-VRP. There are three places in which we set value_range:

Re: [PATCH] Avoid some C++ local statics with constructors

2016-09-23 Thread Richard Biener
On Fri, 23 Sep 2016, Jakub Jelinek wrote: > On Fri, Sep 23, 2016 at 08:55:02AM +0200, Richard Biener wrote: > > While I agree with the goal to reduce the number of static constructors > > esp. the vNULL cases I disagree with. This is just introducing > > undefined behavior (uninitialized object

Re: [PATCH] Fix PR ipa/77653

2016-09-23 Thread Richard Biener
On Fri, Sep 23, 2016 at 10:51 AM, Martin Liška wrote: > On 09/22/2016 03:07 PM, David Edelsohn wrote: >> @@ -,13 +2221,11 @@ sem_variable::merge (sem_item *alias_item) >> } >> >>/* We can not merge if address comparsion metters. */ >> - if (original_address_matters

Re: [PATCH] Bits from Early LTO debug merge -- move stuff from late to early finish

2016-09-23 Thread Richard Biener
On Fri, 23 Sep 2016, Richard Biener wrote: > On Thu, 22 Sep 2016, Richard Biener wrote: > > > > > This merges moving of unused type pruning from late to early finish as > > well as handling of debug types and dwarf2 dups elimination. It adds > > a flag to DIEs so we can mark them as removed

[PATCH 4/5] shrink-wrap: Shrink-wrapping for separate components

2016-09-23 Thread Segher Boessenkool
This is the main substance of this patch series. Instead of doing all of the prologue and epilogue in one spot, it often is better to do components of it at different places, so that they are executed less frequently. What exactly is a component is completely up to the target; this code treats

[PATCH 5/5] rs6000: Separate shrink-wrapping

2016-09-23 Thread Segher Boessenkool
This implements the hooks for separate shrink-wrapping for rs6000. It handles GPRs and LR. The GPRs get a component number corresponding to their register number; LR gets component number 0. 2016-09-23 Segher Boessenkool * config/rs6000/rs6000.c

Re: ICE at -O1 and above in both 32-bit and 64-bit modes on x86_64-linux-gnu

2016-09-23 Thread Richard Biener
On Fri, Sep 23, 2016 at 10:58 AM, kugan wrote: > Hi Richard, > > Thanks for the review. > > On 23/09/16 17:19, Richard Biener wrote: >> >> On Fri, Sep 23, 2016 at 12:24 AM, kugan >> wrote: >>> >>> Hi, >>> As Richard pointed

[PATCH][Committed] Add self to write-after-approval section of MAINTAINERS file

2016-09-23 Thread Tamar Christina
Hi All, I have committed the attached patch, adding myself to the Write After Approval section of the MAINTAINERS file. Thanks, Tamar ChangeLog: 2016-09-23 Tamar Christina * MAINTAINERS (Write After Approval): Add myself.diff --git a/MAINTAINERS

Re: [PATCH] Avoid some C++ local statics with constructors

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 08:55:02AM +0200, Richard Biener wrote: > While I agree with the goal to reduce the number of static constructors > esp. the vNULL cases I disagree with. This is just introducing > undefined behavior (uninitialized object use), and in case we end up > making vNULL not

Re: [PATCH] Fix PR ipa/77653

2016-09-23 Thread Martin Liška
On 09/22/2016 03:07 PM, David Edelsohn wrote: > @@ -,13 +2221,11 @@ sem_variable::merge (sem_item *alias_item) > } > >/* We can not merge if address comparsion metters. */ > - if (original_address_matters && alias_address_matters > - && flag_merge_constants < 2) > + if

Re: [PATCH] Avoid some C++ local statics with constructors

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 10:59:12AM +0200, Richard Biener wrote: > On Fri, 23 Sep 2016, Jakub Jelinek wrote: > > > On Fri, Sep 23, 2016 at 08:55:02AM +0200, Richard Biener wrote: > > > While I agree with the goal to reduce the number of static constructors > > > esp. the vNULL cases I disagree

Re: [PATCH] Avoid some C++ local statics with constructors

2016-09-23 Thread Richard Biener
On Fri, 23 Sep 2016, Richard Biener wrote: > On Thu, 22 Sep 2016, Jakub Jelinek wrote: > > > Hi! > > > > The discovered 5 unnecessary C++ static locals with ctors prompted me to > > look at other cases, which from looking at the optimized or non-optimized > > code are just terrible. > > We

Re: [PATCH 0/3] S/390: Improved risbg usage.

2016-09-23 Thread Andreas Krebbel
On 09/20/2016 02:37 PM, Dominik Vogt wrote: > The following series of patches improves usage of the risbg and > risbgn instructions on s390/s390x. The patches have been > regression tested on s390 and s390x and pass the Spec2006 > testsuite without any negative effects. > > Patch 1 introduces a

[gomp4] Fix tile parsing

2016-09-23 Thread Nathan Sidwell
In working on implementing tile, I discovered the parsing of tile clauses was at best confused. (The spec didn't help by being somewhat vague and not considering interaction with the collapse clause) Fixed with the attached patch. nathan 2016-09-23 Nathan Sidwell

Re: Report DejaGnu ERROR messages in dg-extract-results

2016-09-23 Thread Rainer Orth
Hi Christophe, > We recently faced a problem where a DejaGnu error went un-noticed > (https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01879.html). I just noticed that your patch contained an unrelated and bogus change, reverted as follows. This will only show up on targets that lack (a

Re: [PATCHv3][ARM] -mpure-code option for ARM

2016-09-23 Thread Jakub Jelinek
On Thu, Sep 22, 2016 at 10:37:21PM +0200, Uros Bizjak wrote: > diff --git a/gcc/hooks.c b/gcc/hooks.c > index > 99ec4014adb6fcbb073bf538dd00fe8695ee6cb2..1e925645c3173f8d97e104b9b2f480fca2ede438 > 100644 > --- a/gcc/hooks.c > +++ b/gcc/hooks.c > @@ -481,3 +481,13 @@ void >

Re: [Fortran, accaf, patch, v1] Fixing compatibility with opencoarrays (mostly)

2016-09-23 Thread Andre Vehreschild
Hi Paul, thanks for the review. Committed as r240419. Regards, Andre On Thu, 22 Sep 2016 19:28:49 +0200 Paul Richard Thomas wrote: > Dear Andre, > > Yes, this is fine for trunk. Thanks for fixing it so quickly. > > Best regards > > Paul > > On 22

Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756

2016-09-23 Thread Jonathan Wakely
On 22/09/16 20:22 +0200, Christophe Lyon wrote: On 22 September 2016 at 15:25, Jonathan Wakely wrote: On 22/09/16 12:15 +0100, Jonathan Wakely wrote: On 22/09/16 11:16 +0100, Jonathan Wakely wrote: (Somebody should fix PR58938 so exception_ptr is portable).

Re: C/C++ PATCH to implement -Wbool-operation (PR c/77490)

2016-09-23 Thread Marek Polacek
On Thu, Sep 22, 2016 at 05:24:31PM +, Joseph Myers wrote: > On Wed, 21 Sep 2016, Marek Polacek wrote: > > > > > > And let's refer to "expression of type bool" rather than "boolean > > > > > expression". > > > > > > > > Adjusted (and in the C FE too). > > > > > > Hmm, I'm not sure that

[PATCH] Fix PR77697

2016-09-23 Thread Richard Biener
As noted in the PR defcodefor_name was quite broken - the following rectifies it. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-09-23 Richard Biener PR tree-optimization/77697 * tree-ssa-forwprop.c (defcodefor_name): Remove

Ping**3! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-09-23 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > This patch extends the GNU Fortran front-end to add support for > DEC-style AUTOMATIC and STATIC symbol attributes with a new flag > -fdec-static, allowing explicit

[PATCH v3] Optimize strchr to strlen

2016-09-23 Thread Wilco Dijkstra
After discussion (https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00718.html) here is the latest version of the strchr patch. This uses a gimple statement for the pointer addition so the gsi_prev always points at the strlen call. Optimize strchr (s, 0) to s + strlen (s). strchr (s, 0) appears a

Re: [PATCH v3] Optimize strchr to strlen

2016-09-23 Thread Oleg Endo
On Fri, 2016-09-23 at 14:07 +, Wilco Dijkstra wrote: > After discussion (https://gcc.gnu.org/ml/gcc-patches/2016-09/msg00718 > .html) > here is the latest version of the strchr patch.  This uses a gimple > statement for > the pointer addition so the gsi_prev always points at the strlen > call.

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Markus Trippelsdorf
On 2016.09.22 at 15:42 +0200, Markus Trippelsdorf wrote: > On 2016.09.22 at 15:36 +0200, Richard Biener wrote: > > On Thu, Sep 22, 2016 at 3:13 PM, Wilco Dijkstra > > wrote: > > > Increase the lto-min-partition size to 5 to reduce the number of > > > partitions. > >

[PATCH] Fix handling of -fsanitize-recover* options.

2016-09-23 Thread Martin Liška
Hi. Following patch handles various issues related to -fsanitize-recover* options: 1) -fsanitize-recover=unreachable and -fsanitize-recover=return are currently not reported as invalid options (error message is not displayed) 2) explanation of -fsanitize-recover is not precise

Re: [Patch, fortran] Clean up of error recovery in DTIO procedures

2016-09-23 Thread Rainer Orth
Hi Paul, > Dear All, > > Please find attached a patch to clean up the various issues with > errors in DTIO procedures. The tests were all provided by Gerhard > Steinmetz for which thanks are due. > > I intend to commit this patch as 'obvious' tomorrow morning unless > there are any objections in

Re: Make regcprop to eliminate noop moves better

2016-09-23 Thread Jan Hubicka
> On 09/22/2016 01:48 PM, Jan Hubicka wrote: > > > > * postreload.c (reload_cse_simplify): Also accept USE in noop move > > patterns. > > > >diff --git a/gcc/postreload.c b/gcc/postreload.c > >index 61c1ce8..4f3a526 100644 > >--- a/gcc/postreload.c > >+++ b/gcc/postreload.c > >@@ -153,7

[PATCH] Fix missed debug PR77692

2016-09-23 Thread Richard Biener
I am testing the following patch which re-instantiates behavior to emit DW_AT_const_value attributes for optimized out non-readonly global statics. Those are readonly by means of the ability to remove them early (before any optimization such as removing stores to write-only global vars). Before

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Richard Biener
On Fri, Sep 23, 2016 at 3:29 PM, Richard Biener wrote: > On Fri, Sep 23, 2016 at 3:02 PM, Markus Trippelsdorf > wrote: >> On 2016.09.22 at 15:42 +0200, Markus Trippelsdorf wrote: >>> On 2016.09.22 at 15:36 +0200, Richard Biener wrote: >>> > On

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Marek Polacek
It occurred to me that I should also handle the __has_cpp_attribute(fallthrough) part. But I hope that can be done after the main -Wimplicit-fallthrough is committed. Marek

Re: [PATCH] Fix handling of -fsanitize-recover* options.

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 01:53:48PM +0200, Martin Liška wrote: > 3) -fsanitize=leak is combinable with -fsanitize=address or >-fsanitize=thread Is it really combinable with -fsanitize=thread? I thought only libasan or liblsan provides the leak checker. Anyway, I can't find where in the patch

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-23 Thread Marek Polacek
On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: > On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: > > I suppose that an INTEGER_CST of character type is necessarily a > > character constant, so adding a check for !char_type_p ought to do the > > trick. > >

[PATCH, arm-embedded] -mpure-code option for ARM

2016-09-23 Thread Andre Vieira (lists)
On 22/09/16 16:04, Andre Vieira (lists) wrote: > On 22/09/16 14:52, Richard Earnshaw (lists) wrote: >> On 11/07/16 17:56, Andre Vieira (lists) wrote: >>> On 07/07/16 13:30, mickael guene wrote: Hi Andre, Another feedback on your purecode patch. You have to disable casesi

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Richard Biener
On Fri, Sep 23, 2016 at 3:02 PM, Markus Trippelsdorf wrote: > On 2016.09.22 at 15:42 +0200, Markus Trippelsdorf wrote: >> On 2016.09.22 at 15:36 +0200, Richard Biener wrote: >> > On Thu, Sep 22, 2016 at 3:13 PM, Wilco Dijkstra >> > wrote: >> > >

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-09-23 Thread Rainer Orth
Hi Martin, > On 09/22/2016 06:14 AM, Rainer Orth wrote: >> Hi Martin, >> >>> your patch broke bootstrap with MPFR 2.4.2, which is still the >>> recommended (or perhaps minimal) version according to install.texi: >> [...] >>> The following patch (together with your other one to fix ILP32 targets)

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Wilco Dijkstra
Richard Biener wrote: >On Fri, Sep 23, 2016 at 3:02 PM, Markus Trippelsdorf >wrote: > > And tramp3d only uses ten partitions (lto-min-partition=1). > > With lto-min-partition=5 (current patch) this decrease to only two > > partitions. As a result we loose the

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Markus Trippelsdorf
On 2016.09.23 at 14:19 +, Wilco Dijkstra wrote: > Richard Biener wrote: > >On Fri, Sep 23, 2016 at 3:02 PM, Markus Trippelsdorf > > wrote: > > > And tramp3d only uses ten partitions (lto-min-partition=1). > > > With lto-min-partition=5 (current patch) this

Re: [PATCHv2][ARM] -mpure-code option for ARM

2016-09-23 Thread Sandra Loosemore
On 09/23/2016 04:39 AM, Andre Vieira (lists) wrote: Hi Sandra, Is this better? Cheers, Andre gcc/ChangeLog 2016-09-23 Andre Vieira * target.def(elf_flags_numeric): Change documentation to present tense. And here is the patch with the

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Wilco Dijkstra
Markus Trippelsdorf wrote: > What I wanted to point out is that you of course loose the speedup you'll > get from parallel running backends with only a single partition. Absolutely. For every possible value of min-lto-partition you can find an application that will build with more parallelism if

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Jason Merrill
On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek wrote: >> This is very close, thanks. Let's give a more helpful warning about >> >> [[fallthrough]] 0; >> __attribute__ ((fallthrough)) 0; >> >> both here and in cp_parser_statement, something like "fallthrough attribute >> not

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Marek Polacek
On Fri, Sep 23, 2016 at 10:22:15AM -0400, Jason Merrill wrote: > On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek wrote: > >> This is very close, thanks. Let's give a more helpful warning about > >> > >> [[fallthrough]] 0; > >> __attribute__ ((fallthrough)) 0; > >> > >> both

Re: [PATCH] Increase lto-min-partition

2016-09-23 Thread Prathamesh Kulkarni
On 23 September 2016 at 19:49, Wilco Dijkstra wrote: > Richard Biener wrote: >>On Fri, Sep 23, 2016 at 3:02 PM, Markus Trippelsdorf >>wrote: >> > And tramp3d only uses ten partitions (lto-min-partition=1). >> > With lto-min-partition=5

[PATCH, GCC] Deal with singular sentences in builtin-sprintf-warn-1.c regex

2016-09-23 Thread Thomas Preudhomme
Hi, New builtin-sprintf-warn-1.c testcase contains a few regex of the form "\[0-9\]+ bytes" or ". bytes". This does not account for the case where the number of byte is 0 in which case byte would be in the singular form. This caused a FAIL on arm-none-eabi targets. This patch makes the s

[committed] Provide location information for terminator characters (PR preprocessor/77672)

2016-09-23 Thread David Malcolm
substring_loc::get_location currently fails for the final terminator character in a STRING_CST from the C frontend, so that format_warning_va falls back to using the location of the string as a whole. This patch tweaks things [1] so that we use the final closing quote as the location of the

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Marek Polacek
On Fri, Sep 23, 2016 at 04:23:29PM +0200, Jakub Jelinek wrote: > On Fri, Sep 23, 2016 at 10:22:15AM -0400, Jason Merrill wrote: > > On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek wrote: > > >> This is very close, thanks. Let's give a more helpful warning about > > >> > > >>

Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 03:43:11PM +0100, Dominik Vogt wrote: > Great! > > But could this patch be responsible with some dg-error related > test errors on s390x that are present with current HEAD? E.g. > (Sorry for the linebreaks that vim has inserted). Very unlikely. Are you sure it appeared

[PATCH] Fixed up missing semicolons.

2016-09-23 Thread lhmouse
Hi GCC developers, Today I was trying bootstrapping GCC 7.0.0 and stage 1 compilation failed because of two missing semicolons. After this patch was applied, xgcc could be built successfully, although it still failed the self-test. -- Best regards,

Re: Implement -Wimplicit-fallthrough (version 9)

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 10:22:15AM -0400, Jason Merrill wrote: > On Thu, Sep 22, 2016 at 9:59 AM, Marek Polacek wrote: > >> This is very close, thanks. Let's give a more helpful warning about > >> > >> [[fallthrough]] 0; > >> __attribute__ ((fallthrough)) 0; > >> > >> both

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-09-23 Thread Jason Merrill
On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: > On Wed, Sep 21, 2016 at 03:52:09PM -0400, Jason Merrill wrote: >> On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: >> > I suppose that an INTEGER_CST of character type is necessarily a >> >

Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers

2016-09-23 Thread Dominik Vogt
On Thu, Sep 22, 2016 at 10:05:46PM +0200, Jakub Jelinek wrote: > This is something I've been unhappy for a long time with, and finally got to > write something for it. > When some test expects more than one error or warning or message on the same > source line, people have to use absolute line

[PATCH]: S/390: Fix hotpatch test cases.

2016-09-23 Thread Dominik Vogt
THe attached patch fixes some dg-error tests that were broken since the recent change of the error location. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/testsuite/ChangeLog * gcc.target/s390/hotpatch-compile-1.c: Fixed dg-error test. *

[gomp4] fix an ICE with acc declared VLAs

2016-09-23 Thread Cesar Philippidis
I've applied this patch to gomp4 which fixes a problem with VLA variables in data clauses used in acc declare directives. More details regarding this fix can be found here . Cesar 2016-09-23 Cesar Philippidis

Re: PATCH to fix fallout from recent C++ bool changes

2016-09-23 Thread Jason Merrill
OK, thanks. On Thu, Sep 22, 2016 at 10:24 AM, Marek Polacek wrote: > Jason reported that make check-c++1z reveals some fallout > because we now reject bool++ in C++1z: > https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01460.html > > I hope this patch fixes all of it. > >

Re: [C++ PATCH] Aligned new option handling fixes (PR c++/77651)

2016-09-23 Thread Jason Merrill
On Thu, Sep 22, 2016 at 10:22 AM, Christophe Lyon wrote: > On 22 September 2016 at 15:01, Jason Merrill wrote: >> On Thu, Sep 22, 2016 at 4:58 AM, Christophe Lyon >> wrote: >>> This new test (aligned-new6.C) fails on

[ARM] Enable FP16 vector arithmetic operations.

2016-09-23 Thread Matthew Wahab
Hello, Support for the ARMv8.2-A FP16 NEON arithmetic instructions was added using non-standard names for the instruction patterns. This was needed because the NEON floating point semantics meant that their use by the compiler for HFmode arithmetic operations needed to be restricted. This

Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers

2016-09-23 Thread Dominik Vogt
On Fri, Sep 23, 2016 at 04:48:36PM +0200, Jakub Jelinek wrote: > On Fri, Sep 23, 2016 at 03:43:11PM +0100, Dominik Vogt wrote: > > Great! > > > > But could this patch be responsible with some dg-error related > > test errors on s390x that are present with current HEAD? E.g. > > (Sorry for the

Re: [PATCH, GCC] Deal with singular sentences in builtin-sprintf-warn-1.c regex

2016-09-23 Thread Thomas Preudhomme
Sorry, forgot the patch. Please find it attached. Best regards, Thomas On 23/09/16 16:40, Thomas Preudhomme wrote: Hi, New builtin-sprintf-warn-1.c testcase contains a few regex of the form "\[0-9\]+ bytes" or ". bytes". This does not account for the case where the number of byte is 0 in

[PATCH] Fix builtin-sprintf-warn-2.c xfail pattern

2016-09-23 Thread Thomas Preudhomme
The new builtin-sprintf-warn-2.c xfail on line 83 and 84 for *-*-*-* which fails for arm-none-eabi for instance. The usual pattern for catchall xfail is *-*-*. This patch fixes the pattern as such. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog *** 2016-09-23 Thomas Preud'homme

[C++ PATCH] Implement P0138R2, C++17 construction rules for enum class values

2016-09-23 Thread Jakub Jelinek
Hi! The following patch implements direct enum initialization as per C++17. The change in reshape_init is needed for when it is called from check_initializer and finish_compound_literal for e.g. E e { 5 } and E { 5 } respectively, while the convert_for_assignment spot handles all the other cases,

[committed] Fix gcc.dg/tree-ssa/builtin-sprintf-warn-4.c

2016-09-23 Thread David Malcolm
My fix to the locations for NUL-terminators in substring_loc changed the output for gcc.dg/tree-ssa/builtin-sprintf-warn-4.c, leading to a couple of FAILs from that test. Sorry; my testing of the earlier patch was incomplete (I needed to rebase). I've committed the attached patch to trunk

OpenACC data clause syntax question/patch

2016-09-23 Thread Bernd Schmidt
While trying to get the following benchmarks to run: https://codesign.llnl.gov/lulesh.php I came across some cases where the code and the compiler differed in its interpretation of the OpenACC spec. Specifically, this occurs for acc data clauses with arrays, like: #pragma acc data

Re: [PATCH, GCC] Deal with singular sentences in builtin-sprintf-warn-1.c regex

2016-09-23 Thread Thomas Preudhomme
Hi Martin, On 23/09/16 17:17, Martin Sebor wrote: On 09/23/2016 09:42 AM, Thomas Preudhomme wrote: Sorry, forgot the patch. Please find it attached. Best regards, Thomas On 23/09/16 16:40, Thomas Preudhomme wrote: Hi, New builtin-sprintf-warn-1.c testcase contains a few regex of the form

Re: [PATCH] Fix PR tree-optimization/77654

2016-09-23 Thread Mike Stump
On Sep 23, 2016, at 8:55 AM, Matthew Fortune wrote: > > Doug Gilmore writes: >>> From: Richard Biener [rguent...@suse.de] >>> Sent: Thursday, September 22, 2016 12:43 AM >>> To: Doug Gilmore >>> Cc: gcc-patches@gcc.gnu.org;

[PATCH] Small hooks.c cleanup

2016-09-23 Thread Jakub Jelinek
Hi! The generic hooks (except for one mistaken case) don't use any of the arguments, and are generally meant to be used by any hooks that have such arguments, so giving them names isn't really meaningful. So, this patch uses the C++ nameless parameters type instead of type name ATTRIBUTE_UNUSED.

RE: [PATCH] Fix PR tree-optimization/77654

2016-09-23 Thread Matthew Fortune
Doug Gilmore writes: > > From: Richard Biener [rguent...@suse.de] > > Sent: Thursday, September 22, 2016 12:43 AM > > To: Doug Gilmore > > Cc: gcc-patches@gcc.gnu.org; rgue...@gcc.gnu.org > > Subject: RE: [PATCH] Fix PR tree-optimization/77654 > > > > On Wed, 21 Sep 2016,

Re: OpenACC data clause syntax question/patch

2016-09-23 Thread Jakub Jelinek
On Fri, Sep 23, 2016 at 06:02:32PM +0200, Bernd Schmidt wrote: > While trying to get the following benchmarks to run: > https://codesign.llnl.gov/lulesh.php > > I came across some cases where the code and the compiler differed in its > interpretation of the OpenACC spec. Specifically, this

Re: [PATCH, GCC] Deal with singular sentences in builtin-sprintf-warn-1.c regex

2016-09-23 Thread Martin Sebor
On 09/23/2016 09:42 AM, Thomas Preudhomme wrote: Sorry, forgot the patch. Please find it attached. Best regards, Thomas On 23/09/16 16:40, Thomas Preudhomme wrote: Hi, New builtin-sprintf-warn-1.c testcase contains a few regex of the form "\[0-9\]+ bytes" or ". bytes". This does not account

Re: [PATCH]: S/390: Fix hotpatch test cases.

2016-09-23 Thread Andreas Krebbel
On 09/23/2016 05:14 PM, Dominik Vogt wrote: > THe attached patch fixes some dg-error tests that were broken > since the recent change of the error location. Applied. Thanks! -Andreas-

Re: [PATCH] Improve string::clear() performance

2016-09-23 Thread Jonathan Wakely
On 14/09/16 18:28 +0100, Jonathan Wakely wrote: On 14/09/16 09:09 -0700, Cong Wang wrote: On Wed, Sep 14, 2016 at 4:06 AM, Jonathan Wakely wrote: On 13/09/16 11:02 -0700, Cong Wang wrote: In !_GLIBCXX_USE_CXX11_ABI implementation, string::clear() calls _M_mutate(), which

Re: [PATCH] Improve string::clear() performance

2016-09-23 Thread Cong Wang
On Fri, Sep 23, 2016 at 10:25 AM, Jonathan Wakely wrote: > > I'm applying this patch, which is my one from 2014 with a check for > whether the string is shared, so we just set the length to zero (and > don't throw away reusable capacity) when it's not shared. > > Tested

Re: [Patch, fortran] Clean up of error recovery in DTIO procedures

2016-09-23 Thread Paul Richard Thomas
Dear Rainer, Thanks for the report. I'll have a stab at finding the problem tomorrow. In the interim, could you try applying: Index: /svn/trunk/gcc/fortran/interface.c === *** /svn/trunk/gcc/fortran/interface.c(revision 240349)

Re: [PATCH] Fix PR tree-optimization/77654

2016-09-23 Thread Richard Biener
On September 23, 2016 6:17:17 PM GMT+02:00, Mike Stump wrote: >On Sep 23, 2016, at 8:55 AM, Matthew Fortune > wrote: >> >> Doug Gilmore writes: From: Richard Biener [rguent...@suse.de] Sent: Thursday,

  1   2   >