Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Richard Biener
On Fri, 7 Apr 2017, Florian Weimer wrote: > On 04/06/2017 09:16 PM, Richard Biener wrote: > > On April 6, 2017 8:12:29 PM GMT+02:00, Bernd Edlinger > > wrote: > > > But isn't the effective type changed by the assignment b[1] = 0; > > > as described in 6.5(6): > > > "If

Re: [PATCH] PR80101: Fix ICE in store_data_bypass_p

2017-04-07 Thread Eric Botcazou
> Or we could just change "blockage" and wait for the next bug report. That's my suggestion, yes. > Alternatively, we can arrange for the bypass functions to not ICE. We > can do that specific to these rs6000 pipeline descriptions, by having > our own version of store_data_bypass_p; or we can

Re: [wwwdocs] Document C++ null pointer constant changes in gcc-7/porting_to.html

2017-04-07 Thread Marek Polacek
On Fri, Apr 07, 2017 at 10:25:21AM +0100, Jonathan Wakely wrote: > This issue caused a lot of build failures during the GCC mass rebuilds > for Fedora, but isn't in the porting to guide yet. > > Is this accurate and clear enough for casual readers? Looks fine to me. > Index:

Re: [PATCH] Fix PR80334

2017-04-07 Thread Rainer Orth
Hi Richard, >> > Any suggestion how to mitigate that? Possible solution includes >> > adding { target { ! ... } } to dg-do run. >> >> No idea. However, according to gcc-testresults there are other >> failures: s390-ibm-inux-gnu and s390x-ibm-linux-gnu so far. >> >> This might argue against

Re: [PATCH] Fix PR80334

2017-04-07 Thread Rainer Orth
Hi Richard, > On Thu, 6 Apr 2017, Rainer Orth wrote: > >> Hi Richard, >> >> > The following patch makes sure to preserve (mis-)alignment of memory >> > references when IVOPTs generates TARGET_MEM_REFs for them. >> > >> > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. >> > >> >

Re: [PATCH] Fix PR80334

2017-04-07 Thread Richard Biener
On Fri, 7 Apr 2017, Rainer Orth wrote: > Hi Richard, > > > On Thu, 6 Apr 2017, Rainer Orth wrote: > > > >> Hi Richard, > >> > >> > The following patch makes sure to preserve (mis-)alignment of memory > >> > references when IVOPTs generates TARGET_MEM_REFs for them. > >> > > >> > Bootstrapped on

Re: [PATCH] Fix PR80334

2017-04-07 Thread Richard Biener
On Fri, 7 Apr 2017, Rainer Orth wrote: > Hi Richard, > > >> > Any suggestion how to mitigate that? Possible solution includes > >> > adding { target { ! ... } } to dg-do run. > >> > >> No idea. However, according to gcc-testresults there are other > >> failures: s390-ibm-inux-gnu and

Re: [PATCH] PR80101: Fix ICE in store_data_bypass_p

2017-04-07 Thread Segher Boessenkool
On Fri, Apr 07, 2017 at 10:39:03AM +0200, Eric Botcazou wrote: > > Or we could just change "blockage" and wait for the next bug report. > > That's my suggestion, yes. > > > Alternatively, we can arrange for the bypass functions to not ICE. We > > can do that specific to these rs6000 pipeline

[wwwdocs] Document C++ null pointer constant changes in gcc-7/porting_to.html

2017-04-07 Thread Jonathan Wakely
This issue caused a lot of build failures during the GCC mass rebuilds for Fedora, but isn't in the porting to guide yet. Is this accurate and clear enough for casual readers? Index: htdocs/gcc-7/porting_to.html === RCS file:

[PATCH, GCC/testsuite] Require c99_runtime for pr79800.c

2017-04-07 Thread Thomas Preudhomme
Hi, Testcase gcc.dg/tree-ssa/pr79800.c is run unconditionally. Yet, it uses the 'a' conversion specifier in sprintf which is only available in C99 or later version of the C standard. This commit adds a c99_runtime requirement. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog ***

[PATCH, testsuite]: Fix gcc.dg/unroll-7.c FAIL for x32 target

2017-04-07 Thread Uros Bizjak
Hello! Attached patch mitigates: FAIL: gcc.dg/unroll-7.c scan-rtl-dump loop2_unroll "number of iterations: .const_int 99" testsuite failure for x32 target. Loop analysis determines: Loop 1 is simple: simple exit 3 -> 4 infinite if: (expr_list:REG_DEP_TRUE (ne:SI (and:SI (minus:SI

Re: [PATCH] PR80101: Fix ICE in store_data_bypass_p

2017-04-07 Thread Segher Boessenkool
On Fri, Apr 07, 2017 at 08:54:01AM +0200, Eric Botcazou wrote: > > The only straightforward way I see is to use a rs6000_store_data_bypass_p > > instead, which would be doing the same thing. :-( > > Why not just change the type of the blockage instruction as you suggested? That works for this

[PATCH] omp-low: fix lastprivate/linear lowering for SIMT

2017-04-07 Thread Alexander Monakov
Ping. > I've noticed while re-reading that this patch incorrectly handled SIMT case > in lower_lastprivate_clauses. The code was changed to look for variables > with "omp simt private" attribute, and was left under > 'simduid && DECL_HAS_VALUE_EXPR_P (new_var)' condition. This effectively >

Re: [PATCH] Fix PR80029

2017-04-07 Thread Thomas Schwinge
Hi Cesar! On Wed, 22 Mar 2017 06:40:03 -0700, Cesar Philippidis wrote: > In addition to resolving the memory leak involving OpenACC delare > clauses, this patch also corrects an ICE involving VLA variables as data > clause arguments used in acc declare constructs. More

[PATCH] Add function part to a same comdat group (PR ipa/80212).

2017-04-07 Thread Martin Liška
Hello. Following patch is pre-approved by Honza, where IPA split should properly set a comdat gruop if an original function lives in any. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Martin >From b876a766c2e5ffcf78fdc56e2ff5b87c1e99d30b Mon Sep 17 00:00:00 2001

Re: [PATCH 2/3] Error message on target attribute on aarch64 target (PR target/79889).

2017-04-07 Thread James Greenhalgh
On Mon, Apr 03, 2017 at 09:26:16AM +0200, Martin Liška wrote: > Thanks Kyrill for review. I'm pinging the patch. OK. Thanks, James > > Martin > > On 03/21/2017 10:24 AM, Kyrill Tkachov wrote: > > > > > > Hi Martin, > > > > On 13/03/17 08:25, marxin wrote: > >> gcc/testsuite/ChangeLog: > >>

Re: [PATCH 0/3] Introduce internal_error_cont and exclude it from pot files

2017-04-07 Thread Martin Liška
On 04/06/2017 06:44 PM, Jeff Law wrote: > On 03/24/2017 03:29 AM, Martin Liška wrote: >> I would like to ping that. I'm not sure what's agreement after I read >> discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html >> >> Martin Sebor may know, CC'ing him. > Not sure if you're pinging

[PATCH] Define std::to_chars and std::from_chars for C++17 (P0067R5, partial)

2017-04-07 Thread Jonathan Wakely
This adds another piece of the C++17 library, the std::to_chars and std::from_chars functions for converting numbers to/from strings. This only adds the integer support, floating point types will require a lot more work. This has only been lightly optimised, so it beats printf on average, but

[PATCH] Speedup gt_ggc_m_S

2017-04-07 Thread Richard Biener
Currently it looks up the page table entry for the string twice, once in the ggc_allocated_p test (for strings allocated by libcpp?) and once for the final lookup. The following simply turns ggc_allocated_p into a safe_lookup_page_table_entry. Bootstrapped and tested on

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Bernd Edlinger
On 04/07/17 08:47, Richard Biener wrote: > On Thu, 6 Apr 2017, Bernd Edlinger wrote: > >> On 04/06/17 21:05, Florian Weimer wrote: >>> On 04/06/2017 08:49 PM, Bernd Edlinger wrote: >>> For instance how do you "declare an object without a declared type"? >>> >>> malloc and other allocation

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Bernd Edlinger
On 04/07/17 08:54, Richard Biener wrote: > On Thu, 6 Apr 2017, Bernd Edlinger wrote: >> I think get_alias_set(t) will return 0 for typeless_storage >> types, and therefore has_zero_child will be set anyway. >> I think both mean the same thing in the end, but it depends on >> what typeless_storage

[PATCH][PR target/80358][7 regression] Fix boundary check error in expand_block_compare

2017-04-07 Thread Aaron Sawdey
Turns out we get passed const -1 for the length arg from this code. ROUND_UP adds load_mode_size to that resulting in a small positive number, hilarity ensues. Fixed by computing a sensible limit and using IN_RANGE instead, which won't overflow in this way. OK for trunk if bootstrap/regtest in

Re: [PATCH v2,rs6000] PR80108: Fix ICE with cross compiler

2017-04-07 Thread Segher Boessenkool
Hi Bernhard, On Sat, Apr 08, 2017 at 02:54:31AM +0200, Bernhard Reutner-Fischer wrote: > I suspect /Burnas/s/a/u/ Yeah; it seems to be wrong in the original testcase already (gcc/testsuite/gfortran.dg/streamio_11.f90). > Why do you need a separate fortran.exp? > Can't this be a PPC test in the

Re: [PATCH v2,rs6000] PR80108: Fix ICE with cross compiler

2017-04-07 Thread Bernhard Reutner-Fischer
On 7 April 2017 21:54:24 CEST, Segher Boessenkool wrote: >Hi Kelvin, > >Sorry this has fallen by the wayside. I did mark it "to do", and then >promptly buried it. Whoops. > >On Thu, Apr 06, 2017 at 08:36:00AM -0600, Kelvin Nilsen wrote: > >> +dg-test

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Richard Biener
On Thu, 6 Apr 2017, Bernd Edlinger wrote: > On 04/06/17 21:05, Florian Weimer wrote: > > On 04/06/2017 08:49 PM, Bernd Edlinger wrote: > > > >> For instance how do you "declare an object without a declared type"? > > > > malloc and other allocation functions return pointers to objects without > >

Re: [PATCH] Fix PR80334

2017-04-07 Thread Richard Biener
On Thu, 6 Apr 2017, Rainer Orth wrote: > Hi Richard, > > > The following patch makes sure to preserve (mis-)alignment of memory > > references when IVOPTs generates TARGET_MEM_REFs for them. > > > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > > > Richard. > > > >

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Richard Biener
On Thu, 6 Apr 2017, Bernd Edlinger wrote: > On 04/06/17 09:47, Richard Biener wrote: > > On Wed, 5 Apr 2017, Bernd Edlinger wrote: > > > >> On 04/05/17 19:22, Bernd Edlinger wrote: > >>> On 04/05/17 18:08, Jakub Jelinek wrote: > >>> > >>> Yes, exactly. I really want to reach the deadline for

Re: [PATCH] PR80101: Fix ICE in store_data_bypass_p

2017-04-07 Thread Eric Botcazou
> The only straightforward way I see is to use a rs6000_store_data_bypass_p > instead, which would be doing the same thing. :-( Why not just change the type of the blockage instruction as you suggested? -- Eric Botcazou

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Florian Weimer
On 04/06/2017 09:16 PM, Richard Biener wrote: On April 6, 2017 8:12:29 PM GMT+02:00, Bernd Edlinger wrote: But isn't the effective type changed by the assignment b[1] = 0; as described in 6.5(6): "If a value is stored into an object having no declared type through

Re: [PATCH] Evaluate a SAVE_EXPR before an UBSAN check (PR sanitizer/80350).

2017-04-07 Thread Marek Polacek
On Fri, Apr 07, 2017 at 07:04:08PM +0200, Jakub Jelinek wrote: > On Fri, Apr 07, 2017 at 04:26:50PM +0200, Martin Liška wrote: > > Hello. > > > > Similar to what was done in Marek's r202113, when op1 is a SAVE_EXPR it must > > be evaluated before condition, in order to be able to deliver the

Re: [PATCH, rs6000] Update Power9 scheduling of vector and vector load insns

2017-04-07 Thread Segher Boessenkool
On Fri, Apr 07, 2017 at 11:58:15AM -0500, Pat Haugen wrote: > The following patch changes the method of scheduling vector and vector > load insns. Before it tried to pair up like insns and interleave the > pairs, resulting in something like L1L2V1V2. The preferred scheduling is > now to just

Re: [libcp1] handle anon aggregates linkage-named by typedefs

2017-04-07 Thread Alexandre Oliva
Ping? https://gcc.gnu.org/ml/gcc-patches/2017-03/msg01143.html On Mar 21, 2017, Alexandre Oliva wrote: > for libcc1/ChangeLog > * libcp1plugin.cc (plugin_build_decl): Propagate typedef name to > anonymous aggregate target type. -- Alexandre Oliva, freedom

Re: [PATCH] S/390: Optimize atomic_compare_exchange and atomic_compare builtins.

2017-04-07 Thread Ulrich Weigand
Dominik Vogt wrote: > On Fri, Apr 07, 2017 at 04:34:44PM +0200, Ulrich Weigand wrote: > > > +; Peephole to combine a load-and-test from volatile memory which combine > > > does > > > +; not do. > > > +(define_peephole2 > > > + [(set (match_operand:GPR 0 "register_operand") > > > +

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Bernd Edlinger
On 04/07/17 17:10, Richard Biener wrote: > On April 7, 2017 3:37:30 PM GMT+02:00, Bernd Edlinger > wrote: >> On 04/07/17 08:54, Richard Biener wrote: >>> On Thu, 6 Apr 2017, Bernd Edlinger wrote: I think get_alias_set(t) will return 0 for typeless_storage

[PATCH, rs6000] Update Power9 scheduling of vector and vector load insns

2017-04-07 Thread Pat Haugen
The following patch changes the method of scheduling vector and vector load insns. Before it tried to pair up like insns and interleave the pairs, resulting in something like L1L2V1V2. The preferred scheduling is now to just interleave the insns, resulting in L1V1L2V2. If interleaving fails, fall

Re: [PATCH] S/390: Optimize atomic_compare_exchange and atomic_compare builtins.

2017-04-07 Thread Ulrich Weigand
Dominik Vogt wrote: > v4: > > * Remoce CCZZ1 iterator. > * Remove duplicates of CS patterns. > * Move the skip_cs_label so that output is moved to vtarget even > if the CS instruction was not used. > * Removed leftover from "sne" (from an earlier version of the > * patch).

[PATCH] Add some missing AVX and AVX512F intrinsics (PR target/8032{2,3,5,6})

2017-04-07 Thread Jakub Jelinek
Hi! Apparently while we weren't closely watching, Intel has added into ICC various new intrinsics and they have been added into Clang last fall as well. Tested with make -j272 -k check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} i386.exp' on KNL, will bootstrap/regtest on my Haswell-E

Re: [patch,gomp4] add support for fortran common blocks

2017-04-07 Thread Thomas Schwinge
Hi Cesar! On Wed, 5 Apr 2017 13:37:30 -0700, Cesar Philippidis wrote: > On 04/05/2017 01:22 PM, Thomas Schwinge wrote: > > >> --- a/gcc/gimplify.c > >> +++ b/gcc/gimplify.c > >> @@ -6102,14 +6102,19 @@ oacc_default_clause (struct gimplify_omp_ctx *ctx, > >> tree decl,

OpenACC 2.5 default (present) clause

2017-04-07 Thread Thomas Schwinge
Hi! OpenACC 2.5 added a default (present) clause, which "causes all arrays or variables of aggregate data type used in the compute construct that have implicitly determined data attributes to be treated as if they appeared in a present clause". Preceded by the following cleanup patch (see

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Richard Biener
On April 7, 2017 3:37:30 PM GMT+02:00, Bernd Edlinger wrote: >On 04/07/17 08:54, Richard Biener wrote: >> On Thu, 6 Apr 2017, Bernd Edlinger wrote: >>> I think get_alias_set(t) will return 0 for typeless_storage >>> types, and therefore has_zero_child will be set

Re: [PATCH] Evaluate a SAVE_EXPR before an UBSAN check (PR sanitizer/80350).

2017-04-07 Thread Jakub Jelinek
On Fri, Apr 07, 2017 at 04:26:50PM +0200, Martin Liška wrote: > Hello. > > Similar to what was done in Marek's r202113, when op1 is a SAVE_EXPR it must > be evaluated before condition, in order to be able to deliver the operand > to real shifting. And not just to a BB where ubsan report function

C++ PATCH for sanitizer/80348, ICE with -fsanitize=integer-divide-by-zero

2017-04-07 Thread Marek Polacek
This ICEs in ubsan_instrument_division on the assert that checks whether both operands of the division have the same type. Well, here they didn't, because in cp_build_binary_op we first converted both operands to result_type but then fold_non_dependent_expr changed the type of op0, so we need to

Re: C++ PATCH for sanitizer/80348, ICE with -fsanitize=integer-divide-by-zero

2017-04-07 Thread Jakub Jelinek
On Fri, Apr 07, 2017 at 07:23:17PM +0200, Marek Polacek wrote: > This ICEs in ubsan_instrument_division on the assert that checks whether both > operands of the division have the same type. Well, here they didn't, because > in cp_build_binary_op we first converted both operands to result_type but

[patch] aarch64 FreeBSD wchar_t

2017-04-07 Thread Andreas Tobler
Hi all, I'm going to commit this patch to all active branches (5,6,7) in the next hours. A few failures less in the testsuite. Thanks, Andreas 2017-04-07 Andreas Tobler * config/aarch64/aarch64-freebsd.h: Define WCHAR_TYPE.

Re: [PR59319] output friends in debug info

2017-04-07 Thread Alexandre Oliva
On Mar 21, 2017, Alexandre Oliva wrote: > On Jan 27, 2017, Alexandre Oliva wrote: >> On Oct 19, 2016, Alexandre Oliva wrote: >>> On Sep 23, 2016, Alexandre Oliva wrote: On Aug 30, 2016, Alexandre Oliva

[PATCH] Fix iq2000-elf building libgcc

2017-04-07 Thread Jeff Law
The iq2000-elf port will not currently build libgcc due to triggering this assert in dwarf2out.c::dwarf2out_var_location gcc_assert (prev && (CALL_P (prev) || (NONJUMP_INSN_P (prev) && GET_CODE (PATTERN (prev)) == SEQUENCE

[PATCH] Add _mm512_{,mask_}reduce_*_* intrinsics (PR target/80324)

2017-04-07 Thread Jakub Jelinek
Hi! This patch is slightly larger, so I haven't included it in the patch I've sent a few minutes ago. I've looked at godbolt for what ICC generates for these and picked sequences that generate approx. as good code as that. For min_epi64/max_epi64/min_epu64/max_epu64 there is a slight

Re: [PATCH] Add _mm512_{,mask_}reduce_*_* intrinsics (PR target/80324)

2017-04-07 Thread Uros Bizjak
On Fri, Apr 7, 2017 at 4:52 PM, Jakub Jelinek wrote: > Hi! > > This patch is slightly larger, so I haven't included it in the patch I've > sent a few minutes ago. > > I've looked at godbolt for what ICC generates for these and picked sequences > that generate approx. as good

Re: [PATCH] have chkp skip flexible member arrays (PR #79986)

2017-04-07 Thread Jason Merrill
On Wed, Mar 29, 2017 at 7:07 PM, Martin Sebor wrote: > On 03/21/2017 01:33 PM, Jason Merrill wrote: >> On Tue, Mar 21, 2017 at 11:08 AM, Martin Sebor wrote: >>> On 03/20/2017 10:27 PM, Jason Merrill wrote: On Mon, Mar 20, 2017 at 7:58 PM, Martin Sebor

Re: [PATCH] S/390: Optimize atomic_compare_exchange and atomic_compare builtins.

2017-04-07 Thread Dominik Vogt
On Wed, Apr 05, 2017 at 02:52:00PM +0100, Dominik Vogt wrote: > On Mon, Mar 27, 2017 at 09:27:35PM +0100, Dominik Vogt wrote: > > The attached patch optimizes the atomic_exchange and > > atomic_compare patterns on s390 and s390x (mostly limited to > > SImode and DImode). Among general

[PATCH] Evaluate a SAVE_EXPR before an UBSAN check (PR sanitizer/80350).

2017-04-07 Thread Martin Liška
Hello. Similar to what was done in Marek's r202113, when op1 is a SAVE_EXPR it must be evaluated before condition, in order to be able to deliver the operand to real shifting. And not just to a BB where ubsan report function is called. Patch can bootstrap on ppc64le-redhat-linux and survives

patch to fix PR70478

2017-04-07 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70478 The patch was successfully bootstrapped and tested on x86-64/ppc64/arm64. Committed as rev. 246764. Index: ChangeLog === --- ChangeLog (revision

Re: [Patch, Fortran, F03] PR 80046: Explicit interface required: pointer argument

2017-04-07 Thread Janus Weil
ping! 2017-03-29 22:25 GMT+02:00 Janus Weil : > Hi all, > > here is a patch that enhances the diagnostics for procedure-pointer > assignments, so that procedure-pointer components that need an > explicit interface are correctly rejected. > > Regtests cleanly on

Re: C++ PATCH to fix bogus maybe-uninitialized warning (PR c++/80119)

2017-04-07 Thread Jason Merrill
On Tue, Mar 21, 2017 at 6:00 PM, Marek Polacek wrote: > On Tue, Mar 21, 2017 at 08:41:01PM +0100, Jakub Jelinek wrote: >> On Tue, Mar 21, 2017 at 03:27:02PM -0400, Jason Merrill wrote: >> > OK. >> > >> > On Tue, Mar 21, 2017 at 11:38 AM, Marek Polacek

[PATCH] Fix avx512f-vgetmantpd-2.c testcase with -m32

2017-04-07 Thread Jakub Jelinek
Hi! I've noticed the avx512f-vgetmantpd-2.c testcase eats lots of CPU time on KNL with -m32 and FAILs. The problem is excess precision, I've added -mfpmath=sse to it to fix that. Tested with

Re: [PATCH] Fix avx512f-vgetmantpd-2.c testcase with -m32

2017-04-07 Thread Uros Bizjak
On Fri, Apr 7, 2017 at 4:54 PM, Jakub Jelinek wrote: > Hi! > > I've noticed the avx512f-vgetmantpd-2.c testcase eats lots of > CPU time on KNL with -m32 and FAILs. The problem is > excess precision, I've added -mfpmath=sse to it to fix that. > > Tested with > make -j272 -k

[PATCH] Fix failure to build libgcc for SH ports

2017-04-07 Thread Jeff Law
The SH ports can occasionally fail to build libgcc, particularly in parallel builds: /var/lib/jenkins/jobs/CROSS-SETUP/workspace/gcc/libgcc/unwind-dw2.c:403:10: fatal error: md-unwind-support.h: No such file or directory #include "md-unwind-support.h" ^

Re: [PATCH] Destroy arguments for _Cilk_spawn calling in the child (PR 80038)

2017-04-07 Thread Xi Ruoyao
On 2017-04-06 11:12 -0600, Jeff Law wrote: > With the likely deprecation in mind, I've only done a cursory review of  > the changes -- mostly to verify that they hit Cilk+ paths only. > What's the purpose behind changing when we set the in_lto_p flag? Without that change, GCC with my patch

Re: [PATCH] Add some missing AVX and AVX512F intrinsics (PR target/8032{2,3,5,6})

2017-04-07 Thread Uros Bizjak
On Fri, Apr 7, 2017 at 4:44 PM, Jakub Jelinek wrote: > Hi! > > Apparently while we weren't closely watching, Intel has added into > ICC various new intrinsics and they have been added into Clang > last fall as well. > > Tested with > make -j272 -k check-gcc

Re: [PATCH] S/390: Optimize atomic_compare_exchange and atomic_compare builtins.

2017-04-07 Thread Dominik Vogt
On Fri, Apr 07, 2017 at 04:34:44PM +0200, Ulrich Weigand wrote: > > +; Peephole to combine a load-and-test from volatile memory which combine > > does > > +; not do. > > +(define_peephole2 > > + [(set (match_operand:GPR 0 "register_operand") > > + (match_operand:GPR 2 "memory_operand")) > > +

Re: patch to fix PR70703

2017-04-07 Thread Vladimir Makarov
On 04/06/2017 06:24 AM, Richard Biener wrote: On Wed, Apr 5, 2017 at 6:18 PM, Vladimir Makarov wrote: On 04/05/2017 12:07 PM, Vladimir Makarov wrote: I'll correct the patch. Here is the patch I've committed. Note that in such contexts it's better to just use

Re: C++ PATCH for c++/80095, ICE with this pointer in NSDMI

2017-04-07 Thread Jason Merrill
OK, thanks. On Wed, Apr 5, 2017 at 5:49 AM, Marek Polacek wrote: > Ping. > > On Wed, Mar 29, 2017 at 11:32:39PM +0200, Marek Polacek wrote: >> On Wed, Mar 29, 2017 at 02:56:51PM -0400, Jason Merrill wrote: >> > On Wed, Mar 29, 2017 at 12:38 PM, Marek Polacek

Re: C++ PATCH to fix ICE in replace_placeholders_r (PR c++/79937)

2017-04-07 Thread Jason Merrill
On Fri, Mar 24, 2017 at 12:22 PM, Marek Polacek wrote: > On Thu, Mar 23, 2017 at 05:09:58PM -0400, Jason Merrill wrote: >> On Thu, Mar 23, 2017 at 4:34 PM, Marek Polacek wrote: >> > On Tue, Mar 14, 2017 at 02:34:30PM -0400, Jason Merrill wrote: >> >> On

Re: [PATCH v2,rs6000] PR80108: Fix ICE with cross compiler

2017-04-07 Thread Segher Boessenkool
Hi Kelvin, Sorry this has fallen by the wayside. I did mark it "to do", and then promptly buried it. Whoops. On Thu, Apr 06, 2017 at 08:36:00AM -0600, Kelvin Nilsen wrote: > +dg-test $gfortran_test_path/[lindex $args 1] "" > $gfortran_aux_module_flags Your mailer messed up this line (and

[C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread Volker Reichelt
Hi, with the following patch I suggest to add a diagnostic for extra semicolons after in-class member function definitions: struct A { A() {}; void foo() {}; friend void bar() {}; }; Although they are allowed in the C++ standard, people (including me) often like to get rid of

Re: [PATCH][PR target/80358][7 regression] Fix boundary check error in expand_block_compare

2017-04-07 Thread Segher Boessenkool
On Fri, Apr 07, 2017 at 02:38:50PM -0500, Aaron Sawdey wrote: > Turns out we get passed const -1 for the length arg from this code. > ROUND_UP adds load_mode_size to that resulting in a small positive > number, hilarity ensues. Glad you liked it as well ;-) > Fixed by computing a sensible limit

[C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread Volker Reichelt
Hi, with the following patch I suggest to add a diagnostic for extra semicolons after in-class member function definitions: struct A { A() {}; void foo() {}; friend void bar() {}; }; Although they are allowed in the C++ standard, people (including me) often like to get rid of

Re: [PATCH] Add a new type attribute always_alias (PR79671)

2017-04-07 Thread Jason Merrill
On Fri, Apr 7, 2017 at 11:32 AM, Bernd Edlinger wrote: > On 04/07/17 17:10, Richard Biener wrote: >> On April 7, 2017 3:37:30 PM GMT+02:00, Bernd Edlinger >> wrote: >>> On 04/07/17 08:54, Richard Biener wrote: On Thu, 6 Apr 2017, Bernd

Re: [C++ PATCH] New warning for extra semicolons after in-class function definitions

2017-04-07 Thread David Malcolm
On Fri, 2017-04-07 at 21:55 +0200, Volker Reichelt wrote: > Hi, > > with the following patch I suggest to add a diagnostic for extra > semicolons after in-class member function definitions: > > struct A > { > A() {}; > void foo() {}; > friend void bar() {}; > }; > > Although

[PATCH] Fix dwarf2out ICE with self-inlining (PR debug/80321)

2017-04-07 Thread Jakub Jelinek
Hi! The following C and Ada testcases show ICE due to endless recursion in dwarf2out.c. The problem is that when processing BLOCK_NONLOCALIZED_VARS, we want to treat all the FUNCTION_DECLs in there as mere declarations, but gen_subprogram_die does: int declaration = (current_function_decl !=

Re: patch to fix PR70478

2017-04-07 Thread Jakub Jelinek
On Fri, Apr 07, 2017 at 12:04:16PM -0400, Vladimir Makarov wrote: > The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70478 > > The patch was successfully bootstrapped and tested on x86-64/ppc64/arm64. > > Committed as rev. 246764. > > Index: ChangeLog >