Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-03 Thread Prathamesh Kulkarni
On 3 May 2017 at 03:28, Martin Sebor wrote: > On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: >> >> Hi, >> The attached patch attempts to add option -Wenum-conversion for C and >> objective-C similar to clang, which warns when an enum value of a type >> is implicitly

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-03 Thread Uros Bizjak
On Wed, May 3, 2017 at 12:16 AM, Daniel Santos wrote: >> I'd recommend that in the predicate, you check match_parallel from the >> bottom up, since subexpressions on the top are already matched, and >> you can have different number of subexpressions at the top. >> >>

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Eric Botcazou
> 2017-04-11 Bin Cheng > > * rtlanal.c (rtx_cost): Handle TRUNCATE between tieable modes. This breaks bootstrap with RTL checking: /home/eric/build/gcc/native/./gcc/xgcc -B/home/eric/build/gcc/native/./gcc/ - nostdinc -x c /dev/null -S -o /dev/null -fself-

Re: [PATCH 5/7] clean up quoting problems - c-family (PR 80280 et al.)

2017-05-03 Thread Joseph Myers
On Tue, 2 May 2017, Martin Sebor wrote: > + inform (loc, "in the expansion of concept %qE %qS", check, sub); Are you sure about this (two consecutive quoted strings, open quote of %qS following closing quote of %qE) or should it be a single quoted string %<%E %S%>? -- Joseph S. Myers

[C++ PATCH] name lookup cleanup

2017-05-03 Thread Nathan Sidwell
I'm starting to push my name lookup cleanups from the modules branch. This first patch simply reorders existing decls in cp-tree.h to before the name-lookup #include. It'll allow moving some more things into the cp_global_trees array. The thrust of the name-lookup cleanup will remove a

[PATCH v2] C++: Add fix-it hints for -Wold-style-cast

2017-05-03 Thread David Malcolm
On Thu, 2017-04-27 at 23:03 +0200, Marek Polacek wrote: > On Thu, Apr 27, 2017 at 05:10:24PM -0400, David Malcolm wrote: > > + /* First try const_cast. */ > > + trial = build_const_cast (dst_type, orig_expr, 0 /* complain > > */); > > + if (trial != error_mark_node) > > +return

Re: [PATCH 2/7] clean up quoting problems - gcc (PR 80280 et al.)

2017-05-03 Thread Jeff Law
On 05/02/2017 08:37 PM, Martin Sebor wrote: The attached patch adds missing quoting to diagnostic directives in files in the top-level gcc/ directory. Martin gcc-80280-gcc.diff gcc/ChangeLog: * builtins.c (expand_builtin_object_size): Add missing quoting to %D and like

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Joseph Myers
On Tue, 2 May 2017, Martin Sebor wrote: > In bug 80280 - Missing closing quote (%>) c/semantics.c and > c/c-typeck.c, a translator points out one of a number of kinds > of cosmetic problems that tend to come up late in development, > during translation of GCC messages. Other, arguably more

Re: [PATCH GCC8][03/33]Refactor invariant variable/expression handling

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 3:41 PM, Bin.Cheng wrote: > On Wed, May 3, 2017 at 3:38 PM, Christophe Lyon > wrote: >> Hi Bin, >> >> >> On 24 April 2017 at 12:26, Richard Biener wrote: >>> On Tue, Apr 18, 2017 at 12:38 PM,

RE: [PATCH][x86] Add missing intrinsics for ADD[SD,SS] and SUB[SD,SS]

2017-05-03 Thread Peryt, Sebastian
Thank you! Sebastian -Original Message- From: Uros Bizjak [mailto:ubiz...@gmail.com] Sent: Tuesday, May 2, 2017 3:08 PM To: Peryt, Sebastian Cc: gcc-patches@gcc.gnu.org; kirill.yuk...@gmail.com Subject: Re: [PATCH][x86] Add missing intrinsics for ADD[SD,SS]

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jan Hubicka
> On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > > Hi, > > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This > > is > > related to fact that using sreal implies a non-trivial constructor and thus > > ggc_cleared_alloc is no longer standard compliant. I

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

2017-05-03 Thread Martin Sebor
On 04/30/2017 05:39 PM, Joseph Myers wrote: On Sat, 29 Apr 2017, Martin Sebor wrote: +The safe way to either initialize or "reset" objects of non-trivial Should use TeX quotes in Texinfo files, ``reset''. Heh :) I wrestled with Emacs to get rid of those, It kept replacing my plain quotes

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > Hi, > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This is > related to fact that using sreal implies a non-trivial constructor and thus > ggc_cleared_alloc is no longer standard compliant. I however do not

[PATCH v8] add -fpatchable-function-entry=N,M option

2017-05-03 Thread Torsten Duwe
On Wed, Mar 01, 2017 at 01:35:52PM +, Richard Earnshaw (lists) wrote: > >> > >> How about --fpatchable-function-entry=? > > > I haven't reviewed it yet. I'm not really planning to spend any more > time on this until stage1 re-opens. So I guess this is about now? Here is version 8, which is

Re: [PATCH] have -Wformat-overflow handle -fexec-charset (PR 80503)

2017-05-03 Thread Martin Sebor
On 05/03/2017 08:22 AM, Christophe Lyon wrote: Hi, On 29 April 2017 at 19:56, Andreas Schwab wrote: On Apr 28 2017, Martin Sebor wrote: +void test_width_and_precision_out_of_range (char *d) +{ +#if __LONG_MAX__ == 2147483647 +# define MAX_P1_STR

Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jan Hubicka
Hi, my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This is related to fact that using sreal implies a non-trivial constructor and thus ggc_cleared_alloc is no longer standard compliant. I however do not quite understand why GCC 4.1 manages to misoptimize this code but I

Re: [PATCH] have -Wformat-overflow handle -fexec-charset (PR 80503)

2017-05-03 Thread Christophe Lyon
On 3 May 2017 at 16:54, Martin Sebor wrote: > On 05/03/2017 08:22 AM, Christophe Lyon wrote: >> >> Hi, >> >> >> On 29 April 2017 at 19:56, Andreas Schwab wrote: >>> >>> On Apr 28 2017, Martin Sebor wrote: >>> +void

[PATCH] Remove am33_2.0-linux from config-list.mk

2017-05-03 Thread Jeff Law
am33_2.0-linux was removed from glibc some time ago. Furthermore, for the testing done by config-list.mk builds, we get almost identical coverage from mn10300-elf. In fact, mn10300-elf is actually better for testing purposes -- we can build newlib to do a first level test of the code

Re: [PATCH 1/4][PR tree-optimization/78496] Don't simplify conditionals too early in VRP

2017-05-03 Thread Jeff Law
[ With the patch attached... ] On 05/03/2017 10:31 AM, Jeff Law wrote: This is the first of 3-5 patches to address pr78496. The goal of these patches is to catch jump threads earlier in the pipeline to avoid undesirable behavior in PRE and more generally be able to exploit the secondary

Re: [PATCH v2] Generate reproducible output independently of the build-path

2017-05-03 Thread Ximin Luo
Joseph Myers: > On Tue, 11 Apr 2017, Ximin Luo wrote: > >> Copyright disclaimer >> >> >> I dedicate these patches to the public domain by waiving all of my rights to >> the work worldwide under copyright law, including all related and neighboring >> rights, to the extent

[PATCH 1/4][PR tree-optimization/78496] Don't simplify conditionals too early in VRP

2017-05-03 Thread Jeff Law
This is the first of 3-5 patches to address pr78496. The goal of these patches is to catch jump threads earlier in the pipeline to avoid undesirable behavior in PRE and more generally be able to exploit the secondary opportunities exposed by jump threading. One of the more serious issues I

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Richard Biener
On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek wrote: >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: >> Hi, >> my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > This is >> related to fact that using sreal implies a non-trivial constructor

Re: [PATCH] Implement a warning for bogus sizeof(pointer) / sizeof(pointer[0])

2017-05-03 Thread Jason Merrill
On Tue, May 2, 2017 at 9:26 AM, Bernd Edlinger wrote: > On 05/01/17 17:54, Jason Merrill wrote: >> On Fri, Apr 28, 2017 at 1:05 PM, Bernd Edlinger >> wrote: >>> On 04/28/17 17:29, Martin Sebor wrote: On 04/28/2017 08:12 AM, Bernd

Re: [PATCH, v3] Fix PR51513, switch statement with default case containing __builtin_unreachable leads to wild branch

2017-05-03 Thread Richard Biener
On Wed, 26 Apr 2017, Peter Bergner wrote: > On 4/20/17 8:26 AM, Peter Bergner wrote: > > On 4/20/17 2:37 AM, Richard Biener wrote: > >> Ok, so I think we should ensure that we remove the regular cases > >> with unreachable destination, like in > >> > >> switch (i) > >> { > >> case 0: > >>

Re: [PATCH] have -Wformat-overflow handle -fexec-charset (PR 80503)

2017-05-03 Thread Christophe Lyon
Hi, On 29 April 2017 at 19:56, Andreas Schwab wrote: > On Apr 28 2017, Martin Sebor wrote: > >> +void test_width_and_precision_out_of_range (char *d) >> +{ >> +#if __LONG_MAX__ == 2147483647 >> +# define MAX_P1_STR "2147483648" >> +#elif __LONG_MAX__

Re: [PATCH] Fix documentation and a ctor in gcov.c

2017-05-03 Thread Nathan Sidwell
On 05/02/2017 11:37 AM, Martin Liška wrote: On 04/28/2017 07:23 PM, Nathan Sidwell wrote: Write proper member initializers please. Hi. Done that, patch can bootstrap on ppc64le-redhat-linux and survives regression tests. I consider the patch as pre-approved. yes, thanks! -- Nathan

Re: [PATCH GCC8][03/33]Refactor invariant variable/expression handling

2017-05-03 Thread Christophe Lyon
Hi Bin, On 24 April 2017 at 12:26, Richard Biener wrote: > On Tue, Apr 18, 2017 at 12:38 PM, Bin Cheng wrote: >> Hi, >> This patch refactors how invariant variable/expressions are handled. Now >> they are >> recorded in the same kind data

Re: [PATCH] handle sprintf(d, "%s", ...) in gimple-ssa-sprintf.c

2017-05-03 Thread Martin Sebor
On 05/03/2017 04:20 AM, Richard Biener wrote: On Tue, May 2, 2017 at 4:41 PM, Martin Sebor wrote: FWIW, my fix for bug 79062 is only partial (it gets the pass to run but the warnings are still not issued). I don't quite understand what prevents the warning flag(s) from

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Christophe Lyon
Hi Bin, On 3 May 2017 at 12:12, Bin.Cheng wrote: > On Wed, May 3, 2017 at 11:09 AM, Kyrill Tkachov > wrote: >> Hi Bin, >> >> >> On 03/05/17 11:02, Bin.Cheng wrote: >>> >>> On Wed, May 3, 2017 at 9:38 AM, Bin.Cheng

[committed] New fix-it printer

2017-05-03 Thread David Malcolm
The existing fix-it printer can lead to difficult-to-read output when fix-it hints are near each other. For example, in a recent patch to add fix-it hints to the C++ frontend's -Wold-style-cast, e.g. for: foo *f = (foo *)ptr->field; ^ the fix-it hints: replace the

Re: [PATCH GCC8][17/33]Treat complex cand step as invriant expression

2017-05-03 Thread Richard Biener
On Tue, Apr 18, 2017 at 12:46 PM, Bin Cheng wrote: > Hi, > We generally need to compute cand step in loop preheader and use it in loop > body. > Unless it's an SSA_NAME of constant integer, an invariant expression is > needed. I'm confused as to what this patch does.

Re: Update ipa-cp to new time metrics

2017-05-03 Thread Martin Jambor
Hi, On Tue, May 02, 2017 at 11:33:28AM +0200, Jan Hubicka wrote: > Hi, > this patch makes ipa-cp to use nonspecialized time as a base for decision > about > cloning. I wonder about the capping - we perhaps want to use sreals further > in > the code because time differences can be large (with

Re: [PATCH GCC8][03/33]Refactor invariant variable/expression handling

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 3:38 PM, Christophe Lyon wrote: > Hi Bin, > > > On 24 April 2017 at 12:26, Richard Biener wrote: >> On Tue, Apr 18, 2017 at 12:38 PM, Bin Cheng wrote: >>> Hi, >>> This patch refactors how invariant

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Martin Sebor
On 05/03/2017 09:53 AM, Joseph Myers wrote: On Tue, 2 May 2017, Martin Sebor wrote: In bug 80280 - Missing closing quote (%>) c/semantics.c and c/c-typeck.c, a translator points out one of a number of kinds of cosmetic problems that tend to come up late in development, during translation of

[committed] Fix typo in common.opt

2017-05-03 Thread David Malcolm
Successfully bootstrapped on x86_64-pc-linux-gnu. Committed to trunk as r247562. gcc/ChangeLog: * common.opt (fdiagnostics-parseable-fixits): Fix typo. --- gcc/common.opt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/common.opt b/gcc/common.opt index

Re: [PATCH] Fix ICE in modified_type_die (PR debug/80461)

2017-05-03 Thread Jason Merrill
On Wed, Apr 19, 2017 at 12:29 PM, Jeff Law wrote: > On 04/19/2017 10:13 AM, Jakub Jelinek wrote: >> >> On Wed, Apr 19, 2017 at 09:55:19AM -0600, Jeff Law wrote: >>> >>> On 04/19/2017 09:10 AM, Jakub Jelinek wrote: On Wed, Apr 19, 2017 at 08:57:52AM -0600, Jeff Law

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Richard Biener
On May 3, 2017 6:46:05 PM GMT+02:00, Jakub Jelinek wrote: >On Wed, May 03, 2017 at 06:44:46PM +0200, Richard Biener wrote: >> On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek >wrote: >> >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: >> >> Hi,

Re: [RFC PATCH 0/3] Call summary class

2017-05-03 Thread Martin Jambor
On Mon, Feb 27, 2017 at 05:36:48PM +0100, Martin Jambor wrote: > Hello, > > the patch sequence in this thread adds a call_summary class, which is > analogous to function_summary we already have but which gathers > information about call graph edges, rather than nodes. > > The first patch

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:39:18PM +0200, Jan Hubicka wrote: > > On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > > > Hi, > > > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > > > This is > > > related to fact that using sreal implies a non-trivial

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:44:46PM +0200, Richard Biener wrote: > On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek wrote: > >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > >> Hi, > >> my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > >

Re: C++ PATCH to fix ICE in replace_placeholders_r (PR c++/79937)

2017-05-03 Thread Jason Merrill
On Tue, Apr 25, 2017 at 12:17 PM, Marek Polacek wrote: > On Fri, Apr 07, 2017 at 03:27:36PM -0400, Jason Merrill wrote: >> On Fri, Mar 24, 2017 at 12:22 PM, Marek Polacek wrote: >> > On Thu, Mar 23, 2017 at 05:09:58PM -0400, Jason Merrill wrote: >> >> On

Re: [PATCH 1/4][PR tree-optimization/78496] Don't simplify conditionals too early in VRP

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 5:32 PM, Jeff Law wrote: > [ With the patch attached... ] > > > On 05/03/2017 10:31 AM, Jeff Law wrote: >> >> This is the first of 3-5 patches to address pr78496. >> >> The goal of these patches is to catch jump threads earlier in the pipeline >> to avoid

[PATCH, rs6000] Avoid vectorizing versioned copy loops with vectorization factor 2

2017-05-03 Thread Bill Schmidt
Hi, We recently became aware of some poor code generation as a result of unprofitable (for POWER) loop vectorization. When a loop is simply copying data with 64-bit loads and stores, vectorizing with 128-bit loads and stores generally does not provide any benefit on modern POWER processors.

New German PO file for 'gcc' (version 7.1.0)

2017-05-03 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-7.1.0.de.po', has just

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Martin Sebor
On 05/03/2017 01:59 PM, Joseph Myers wrote: On Wed, 3 May 2017, Martin Sebor wrote: Use contrib/config-list.mk, with a native compiler with this patch in the PATH, to test building compilers for many configurations. (No doubt you'll also find existing build issues, which may or may not be

Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining

2017-05-03 Thread Jason Merrill
On Tue, Mar 14, 2017 at 8:24 AM, Pierre-Marie de Rodat wrote: > Hello, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79542 reports an ICE in > dwarf2out.c for an Ada testcase built with optimization. > > This crash happens during the late generation pass because >

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Joseph Myers
On Wed, 3 May 2017, Martin Sebor wrote: > > Clarifying the comment is helpful, but a data structure involving putting > > the same character in both still doesn't make sense to me. It would seem > > a lot clearer to (for example) split "DFKTEV" into separate "DFTV" and > > "EK" cases, where "EK"

Re: [PATCH 1/4][PR tree-optimization/78496] Don't simplify conditionals too early in VRP

2017-05-03 Thread Jeff Law
On 05/03/2017 10:55 AM, Bin.Cheng wrote: On Wed, May 3, 2017 at 5:32 PM, Jeff Law wrote: [ With the patch attached... ] On 05/03/2017 10:31 AM, Jeff Law wrote: This is the first of 3-5 patches to address pr78496. The goal of these patches is to catch jump threads earlier

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Jeff Law
On 05/03/2017 12:47 PM, Martin Sebor wrote: I can do some of it but not all of it. The work doesn't involve just building the compiler but also running the tests and fixing up regressions in those that are written to expect the unquoted diagnostics. I don't have the ability to run the test

Re: [PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-03 Thread Joseph Myers
On Wed, 3 May 2017, Martin Sebor wrote: > > Use contrib/config-list.mk, with a native compiler with this patch in the > > PATH, to test building compilers for many configurations. (No doubt > > you'll also find existing build issues, which may or may not be filed in > > Bugzilla.) > > I can do

[gomp4] Don't mark OpenACC auto loops as independent inside acc parallel regions

2017-05-03 Thread Cesar Philippidis
The OpenACC 2.5 spec updated the behavior of acc loops inside acc parallel regions such that loop with seq and auto clauses are not implicitly independent. Back in OpenACC 2.0, all loops inside acc parallel regions were implicitly independent. Oddly enough, if the user just places an acc loop

Re: [wwwdocs, ARM, AArch64] Document ABI changes and fixes

2017-05-03 Thread Gerald Pfeifer
On Tue, 2 May 2017, Richard Earnshaw (lists) wrote: > This patch adds some release notes for the gcc ABI changes affecting ARM > and AArch64. This looks fine, thank you. The one thing you may want to look into is where it says "code where class objects are passed by value to functions" which

[PATCH] Fix -fopt-info documentation in invoke.texi

2017-05-03 Thread Steve Ellcey
The description of the default behavour of -fopt-info in invoke.texi is wrong.  This patch fixes it.  I also added a sentence to explicitly say what is implied by the note that -fopt-info-vec-missed is the same as -fopt-info-missed-vec.  Namely, that order doesn't matter. OK to checkin? Steve

Re: [testsuite, committed] Replace absolute line numbers in c-c++-common

2017-05-03 Thread Mike Stump
On May 3, 2017, at 12:39 AM, Tom de Vries wrote: > diff --git a/gcc/testsuite/c-c++-common/Wshift-negative-value-1.c > b/gcc/testsuite/c-c++-common/Wshift-negative-value-1.c > index 8f14034..7df1804 100644 > --- a/gcc/testsuite/c-c++-common/Wshift-negative-value-1.c > +++

Use base inequality for some vector alias checks

2017-05-03 Thread Richard Sandiford
This patch checks whether two data references x and y cannot partially overlap and so are independent whenever != We can then use this in the vectoriser to optimise alias checks. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ 2016-05-03 Richard

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-03 Thread Uros Bizjak
On Wed, May 3, 2017 at 9:38 AM, Daniel Santos wrote: > On 05/03/2017 01:10 AM, Uros Bizjak wrote: >> >> The order of subexpressions of parallel in general does not matter. > > > Thanks, this makes things much clearer. > >>> Also, I'm wondering if there's anything wrong

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 7:17 AM, Eric Botcazou wrote: >> 2017-04-11 Bin Cheng >> >> * rtlanal.c (rtx_cost): Handle TRUNCATE between tieable modes. > > This breaks bootstrap with RTL checking: > > /home/eric/build/gcc/native/./gcc/xgcc

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-03 Thread Daniel Santos
On 05/03/2017 01:10 AM, Uros Bizjak wrote: The order of subexpressions of parallel in general does not matter. Thanks, this makes things much clearer. Also, I'm wondering if there's anything wrong with calling ix86_gen_leave () and plucking the insns out of the generated parallel insn and

Alternative check for vector refs with same alignment

2017-05-03 Thread Richard Sandiford
vect_find_same_alignment_drs uses the ddr dependence distance to tell whether two references have the same alignment. Although that's safe with the current code, there's no particular reason why a dependence distance of 0 should mean that the accesses start on the same byte. E.g. a reference to

Handle data dependence relations with different bases

2017-05-03 Thread Richard Sandiford
This patch tries to calculate conservatively-correct distance vectors for two references whose base addresses are not the same. It sets a new flag DDR_COULD_BE_INDEPENDENT_P if the dependence isn't guaranteed to occur. The motivating example is: struct s { int x[8]; }; void f (struct s *a,

Re: [PATCH] Optimize in VRP loads from constant arrays (take 2)

2017-05-03 Thread Jakub Jelinek
On Tue, May 02, 2017 at 02:50:16PM +0200, Richard Biener wrote: > > If array_at_struct_end_p is wrong, it should be fixed ;) > > Indeed. It was originally meant to say false if you can trust > TYPE_DOMAIN of the array but now it says false if there's some means > to constrain the array size (the

[RFC][PATCH] Introduce -fdump*-folding

2017-05-03 Thread Martin Liška
Hello Last release cycle I spent quite some time with reading of IVOPTS pass dump file. Using -fdump*-details causes to generate a lot of 'Applying pattern' lines, which can make reading of a dump file more complicated. There are stats for tramp3d with -O2 and -fdump-tree-all-details. Percentage

[testsuite, committed] Replace absolute line numbers in c-c++-common

2017-05-03 Thread Tom de Vries
Hi, this patch replaces absolute line numbers in the c-c++-common directory. Committed as obvious. Thanks, - Tom Replace absolute line numbers in c-c++-common 2017-05-01 Tom de Vries PR testsuite/80557 * c-c++-common/Wshift-negative-value-1.c: Replace absolute

Re: [PATCH] Allow building GCC with PTX offloading even without CUDA being installed (gcc and nvptx-tools patches)

2017-05-03 Thread Jakub Jelinek
On Sat, Jan 21, 2017 at 03:50:43PM +0100, Thomas Schwinge wrote: > > In order to configure gcc to load libcuda.so.1 dynamically, > > one has to either configure it --without-cuda-driver, or without > > --with-cuda-driver=/--with-cuda-driver-lib=/--with-cuda-driver-include= > > options if cuda.h

[testsuite, committed] Add quotes to numerical comment arg of dg directive

2017-05-03 Thread Tom de Vries
Hi, this patch adds quotes to the comment argument of a dg-message directive when the comment is a plain number, to avoid confusion with line numbers. Committed as obvious. Thanks, - Tom Add quotes to numerical comment arg of dg directive 2017-05-01 Tom de Vries

[committed] Wrap tree-data-ref.h macro arguments

2017-05-03 Thread Richard Sandiford
Tested on aarch64-linux-gnu and x86_64-linux-gnu. Installed as obvious. Thanks, Richard gcc/ 2016-05-03 Richard Sandiford * tree-data-ref.h (SUB_CONFLICTS_IN_A): Wrap SUB argument in brackets. (SUB_CONFLICTS_IN_B, SUB_LAST_CONFLICT,

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-03 Thread Andrew Pinski
On Wed, May 3, 2017 at 1:10 AM, Martin Liška wrote: > Hello > > Last release cycle I spent quite some time with reading of IVOPTS pass > dump file. Using -fdump*-details causes to generate a lot of 'Applying > pattern' > lines, which can make reading of a dump file more

[PATCH] Improve vectorizer peeling for alignment costmodel

2017-05-03 Thread Richard Biener
The following extends the very simplistic cost modeling I added somewhen late in the release process to, for all unknown misaligned refs, also apply this model for loops containing stores. The model basically says it's useless to peel for alignment if there's only a single DR that is affected or

Re: [gcn][patch] Add -mgpu option and plumb in assembler/linker

2017-05-03 Thread Andrew Stubbs
On 02/05/17 18:08, Martin Jambor wrote: Hi Andrew, sorry for replying only now but yesterday was public holiday here and I am still only in the process of recovering from a long weekend. No problem, the UK had the same. :-) While the only objection I have is the C++ style comment in

[PATCH] Revert part of PR80492

2017-05-03 Thread Richard Biener
This change unnecessarily pessimizes some cases. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2017-05-03 Richard Biener Revert PR tree-optimization/80492 * tree-ssa-alias.c (decl_refs_may_alias_p): Handle

Re: [PATCH] handle sprintf(d, "%s", ...) in gimple-ssa-sprintf.c

2017-05-03 Thread Richard Biener
On Tue, May 2, 2017 at 4:41 PM, Martin Sebor wrote: FWIW, my fix for bug 79062 is only partial (it gets the pass to run but the warnings are still not issued). I don't quite understand what prevents the warning flag(s) from getting set when -flto is used.

Re: Alternative check for vector refs with same alignment

2017-05-03 Thread Richard Sandiford
"Bin.Cheng" writes: > On Wed, May 3, 2017 at 11:07 AM, Richard Biener > wrote: >> On Wed, May 3, 2017 at 9:54 AM, Richard Sandiford >> wrote: >>> vect_find_same_alignment_drs uses the ddr dependence distance >>> to

Re: [PATCH, GCC/ARM, stage4] Set mode for success result of atomic compare and swap

2017-05-03 Thread Thomas Preudhomme
Hi Kyrill, On 19/04/17 14:34, Kyrill Tkachov wrote: Hi Thomas, On 12/04/17 09:59, Thomas Preudhomme wrote: Hi, Currently atomic_compare_and_swap_1 define_insn do not have a mode set for the destination of the set indicating the success result of the instruction. This is because the operand

[PATCH] Doxygen: add default location for filters and output folder.

2017-05-03 Thread Martin Liška
On 04/28/2017 02:03 PM, Martin Liška wrote: > Why do we not make a default for OUTPUT_DIRECTORY and INPUT_FILTER ? > I would expect people are running doxygen from GCC root folder. Hi. I'm suggesting following patch for that. Martin >From 4623de7cf43598de0f778dc976a3b219220716e3 Mon Sep 17

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 9:38 AM, Bin.Cheng wrote: > On Wed, May 3, 2017 at 7:17 AM, Eric Botcazou wrote: >>> 2017-04-11 Bin Cheng >>> >>> * rtlanal.c (rtx_cost): Handle TRUNCATE between tieable modes. >> >> This breaks

Re: Alternative check for vector refs with same alignment

2017-05-03 Thread Richard Biener
On Wed, May 3, 2017 at 9:54 AM, Richard Sandiford wrote: > vect_find_same_alignment_drs uses the ddr dependence distance > to tell whether two references have the same alignment. Although > that's safe with the current code, there's no particular reason > why a

Re: Alternative check for vector refs with same alignment

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 11:07 AM, Richard Biener wrote: > On Wed, May 3, 2017 at 9:54 AM, Richard Sandiford > wrote: >> vect_find_same_alignment_drs uses the ddr dependence distance >> to tell whether two references have the same

Re: [PATCH, GCC/ARM, Stage 1] PR71607: Fix ICE when loading constant

2017-05-03 Thread Richard Earnshaw (lists)
On 20/04/17 10:54, Prakhar Bahuguna wrote: > [ARM] PR71607: Fix ICE when loading constant > > gcc/ChangeLog: > > 2017-04-18 Andre Vieira > Prakhar Bahuguna > > PR target/71607 > * config/arm/arm.md

Re: [PATCH, GCC/ARM, stage4] Set mode for success result of atomic compare and swap

2017-05-03 Thread Kyrill Tkachov
Hi Thomas, On 03/05/17 10:39, Thomas Preudhomme wrote: Hi Kyrill, On 19/04/17 14:34, Kyrill Tkachov wrote: Hi Thomas, On 12/04/17 09:59, Thomas Preudhomme wrote: Hi, Currently atomic_compare_and_swap_1 define_insn do not have a mode set for the destination of the set indicating the success

Re: [PATCH GCC8][07/33]Offset validity check in address expression

2017-05-03 Thread Richard Biener
On Tue, May 2, 2017 at 7:06 PM, Bin.Cheng wrote: > On Mon, Apr 24, 2017 at 11:34 AM, Richard Biener > wrote: >> On Tue, Apr 18, 2017 at 12:41 PM, Bin Cheng wrote: >>> Hi, >>> For now, we check validity of offset by computing

Re: [PATCH] ggc-page loop

2017-05-03 Thread Richard Biener
On Wed, May 3, 2017 at 2:09 AM, Andrew Pinski wrote: > On Tue, May 2, 2017 at 3:41 PM, Nathan Sidwell wrote: >> This loop in ggc-page confused me, because the iterator is one greater than >> the indexing value. Also the formatting of the array indexing is

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Kyrill Tkachov
Hi Bin, On 03/05/17 11:02, Bin.Cheng wrote: On Wed, May 3, 2017 at 9:38 AM, Bin.Cheng wrote: On Wed, May 3, 2017 at 7:17 AM, Eric Botcazou wrote: 2017-04-11 Bin Cheng * rtlanal.c (rtx_cost): Handle TRUNCATE between

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-03 Thread Bin.Cheng
On Wed, May 3, 2017 at 11:09 AM, Kyrill Tkachov wrote: > Hi Bin, > > > On 03/05/17 11:02, Bin.Cheng wrote: >> >> On Wed, May 3, 2017 at 9:38 AM, Bin.Cheng wrote: >>> >>> On Wed, May 3, 2017 at 7:17 AM, Eric Botcazou >>>

Re: [RFC][PATCH] Introduce -fdump*-folding

2017-05-03 Thread Richard Biener
On Wed, May 3, 2017 at 10:10 AM, Martin Liška wrote: > Hello > > Last release cycle I spent quite some time with reading of IVOPTS pass > dump file. Using -fdump*-details causes to generate a lot of 'Applying > pattern' > lines, which can make reading of a dump file more

Re: [PATCH, testsuite]: Fix g++.dg/lto/pr79671 execute failure

2017-05-03 Thread Richard Biener
On Tue, May 2, 2017 at 5:38 PM, Uros Bizjak wrote: > Hello! > > We have to match input and output operand (or use "+") of an empty asm > to move the value to a register. > > 2017-05-02 Uros Bizjak > > * g++.dg/lto/pr79671_0.C (foo): Fix asm

Re: [PATCH 2/5][GIMPLE FE] PR testsuite/80580: handle invalid types of "->" operands

2017-05-03 Thread Richard Biener
On Mon, May 1, 2017 at 8:05 PM, Mikhail Maltsev wrote: > This bug happens when the LHS of operator '->' is either missing, i.e.: > > (->a) = 0; > > or it is not a pointer: > > int b; > b_2->c = 0; > > LHS should be validated. I think for the missing LHS it's better to simply

Re: [PATCH 3/5][GIMPLE FE] PR testsuite/80580. Handle invalid unary "*" operand type

2017-05-03 Thread Richard Biener
On Mon, May 1, 2017 at 8:07 PM, Mikhail Maltsev wrote: > This is essentially the same problem as in patch 2, but with unary '*'. We > should verify that its argument is a pointer. This is ok with being more specific like "expected pointer as argument of unary %<*%>"

Re: [PATCH] canonical type hashing

2017-05-03 Thread Richard Biener
On Tue, May 2, 2017 at 3:50 PM, Nathan Sidwell wrote: > On the modules branch, I need rematerialize canonical types and the like > from a read-in serialized tree. > > I discovered the canonical-type hash table is fed a bespoke hash value by > each type creator. There was no

Re: [PATCH] ggc-page loop

2017-05-03 Thread Nathan Sidwell
On 05/03/2017 05:54 AM, Richard Biener wrote: He does, albeit in a coding way I dislike (watch how the iterator update is done in the condition!) Sorry you dislike that. I've used that kind of loop idiom, since for ever though. nathan -- Nathan Sidwell

Re: [PATCH] canonical type hashing

2017-05-03 Thread Nathan Sidwell
On 05/03/2017 07:32 AM, Richard Biener wrote: On Tue, May 2, 2017 at 3:50 PM, Nathan Sidwell wrote: Looks ok to me. The new function name 'type_hash_default' is a little odd, maybe name it type_hash_canon_hash instead? sure. I think when I originally broke it out, I