Re: [PATCH] gcc::context creation

On 06/05/2017 07:47 AM, Jakub Jelinek wrote: Whether there is a blank between function and its function comment is something we aren't consistent in, but it seems that in dumpfile.c there is a blank line, so I'm adjusting. Ok (I only know the blank line rule because someone nitted one of my

Re: [PATCH] gcc::context creation

On Mon, Jun 05, 2017 at 08:46:21AM -0400, Nathan Sidwell wrote: > On 06/05/2017 07:47 AM, Jakub Jelinek wrote: > > > Whether there is a blank between function and its function comment > > is something we aren't consistent in, but it seems that in dumpfile.c > > there is a blank line, so I'm

Re: [PATCH, GCC/ARM, ping] Complete legend for ARM register allocation in arm.h

Ping? Best regards, Thomas On 26/05/17 15:20, Thomas Preudhomme wrote: [resending with gcc-patches this time] Hi, The comment describing ARM register allocation in arm.h contains 3 keys: S, F and *. The legend only explains S and *, this patch remedies that. ChangeLog entry is as follows:

RE: [PATCH,testsuite] Add check_effective_target_rdynamic and use it in g++.dg/lto/pr69589_0.C.

Hi Renlin, > > Thanks for fixing this! Do you have plan to backport the fix to gcc-6 branch? > I am happy to backport it. I've rebased the patch on top of the gcc-6 branch and attached it below. Rainer, is this OK for gcc-6? Regards, Toma Tabacu gcc/ChangeLog: Backported from

[PATCH] Add missing entry for -Wduplicated-branches

Hi, the warning option -Wduplicated-branches added by Marek in r244705 https://gcc.gnu.org/viewcvs?rev=244705=gcc=rev lacks an entry in the warning list of doc/invoke.texi. The patch below fixes that. OK for trunk? What about the GCC 7 branch? Regards, Volker 2017-06-05 Volker Reichelt

Re: [PATCH] gcc::context creation

On Mon, Jun 05, 2017 at 06:57:47AM -0400, Nathan Sidwell wrote: > On 06/05/2017 05:46 AM, Jakub Jelinek wrote: > > > Here is a patch to implement that. I chose to keep the 3 dumps predefined > > dumps and just tweak their registered number, otherwise the changes would be > > bigger. > > Yeah,

Fix profile updating in tree-ssa-loop-im

Hi, this patch fixes profile update in tree-ssa-loop-im.c. This looks like quite a noticeable bug because the basic block storing flags ends up with count 0 and thus is optimized for size/possibly moved offline so perhaps even backporting to the release branches would make sense. LSM profuces

[PATCH] Add noexcept to shared_ptr owner comparisons (LWG 2873)

C++17 requires these to be noexcept, and there's no reason not to do it for earlier standard modes too. * include/bits/shared_ptr_base.h (__shared_ptr::owner_before) (__weak_ptr::owner_before, _Sp_owner_less::operator()): Add noexcept specifiers as per LWG 2873 and LWG

Re: [PATCH, GCC/ARM] Complete legend for ARM register allocation in arm.h

On 26/05/17 15:20, Thomas Preudhomme wrote: [resending with gcc-patches this time] Hi, The comment describing ARM register allocation in arm.h contains 3 keys: S, F and *. The legend only explains S and *, this patch remedies that. ChangeLog entry is as follows: *** gcc/ChangeLog ***

Re: {PATCH] New C++ warning -Wcatch-value

On 15 May, Martin Sebor wrote: >> So how about the following then? I stayed with the catch part and added >> a parameter to the warning to let the user decide on the warnings she/he >> wants to get: -Wcatch-value=n. >> -Wcatch-value=1 only warns for polymorphic classes that are caught by >> value

Re: [PING**3] [PATCH] Force use of absolute path names for gcov

On 06/02/2017 10:43 AM, Bernd Edlinger wrote: On 06/02/17 13:35, Nathan Sidwell wrote: On 06/01/2017 03:24 PM, Bernd Edlinger wrote: This is a gcc option that converts relative path names to absolute ones, so that gcov can properly merge the line numbers in projects where different relative

Re: [PATCH, GCC/ARM, ping] Rename *_compute_save_reg_mask ()

Ping? Best regards, Thomas On 26/05/17 15:19, Thomas Preudhomme wrote: Hi, Name of arm_compute_save_reg_mask and thumb1_compute_save_reg_mask suggest that all register saving computation is done in these function but these only deal with core registers. The caller arm_compute_frame_layout ()

Re: [patch, libfortran] Fix matmul result zeroing for empty arguments

Am 05.06.2017 um 11:52 schrieb Thomas Koenig: OK for trunk? ... and 7.1, where this bug was actually discovered? This is a regerssion. Regards Thomas

Re: [PATCH] gcc::context creation

On 06/05/2017 05:46 AM, Jakub Jelinek wrote: Here is a patch to implement that. I chose to keep the 3 dumps predefined dumps and just tweak their registered number, otherwise the changes would be bigger. Yeah, that can wait for another day. The patch additionally renames TDI_generic to

Re: [PATCH] gcc::context creation

On Wed, May 24, 2017 at 08:00:30AM -0400, Nathan Sidwell wrote: > On 05/24/2017 07:57 AM, Jakub Jelinek wrote: > > > The numbering is not to differentiate between dumps of the same name, that > > is done through numbered suffixes of the dump names, but to make the order > > of passes visible to

[patch, libfortran] Fix matmul result zeroing for empty arguments

Hello world, the attached patch moves the zeroing of the result variable before the early return. This is done so that the result for zero-sized arguments is still valid. The bug was only in the library version, but I have also added a test case for the inline version to make sure the bug does

RE: [PATCH][x86][PR73350][PR80862]

Hi, 1 is replace 8 spaces with tab suggested by ./check_GNU_style.sh, should I still fix it back? 2,3,4 Done CSE is working, spec 2k6 on skylake-avx512 has same score. PR target/73350,80862 gcc/ * config/i386/subst.md (round): Fix round pattern. * config/i386/i386.c

Re: [C++ PATCH] lang_decl selector & decomposition

On Wed, May 31, 2017 at 01:16:36PM -0400, Nathan Sidwell wrote: > On 05/31/2017 01:05 PM, Jakub Jelinek wrote: > > > That is weird, that sounds like a bug somewhere? Which testcase is it on? > > I think decomp25 & decomp7 & 8 (sorry, can't recall full name). > I discovered them because my first

Re: [C++ PATCH] lang_decl selector & decomposition

On 06/05/2017 06:28 AM, Jakub Jelinek wrote: So unless cxx_dup_lang_specific_decl or copy_decl or tsubst_decl clears the DECL_DECOMP_BASE for the short time before cp_finish_decomp is called, DECL_DECOMP_BASE will be "wrong" for a short time, but it shouldn't matter, nothing should be querying

Re: Containers default initialization

On 04/06/17 22:26 +0200, François Dumont wrote: Hi I have eventually adapt the test to all containers and the result is successful for map/set/unordered_map/unordered_set. It is failing for deque/list/forward_list/vector/vector. I even try to change the test to look at the difference

Re: [PATCH] Optimize std::advance for single increments

On 05/06/17 12:47 +0200, Marc Glisse wrote: On Mon, 5 Jun 2017, Jonathan Wakely wrote: LWG 2931 suggests a new overload of std::next for the default n==1 case, because it can be simpler for some random access iterators to do ++i than i += 1, e.g. for std::deque::iterator. I've suggested we

Re: [PATCH GCC][4/5]Improve loop distribution to handle hmmer

On Mon, Jun 5, 2017 at 5:21 AM, Kugan Vivekanandarajah wrote: > Hi Bin, > > Thanks for posting the patch. I haven't looked in detail yet but have > couple of quick questions. > > 1. Shouldn’t the run time alias check for versioning happen only when >

Re: [PATCH, GCC/ARM] Rename *_compute_save_reg_mask ()

On 26/05/17 15:19, Thomas Preudhomme wrote: Hi, Name of arm_compute_save_reg_mask and thumb1_compute_save_reg_mask suggest that all register saving computation is done in these function but these only deal with core registers. The caller arm_compute_frame_layout () also computes some of the

[PING^2] for three diagnostic-related patches

Hi again, I'd like to re-ping those patches below before they start to bit-rot ;-) Regards, Volker On 16 May, Volker Reichelt wrote: > Hi, > > I'd like to ping the following diagnostic-related patches that might > have slipped through the cracks: > > C++ parser: Fix typos in error messages: >

[PATCH] Optimize std::advance for single increments

LWG 2931 suggests a new overload of std::next for the default n==1 case, because it can be simpler for some random access iterators to do ++i than i += 1, e.g. for std::deque::iterator. I've suggested we close that issue as NAD, because we don't need a new overload to do that, and here's the

Re: [PATCH] Optimize std::advance for single increments

On Mon, 5 Jun 2017, Jonathan Wakely wrote: LWG 2931 suggests a new overload of std::next for the default n==1 case, because it can be simpler for some random access iterators to do ++i than i += 1, e.g. for std::deque::iterator. I've suggested we close that issue as NAD, because we don't need

Re: add VxWorks specific crtstuff implementation files for Ada runtimes

On 06/02/2017 11:58 AM, Olivier Hainque wrote: Hello, 2017-06-02 Olivier Hainque ada/ * vx_crtbegin_auto.c: New file. * vx_crtbegin.c: New file. * vx_crtbegin.inc: New file. * vx_crtend.c: New file. + * Copyright

[PATCH] remove incorrect assert

Hi, here is a tiny patch which removes an assert which I believe is wrong. I think it is an anomaly as the only callee (determine_max_movement at gcc/tree-ssa-loop-im.c:749) tests the asserted result against NULL. (If the assert really were correct then the else statement is redundant (dead

Re: Reorgnanization of profile count maintenance code, part 1

I'm seeing a build failure for mips64-linux-gnu: In file included from /scratch/jmyers/glibc-bot/src/gcc/gcc/config/mips/frame-header-opt.c:35:0: /scratch/jmyers/glibc-bot/src/gcc/gcc/cfg.h:106:64: error: 'profile_count' has not been declared extern void update_bb_profile_for_threading

Re: Reorgnanization of profile count maintenance code, part 1

Hi, sorry for that. I am testing the obvious change to add #include "profile-count.h" into relevant target files. Honza > I'm seeing a build failure for mips64-linux-gnu: > > In file included from > /scratch/jmyers/glibc-bot/src/gcc/gcc/config/mips/frame-header-opt.c:35:0: >

Re: [PATCH] gcc::context creation

On 06/05/2017 08:50 AM, Jakub Jelinek wrote: It was the intent that there is no unnecessary gap, the difference between those two should be simply the maximum any FE registers. So, on your branch you'd bump it to 4 and on trunk when merging your branch. I can live with that. nathan --

Re: [PATCH] Finish implementing P0426R1 "Constexpr for std::char_traits" for C++17

On 23/04/17 19:33 +0100, Pedro Alves wrote: On 04/23/2017 06:54 PM, Pedro Alves wrote: Hi! As I had suggested in PR c++/80265, here's a patch that uses __builtin_constant_p to tell whether we can defer to a constexpr algorithm, which avoids having to wait for compiler support. Unfortunately I

[Patch, Fortran, OOP] PR 70601: [5/6/7/8 Regression] [OOP] ICE on procedure pointer component call

Hi all, I have just committed the attached one-line patch to trunk as obvious. It fixes an ICE-on-valid regression with procedure-pointer components. I plan to backport it to the release branches soon (if there are no objections) ... Cheers, Janus Index:

Re: [PATCH] Add missing entry for -Wduplicated-branches

On Mon, Jun 05, 2017 at 02:38:11PM +0200, Volker Reichelt wrote: > Hi, > > the warning option -Wduplicated-branches added by Marek in r244705 > https://gcc.gnu.org/viewcvs?rev=244705=gcc=rev > lacks an entry in the warning list of doc/invoke.texi. Oops. > The patch below fixes that. > > OK for

Re: RFC: [PATCH] Add warn_if_not_aligned attribute

The new attribute needs documentation. Should the test be in c-c++-common or does this feature not support C++? -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] C++ parser: Fix typos in error messages

On Tue, 2017-05-02 at 08:05 +0200, Volker Reichelt wrote: > Hi, > > the following patch fixes two typos in error messages of the C++ > parser > (which have gone unnoticed since GCC 3.4.0). > > Bootstrapped and regtested on x86_64-pc-linux-gnu. > OK for trunk? > Should this go also to GCC 7.2? >

Re: Reorgnanization of profile count maintenance code, part 1

Hi, I have committed the following fix. Honza Index: ChangeLog === --- ChangeLog (revision 248878) +++ ChangeLog (working copy) @@ -1,5 +1,10 @@ 2017-06-05 Jan Hubicka + *

Re: [PATCH] add more detail to -Wconversion and -Woverflow (PR 80731)

Hi, newlib-stdint.h defines UINT32_TYPE as "long unsigned int" for ILP32 targets. This leads such target to warn on "long unsigned int" conversation rather than "unsigned int". This patch modifies the dg-warning regexp to allow an option "long " prefix in the warning, thereby working for LP64

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

Maybe I should use a different approach and instead of trying to see if a function is deleted use trivially_xible to see if it's usable. That will mean changing the diagnostics from "with a deleted special function" to "without trivial special function" but it will avoid calling

[PING^2] re [PATCH v2] C++: Add fix-it hints for -Wold-style-cast

Ping re this patch: https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00204.html On Fri, 2017-05-26 at 15:35 -0400, David Malcolm wrote: > On Wed, 2017-05-03 at 09:51 -0400, David Malcolm wrote: > > On Thu, 2017-04-27 at 23:03 +0200, Marek Polacek wrote: > > > On Thu, Apr 27, 2017 at 05:10:24PM

Re: [PATCH] PR libstdc++/80939 Remove unmeetable constexpr specifiers

On 02/06/17 12:19 -0700, Tim Shen wrote: On Fri, Jun 2, 2017 at 6:07 AM, Jonathan Wakely wrote: As the PR points out, we aren't qualifying calls to __ref_cast, and have 'constexpr' on function templates that can never be usable in constant expressions. Apology for the constexpr trolling, but

Re: [PATCH] add more detail to -Wconversion and -Woverflow (PR 80731)

On 06/05/2017 10:05 AM, Thomas Preudhomme wrote: Hi, newlib-stdint.h defines UINT32_TYPE as "long unsigned int" for ILP32 targets. This leads such target to warn on "long unsigned int" conversation rather than "unsigned int". This patch modifies the dg-warning regexp to allow an option "long "

Re: [PING**3] [PATCH] Force use of absolute path names for gcov

On 06/05/17 13:11, Nathan Sidwell wrote: > +Compile the source files additionally with @option{-fprofile-abs-path} > +to create absolute path names in the @file{.gcno} files. This allows > +@command{gcov} to find the correct sources in projects with multiple > +directories. > > I think the

More profile updating fixes

Hi, here are less trivial updates to profile code which I did not bundle into initial transition. Those are not bugs in old code, just new code needs to track more. profile-bootstrapped/regtested x86_64-linux, will commit it shortly. * cfgexpand.c (expand_gimple_tailcall): Initialize

Re: RFC: [PATCH] Add warn_if_not_aligned attribute

On Mon, Jun 5, 2017 at 8:11 AM, Joseph Myers wrote: > The new attribute needs documentation. Should the test be in c-c++-common This feature does support C++. But C++ compiler issues a slightly different warning at a different location. > or does this feature not

Re: Reorgnanization of profile count maintenance code, part 1

On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka wrote: > Index: profile.c > === > --- profile.c (revision 248684) > +++ profile.c (working copy) > @@ -67,6 +67,10 @@ along with GCC; see the file COPYING3. > >

Re: [PATCH] Add missing entry for -Wduplicated-branches

On 5 Jun, Marek Polacek wrote: > On Mon, Jun 05, 2017 at 02:38:11PM +0200, Volker Reichelt wrote: >> Hi, >> >> the warning option -Wduplicated-branches added by Marek in r244705 >> https://gcc.gnu.org/viewcvs?rev=244705=gcc=rev >> lacks an entry in the warning list of doc/invoke.texi. > > Oops.

[PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170)

PR 62170 describes a problem with how the quoting in pp_format interacts with the "aka" information for typedefs in %qT for the C family of frontends, and also now for %qH and %qI in the C++ frontend. Currently for %qT we print e.g.: ‘Py_ssize_t* {aka int*}’ ^^ colorized

Re: Reorgnanization of profile count maintenance code, part 1

On Mon, Jun 5, 2017 at 8:37 AM, Jan Hubicka wrote: > Hi, > I have committed the following fix. I seeing the following error while building aarch64-elf: /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/shrink-wrap.c: In function

Re: Reorgnanization of profile count maintenance code, part 1

> I seeing the following error while building aarch64-elf: Same thing on darwin!-( TIA Dominique

[PATCH 1/1] Remove redundant definition of srcrootpre

This script has the only occurrence of it, and in this line it defines and exports it. --- config-ml.in | 1 - 1 file changed, 1 deletion(-) diff --git a/config-ml.in b/config-ml.in index 47f153350..58c80a35c 100644 --- a/config-ml.in +++ b/config-ml.in @@ -493,7 +493,6 @@ multi-do:

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

On 06/04/2017 10:01 PM, Jason Merrill wrote: On 06/02/2017 05:28 PM, Martin Sebor wrote: On 05/31/2017 05:34 PM, Jason Merrill wrote: On 05/27/2017 06:44 PM, Martin Sebor wrote: + /* True if the class is trivial and has a trivial non-deleted copy + assignment, copy ctor, and default

[PATCH, GCC/THUMB1] New define_insn_and_split pattern to optimize out unnecessary uxtb instructions

GCC currently generates unnecessary uxtb instructions when compiling gcc.target/arm/unsigned-extend-1.c for Thumb1 targets such as the Cortex-M0. This test case is as follows: unsigned char foo (unsigned char c) { return (c >= '0') && (c <= '9'); } The assembly output generated with

Re: [PING**3] [PATCH] Force use of absolute path names for gcov

On 06/05/2017 12:31 PM, Bernd Edlinger wrote: So how about this new patch? Is it OK for trunk? Yes thanks. nathan -- Nathan Sidwell

Re: {PATCH] New C++ warning -Wcatch-value

On Mon, Jun 5, 2017 at 6:55 AM, Volker Reichelt wrote: > On 15 May, Martin Sebor wrote: >>> So how about the following then? I stayed with the catch part and added >>> a parameter to the warning to let the user decide on the warnings she/he >>> wants to get:

Re: More profile updating fixes

Hi, On 5 June 2017 at 19:36, Jan Hubicka wrote: > Hi, > here are less trivial updates to profile code which I did not bundle into > initial transition. Those are not bugs in old code, just new code needs > to track more. > > profile-bootstrapped/regtested x86_64-linux, will

Re: [patch, libfortran] Fix matmul result zeroing for empty arguments

On 06/05/2017 02:52 AM, Thomas Koenig wrote: > Hello world, > > the attached patch moves the zeroing of the result variable before the > early return. This is done so that the result for zero-sized arguments > is still valid. > > The bug was only in the library version, but I have also added a

[committed] libcpp: add callback for comment-handling

On Fri, 2017-05-12 at 12:47 -0600, Jeff Law wrote: > On 05/02/2017 01:08 PM, David Malcolm wrote: > > Currently the C/C++ frontends discard comments when parsing. > > It's possible to set up libcpp to capture comments as tokens, > > by setting CPP_OPTION (pfile, discard_comments) to false), > >

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

On 06/05/2017 10:07 AM, Martin Sebor wrote: Maybe I should use a different approach and instead of trying to see if a function is deleted use trivially_xible to see if it's usable. That will mean changing the diagnostics from "with a deleted special function" to "without trivial special

Re: [PATCH][SPARC] PR target/80968 Prevent stack loads in return delay slot.

> That seems to work as well, following is going through a testsuite > run right now: > > > [PATCH] sparc: Fix stack references in return delay slot. > > gcc/ > > PR target/80968 > * config/sparc/sparc.c (sparc_expand_prologue): Emit frame > blockage if

Re: Reorgnanization of profile count maintenance code, part 1

> > I seeing the following error while building aarch64-elf: > > Same thing on darwin!-( Ooops, I managed to accidentally change my bootstrap tree. I have reverted that change now. Honza > > TIA > > Dominique

Re: [Patch, fortran] PR35339 Optimize implied do loops in io statements

With all the style fixes committed as r248877. Thanks for the review. Nicolas On 06/03/2017 06:25 PM, Jerry DeLisle wrote: On 06/03/2017 06:48 AM, Nicolas Koenig wrote: Hello everyone, here is a version of the patch that includes a workaround for PR 80960. I have also included a separate

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

Jan Hubicka recently changed the calling sequence to init_lowered_empty_function, and my patch doesn't build any more. I cloned the changes made in the x86_64 port and committed the following change (subversion id 248902) so that the rs6000 build should build once again.

Re: [PATCH] warn on mem calls modifying objects of non-trivial types (PR 80560)

On 06/05/2017 01:13 PM, Martin Sebor wrote: On 06/05/2017 10:07 AM, Martin Sebor wrote: Maybe I should use a different approach and instead of trying to see if a function is deleted use trivially_xible to see if it's usable. That will mean changing the diagnostics from "with a deleted special

Re: [PATCH][SPARC] PR target/80968 Prevent stack loads in return delay slot.

From: Eric Botcazou Date: Tue, 06 Jun 2017 00:02:06 +0200 >> That seems to work as well, following is going through a testsuite >> run right now: >> >> >> [PATCH] sparc: Fix stack references in return delay slot. >> >> gcc/ >> >> PR

Fix PR rtl-optimization/80474

This is a regression present on the 6 branch for MIPS (and latent on the 7 branch and mainline). The reorg pass generates wrong code for the attached testcase with a combination of options under the form of a double lo_sum(sym) instruction for a single hi(sum). The pass starts from a

[PING #3] [PATCH] handle enumerated types in -Wformat-overflow (PR 80397)

Jeff, I suspect you're still busy but I'm Looking for approval to commit the nearly trivial patch below: https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00547.html Martin On 05/22/2017 08:19 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00547.html On