[PATCH, rs6000] testcase coverage for vec_cntlz

2017-08-08 Thread Will Schmidt
Hi, [PATCH, rs6000] testcase coverage for vec_cntlz Add testcase coverage for vec_cntlz built-in functions. Tested across power platforms (p6 and newer). OK for trunk? Thanks, -Will [gcc/testsuite] 2017-08-08 Will Schmidt *

[PATCH, rs6000] testcase coverage for vec_madd built-in functions

2017-08-08 Thread Will Schmidt
Hi, [Patch, rs6000] testcase coverage for vec_madd built-in function Add testcase coverage for vec_madd built-in function. Tested across power platforms (p6 and newer). OK for trunk? Thanks, -Will [testsuite] 2017-08-08 Will Schmidt

[PATCH, rs6000] testcase coverage for vec_pack builtin

2017-08-08 Thread Will Schmidt
Hi, [PATCH, rs6000] testcase coverage for vec_pack builtin Add some testcase coverage for the vec_pack built-in. Tested across power platforms (p6 and newer). OK for trunk? Thanks, -Will [gcc/testsuite] |---2017-08-08 Will Schmidt

Re: [PATCH, rs6000] testcase coverage for vec_madd built-in functions

2017-08-08 Thread Segher Boessenkool
Hi! On Tue, Aug 08, 2017 at 04:20:14PM -0500, Will Schmidt wrote: > * fold-vec-madd-double.c: New. > * fold-vec-madd-float.c: New. > * fold-vec-madd-short.c: New. Same as before, it needs the path in here (the path is relative to the directory the changelog is in). The actual

Re: [PATCH, rs6000] testcase coverage for vec_pack builtin

2017-08-08 Thread Segher Boessenkool
On Tue, Aug 08, 2017 at 04:24:26PM -0500, Will Schmidt wrote: > * fold-vec-pack-double.c: New. > * fold-vec-pack-int.c: New. > * fold-vec-pack-longlong.c: New. > * fold-vec-pack-short.c: New. Okay for trunk (with the changelog fixed). Thanks, Segher

Re: C PATCH to display types when printing a conversion warning (PR c/81233)

2017-08-08 Thread Joseph Myers
On Thu, 13 Jul 2017, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-linux and powerpc64le-unknown-linux-gnu, > ok for trunk? OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH, rs6000] testcase coverage for vec_cntlz

2017-08-08 Thread Segher Boessenkool
Hi Will, > * fold-vec-cntlz-int.c: New. * gcc.target/powerpc/fold-vec-cntlz-int.c: New. Okay for trunk with the changelog fixed like that. Thanks, Segher

Re: [PATCH, rs6000] enable early debug and disable switch for gimple folding

2017-08-08 Thread Segher Boessenkool
Hi! On Tue, Aug 08, 2017 at 04:14:56PM -0500, Will Schmidt wrote: > * config/rs6000/rs6000.c: rs6000_option_override_internal() Add blurb > to indicate when early gimple folding has been disabled. * config/rs6000/rs6000.c (rs6000_option_override_internal): ... >

Re: [PATCH, rs6000] Add testcase coverage for vec_msum built-in

2017-08-08 Thread Segher Boessenkool
Hi, On Tue, Aug 08, 2017 at 04:22:40PM -0500, Will Schmidt wrote: > * fold-vec-msum-char.c: New. > * fold-vec-msum-short.c: New. Okay for trunk with the paths in the changelog fixed. Thanks! Segher

[PATCH, rs6000] enable early debug and disable switch for gimple folding

2017-08-08 Thread Will Schmidt
Hi, [PATCH, rs6000] enable early debug and disable switch for gimple folding Enable debug options related to gimple folding for the rs6000 target. Adds some output to the existing -mdebug=builtin option Add a -mgimple-folding=off option to disable the early rs6000 gimple folding. OK for

[PATCH, rs6000] Add testcase coverage for vec_msum built-in

2017-08-08 Thread Will Schmidt
Hi, [PATCH, rs6000] Add testcase coverage for vec_msum built-in Add testcase coverage for vec_msum built-in. Tested across power platforms (p6 and newer). OK for trunk? Thanks, -Will [gcc/testsuite] 2017-08-08 Will Schmidt *

Re: PING^2: [PATCH] PR driver/81523: Make -static override -pie

2017-08-08 Thread Joseph Myers
On Mon, 7 Aug 2017, H.J. Lu wrote: > Hi Joseph, > > Can you take a look at this patch: > > https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00011.html This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: C PATCH to further improve diagnostic for -Wsign-compare (PR c/81417)

2017-08-08 Thread Joseph Myers
On Wed, 2 Aug 2017, Marek Polacek wrote: > Hmm, how about this, then? > > "operand of ?: changes signedness from %qT to %qT due to unsignedness of > other operand" > > I couldn't come up with anything more brief yet conveying all the information. > I don't like adding "second"/"third"/... very

[PATCH] Add -static-pie to GCC driver to create static PIE

2017-08-08 Thread H.J. Lu
This patch adds -static-pie to GCC driver to create static PIE. A static position independent executable (PIE) is similar to static executable, but can be loaded at any address without a dynamic linker. All linker input files must be compiled with -fpie or -fPIE and linker must support

Re: [committed, nvptx] Add nvptx_override_options_after_change

2017-08-08 Thread Thomas Schwinge
Hi Tom! On Fri, 21 Jul 2017 11:49:11 +0200, Tom de Vries wrote: > this patch adds nvptx_override_options_after_change, containing a > workaround for PR81430. > --- a/gcc/config/nvptx/nvptx.c > +++ b/gcc/config/nvptx/nvptx.c > @@ -207,6 +207,17 @@ nvptx_option_override

Re: [RFC][PATCH] Do refactoring of attribute functions and move them to attribs.[hc].

2017-08-08 Thread Tom de Vries
On 08/08/2017 06:36 AM, Martin Liška wrote: Hello. I'm sending final version that I'm going to install. Compared to the previous version I tested all targets in contrib/config-list.mk. I ran into a build breaker for an nvptx offloading compiler (where the ACCEL_COMPILER-guarded code is

Re: [committed, nvptx] Add nvptx_override_options_after_change

2017-08-08 Thread Tom de Vries
On 08/08/2017 10:45 AM, Thomas Schwinge wrote: Hi Tom! On Fri, 21 Jul 2017 11:49:11 +0200, Tom de Vries wrote: this patch adds nvptx_override_options_after_change, containing a workaround for PR81430. --- a/gcc/config/nvptx/nvptx.c +++ b/gcc/config/nvptx/nvptx.c @@

Re: [PATCH] Forbid section anchors for ASan build (PR sanitizer/81697)

2017-08-08 Thread Vyacheslav Barinov
Hello, Andrew Pinski writes: > On Mon, Aug 7, 2017 at 11:15 PM, Slava Barinov wrote: >>gcc/ >>* varasm.c (use_object_blocks_p): Forbid section anchors for ASan >> >>gcc/testsuite/ >>* g++.dg/asan/global-alignment.cc: New

[PATCH] Switch on *.cc tests for g++ ASan

2017-08-08 Thread Slava Barinov
* g++.dg/asan/asan.exp: Switch on *.cc tests. Signed-off-by: Slava Barinov --- gcc/testsuite/ChangeLog| 4 gcc/testsuite/g++.dg/asan/asan.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/ChangeLog

[PATCH] Forbid section anchors for ASan build (PR sanitizer/81697)

2017-08-08 Thread Slava Barinov
gcc/ * varasm.c (use_object_blocks_p): Forbid section anchors for ASan gcc/testsuite/ * g++.dg/asan/global-alignment.cc: New test to test global variables alignment. Signed-off-by: Slava Barinov --- gcc/ChangeLog

Re: [PATCH] Forbid section anchors for ASan build (PR sanitizer/81697)

2017-08-08 Thread Andrew Pinski
On Mon, Aug 7, 2017 at 11:15 PM, Slava Barinov wrote: >gcc/ >* varasm.c (use_object_blocks_p): Forbid section anchors for ASan > >gcc/testsuite/ >* g++.dg/asan/global-alignment.cc: New test to test global >variables alignment. Can

RE: [PATCH][Arm] Test suite failures resulting from deprecation of -mstructure-size-boundary

2017-08-08 Thread Michael Collison
Because the comment (for example) in g+=.dg/ext/packed8.C says // NOTE: This test assumes packed structure layout differs from unpacked // structure layout. This isn't true, e.g., with the default // arm-none-elf options. If we could just delete the -mstructure-size-boundary=8

Re: [PATCH] Add -static-pie to GCC driver to create static PIE

2017-08-08 Thread Richard Biener
On August 9, 2017 12:18:41 AM GMT+02:00, "H.J. Lu" wrote: >This patch adds -static-pie to GCC driver to create static PIE. A >static >position independent executable (PIE) is similar to static executable, >but can be loaded at any address without a dynamic linker. All

Re: [PATCH] ICF: properly handle LABEL_DECLs (PR tree-opt/81696).

2017-08-08 Thread Martin Liška
On 08/08/2017 01:17 PM, Richard Biener wrote: > On Tue, Aug 8, 2017 at 1:11 PM, Martin Liška wrote: >> Hello. >> >> As LABEL_DECL can point to another function (non-local goto), we must >> properly >> compare them. >> >> Patch can bootstrap on ppc64le-redhat-linux and survives

[PATCH][RFC] Patch candidate for other/39851

2017-08-08 Thread Martin Liška
Hi. As mentioned in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39851#c0 we need to call targetm.target_option.override () in order to properly report which ISA options are enabled for a -march/-mtune. Currently, opts.c uses just #include "common/common-target.h" we are unable to call the

[PATCH] Fix PR81719

2017-08-08 Thread Richard Biener
The following improves niter analysis for range-based for loops by handling ADDR_EXPR in expand_simple_operations. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2017-08-08 Richard Biener PR middle-end/81719 *

Re: [PATCH] Fix PR81719

2017-08-08 Thread Bin.Cheng
On Tue, Aug 8, 2017 at 1:20 PM, Richard Biener wrote: > > The following improves niter analysis for range-based for loops > by handling ADDR_EXPR in expand_simple_operations. > > Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. > > Richard. > > 2017-08-08 Richard

Re: [PATCH] Fix PR81719

2017-08-08 Thread Richard Biener
On Tue, 8 Aug 2017, Bin.Cheng wrote: > On Tue, Aug 8, 2017 at 1:20 PM, Richard Biener wrote: > > > > The following improves niter analysis for range-based for loops > > by handling ADDR_EXPR in expand_simple_operations. > > > > Bootstrapped on x86_64-unknown-linux-gnu, testing

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Richard Kenner
> The pattern will only be matched if the value is positive. More > specifically if the constant value is 32 (SImode) or 64 (DImode). I don't mean the constant, but the value subtracted from it. If that's negative, then we have a shift count larger than the wordsize.

[PATCH] Fix PR81723

2017-08-08 Thread Richard Biener
I am testing the following patch to reduce SLP vectorization SLP build time which can be exponential in some cases due to us now aggressively allowing build-from-scalars as fallback. The patch fixes this by avoiding repeated (failing and thus not accounted with max_tree_size) SLP builds on the

Re: [PING #2] [PATCH] enhance -Wrestrict to handle string built-ins (PR 78918)

2017-08-08 Thread Richard Biener
On Mon, Aug 7, 2017 at 1:08 AM, Martin Sebor wrote: > On 08/03/2017 02:45 AM, Richard Biener wrote: >> >> On Wed, Aug 2, 2017 at 7:10 PM, Jeff Law wrote: >>> >>> On 08/01/2017 03:25 AM, Richard Biener wrote: On Tue, Aug 1, 2017 at 11:23 AM, Richard

Re: [PATCH, rs6000] Clean up capitalized diagnostic messages

2017-08-08 Thread Bill Schmidt
Fixed with r250952. Bill > On Aug 6, 2017, at 3:08 AM, Andreas Schwab wrote: > > FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c (test for errors, line > 18) > FAIL: gcc.target/powerpc/bfp/scalar-extract-exp-2.c (test for excess errors) > FAIL:

[PATCH] ICF: properly handle LABEL_DECLs (PR tree-opt/81696).

2017-08-08 Thread Martin Liška
Hello. As LABEL_DECL can point to another function (non-local goto), we must properly compare them. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed ? Martin gcc/ChangeLog: 2017-08-08 Martin Liska PR tree-opt/81696

Re: [PATCH] ICF: properly handle LABEL_DECLs (PR tree-opt/81696).

2017-08-08 Thread Richard Biener
On Tue, Aug 8, 2017 at 1:11 PM, Martin Liška wrote: > Hello. > > As LABEL_DECL can point to another function (non-local goto), we must properly > compare them. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready to be installed ? Ok. So with

Re: [PATCH GCC][5/5]Enable tree loop distribution at -O3 and above optimization levels.

2017-08-08 Thread Richard Biener
On Mon, Aug 7, 2017 at 11:10 AM, Bin.Cheng wrote: > On Fri, Jun 23, 2017 at 12:04 PM, Richard Biener > wrote: >> On Fri, Jun 23, 2017 at 10:47 AM, Bin.Cheng wrote: >>> On Fri, Jun 23, 2017 at 6:04 AM, Jeff Law

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread H.J. Lu
On Tue, Aug 8, 2017 at 11:00 AM, Richard Biener wrote: > On August 8, 2017 7:36:35 PM GMT+02:00, Richard Sandiford > wrote: >>Richard Sandiford writes: >>> Richard Biener

Re: [PATCH 1/2] simplify-rtx: The truncation of an IOR can have all bits set (PR81423)

2017-08-08 Thread Jeff Law
On 08/07/2017 04:33 PM, Segher Boessenkool wrote: > On Tue, Jul 25, 2017 at 06:25:49AM -0500, Segher Boessenkool wrote: >> On Mon, Jul 24, 2017 at 04:06:39PM -0600, Jeff Law wrote: 2017-07-24 Segher Boessenkool gcc/testsuite/ PR

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread H.J. Lu
On Mon, Aug 7, 2017 at 1:05 PM, Richard Sandiford wrote: > Arjan van de Ven writes: >> On 8/7/2017 8:43 AM, Jakub Jelinek wrote: >>> On Mon, Aug 07, 2017 at 08:39:24AM -0700, H.J. Lu wrote: When Linux/x86-64 kernel is compiled with

Re: [PATCH 0/5] RFC, WIP: RTL cost improvements

2017-08-08 Thread Jeff Law
On 08/05/2017 11:15 AM, Segher Boessenkool wrote: > On Sat, Aug 05, 2017 at 11:07:20AM +0100, Richard Sandiford wrote: >> Segher Boessenkool writes: >>> This series creates pattern_cost and insn_cost functions that together >>> replace the existing insn_rtx_cost

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread Uros Bizjak
On Tue, Aug 8, 2017 at 6:38 PM, H.J. Lu wrote: > When Linux/x86-64 kernel is compiled with -fno-omit-frame-pointer. > this optimization removes more than 730 > > pushq %rbp > movq %rsp, %rbp > popq %rbp If you don't want the frame pointer,

Re: [PATCH 00/22] RFC: integrated 3rd-party static analysis support

2017-08-08 Thread Richard Sandiford
David Malcolm writes: > This patch kit clearly isn't ready yet as-is (see e.g. the > "known unknowns" below), but I'm posting it now in the hope of > getting early feedback. Looks really useful. One thing I wasn't sure of from a quick scan was: what would happen if the

Re: [PATCH] Fix OpenMP/OpenACC/Cilk+ issues with forced/non-local labels (PR c/81687)

2017-08-08 Thread Richard Biener
On Fri, 4 Aug 2017, Jakub Jelinek wrote: > Hi! > > If there are forced or non-local labels in OpenMP parallel/task/target > regions (or OpenACC or Cilk+), then we often fail to link as the following > testcases show - the labels aren't emitted anywhere, just references to > them. > > While it

Re: [PATCH] Convert character arrays to string csts

2017-08-08 Thread Martin Liška
On 11/09/2016 11:22 AM, Richard Biener wrote: > On Fri, Nov 4, 2016 at 2:33 PM, Martin Liška wrote: >> On 11/03/2016 02:00 PM, Jan Hubicka wrote: On 11/03/2016 01:12 PM, Martin Liška wrote: > + tree init = DECL_INITIAL (decl); > + if (init > + &&

Re: [PATCH] Fix PR81354 (SLSR, insert on edges)

2017-08-08 Thread Richard Biener
On Mon, Aug 7, 2017 at 8:51 PM, Bill Schmidt wrote: > Hi, > > PR81354 describes an ICE in SLSR that occurs when a GIMPLE PHI statement > changes > address during the SLSR pass. SLSR contains a mapping table from GIMPLE > statements > to entries in the candidate

[PATCH] Fix PR81766

2017-08-08 Thread Richard Biener
The following patch is a partial reversal of r250815 (on the branch) which restores behavior of always calling find_many_sub_basic_blocks on prologue inserted code. Doing that probably masks an issue with either scheduling or the way x86 sets up the PIC register. The patch allows grub2 to

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Wilco Dijkstra
Richard Kenner wrote: >Michael Collison wrote: > > On Aarc64 SHIFT_COUNT_TRUNCATED is only true if SIMD code generation > > is disabled. This is because the simd instructions can be used for > > shifting but they do not truncate the shift count. > > In that case, the change isn't safe! Consider

Re: [PATCH PR81744]Fix ICE by deep copying expression of loop's number of iterations

2017-08-08 Thread Richard Biener
On Tue, Aug 8, 2017 at 12:35 PM, Bin Cheng wrote: > Hi, > This is an obvious patch. It fixes ICE in PR81744 by deep copying expression > of loop's number of iterations. > Test result checked. Is it OK? Ok. Thanks, Richard. > Thanks, > bin > 2017-08-07 Bin Cheng

RE: [GCC][PATCH][mid-end][Version 3] Optimize x * copysign (1.0, y) [Patch (1/2)]

2017-08-08 Thread Richard Biener
On Mon, 7 Aug 2017, Tamar Christina wrote: > Hi Richard, > > > switch (code) > > { > > case MULT_EXPR: > > if (!convert_mult_to_widen (stmt, ) > > && !convert_expand_mult_copysign (stmt, ) > >

[PATCH PR81744]Fix ICE by deep copying expression of loop's number of iterations

2017-08-08 Thread Bin Cheng
Hi, This is an obvious patch. It fixes ICE in PR81744 by deep copying expression of loop's number of iterations. Test result checked. Is it OK? Thanks, bin 2017-08-07 Bin Cheng PR tree-optimization/81744 * tree-predcom.c (prepare_finalizers_chain): Deep

Re: C PATCH to further improve diagnostic for -Wsign-compare (PR c/81417)

2017-08-08 Thread Marek Polacek
Ping. The make_location change should allow us to do really cool things, if we pass c_exprs to build_binary_loc, btw. Like all the ranges for diagnostic and similar. On Wed, Aug 02, 2017 at 02:43:39PM +0200, Marek Polacek wrote: > On Tue, Aug 01, 2017 at 04:48:01PM -0400, David Malcolm wrote: >

Re: C PATCH to display types when printing a conversion warning (PR c/81233)

2017-08-08 Thread Marek Polacek
Ping. On Mon, Jul 31, 2017 at 01:27:01PM +0200, Marek Polacek wrote: > Ping. > > On Thu, Jul 20, 2017 at 12:53:10PM +0200, Marek Polacek wrote: > > On Wed, Jul 19, 2017 at 10:51:33AM -0400, David Malcolm wrote: > > > The changes to diagnostic-core.h and diagnostic.c are OK. > > > > Thanks. > >

Re: [PATCH] Convert character arrays to string csts

2017-08-08 Thread Richard Biener
On Tue, Aug 8, 2017 at 1:47 PM, Martin Liška wrote: > On 11/09/2016 11:22 AM, Richard Biener wrote: >> On Fri, Nov 4, 2016 at 2:33 PM, Martin Liška wrote: >>> On 11/03/2016 02:00 PM, Jan Hubicka wrote: > On 11/03/2016 01:12 PM, Martin Liška wrote: >> +

[PATCH, i386]: Make stack canary location customizable (PR target/81708)

2017-08-08 Thread Uros Bizjak
Hello! Attached patch introduces -mstack-protector-guard-reg= and -mstack-protector-guard-offset= options to make stack canary location customizable. These are the same options powerpc has. 2017-08-08 Uros Bizjak PR target/81708 * config/i386/i386.opt

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread Richard Sandiford
Richard Sandiford writes: > Richard Biener writes: >> On August 8, 2017 6:38:30 PM GMT+02:00, "H.J. Lu" >> wrote: >>>On Mon, Aug 7, 2017 at 1:05 PM, Richard Sandiford >>> wrote:

Re: [PATCH][v2] Fix target attribute handling (PR c++/81355).

2017-08-08 Thread Jason Merrill
On Tue, Aug 8, 2017 at 12:59 AM, Martin Liška wrote: > On 08/02/2017 09:56 PM, Martin Sebor wrote: >> On 08/02/2017 01:04 PM, Jeff Law wrote: >>> On 07/28/2017 05:13 AM, Martin Liška wrote: Hello. Following patch skips empty strings in 'target' attribute. Patch

Re: [PATCH] Fix middle-end/81737

2017-08-08 Thread Marek Polacek
On Mon, Aug 07, 2017 at 04:07:49PM +0200, Richard Biener wrote: > On August 7, 2017 11:09:59 AM GMT+02:00, Marek Polacek > wrote: > >On Mon, Aug 07, 2017 at 10:58:09AM +0200, Jakub Jelinek wrote: > >> On Mon, Aug 07, 2017 at 10:47:51AM +0200, Marek Polacek wrote: > >> > In my

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread Richard Sandiford
Richard Biener writes: > On August 8, 2017 6:38:30 PM GMT+02:00, "H.J. Lu" wrote: >>On Mon, Aug 7, 2017 at 1:05 PM, Richard Sandiford >> wrote: >>> Arjan van de Ven writes: On 8/7/2017

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread Richard Biener
On August 8, 2017 7:36:35 PM GMT+02:00, Richard Sandiford wrote: >Richard Sandiford writes: >> Richard Biener writes: >>> On August 8, 2017 6:38:30 PM GMT+02:00, "H.J. Lu" > wrote:

Re: [PATCH][v2] Fix target attribute handling (PR c++/81355).

2017-08-08 Thread Martin Sebor
On 08/07/2017 10:59 PM, Martin Liška wrote: On 08/02/2017 09:56 PM, Martin Sebor wrote: On 08/02/2017 01:04 PM, Jeff Law wrote: On 07/28/2017 05:13 AM, Martin Liška wrote: Hello. Following patch skips empty strings in 'target' attribute. Patch can bootstrap on ppc64le-redhat-linux and

Re: [PATCH 0/5] RFC, WIP: RTL cost improvements

2017-08-08 Thread Richard Sandiford
Jeff Law writes: > On 08/05/2017 11:15 AM, Segher Boessenkool wrote: >> On Sat, Aug 05, 2017 at 11:07:20AM +0100, Richard Sandiford wrote: >>> Segher Boessenkool writes: This series creates pattern_cost and insn_cost functions that together

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-08 Thread Richard Biener
On August 8, 2017 6:38:30 PM GMT+02:00, "H.J. Lu" wrote: >On Mon, Aug 7, 2017 at 1:05 PM, Richard Sandiford > wrote: >> Arjan van de Ven writes: >>> On 8/7/2017 8:43 AM, Jakub Jelinek wrote: On Mon, Aug 07, 2017 at

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Michael Collison
This case is covered by Wilco's previous reply: https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00575.html -Original Message- From: Richard Kenner [mailto:ken...@vlsi1.ultra.nyu.edu] Sent: Tuesday, August 8, 2017 5:13 AM To: Michael Collison Cc:

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Richard Kenner
> This case is covered by Wilco's previous reply: > > https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00575.html Which I don't understand: > No it's perfectly safe - it becomes an integer-only shift after the > split since it keeps the masking as part of the pattern. Let say we have your first

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Richard Kenner
> Because for integer shift instructions the shift count is > truncated. We ensure that we only use integer shift instructions by > emitting a shift with a mask. This only matches integer shift > instructions in the md file. That's why I asked about SHIFT_COUNT_TRUNCATED. So it's truncated for

[PATCH 6/6 v2] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available

2017-08-08 Thread Daniel Santos
This update adds documentation for the new effective taregts in addition to a few existing effective targets that were undocumented. Changes to lib/target-supports.exp and documentation: * Add effective-targets avx512f and avx512f_runtime (needed for new tests). * Corrects bug in

PING Re: [PATCH 0/6] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f

2017-08-08 Thread Daniel Santos
Original message: https://gcc.gnu.org/ml/gcc-patches/2017-07/msg02005.html Patches 2 and 3 have been committed and I have corrected the error in patch 5. I configuring with --enable-checking=yes,rtl --enable-languages=all and retested with RUNTESTFLAGS="--target_board=unix/\{,-m32\}" The

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Michael Collison
Because for integer shift instructions the shift count is truncated. We ensure that we only use integer shift instructions by emitting a shift with a mask. This only matches integer shift instructions in the md file. -Original Message- From: Richard Kenner

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Michael Collison
Correct. It is truncated for integer shift, but not simd shift instructions. We generate a pattern in the split that only generates the integer shift instructions. -Original Message- From: Richard Kenner [mailto:ken...@vlsi1.ultra.nyu.edu] Sent: Tuesday, August 8, 2017 1:04 PM To:

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Richard Kenner
> Correct. It is truncated for integer shift, but not simd shift > instructions. We generate a pattern in the split that only generates > the integer shift instructions. That's unfortunate, because it would be nice to do this in simplify_rtx, since it's machine-independent, but that has to be

[PATCH] matching tokens: C++ parts (v3)

2017-08-08 Thread David Malcolm
On Mon, 2017-08-07 at 14:25 -0400, Jason Merrill wrote: Thanks for looking at this. > On 08/01/2017 04:21 PM, David Malcolm wrote: > > @@ -27632,6 +27769,9 @@ cp_parser_sizeof_operand (cp_parser* > > parser, enum rid keyword) > > { > >tree type = NULL_TREE; > > > > +

RE: [PATCH] [Aarch64] Optimize subtract in shift counts

2017-08-08 Thread Michael Collison
Correct. -Original Message- From: Richard Kenner [mailto:ken...@vlsi1.ultra.nyu.edu] Sent: Tuesday, August 8, 2017 1:20 PM To: Michael Collison Cc: gcc-patches@gcc.gnu.org; nd ; pins...@gmail.com Subject: RE: [PATCH] [Aarch64] Optimize subtract in

Re: [PATCH 2/3] Matching tokens: C parts (v2)

2017-08-08 Thread David Malcolm
On Fri, 2017-08-04 at 12:09 -0600, Jeff Law wrote: > On 08/04/2017 08:32 AM, David Malcolm wrote: > > On Thu, 2017-08-03 at 11:34 -0600, Jeff Law wrote: > > > On 08/01/2017 02:21 PM, David Malcolm wrote: > > > > Changed in v2: > > > > > > > > * Renamed template argument to traits_t; eliminated

[PATCH] Changes for v3 of the C++ patch

2017-08-08 Thread David Malcolm
For reference, here's the diff of the v3 C++ patch to the v2 patch, in case it's useful: gcc/cp/ChangeLog: * parser.c (token_pair::require_open): Use tabs rather than spaces. (token_pair::peek_open): Delete. (token_pair::require_close): Use tabs rather than spaces.

[PATCH GCC][OBVIOUS]Handle boundary case for last iv candidate

2017-08-08 Thread Bin Cheng
Hi, When investigate issues, I ran into this obvious issue that the last candidate is not related to compare type iv_use. This patch fixes it. Will apply later. Thanks, bin 2017-08-08 Bin Cheng * tree-ssa-loop-ivopts.c (relate_compare_use_with_all_cands): Handle

[PATCH 1/3] improve detection of attribute conflicts (PR 81544)

2017-08-08 Thread Martin Sebor
Part 1 of the patch series is the core of the enhancement without the (trivial) changes to the back ends and front ends other than C and C++. Marek, I tried to follow what we discussed in IRC. Please let me know if I missed something. Joseph, I read your comments on Marek's patch for the same

[PATCH 2/3] improve detection of attribute conflicts (PR 81544)

2017-08-08 Thread Martin Sebor
Part 2 of the series contains the mechanical changes to all the back ends and to front ends other than C and C++. There are no functional changes here. Martin PR c/81544 - attribute noreturn and warn_unused_result on the same function accepted gcc/ChangeLog: PR c/81544 *

[PATCH 0/3] improve detection of attribute conflicts (PR 81544)

2017-08-08 Thread Martin Sebor
This patch series improves the attribute checking infrastructure to make it easy to express mutual exclusivity between attributes, detect and drop conflicting attributes as they are being added to declarations, and help find sources of conflicts when they involve two distinct declarations of the

[PATCH 3/3] diagnose attribute aligned conflicts (PR 81566)

2017-08-08 Thread Martin Sebor
Patch 3 in the series restores the diagnostics for conflicting attribute aligned on the same function (this regressed in r192199 in GCC 4.9), and also makes use of the enhanced infrastructure to enhance the detection of the same conflicts on distinct declarations of the same function. Rather