Re: [PATCH] Add anitizer_linux_x86_64.lo if __x86_64__ is defined by $CC

2017-10-05 Thread Jakub Jelinek
On Sat, Sep 30, 2017 at 06:12:39PM -0700, H.J. Lu wrote: > Since size of "void *" is 4 bytes for x32, check if __x86_64__ is defined > by $CC, instead of > > if test x$ac_cv_sizeof_void_p = x8; then > > to decide wether anitizer_linux_x86_64.lo should be used. > > I am testing this on i686 and

Re: [committed] Propagate attributes, including optimization and target node, to OMP outlined regions (PR tree-optimization/82374)

2017-10-05 Thread Jakub Jelinek
On Thu, Oct 05, 2017 at 09:59:35AM +0200, Rainer Orth wrote: > Hi Jakub, > > > 2017-10-04 Jakub Jelinek > > > > PR tree-optimization/82374 > > * omp-low.c (create_omp_child_function): Copy DECL_ATTRIBUTES, > > DECL_FUNCTION_SPECIFIC_OPTIMIZATION, > >

Re: Allow non-wi wi

2017-10-05 Thread Richard Biener
On Tue, Oct 3, 2017 at 8:34 PM, Richard Sandiford wrote: > This patch uses global rather than member operators for wide-int.h, > so that the first operand can be a non-wide-int type. Not sure why we had the in-class ones. If we had some good arguments they'd still

Re: [patch] Fix wrong code with small structure return on PowerPC

2017-10-05 Thread Richard Biener
On Tue, Oct 3, 2017 at 8:39 PM, Eric Botcazou wrote: >> Reading the patch I think that it gets conservativeness wrong -- shouldn't >> it be >> >> if (is_definitely_initialized) >>{ >> SUBREG_PROMOTED_VAR_P (temp) = 1; >> SUBREG_PROMOTED_SET (temp,

[PATCH][ARM][GCC] Add a self test for FPU feature bits

2017-10-05 Thread Tamar Christina
Hi All, This patch adds a more elaborate self-test to the arm back-end which tests to make sure you don't have any bit specified in ISA_ALL_FPU_INTERNAL that are not defined by any fpu configuration. Catching this during the self-test prevents an ICE at runtime when -mfpu=auto tries to detect

Re: [committed] Propagate attributes, including optimization and target node, to OMP outlined regions (PR tree-optimization/82374)

2017-10-05 Thread Rainer Orth
Hi Jakub, > This patch propagates attributes, including opt and target nodes, from > the containing function to the OMP/OACC outlined region functions. > > Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. > > 2017-10-04 Jakub Jelinek > > PR

Re: [PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-05 Thread Richard Biener
On Tue, Oct 3, 2017 at 12:40 AM, Jeff Law wrote: > On 10/02/2017 01:35 PM, Segher Boessenkool wrote: >> If we have (X)|C2 simplify_binary_operation_1 makes C1 as small as >> possible. This makes worse code in common cases like when the AND with >> C1 is from a zero-extension.

RE: 0001-Part-1.-Add-generic-part-for-Intel-CET-enabling

2017-10-05 Thread Tsimbalist, Igor V
I would like to implement the patch in a bit different way depending on answers I will get for my following proposals: - I propose to make a type with 'nocf_check' attribute to be different from type w/o the attribute. The reason is that the type with 'nocf_check' attribute implies different

Re: [PATCH][ARM][GCC] Add a self test for FPU feature bits

2017-10-05 Thread Richard Earnshaw (lists)
On 05/10/17 10:59, Tamar Christina wrote: > Hi All, > > This patch adds a more elaborate self-test to the arm back-end > which tests to make sure you don't have any bit specified in > ISA_ALL_FPU_INTERNAL that are not defined by any fpu configuration. > > Catching this during the self-test

[PATCH] Fix typos in graphite testcases

2017-10-05 Thread Richard Biener
Causing some UNRESOLVED. Committed. Richard. p3-3 Description: Binary data

Re: [C++ PATCH] Move mangling alias out of ::

2017-10-05 Thread Bernhard Reutner-Fischer
On Wed, Oct 04, 2017 at 12:51:18PM -0400, Nathan Sidwell wrote: > Applying to trunk. +void +record_mangling (tree decl, bool need_warning) +{ + if (!mangled_decls) +mangled_decls = hash_map::create_ggc (499); + + gcc_checking_assert (DECL_ASSEMBLER_NAME_SET_P (decl)); + tree id =

Re: [Libgomp, Fortran] Fix canadian cross build

2017-10-05 Thread Yvan Roux
On 5 September 2017 at 12:04, Jakub Jelinek wrote: > On Tue, Sep 05, 2017 at 10:58:22AM +0200, Yvan Roux wrote: >> ping >> >> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01784.html > > This really needs to be reviewed by a build machinery maintainer. Thanks for the CC list

[openacc, testsuite, committed] Fix libgomp.oacc-c-c++-common/{loop-red-g-1,routine-g-1}.c for non-nvidia devices

2017-10-05 Thread Tom de Vries
[ was : Re: [openacc, testsuite, committed] Fix libgomp.oacc-c-c++-common/loop-g-{1,2}.c for non-nvidia devices ] On 09/28/2017 08:47 AM, Tom de Vries wrote: Hi, this patch makes the test-cases libgomp.oacc-c-c++-common/loop-g-{1,2}.c  work for non-nvidia devices. For nvidia devices, a

Re: Transform (x >> cst) != 0 to x >= (1 << cst) and (x >> cst) == 0 to x < (1 << cst)

2017-10-05 Thread Richard Biener
On Tue, 3 Oct 2017, Jeff Law wrote: > On 10/03/2017 03:00 PM, Marc Glisse wrote: > > On Tue, 3 Oct 2017, Jakub Jelinek wrote: > > > >> On Tue, Oct 03, 2017 at 12:54:39PM -0700, Prathamesh Kulkarni wrote: > >>> Hi, > >>> This follow-up patch implements the patterns mentioned in $subject. > >>>

Re: [PATCH] Improve alloca alignment

2017-10-05 Thread Richard Biener
On Thu, Oct 5, 2017 at 1:07 AM, Jeff Law wrote: > On 10/04/2017 08:53 AM, Eric Botcazou wrote: >>> This seems like a SPARC target problem to me -- essentially it's >>> claiming a higher STACK_BOUNDARY than it really has. >> >> No, it is not, I can guarantee you that the stack

Re: [C++ PATCH] Move mangling alias out of ::

2017-10-05 Thread Nathan Sidwell
On 10/05/2017 05:28 AM, Bernhard Reutner-Fischer wrote: On Wed, Oct 04, 2017 at 12:51:18PM -0400, Nathan Sidwell wrote: + /* If this is already an alias, remove the alias, because the real + decl takes presidence. */ s/presidence/precedence/ ? thanks, + if (!existed) +; +

[PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-10-05 Thread Martin Liška
Hello. As discussed 2 days ago on IRC with Jakub and Jonathan, C++ standard says that having a non-return function with missing return statement is undefined behavior. We've got -fsanitize=return check for that and we can in such case instrument __builtin_unreachable(). This patch does that.

[PATCH], Add PowerPC ISA 3.0 Atomic Memory Operation functions

2017-10-05 Thread Michael Meissner
This patch adds support for most of the PowerPC ISA 3.0 Atomic Memory Operation instructions, listed in section 4.5 of the manual. Currently these functions are done via extended asm. At some point in the future, I will probably move the inner part of the patch to use new built-in functions to

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Martin Sebor
On 10/05/2017 03:04 PM, Bernd Edlinger wrote: On 10/05/17 18:16, Martin Sebor wrote: On 10/03/2017 01:33 PM, Bernd Edlinger wrote: I'm not sure if this warning may be a bit too strict, but I think so far it just triggered on rather questionable code. Thoughts? My initial thought is that

Re: [RFC] propagate malloc attribute in ipa-pure-const pass

2017-10-05 Thread Prathamesh Kulkarni
On 29 September 2017 at 12:28, Jan Hubicka wrote: >> > I wonder what happens here when, say, ipa-icf redirect the call to >> > eqivaelnt >> > function and removes the callee? Perhaps we realy want to have set of call >> > sites rahter than nodes stored from analysis to

bootstrap-debug-lean + flags in producer vs compare

2017-10-05 Thread Alexandre Oliva
Unlike bootstrap-debug, bootstrap-debug-lean used to pass compare using the traditional compare command, because it compiled both stage2 and stage3 with options that used to generate identical output (-fcompare-debug= in stage2 vs -fcompare-debug in stage3). Since we started adding relevant

Go patch committed: Drop special handling of unexported func/var names

2017-10-05 Thread Ian Lance Taylor
This patch to the Go frontend changes the handling of the assembler names used for unexported functions and variables, making them the same as for exported names. For example, for the package math/big, we used to generate unexported names as `big.trim` and exported names as `math_big.NewInt`.

Re: [PATCH] C++ warning on vexing parse

2017-10-05 Thread Nathan Sidwell
On 10/04/2017 10:44 AM, Jason Merrill wrote: Hmm, I don't think we want to diagnose these; if a parameter-list follows the parenthesized declarator, it isn't ambiguous. True. I went with that approach 3 and 4 seem like false positives. The problematic cases are all ones where the

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Bernd Edlinger
On 10/05/17 02:24, Eric Gallager wrote: > Sorry if this is a stupid question, but could you explain how this > warning is different from -Wbad-function-cast? Something about direct > calls to functions vs. passing them as function pointers? No, it is not :) -Wbad-function-cast is IMHO a strange

Re: [PATCH v3 1/14] D: The front-end (DMD) language implementation and license.

2017-10-05 Thread Iain Buclaw
On 3 October 2017 at 23:36, Joseph Myers wrote: > On Tue, 3 Oct 2017, Jeff Law wrote: > >> /* Copyright (c) 2010-2014 by Digital Mars >> * All Rights Reserved, written by Walter Bright >> * http://www.digitalmars.com >> * Distributed under the Boost Software License,

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Bernd Edlinger
On 10/03/17 23:34, Joseph Myers wrote: > On Tue, 3 Oct 2017, Bernd Edlinger wrote: > >> invalid, also if both function types have a non-null TYPE_ARG_TYPES >> I would say this deserves a warning. As an exception I have > > I'm not convinced by the TYPE_ARG_TYPES check, at least for C. > I

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Joseph Myers
On Thu, 5 Oct 2017, Bernd Edlinger wrote: > But why is int(*)(int) compatible to (int)(*)() but not > to int(*)(int,...) ? I think it's a matter of what function types were possible in K C. variadic types weren't (there was an older ), and neither were types with arguments of type float or

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-10-05 Thread Jakub Jelinek
On Thu, Oct 05, 2017 at 12:31:23PM +0200, Martin Liška wrote: > As discussed 2 days ago on IRC with Jakub and Jonathan, C++ standard says > that having a non-return > function with missing return statement is undefined behavior. We've got > -fsanitize=return check for > that and we can in such

Re: [PATCH] C++ warning on vexing parse

2017-10-05 Thread Nathan Sidwell
On 10/04/2017 08:17 PM, Eric Gallager wrote: On Tue, Oct 3, 2017 at 1:08 PM, Nathan Sidwell wrote: [non-c++ people on CC, there's a reason ...] This patch adds a new warning, concerning unnecessary parentheses on a declaration. For instance: prettyprinter (pp); Could

[PATCH GCC][6/7]Support loop nest distribution for builtin partition

2017-10-05 Thread Bin Cheng
Hi, This patch rewrites classification part of builtin partition so that nested builtin partitions are supported. With this extension, below loop nest: void foo (void) { for (unsigned i = 0; i < M; ++i) for (unsigned j = 0; j < N; ++j) arr[i][j] = 0; will be distributed into a single

[PATCH GCC][7/7]Merge adjacent memset builtin partitions

2017-10-05 Thread Bin Cheng
Hi, This patch merges adjacent memset builtin partitions if possible. It is a useful special case optimization transforming below code: #define M (256) #define N (512) struct st { int a[M][N]; int c[M]; int b[M][N]; }; void foo (struct st *p) { for (unsigned i = 0; i < M; ++i) {

Zen tuning part 1 (reassociation width)

2017-10-05 Thread Jan Hubicka
Hi, this patch enables reassociation of integer and vector operations for Zen. While doing so I have noticed that the logic is split across three target hooks (TARGET_VECTOR_PARALLEL_EXECUTION, TARGET_REASSOC_INT_TO_PARALLEL and TARGET_REASSOC_FP_TO_PARALLEL) and function ix86_reassociation_width.

Re: [PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-05 Thread Segher Boessenkool
On Thu, Oct 05, 2017 at 10:46:13AM +0200, Richard Biener wrote: > >> PR rtl-optimization/77729 > >> * simplify-rtx.c (simplify_binary_operation_1): Delete the (X)|C2 > >> to (X&(C1&~C2))|C2 transformations. > > OK for the trunk. I'm not sure if the BZ in question qualifies this

[PATCH GCC][3/7]Don't skip renaming PHIs in loop nest with only one inner loop

2017-10-05 Thread Bin Cheng
Hi, Function rename_variables_in_bb skips renaming PHI nodes in loop nest if the outer loop has only one inner loop. This breaks loop nest distribution when inner loop has PHI node initialized from outer loop's variable. Unfortunately, I lost the original C code illustrating the issue. Now it

[PATCH GCC][2/7]Don't rename variables for deleted new preheader

2017-10-05 Thread Bin Cheng
Hi, I noticed that new_preheader basic block could be deleted if the copied loop is added at entry in function slpeel_tree_duplicate_loop_to_edge_cfg. This simple patch skips new_preheader during variable renaming if it is deleted. Bootstrap and test in patch set on x86_64 and AArch64, is it OK?

Re: [PATCH] PR target/68256 Defining TARGET_USE_CONSTANT_BLOCKS_P causes go bootstrap failure on aarch64

2017-10-05 Thread Richard Earnshaw (lists)
On 04/10/17 00:50, vladimir.mezent...@oracle.com wrote: > From: Vladimir Mezentsev > > Tested on aarch64-linux-gnu. > No regression. > No bootstrap failure. > > gcc/ChangeLog: > 2017-09-26 Vladimir Mezentsev > > *

Re: [AArch64] Backport to gcc-7 PR71727 fix -mstrict-align

2017-10-05 Thread Richard Earnshaw (lists)
On 04/10/17 14:35, Christophe Lyon wrote: > Hi, > > I've recently committed a follow-up fix for PR71727 for -mstrict-align > on aarch64 (r253242). > I think it would be appropriate to apply it to gcc-7-branch. The patch > from trunk applies cleanly to gcc-7-branch. > > Although the original bug

Re: [PATCH][GRAPHITE] Rewrite PHI handling in code-gen

2017-10-05 Thread Richard Biener
On Wed, 4 Oct 2017, Richard Biener wrote: > > The following patch completely re-does PHI handling during > code-generation. PHI handling is currently responsible for 99% of > all code-generation issues. With the patch the number of code-generation > issues in SPEC 2k6 decreases from 180 to 5,

[C++ PATCH] Kill IDENTIFIER_GLOBAL_VALUE

2017-10-05 Thread Nathan Sidwell
As mentioned yesterday, there's now no need for set_global_binding to have separate name & decl parms. This patch makes that change and kills IDENTIFIER_GLOBAL_VALUE and SET_IDENTIFIER_GLOBAL_VALUE, which are have been forwarding macros for a long time now. Because get_namespace_binding has

[PATCH GCC][1/7]Delete unused field of struct partition in loop distribution

2017-10-05 Thread Bin Cheng
Hi, This patch set implements distribution and builtin pattern distribution for loop nest. It consists of below patches: Patches [1~4]: Cleanup and (latent) bug fixes. Patch [5]: Loop nest distribution of two-level innermost loop nest. Patches [6,7]: Loop nest builtin pattern distribution.

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Andreas Schwab
On Okt 05 2017, Bernd Edlinger wrote: > The idea for this warning came up when someone spotted a place in > openssl, where a type cast was used to change the return value of a > callback function from long to int: > > https://github.com/openssl/openssl/issues/4413 > >

Re: [Libgomp, Fortran] Fix canadian cross build

2017-10-05 Thread Petr Ovtchenkov
On Thu, 5 Oct 2017 12:56:36 +0200 Yvan Roux wrote: > On 5 September 2017 at 12:04, Jakub Jelinek wrote: > > On Tue, Sep 05, 2017 at 10:58:22AM +0200, Yvan Roux wrote: > >> ping > >> > >> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01784.html > > > >

[PATCH GCC][5/7]Extend loop distribution for two-level innermost loop nest

2017-10-05 Thread Bin Cheng
Hi, For now distribution pass only handles the innermost loop. This patch extends the pass to cover two-level innermost loop nest. It also refactors code in pass_loop_distribution::execute for better reading. Note I restrict it to 2-level loop nest on purpose because of high cost in data

[PATCH GCC][4/7]Choose exit edge/path when removing inner loop's exit statement

2017-10-05 Thread Bin Cheng
Hi, Function generate_loops_for_partition chooses arbitrary path when removing exit condition not in partition. This is fine for now because it's impossible to have loop exit condition in case of innermost distribution. After extending to loop nest distribution, we must choose exit edge/path

Re: [PATCH] Add sanopt support for UBSAN_PTR.

2017-10-05 Thread Martin Liška
On 10/04/2017 08:06 PM, Jakub Jelinek wrote: > On Wed, Oct 04, 2017 at 11:05:23AM +0200, Martin Liška wrote: >> Following patch adds support for optimizing out unnecessary UBSAN_PTR checks. >> It handles separately positive and negative offsets, zero offset is ignored. >> Apart from that, we

[PATCH 2/2] C/C++: add fix-it hints for various missing symbols (v3)

2017-10-05 Thread David Malcolm
Here's a slight update to this patch, since v2 was made invalid by r253411 ("C: underline parameters in mismatching function calls"). Both v2 and r253411 added code to c-parser.c/h to track the location_t of the last consumed token (although I somehow managed to name the new field in c_parser

libbacktrace patch committed: Minor decompression improvement

2017-10-05 Thread Ian Lance Taylor
I've committed a patch to libbacktrace to speed up decompression a few percent by loading 32-bit values rather than 8-bit bytes. Bootstrapped and ran libbacktrace and Go tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2017-10-05 Ian Lance Taylor * elf.c

Re: [PATCH] Add sanopt support for UBSAN_PTR.

2017-10-05 Thread Martin Sebor
On 10/04/2017 03:05 AM, Martin Liška wrote: Hello. Following patch adds support for optimizing out unnecessary UBSAN_PTR checks. It handles separately positive and negative offsets, zero offset is ignored. Apart from that, we utilize get_inner_reference for local and global variables, that also

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Maxim Kuvyrkov
> On Oct 5, 2017, at 8:20 PM, Steve Ellcey wrote: > > On Wed, 2017-10-04 at 13:24 +, Wilco Dijkstra wrote: >> Richard Sandiford wrote: >>> >>> >>> I don't think it's reasonable to commit this as obvious. You said >>> yourself in the covering message that "it doesn't at

[PATCH] Print variadic C-functions properly in diagnostics

2017-10-05 Thread Bernd Edlinger
Hi! This fixes the c-pretty-printing of variadic function types by adding ", ..." to the output of the function parameters. Bootstrapped and reg-tested on x86_64-pc-linux-gnu. Is it OK for trunk? Thanks Bernd. c-family: 2017-10-05 Bernd Edlinger *

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Martin Sebor
On 10/03/2017 01:33 PM, Bernd Edlinger wrote: Hi! I have implemented a warning -Wcast-function-type that analyzes type casts which change the function signatures. I would consider function pointers with different result type invalid, also if both function types have a non-null TYPE_ARG_TYPES I

Re: Zen tuning part 2: Increase branch_cost to 3

2017-10-05 Thread Joseph Myers
Should mention PR target/80313 (don't know if this is a complete fix, but it's at least an issue mentioned in that bug). -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-10-05 Thread Richard Earnshaw (lists)
On 25/09/17 17:35, Qing Zhao wrote: > Hi, Andreas, > > thanks for the comment. > >> GNU style is line break before the operator, not after. > > updated per your comment. > > Qing. > > --- > gcc/config/aarch64/aarch64.c | 12 +--- > gcc/config/aarch64/aarch64.h

Re: [PATCH] Fix PR81422[aarch64] internal compiler error: in update_equiv_regs, at ira.c:3425

2017-10-05 Thread Qing Zhao
HI, Richard, > On Oct 5, 2017, at 9:53 AM, Richard Earnshaw (lists) > wrote: > > Two minor nits to fix: > > - ChangeLog entries should start with a capital letter (s/check/Check/). > - Please use hard tabs rather than 8 consecutive spaces (each of your > new 'if'

Fix PR ada/82393

2017-10-05 Thread Eric Botcazou
It's a build failure on Cygwin64 and is very similar to PR ada/64640, which was a build failure on Cygwin32. Instead of defining non-existent constants, let's just reuse the DJGPP version of __gnat_set_mode here. Applied on the mainline and 7 branch. 2017-10-05 Eric Botcazou

Re: [PATCH] Print variadic C-functions properly in diagnostics

2017-10-05 Thread Joseph Myers
On Thu, 5 Oct 2017, Bernd Edlinger wrote: > Hi! > > This fixes the c-pretty-printing of variadic function types by > adding ", ..." to the output of the function parameters. > > > Bootstrapped and reg-tested on x86_64-pc-linux-gnu. > Is it OK for trunk? OK. -- Joseph S. Myers

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-10-05 Thread Martin Liška
On 10/05/2017 05:07 PM, Jason Merrill wrote: On Thu, Oct 5, 2017 at 6:31 AM, Martin Liška wrote: As discussed 2 days ago on IRC with Jakub and Jonathan, C++ standard says that having a non-return function with missing return statement is undefined behavior. We've got

Go patch committed: Consolidate all names in one place

2017-10-05 Thread Ian Lance Taylor
This patch to the Go frontend consolidates all external name handling in one place: a new file names.cc. This handles names that might appear in the assembly code, not necessarily names that are only used for local variables and labels and the like. This patch does not change any of the names,

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Steve Ellcey
On Wed, 2017-10-04 at 13:24 +, Wilco Dijkstra wrote: > Richard Sandiford wrote: > > > > > > I don't think it's reasonable to commit this as obvious.  You said > > yourself in the covering message that "it doesn't at all restore > > the original behaviour since we no longer compare the base

Zen tuning part 2: Increase branch_cost to 3

2017-10-05 Thread Jan Hubicka
Hi, this patch increases branch_cost to 3. Constant 2 is apparently copied from bdver4 costs while core and generic use 3. 3 seems to give best results for spec2000 and also significantly improve monte carlo benchmark from scimark. Bootstrapped/regtested x86_64-linux, comitted. Index:

Zen tuning part 3: Simplify ia32_multipass_dfa_lookahead

2017-10-05 Thread Jan Hubicka
Hi, ia32_multipass_dfa_lookahead currently defaults to issue rate for all modern CPUs. It return 1 for pentiumpro and k6 but I believe it is only because no one was interested to benchmark it and enable it. I do not think these two exceptions are worth of the maintenance burden especially

Re: [PATCH] Fix typos in graphite testcases

2017-10-05 Thread Sebastian Pop
On Thu, Oct 5, 2017 at 2:44 AM, Richard Biener wrote: > Causing some UNRESOLVED. > > Committed. > Looks good. Thanks!

Re: [PATCH][GCC][testsuite][mid-end][ARM][AARCH64] Fix failing vec align tests.

2017-10-05 Thread Richard Earnshaw (lists)
On 02/10/17 14:13, Tamar Christina wrote: > Hi All, > > Previously I had corrected the vect_hw_misalign check which prompted these > three test to start failing because the condition needs to be inverted in the > testcases. > > Regtested on aarch64-none-elf, arm-none-linux-gnueabihf and >

Re: [PATCH][RFC] Instrument function exit with __builtin_unreachable in C++.

2017-10-05 Thread Jason Merrill
On Thu, Oct 5, 2017 at 6:31 AM, Martin Liška wrote: > As discussed 2 days ago on IRC with Jakub and Jonathan, C++ standard says > that having a non-return > function with missing return statement is undefined behavior. We've got > -fsanitize=return check for > that and we can in

tree-complex.c: fix some_nonzerop test over reals (and a bug fix)

2017-10-05 Thread Laurent Thevenoux
Hello, This patch improves the some_nonzerop(tree t) function from tree-complex.c file (the function is only used there). This function returns true if a tree as a parameter is not the constant 0 (or +0.0 only for reals when !flag_signed_zeros ). The former result is then used to determine

[PATCH] ira-color: fix allocno_priority_compare_func for qsort (PR 82395)

2017-10-05 Thread Alexander Monakov
Hello, In ira-color.c, qsort comparator allocno_priority_compare_func lacks anti- commutativity and can indicate A < B < A if boths allocnos satisfy non_spilled_static_chain_regno_p. It should fall down to following sub-comparisons in that case. There is another issue: the comment doesn't match

Re: [PATCH][AArch64] Add BIC-imm and ORR-imm SIMD pattern

2017-10-05 Thread Sudi Das
Hi Steve Sorry about this. I am on it. I have a fix and I am running tests on it right now. Sudi From: Steve Ellcey Sent: Thursday, October 5, 2017 12:05 AM To: Richard Earnshaw; Sudi Das; James Greenhalgh Cc: gcc-patches@gcc.gnu.org; nd; Marcus Shawcroft Subject: Re:

Re: [PATCH][GRAPHITE] Rewrite PHI handling in code-gen

2017-10-05 Thread Sebastian Pop
On Thu, Oct 5, 2017 at 6:43 AM, Richard Biener wrote: > On Wed, 4 Oct 2017, Richard Biener wrote: > > > > > The following patch completely re-does PHI handling during > > code-generation. PHI handling is currently responsible for 99% of > > all code-generation issues. With

Re: [PATCH] [graphite] translate reads and writes in a single traversal of memory ops

2017-10-05 Thread Sebastian Pop
On Mon, Oct 2, 2017 at 4:18 AM, Richard Biener wrote: > On Mon, Oct 2, 2017 at 6:53 AM, Sebastian Pop > wrote: > > The patch moves the code that translates reads and writes to isl > representation > > in a same loop. This is to avoid

Re: [GCC][PATCH][testsuite][mid-end] Fix failing slp test on aarch64 and arm.

2017-10-05 Thread Richard Earnshaw (lists)
On 02/10/17 14:20, Tamar Christina wrote: > Hi All, > > The slp vectorization test currently fails on AArch32 and AArch64 > due to it not taking into account that we do have 128 bit vectors in > NEON. This means that two of the loops get vectorized instead of just 1. > > So update the conditions

Re: [PATCH v3 7/14] D: Add D language support to GCC targets.

2017-10-05 Thread Richard Earnshaw (lists)
On 02/10/17 10:00, Iain Buclaw wrote: > This patch add D language support to targets of GCC itself. > > Changes since previous are just removing patches for untested target > configurations, these can be re-added later on an as-per basis. > > --- > > > 07-v3-d-gcc-target.patch > > >

Re: [PATCH v3 7/14] D: Add D language support to GCC targets.

2017-10-05 Thread Iain Buclaw
On 5 October 2017 at 16:56, Richard Earnshaw (lists) wrote: > On 02/10/17 10:00, Iain Buclaw wrote: >> This patch add D language support to targets of GCC itself. >> >> Changes since previous are just removing patches for untested target >> configurations, these can be

Re: [PATCH][GRAPHITE] Adjust CASE_CONVERT in extract_affine

2017-10-05 Thread Sebastian Pop
On Wed, Oct 4, 2017 at 2:45 AM, Richard Biener wrote: > > While my last change involving signed types was correct it wasn't optimal. > We can avoid the modulo constraints if the conversion is widening > (thus all values fit in the new type). > > Bootstrapped and tested on

Re: [PATCH][GRAPHITE] Rewrite PHI handling in code-gen

2017-10-05 Thread Sebastian Pop
On Thu, Oct 5, 2017 at 9:20 AM, Sebastian Pop wrote: > > We also need to tag commutative and associative reductions > in the dependence graph. Now that the code generation will > nicely handle scalar dependences, we may want to add back > some of the code from this commit: >

Re: [PATCH] Fix PR81422[aarch64] internal compiler error: in update_equiv_regs, at ira.c:3425

2017-10-05 Thread Richard Earnshaw (lists)
On 19/09/17 20:22, Qing Zhao wrote: > Hi, > > This patch fixes the aarch64 bug 81422 > https://gcc.gnu.org/PR81422 > > Before adding REG_EQUIV notes in the TLS symbol handling code, > we should check whether the "dest" is a REG or NOT (sometimes, > it's a SUBREG as in this bug). Only when the

[PATCH] PR82396 workaround for AArch64 bootstrap failure

2017-10-05 Thread Wilco Dijkstra
r253236 broke AArch64 bootstrap. This is a temporary workaround that disables qsort checking in the scheduler to enable continued development and testing on AArch64. This will be removed once the autopref scheduling code has been fixed. AArch64 bootstrap completes, OK for commit? ChangeLog:

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Steve Ellcey
On Thu, 2017-10-05 at 20:33 +0300, Maxim Kuvyrkov wrote: > I'm currently bootstrapping the following patch (on aarch64-linux- > gnu, arm-linux-gnueabihf will follow tomorrow), which (like Wilco's > patch) seems to unbreak bootstrap, but is less invasive and preserves > handling of

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Wilco Dijkstra
Maxim Kuvyrkov wrote: > What the heck, I'll jump in as well. Why not - how many engineers does it take to sort?!? > I'm still working on analysis, but it appears to me that Alexander's patch > (current state of trunk) fails qsort check due to not being symmetric for > load/store analysis

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Eric Gallager
On 10/5/17, Bernd Edlinger wrote: > On 10/05/17 02:24, Eric Gallager wrote: >> Sorry if this is a stupid question, but could you explain how this >> warning is different from -Wbad-function-cast? Something about direct >> calls to functions vs. passing them as function

Re: [PATCH v3 1/14] D: The front-end (DMD) language implementation and license.

2017-10-05 Thread Walter Bright
On 10/5/2017 3:59 AM, Iain Buclaw wrote: On 3 October 2017 at 23:36, Joseph Myers wrote: On Tue, 3 Oct 2017, Jeff Law wrote: /* Copyright (c) 2010-2014 by Digital Mars * All Rights Reserved, written by Walter Bright * http://www.digitalmars.com * Distributed

RE: Zen tuning part 2: Increase branch_cost to 3

2017-10-05 Thread Kumar, Venkataramanan
Hi Honza, -Original Message- From: Jan Hubicka [mailto:hubi...@ucw.cz] Sent: Thursday, October 5, 2017 8:41 PM To: gcc-patches@gcc.gnu.org; Kumar, Venkataramanan Subject: Zen tuning part 2: Increase branch_cost to 3 Hi, this patch increases branch_cost to

Re: [RFA] [PATCH 4/4] Ignore reads of "dead" memory locations in DSE

2017-10-05 Thread Christophe Lyon
Hi Jeff, On 7 September 2017 at 00:18, Jeff Law wrote: > Another old patch getting resurrected... > > This patch (r253305) introduces a new FAIL on arm-none-eabi (as opposed arm-linux-gnueabi*): FAIL: gcc.dg/tree-ssa/ssa-dse-26.c scan-tree-dump-times dse1 "Deleted dead

[PATCH] Improve -fstore-merging for bool/enum constants (PR tree-optimization/82434)

2017-10-05 Thread Jakub Jelinek
Hi! The following testcase fails, because can_native_encode_type_p doesn't handle BOOLEAN_TYPE nor ENUMERAL_TYPE (while native_encode_expr handles those just fine). But, it isn't just those, can_native_encode_type_p doesn't really make sense to me, since whether native_encode_expr fails or not

[C PATCH] Fix -Wtautological-compare (PR c/82437)

2017-10-05 Thread Jakub Jelinek
Hi! In warn_tautological_bitwise_comparison, there is even a comment mentioning the fact that the types of the two constants might not be the same (it is called with the original arguments before they are promoted to common type for the comparison). On the following testcase, one of the

Re: [PATCH] C++17 P0067R5 std::to_chars and std::from_chars (partial)

2017-10-05 Thread Jonathan Wakely
On 05/10/17 22:00 +0200, Christophe Lyon wrote: Hi Jonathan, On 3 October 2017 at 16:31, Jonathan Wakely wrote: On 02/10/17 15:13 +0100, Jonathan Wakely wrote: +#ifndef _GLIBCXX_CHARCONV +#define _GLIBCXX_CHARCONV 1 + +#pragma GCC system_header + +#if __cplusplus >=

Re: [PATCH][GCC][testsuite][mid-end][ARM][AARCH64] Fix failing vec align tests.

2017-10-05 Thread Rainer Orth
Hi Tamar, > Previously I had corrected the vect_hw_misalign check which prompted these > three test to start failing because the condition needs to be inverted in the > testcases. > > Regtested on aarch64-none-elf, arm-none-linux-gnueabihf and > x86_64-pc-linux-gnu. > > Ok for trunk? > > Thanks,

Re: [PATCH] Improve alloca alignment

2017-10-05 Thread Wilco Dijkstra
Richard Biener wrote: > On Thu, Oct 5, 2017 at 1:07 AM, Jeff Law wrote: > > On 10/04/2017 08:53 AM, Eric Botcazou wrote: This seems like a SPARC target problem to me -- essentially it's claiming a higher STACK_BOUNDARY than it really has. >>> >>> No, it is not, I can

Re: [PATCH] C++17 P0067R5 std::to_chars and std::from_chars (partial)

2017-10-05 Thread Christophe Lyon
Hi Jonathan, On 3 October 2017 at 16:31, Jonathan Wakely wrote: > On 02/10/17 15:13 +0100, Jonathan Wakely wrote: >> >> +#ifndef _GLIBCXX_CHARCONV >> +#define _GLIBCXX_CHARCONV 1 >> + >> +#pragma GCC system_header >> + >> +#if __cplusplus >= 201402L >> + >> +#include >>

Re: Let the target choose a vectorisation alignment

2017-10-05 Thread Christophe Lyon
Hi Richard, On 18 September 2017 at 15:57, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Sep 18, 2017 at 1:58 PM, Richard Sandiford >> wrote: >>> The vectoriser aligned vectors to TYPE_ALIGN

Re: [PATCH] Fix PR82396: qsort comparator non-negative on sorted output

2017-10-05 Thread Alexander Monakov
On Thu, 5 Oct 2017, Maxim Kuvyrkov wrote: > I'm still working on analysis, but it appears to me that Alexander's patch > (current state of trunk) fails qsort check due to not being symmetric for > load/store analysis (write == 0 or write == 1) in comparisons with > "irrelevant" instructions.

Re: [PATCH] Fix PR80295[aarch64] [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-10-05 Thread Qing Zhao
Richard, thanks for your review and comments. > On Oct 5, 2017, at 11:50 AM, Richard Earnshaw (lists) > wrote: > > On 25/09/17 17:35, Qing Zhao wrote: >> >> --- a/gcc/config/aarch64/aarch64.h >> +++ b/gcc/config/aarch64/aarch64.h >> @@ -782,7 +782,7 @@ typedef

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Bernd Edlinger
On 10/05/17 18:16, Martin Sebor wrote: > On 10/03/2017 01:33 PM, Bernd Edlinger wrote: >> >> I'm not sure if this warning may be a bit too strict, but I think >> so far it just triggered on rather questionable code. >> >> Thoughts? > > My initial thought is that although casts between

Re: [C PATCH] Fix -Wtautological-compare (PR c/82437)

2017-10-05 Thread Marek Polacek
On Thu, Oct 05, 2017 at 10:34:26PM +0200, Jakub Jelinek wrote: > Hi! > > In warn_tautological_bitwise_comparison, there is even a comment > mentioning the fact that the types of the two constants might not be the > same (it is called with the original arguments before they are promoted > to

Re: [PATCH] PR target/68256 Defining TARGET_USE_CONSTANT_BLOCKS_P causes go bootstrap failure on aarch64

2017-10-05 Thread vladimir . mezentsev
On 10/05/2017 07:09 AM, Richard Earnshaw (lists) wrote: > On 04/10/17 00:50, vladimir.mezent...@oracle.com wrote: >> From: Vladimir Mezentsev >> >> Tested on aarch64-linux-gnu. >> No regression. >> No bootstrap failure. >> >> gcc/ChangeLog: >> 2017-09-26 Vladimir

Re: [C++ PATCH] Fix comment

2017-10-05 Thread Jason Merrill
On Wed, Oct 4, 2017 at 11:44 AM, Nathan Sidwell wrote: > On 10/04/2017 11:29 AM, Jason Merrill wrote: >> On Wed, Oct 4, 2017 at 10:12 AM, Nathan Sidwell wrote: >>> In answering a question about passing non-trivial types through ..., I >>> discovered a misleading

Re: [RFA] [PATCH] Add a warning for invalid function casts

2017-10-05 Thread Joseph Myers
On Thu, 5 Oct 2017, Bernd Edlinger wrote: > Maybe it would be good to not warn in type-casts, when they can be > assumed to be safe, for instance > void* <-> any pointer (parameter or result), > uintptr_t <-> any int, any pointer (parameter or result), > void (*) (void) and void (*) (...) <-> any

[PATCH] rs6000: Fix an error message in sysv4.h

2017-10-05 Thread Segher Boessenkool
While looking at PR82411, I got the error message error: '-msdata=-mcall' and 'eabi-linux' are incompatible which caused some head-scratching. Fixed thusly. Will also backport (to 7 and 6) later. Segher 2017-10-05 Segher Boessenkool *