Re: [PATCH] Improve FAIL message for dump-*-times functions.

2017-10-17 Thread Martin Liška
On 10/11/2017 06:56 PM, Segher Boessenkool wrote: Hi! On Wed, Oct 11, 2017 at 10:14:29AM +0200, Martin Liška wrote: This patch helps to find why an expected number of scan patterns does not match: FAIL: gcc.dg/unroll-3.c scan-tree-dump-times cunrolli "loop with 3 iterations completely

[patch] avoid printing leading 0 in widest_int hex dumps

2017-10-17 Thread Aldy Hernandez
Hi folks! Calling print_hex() on a widest_int with the most significant bit turned on can lead to a leading zero being printed (0x0). This produces confusing dumps to say the least, especially when you incorrectly assume an integer is NOT signed :). OK for trunk? gcc/ *

Re: Missing REDUCE[SD,SS] intrinsics

2017-10-17 Thread Kirill Yukhin
Hello Olga, Sebastian, On 16 Oct 11:20, Peryt, Sebastian wrote: > Hi, > > This patch written by Olga Makhotina adds missing intrinsics for > REDUCE[SD,SS]. > > 16.10.2017 Olga Makhotina > > gcc/ > * config/i386/avx512dqintrin.h (_mm_mask_reduce_sd, >

[patch] Relax IVOPTs restriction on auto-increment

2017-10-17 Thread Eric Botcazou
Hi, add_autoinc_candidates begins with this test: /* If we insert the increment in any position other than the standard ones, we must ensure that it is incremented once per iteration. It must not be in an inner nested loop, or one side of an if statement. */ if

Re: [PATCH][GRAPHITE] Consistently use region analysis

2017-10-17 Thread Richard Biener
On Sat, 14 Oct 2017, Sebastian Pop wrote: > On Fri, Oct 13, 2017 at 8:02 AM, Richard Biener wrote: > > > > > Now that SCEV instantiation handles regions properly (see hunk below > > for a minor fix) we can use it consistently from GRAPHITE and thus > > simplify

Re: [PATCH PR/82546] tree node size

2017-10-17 Thread Richard Biener
On Mon, 16 Oct 2017, Nathan Sidwell wrote: > On 10/16/2017 02:49 AM, Richard Biener wrote: > > On October 13, 2017 8:29:40 PM GMT+02:00, Nathan Sidwell > > wrote: > > > > I intend to continue cleaning this up of course. It's not clear to me > > > whether we should cache these

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-10-17 Thread Richard Biener
On Fri, Oct 13, 2017 at 6:13 PM, Martin Jambor wrote: > Hi, > > I'd like to request comments to the patch below which aims to fix PR > 80689, which is an instance of a store-to-load forwarding stall on > x86_64 CPUs in the Image Magick benchmark, which is responsible for a > slow

Re: [PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-10-17 Thread Richard Biener
On Sat, Oct 14, 2017 at 10:39 AM, Eric Botcazou wrote: >> This looks good. OK for the trunk. > > FWIW I disagree. The patch completely shuns the existing implementation of > the pass, which is based on a forward scan within basic blocks to identify the > various

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Thomas Schwinge
Hi! On Mon, 16 Oct 2017 10:49:45 +0200, Tom de Vries wrote: > this patch enables some openacc test-cases for non-nvidia devices. > > Committed. Thanks! > --- a/libgomp/testsuite/libgomp.oacc-fortran/declare-1.f90 > +++

Re: Check that there are no missing probabilities

2017-10-17 Thread Richard Biener
On Fri, Oct 13, 2017 at 9:27 PM, Jakub Jelinek wrote: > On Fri, Oct 13, 2017 at 09:06:55PM +0200, Jan Hubicka wrote: >> For EH we should set it to profile_probability::zero () because we know it >> is unlikely >> path. I will take a look. > > With the > > ---

Re: [patch] Enhance support for -Wstack-usage/-Wvla-larger-than/-Walloca-larger-than

2017-10-17 Thread Richard Biener
On Mon, Oct 16, 2017 at 10:35 AM, Eric Botcazou wrote: > Hi, > > a big limitation of -Wstack-usage/-Wvla-larger-than/-Walloca-larger-than is > that you need -O2 (or more precisely -ftree-vrp) in order to be able to say > something sensible for dynamically-sized

Re: Check that there are no missing probabilities

2017-10-17 Thread Jan Hubicka
> > graphite does > > if (changed) > { > cleanup_tree_cfg (); > profile_status_for_fn (cfun) = PROFILE_ABSENT; > release_recorded_exits (cfun); > tree_estimate_probability (false); > > so it runs into CFG cleanup running before it properly resets counts. > > I

Re: [patch] avoid printing leading 0 in widest_int hex dumps

2017-10-17 Thread Richard Sandiford
Aldy Hernandez writes: > Hi folks! > > Calling print_hex() on a widest_int with the most significant bit turned > on can lead to a leading zero being printed (0x0). This produces > confusing dumps to say the least, especially when you incorrectly assume > an integer

Re: [patch][arm] gcc-7-branch: Fix bootstrap on FreeBSD

2017-10-17 Thread Kyrill Tkachov
Hi Andreas, On 16/10/17 20:00, Andreas Tobler wrote: Hi all, I struggled over a bootstrap issue while building gcc-7 for armv7-*-freebsd* I got a 'permission denied' while creating the arm-tables.opt file. The source tree is located on a nfs server. The below patch fixed it for me. Ok to

Re: [PATCH] Improve alloca alignment

2017-10-17 Thread Wilco Dijkstra
Wilco Dijkstra wrote: > > Yes STACK_BOUNDARY applies to virtual_stack_dynamic_rtx and all other > virtual frame registers. It appears it's main purpose is to enable alignment > optimizations since PREFERRED_STACK_BOUNDARY is used to align > local and outgoing argument area etc. So if you don't

Re: [PATCH GCC]Introduce qsort_range interface for GCC vector

2017-10-17 Thread Richard Biener
On Mon, Oct 16, 2017 at 4:53 PM, Bin Cheng wrote: > Hi, > I was asked by Richi to replace insertion sort with qsort_range in loop > nest distribution patch. Although I believe stable sort (thus insertion) > sort is needed in that case, I also added qsort_range interface in

Re: [patch][arm] gcc-7-branch: Fix bootstrap on FreeBSD

2017-10-17 Thread Kyrill Tkachov
On 17/10/17 13:42, Andreas Tobler wrote: Hi Kyrill, On 17.10.17 12:02, Kyrill Tkachov wrote: > On 16/10/17 20:00, Andreas Tobler wrote: >> Hi all, >> >> I struggled over a bootstrap issue while building gcc-7 for >> armv7-*-freebsd* >> >> I got a 'permission denied' while creating the

[patch][i386, AVX] GFNI enabling [3/4]

2017-10-17 Thread Koval, Julia
Hi, this the third patch of GFNI ISASET enabling. It enables GF2P8AFFINE instruction, described here: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf gcc/ * config/i386/gfniintrin.h

[PATCH][GRAPHITE] Fix PR82563

2017-10-17 Thread Richard Biener
PR82573 shows the ugly part of an earlier fix, that we now split the entry edge of SCOPs during analysis phase to get a GBB for the entry edge PHI copies. That invalidates loop-closed SSA in some cases like the PR. So the following patch gets rid of that "fake" GBB by explicitely emitting SESE

RE: [patch][i386, AVX] GFNI enabling [3/4]

2017-10-17 Thread Koval, Julia
Thanks for your comments, fixed everything. gcc/ * config/i386/gfniintrin.h (_mm_gf2p8affine_epi64_epi8, _mm256_gf2p8affine_epi64_epi8, _mm_mask_gf2p8affine_epi64_epi8, _mm_maskz_gf2p8affine_epi64_epi8, _mm256_mask_gf2p8affine_epi64_epi8,

Re: [PATCH][Middle-end]Fix PR80295 [7/8 Regression] ICE in __builtin_update_setjmp_buf expander

2017-10-17 Thread Richard Biener
On Mon, 16 Oct 2017, Qing Zhao wrote: > resend this patch for middle-end to review. > > this patch was originally sent to aarch64 for review in the beginning: > > https://gcc.gnu.org/ml/gcc-patches/2017-10/msg00404.html > > The

[PATCH][GRAPHITE] Remove dead code

2017-10-17 Thread Richard Biener
The following removes copy_internal_parameters and the parameter rename map. It got dead by myself forgetting to copy the member to the false if-region part ... and in previous mail we discussed we'd rather wait for a testcase showing the need to handle "parameters" defined in the region.

Re: [PATCH GCC][7/7]Merge adjacent memset builtin partitions

2017-10-17 Thread Bin.Cheng
On Mon, Oct 16, 2017 at 5:27 PM, Bin.Cheng wrote: > On Mon, Oct 16, 2017 at 5:00 PM, Bin.Cheng wrote: >> On Mon, Oct 16, 2017 at 2:56 PM, Bin.Cheng wrote: >>> On Thu, Oct 12, 2017 at 2:43 PM, Richard Biener >>>

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 02:51 PM, Tom de Vries wrote: On 10/17/2017 01:19 PM, Thomas Schwinge wrote: Hi! On Mon, 16 Oct 2017 10:49:45 +0200, Tom de Vries  wrote: this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks! ---

Re: [PATCH PR/82546] tree node size

2017-10-17 Thread Richard Biener
On Tue, 17 Oct 2017, Nathan Sidwell wrote: > On 10/17/2017 05:26 AM, Richard Biener wrote: > > > Sorry for not looking at the patch before replying. The patch looks ok > > but shouldn't LANG_TYPE be also handled by the FE? LANG_TYPE itself > > is an odd beast if I may say that - it's only used

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Jakub Jelinek
On Tue, Oct 17, 2017 at 04:42:58PM +0200, Tom de Vries wrote: > I found the culprit, in gfortran-dg-runtest: > ... > # look if this is dg-do-run test, in which case > > # we cycle through the option list, otherwise we don't > > if [expr [search_for $test "dg-do run"]] { >

[PATCH PR82574]Check that datref must be executed exactly once per iteration against outermost loop in nest

2017-10-17 Thread Bin Cheng
Hi, The patch fixes ICE reported in PR82574. In order to distribute builtin partition, we need to check that data reference must be executed exactly once per iteration. In distribution for loop nest, this has to be checked against each loop in the nest. One optimization can be done is we

Re: [patch][arm] gcc-7-branch: Fix bootstrap on FreeBSD

2017-10-17 Thread Andreas Tobler
Hi Kyrill, On 17.10.17 12:02, Kyrill Tkachov wrote: On 16/10/17 20:00, Andreas Tobler wrote: Hi all, I struggled over a bootstrap issue while building gcc-7 for armv7-*-freebsd* I got a 'permission denied' while creating the arm-tables.opt file. The source tree is located on a nfs server.

Re: [patch] Relax IVOPTs restriction on auto-increment

2017-10-17 Thread Richard Biener
On Tue, Oct 17, 2017 at 9:45 AM, Eric Botcazou wrote: > Hi, > > add_autoinc_candidates begins with this test: > > /* If we insert the increment in any position other than the standard > ones, we must ensure that it is incremented once per iteration. > It must

[RFA] Zen tuning part 9: Add support for scatter/gather in vectorizer costmodel

2017-10-17 Thread Jan Hubicka
Hi, gether/scatter loads tends to be expensive (at least for x86) while we now account them as vector loads/stores which are cheap. This patch adds vectorizer cost entry for these so this can be modelled more realistically. Bootstrapped/regtested x86_64-linux, OK? Honza 2017-10-17 Jan

Re: [PATCH 2/2] S/390: Do not end groups after fallthru edge

2017-10-17 Thread Robin Dapp
> Can't we just set s390_sched_state to s390_last_sched_state in > s390_sched_init. Good idea, this simplifies the code quite a bit. > Preserving the sched state across basic blocks for your case works > only if the BBs are traversed with the fall through edges coming > first. Is that the case?

[PATCH][GRAPHITE] Fix ISL memory management issue

2017-10-17 Thread Richard Biener
The isl_union_map operations always take the existing map and return a new one but scop_get_reads_and_writes tries to operate on its parameters in-place. This fails once a re-allocation happens leading to "interesting" issues (like random segfaults with -fdump-tree-graphite-details on larger

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 01:19 PM, Thomas Schwinge wrote: Hi! On Mon, 16 Oct 2017 10:49:45 +0200, Tom de Vries wrote: this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks! --- a/libgomp/testsuite/libgomp.oacc-fortran/declare-1.f90 +++

Re: [patch][i386, AVX] GFNI enabling [3/4]

2017-10-17 Thread Jakub Jelinek
On Tue, Oct 17, 2017 at 01:09:50PM +, Koval, Julia wrote: > Hi, this the third patch of GFNI ISASET enabling. It enables GF2P8AFFINE > instruction, described here: > https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf

[patch][i386, AVX] GFNI enabling [4/4]

2017-10-17 Thread Koval, Julia
Hi, This the fourth patch of GFNI ISASET enabling. It enables GF2P8MULB instruction, described here: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf gcc/ * config/i386/gfniintrin.h (_mm_gf2p8mul_epi8,

Re: [RFA] Zen tuning part 9: Add support for scatter/gather in vectorizer costmodel

2017-10-17 Thread Richard Biener
On Tue, 17 Oct 2017, Jan Hubicka wrote: > Hi, > gether/scatter loads tends to be expensive (at least for x86) while we now > account them > as vector loads/stores which are cheap. This patch adds vectorizer cost > entry for these > so this can be modelled more realistically. > >

Re: [PATCH PR/82546] tree node size

2017-10-17 Thread Nathan Sidwell
On 10/17/2017 05:26 AM, Richard Biener wrote: Sorry for not looking at the patch before replying. The patch looks ok but shouldn't LANG_TYPE be also handled by the FE? LANG_TYPE itself is an odd beast if I may say that - it's only used by the C++ and Ada FEs and the Ada FE does only I

[patch][x86] GFNI enabling [2/4]

2017-10-17 Thread Koval, Julia
Hi, this is the second patch of enabling GFNI ISASET. It adds GF2P8AFFINEINV instruction. The instruction is described here: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf gcc/ * config.gcc: Add gfniintrin.h.

Re: [patch][arm] gcc-7-branch: Fix bootstrap on FreeBSD

2017-10-17 Thread Richard Earnshaw (lists)
On 17/10/17 14:00, Kyrill Tkachov wrote: > > On 17/10/17 13:42, Andreas Tobler wrote: >> Hi Kyrill, >> >> On 17.10.17 12:02, Kyrill Tkachov wrote: >> >> > On 16/10/17 20:00, Andreas Tobler wrote: >> >> Hi all, >> >> >> >> I struggled over a bootstrap issue while building gcc-7 for >> >>

RE: [patch][i386, AVX] GFNI enabling [4/4]

2017-10-17 Thread Koval, Julia
Fixed changelog. gcc/ * config/i386/gfniintrin.h (_mm_gf2p8mul_epi8, _mm256_gf2p8mul_epi8, _mm_mask_gf2p8mul_epi8, _mm_maskz_gf2p8mul_epi8, _mm256_mask_gf2p8mul_epi8, _mm256_maskz_gf2p8mul_epi8, _mm512_mask_gf2p8mul_epi8, _mm512_maskz_gf2p8mul_epi8,

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 04:46 PM, Jakub Jelinek wrote: On Tue, Oct 17, 2017 at 04:42:58PM +0200, Tom de Vries wrote: I found the culprit, in gfortran-dg-runtest: ... # look if this is dg-do-run test, in which case # we cycle through the option list, otherwise we don't if

[PATCH, middle-end/82577] Fix DECL_ASSEMBLER_NAME ICE

2017-10-17 Thread Nathan Sidwell
This fixes a new ICE I caused by breaking out HAS_DECL_ASSEMBLER_NAME_P from DECL_ASSEMBLER_NAME_SET_P. alias.c needs to check it. As it's doing explicit HAS and SET checking, it might as well use the RAW accessor too. Committing as obvious. nathan -- Nathan Sidwell 2017-10-17 Nathan

[C++ PATCH 82560] missing dtor call

2017-10-17 Thread Nathan Sidwell
In a 'new T(whatever)' expression, we'll never call T::~T. We used to generate such a cleanup (but then throw it away in optimization). But now dtors can be deleted, so that approach could fail. My patch for 78469 fixed that. But caused this problem. The only cleanup we should not be

Re: [PATCH] Do not put gimple stmt on an abnormal edge (PR sanitizer/82545).

2017-10-17 Thread Jakub Jelinek
On Mon, Oct 16, 2017 at 10:15:04PM +0200, Martin Liška wrote: > Hi. > > As discussed with Jakub on IRC, we should not put ASAN reporting function > on critical edges. Can that potentially lead to a missed use-after-scope, > but I guess it's very rare. > > Patch can bootstrap on

[PATCH] Canonicalize constant multiplies in division

2017-10-17 Thread Wilco Dijkstra
This patch implements some of the optimizations discussed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71026. Canonicalize x / (C1 * y) into (x * C2) / y. This moves constant multiplies out of the RHS of a division in order to allow further simplifications (such as (C1 * x) / (C2 * y) -> (C3

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Mike Stump
On Oct 17, 2017, at 8:34 AM, Tom de Vries wrote: > >>> OK, if full testing is ok? >> I believe this was fully intentional and the presence/absence of >> explicit dg-do run can then be used to decide if it should loop through >> options or not. > > I don't see an explicit

[PATCH] Canonicalize negates in division

2017-10-17 Thread Wilco Dijkstra
This patch implements some of the optimizations discussed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71026. Canonicalize x / (- y) into (-x) / y. This moves negates out of the RHS of a division in order to allow further simplifications and potentially more reciprocal CSEs. OK for commit?

Re: [patch] avoid printing leading 0 in widest_int hex dumps

2017-10-17 Thread Mike Stump
On Oct 17, 2017, at 5:18 AM, Richard Sandiford wrote: > > Aldy Hernandez writes: >> This produces confusing dumps to say the least > That's the intended behaviour though. > 0x0 -> (1 << 32) - 1 to infinite precision >

Re: [PATCH, testsuite] Add dg-require-stack-size

2017-10-17 Thread Mike Stump
On Oct 16, 2017, at 3:16 AM, Tom de Vries wrote: > > I noticed gcc.dg/tree-ssa/ldist-27.c failing for nvptx due to a too large > stack size. > OK for trunk? Hum. There is an existing mechanism (find-grep STACK_SIZE) in the tree to handle the same issue. Did you

[PATCH] Simplify floating point comparisons

2017-10-17 Thread Wilco Dijkstra
This patch implements some of the optimizations discussed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71026. Simplify (C / x > 0.0) into x > 0.0. If C is negative the comparison is reversed. Simplify (x * C1) > C2 into x > (C2 / C1). Again, if C1 is negative the comparison is reversed.

[PATCH, i386]: Do not emit x87 FP reg-stack compensation pops from output_fp_compare

2017-10-17 Thread Uros Bizjak
Hello! Currently, x87 FP stack compensation pops for FTST and FCOMIP instructions are emitted from output_fp_compare function as an assembly code. Attached patch moves detection of these two instructions to reg-stack.c and handles compensation pops during reg-stack processing. This change further

Re: [committed] Fix another tree-ssa-dse.c thinko

2017-10-17 Thread Jeff Law
On 10/16/2017 01:58 PM, Martin Liška wrote: > On 10/16/2017 07:56 PM, Jeff Law wrote: >> With this patch we get a clean bootstrap & regression test with Martin's >> latest sbitmap checking patches on x86. > > Thanks Jeff for testing. May I consider this as green for installation > of my patch? I

Re: [PATCH] Fix bitmap_bit_in_range_p (PR tree-optimization/82493).

2017-10-17 Thread Jeff Law
On 10/13/2017 07:02 AM, Martin Liška wrote: > On 10/12/2017 11:54 PM, Jeff Law wrote: >> On 10/11/2017 12:13 AM, Martin Liška wrote: >>> 2017-10-10 Martin Liska >>> >>> PR tree-optimization/82493 >>> * sbitmap.c (bitmap_bit_in_range_p): Fix the implementation. >>>

Re: [patch] avoid printing leading 0 in widest_int hex dumps

2017-10-17 Thread Andrew MacLeod
On 10/17/2017 08:18 AM, Richard Sandiford wrote: Aldy Hernandez writes: Hi folks! Calling print_hex() on a widest_int with the most significant bit turned on can lead to a leading zero being printed (0x0). This produces confusing dumps to say the least, especially

Re: [PATCH, rs6000] Add Power 8 support to vec_revb

2017-10-17 Thread Segher Boessenkool
Hi Carl, On Tue, Oct 17, 2017 at 09:56:43AM -0700, Carl Love wrote: > gcc/ChangeLog: > > 2017-10-17 Carl Love > > * config/rs6000/rs6000-c.c (P8V_BUILTIN_VEC_REVB): > Add power 8 definitions for the builtin instances. > (P9V_BUILTIN_VEC_REVB): Remove the

Re: [PATCH, rs6000] Add Power 8 support to vec_revb

2017-10-17 Thread Carl Love
GCC maintainers: I have addressed the issues with the vec_revb patch mentioned by Segher. I have retested the updated patch on: powerpc64-unknown-linux-gnu (Power 8 BE), powerpc64le-unknown-linux-gnu (Power 8 LE), powerpc64le-unknown-linux-gnu (Power 9 LE) without regressions. Please

Re: [RFA] Zen tuning part 9: Add support for scatter/gather in vectorizer costmodel

2017-10-17 Thread Jan Hubicka
> On Tue, 17 Oct 2017, Jan Hubicka wrote: > > > Hi, > > gether/scatter loads tends to be expensive (at least for x86) while we now > > account them > > as vector loads/stores which are cheap. This patch adds vectorizer cost > > entry for these > > so this can be modelled more realistically. >

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 05:34 PM, Tom de Vries wrote: On 10/17/2017 04:46 PM, Jakub Jelinek wrote: the presence/absence of explicit dg-do run can then be used to decide if it should loop through options or not. I'd be in favor of specifying this clearly, f.i. as: ... '! { dg-no-torture-options }'

[PATCH] C/C++: more stdlib header hints (PR c/81404)

2017-10-17 Thread David Malcolm
This patch depends on: * "[PATCH] c-family: add name_hint/deferred_diagnostic (v2)" * https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01021.html (waiting review) * [PATCH 3/3] C: hints for missing stdlib includes for macros and types * https://gcc.gnu.org/ml/gcc-patches/2017-07/msg00125.html

RE: [PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-10-17 Thread Michael Collison
Richard and Eric, I see you have objected and indicated the additional cost. Have you quantified how much more expensive the pass is? -Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Tuesday, October 17, 2017 4:45 AM To: Eric Botcazou

[PATCH, rs6000] 1/2 Add x86 SSE2 <emmintrin,h> intrinsics to GCC PPC64LE target

2017-10-17 Thread Steven Munroe
These is the forth major contribution of X86 intrinsic equivalent headers for PPC64LE. X86 SSE2 technology adds double float (__m128d) support, filled in a number 128-bit vector integer (__m128i) operations and added some MMX conversions to and from 128-bit vector (XMM) operations. In general

[Patch, fortran] PR82550 - program using submodules fails to link

2017-10-17 Thread Paul Richard Thomas
The attached patch has a comment that explains what is going on. Bootstrapped and regtested on FC23/x86_64 - OK for trunk and 7-branch? Paul 2017-10-17 Paul Thomas PR fortran/82550 * expr.c (gfc_check_pointer_assign): A use associated procedure target in a

Unbreak Ada bootstrap (was Re: [PATCH PR/82546] tree node size)

2017-10-17 Thread Jakub Jelinek
Hi! On Fri, Oct 13, 2017 at 02:29:40PM -0400, Nathan Sidwell wrote: > [Although I filed this as a middle-end bug, it's really a core infra bug, > not sure who the best reviewer is] > 2017-10-13 Nathan Sidwell > > PR middle-end/82546 > gcc/ > * tree.c

[RFC PATCH] Add -fsanitize=noreturn support

2017-10-17 Thread Jakub Jelinek
Hi! While we have a warning for falling through out of a noreturn function or return in such function, the actual UB occurs only if we actually return from those functions. This patch attempts to instrument it. Will need to submit the libsanitizer part upstream first though. 2017-10-17 Jakub

Re: [PATCH] Update -ffunction/data-sections documentation

2017-10-17 Thread Sandra Loosemore
On 10/15/2017 11:59 PM, Sebastian Huber wrote: gcc/ * invoke.texi (ffunction-sections and fdata-sections): Update. --- gcc/doc/invoke.texi | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi

Re: [PATCH] C/C++: more stdlib header hints (PR c/81404)

2017-10-17 Thread Joseph Myers
On Tue, 17 Oct 2017, David Malcolm wrote: > It also adds generalizes some of the code for this (and for the "std::" > namespace hints in the C++ frontend), moving it to a new > c-family/known-headers.cc and .h, and introducing a class known_headers. > This currently just works by scanning a

Re: Unbreak Ada bootstrap (was Re: [PATCH PR/82546] tree node size)

2017-10-17 Thread Richard Biener
On October 17, 2017 9:29:46 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >On Fri, Oct 13, 2017 at 02:29:40PM -0400, Nathan Sidwell wrote: >> [Although I filed this as a middle-end bug, it's really a core infra >bug, >> not sure who the best reviewer is] > >> 2017-10-13 Nathan

RE: [PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-10-17 Thread Michael Collison
Are we in agreement that I should revert the patch? -Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Tuesday, October 17, 2017 1:10 PM To: Michael Collison ; Eric Botcazou Cc: Jeff Law ;

[committed] Simplify format_warning_at_substring API

2017-10-17 Thread David Malcolm
The format_warning_at_substring API has a rather clunk way of indicating the location of the pertinent param (if any): a source_range * is passed in, which can be NULL. Doing so requires extracting a range from the location_t and passing around a pointer to it, or NULL, as needed. This patch

[v3 PATCH] Deduction guides for associative containers, debug mode deduction guide fixes.

2017-10-17 Thread Ville Voutilainen
Tested on Linux-PPC64. The debug mode fixes have been tested manually and individually on Linux-x64. 2017-10-17 Ville Voutilainen Deduction guides for associative containers, debug mode deduction guide fixes. * include/bits/stl_algobase.h (__iter_key_t)

Re: [PATCH] c-family: add name_hint/deferred_diagnostic (v2)

2017-10-17 Thread Joseph Myers
The C front-end parts of this patch are OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-10-17 Thread Eric Botcazou
> I see you have objected and indicated the additional cost. Have you > quantified how much more expensive the pass is? No, but use-def chains are known to be slow because DF is slow, see e.g. the comment located a few lines below the call to try_merge_compare: /* ??? This is one point at

RE: [PATCH][compare-elim] Merge zero-comparisons with normal ops

2017-10-17 Thread Richard Biener
On October 17, 2017 9:08:31 PM GMT+02:00, Michael Collison wrote: >Richard and Eric, > >I see you have objected and indicated the additional cost. Have you >quantified how much more expensive the pass is? DF has known quadratic behavior in memory for certain problems.

Re: Unbreak Ada bootstrap (was Re: [PATCH PR/82546] tree node size)

2017-10-17 Thread Eric Botcazou
> This change broke Ada bootstrap, because the FE doesn't have any tree_size > langhook, but has one language specific tcc_type tree - > UNCONSTRAINED_ARRAY_TYPE. There should be a requirement to test all languages for this kind of changes. > Fixed thusly, bootstrapped/regtested on x86_64-linux

[Visium] Fix build breakage

2017-10-17 Thread Eric Botcazou
The compare-elim.c change broke the build because the pass now sends all kind of junk RTXes to the select_cc_mode target hook, which was written in exact keeping with arithmetic patterns of the MD file. We now need to handle all possible RTXes on the RHS of an assignment, even calls. Tested

[PATCH] Add -fsanitize=builtin support

2017-10-17 Thread Jakub Jelinek
Hi! On Mon, Oct 16, 2017 at 08:52:50PM +0200, Jakub Jelinek wrote: > The following patch is an attempt at libsanitizer merge from upstream. > Sadly libubsan has several ABI incompatible changes, dunno if we should > fight the mess and re-add backward compatibility back, or as the patch > does

Re: [patch] avoid printing leading 0 in widest_int hex dumps

2017-10-17 Thread Richard Sandiford
Andrew MacLeod writes: > On 10/17/2017 08:18 AM, Richard Sandiford wrote: >> Aldy Hernandez writes: >>> Hi folks! >>> >>> Calling print_hex() on a widest_int with the most significant bit turned >>> on can lead to a leading zero being printed (0x0).

[patch, fortran] Fix PR 82567

2017-10-17 Thread Thomas Koenig
Hello world, this patch fixes a regression with long compile times, which came about due to our handling of array constructors at compile time. This, togeteher with a simplification in front end optimization, led to long compile times and large code. Regression-tested. OK for trunk and the

[testsuite] UnXFAIL gcc.dg/attr-alloc_size-11.c on Visium

2017-10-17 Thread Eric Botcazou
Tested on visium-elf, applied on the mainline and 7 branch. 2017-10-17 Eric Botcazou * gcc.dg/attr-alloc_size-11.c: UnXFAIL for visium-*-*. -- Eric BotcazouIndex: gcc.dg/attr-alloc_size-11.c ===

Re: [PATCH 4/9] [SFN] introduce statement frontier notes, still disabled

2017-10-17 Thread Alexandre Oliva
On Oct 13, 2017, Richard Biener wrote: > If the [SFN] is self-contained you can install that part once the approval > for the FE parts is in. It is, so I'll do that. > You can of course wait a bit for more reviews > (stopped short on LVU because of that all-targets

Re: [patch, fortran] Fix PR 79795

2017-10-17 Thread Jerry DeLisle
On 10/15/2017 11:09 AM, Thomas Koenig wrote: > Hello world, > > the attached patch fixes a regression by turning an ICE-on-invalid into > an error message (and making sure that it fits). > > Regression-tested on trunk. > > OK for all affected branches (8/7/6)? > Yes, OK, thanks. Jerry

Re: [PATCH 18/22] Enable building libmpx with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:36 PM, Tsimbalist, Igor V wrote: > Enable building libmpx with Intel CET options. > > libmpx/ > * Makefile.in: Regenerate. > * acinclude.m4: Add enable.m4 and cet.m4. > * configure: Regenerate. > * configure.ac: Set CET_FLAGS. Update XCFLAGS. > *

Re: [PATCH 10/22] Enable building libcilkrts with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:13 PM, Tsimbalist, Igor V wrote: > Enable building libcilkrts with CET options. > > libcilkrts/ > * Makefile.am: Add AM_CXXFLAGS and XCXXFLAGS. > * configure.ac: Set CET_FLAGS, update XCFLAGS, XCXXFLAGS. > * Makefile.in: Regenerate. > * aclocal.m4:

Re: [PATCH 12/22] Enable building libgomp with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:20 PM, Tsimbalist, Igor V wrote: > Enable building libgomp with CET options. > > libgomp/ > * configure.ac: Set CET_FLAGS, update XCFLAGS and FCFLAGS. > * acinclude.m4: Add cet.m4. > * configure: Regenerate. > * Makefile.in: Likewise. > *

Re: [PATCH 16/22] Enable building libssp with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:31 PM, Tsimbalist, Igor V wrote: > Enable building libssp with Intel CET options. > > libssp/ > * Makefile.am: Update AM_CFLAGS. > * Makefile.in: Regenerate. > * configure: Likewise. > * aclocal.m4: Likewise. > * configure.ac: Set CET_FLAGS. Update

Re: [PATCH 15/22] Enable building libvtv with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:29 PM, Tsimbalist, Igor V wrote: > Enable building libvtv with Intel CET options. > > libvtv/ > * acinclude.m4: Add enable.m4 and cet.m4. > * libvtv/configure: Regenerate. > * libvtv/configure.ac: Set CET_FLAGS. Update XCFLAGS. Same comments as with libcilkrts.

Re: [PATCH 19/22] Enable building libgfortran with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 03:17 PM, Tsimbalist, Igor V wrote: > Enable building libgfortran with Intel CET options. > > libgfortran/ > * acinclude.m4: Add enable.m4, cet.m4. > * configure: Regenerate. > * configure.ac: Set CET_FLAGS. Update AM_FCFLAGS, AM_CFLAGS, > CFLAGS. > Same

Re: [PATCH 17/22] Enable building libquadmath with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:34 PM, Tsimbalist, Igor V wrote: > Enable building libquadmath with Intel CET options. > > libquadmath/ > * Makefile.am: Update AM_CFLAGS. > * Makefile.in: Regenerate: > * acinclude.m4: Add enable.m4 and cet.m4. > * configure: Regenerate. > *

Re: [PATCH 14/22] Enable building libsanitizer with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:27 PM, Tsimbalist, Igor V wrote: > Enable building libsanitizer with Intel CET options. > > libsanitizer/ > * acinclude.m4: Add enable.m4 and cet.m4. > * Makefile.in: Regenerate. > * asan/Makefile.am: Update AM_CXXFLAGS. > * asan/Makefile.in: Regenerate. >

Re: [PATCH 11/22] Enable building libatomic with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 02:18 PM, Tsimbalist, Igor V wrote: > Enable building libatomic with CET options. > > libatomic/ > * configure.ac: Set CET_FLAGS, update XCFLAGS. > * acinclude.m4: Add cet.m4 and enable.m4. > * configure: Regenerate. > * Makefile.in: Likewise. > *

Re: [PATCH] C/C++: more stdlib header hints (PR c/81404)

2017-10-17 Thread Martin Sebor
On 10/17/2017 11:33 AM, David Malcolm wrote: This patch depends on: * "[PATCH] c-family: add name_hint/deferred_diagnostic (v2)" * https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01021.html (waiting review) * [PATCH 3/3] C: hints for missing stdlib includes for macros and types *

Re: [Patch, fortran] PR82550 - program using submodules fails to link

2017-10-17 Thread Jerry DeLisle
On 10/17/2017 11:33 AM, Paul Richard Thomas wrote: > The attached patch has a comment that explains what is going on. > > Bootstrapped and regtested on FC23/x86_64 - OK for trunk and 7-branch? > Yes, looks OK for both. Thanks. Jerry

Re: [patch, fortran] Fix PR 82567

2017-10-17 Thread Jerry DeLisle
On 10/17/2017 03:36 PM, Thomas Koenig wrote: > Hello world, > > this patch fixes a regression with long compile times, > which came about due to our handling of array constructors > at compile time.  This, togeteher with a simplification in > front end optimization, led to long compile times and

Re: [PATCH 20/22] Enable building libobjc with Intel CET

2017-10-17 Thread Jeff Law
On 10/12/2017 03:19 PM, Tsimbalist, Igor V wrote: > Enable building libobjc with Intel CET options. > > libobjc/ > * Makefile.in: Regenerate. > * aclocal.m4: Likeiwse. > * configure: Likewise. > * configure.ac: Set CET_FLAGS. Update XCFLAGS. > Same comments as the

Re: [patch, fortran] Fix PR 82567

2017-10-17 Thread Steve Kargl
On Tue, Oct 17, 2017 at 06:14:16PM -0700, Jerry DeLisle wrote: > On 10/17/2017 03:36 PM, Thomas Koenig wrote: > > Hello world, > > > > this patch fixes a regression with long compile times, > > which came about due to our handling of array constructors > > at compile time.  This, togeteher with a

[PATCH] enhance -Warray-bounds to handle strings and excessive indices

2017-10-17 Thread Martin Sebor
While testing my latest -Wrestrict changes I noticed a number of opportunities to improve the -Warray-bounds warning. Attached is a patch that implements a solution for the following subset of these: PR tree-optimization/82596 - missing -Warray-bounds on an out-of bounds index into string