Re: [RFC] fixincludes: vxworks: add hack around ioLib.h/unistd.h mutual inclusion

2018-06-25 Thread Rasmus Villemoes
On 2018-06-20 14:35, Martin Liška wrote: > On 06/20/2018 02:19 PM, Tom de Vries wrote: >> Hi, >> >> for make check-fixincludes I'm seeing: >> ... >> cmp: EOF on >> /home/vries/gcc_versions/devel/src/fixincludes/tests/base/ioLib.h >> *** ioLib.h 2018-06-20 14:14:40.035956737 +0200 >> --- /home/v

Re: [AArch64][PATCH 2/2] PR target/83009: Relax strict address checking for store pair lanes

2018-06-25 Thread Andre Simoes Dias Vieira
On 14/06/18 12:47, Richard Sandiford wrote: > Kyrill Tkachov writes: >> Hi Andre, >> On 07/06/18 18:02, Andre Simoes Dias Vieira wrote: >>> Hi, >>> >>> See below a patch to address PR 83009. >>> >>> Tested with aarch64-linux-gnu bootstrap and regtests for c, c++ and fortran. >>> Ran the adjusted

Re: [AArch64][PATCH 1/2] Fix addressing printing of LDP/STP

2018-06-25 Thread Andre Simoes Dias Vieira
On 18/06/18 09:08, Andre Simoes Dias Vieira wrote: > Hi Richard, > > Sorry for the delay I have been on holidays. I had a look and I think you > are right. With these changes Umq and Uml seem to have the same > functionality though, so I would suggest using only one. Maybe use a > different

Re: [PATCH] [RFC] Higher-level reporting of vectorization problems

2018-06-25 Thread Richard Biener
On Fri, 22 Jun 2018, David Malcolm wrote: > NightStrike and I were chatting on IRC last week about > issues with trying to vectorize the following code: > > #include > std::size_t f(std::vector> const & v) { > std::size_t ret = 0; > for (auto const & w: v) > ret += w.si

Re: [PATCH][AARCH64] PR target/84521 Fix frame pointer corruption with -fomit-frame-pointer with __builtin_setjmp

2018-06-25 Thread Sudakshina Das
PING! On 14/06/18 12:10, Sudakshina Das wrote: Hi Eric On 07/06/18 16:33, Eric Botcazou wrote: Sorry this fell off my radar. I have reg-tested it on x86 and tried it on the sparc machine from the gcc farm but I think I couldn't finished the run and now its showing to he unreachable. The patc

Re: [PATCH, rs6000] Add vec_extract builtin tests, fix arguments on existing tests

2018-06-25 Thread Segher Boessenkool
Hi! On Fri, Jun 22, 2018 at 08:21:35AM -0700, Carl Love wrote: > GCC Maintainers: > > The following patch adds tests for the vec_extract builtin. I also > adjusts the second argument on the existing tests so they match the > ABI, specifically an integer not a const integer. Does that make a dif

Re: [PATCH] Avoid changing DR for scatter/gather refs

2018-06-25 Thread Richard Biener
On Sun, 24 Jun 2018, Eric Botcazou wrote: > > 2018-06-21 Richard Biener > > > > * tree-data-ref.c (dr_step_indicator): Handle NULL DR_STEP. > > * tree-vect-data-refs.c (vect_analyze_possibly_independent_ddr): > > Avoid calling vect_mark_for_runtime_alias_test with gathers or scatte

Re: [PATCH 0/3][POPCOUNT]

2018-06-25 Thread Bin.Cheng
On Mon, Jun 25, 2018 at 1:50 PM, Kugan Vivekanandarajah wrote: > Hi Bin, > > On 25 June 2018 at 13:56, Bin.Cheng wrote: >> On Mon, Jun 25, 2018 at 11:37 AM, Kugan Vivekanandarajah >> wrote: >>> Hi Bin, >>> >>> Thanks for your comments. >>> >>> On 25 June 2018 at 11:15, Bin.Cheng wrote: On

Re: [PATCH], PowerPC long double transition patches, v2, Patch #1 (disable long double multilib)

2018-06-25 Thread Segher Boessenkool
On Fri, Jun 22, 2018 at 05:04:14PM -0400, Michael Meissner wrote: > Here is the patch redone to disable multilib support altogether. I verified > that without --{enable,disable}-multilib that it no longer builds a multilib > compiler. Can I install this into the trunk and to the GCC 8.x branch?

Re: [PATCH, rs6000] Fix AIX test case failures

2018-06-25 Thread Segher Boessenkool
Hi Carl, On Fri, Jun 22, 2018 at 02:55:44PM -0700, Carl Love wrote: > --- a/gcc/testsuite/gcc.target/powerpc/divkc3-2.c > +++ b/gcc/testsuite/gcc.target/powerpc/divkc3-2.c > @@ -13,4 +13,5 @@ divide (cld_t *p, cld_t *q, cld_t *r) >*p = *q / *r; > } > > -/* { dg-final { scan-assembler "bl __

Re: [PATCH 0/3][POPCOUNT]

2018-06-25 Thread Richard Biener
On Mon, Jun 25, 2018 at 11:30 AM Bin.Cheng wrote: > > On Mon, Jun 25, 2018 at 1:50 PM, Kugan Vivekanandarajah > wrote: > > Hi Bin, > > > > On 25 June 2018 at 13:56, Bin.Cheng wrote: > >> On Mon, Jun 25, 2018 at 11:37 AM, Kugan Vivekanandarajah > >> wrote: > >>> Hi Bin, > >>> > >>> Thanks for yo

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-06-25 Thread Richard Biener
On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah wrote: > > [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p This says that COND_EXPR itself isn't expensive. I think we should constrain that a bit. I think a good default would be to only allow a single COND_EXPR which you

Re: [PATCH 2/3][POPCOUNT] Check if zero check is done before entering the loop

2018-06-25 Thread Richard Biener
On Fri, Jun 22, 2018 at 11:14 AM Kugan Vivekanandarajah wrote: > > gcc/ChangeLog: The canonical way is calling simplify_using_initial_conditions on the may_be_zero condition. Richard. > 2018-06-22 Kugan Vivekanandarajah > > * tree-ssa-loop-niter.c (number_of_iterations_popcount): If popc

Re: [PATCH v2, rs6000] Backport Fix implementation of vec_pack (vector double, vector double) built-in function

2018-06-25 Thread Segher Boessenkool
On Fri, Jun 22, 2018 at 05:36:24PM -0500, Kelvin Nilsen wrote: > After waiting a few days for this newly committed patch to settle, is it ok > to backport to gcc 6, gcc 7, and gcc 8? Sure. Thanks! Segher

Re: [committed] Update OpenACC testcases

2018-06-25 Thread Rainer Orth
Hi Thomas, > On our development branch(es) we had accumulated a bunch of testcases > (updates) that should have been part of earlier patch submissions, or > were not yet pushed for unknown reasons. ... until now; in r261884, I > just committed the following to trunk: > > commit e342f300e74ee68bc4

Re: [PATCH 3/3][POPCOUNT] Remove unnecessary if condition in phiopt

2018-06-25 Thread Richard Biener
On Fri, Jun 22, 2018 at 11:16 AM Kugan Vivekanandarajah wrote: > > gcc/ChangeLog: @@ -1516,6 +1521,114 @@ minmax_replacement (basic_block cond_bb, basic_block middle_bb, return true; } +/* Convert + + + if (b_4(D) != 0) + goto vertical space before the comment. +

Re: [PATCH][3/3] Consider multiple vector sizes for vectorization based on cost

2018-06-25 Thread Richard Biener
On Fri, 22 Jun 2018, Richard Biener wrote: > > The following makes the vectorizer consider all vector sizes as advertised > by targetm.vectorize.autovectorize_vector_sizes and decide on which > vector size to use based on costs. > > Given comparing costs is difficult if you do not know the numbe

Re: [PATCH] Fix up AVX512F 128/256-bit shifts from using EVEX counts (PR target/84786)

2018-06-25 Thread Kirill Yukhin
Hello Jakub, On 22 июн 23:47, Jakub Jelinek wrote: > Hi! > > The following testcase got fixed in 8/trunk with r253924 part of > PR82370 enhancements, but that is not IMHO something we should backport. > So instead the following patch adds something simpler, use Yv constraint > for the DImode shift

Re: [PATCH] rs6000: Fix vector homogeneous aggregates (PR86197)

2018-06-25 Thread Segher Boessenkool
On Tue, Jun 19, 2018 at 10:45:59AM +, Segher Boessenkool wrote: > The existing code allows only 4 vectors worth of ieee128 homogeneous > aggregates, but it should be 8. This happens because at one spot it > is mistakenly qualified as being passed in floating point registers. > > This patch fi

[PATCH] libtool: Sort output of 'find' to enable deterministic builds.

2018-06-25 Thread Bernhard M. Wiedemann
so that gcc builds in a reproducible way in spite of indeterministic filesystem readdir order See https://reproducible-builds.org/ for why this is good. While working on the reproducible builds effort, I found that when building the gcc8 package for openSUSE, there were differences between each b

Re: [PATCH] rs6000: Fix absif2

2018-06-25 Thread Segher Boessenkool
On Mon, Jun 04, 2018 at 04:30:36PM +, Segher Boessenkool wrote: > Without this patch absif2 always FAILs. There is no testcase for > that, nor do we see it during bootstrap, but it is obvious. > > Bootstrapped and tested on powerpc64-linux {-m32,-m64}; committing > to trunk. Backported to 8

Re: [PATCH 1/4] regcprop: Avoid REG_CFA_REGISTER notes (PR85645)

2018-06-25 Thread Segher Boessenkool
Hi Eric, On Wed, May 09, 2018 at 09:22:47AM +0200, Eric Botcazou wrote: > > 2018-05-08 Segher Boessenkool > > > > PR rtl-optimization/85645 > > * regcprop.c (copyprop_hardreg_forward_1): Don't propagate into an > > insn that has a REG_CFA_REGISTER note. > > OK, thanks. Are these

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/24/2018 11:56 PM, Jan Hubicka wrote: >> Hi, >> >> [ The analysis of this PR was done at https://stackoverflow.com/a/33557963 , >> November 2015. ] >> >> This tls sequence: >> ... >> 0x00 .byte 0x66 >> 0x01 leaq x@tlsgd(%rip),%rdi >> 0x08 .word 0x >> 0x0a rex64 >> 0x0b call __tls_get_addr

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/24/2018 11:59 PM, Jan Hubicka wrote: > Hi, > searching for other occurences I see: > jan@skylake:~/trunk/gcc/config/i386> grep ASM_BYTE *md *.c > i386.md:return ASM_BYTE "0x9e"; > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); >

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Andreas Schwab
I'm still getting this error: Running /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp ... gdb used in /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp: /usr/bin/gdb ERROR: tcl error sourcing /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/gu

Fix noaddr testcase

2018-06-25 Thread Jan Hubicka
Hi, this patch prevents lto-section-out to dump section name into the dump file when noaddr or nonnumbered is used because it contains a random seed. regtested x86_64-linux, comitted. Honza * lto-section-out.c (lto_begin_section): Do not print section name for noaddr and unnumber

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Nathan Sidwell
On 06/25/2018 08:25 AM, Tom de Vries wrote: If we'd implemented something like this in gas: ... .insn .byte 0x66 .endinsn ... we could fix this more generically. Doesn't arm gas provide this functionality with some target-specific pseudo? It'd be good to copy that. ah, inst: @cindex @code

[PATCH] Fix PR86304

2018-06-25 Thread Richard Biener
Committed as obvious. Richard. 2018-06-25 Richard Biener PR tree-optimization/86304 * tree-vectorizer.c (vectorize_loops): Walk over new possibly epilogue-if-converted loops as well. Index: gcc/tree-vectorizer.c ==

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/25/2018 02:45 PM, Nathan Sidwell wrote: > On 06/25/2018 08:25 AM, Tom de Vries wrote: > >> If we'd implemented something like this in gas: >> ... >> .insn >> .byte 0x66 >> .endinsn >> ... >> we could fix this more generically. > > Doesn't arm gas provide this functionality with some target-

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Tom de Vries
On 06/25/2018 02:32 PM, Andreas Schwab wrote: > I'm still getting this error: > > Running /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp > ... > gdb used in > /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp: > /usr/bin/gdb &

Re: [PATCH, rs6000] Change word selector to prefered location for vec_insert builtin

2018-06-25 Thread Bill Schmidt
> On Jun 22, 2018, at 7:56 PM, Segher Boessenkool > wrote: > > Hi Carl, > > On Fri, Jun 22, 2018 at 07:32:47AM -0700, Carl Love wrote: >> The following patch changes the word selected when extracting the word >> from the second vector to insert into the first vector by the >> vec_insert() bui

Re: [PATCH] v3 of optinfo, remarks and optimization records

2018-06-25 Thread Richard Biener
On Wed, Jun 20, 2018 at 6:34 PM David Malcolm wrote: > > Here's v3 of the patch (one big patch this time, rather than a kit). > > Like the v2 patch kit, this patch reuses the existing dump API, > rather than inventing its own. > > Specifically, it uses the dump_* functions in dumpfile.h that don't

Re: Have g++ define _FILE_OFFSET_BITS=64 on Solaris

2018-06-25 Thread Rainer Orth
Hi Franz, > so you are supposed to use "-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64", > but at least a quick glance at the Sol10 headers shows that the additional > -D_LARGEFILE_SOURCE only makes a difference for fseeko/ftello. That still right, that's also explained in lfcompile(7). > doesn't ex

[PATCH] Fix PR86287

2018-06-25 Thread Richard Biener
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2018-06-25 Richard Biener PR tree-optimization/86287 * tree-vect-loop.c (vect_transform_loop_stmt): Fix read-after-free. diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 8e3f5f550b0..bd549

[PATCH] Fix PR86271

2018-06-25 Thread Richard Biener
The following fixes the bogus IL that does pointer extension from inlining of mismatched function args (testcase with -m32). The solution as implemented is to not inline by making fold_convertible reject the required conversion. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ri

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Andreas Schwab
On Jun 25 2018, Tom de Vries wrote: > @@ -151,6 +151,9 @@ proc report_gdb { gdb loc } { > } > set gdb [exec which $gdb] > send_log "gdb used in $loc: $gdb\n" > -set gdb_version [exec $gdb -v] > +if { [catch { set gdb_version [exec $gdb -v] }] } { > + send_log "gdb use

[PATCH] gcc_qsort: avoid overlapping memcpy (PR 86311)

2018-06-25 Thread Alexander Monakov
Hi, In PR 86311 Valgrind flags a call to memcpy with overlapping buffers. This can happen in reorder{23,45} helpers when we're reordering in-place, and the 3rd/5th element doesn't need to be moved: in that case the middle memcpy is called with source == destination. The fix is simple: just use a

Re: [PATCH] gcc_qsort: avoid overlapping memcpy (PR 86311)

2018-06-25 Thread Alexander Monakov
On Mon, 25 Jun 2018, Alexander Monakov wrote: > > In PR 86311 Valgrind flags a call to memcpy with overlapping buffers. This can > happen in reorder{23,45} helpers when we're reordering in-place, and the > 3rd/5th > element doesn't need to be moved: in that case the middle memcpy is called > with

Re: [PATCH][Middle-end][version 3]2nd patch of PR78809 and PR83026

2018-06-25 Thread Qing Zhao
> On Jun 22, 2018, at 11:49 PM, Jeff Law wrote: > > On 05/29/2018 06:08 PM, Qing Zhao wrote: >> Hi, Jeff, >> >> Thanks a lot for your review and comments. >> >> I have updated my patch based on your suggestion, and retested this whole >> patch on both X86 and aarch64. >> >> please take a lo

[PATCH, rs6000] don't use unaligned vsx for memset of less than 32 bytes

2018-06-25 Thread Aaron Sawdey
In gcc 8 I added support for unaligned vsx in the builtin expansion of memset(x,0,y). Turns out that for memset of less than 32 bytes, this doesn't really help much, and it also runs into an egregious load-hit- store case in CPU2006 components gcc and hmmer. This patch reverts to the previous (gcc

[PATCH] Fix to [-Wmissing-field-initializers] in libatomic/config/posix/lock.c:58

2018-06-25 Thread U.Mutlu
When building with "... -g0 -DNDEBUG -Wall -Wextra -Wpedantic" then the following error happens: ../../../gcc_trunk/libatomic/config/posix/lock.c: At top level: ../../../gcc_trunk/libatomic/config/posix/lock.c:58:3: warning: missing initializer for field 'pad' of 'struct lock' [-Wmissing-field-

[committed] Fix v850e divmodhi4 and udivmodhi4

2018-06-25 Thread Jeff Law
Discovered when analyzing testresults for the v850. There's two bugs lurking in those patterns. The most serious is the divmodhi4 pattern. It takes a 32bit dividend and divides it by the low 16 bits of the divisor. However, being a HImode pattern, we've assumed the upper 16 bits of the divisor

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Tom de Vries
On 06/25/2018 04:36 PM, Andreas Schwab wrote: > On Jun 25 2018, Tom de Vries wrote: > >> @@ -151,6 +151,9 @@ proc report_gdb { gdb loc } { >> } >> set gdb [exec which $gdb] >> send_log "gdb used in $loc: $gdb\n" >> -set gdb_version [exec $gdb -v] >> +if { [catch { set gdb_v

Re: Have g++ define _FILE_OFFSET_BITS=64 on Solaris

2018-06-25 Thread Franz Sirl
Am 2018-06-25 um 15:57 schrieb Rainer Orth: Hi Franz, so you are supposed to use "-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64", but at least a quick glance at the Sol10 headers shows that the additional -D_LARGEFILE_SOURCE only makes a difference for fseeko/ftello. That still right, that's als

[PATCH] Add experimental::sample and experimental::shuffle from N4531

2018-06-25 Thread Jonathan Wakely
The additions to were added in 2015 but the new algorithms in were not. This adds them. * include/experimental/algorithm (sample, shuffle): Add new overloads using per-thread random number engine. * testsuite/experimental/algorithm/sample.cc: Simpify and reduce d

Re: [PATCH] gcc_qsort: avoid overlapping memcpy (PR 86311)

2018-06-25 Thread Richard Biener
On June 25, 2018 4:52:43 PM GMT+02:00, Alexander Monakov wrote: >On Mon, 25 Jun 2018, Alexander Monakov wrote: >> >> In PR 86311 Valgrind flags a call to memcpy with overlapping buffers. >This can >> happen in reorder{23,45} helpers when we're reordering in-place, and >the 3rd/5th >> element doe

Re: [PATCH] Add experimental::sample and experimental::shuffle from N4531

2018-06-25 Thread Jonathan Wakely
On 25/06/18 17:23 +0100, Jonathan Wakely wrote: The additions to were added in 2015 but the new algorithms in were not. This adds them. * include/experimental/algorithm (sample, shuffle): Add new overloads using per-thread random number engine. * testsuite/experimental/

[PATCH] PR libstdc++/86292 fix exception safety of std::vector constructor

2018-06-25 Thread Jonathan Wakely
PR libstdc++/86292 * include/bits/stl_vector.h (vector::_M_range_initialize): Add try-catch block. * testsuite/23_containers/vector/cons/86292.cc: New. Tested x86_64-linux, committed to trunk. commit 541662d2c8d2633f2140e434cdaadcf36b8db282 Author: Jonathan Wakely

Invert sense of NO_IMPLICIT_EXTERN_C

2018-06-25 Thread Nathan Sidwell
NO_IMPLICIT_EXTERN_C was introduced to tell the compiler that it didn't need to fake up 'extern "C" { ... }' around system header files. Over the years more and more system headers have become C++-aware, leading to more targets defining this macro. Unfortunately because of the sense of this m

Re: [PATCH, rs6000] Fix AIX test case failures

2018-06-25 Thread Carl Love
On Mon, 2018-06-25 at 04:44 -0500, Segher Boessenkool wrote: > Hi Carl, > > On Fri, Jun 22, 2018 at 02:55:44PM -0700, Carl Love wrote: > > --- a/gcc/testsuite/gcc.target/powerpc/divkc3-2.c > > +++ b/gcc/testsuite/gcc.target/powerpc/divkc3-2.c > > @@ -13,4 +13,5 @@ divide (cld_t *p, cld_t *q, cld_t

Re: [PATCH] gcc_qsort: avoid overlapping memcpy (PR 86311)

2018-06-25 Thread Alexander Monakov
On Mon, 25 Jun 2018, Richard Biener wrote: >> Sigh - I see GCC optimizes memmove as well as memcpy in this case, so >> changing the offending memcpy calls to memmoves would be a bit cleaner. OK to >> go with this instead? > > I think that's better. Or conditionalizing the offending ones on dest! =

Re: [PATCH] Remove -Wunsafe-loop-optimizations option (PR middle-end/86095)

2018-06-25 Thread NightStrike
On Fri, Jun 15, 2018 at 3:08 PM, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, all traces of this warning option except these > were removed earlier, so the warning option does nothing. This is unfortunate. As noted here: https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01057.html The wa

Re: [PATCH, rs6000] Fix AIX test case failures

2018-06-25 Thread Segher Boessenkool
On Mon, Jun 25, 2018 at 09:53:17AM -0700, Carl Love wrote: > On Mon, 2018-06-25 at 04:44 -0500, Segher Boessenkool wrote: > > On Fri, Jun 22, 2018 at 02:55:44PM -0700, Carl Love wrote: > > > --- a/gcc/testsuite/gcc.target/powerpc/divkc3-2.c > > > +++ b/gcc/testsuite/gcc.target/powerpc/divkc3-2.c >

Backports to 6.5

2018-06-25 Thread Jakub Jelinek
Hi! I've backported 75 commits from 7.x branch to 6.x, bootstrapped/regtested them on x86_64-linux and i686-linux and committed to gcc-6-branch. Jakub 2018-06-25 Jakub Jelinek Backported from mainline 2017-09-27 Jakub Jelinek PR c++/82159 * gimplify

Re: [patch, fortran] Handling of .and. and .or. expressions

2018-06-25 Thread Janus Weil
Hi Thomas, hi all, I'm back from holidays and have more time to deal with this now ... 2018-06-17 0:38 GMT+02:00 Janus Weil : > > Am 16. Juni 2018 23:14:08 MESZ schrieb Thomas Koenig : >>In my patch, I have tried to do all three things at the same time, and >>after this discussion, I still think

Re: [PATCH 1/4] regcprop: Avoid REG_CFA_REGISTER notes (PR85645)

2018-06-25 Thread Eric Botcazou
> Are these patches okay for backport to 8? At least the first two. If they fulfill the criteria for a release branch, no objection by me. -- Eric Botcazou

Re: [PATCH] config/abi/post/x86_64-linux-gnu/baseline_symbols.txt: Update.

2018-06-25 Thread Jonathan Wakely
On 21/06/18 21:39 +0100, Jonathan Wakely wrote: Apparently we never updated the x86_64-linux-gnu baseline for gcc-8 (so now that I'm trying to add a new symbol version on trunk, I'm seeing errors for the get_entropy symbol added in the previous symbol version). The same change is needed for ppc

Re: [PATCH] avoid using strnlen result for late calls to strlen (PR 82604)

2018-06-25 Thread Martin Sebor
On 06/22/2018 04:00 PM, Jeff Law wrote: On 06/18/2018 01:15 PM, Martin Sebor wrote: While looking into opportunities to detect strnlen/strlen coding mistakes (pr86199) I noticed a bug in the strnlen implementation I committed earlier today that lets a strnlen() result be saved and used in subseq

[PATCH] PR libstdc++/86112 fix printers for Python 2.6

2018-06-25 Thread Jonathan Wakely
Dict comprehensions are only supported since Python 2.7, so use an alternative syntax that is backwards compatible. PR libstdc++/86112 * python/libstdcxx/v6/printers.py (add_one_template_type_printer): Replace dict comprehension. Tested x86_64-linux, committed to trunk.

Re: [PATCH] PR libstdc++/86112 fix printers for Python 2.6

2018-06-25 Thread Jonathan Wakely
On 25/06/18 22:03 +0100, Jonathan Wakely wrote: Dict comprehensions are only supported since Python 2.7, so use an alternative syntax that is backwards compatible. PR libstdc++/86112 * python/libstdcxx/v6/printers.py (add_one_template_type_printer): Replace dict comprehen

Re: [PATCH/RFC] enable -Wstrict-prototypes (PR 82922)

2018-06-25 Thread Martin Sebor
On 06/22/2018 11:19 AM, Joseph Myers wrote: On Thu, 21 Jun 2018, Eric Gallager wrote: On 6/21/18, Jeff Law wrote: On 06/12/2018 11:21 AM, Joseph Myers wrote: On Tue, 12 Jun 2018, Martin Sebor wrote: The proposal to enable -Wstrict-prototypes discussed below was considered too late for GCC

Re: [PATCH 1/4] regcprop: Avoid REG_CFA_REGISTER notes (PR85645)

2018-06-25 Thread Jeff Law
On 06/25/2018 05:53 AM, Segher Boessenkool wrote: > Hi Eric, > > On Wed, May 09, 2018 at 09:22:47AM +0200, Eric Botcazou wrote: >>> 2018-05-08 Segher Boessenkool >>> >>> PR rtl-optimization/85645 >>> * regcprop.c (copyprop_hardreg_forward_1): Don't propagate into an >>> insn that h

Re: [PATCH 1/2] Untangle stddef.h a little

2018-06-25 Thread Jeff Law
On 06/24/2018 05:19 PM, Gerald Pfeifer wrote: > On Tue, 19 Jun 2018, Joseph Myers wrote: >> These two patches are OK, please commit. > > I created ChangeLog entries and committed both patches (one a few > days ago, the second just now). > > Thank you, Maya! If you have any further clean-ups, I

GCC 6 patch RFA: libgo: Remove syscall.Ustat

2018-06-25 Thread Ian Lance Taylor
Since it looks like there might be a 6.5 release, here is backport of https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01420.html to GCC 6 branch. This removes the syscall.Ustat function from libgo, since the ustat function is being removed from new versions of glibc. Bootstrapped and ran Go tests

Re: GCC 6 patch RFA: libgo: Remove syscall.Ustat

2018-06-25 Thread Jakub Jelinek
On Mon, Jun 25, 2018 at 03:02:02PM -0700, Ian Lance Taylor wrote: > Since it looks like there might be a 6.5 release, here is backport of Yes, 6.5 is going to be the last release from the gcc-6-branch. > https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01420.html > > to GCC 6 branch. This removes

[PR Fortran/83183] Fix infinite recursion (ICE) with -finit-derived when initializing allocatable BT_DERIVED components

2018-06-25 Thread Fritz Reese
All, The attached patch fixes PR 83183. Previously, attempting to generate initializers for allocatable components of the same derived type triggered infinite recursion. Passes regression tests. OK for trunk and gcc-8-branch? >From 01961cc78b8ecd5272521098ae3166516a49dcd1 Mon Sep 17 00:00:00 2001

Go patch committed: Escape analysis improvements

2018-06-25 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang adds some escape analysis improvements to the Go frontend. These are based on earlier patches to the gc compiler. - https://golang.org/cl/99335: unnamed receiver should not escape. - https://golang.org/cl/105257: propagate loop depth to field. This p

[C++ Patch] More location fixes to grokdeclarator

2018-06-25 Thread Paolo Carlini
Hi, this includes straightforward tweaks to check_concept_fn and quite a bit of additional work on grokdeclarator: most of it is also rather straightforward. In a few places there is the subtlety that we want to handle together ds_storage_class and ds_thread, whichever location is the smalles

[committed] Fix v850e3v5 recipf and rsqrt issues

2018-06-25 Thread Jeff Law
Code in optabs.c for directly expanding some operations checks the number of operands in the expander/named pattern against the expected number of operands. If they do not match an ICE is triggered. /* Try to generate instruction ICODE, using operands [OPS, OPS + NOPS) as its operands. Retu

[PATCH] Fix bootstrap failure in vect_analyze_loop

2018-06-25 Thread David Malcolm
I ran into this bootstrap failure (with r262092): ../../../src/gcc/tree-vect-loop.c: In function ‘_loop_vec_info* vect_analyze_loop(loop*, loop_vec_info, vec_info_shared*)’: ../../../src/gcc/tree-vect-loop.c:1946:25: error: ‘n_stmts’ may be used uninitialized in this function [-Werror=maybe-unin

Re: [PR Fortran/83183] Fix infinite recursion (ICE) with -finit-derived when initializing allocatable BT_DERIVED components

2018-06-25 Thread Steve Kargl
On Mon, Jun 25, 2018 at 06:06:13PM -0400, Fritz Reese wrote: > > The attached patch fixes PR 83183. Previously, attempting to generate > initializers for allocatable components of the same derived type > triggered infinite recursion. Passes regression tests. OK for trunk > and gcc-8-branch? > >

Re: Invert sense of NO_IMPLICIT_EXTERN_C

2018-06-25 Thread David Edelsohn
On Mon, Jun 25, 2018 at 12:48 PM Nathan Sidwell wrote: > > NO_IMPLICIT_EXTERN_C was introduced to tell the compiler that it didn't > need to fake up 'extern "C" { ... }' around system header files. Over > the years more and more system headers have become C++-aware, leading to > more targets defi

[committed] v850 logical_op_short_circuit

2018-06-25 Thread Jeff Law
v850 should be marked as logical_op_short_circuit for testing purposes but wasn't. Fix fixes about a dozen testsuite failures per multilib. Installed on the trunk. Jeff commit 2224de3ea8b9b4381b07fcb96a2cde9266ead611 Author: law Date: Tue Jun 26 05:19:15 2018 + * lib/target-s

Re: fix libcc1 dependencies in toplevel Makefile

2018-06-25 Thread Alexandre Oliva
On Jun 11, 2018, Alexandre Oliva wrote: > On Jun 3, 2018, Alexandre Oliva wrote: >> On Jun 27, 2017, Alexandre Oliva wrote: > 1. address the previously-mentioned fragility in the patch I posted, to > catch all cases of postbootstrap targets and their deps on > non-postbootstrap targets. This

[committed] v850, default to bigger switch tables

2018-06-25 Thread Jeff Law
So many many years ago when I first wrote the v850 port I included the ability to have entries in switch jump tables be either 16 or 32 bits wide. With the default being 16 bits. In retrospect that was a mistake. The silent failures when the entries overflow is just too painful. This patch cha

Re: [PATCH] Remove -Wunsafe-loop-optimizations option (PR middle-end/86095)

2018-06-25 Thread Richard Biener
On Mon, 25 Jun 2018, NightStrike wrote: > On Fri, Jun 15, 2018 at 3:08 PM, Jakub Jelinek wrote: > > Hi! > > > > As mentioned in the PR, all traces of this warning option except these > > were removed earlier, so the warning option does nothing. > > This is unfortunate. As noted here: > > https