std::vector fix & enhancements

2018-10-30 Thread François Dumont
Following Marc Glisse change to ignore _M_start offset I wanted to go a little step further and just remove it in _GLIBCXX_INLINE_VERSION mode. I also fix a regression we already fixed on mainstream std::vector regarding noexcept qualification of move constructor with allocator. And I

RE: [PATCH][GCC][mingw-w64][Ada] Fix Ada native bootstrap (PR81878).

2018-10-30 Thread Tamar Christina
Hi Eric, > -Original Message- > From: Eric Botcazou > Sent: Friday, October 26, 2018 11:20 > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; char...@adacore.com; > dero...@adacore.com > Subject: Re: [PATCH][GCC][mingw-w64][Ada] Fix Ada native bootstrap > (PR81878). > > > Due to

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-30 Thread Jakub Jelinek
On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: > +hashtab_chk_error () > +{ > + fprintf (stderr, "hash table checking failed: " > +"equal operator returns true for a pair " > +"of values with a different hash value"); BTW, either use internal_error here, or at

hash-table violation in gcc/fortran/trans-decl.c

2018-10-30 Thread Martin Liška
On 10/29/18 12:04 PM, Martin Liška wrote: > 2) gfc_find_module > > $ ./xgcc -B. > /home/marxin/Programming/gcc/gcc/testsuite/gfortran.dg/coarray/alloc_comp_2.f90 > -fcoarray=single -fchecking=3 > hash table checking failed: equal operator returns true for a pair of values > with a different

Re: [Patch, regrename] Fix PR87330 : ICE in scan_rtx_reg, at regrename.c

2018-10-30 Thread Sameera Deshpande
On Tue, 9 Oct 2018 at 04:08, Eric Botcazou wrote: > > > Other notes need not be changed, as they don't hold renamed register > > information. > > > > Ok for trunk? > > No, REG_DEAD & REG_UNUSED note must be recomputed by passes consuming them. > > > 2018-10-09 Sameera Deshpande > > > *

Re: Add a loop versioning pass

2018-10-30 Thread Richard Biener
(sorry for breaking threading -- I composed a review mail offline but gmail has no way of nicely sending that neither has it a way to bounce messages...) > This patch adds a pass that versions loops with variable index strides > for the case in which the stride is 1. E.g.: > > for (int i

hash-table violation in gcc/cp/pt.c

2018-10-30 Thread Martin Liška
On 10/29/18 12:04 PM, Martin Liška wrote: > 3) lookup_template_class_1 > > $ ./xg++ -B. > /home/marxin/Programming/gcc/gcc/testsuite/g++.dg/template/ttp23.C -c > -fchecking=3 > hash table checking failed: equal operator returns true for a pair of values > with a different hash >

Re: hash-table violation in gcc/cp/pt.c

2018-10-30 Thread Martin Liška
On 10/30/18 11:25 AM, Martin Liška wrote: > On 10/29/18 12:04 PM, Martin Liška wrote: >> 3) lookup_template_class_1 >> >> $ ./xg++ -B. >> /home/marxin/Programming/gcc/gcc/testsuite/g++.dg/template/ttp23.C -c >> -fchecking=3 >> hash table checking failed: equal operator returns true for a pair of

Re: [Patch, regrename] Fix PR87330 : ICE in scan_rtx_reg, at regrename.c

2018-10-30 Thread Richard Earnshaw (lists)
On 30/10/2018 10:09, Sameera Deshpande wrote: > On Tue, 9 Oct 2018 at 04:08, Eric Botcazou wrote: >> >>> Other notes need not be changed, as they don't hold renamed register >>> information. >>> >>> Ok for trunk? >> >> No, REG_DEAD & REG_UNUSED note must be recomputed by passes consuming them. >>

[patch] Don't allow the pool allocator to be configured to allocate zero-sized objects

2018-10-30 Thread Richard Earnshaw (lists)
PR bootstrap/87747 would have been significantly easier to track down if the pool allocator had faulted an attempt to configure it to allocate zero-sized objects. Instead, this slipped through and we later hit memory corruption when the assumed size turned out to be different to the configured

Re: [PATCH, GCC/ARM, ping3] Fix PR87374: ICE with -mslow-flash-data and -mword-relocations

2018-10-30 Thread Thomas Preudhomme
Ping? Best regards, Thomas On Tue, 23 Oct 2018 at 10:10, Thomas Preudhomme wrote: > > Ping? > > Best regards, > > Thomas > > On Mon, 15 Oct 2018 at 16:01, Thomas Preudhomme > wrote: > > > > Ping? > > > > Best regards, > > > > Thomas > > On Fri, 5 Oct 2018 at 17:50, Thomas Preudhomme > >

Re: [AArch64] Add Saphira pipeline description.

2018-10-30 Thread Sameera Deshpande
On Fri, 26 Oct 2018 at 13:33, Sameera Deshpande wrote: > > Hi! > > Please find attached the patch to add a pipeline description for the > Qualcomm Saphira core. It is tested with a bootstrap and make check, > with no regressions. > > Ok for trunk? > > gcc/ > Changelog: > > 2018-10-26 Sameera

Re: [Patch, regrename] Fix PR87330 : ICE in scan_rtx_reg, at regrename.c

2018-10-30 Thread Sameera Deshpande
On Tue, 30 Oct 2018 at 16:16, Richard Earnshaw (lists) wrote: > > On 30/10/2018 10:09, Sameera Deshpande wrote: > > On Tue, 9 Oct 2018 at 04:08, Eric Botcazou wrote: > >> > >>> Other notes need not be changed, as they don't hold renamed register > >>> information. > >>> > >>> Ok for trunk? > >>

Fix D compilation on Solaris

2018-10-30 Thread Rainer Orth
I just tried building D on Solaris 11/SPARC and x86 and ran into a couple of issues. The following patch is at least enough to have the build finish on Solaris 11/x86, but on SPARC d21 runs into several BUS errors (probably due to alignment issues). One comment up front: I believe it would be

Re: [PATCH] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ilya Leoshkevich
> Am 29.10.2018 um 19:45 schrieb Ulrich Weigand : > > Ilya Leoshkevich wrote: > >> >> UNSPEC_LTREF and friends are necessary in order to communicate the >> dependency on the base register to pass_sched2. When LARL is used, no >> base register is necessary, so in such cases the rewrite must

Re: Turn complete to incomplete types in free_lang_data

2018-10-30 Thread Richard Biener
On Mon, 29 Oct 2018, Jan Hubicka wrote: > Hi, > this is cleaner version of the patch. During weekend I did some tests with > firefox, libreoffice and gcc builds and it seems to work well. For firefox > it reaches almost linear scalability of the ltrans files (they are 1.9GB, > after increasing

[PATCH] PR libstdc++/87784 fix dynamic_bitset::push_back

2018-10-30 Thread Jonathan Wakely
Previously the _M_Nb member was incremented before calling _M_unchecked_set which meant that the bit being set was out of bounds. It either set the wrong bit in an allocated word, or accessed beyond the end of the allocated memory in the _M_w vector. The fix for the bug is to update the _M_Nb

[PATCH v2] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ilya Leoshkevich
Bootstrapped and regtested on s390x-redhat-linux. Changes since v1: * Removed unnecessary gen_rtx_CONST call. * UNSPEC_LTREF are now omitted for all relatively addressed pool entries, and not only those which occur in LARL-like patterns. r265490 allowed the compiler to choose in a more

Re: [PATCH] Fix bug 86293

2018-10-30 Thread Jeff Law
On 10/29/18 10:39 PM, Nicholas Krause wrote: > This fixes the bug on the gcc bugzilla with id, 86293. Basically > a variable is undefined in certain build configuration scentarios > and must be enabled with the attribute marco and the flag, unused > for it to avoid this build error. Build and

Re: Ping: [PATCH, testsuite]: check for weak support

2018-10-30 Thread Paul Koning
> On Oct 30, 2018, at 10:17 AM, Jeff Law wrote: > > On 10/30/18 6:55 AM, Paul Koning wrote: >> Ping. Ok to commit? >> >> paul >> >>> On Oct 25, 2018, at 2:57 PM, Paul Koning wrote: >>> >>> I ran into a failures due to no weak symbol support in my target. This >>> patch cures that.

Re: [PATCH] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ulrich Weigand
Ilya Leoshkevich wrote: > Am 29.10.2018 um 19:45 schrieb Ulrich Weigand : > > > This is true. But something else must still be going on here. Note that > > many other instruction patterns might contain constant pool addresses, > > since they are accepted e.g. by the 'b' constraint. In all of

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Stafford Horne
On Sun, Oct 28, 2018 at 01:56:29AM +, Richard Henderson wrote: > On 10/27/18 5:37 AM, Stafford Horne wrote: > > +(define_insn "zero_extendhisi2" > > + [(set (match_operand:SI 0 "register_operand""=r,r") > > + (zero_extend:SI (match_operand:HI 1 "nonimmediate_operand"

[PATCH] Fix __builtin_expect_with_probability documentation

2018-10-30 Thread Jonathan Wakely
* doc/extend.texi: Fix prototype and description of __builtin_expect_with_probability. Committed to trunk, as discussed on the gcc list. commit 9fb8a9f94f673e7dd12b3a625829db6caaeab99e Author: Jonathan Wakely Date: Tue Oct 30 12:15:14 2018 + Fix

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-30 Thread Martin Liška
On 10/30/18 11:03 AM, Jakub Jelinek wrote: > On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >> +hashtab_chk_error () >> +{ >> + fprintf (stderr, "hash table checking failed: " >> + "equal operator returns true for a pair " >> + "of values with a different hash value");

Re: Fix D compilation on Solaris

2018-10-30 Thread Rainer Orth
Rainer Orth writes: > * On sparc, I didn't get that far, unfortunately: as I mentioned, many > compilations die with SIGBUS: > > libtool: compile: /var/gcc/regression/trunk/11.5-gcc/build/./gcc/gdc > -B/var/gcc/regression/trunk/11.5-gcc/build/./gcc/ > -B/vol/gcc/sparc-sun-solaris2.11/bin/

[PATCH] PR libstdc++/87809 avoid invalid expressions in exception specifications

2018-10-30 Thread Jonathan Wakely
If the allocator isn't default constructible then checking if the default constructor throws in an exception specification makes the declaration invalid. Use the type trait instead. PR libstdc++/87809 * include/bits/forward_list.h (_Fwd_list_impl::_Fwd_list_impl()): Use

Re: Ping: [PATCH, testsuite]: check for weak support

2018-10-30 Thread Jeff Law
On 10/30/18 6:55 AM, Paul Koning wrote: > Ping. Ok to commit? > > paul > >> On Oct 25, 2018, at 2:57 PM, Paul Koning wrote: >> >> I ran into a failures due to no weak symbol support in my target. This >> patch cures that. Is it right? The test case uses "weakref" so I' not 100% >>

Ping: [PATCH, testsuite]: check for weak support

2018-10-30 Thread Paul Koning
Ping. Ok to commit? paul > On Oct 25, 2018, at 2:57 PM, Paul Koning wrote: > > I ran into a failures due to no weak symbol support in my target. This patch > cures that. Is it right? The test case uses "weakref" so I' not 100% sure > that checking for "weak" support is correct.

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Stafford Horne
Hello, On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Oct 29, 2018 at 06:47:23AM +0900, Stafford Horne wrote: > > On Sat, Oct 27, 2018 at 09:57:30PM -0500, Segher Boessenkool wrote: > > > > +/* Helper for defining INITIAL_ELIMINATION_OFFSET. > > > > + We

[PATCH] Fix PRs70359/86270

2018-10-30 Thread Richard Biener
This picks up work from earlier this year where Aldy worked on undoing forwprop during out-of-SSA to improve coalescing across backedges. The following patch first rectifies the existing code which is meant to insert necessary copies in places where it then allows coalescing and thus avoids

[PATCH] Simplify replace_trapping_overflow

2018-10-30 Thread Richard Biener
Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2018-10-30 Richard Biener * tree-eh.c (replace_trapping_overflow): Simplify ABS_EXPR case using ABSU_EXPR. diff --git a/gcc/tree-eh.c b/gcc/tree-eh.c index 1c7d9dc1d59..046405b8a15 100644 --- a/gcc/tree-eh.c

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-10-30 Thread Jeff Law
On 10/29/18 5:51 PM, Martin Sebor wrote: > The missing nul detection fails when the argument of the %s or > similar sprintf directive is the address of a non-nul character > constant such as in: > >   const char c = 'a'; >   int f (void) >   { > return snprintf (0, 0, "%s", ); >   } > > This 

Re: [PATCH] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ulrich Weigand
Ilya Leoshkevich wrote: > Am 30.10.2018 um 16:20 schrieb Ulrich Weigand : > > Not sure that this is fully correct either. *Some* instructions, like > > e.g. floating-point loads, do not accept relative operands. And even > > for the relative loads that exist, there may be slightly different > >

Re: [PATCH v2] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ulrich Weigand
Ilya Leoshkevich wrote: > @@ -8223,6 +8237,18 @@ find_constant_pool_ref (rtx x, rtx *ref) >&& XINT (x, 1) == UNSPECV_POOL_ENTRY) > return; > > + if (SYMBOL_REF_P (x) > + && CONSTANT_POOL_ADDRESS_P (x) > + && s390_symbol_larl_p (x)) > +{ > + if (*ref == NULL_RTX)

Re: [PATCH][rs6000] use index form addresses more often for ldbrx/stdbrx

2018-10-30 Thread Segher Boessenkool
On Tue, Oct 30, 2018 at 10:22:48AM -0500, Aaron Sawdey wrote: > I had to make one more change to make this actually work. In > rs6000_force_indexed_or_indirect_mem() it was necessary to > return the updated rtx. Yes, that probably work better ;-) > Bootstrap/regtest passes on ppc64le (power7,

Remove duplicate line in gcov's output

2018-10-30 Thread Eric Botcazou
...coming from a duplicate line in gcov's source code. Tested on x86_64-suse-linux, applied on mainline as obvious. 2018-10-30 Eric Botcazou * gcov.c (output_lines): Remove duplicate line. -- Eric BotcazouIndex: gcov.c

Re: [PATCH, testsuite, c-compat] Handle another c/l option not recognised by older GCC or clang.

2018-10-30 Thread Mike Stump
On Oct 29, 2018, at 12:53 PM, Iain Sandoe wrote: > > When using ALT_CC/CXX_UNDER_TEST in the compat/struct-layout-1 tests, the c/l > options provided to the “alt” compiler need to avoid latest and greatest GCC > capability. The patch tests to see if the ‘alt’ compiler can handle >

[PATCH 1/2] asm qualifiers (PR55681)

2018-10-30 Thread Segher Boessenkool
PR55681 observes that currently only one qualifier is allowed for inline asm, so that e.g. "volatile asm" is allowed, "const asm" is also okay (with a warning), but "const volatile asm" gives an error. Also "const const asm" is an error (while "const const int" is okay for C), "goto" has to be

[PATCH 0/2] asm qualifiers (PR55681) and asm input

2018-10-30 Thread Segher Boessenkool
Hi! This is the same "asm input" patch as before, but now preceded by a patch that makes all orderings of volatile/goto/inline valid, also the other type qualifiers for C, and also repetitions for C. Tested on powerpc64-linux {-m32,-m64}. Is this okay for trunk? Segher gcc/c/c-parser.c

Re: [PATCH 2/2] asm inline

2018-10-30 Thread Marek Polacek
On Tue, Oct 30, 2018 at 05:30:34PM +, Segher Boessenkool wrote: > --- a/gcc/c/c-typeck.c > +++ b/gcc/c/c-typeck.c > @@ -10064,7 +10064,7 @@ build_asm_stmt (tree cv_qualifier, tree args) > are subtly different. We use a ASM_EXPR node to represent this. */ > tree > build_asm_expr

Re: [doc PATCH] clarify attribute optimize and target syntax

2018-10-30 Thread Jeff Law
On 10/25/18 12:35 PM, Martin Sebor wrote: > While testing the optimize and target attributes and comparing > the results to what the manual describes I noticed that some > syntactic forms aren't fully documented for both attributes. > Specifically, the optimize attribute doesn't mention that each

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Richard Henderson
On 10/30/18 12:18 PM, Stafford Horne wrote: > OK, I was just being lazy allowing the spill. Do you think the split/expand > would be an RTL using left shift / right shift? Can you think of something > more clever? Since "real" hardware does not usually support shifts with an > immediate we will

Re: [PATCH] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ilya Leoshkevich
> Am 30.10.2018 um 16:20 schrieb Ulrich Weigand : > > Ilya Leoshkevich wrote: >> Am 29.10.2018 um 19:45 schrieb Ulrich Weigand : >> >>> This is true. But something else must still be going on here. Note that >>> many other instruction patterns might contain constant pool addresses, >>>

Re: [PATCH/AARCH64] Add OcteonTX for -mcpu=

2018-10-30 Thread Richard Earnshaw (lists)
On 30/10/2018 17:06, Andrew Pinski wrote: > Hi all, > There was a name change of the Products, ThunderX T81 and ThunderX > T83 to OcteonTX family name. This change was done a few years ago but > I had not submmitted the change at that time. This is also the first > patch in a series to add

[PATCH 2/2] asm inline

2018-10-30 Thread Segher Boessenkool
The Linux kernel people want a feature that makes GCC pretend some inline assembler code is tiny (while it would think it is huge), so that such code will be inlined essentially always instead of essentially never. This patch lets you say "asm inline" instead of just "asm", with the result that

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-10-30 Thread Jeff Law
On 10/30/18 9:44 AM, Martin Sebor wrote: > On 10/30/2018 09:27 AM, Jeff Law wrote: >> On 10/29/18 5:51 PM, Martin Sebor wrote: >>> The missing nul detection fails when the argument of the %s or >>> similar sprintf directive is the address of a non-nul character >>> constant such as in: >>> >>>  

[PATCH] xfail ira-shrink-wrap-prep tests (PR87708)

2018-10-30 Thread Segher Boessenkool
After r265398, the ira-shrinkwrap-prep-[12].c tests fail on all targets, because the IRA feature tested can only move hard registers down, and we no longer have hard registers for the function parameters at this stage. Is this okay for trunk? 2018-10-30 Segher Boessenkool gcc/testsuite/

Re: [PATCH, GCC/ARM] Fix PR87374: ICE with -mslow-flash-data and -mword-relocations

2018-10-30 Thread Ramana Radhakrishnan
On Fri, Oct 5, 2018 at 5:50 PM Thomas Preudhomme wrote: > > Hi Ramana and Kyrill, > > I've reworked the patch to add some documentation of the option > conflict and reworked the -mword-relocation logic slightly to set the > variable explicitely in PIC mode rather than test for PIC and word >

Re: [C++ Patch] Improve locations in flexible array members diagnostic

2018-10-30 Thread Jason Merrill
OK. On Tue, Oct 30, 2018 at 11:23 AM Paolo Carlini wrote: > > Hi, > > today I noticed quite a few additional places where we can exploit > declarator->id_loc, the below are the first bits. Tested x86_64-linux. > > Thanks, Paolo. > > // >

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Segher Boessenkool
On Tue, Oct 30, 2018 at 09:49:18PM +0900, Stafford Horne wrote: > Hello, > > On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote: > > Yes, like that. It also easily can handle the other combos (those with > > STACK_POINTER), and it is easier if you have to switch

[PATCH/AARCH64] Add OcteonTX for -mcpu=

2018-10-30 Thread Andrew Pinski
Hi all, There was a name change of the Products, ThunderX T81 and ThunderX T83 to OcteonTX family name. This change was done a few years ago but I had not submmitted the change at that time. This is also the first patch in a series to add OcteonTX 2 support to GCC. OK? Bootstrapped and

Re: Fix D compilation on Solaris

2018-10-30 Thread Iain Buclaw
On Tue, 30 Oct 2018 at 14:13, Rainer Orth wrote: > > Rainer Orth writes: > > > * On sparc, I didn't get that far, unfortunately: as I mentioned, many > > compilations die with SIGBUS: > > > > libtool: compile: /var/gcc/regression/trunk/11.5-gcc/build/./gcc/gdc > >

[C++ Patch] Improve locations in flexible array members diagnostic

2018-10-30 Thread Paolo Carlini
Hi, today I noticed quite a few additional places where we can exploit declarator->id_loc, the below are the first bits. Tested x86_64-linux. Thanks, Paolo. // /cp 2018-10-30 Paolo Carlini * decl.c (grokdeclarator): Use declarator->id_loc in diagnostic

Re: [PATCH][rs6000] use index form addresses more often for ldbrx/stdbrx

2018-10-30 Thread Aaron Sawdey
I had to make one more change to make this actually work. In rs6000_force_indexed_or_indirect_mem() it was necessary to return the updated rtx. Bootstrap/regtest passes on ppc64le (power7, power9), ok for trunk? Thanks! Aaron 2018-10-30 Aaron Sawdey * config/rs6000/rs6000.md

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Segher Boessenkool
On Tue, Oct 30, 2018 at 08:26:00PM +0900, Stafford Horne wrote: > On Mon, Oct 29, 2018 at 04:42:43PM +, Richard Henderson wrote: > > On 10/29/18 4:34 PM, Segher Boessenkool wrote: > > > Is there some better documentation available? This is what google found > > > for me. I would have like

[RFT PATCH, middle end]: Fix PR58372, internal compiler error: ix86_compute_frame_layout

2018-10-30 Thread Uros Bizjak
Hello! Function calls, generated directly through emit_library_call (for the testcase from PR the compiler builds a call to _Unwind_SjLj_Register via sjlj_emit_function_enter) miss a whole lot of stack realignmnet setup. There is an update to crtl->preferred_stack_boundary present, but several

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-10-30 Thread Martin Sebor
On 10/30/2018 09:54 AM, Jeff Law wrote: On 10/30/18 9:44 AM, Martin Sebor wrote: On 10/30/2018 09:27 AM, Jeff Law wrote: On 10/29/18 5:51 PM, Martin Sebor wrote: The missing nul detection fails when the argument of the %s or similar sprintf directive is the address of a non-nul character

Re: [PATCH] detect missing nuls in address of const char (PR 87756)

2018-10-30 Thread Martin Sebor
On 10/30/2018 09:27 AM, Jeff Law wrote: On 10/29/18 5:51 PM, Martin Sebor wrote: The missing nul detection fails when the argument of the %s or similar sprintf directive is the address of a non-nul character constant such as in: const char c = 'a'; int f (void) { return snprintf (0,

[patch, fortran] Fix PR 85896, type confusion with min and max

2018-10-30 Thread Thomas Koenig
Hello world, the attached patchlet fixes a rejects-valid bug by simply ignoring the type for max and min during simplification. This is correct because setting the type of a generic intrinsic function has no effect. It is a rare pleasure to fix a bug by removing code only :-)

Re: [PATCH] xfail ira-shrink-wrap-prep tests (PR87708)

2018-10-30 Thread Jeff Law
On 10/30/18 11:59 AM, Segher Boessenkool wrote: > After r265398, the ira-shrinkwrap-prep-[12].c tests fail on all > targets, because the IRA feature tested can only move hard registers > down, and we no longer have hard registers for the function parameters > at this stage. > > Is this okay for

[PATCH 3/4] [og8] Attach / Detach C++ FE changes

2018-10-30 Thread Cesar Philippidis
As noted here this patch adds support for attach and detach in the C++ front end. Unlike trunk, OG8 has some preliminary support for the this pointer. Consequently, finish_omp_clauses had to take care of a couple more cases in order to get

Re: [PATCH] avoid -Wnonnull for printf format in dead code (PR 87041)

2018-10-30 Thread Jeff Law
On 10/29/18 3:59 PM, Martin Sebor wrote: > PR 87041 - -Wformat "reading through null pointer" on unreachable > code is a complaint about -Wformat false positives due to null > arguments to %s directives in unreachable printf calls.  The warning > is issued by the front end, too early to know 

Re: [AArch64] Add Saphira pipeline description.

2018-10-30 Thread James Greenhalgh
On Tue, Oct 30, 2018 at 05:12:58AM -0500, Sameera Deshpande wrote: > On Fri, 26 Oct 2018 at 13:33, Sameera Deshpande > wrote: > > > > Hi! > > > > Please find attached the patch to add a pipeline description for the > > Qualcomm Saphira core. It is tested with a bootstrap and make check, > > with

Re: [PATCH, d] Disable D on systems where it is known not to work.

2018-10-30 Thread Andreas Schwab
On Okt 30 2018, Iain Buclaw wrote: > This turns off D front-end where there's been reported bootstrap > problems that need further investigation. Also added a configure.tgt > for libphobos to allow enabling for targets where there's known good > runtime support backed by existing continuous

Re: [PATCH, d] Disable D on systems where it is known not to work.

2018-10-30 Thread Iain Buclaw
On Tue, 30 Oct 2018 at 20:50, Andreas Schwab wrote: > > On Okt 30 2018, Iain Buclaw wrote: > > > This turns off D front-end where there's been reported bootstrap > > problems that need further investigation. Also added a configure.tgt > > for libphobos to allow enabling for targets where

Re: [PATCH, AArch64 v2 02/11] aarch64: Improve cas generation

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:06AM -0500, Richard Henderson wrote: > Do not zero-extend the input to the cas for subword operations; > instead, use the appropriate zero-extending compare insns. > Correct the predicates and constraints for immediate expected operand. OK, modulo two very dull style

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

2018-10-30 Thread Jason Merrill
On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: On 24/10/18 22:41, Jason Merrill wrote: On 10/15/18 12:45 PM, Paolo Carlini wrote: && ((TREE_CODE (declspecs->type) != TYPENAME_TYPE +   &&

[PATCH 1/4] [og8] Attach / Detach generic infrastructure

2018-10-30 Thread Cesar Philippidis
As mentioned here , this patch series adds support for the new attach / detach clauses introduced in OpenACC 2.6 to the C and C++ front ends. There is one notable difference between this patch and the one I posted for trunk. This patch

Re: [PATCH, AArch64 v2 05/11] aarch64: Emit LSE st instructions

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:09AM -0500, Richard Henderson wrote: > When the result of an operation is not used, we can ignore the > result by storing to XZR. For two of the memory models, using > XZR with LD has a preferred assembler alias, ST. ST has different semantics to LD, in particular,

Re: [PATCH, AArch64 v2 06/11] Add visibility to libfunc constructors

2018-10-30 Thread James Greenhalgh
This one needs some other reviewers copied in, who may have missed that it is not an AARch64 only patch (it looks fine to me). James On Tue, Oct 02, 2018 at 11:19:10AM -0500, Richard Henderson wrote: > * optabs-libfuncs.c (build_libfunc_function_visibility): > New, split out from...

Re: [PATCH, AArch64 v2 09/11] aarch64: Force TImode values into even registers

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:13AM -0500, Richard Henderson wrote: > The LSE CASP instruction requires values to be placed in even > register pairs. A solution involving two additional register > classes was rejected in favor of the much simpler solution of > simply requiring all TImode values to

[PATCH 4/4] [og8] Attach / Detach compiler tests

2018-10-30 Thread Cesar Philippidis
This patch introduces a couple of compiler tests for the OpenACC attach and detach clauses. I've committed it to openacc-gcc-8-branch. Cesar 2018-10-30 Cesar Philippidis gcc/testsuite/ * c-c++-common/goacc/mdc-1.c: New test. * c-c++-common/goacc/mdc-2.c: New test. * g++.dg/goacc/mdc.C:

Re: Turn complete to incomplete types in free_lang_data

2018-10-30 Thread Jan Hubicka
Hi, this is variant I re-tested and comitted. It goes by adding the type to worklist - it is very hard to debug ordering issues in free lang data so I think it is more robust to avoid introducing more surprises and we will definitly want to also simplify function types eventually. I am now

Re: [PATCH, AArch64 v2 01/11] aarch64: Simplify LSE cas generation

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:05AM -0500, Richard Henderson wrote: > The cas insn is a single insn, and if expanded properly need not > be split after reload. Use the proper inputs for the insn. OK. Thanks, James > > * config/aarch64/aarch64.c (aarch64_expand_compare_and_swap): >

Re: [PATCH, AArch64 v2 03/11] aarch64: Improve swp generation

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:07AM -0500, Richard Henderson wrote: > Allow zero as an input; fix constraints; avoid unnecessary split. OK. James > > * config/aarch64/aarch64.c (aarch64_emit_atomic_swap): Remove. > (aarch64_gen_atomic_ldop): Don't call it. > *

V2 [PATCH] i386: Use scalar operand in SF/DF/SI/DI vec_dup patterns

2018-10-30 Thread H.J. Lu
On Mon, Oct 29, 2018 at 2:02 PM Uros Bizjak wrote: > > On Sat, Oct 27, 2018 at 8:03 AM H.J. Lu wrote: > > > > Use scalar operand in SF/DF/SI/DI vec_dup patterns which enables combiner > > to generate > > > > (set (reg:V8SF 84) > > (vec_duplicate:V8SF (mem/c:SF (symbol_ref:DI ("y") > > >

[PATCH 2/4] [og8] Attach / Detach C FE changes

2018-10-30 Thread Cesar Philippidis
As noted here , this patch adds support for attach and detach in the C front end. The only major difference between this and the trunk patch is that OG8 supports the acc routine bind clause, do the trunk patch didn't apply cleanly. Other

Re: [patch, fortran] Fix PR 85896, type confusion with min and max

2018-10-30 Thread Janne Blomqvist
On Tue, Oct 30, 2018 at 8:57 PM Thomas Koenig wrote: > Hello world, > > the attached patchlet fixes a rejects-valid bug by simply ignoring the > type for max and min during simplification. This is correct > because setting the type of a generic intrinsic function has > no effect. > > It is a

Re: C++ PATCH to implement C++20 P0892R2 - explicit(bool) [v4]

2018-10-30 Thread Jason Merrill
On 10/29/18 6:15 PM, Marek Polacek wrote: On Wed, Oct 24, 2018 at 02:55:14PM -0400, Jason Merrill wrote: On 10/12/18 12:32 PM, Marek Polacek wrote: + EXPLICIT_SPECIFIER is used in case the explicit-specifier, if any, has + value-dependent expression. */ static void

Re: [PATCH v2] S/390: Allow LARL of literal pool entries

2018-10-30 Thread Ilya Leoshkevich
> Am 30.10.2018 um 18:22 schrieb Ulrich Weigand : > > Ilya Leoshkevich wrote: > >> @@ -8223,6 +8237,18 @@ find_constant_pool_ref (rtx x, rtx *ref) >> && XINT (x, 1) == UNSPECV_POOL_ENTRY) >> return; >> >> + if (SYMBOL_REF_P (x) >> + && CONSTANT_POOL_ADDRESS_P (x) >> + &&

Re: [PATCH, testsuite, c-compat] Handle another c/l option not recognised by older GCC or clang.

2018-10-30 Thread Jeff Law
On 10/29/18 1:53 PM, Iain Sandoe wrote: > Hi > > When using ALT_CC/CXX_UNDER_TEST in the compat/struct-layout-1 tests, the c/l > options provided to the “alt” compiler need to avoid latest and greatest GCC > capability. The patch tests to see if the ‘alt’ compiler can handle >

Re: [PATCH, AArch64 v2 04/11] aarch64: Improve atomic-op lse generation

2018-10-30 Thread James Greenhalgh
On Tue, Oct 02, 2018 at 11:19:08AM -0500, Richard Henderson wrote: > Fix constraints; avoid unnecessary split. Drop the use of the atomic_op > iterator in favor of the ATOMIC_LDOP iterator; this is simplier and more > logical for ldclr aka bic. OK. Thanks, James > > *

Re: [PATCH] Provide extension hint for aarch64 target (PR driver/83193).

2018-10-30 Thread James Greenhalgh
On Thu, Oct 25, 2018 at 05:53:22AM -0500, Martin Liška wrote: > On 10/24/18 7:48 PM, Martin Sebor wrote: > > On 10/24/2018 03:52 AM, Martin Liška wrote: > >> On 10/23/18 6:31 PM, Martin Sebor wrote: > >>> On 10/22/2018 07:05 AM, Martin Liška wrote: > On 10/16/18 6:57 PM, James Greenhalgh

[PATCH, d] Disable D on systems where it is known not to work.

2018-10-30 Thread Iain Buclaw
Hi, This turns off D front-end where there's been reported bootstrap problems that need further investigation. Also added a configure.tgt for libphobos to allow enabling for targets where there's known good runtime support backed by existing continuous integration. For both, this can be

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-10-30 Thread Cesar Philippidis
On 10/5/18 07:07, Tom de Vries wrote: > On 6/29/18 8:19 PM, Cesar Philippidis wrote: >> The attached patch includes the nvptx and GCC ME reductions enhancements. >> >> Is this patch OK for trunk? It bootstrapped / regression tested cleanly >> for x86_64 with nvptx offloading. >> > > These need

LTO partitioning performance & increase default number of partitions

2018-10-30 Thread Jan Hubicka
Hi, this patch increases lto-partitions to 128. This makes ltrans.o file sizes to grow from 458MB to 651MB which is still not perfect but a lot better than prevoiusly. On firefox the growth is smaller (only about 10%) which is probably caused by the "unified build" they use where they merge

Re: [PATCH] use MAX_OFILE_ALIGNMENT to validate attribute aligned (PR 87795)

2018-10-30 Thread Jeff Law
On 10/30/18 3:40 PM, Martin Sebor wrote: > Bug 87795 - Excessive alignment permitted for functions and labels > points out that the handler for attribute aligned makes it possible > for unsupported alignments to be accepted by the front end only to > be either rejected later on by some targets for 

Re: Avoid tests failures in C++98

2018-10-30 Thread Jonathan Wakely
On 30/10/18 22:42 +0100, François Dumont wrote: Running some tests in C++98 show that the error checked by following tests are those of the C++11 mode. This patch add target c++11 so that those tests are ignored in previous mode.     *

[PATCH] use MAX_OFILE_ALIGNMENT to validate attribute aligned (PR 87795)

2018-10-30 Thread Martin Sebor
Bug 87795 - Excessive alignment permitted for functions and labels points out that the handler for attribute aligned makes it possible for unsupported alignments to be accepted by the front end only to be either rejected later on by some targets for variables, or to cause an ICE for overaligned

Re: std::vector fix & enhancements

2018-10-30 Thread François Dumont
Running tests in C++98 mode show that I had forgotten a 'return *this;' in _Bvector_impl_data::operator=. So here is the patch again. On 10/30/18 7:28 AM, François Dumont wrote: Following Marc Glisse change to ignore _M_start offset I wanted to go a little step further and just remove it in

Re: [Patch, fortran] PR40196 - [F03] [F08] Type parameter inquiry (str%len, a%kind) and Complex parts (z%re, z%im)

2018-10-30 Thread Paul Richard Thomas
Hi Thomas, I tried failing cases of that kind; or assignment to len/kind part refs and returned correct errors. Must check where I was going wrong. Paul from a chilly Garching-bei-Muenchen On Sun, 28 Oct 2018, 13:38 Thomas Koenig Hi Paul, > > > >> inq would be easier to understand and

Re: [PATCH] use MAX_OFILE_ALIGNMENT to validate attribute aligned (PR 87795)

2018-10-30 Thread Joseph Myers
On Tue, 30 Oct 2018, Martin Sebor wrote: > So it seems that the attribute handler should be using this macro > instead. I also took the liberty to add more detail to the error Note that it should only be used for alignments relevant to the object file - *not* for alignments of variables with

Re: std::vector fix & enhancements

2018-10-30 Thread Jonathan Wakely
On 30/10/18 07:28 +0100, François Dumont wrote: Following Marc Glisse change to ignore _M_start offset I wanted to go a little step further and just remove it in _GLIBCXX_INLINE_VERSION mode. I also fix a regression we already fixed on mainstream std::vector regarding noexcept qualification

Avoid tests failures in C++98

2018-10-30 Thread François Dumont
Running some tests in C++98 show that the error checked by following tests are those of the C++11 mode. This patch add target c++11 so that those tests are ignored in previous mode.     * testsuite/23_containers/deque/requirements/dr438/assign_neg.cc:     Add target c++11.     *

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Stafford Horne
On Tue, Oct 30, 2018 at 03:57:03PM +, Richard Henderson wrote: > On 10/30/18 12:18 PM, Stafford Horne wrote: > > OK, I was just being lazy allowing the spill. Do you think the split/expand > > would be an RTL using left shift / right shift? Can you think of something > > more clever? Since

Re: [PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-30 Thread Stafford Horne
On Tue, Oct 30, 2018 at 10:49:53AM -0500, Segher Boessenkool wrote: > On Tue, Oct 30, 2018 at 09:49:18PM +0900, Stafford Horne wrote: > > Hello, > > > > On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote: > > > Yes, like that. It also easily can handle the other combos (those

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

2018-10-30 Thread Paolo Carlini
Hi, On 30/10/18 21:37, Jason Merrill wrote: On 10/26/18 2:02 PM, Paolo Carlini wrote: On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: On 24/10/18 22:41, Jason Merrill wrote: On 10/15/18 12:45 PM, Paolo Carlini wrote: && ((TREE_CODE

Update GCC to autoconf 2.69, automake 1.15.1

2018-10-30 Thread Joseph Myers
This patch (diffs to generated files omitted below) updates GCC to use autoconf 2.69 and automake 1.15.1. (That's not the latest automake version, but it's the one used by binutils-gdb, with which consistency is desirable, and in any case seems a useful incremental update that should make a

Re: [PATCH, d] Disable D on systems where it is known not to work.

2018-10-30 Thread Alan Modra
On Tue, Oct 30, 2018 at 09:07:30PM +0100, Iain Buclaw wrote: > On Tue, 30 Oct 2018 at 20:50, Andreas Schwab wrote: > > > > On Okt 30 2018, Iain Buclaw wrote: > > > > > This turns off D front-end where there's been reported bootstrap > > > problems that need further investigation. Also added a

Re: [PATCH] Make __PRETTY_FUNCTION__-like functions mergeable string csts (PR c++/64266).

2018-10-30 Thread Jason Merrill
On 10/29/18 9:37 AM, Jason Merrill wrote: On Fri, Oct 26, 2018 at 3:14 AM Martin Liška wrote: On 10/24/18 7:24 PM, Jason Merrill wrote: On Tue, Oct 23, 2018 at 4:59 AM Martin Liška wrote: However, I still see some minor ICEs, it's probably related to decay_conversion in cp_fname_init: 1)

  1   2   >