Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, I differ there. A longer explanation: fork() is standard POSIX. Not all systems have posix_spawn. For those systems which do not have it, we would cause a regression by simply removing that functionality for this. The patch is OK from my side if you add fork() as a fallback

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c-family.diff > >

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: > > Hi Janne, > > > fork() semantics can be problematic. Most unix style OS'es have > > posix_spawn which can be used to replace fork + exec in many cases. > > For more information see > > e.g. > >

[PATCH] x86-64: Add vararg ABI tests

2019-05-16 Thread H.J. Lu
We can scan stack for return address to get vector arguments passed on stack. * gcc.target/x86_64/abi/test_varargs-m128.c: New file. * gcc.target/x86_64/abi/avx/test_varargs-m256.c: Likewise. * gcc.target/x86_64/abi/avx512f/test_varargs-m512.c: Likewise. ---

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:43 +0100, Jonathan Wakely wrote: On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead

[PATCH] Implement sane variant converting constructor (P0608R3)

2019-05-16 Thread Jonathan Wakely
* include/std/variant (__overload_set): Remove. (_Arr): New helper. (_Build_FUN): New class template to define a single FUN overload, with specializations to prevent unwanted conversions, as per P0608R3. (_Build_FUNs): New class template to build an

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Ville Voutilainen
On Thu, 16 May 2019 at 23:28, Jonathan Wakely wrote: > Here's what I've tested and am about to commit. Looks good to me.

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Segher Boessenkool
Hi Jeff, On Thu, May 16, 2019 at 12:41:16PM -0600, Jeff Law wrote: > For architectures like PPC, we probably don't want to use the loop count > for anything else as it's likely expensive to get data in/out of the the > loop count register. That is part of it. Another part is that it costs extra

Re: [PATCH] Fix PR 81721: ICE with PCH and Pragma warning and C++ operator

2019-05-16 Thread Joseph Myers
On Mon, 1 Apr 2019, apin...@marvell.com wrote: > From: Andrew Pinski > > Hi, > The problem here is the token->val.node is not saved over > a precompiled header for C++ operator. This can cause an > internal compiler error as we tried to print out the spelling > of the token as we assumed it

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the c-family/ directory > and pointed out by the -Wformat-diag warning. Some of the changes in this patch are questionable. The diagnostics

Re: [PATCH 8/12] fix diagnostic quoting/spelling in the middle-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in middle-end files and > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-midend.diff > > gcc/ChangeLog: > > *

Re: patches to detect GCC diagnostics

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 04:58:08PM +0200, Roland Illig wrote: > - error ("#pragma GCC target string... is badly formed"); > + error ("%<#pragma GCC target%> string is badly formed"); > - error ("#pragma GCC optimize string... is badly formed"); > + error ("%<#pragma GCC

Re: OpenACC Profiling Interface: 'acc_register_library'

2019-05-16 Thread Thomas Schwinge
Hi Jakub! On Thu, 16 May 2019 17:54:23 +0200, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 05:21:56PM +0200, Thomas Schwinge wrote: > > > Jakub, would you please especially review the non-OpenACC-specific > > > changes here, including the libgomp ABI changes? > > > > Given a baseline that

Re: [PATCH 9/12] adjust tests to quoting/spelling diagnostics fixes

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch adjusts the expected test output to the quoting, > spelling and other formatting changes in diagnostics to fix issues > pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-tests.diff > > gcc/testsuite/ChangeLog:

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > * tree-ssa-loop-ivopts.c

Re: [PATCH 10/12] fix diagnostic quoting/spelling in D

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the D front end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-d.diff > > gcc/d/ChangeLog: > > * d/d-builtins.cc

Re: [PATCH 11/12] fix diagnostic quoting/spelling issues in i386 back-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:33 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the i386 back-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-i386.diff > > gcc/ChangeLog: > > *

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Wed, May 08, 2019 at 06:09:06PM +0800, JunMa wrote: > 2019-05-07  Jun Ma > >     PR tree-optimization/90106 >     * gcc.dg/cdce1.c: Check tailcall code generation after cdce pass. >     * gcc.dg/cdce2.c: Likewise. This is wrong and results in UNSUPPORTED failures. Both tests are dg-do run,

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

2019-05-16 Thread Martin Sebor
On 5/16/19 5:22 PM, Joseph Myers wrote: On Tue, 14 May 2019, Martin Sebor wrote: The attached patch fixes quoting, spelling, and other formatting issues in diagnostics issued from files in the c-family/ directory and pointed out by the -Wformat-diag warning. Some of the changes in this patch

Re: patches to detect GCC diagnostics

2019-05-16 Thread Martin Sebor
On 5/16/19 8:58 AM, Roland Illig wrote: Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't

[committed] Fix ICE in equal_mem_array_ref_p (PR c++/90484)

2019-05-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, if we are very unlucky and have a hash collision not just when hash % hash table size is equal, but when the whole 32-bit hash is equal, we can actually end up with compatible types (bool vs. unsigned : 1 on the testcase), but sz0 != sz1 (one is 1-bit, the other

[PATCH] Remove incorrect assertion from filesystem::absolute

2019-05-16 Thread Jonathan Wakely
The assertion is wrong, it should be *s.end() == 0, but that's not allowed. Just remove it, but keep the comment. * src/c++17/fs_ops.cc (absolute(const path&, error_code&)) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Remove bogus assertion. Tested x86_64-w64-mingw32, committed to trunk.

Re: [PATCH] soft-fp: Update soft-fp from glibc

2019-05-16 Thread Joseph Myers
On Wed, 15 May 2019, H.J. Lu wrote: > This patch is updating all soft-fp from glibc, most changes are > copyright years update, and changes other than years update are > > * soft-fp/extenddftf2.c: Use "_FP_W_TYPE_SIZE < 64" to check if > 4_FP_W_TYPEs are used for IEEE quad precision.

Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang intrinsifies the runtime/internal/atomic functions. Currently the runtime/internal/atomic functions are implemented in C using C compiler intrinsics. This patch lets the Go frontend recognize these functions and turn them into intrinsics directly.

Re: [PATCH 6/12] fix diagnostic quoting/spelling in C++

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C++ front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-cp.diff > > gcc/cp/ChangeLog: > > * call.c

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Am 16.05.19 um 22:10 schrieb Janne Blomqvist: On Thu, May 16, 2019 at 10:59 PM Thomas Koenig wrote: Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g.

[PATCH] i386: Enable MMX intrinsics without SSE/SSE2/SSSE3

2019-05-16 Thread H.J. Lu
Since MMX intrinsics are marked with SSE/SSE2/SSSE3 for SSE emulation, enable them without SSE/SSE2/SSSE3 if MMX is enabled. Restore TARGET_3DNOW check, which was changed to TARGET_3DNOW_A by revision 271235. gcc/ PR target/90497 * config/i386/i386-expand.c

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Tue, 14 May 2019, Maxim Kuvyrkov wrote: > The scripts convert svn history branch by branch. They rely on git-svn > on convert individual branches. Git-svn is a good tool for converting > individual branches. It is, however, either very slow at converting the > entire GCC repo, or goes

Re: [PATCH 2/12] fix diagnostic quoting/spelling in ada

2019-05-16 Thread Jeff Law
On 5/14/19 3:31 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Ada front and pointed out by > the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-ada.diff > > gcc/ada/ChangeLog: > > *

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > > PR target/88834 > > *

[PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Janne Blomqvist
fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in libgfortran with

Re: [PATCH] libfortran/90038: Use posix_spawn instead of fork

2019-05-16 Thread Thomas Koenig
Hi Janne, fork() semantics can be problematic. Most unix style OS'es have posix_spawn which can be used to replace fork + exec in many cases. For more information see e.g. https://www.microsoft.com/en-us/research/uploads/prod/2019/04/fork-hotos19.pdf This replaces the one use of fork in

[RFC PATCH] Enhancements to profiledbootstrap

2019-05-16 Thread Arvind Sankar
Hi, I've been playing some with the PGO build infrastructure and have a few changes I thought I'd share and get feedback on whether they're completely crazy or not. I'm not terribly familiar with the innards of the build infra, so would appreciate any comments and suggestions. First, a recap of

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:07 -0600, Jeff Law wrote: On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: On May 16, 2019, at 7:22 PM, Jeff Law wrote: On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: > One possibility is to add -fdump-tree-optimized and scan for > /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" > "optimized" } } */ > resp. > /* { dg-final { scan-tree-dump "log \\(\[^\n\r]*\\); \\\[tail

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: [...] We are not consistent here in `gnat_target_compile' anyway, as you can see from the two existing `concat' invocations, and also the `timeout=300' element. That is the GCC testsuite rather than DejaGnu itself, so

[C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

2019-05-16 Thread Paolo Carlini
Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing approach can be neatly extended. Tested x86_64-linux. Thanks, Paolo.

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code,

Re: [PATCH 4/12] fix diagnostic quoting/spelling in the C front-end

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the C front-end and pointed out > by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-c.diff > > gcc/c/ChangeLog: > > * c-decl.c

Re: [PATCH 7/12] fix diagnostic quoting/spelling in libgcc

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued from files in the libgcc directory > and pointed out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-libgcc.diff > > libgcc/ChangeLog: > >

Re: [PATCH 3/12] fix diagnostic quoting/spelling in Brig

2019-05-16 Thread Jeff Law
On 5/14/19 3:32 PM, Martin Sebor wrote: > The attached patch fixes quoting, spelling, and other formatting > issues in diagnostics issued by the Brig front end and pointed > out by the -Wformat-diag warning. > > Martin > > gcc-wformat-diag-brig.diff > > gcc/brig/ChangeLog: > > *

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Segher Boessenkool
On Thu, May 16, 2019 at 12:03:14PM +0100, Iain Sandoe wrote: > I did a quick check... > > dfp.exp most (all?) fail despite > > /* { dg-require-effective-target powerpc_p9vector_ok } */ > > with errors like this… > > error: decimal floating point not supported for this target Okay, so the test

Go patch committed: Add intrinsics for runtime/internal/sys functions

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang adds intrinsics for runtime/internal/sys functions. runtime/internal/sys.Ctz32/64 and Bswap32/64 are currently implemented with compiler builtin functions. But if they are called from another package, the compiler does not know and therefore cannot

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Joseph Myers
On Thu, 16 May 2019, Maxim Kuvyrkov wrote: > Let's avoid mixing the two discussions: (1) converting svn repo to git > (and getting community consensus to switch to git) and (2) deciding on > which branches to keep in the new repo. > > With git, we can always split away unneeded history by

New Spanish PO file for 'gcc' (version 9.1.0)

2019-05-16 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: https://translationproject.org/latest/gcc/es.po (This file, 'gcc-9.1.0.es.po', has

Strenghten aliasing_component_refs_p

2019-05-16 Thread Jan Hubicka
Hi, this patch cuts walks in aliasing_component_refs_p if the type we look for can not fit into a given type by comparing their sizes. Similar logic already exists in indirect_ref_may_alias_decl_p. When we walk reference a.b.c.d.e looking for type x we only need to do it if sizeof(a)>=sizeof(x)

Go patch committed: Make value method of direct iface take pointer

2019-05-16 Thread Ian Lance Taylor
This patch to the Go frontend by Cherry Zhang make value methods of direct interface types take a pointer argument. Currently, a value method of a direct interface type takes the value of the receiver, which is pointer shaped, as the first parameter. When this method is called through interface,

Re: Deque code cleanup and optimizations

2019-05-16 Thread François Dumont
Here is the simplified patch. I put back the _M_map checks, we'll see later if those can be removed.     * include/bits/stl_deque.h     (_Deque_iterator<>::__ptr_to): Remove, use std::__ptr_rebind.     (_Deque_base(_Deque_base&&, const allocator_type&)): New.    

[PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread linkw
From: Kewen Lin Hi, Previous version link: https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html Comparing with the previous version, I moved the generic parts of rs6000 target hook to IVOPTs. But I still kept the target hook as previous which checks some target specific criteria like

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kugan Vivekanandarajah
Hi, On Fri, 17 May 2019 at 13:37, wrote: > > From: Kewen Lin > > Hi, > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html > > Comparing with the previous version, I moved the generic > parts of rs6000 target hook to IVOPTs. But I still kept > the target hook as

Re: [PATCH][PR90106] Builtin call transformation changes in cdce pass

2019-05-16 Thread JunMa
在 2019/5/17 上午6:04, Jakub Jelinek 写道: On Thu, May 16, 2019 at 11:39:38PM +0200, Jakub Jelinek wrote: One possibility is to add -fdump-tree-optimized and scan for /* { dg-final { scan-tree-dump "pow \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ resp. /* { dg-final { scan-tree-dump "log

[PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

2019-05-16 Thread Feng Xue OS
This patch is meant to give user a way to optimize away those empty loops which are impossible to be recognized by compiler, such as C++ STL container-based loop, void f (std::map )   {     for (auto it = m.begin (); it != m.end (); ++it);   } An option "-ffinite-loop" is added to

Re: LWG2593 Move from allocator state is preserved

2019-05-16 Thread François Dumont
2 other tests needed to be adapted in 21_strings. Attached patch applied. 2019-05-17  François Dumont     Move from state of allocators (LWG2593)     * include/bits/stl_deque.h     (_Deque_base(_Deque_base&&, false_type)): Remove.     (_Deque_base(_Deque_base&&, true_type)): Remove.    

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Ramana Radhakrishnan
On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov wrote: > > > On May 16, 2019, at 7:22 PM, Jeff Law wrote: > > > > On 5/15/19 5:19 AM, Richard Biener wrote: > >> > >> For the official converted repo do we really want all (old) > >> development branches to be in the > >> main git repo? I suppose

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 4:04 PM Martin Jambor wrote: > > Hi Richi, > > On Thu, May 16 2019, Richard Biener wrote: > > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > >> > >> Hello, > >> > >> this is a follow-up from a WIP patch I sent here in late December: > >>

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Jeff Law
On 5/15/19 2:47 AM, Richard Biener wrote: > On Wed, 15 May 2019, Kewen.Lin wrote: > >> on 2019/5/14 下午3:26, Richard Biener wrote: >>> On Tue, May 14, 2019 at 5:10 AM wrote: From: Kewen Lin Previous version link for background:

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: > > On 5/15/19 3:03 PM, Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > >> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >>> > >>> Gimple jump threading does not duplicate forwarder blocks that might > >>> be

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Jeff Law
On 5/16/19 12:46 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 6:14 PM Jeff Law wrote: >> >> On 5/15/19 3:03 PM, Alexandre Oliva wrote: >>> On May 15, 2019, Richard Biener wrote: >>> On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > > Gimple jump threading does not

[PATCH] Refactor tree-affine.c to not build GENERIC trees

2019-05-16 Thread Richard Biener
The following picks up the patch from last December, refactoring aff_combination_expand to not use gimple_assign_rhs_to_tree but analyze GIMPLE stmts directly. Last December I was stuck at FAIL: gcc.dg/tree-ssa/ivopts-lt-2.c scan-tree-dump-times ivopts "PHI" 1 FAIL:

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Jeff Law
On 5/16/19 12:36 PM, Ramana Radhakrishnan wrote: > On Thu, May 16, 2019 at 5:41 PM Maxim Kuvyrkov > wrote: >> >>> On May 16, 2019, at 7:22 PM, Jeff Law wrote: >>> >>> On 5/15/19 5:19 AM, Richard Biener wrote: For the official converted repo do we really want all (old) development

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

2019-05-16 Thread Dragan Mladjenovic
Ping. From: Dragan Mladjenovic Sent: Thursday, May 9, 2019 12:29 PM To: gcc-patches@gcc.gnu.org Cc: Dragan Mladjenovic; Jakub Jelinek; Matthew Fortune Subject: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx From: "Dragan Mladjenovic"

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 13:30 +0100, Jonathan Wakely wrote: On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are

[PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Jakub Jelinek
On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > but I'd need some data structure where to store the argument; we don't have > > loop_vinfo yet (we don't have it even before the loop over vector sizes),

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Martin Jambor
Hi Richi, On Thu, May 16 2019, Richard Biener wrote: > On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: >> >> Hello, >> >> this is a follow-up from a WIP patch I sent here in late December: >> https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html >> >> Just like the last time, the patch

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > This patch really exposes a significant deficiency in our current > implementation of default_target_compile: the order of various flags > can be significant, but we only have that order implicitly expressed in > the code, which goes all the way

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 2:52 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: >> >> On 5/16/19 1:42 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > > Index: gcc/gcc/testsuite/lib/gnat.exp > > === > > --- gcc.orig/gcc/testsuite/lib/gnat.exp > > +++ gcc/gcc/testsuite/lib/gnat.exp > > @@ -167,6 +167,8 @@ proc gnat_target_compile {

Re: [PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 11:20 AM Thomas De Schampheleire wrote: > > From: Thomas De Schampheleire > > In addition to making -feliminate-unused-debug-symbols work for the DWARF > format (see [1]), make this option the default. This behavior was the case > before, e.g. under gcc 4.9.x. > [1]

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:53 PM Martin Liška wrote: > > On 5/16/19 1:42 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > >> > >> On 5/16/19 1:24 PM, Richard Biener wrote: > >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > > Hi. > >

Re: [PATCH] OpenMP simd if clause support with runtime determined argument (take 2)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 11:30:38AM +0200, Richard Biener wrote: > > > note_simd_array_uses indeed does walk the IL and does look at the calls, > > > but I'd need some data structure where to store the argument; we don't > > > have > > > loop_vinfo yet

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 11:05 +0100, Jonathan Wakely wrote: On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const

Re: [PATCH] Fix PR90394, [10 Regression] ICE in is_value_included_in, at tree-ssa-uninit.c:1055

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:09 AM Vladislav Ivanishin wrote: > > Hi! > > Here is a simple patch fixing the regression introduced in r270660. > > > Regtested and bootstrapped with `BOOT_CFLAGS="-O > -Wno-error=maybe-uninitialized -Wuninitialized"` on x86_64-pc-linux-gnu. > OK for trunk? OK. > It

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 4:40 AM wrote: > > From: Kugan Vivekanandarajah > > gcc/ChangeLog: > > 2019-05-15 Kugan Vivekanandarajah > > PR target/88834 > * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle > IFN_MASK_LOAD_LANES and IFN_MASK_STORE_LANES. >

[PATCH] Handle a location with NULL as a file (PR driver/90495)

2019-05-16 Thread Martin Liška
Hi. With LTO and -fsanitize we end up with a static ctor (_GLOBAL__sub_I_00099_0_main) that has no source location. With that stack usage will print '(artificial)' as a location of the function. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed?

Re: [PATCH 0/12] detect quoting and punctuation problems in diagnostics

2019-05-16 Thread Martin Liška
Hi. Maybe I've install the patches wrongly, but I see following error on ppc64le during bootstrap in stage2: /home/marxin/Programming/gcc/objdir/./prev-gcc/xg++ -B/home/marxin/Programming/gcc/objdir/./prev-gcc/ -B/usr/local/powerpc64le-unknown-linux-gnu/bin/ -nostdinc++

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 6:30 AM bin.cheng wrote: > > Hi, > As noted in PR57534 comment #33, SLSR currently doesn't strength reduce memory > references in reported cases, which conflicts with its comment at the > beginning of file. > The main reason is in functions slsr_process_ref and

[PATCH] Remove a test-case that leads to a huge stack (and file) allocation (PR middle-end/90478).

2019-05-16 Thread Martin Liška
Hi. I'm going to remove the test as it leads to a huge .s files and stack allocation at gcc/stmt.c:777 Ready for trunk? Martin gcc/testsuite/ChangeLog: 2019-05-16 Martin Liska PR middle-end/90478 * gcc.dg/tree-ssa/pr90478-2.c: Remove. ---

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: > > On 5/16/19 1:24 PM, Richard Biener wrote: > > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > >> > >> Hi. > >> > >> We should not allow target_clones being combined with alias attribute. > >> > >> Patch can bootstrap on

Re: [PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
On 16/05/19 12:29 +0100, Jonathan Wakely wrote: These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we do a runtime branch, marked [[unlikely]] to

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:42 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:38 PM Martin Liška wrote: >> >> On 5/16/19 1:24 PM, Richard Biener wrote: >>> On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: Hi. We should not allow target_clones being combined with alias attribute.

Re: [PATCH] True IPA reimplementation of IPA-SRA

2019-05-16 Thread Richard Biener
On Fri, May 10, 2019 at 10:31 AM Martin Jambor wrote: > > Hello, > > this is a follow-up from a WIP patch I sent here in late December: > https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01765.html > > Just like the last time, the patch below is is a reimplementation of > IPA-SRA to make it a full

Re: [PATCH] Remove redundant accessors in hash tables

2019-05-16 Thread Jonathan Wakely
On 16/05/19 07:47 +0200, François Dumont wrote: On 5/15/19 5:37 PM, Jonathan Wakely wrote: François, I noticed that _Hash_code_base and _Hashtable_base have a number of member functions which are overloaded for const and non-const:    const _Equal&    _M_eq() const { return

Re: preserve more debug stmts in gimple jump threading

2019-05-16 Thread Richard Biener
On Wed, May 15, 2019 at 11:03 PM Alexandre Oliva wrote: > > On May 15, 2019, Richard Biener wrote: > > > On Wed, May 15, 2019 at 10:20 AM Alexandre Oliva wrote: > >> > >> Gimple jump threading does not duplicate forwarder blocks that might > >> be present before or after the copied block. > > >

Re: [PATCH, Darwin, PowerPC, testsuite] Exclude Darwin from VSX, Power8 and Power9 tests.

2019-05-16 Thread Iain Sandoe
Hi Segher, > On 15 May 2019, at 18:35, Iain Sandoe wrote: >> On 15 May 2019, at 18:24, Segher Boessenkool >> wrote: >> > >> On Wed, May 15, 2019 at 12:54:03PM +0100, Iain Sandoe wrote: >>> The patch augments the tests for feature support for VSX, >>> power8 and power9 to exclude Darwin

[PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
Hi. We should not allow target_clones being combined with alias attribute. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-05-16 Martin Liska PR lto/90500 * multiple_target.c

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Richard Biener
On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: > > Hi. > > We should not allow target_clones being combined with alias attribute. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? So that's because an alias cannot be turned into a

[PATCH] Changes to std::variant to reduce code size

2019-05-16 Thread Jonathan Wakely
These two changes both result in smaller code for std::variant. The first one means smaller tables of function pointers, because we don't generate an instantiation for the valueless state. Instead we do a runtime branch, marked [[unlikely]] to make _M_reset() a no-op if it's already valueless.

Re: [PATCH] Do not allow target_clones with alias attr (PR lto/90500).

2019-05-16 Thread Martin Liška
On 5/16/19 1:24 PM, Richard Biener wrote: > On Thu, May 16, 2019 at 1:18 PM Martin Liška wrote: >> >> Hi. >> >> We should not allow target_clones being combined with alias attribute. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > > So

Re: [PATCH 1/12] implement -Wformat-diag to detect quoting and spelling issues in GCC diagnostics

2019-05-16 Thread Martin Liška
On 5/16/19 12:36 AM, Martin Sebor wrote: > On 5/15/19 8:50 AM, Martin Sebor wrote: >> On 5/15/19 5:40 AM, Martin Liška wrote: >>> On 5/14/19 11:31 PM, Martin Sebor wrote: The attached patch implements the -Wformat-diag warning to help find quoting, spelling, and other formatting issues 

[PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Jakub Jelinek
Hi! Fortran subroutines/functions that have CHARACTER arguments have also hidden arguments at the end of the argument list which hold the string length. This is something all Fortran compilers I've tried do and is done in order to support calling unprototyped subroutines/functions where one

[PATCH] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

2019-05-16 Thread Thomas De Schampheleire
From: Thomas De Schampheleire In addition to making -feliminate-unused-debug-symbols work for the DWARF format (see [1]), make this option the default. This behavior was the case before, e.g. under gcc 4.9.x. [1] https://gcc.gnu.org/viewcvs/gcc?view=revision=269925 gcc/ChangeLog: 2019-05-16

Re: [PATCH] OpenMP simd if clause support with runtime determined argument

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > On Thu, May 16, 2019 at 09:53:06AM +0200, Richard Biener wrote: > > > + if (nonconst_simd_if) > > > +{ > > > + if (sctx.lane == NULL_TREE) > > > + { > > > + sctx.idx = create_tmp_var (unsigned_type_node); > > > + sctx.lane = create_tmp_var

Re: [PATCH] S/390: Add -march to test case

2019-05-16 Thread Ilya Leoshkevich
> 2019-05-15 Robin Dapp > > * gcc.target/s390/global-array-element-pic.c: Add -march=z900. > * gcc.target/s390/global-array-element-pic2.c: New test for z10+. LGTM

Re: [PATCH] Add workaround for broken C/C++ wrappers to LAPACK (PR fortran/90329)

2019-05-16 Thread Richard Biener
On Thu, 16 May 2019, Jakub Jelinek wrote: > Hi! > > Fortran subroutines/functions that have CHARACTER arguments have also > hidden arguments at the end of the argument list which hold the string > length. This is something all Fortran compilers I've tried do and is > done in order to support

[PATCH][gimplefe] BIT_INSERT_EXPR support

2019-05-16 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-05-16 Richard Biener c/ * gimple-parser.c (c_parser_gimple_statement): Handle __BIT_INSERT. (c_parser_gimple_unary_expression): Likewise. * gimple-pretty-print.c (dump_ternary_rhs):

Re: [committed] Fix up pr90478.c testcase (was Re: [PATCH] Check for overflow in tree-switch-conversion (PR middle-end/90478).)

2019-05-16 Thread Martin Liška
On 5/16/19 12:45 AM, Jakub Jelinek wrote: > Fixed thusly, tested on x86_64-linux with -m32/-m64, committed to trunk as > obvious: Thank you Jakub.

Re: [PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-05-16 Thread Richard Sandiford
kugan.vivekanandara...@linaro.org writes: > From: Kugan Vivekanandarajah > > Inorder to fix this PR. > * We need to change the whilelo pattern in backend > * Change RTL CSE such that: >- Add support for VEC_DUPLICATE >- When handling PARALLEL rtx in cse_insn, we kill CSE defined by all

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 15, 2019, at 9:47 PM, Segher Boessenkool > wrote: > > On Wed, May 15, 2019 at 11:34:34AM +0300, Maxim Kuvyrkov wrote: >>> On May 15, 2019, at 12:20 AM, Segher Boessenkool >>> wrote: >>> On Tue, May 14, 2019 at 07:11:18PM +0300, Maxim Kuvyrkov wrote: This patch adds scripts to

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

2019-05-16 Thread Maxim Kuvyrkov
> On May 16, 2019, at 3:33 AM, Paul Koning wrote: > > > >> On May 15, 2019, at 2:42 PM, Eric Gallager wrote: >> >>> ... >> >> Wasn't Eric S. Raymond working on his own conversion of the GCC repo >> from SVN to Git? Whatever happened to his? > > Yes, and from what I recall he found that

Re: [PATCH v2 3/3] Consider doloop cmp use in ivopts

2019-05-16 Thread Richard Biener
On Wed, 15 May 2019, Segher Boessenkool wrote: > On Wed, May 15, 2019 at 10:47:31AM +0200, Richard Biener wrote: > > Ah, so the key issue is that the doloop IV is "free"? That > > is, it doesn't consume a general register and whatnot? That > > is allocating this IV doesn't really interfere with

  1   2   >