Re: [PATCH v2] RISC-V: Promote type correctly for libcalls

On Mon, 5 Aug 2019, Kito Cheng wrote: > Committed as r274107 > > Hi Jakub, Richard: > > This patch is fix ABI bug for libcall on RISC-V, we've also tested on > gcc 8 and 9, it's ok for gcc 9 and 8? Works for me. Thanks, Richard. > Thanks. > > On Fri, Aug 2, 2019 at 11:52 PM Jim Wilson

Make function_code a 32-bit field

Adding SVE intrinsics on top of the existing AArch64 intrinsics blows the 12-bit function_code in tree_function_decl. That bitfield has no spare bits, but it comes at the end of the structure and is preceded by a pointer, so on LP64 hosts there's currently a 32-bit hole at end. This patch

Re: [PATCH] Add _mm256_{load,store}u2_m128{,d,i} intrinsics (PR target/91341)

On Mon, Aug 5, 2019 at 9:30 AM Jakub Jelinek wrote: > > Hi! > > The following patch adds a couple of intrinsics that both ICC and clang > have, but GCC doesn't. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > They emit optimal code except for the last one,

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

On Aug 05 2019, Kito Cheng wrote: > + # TODO: Support implied extensions, e.g. D implied F in latest spce. spec > + # TODO: Support extesnion version. extension > + # Filter out any non exist index. non-existent Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: >> >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: >> > >> So you unconditionally add a smaxdi3 pattern - indeed this looks >> necessary even when going

Re: [PATCH] Properly detect working jobserver in gcc driver.

On 8/2/19 11:55 AM, Richard Biener wrote: > On Fri, Aug 2, 2019 at 11:19 AM Martin Liška wrote: >> >> On 8/2/19 11:15 AM, Jan Hubicka wrote: On Fri, Aug 2, 2019 at 10:50 AM Jakub Jelinek wrote: > > On Fri, Aug 02, 2019 at 10:47:10AM +0200, Martin Liška wrote: >>> Can you strace

[PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

Input string consist of four parts: --- and generator doing combination with part, but it just append the extension at the end of arch string, it might generate invalid arch. For example, without this patch `./multilib-generator rv32imafc-ilp32--d` will generate: MULTILIB_OPTIONS =

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, 5 Aug 2019, Martin Liška wrote: I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument (when not being used). Ah, I didn't realize that after cloning and drastically changing the signature it would still count as operator new/delete. Is getting

[PATCH] Add _mm256_{load,store}u2_m128{,d,i} intrinsics (PR target/91341)

Hi! The following patch adds a couple of intrinsics that both ICC and clang have, but GCC doesn't. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? They emit optimal code except for the last one, _mm256_storeu2_m128i, where we emit vmovups %xmm0, (%rsi)

Add a gimple_move_vops helper function

I needed to add another instance of this idiom, so thought it'd be worth having a helper function. Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. OK to install? Richard 2019-08-05 Richard Sandiford gcc/ * gimple.h (gimple_move_vops): Declare. * gimple.c

Re: [PATCH] Handle new operators with no arguments in DCE.

On 8/5/19 9:07 AM, Marc Glisse wrote: > On Mon, 5 Aug 2019, Martin Liška wrote: > >> I'm sending fix for the ICE. The issue is that we can end up >> with a ctor without an argument (when not being used). > > Ah, I didn't realize that after cloning and drastically changing the > signature it

[PATCH] Handle new operators with no arguments in DCE.

On 8/2/19 11:34 PM, H.J. Lu wrote: > On Tue, Jul 2, 2019 at 4:50 AM Martin Liška wrote: >> >> Second part. >> >> Martin > > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91334 > Hi. I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

> On Aug 2, 2019, at 11:41 AM, Maxim Kuvyrkov wrote: > >> On Aug 1, 2019, at 11:43 PM, Jason Merrill wrote: >> ... >>> Unfortunately, current mirror does not and could not account for rewrites >>> of SVN commit log messages. For trunk the histories of diverge in 2008 due >>> to commit

Re: [PATCH, Ada, Darwin, PPC] PPC Darwin has stack check probes.

> On 4 Aug 2019, at 21:43, Eric Botcazou wrote: > >> This (PPC)Darwin-specific patch has been on mainline for some time now >> without issues, the problem is present on open branches, may I backport it? > > Yes, thanks. Done for 9.2 Iain

Re: [PATCH, Ada] Push -shared-libgcc where needed.

> On 4 Aug 2019, at 21:42, Eric Botcazou wrote: > >> This patch has now been on mainline for some time without any apparent >> issue, the problem is also present on the open branches, may I backport it? > > OK, thanks. Done for 9.2. Iain

[C] Fix bogus nested enum error message

For: enum a { A }; enum a { B }; we emit a bogus error about nested definitions before the real error: foo.c:2:6: error: nested redefinition of ‘enum a’ 2 | enum a { B }; | ^ foo.c:2:6: error: redeclaration of ‘enum a’ foo.c:1:6: note: originally defined here 1 | enum

Re: [patch] Fix tree-optimization/91169

> Testing went OK but it looks like acats doesn't honor > RUNTESTFLAGS so I got no multilib testing for it :/ > And the PR didn't contain sth I could plug into gnat.dg so I checked > with visual inspection of dumps on the reduced testcase. Sorry about that, gnat.dg/array37.adb now attached. > I

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Sun, 4 Aug 2019, Uros Bizjak wrote: > On Sun, Aug 4, 2019 at 7:23 PM Jakub Jelinek wrote: > > > > On Sun, Aug 04, 2019 at 07:11:01PM +0200, Uros Bizjak wrote: > > > Yes, the approach looks OK to me. It makes chain building mode > > > agnostic, and the chain building can be used for > > > a)

Fold MASK_LOAD/STORE with an all-true mask

This patch folds IFN_MASK_LOAD and IFN_MASK_STOREs to normal accesses if the mask is all-true. This can happen for fully-masked loops that didn't actually need to be (which could be handled by the vectoriser instead), or for unrolled fully-masked loops whose first iteration is guaranteed to

Protect tree_to_shwi call in unmodified_param_1

unmodified_param_1 used tree_to_shwi without first checking tree_fits_shwi_p. This is needed by the SVE ACLE support and is hard to test independently. Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. OK to install? Richard 2019-08-05 Richard Sandiford gcc/ *

[PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float linux targets.

From: "Dragan Mladjenovic" gcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to TARGET_SOFT_FLOAT. * config/mips/mips.c (TARGET_ASM_FILE_END): Define to ... (mips_asm_file_end): New function. Delegate to

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > >

Re: [PATCH] Handle new operators with no arguments in DCE.

On 8/5/19 1:57 PM, Marc Glisse wrote: > On Mon, 5 Aug 2019, Martin Liška wrote: > >> On 8/5/19 9:07 AM, Marc Glisse wrote: >>> On Mon, 5 Aug 2019, Martin Liška wrote: >>> I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument (when not being used).

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On 8/3/19 12:31 AM, Jason Merrill wrote: > On Fri, Aug 2, 2019 at 7:35 AM Martin Liška wrote: >> >> On 8/2/19 1:06 PM, Richard Biener wrote: >>> On Fri, Aug 2, 2019 at 1:01 PM Martin Liška wrote: On 8/2/19 12:54 PM, Maxim Kuvyrkov wrote: >> On Aug 2, 2019, at 1:26 PM, Martin Liška

Re: wrap math.h for M_PI et al in target/i386 tests

> On Jul 30, 2019, at 5:22 AM, Uros Bizjak wrote: >> Most but not all of the tests that expect M_PI, M_PI_2 and/or M_PI_4 >> to be defined in math.h explicitly exclude one target system that does >> not satisfy this non-standard assumption. >> >> This patch introduces a wrapper header that

Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On Mon, Aug 5, 2019 at 9:20 AM Martin Liška wrote: > Based on the IRC discussion with Jakub, there's missing key element of the > transition. > Jakub requests to have a monotonically increasing revisions (aka rXXX) to > be assigned > for the future git revisions. These will be linked from

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: > I agree. But for those who want a monotonically increasing > identifier, there's already one in git: CommitDate. In the discussion > of this issue four years ago, While commit date is monotonically increasing, it has the problem

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Aug 2, 2019, at 4:06 AM, Richard Biener wrote: > > IMHO voting is bike-shedding. > > Those who do the work decide. _They_ may ask questions _and_ decide whether > to listen to the answer. I'd tend to agree. I also think the recent conversion work is a fine solution, and that my

[wwwdocs] Another C++20 table update

I've opened a bunch of PRs to track the status of C++2a features in G++. This patch updates the C++2a table accordingly. While at it, I made a small clarification regarding P1152R4: only certain uses of volatile are being deprecated, not volatile itself. Index: cxx-status.html

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On 05/08/2019 16:34, Jakub Jelinek wrote: On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: I agree. But for those who want a monotonically increasing identifier, there's already one in git: CommitDate. In the discussion of this issue four years ago, While commit date is

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Mon, Aug 5, 2019 at 12:12 PM Richard Sandiford > wrote: >> >> Uros Bizjak writes: >> > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford >> > wrote: >> >> >> >> Uros Bizjak writes: >> >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> >> >> >> >> On Thu,

[PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

From: "Dragan Mladjenovic" libgcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config/mips/gnustack.h: Check for TARGET_LIBC_GNUSTACK also. gcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config.in: Regenerated. * config/mips/linux.h (NEED_INDICATE_EXEC_STACK):

Re: Add a gimple_move_vops helper function

On Mon, Aug 5, 2019 at 10:49 AM Richard Sandiford wrote: > > I needed to add another instance of this idiom, so thought it'd > be worth having a helper function. > > Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. > OK to install? OK. > Richard > > > 2019-08-05 Richard Sandiford

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:16 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > > dimode_{scalar_to_vector_candidate_p,remove_non_convertible_regs} > > > functions to drop the dimode_ prefix - is that OK or do you > > > prefer some other prefix? > > > > No, please just drop

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > "TARGET_AVX512F"]) > > > > and then we need to split DImode for 32bits, too. > > For now, please add "TARGET_64BIT && TARGET_AVX512F" for DImode > condition, I'll

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, 5 Aug 2019, Martin Liška wrote: You are right. It can really lead to confusion of the DCE. What we have is DECL_ABSTRACT_ORIGIN(decl) which we can use to indicate operators that were somehow modified by an IPA optimization. Looks similar to the cgraph_node->clone_of that Richard was

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford wrote: > > Uros Bizjak writes: > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > >> > >> On Thu, 1 Aug 2019, Uros Bizjak wrote: > >> > >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: > >> > > >> So you unconditionally

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 12:12 PM Richard Sandiford wrote: > > Uros Bizjak writes: > > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford > > wrote: > >> > >> Uros Bizjak writes: > >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > >> >> > >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > > dimode_{scalar_to_vector_candidate_p,remove_non_convertible_regs} > > functions to drop the dimode_ prefix - is that OK or do you > > prefer some other prefix? > > No, please just drop the prefix. just noticed this applies to the derived

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > > "TARGET_AVX512F"]) > > > > > > > > and then we need to

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Sun, 4 Aug 2019, Uros Bizjak wrote: > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: > > > > > So you unconditionally add a smaxdi3 pattern - indeed this looks > >

Re: [patch] Fix tree-optimization/91169

On Mon, Aug 5, 2019 at 10:28 AM Eric Botcazou wrote: > > > Testing went OK but it looks like acats doesn't honor > > RUNTESTFLAGS so I got no multilib testing for it :/ > > And the PR didn't contain sth I could plug into gnat.dg so I checked > > with visual inspection of dumps on the reduced

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 3:04 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI

Re: Fold MASK_LOAD/STORE with an all-true mask

On Mon, Aug 5, 2019 at 10:50 AM Richard Sandiford wrote: > > This patch folds IFN_MASK_LOAD and IFN_MASK_STOREs to normal accesses > if the mask is all-true. This can happen for fully-masked loops that > didn't actually need to be (which could be handled by the vectoriser > instead), or for

[committed][MSP430] Add "cleanup-saved-temps" directive to gcc.target/msp430/pr80993.c

This fixes linker errors about different memory models in object files when the large/small memory models are tested one after the other in the same build directory, by cleaning up the temporary LTO files required to be generated for this test. Applied on trunk. >From

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, 5 Aug 2019, Martin Liška wrote: On 8/5/19 9:07 AM, Marc Glisse wrote: On Mon, 5 Aug 2019, Martin Liška wrote: I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument (when not being used). Ah, I didn't realize that after cloning and drastically

Re: Protect tree_to_shwi call in unmodified_param_1

On Mon, Aug 5, 2019 at 10:58 AM Richard Sandiford wrote: > > unmodified_param_1 used tree_to_shwi without first checking > tree_fits_shwi_p. This is needed by the SVE ACLE support and > is hard to test independently. > > Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. > OK to

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford > wrote: >> >> Uros Bizjak writes: >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: >> >> >> >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener >> >> > wrote:

[PATCH 0/2] [MIPS] Emit .note.GNU-stack for linux targets.

From: "Dragan Mladjenovic" Greetings, These patches enable emitting .note.GNU-stack by default on mips linux targets. First one enables it unconditionally for soft-float builds while the second one enables it for hard-float build if gcc is configured against the future version of glibc that

Re: Make function_code a 32-bit field

On Mon, Aug 5, 2019 at 10:56 AM Richard Sandiford wrote: > > Adding SVE intrinsics on top of the existing AArch64 intrinsics blows > the 12-bit function_code in tree_function_decl. That bitfield has no > spare bits, but it comes at the end of the structure and is preceded > by a pointer, so on

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, Aug 5, 2019 at 8:44 AM Martin Liška wrote: > > On 8/2/19 11:34 PM, H.J. Lu wrote: > > On Tue, Jul 2, 2019 at 4:50 AM Martin Liška wrote: > >> > >> Second part. > >> > >> Martin > > > > This caused: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91334 > > > > Hi. > > I'm sending fix

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:43 PM Uros Bizjak wrote: > > On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > > > On

Re: [PATCH v2] RISC-V: Promote type correctly for libcalls

Committed to gcc-9 as r274108 and gcc-8 as r274113 On Mon, Aug 5, 2019 at 3:29 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Kito Cheng wrote: > > > Committed as r274107 > > > > Hi Jakub, Richard: > > > > This patch is fix ABI bug for libcall on RISC-V, we've also tested on > > gcc 8 and 9,

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > "TARGET_AVX512F"]) > > > > > > and then we need to split DImode for 32bits, too. > > > > For now, please

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > On Mon, Aug 5, 2019 at 3:04 PM Richard Biener wrote: > > > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > > > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > > >

[PATCH] issue a correct fix-it hint for bad argument in GCC diagnostics (PR 80619)

When the argument to a directive with a length modifier like %lu in a call to a GCC diagnostic function such as warning()) is not of the right integer type, GCC suggests to replace the length modifier in the directive with 'w'. For instance: warning: format ‘%lu’ expects argument of type

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 01:29:26PM -0500, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > > > -/* Predicate yielding true iff X is an rtx for a double-int. */ > > > > +/*

Re: [PATCH 04/10, OpenACC] Turn OpenACC kernels regions into a sequence of, parallel regions

On 18/07/2019 10:30 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:06:07PM +0100, Kwok Cheung Yeung wrote: --- a/gcc/omp-oacc-kernels.c +++ b/gcc/omp-oacc-kernels.c @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see #include "backend.h" #include "target.h" #include

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > Hi Arvind, > > First: do you have a copyright assignment? See > https://gcc.gnu.org/contribute.html > for instructions. Nope, is this really substantial enough to warrant one? > > This is easier to review, and even to

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On 8/5/19 11:34 AM, Jakub Jelinek wrote: On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: I agree. But for those who want a monotonically increasing identifier, there's already one in git: CommitDate. In the discussion of this issue four years ago, While commit date is

Re: C++ PATCH for c++/91338 - P1161R3: Deprecate a[b,c]

On Mon, Aug 05, 2019 at 02:31:15PM -0400, Jason Merrill wrote: > On 8/3/19 9:54 PM, Marek Polacek wrote: > > This patch implements P1161R3, Deprecate uses of the comma operator in > > subscripting expressions: > > > > which

Re: [C++ Patch] Improve delete_sanity locations

On 8/2/19 8:27 AM, David Malcolm wrote: On Fri, 2019-08-02 at 14:02 +0200, Paolo Carlini wrote: Hi, On 31/07/19 21:39, David Malcolm wrote: [snip] I don't care for "cp_expr_loc_or_loc". By "_or_here" do you mean "or input_location"? Calling it "cp_expr_loc_or_input_location" would spell

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 3:29 PM Richard Biener wrote: > > > > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > > > > > "TARGET_AVX512F"]) > > > > > > > > > > > > > > and then we need to split DImode for 32bits, too. > > > > > > > > > > > > For now, please add "TARGET_64BIT

Re: C++ PATCH for c++/91264 - detect modifying const objects in constexpr

On 7/31/19 3:26 PM, Marek Polacek wrote: One of the features of constexpr is that it doesn't allow UB; and such UB must be detected at compile-time. So running your code in a context that requires a constant expression should ensure that the code in question is free of UB. In effect, constexpr

PING^1 [PATCH] i386: Separate costs of pseudo registers from hard registers

On Tue, Jul 23, 2019 at 2:57 PM H.J. Lu wrote: > > On Mon, Jun 24, 2019 at 9:16 AM H.J. Lu wrote: > > > > On Mon, Jun 24, 2019 at 6:37 AM Richard Biener wrote: > > > > > > On Thu, 20 Jun 2019, Jan Hubicka wrote: > > > > > > > > > Currently, costs of moves are also used for costs of RTL > > > >

Re: [PATCH V5, rs6000] Support vrotr3 for int vector types

On Mon, Aug 05, 2019 at 11:41:41AM +0800, Kewen.Lin wrote: > on 2019/8/4 上午4:52, Segher Boessenkool wrote: > > On Fri, Aug 02, 2019 at 04:59:44PM +0800, Kewen.Lin wrote: > >> As to the predicate name and usage, I checked the current vector shifts, > >> they don't need to check const_vector

Re: [PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

On 8/1/19 7:35 PM, Martin Sebor wrote: On 8/1/19 12:09 PM, Jason Merrill wrote: On 7/22/19 12:34 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00622.html On 7/8/19 3:58 PM, Martin Sebor wrote: The attached patch implements three new warnings:   * 

[PATCH] Add --with-static-standard-libraries to the top level

gdb should normally not be linked with -static-libstdc++. Currently this has not caused problems, but it's incompatible with catching an exception thrown from a shared library -- and a subsequent patch changes gdb to do just this. This patch adds a new --with-static-standard-libraries flag to

Re: C++ PATCH for c++/91338 - P1161R3: Deprecate a[b,c]

On 8/3/19 9:54 PM, Marek Polacek wrote: This patch implements P1161R3, Deprecate uses of the comma operator in subscripting expressions: which made its way to C++20. New [depr.comma.subscript] shows: void f(int *a, int

Re: [patch][aarch64]: add intrinsics for vld1(q)_x4 and vst1(q)_x4

On 7/18/19 1:18 PM, James Greenhalgh wrote: On Mon, Jun 10, 2019 at 06:21:05PM +0100, Sylvia Taylor wrote: Greetings, This patch adds the intrinsic functions for: - vld1__x4 - vst1__x4 - vld1q__x4 - vst1q__x4 Bootstrapped and tested on aarch64-none-linux-gnu. Ok for trunk? If yes, I don't

[Committed] PR fortran/91372 -- Fix parsing of DATA with implied do-loop

I've committed the attached patch as obvious. My previous patch was too strict (and incorrect) in the interpretation of R837 data-stmt is DATA data-stmt-set [ [ , ] data-stmt-set ] ... The previous patch required whitespace after DATA, but it seems that it id valid to do

[PATCH] [LRA] Fix wrong-code PR 91109

Hi! PR 91109 is a wrong-code bug, where LRA is using a scratch register which is actually not available for use, and thus gets clobbered when it should not. That seems to be mostly because the live range info of the cloned schatch register is not working the way how update_scrach_ops sets up

Re: Use predicates for RTL objects

Hi Arvind, First: do you have a copyright assignment? See https://gcc.gnu.org/contribute.html for instructions. This is easier to review, and even to commit as obvious, if you did a patch per macro, certainly for the new macros; and, put the script in contrib/, and then say with every patch

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > First: do you have a copyright assignment? See > > https://gcc.gnu.org/contribute.html > > for instructions. > > Nope, is this really substantial enough to

Re: [PATCH]: Fix PR c++/88095, class template argument deduction for literal operator templates per P0732 for C++2a

On 8/2/19 9:59 AM, Tom Honermann wrote: This patch fixes PR c++/88095: - Bug 88095 - class nontype template parameter UDL string literals doesn't accepts deduction placeholder - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88095. It also addresses a latent issue; literal operator templates

[C++ Patch] One more cp_expr_loc_or_input_loc

Hi, just spotted an additional error which can benefit from cp_expr_loc_or_input_loc. Tested x86_64-linux. Thanks, Paolo. /cp 2019-08-05 Paolo Carlini * decl.c (check_array_designated_initializer): Use cp_expr_loc_or_input_loc in one place.

Re: [PATCH 06/10, OpenACC] Adjust parallelism of loops in gang-single parts of OpenACC kernels regions

The change to patch 04 (Turn OpenACC kernels regions into a sequence of parallel regions) necessitates an additional include of 'diagnostic-core.h' in omp-oacc-kernels.c, as it is no longer indirectly included by 'cp/cp-tree.h'. Kwok On 17/07/2019 10:12 pm, Kwok Cheung Yeung wrote: Loops in

Re: [RFC][tree-vect]PR 88915: Further vectorize second loop when versioning

Hi Richard, Thanks for the feedback! See comments inline. On 01/08/2019 16:26, Richard Biener wrote: On Tue, 30 Jul 2019, Andre Vieira (lists) wrote: On 30/07/2019 13:16, Andre Vieira (lists) wrote: Hi Richard, I believe this is in line with what you were explaining to me earlier. The

Re: [Committed] PR fortran/90985 -- DATA must be followed by whitespace

On Fri, Aug 2, 2019 at 4:51 PM Steve Kargl wrote: > > In free-form source code, DATA must be followed by whitespace. > This patch checks for whitespace, and if none is found, returns > MATCH_NO to give other matchers a chance to run. > > 2019-08-02 Steven G. Kargl > > PR fortran/90985

Re: [Committed] PR fortran/90985 -- DATA must be followed by whitespace

On Mon, Aug 05, 2019 at 12:01:36PM -0700, H.J. Lu wrote: > On Fri, Aug 2, 2019 at 4:51 PM Steve Kargl > wrote: > > > > In free-form source code, DATA must be followed by whitespace. > > This patch checks for whitespace, and if none is found, returns > > MATCH_NO to give other matchers a chance to

[PATCH] Sync MIPS support from libffi master repository

This updates the libffi MIPS support up to commit 746dbe3a6a79, with the exception of commit bd72848c7af9 which prefixes the ALIGN macro with FFI_ for all ports. These patches, with the exception of the softfloat one, have been used on the Debian GCC packages for quite some time.

Re: [PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

On 8/5/19 1:25 PM, Jason Merrill wrote: On 8/1/19 7:35 PM, Martin Sebor wrote: On 8/1/19 12:09 PM, Jason Merrill wrote: On 7/22/19 12:34 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00622.html On 7/8/19 3:58 PM, Martin Sebor wrote: The attached patch

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > gcc/ChangeLog > * gcc/config/riscv/multilib-generator: Handle extensions > combination correctly. A ChangeLog entry should generally describe what a patch changes, not what it does. So this should mention a new variable

Re: [PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

I have run the whole patch series through check_GNU_style.sh and fixed up the formatting where indicated. Do I need to post the reformatted patchset? Thanks Kwok On 18/07/2019 10:24 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:04:10PM +0100, Kwok Cheung Yeung wrote: @@ -2319,7

[PATCH] RISC-V: Fix C ABI for flattened struct with 0-length bitfield.

This fixes a problem with the GCC implementation of the ABI, where we are accidentally emitting different code for the same struct when compiled by the C and C++ compilers. This was found by LLVM developers comparing the LLVM ABI to the GCC ABI. This affects any struct with one or more

[committed] add test for PR 50476

The expected warning is now issued so I resolved the bug and committed the test below in r274135. As an aside, the warning points to the pointer dereference but mentions the name of the local variable to which it points. Since the local variable is defined in a different function whose name

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

Hi Jim. Andreas: Thanks your review :) Committed with English improvements and ChangeLog update as r274137 On Tue, Aug 6, 2019 at 5:48 AM Jim Wilson wrote: > > On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > > gcc/ChangeLog > > * gcc/config/riscv/multilib-generator: Handle

[wwwdocs] Update C++ DR table

A couple of new DRs, plus some status updates. Applied to CVS. Index: cxx-dr-status.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/cxx-dr-status.html,v retrieving revision 1.25 diff -u -r1.25 cxx-dr-status.html ---

Re: [doc PATCH] document variable attribute alias

On 8/4/19 9:45 PM, Sandra Loosemore wrote: On 7/31/19 5:05 PM, Martin Sebor wrote: It was pointed out recently in another forum that GCC doesn't document attribute alias for variables.  It was also noted in the same discussion that the semantics of accessing aliases and their targets can have

Re: [doc PATCH] document variable attribute alias

On 8/5/19 4:43 PM, Martin Sebor wrote: On 8/4/19 9:45 PM, Sandra Loosemore wrote: [snip] OK with that fixed. Done in r274127. Since people tend to refer to the manual for older versions of the compiler I'd like to make this change on supported release branches as well.  If you see any

[committed] add C++ test for PR60517

The expected diagnostic is now issued so I resolved the bug and committed the test in r274130. Martin Index: gcc/testsuite/g++.dg/pr60517.C === --- gcc/testsuite/g++.dg/pr60517.C (nonexistent) +++

[PATCH v2 08/18] Use CONST_VECTOR_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_VECTOR

2019-08-05 Arvind Sankar gcc/ChangeLog: * common.md: Convert GET_CODE (..) == CONST_VECTOR to CONST_VECTOR_P (..). * config/aarch64/aarch64.c: Likewise. * config/alpha/alpha.c: Likewise. * config/arc/arc.c: Likewise. *

[PATCH v2 07/18] Add CONST_VECTOR_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_VECTOR. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 28b5a82d651..45e2b85867d 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -818,6 +818,9 @@ struct GTY(())

[PATCH v2 10/18] Use CONST_STRING_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_STRING

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/avr/avr.c: Convert GET_CODE (..) == CONST_STRING to CONST_STRING_P (..). * dwarf2out.c: Likewise. * genattrtab.c: Likewise. * gensupport.c: Likewise. 4 files changed, 15 insertions(+), 15

[PATCH v2 05/18] Use CONST_FIXED_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_FIXED

2019-08-05 Arvind Sankar gcc/ChangeLog: * cfgexpand.c: Convert GET_CODE (..) == CONST_FIXED to CONST_FIXED_P. * config/spu/spu.c: Likewise. * varasm.c: Likewise. 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/cfgexpand.c

[PATCH v2 15/18] Use LABEL_REF_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtlanal.c: Convert GET_CODE (..) == LABEL_REF to LABEL_REF_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/rtlanal.c b/gcc/rtlanal.c index cb6c8902353..a8becc85047 100644 --- a/gcc/rtlanal.c +++

[PATCH v2 09/18] Add CONST_STRING_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_STRING. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 45e2b85867d..d02772b65be 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -821,6 +821,9 @@ struct GTY(())

[PATCH v2 03/18] Use CONST_INT_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * combine-stack-adj.c: Convert GET_CODE (..) == CONST_INT to CONST_INT_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/combine-stack-adj.c b/gcc/combine-stack-adj.c index 3638a1b10ee..f98a0d54c98 100644

  1   2   >