Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Alexandre Oliva
On May 27, 2020, Andreas Schwab wrote: > Looks like tcl 8.5.5 has a bug: Ugh, how unfortunate. > % glob -nocomplain -path {} -- {a.{out,exe}} > % glob -nocomplain -path {} -- {a.{out,exe}*} > a.out Thanks for tracking that down, I'll put in some work around for that. -- Alexandre Oliva,

Re: [PATCH] gcc/Makefile.in: move SELFTEST_DEPS before including language makefile fragments

2020-05-27 Thread Romain Naour via Gcc-patches
Hi All, Le 22/05/2020 à 00:13, David Malcolm a écrit : > On Thu, 2020-05-21 at 17:35 +0200, Romain Naour wrote: >> As reported by several Buildroot users [1][2][3], the gcc build >> may fail while running selftests makefile target. >> >> The problem only occurs when ccache is used with gcc 9 and

Re: [PATCH] PR94397 the compiler consider "type is( real(kind(1.)) )" as a syntax error

2020-05-27 Thread Thomas Koenig via Gcc-patches
Hi Mark, ping the patch looks good do me. Regards Thomas

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-05-27 Thread Martin Liška
On 5/26/20 12:15 PM, Richard Sandiford wrote: So longer-term, I think we should replace VCOND(U) with individual ifns, like for VCONDEQ. We could reduce the number of optabs needed by canonicalising greater-based tests to lesser-based tests. Hello. Thanks for the feedback. So would it be

[PATCH] tree-optimization/95356 - fix vectorizable_shift vector types

2020-05-27 Thread Richard Biener
This makes sure to always use the same vector type for the shift operand as for the shifted operand. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2020-05-27 Richard Biener PR tree-optimization/95356 * tree-vect-stmts.c (vectorizable_shift): Adjust

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Richard Biener via Gcc-patches
On Wed, May 27, 2020 at 3:33 PM Eric Botcazou wrote: > > > Please use int128 effective target rather than lp64 in the tests that need > > __int128 type. > > OK, thanks, adjusted locally. OK. Thanks, Richard. > -- > Eric Botcazou

Re: [PATCH 0/7] Support vector load/store with length

2020-05-27 Thread Segher Boessenkool
On Wed, May 27, 2020 at 09:25:43AM +0200, Richard Biener wrote: > On Tue, 26 May 2020, Segher Boessenkool wrote: > > On Tue, May 26, 2020 at 01:29:30PM +0100, Richard Sandiford wrote: > > > FWIW, I agree adding .LEN_LOAD and .LEN_STORE seems like a good > > > approach. I think it'll be more

Re: Broken build

2020-05-27 Thread Alexandre Oliva
On May 26, 2020, Hans-Peter Nilsson wrote: >> Here's a proper patch submission. > And here's an improper bug report. :-) Thanks, H-P, > xgcc: error: : No such file or directory Interesting... If you cut the command line that you included in your so-called improper bug report ;-) do you get

[PATCH] gcc-changelog: enhance handling of renamings

2020-05-27 Thread Pierre-Marie de Rodat
So far, we expect from a commit that renames a file to contain a changelog entry only for the new name. For example, after the following commit: $ git move foo bar $ git commit We expect the following changelog: * bar: Renamed from foo. Git does not keep track of renamings, only file

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Andreas Schwab
On Mai 27 2020, Alexandre Oliva wrote: > On May 27, 2020, Andreas Schwab wrote: > >> Looks like tcl 8.5.5 has a bug: > > Ugh, how unfortunate. In fact, that bug exists in all versions. https://core.tcl-lang.org/tcl/tktview?name=5bbd044812 Andreas. -- Andreas Schwab, SUSE Labs,

Re: [PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-27 Thread Uros Bizjak via Gcc-patches
On Wed, May 27, 2020 at 8:02 AM Hongtao Liu wrote: > > On Mon, May 25, 2020 at 8:41 PM Uros Bizjak wrote: > > > > On Mon, May 25, 2020 at 2:21 PM Hongtao Liu wrote: > > > > > > According to Intel SDM, VPMOVQB xmm1/m16 {k1}{z}, xmm2 has 16-bit > > > memory_operand instead of 128-bit one which

[PATCH] tree-optimization/95295 - fix sinking after path merging in new SM code

2020-05-27 Thread Richard Biener
This fixes a missed sinking of remat stores across unrelated stores after merging from different paths. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. 2020-05-27 Richard Biener PR tree-optimization/95295 * tree-ssa-loop-im.c (sm_seq_valid_bb): Fix sinking after

Re: [stage1][PATCH] Make TOPN counter dynamically allocated.

2020-05-27 Thread Martin Liška
PING^2 On 5/15/20 11:57 AM, Martin Liška wrote: We're in stage1: PING^

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Jakub Jelinek via Gcc-patches
On Wed, May 27, 2020 at 11:23:32AM +0200, Eric Botcazou wrote: > gcc/testsuite/ChangeLog: > > * gcc.dg/builtin-bswap-10.c: New test. > * gcc.dg/builtin-bswap-11.c: Likewise. > * gcc.dg/builtin-bswap-12.c: Likewise. > * gcc.target/i386/builtin-bswap-5.c: Likewise. Please

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Eric Botcazou
> Please use int128 effective target rather than lp64 in the tests that need > __int128 type. OK, thanks, adjusted locally. -- Eric Botcazou

Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392

2020-05-27 Thread Thomas Koenig via Gcc-patches
Hi Mark, ping Looks good. Thanks!

RE: [PATCH PR95254] aarch64: gcc generate inefficient code with fixed sve vector length

2020-05-27 Thread Yangfei (Felix)
Hi, > -Original Message- > From: Richard Sandiford [mailto:richard.sandif...@arm.com] > Sent: Tuesday, May 26, 2020 11:58 PM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH PR95254] aarch64: gcc generate inefficient code with > fixed sve vector length > > Sorry

[PATCH 2/2] Code generate externals/invariants during the SLP graph walk

2020-05-27 Thread Richard Biener
This reaps the benefit of having the correct vector types on invariant SLP nodes. Bootstrap / regtest of this small series is underway on x86_64-unknown-linux-gnu. Comments welcome. Thanks, Richard. This generates vector defs for externals and invariants during the SLP walk rather than as

[PATCH 1/2] make vect_finish_stmt_generation work w/o stmt_vec_info

2020-05-27 Thread Richard Biener
This makes the call chain below vec_init_vector happy with a NULL stmt_vec_info which is used as "context". 2020-05-27 Richard Biener * tree-vect-stmts.c (vect_finish_stmt_generation_1): Conditionalize stmt_info use, assert the new stmt cannot throw when not specified.

[pushed] c++: operator<=> and -Wzero-as-null-pointer-constant [PR95242]

2020-05-27 Thread Jason Merrill via Gcc-patches
In C++20, if there is no viable operator< available, lhs < rhs gets rewritten to (lhs <=> rhs) < 0, where operator< for the comparison categories is intended to accept literal 0 on the RHS but not other integers. We don't want this to produce a warning from -Wzero-as-null-pointer-constant.

Re: zstd not found if installed in non-system prefix

2020-05-27 Thread Martin Liška
On 5/20/20 9:32 PM, Michael Kuhn wrote: Hi, when specifying a non-system prefix with --with-zstd, the build fails because the header and library cannot be found (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95005). The attached patch fixes the problem and is what we use in Spack to make

Re: [PATCH PR95332] gcov-tool: Flexible endian adjustment for merging coverage data

2020-05-27 Thread Martin Liška
On 5/27/20 12:35 PM, dongjianqiang (A) wrote: Thanks for your comments, I add the ChangeLog in the patch. Thanks. That patch is fine, please install it. Martin

[committed] libstdc++: Add new testcase for comparison category types

2020-05-27 Thread Jonathan Wakely via Gcc-patches
Comparing a comparison category type to anything except a literal 0 is undefined. This verifies that at least some misuses are diagnosed at compile time. * testsuite/18_support/comparisons/categories/zero_neg.cc: New test. Tested x86_64-linux, committed to master. commit

Re: [PATCH] PR fortran/95090 - ICE: identifier overflow

2020-05-27 Thread Thomas Koenig via Gcc-patches
Am 26.05.20 um 23:16 schrieb Harald Anlauf: Yet another obvious case of insufficient size of a temporary buffer. OK for master? Yes. Thanks a lot! Regards Thomas

[PR c++/95263] Revert alias template change

2020-05-27 Thread Nathan Sidwell
Sadly my attempt to make some aliast template construction immutable doesn't always apply. Reverting that patch and I guess more work needed on modules :( nathan -- Nathan Sidwell 2020-05-27 Nathan Sidwell PR c++/95263, revert 74744bb1f2847b5b9ce3e97e0fec9c23bb0e499f * pt.c

[PATCH] tree-optimization/95335 - fix SLP nodes dropped to invariant

2020-05-27 Thread Richard Biener
When we drop a SLP node to invariant because we cannot vectorize it we have to make sure to revisit it in the users. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. 2020-05-27 Richard Biener PR tree-optimization/95335 * tree-vect-slp.c

[pushed] c++: Fix stdcall attribute in template. [PR95222]

2020-05-27 Thread Jason Merrill via Gcc-patches
Another case that breaks with my fix for PR90750: we shouldn't move type attributes in TYPENAME context either, as there's no decl for them to move to. Tested x86_64-pc-linux-gnu, applying to trunk. gcc/cp/ChangeLog: PR c++/95222 * decl.c (grokdeclarator): Don't shift attributes

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-05-27 Thread Richard Biener via Gcc-patches
On May 27, 2020 6:13:24 PM GMT+02:00, Richard Sandiford wrote: >Martin Liška writes: >> On 5/26/20 12:15 PM, Richard Sandiford wrote: >>> So longer-term, I think we should replace VCOND(U) with individual >ifns, >>> like for VCONDEQ. We could reduce the number of optabs needed by >>>

Re: [PATCH] gcc-changelog: enhance handling of renamings

2020-05-27 Thread Martin Liška
On 5/27/20 7:50 PM, Martin Liška wrote: We'll need here a skip based on version of unidiff. So something like: @pytest.mark.skipif ? I believe something like: diff --git a/contrib/gcc-changelog/git_email.py b/contrib/gcc-changelog/git_email.py index 6e42629cf07..afa6771c7fe 100755 ---

Re: Broken build

2020-05-27 Thread Hans-Peter Nilsson via Gcc-patches
> From: Alexandre Oliva > Date: Wed, 27 May 2020 16:30:07 +0200 > On May 26, 2020, Hans-Peter Nilsson wrote: > > >> Here's a proper patch submission. > > > And here's an improper bug report. > > :-) > > Thanks, H-P, > > > xgcc: error: : No such file or directory > > Interesting... If you

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Andreas Schwab
Looks like tcl 8.5.5 has a bug: % glob -nocomplain -path {} -- {a.{out,exe}} % glob -nocomplain -path {} -- {a.{out,exe}*} a.out Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely

Re: [PATCH PR95332] gcov-tool: Flexible endian adjustment for merging coverage data

2020-05-27 Thread dongjianqiang (A)
Hi Martin, Thanks for your comments, I add the ChangeLog in the patch. Thanks, Dong JianQiang On 5/27/20 4:47 PM, Martin Liška wrote: > > On 5/27/20 5:00 AM, dongjianqiang (A) wrote: > > Hi GCC maintainers, > > > > Proposed patch to PR95332 - gcov-tool merge:"not a gcov data file" > > > > This

Re: [PATCH v2] arm: Warn if IRQ handler is not compiled with -mgeneral-regs-only [PR target/94743]

2020-05-27 Thread Christophe Lyon via Gcc-patches
Ping? On Thu, 14 May 2020 at 16:57, Christophe Lyon wrote: > > The interrupt attribute does not guarantee that the FP registers are > saved, which can result in problems difficult to debug. > > Saving the FP registers and status registers can be a large penalty, > so it's probably not desirable

Re: [PATCH, committed] [9/10/11 Regression] PR fortran/95104 - Segfault on a legal WAIT statement

2020-05-27 Thread Thomas Koenig via Gcc-patches
Am 26.05.20 um 23:33 schrieb Harald Anlauf: Committed as obvious. The invalid NULL pointer dereference was discovered by Steve Kargl. Will backport in a few days, when I figure out how to do it now. Thanks for committing this. The way to backport now is to first run

Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.

2020-05-27 Thread Richard Sandiford
Martin Liška writes: > On 5/26/20 12:15 PM, Richard Sandiford wrote: >> So longer-term, I think we should replace VCOND(U) with individual ifns, >> like for VCONDEQ. We could reduce the number of optabs needed by >> canonicalising greater-based tests to lesser-based tests. > > Hello. > > Thanks

Re: [PATCH PR95254] aarch64: gcc generate inefficient code with fixed sve vector length

2020-05-27 Thread Richard Sandiford
"Yangfei (Felix)" writes: >> > + >> > +{ >> > + x = x_inner; >> > +} >> > + else if (x_inner != NULL_RTX && MEM_P (y) >> > + && known_eq (GET_MODE_SIZE (x_inner_mode), >> GET_MODE_SIZE (mode)) >> > + && ! targetm.can_change_mode_class (x_inner_mode, mode, >> ALL_REGS) >> > +

[committed] i386: Implement V2SF shuffles

2020-05-27 Thread Uros Bizjak via Gcc-patches
2020-05-27 Uroš Bizjak gcc/ChangeLog: * config/i386/mmx.md (mmx_pswapdsf2): Add SSE alternatives. Enable insn pattern for TARGET_MMX_WITH_SSE. (*mmx_movshdup): New insn pattern. (*mmx_movsldup): Ditto. (*mmx_movss): Ditto. * config/i386/i386-expand.c

Re: [PATCH 1/2] make vect_finish_stmt_generation work w/o stmt_vec_info

2020-05-27 Thread Richard Sandiford
Richard Biener writes: > This makes the call chain below vec_init_vector happy with a NULL > stmt_vec_info which is used as "context". > > 2020-05-27 Richard Biener > > * tree-vect-stmts.c (vect_finish_stmt_generation_1): > Conditionalize stmt_info use, assert the new stmt cannot

Re: [PATCH v2] RS6000, add VSX mask manipulation support

2020-05-27 Thread Carl Love via Gcc-patches
GCC maintainers: I have addressed the following comments on the patch from Will: - ChangeLog: fixed name/symbol order; changed reference from rs6000-c.c to rs6000-builtin.def. - define_expand "vec_mtvsrbm": changed name to vec_mtvsrbm_mtvsrbmi, updated comment. -

Re: [PATCH 1/2] make vect_finish_stmt_generation work w/o stmt_vec_info

2020-05-27 Thread Richard Biener
On May 27, 2020 5:40:30 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> This makes the call chain below vec_init_vector happy with a NULL >> stmt_vec_info which is used as "context". >> >> 2020-05-27 Richard Biener >> >> * tree-vect-stmts.c

Re: [PATCH] gcc-changelog: enhance handling of renamings

2020-05-27 Thread Martin Liška
On 5/27/20 4:29 PM, Pierre-Marie de Rodat wrote: So far, we expect from a commit that renames a file to contain a changelog entry only for the new name. For example, after the following commit: $ git move foo bar $ git commit We expect the following changelog: * bar: Renamed from

[PATCH] mklog: support renaming of files

2020-05-27 Thread Martin Liška
Hi. There's a patch that utilizes newly added functionality in unidiff 0.6.0. It newly generates: diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf2.c similarity index 100% rename from gcc/ipa-icf.c rename to gcc/ipa-icf2.c $ ./contrib/mklog.py 0001-test.patch gcc/ChangeLog: * ipa-icf.c: Moved

[committed] libstdc++: Fix atomic::load (PR 95282)

2020-05-27 Thread Jonathan Wakely via Gcc-patches
PR libstdc++/95282 * include/bits/atomic_base.h (__atomic_impl::load): Add cv-qualifiers to parameter so that _Tp is deduced as the unqualified type. * testsuite/29_atomics/atomic_float/95282.cc: New test. Tested powerpc64le-linbux, committed to master.

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Jeff Law via Gcc-patches
On Wed, 2020-05-27 at 19:05 -0300, Alexandre Oliva wrote: > outputs.exp: no lto, linker default output, cdtor temps, empty args > > From: Alexandre Oliva > > This patch fixes various issues in the testsuite that came up after > the dump/aux output revamp, namely: > > - many outputs.exp tests

Re: [PATCH] Port libgccjit to Windows.

2020-05-27 Thread Nicolas Bértolo via Gcc-patches
Hi, > Do you have commit/push access to the gcc repository? No I don't. > BTW, why isn't it necessary to use --enable-host-shared in Windows? > Can we document that? That's because all code is position independent in Windows. > On the subject of nitpicking, I find myself getting distracted by

Re: [PATCH] gcc: xtensa: delegitimize UNSPEC_PLT

2020-05-27 Thread Max Filippov via Gcc-patches
On Wed, May 27, 2020 at 4:35 PM augustine.sterl...@gmail.com wrote: > > On Tue, May 26, 2020 at 11:43 AM Max Filippov wrote: > > > > This fixes 'non-delegitimized UNSPEC 3 found in variable location' notes > > issued when building libraries which interferes with running tests. > > > > 2020-05-24

Re: [PATCH] gcc: xtensa: delegitimize UNSPEC_PLT

2020-05-27 Thread augustine.sterling--- via Gcc-patches
On Tue, May 26, 2020 at 11:43 AM Max Filippov wrote: > > This fixes 'non-delegitimized UNSPEC 3 found in variable location' notes > issued when building libraries which interferes with running tests. > > 2020-05-24 Max Filippov > gcc/ > * config/xtensa/xtensa.c

Re: Broken build

2020-05-27 Thread Anthony Green
Hans-Peter Nilsson via Gcc-patches writes: > And here's an improper bug report. > > One of the commits between cfdff3eeb90..5c8344e7289 caused every > single *linked* test to fail for cris-elf, like: I can confirm that the moxie-elf test cases don't link either. It looks like setting ldscript

Re: Broken build

2020-05-27 Thread Alexandre Oliva
On May 27, 2020, Hans-Peter Nilsson wrote: >> I ask because this error suggests an empty argument passed to >> GCC. > And ignored before your rewrite? Or absent. It turned out my massaging of ldflags et al turned consecutive blanks into empty arguments. I posted a patch for that and most of

Re: [PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-27 Thread Kewen.Lin via Gcc-patches
on 2020/5/27 下午6:02, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> Thanks for your comments! >> >> on 2020/5/26 锟斤拷锟斤拷8:49, Richard Sandiford wrote: >>> "Kewen.Lin" writes: @@ -626,6 +645,12 @@ public: /* True if have decided to use a fully-masked loop. */

Re: [PATCH PR95332] gcov-tool: Flexible endian adjustment for merging coverage data

2020-05-27 Thread dongjianqiang (A)
Thanks for reviewing this. Could you please help install this patch? I am not a gcc commiter. Regards, Dong JianQiang > > On 5/27/20 12:35 PM, dongjianqiang (A) wrote: > > Thanks for your comments, I add the ChangeLog in the patch. > > Thanks. That patch is fine, please install it. > >

Ping^1 [PATCH 2/4 V3] Add target hook stride_dform_valid_p

2020-05-27 Thread Kewen.Lin via Gcc-patches
Hi, Gentle ping patches as below: 1/4 v3 https://gcc.gnu.org/pipermail/gcc-patches/2020-February/540171.html 2/4 v3 https://gcc.gnu.org/pipermail/gcc-patches/2020-March/541387.html 3/4 v3 https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545643.html Or shall I ping them seperately? Thanks!

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Alexandre Oliva
outputs.exp: no lto, linker default output, cdtor temps, empty args From: Alexandre Oliva This patch fixes various issues in the testsuite that came up after the dump/aux output revamp, namely: - many outputs.exp tests used -flto without checking that LTO was supported, getting lots of

[PATCH] c++: constexpr RANGE_EXPR ctor indexes [PR95241]

2020-05-27 Thread Patrick Palka via Gcc-patches
In the testcase below, the CONSTRUCTOR for 'field' contains a RANGE_EXPR index: {aggr_init_expr<...>, [1...2]={.off=1}} but get_or_insert_ctor_field isn't prepared to handle RANGE_EXPR indexes. This patch adds limited support for RANGE_EXPR indexes to get_or_insert_ctor_field. The limited

[comitted] i386: Fix V2SF horizontal add/subtract insns

2020-05-27 Thread Uros Bizjak via Gcc-patches
PFPNACC insn is incorrectly modelled to perform addition and subtraction of two operands, but in reality it performs horizontal addition and subtraction: Instruction: PFPNACC dest,src Description: dest[31:0] <- dest[31:0] - dest[63:32]; dest[63:32] <- src[31:0] + src[63:32]; Also, it is not

[pushed] c++: Handle multiple aggregate overloads [PR95319].

2020-05-27 Thread Jason Merrill via Gcc-patches
Here, when considering the two 'insert' overloads, we look for aggregate conversions from the same initializer-list to B<3> or initializer_list>. But since my fix for reshape_init overhead on the PR14179 testcase we reshaped the initializer-list directly, leading to an error when we then tried to

[committed] i386: Remove %q modifier from two pmov insn templates [PR95355]

2020-05-27 Thread Uros Bizjak via Gcc-patches
2020-05-27 Uroš Bizjak gcc/ChangeLog: PR target/95355 * config/i386/sse.md (avx512f_v16qiv16si2): Remove %q operand modifier from insn template. (avx512f_v8hiv8di2): Ditto. gcc/testsuite/ChangeLog: PR target/95355 * gcc.target/i386/pr95355.c: New test.

Re: [PATCH] c++: constexpr RANGE_EXPR ctor indexes [PR95241]

2020-05-27 Thread Patrick Palka via Gcc-patches
On Wed, 27 May 2020, Patrick Palka wrote: > In the testcase below, the CONSTRUCTOR for 'field' contains a > RANGE_EXPR index: > > {aggr_init_expr<...>, [1...2]={.off=1}} > > but get_or_insert_ctor_field isn't prepared to handle RANGE_EXPR > indexes. > > This patch adds limited support for

[commmitted] jit: fix libgccjit.info entry [PR 91330]

2020-05-27 Thread David Malcolm via Gcc-patches
2020-05-27 Tom Tromey gcc/jit/ChangeLog: PR jit/91330 * docs/conf.py (texinfo_documents): Set description. * docs/_build/texinfo/libgccjit.texi: Regenerate. --- gcc/jit/docs/_build/texinfo/libgccjit.texi | 2 +- gcc/jit/docs/conf.py | 2 +- 2

Aw: Re: [PATCH, committed] [9/10/11 Regression] PR fortran/95104 - Segfault on a legal WAIT statement

2020-05-27 Thread Harald Anlauf
Hi Thomas, thanks for the hint: > Von: "Thomas Koenig" > Am 26.05.20 um 23:33 schrieb Harald Anlauf: > > Will backport in a few days, when I figure out how to do it now. > > The way to backport now is to first run contrib/gcc-git-customization.sh > from current master, and then change to the

[committed] jit: use deep unsharing of trees [PR 95314]

2020-05-27 Thread David Malcolm via Gcc-patches
PR jit/95314 reports a internal error inside verify_gimple, which turned out to be due to reusing the result of gcc_jit_lvalue_get_address in several functions, leading to tree nodes shared between multiple function bodies. This patch fixes the issue by adopting the "Deep unsharing" strategy

[committed] libstdc++: Fix std::reverse_iterator comparisons (PR 94354)

2020-05-27 Thread Jonathan Wakely via Gcc-patches
The std::reverse_iterator comparisons have always been implemented only in terms of equality and less than. In C++98 that made no difference for reasonable code, because when the underlying operators are the same type they are required to support all comparisons anyway. But since LWG 280 it's

[committed] libstdc++: Fix view adaptors for mixed-const sentinels and iterators (PR 95322)

2020-05-27 Thread Jonathan Wakely via Gcc-patches
The bug report is that transform_view's sentinel cannot be compared to its iterator. The comparison is supposed to use operator==(iterator, sentinel) after converting sentinel to sentinel. However, the operator== is a hidden friend so is not a candidate when comparing iterator with sentinel. The

Re: [PATCH] c++: constexpr RANGE_EXPR ctor indexes [PR95241]

2020-05-27 Thread Patrick Palka via Gcc-patches
On Wed, 27 May 2020, Patrick Palka wrote: > On Wed, 27 May 2020, Patrick Palka wrote: > > > In the testcase below, the CONSTRUCTOR for 'field' contains a > > RANGE_EXPR index: > > > > {aggr_init_expr<...>, [1...2]={.off=1}} > > > > but get_or_insert_ctor_field isn't prepared to handle

Re: [PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-27 Thread Hongtao Liu via Gcc-patches
On Wed, May 27, 2020 at 8:01 PM Uros Bizjak wrote: > > On Wed, May 27, 2020 at 8:02 AM Hongtao Liu wrote: > > > > On Mon, May 25, 2020 at 8:41 PM Uros Bizjak wrote: > > > > > > On Mon, May 25, 2020 at 2:21 PM Hongtao Liu wrote: > > > > > > > > According to Intel SDM, VPMOVQB xmm1/m16

[committed] openmp: Fix up omp_declare_variant{s, _alt} htab handling [PR95315]

2020-05-27 Thread Jakub Jelinek via Gcc-patches
Hi! This patch fixes a GC ICE. During debugging, I've found that during gimplification we can actually call omp_resolve_declare_variant multiple times and it would create a new magic declare_variant_alt FUNCTION_DECL each time, which is undesirable, once we have such a decl, we should just use

Re: [PATCH PR95332] gcov-tool: Flexible endian adjustment for merging coverage data

2020-05-27 Thread Martin Liška
On 5/27/20 5:00 AM, dongjianqiang (A) wrote: Hi GCC maintainers, Proposed patch to PR95332 - gcov-tool merge:"not a gcov data file" This error occurs when using gcov-tool merge dir1 dir2 where dir1 and dir2 are the directories containing the .gcda files which were generated by different

Re: [PATCH 0/7] Support vector load/store with length

2020-05-27 Thread Kewen.Lin via Gcc-patches
on 2020/5/27 下午3:25, Richard Biener wrote: > On Tue, 26 May 2020, Segher Boessenkool wrote: > >> Hi! >> >> On Tue, May 26, 2020 at 01:29:30PM +0100, Richard Sandiford wrote: >>> FWIW, I agree adding .LEN_LOAD and .LEN_STORE seems like a good >>> approach. I think it'll be more maintainable in

[PATCH] c++: Try to complete decomp types [PR95328]

2020-05-27 Thread Jakub Jelinek via Gcc-patches
Hi! Two years ago Paolo has added the else if (processing_template_decl && !COMPLETE_TYPE_P (type)) pedwarn (...); lines into cp_finish_decomp. For type dependent decl we punt much earlier, but even for types which aren't type dependent COMPLETE_TYPE_P might be false as this testcase

Re: [PATCH 0/7] Support vector load/store with length

2020-05-27 Thread Richard Sandiford
Richard Biener writes: > On Tue, 26 May 2020, Jim Wilson wrote: > >> On Tue, May 26, 2020 at 12:12 AM Richard Biener wrote: >> > From a look at the series description below you seem to add a new way >> > of doing loads for this. Did you review other ISAs (those I'm not >> > familiar with myself

[PATCH] Rewrite maintainer-scripts/update_version_git

2020-05-27 Thread Jakub Jelinek via Gcc-patches
Hi! This patch rewrites update_version_git to be just a thin wrapper around Martin's new python script. This just arranges to check out the gcc repo in a temporary directory, copy out the contrib scripts so that the running script doesn't change with branch checkouts and runs the script. I've

Re: [PATCH] Rewrite maintainer-scripts/update_version_git

2020-05-27 Thread Richard Biener
On Wed, 27 May 2020, Jakub Jelinek wrote: > Hi! > > This patch rewrites update_version_git to be just a thin wrapper around > Martin's new python script. This just arranges to check out the gcc > repo in a temporary directory, copy out the contrib scripts so that > the running script doesn't

Re: [PATCH RFC] gcc-git: Add prepare-commit-msg hook.

2020-05-27 Thread Martin Liška
On 5/26/20 8:02 PM, Jason Merrill wrote: Maybe these environment variables should start with GCC_GIT, not just GCC, to  give more indication what they're for. All right, I renamed it and pushed to master. Martin

Re: New mklog script

2020-05-27 Thread Martin Liška
On 5/26/20 8:06 PM, Jason Merrill wrote: gcc-ci-log would be better if you want something short; I'd prefer gcc-commit-mklog, and let people define their own shorter aliases as desired. Hello. There's a rename I'm going to install. Martin >From b423f910dcc2a58a86b61cc5b966a81066abbf12 Mon

Re: [PATCH 1/2] rs6000: tune cunroll for simple loops at O2

2020-05-27 Thread Richard Biener via Gcc-patches
On Wed, May 27, 2020 at 6:36 AM Jiufu Guo wrote: > > Segher Boessenkool writes: > > > Hi! > > > > On Tue, May 26, 2020 at 08:58:13AM +0200, Richard Biener wrote: > >> On Mon, May 25, 2020 at 7:44 PM Segher Boessenkool > >> wrote: > >> > Yes, cunroll does not have its own option, and that is a

Re: New mklog script

2020-05-27 Thread Martin Liška
On 5/26/20 5:38 PM, Martin Sebor wrote: By the way, it's nice that the existing gcc- aliases are documented on https://gcc.gnu.org/gitwrite.html.  I would suggest to add this one there as well. Yes. I added the documentation bit and pushed ho master. Martin >From

Re: [PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-27 Thread Kewen.Lin via Gcc-patches
Hi Richard, Thanks for your comments! on 2020/5/26 下午8:49, Richard Sandiford wrote: > "Kewen.Lin" writes: >> @@ -626,6 +645,12 @@ public: >>/* True if have decided to use a fully-masked loop. */ >>bool fully_masked_p; >> >> + /* Records whether we still have the option of using a

Re: [PATCH] PR94397 the compiler consider "type is( real(kind(1.)) )" as a syntax error

2020-05-27 Thread Mark Eggleston
ping On 13/05/2020 18:19, Mark Eggleston wrote: Please find attached a patch for PR94397. Commit message: Fortran  : "type is( real(kind(1.)) )" spurious syntax error PR94397 Based on a patch in the comments of the PR. That patch fixed this problem but caused the test cases for PR93484 to

Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392

2020-05-27 Thread Mark Eggleston
ping On 19/05/2020 08:49, Mark Eggleston wrote: Please find attached patch for PR50392. This patch was extracted from the comments in the PR and was written back in 2011! I have verified that it fixes the PR on master, gcc-8, gcc-9 and gcc-10. Commit message: Fortran  : ICE in

Re: [PATCH] Add debug (slp_tree) and dump infrastructure for this

2020-05-27 Thread Richard Biener
On Tue, 26 May 2020, David Malcolm wrote: > On Mon, 2020-05-25 at 16:56 +0200, Richard Biener wrote: > > This adds an alternate debug_dump_context similar to the one for > > selftests but for interactive debugging routines. This allows > > to share code between user-visible dumping via the

Re: [PATCH 0/7] Support vector load/store with length

2020-05-27 Thread Richard Biener
On Tue, 26 May 2020, Jim Wilson wrote: > On Tue, May 26, 2020 at 12:12 AM Richard Biener wrote: > > From a look at the series description below you seem to add a new way > > of doing loads for this. Did you review other ISAs (those I'm not > > familiar with myself too much are SVE, RISC-V and

Re: [PATCH 0/7] Support vector load/store with length

2020-05-27 Thread Richard Biener
On Tue, 26 May 2020, Segher Boessenkool wrote: > Hi! > > On Tue, May 26, 2020 at 01:29:30PM +0100, Richard Sandiford wrote: > > FWIW, I agree adding .LEN_LOAD and .LEN_STORE seems like a good > > approach. I think it'll be more maintainable in the long run than > > trying to have .MASK_LOADs

Re: [PATCH] Fix nonconforming memory_operand for vpmov instructions which has memory operand narrow than 128 bits [avx512f]

2020-05-27 Thread Hongtao Liu via Gcc-patches
On Mon, May 25, 2020 at 8:41 PM Uros Bizjak wrote: > > On Mon, May 25, 2020 at 2:21 PM Hongtao Liu wrote: > > > > According to Intel SDM, VPMOVQB xmm1/m16 {k1}{z}, xmm2 has 16-bit > > memory_operand instead of 128-bit one which exists in current > > implementation. Also for other vpmov

[patch] Add support for __builtin_bswap128

2020-05-27 Thread Eric Botcazou
Hi, this patch introduces a new builtin named __builtin_bswap128 on targets where TImode is supported, i.e. 64-bit targets only in practice. The implementation simply reuses the existing double word path in optab, so no routine is added to libgcc (which means that you get two calls to

[PATCH] aarch64: add support for unpacked EOR, ORR and AND

2020-05-27 Thread Joe Ramsay
Hi! This patch improves code generation for EOR, ORR and AND on unpacked vectors with SVE. The following function: void f (unsigned int *x, unsigned short *y, unsigned short *z) { for (int i = 0; i < 7; ++i) x[i] = (unsigned short) (y[i] & z[i]); } previously compiled to ptrue p1.d, vl3

[PATCH] Ada: Bump version to 11.

2020-05-27 Thread Martin Liška
Hello. I'm packaging a new gcc11 package and I noticed this needs to be bumped. Ready for master? Thanks, Martin gcc/ada/ChangeLog: * gnatvsn.ads: Bump Library_Version to 11. --- gcc/ada/gnatvsn.ads | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] Ada: Bump version to 11.

2020-05-27 Thread Arnaud Charlet
> I'm packaging a new gcc11 package and I noticed this needs to be bumped. > > Ready for master? Yes, thanks. > gcc/ada/ChangeLog: > > * gnatvsn.ads: Bump Library_Version to 11. > --- > gcc/ada/gnatvsn.ads | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] c++: Fix bogus "does not declare anything" warning (PR 66159)

2020-05-27 Thread Jonathan Wakely via Gcc-patches
G++ gives a bogus warning for 'struct A; using B = struct ::A;' complaining that the elaborated-type-specifier doesn't declare anything. That's true, but it's not trying to declare struct ::A, just refer to it unambiguously. Do not emit the warning unless we're actually parsing a declaration.

Re: drop -aux{dir,base}, revamp -dump{dir,base}

2020-05-27 Thread Andreas Schwab
FAIL: outputs exe default 1: a.{out,exe} FAIL: outputs exe default 1: extra a.out FAIL: outputs exe default 2: a.{out,exe} FAIL: outputs exe default 2: extra a.out FAIL: outputs exe savetmp unnamed1: a.{out,exe} FAIL: outputs exe savetmp unnamed1: extra a.out FAIL: outputs exe savetmp unnamed2:

Re: [PATCH 5/7] vect: Support vector load/store with length in vectorizer

2020-05-27 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi Richard, > > Thanks for your comments! > > on 2020/5/26 锟斤拷锟斤拷8:49, Richard Sandiford wrote: >> "Kewen.Lin" writes: >>> @@ -626,6 +645,12 @@ public: >>>/* True if have decided to use a fully-masked loop. */ >>>bool fully_masked_p; >>> >>> + /* Records whether