Re: [PATCH v2] testsuite: Fix test failures from outputs.exp [PR98225]

Hi Bernd, > On 1/8/21 8:27 PM, David Edelsohn wrote: >> Hi, Bernd >> >> Thanks for investigating this and creating a revised version of the >> patch. With the second patch, the gcc.misc-test/outputs.exp results >> are clean on AIX. >> > > Many thanks for confirming that the patch works. > > Is

Re: [PATCH] [WIP] openmp: Add OpenMP 5.0 task detach clause support

Hello Thanks for the review. Due to the Christmas holidays I have not finished addressing all these issues yet, but I expect to be done by the end of this week. Can this patch still make it for GCC 10, as I believe stage 4 is starting soon? Thanks Kwok On 10/12/2020 2:38 pm, Jakub Jelinek

Re: [PATCH] libstdc++: implement locale support for AIX

Hi, Clement The patch is local to libstdc++ AIX support, so I believe that I can approve it. libstdc++ loads the gcc testsuite target-supports.exp extensions. The patch needs to update the libstdc++ testcases to require wchar32 or utf-8 as appropriate to avoid the failures. Thanks, David On

Re: [PATCH] [x86]Delete dead code in ix86_expand_sse_comi.[PR98612]

On Mon, Jan 11, 2021 at 11:28 AM Hongtao Liu wrote: > > Hi: > d->flag is always 0 for builtins located in > BDESC_FIRST (comi,COMI,...) > ... > BDESC_END (COMI, PCMPESTR) > So the condition can be deleted, so did BUILTIN_DESC_SWAP_OPERANDS. > > Regtested and bootstrapped on

RE: [PATCH 5/8 v9]middle-end slp: support complex multiply and complex multiply conjugate

On Mon, 11 Jan 2021, Tamar Christina wrote: > Hi Richi, > > This adds support for complex multiply and complex multiply and accumulate to > the vect pattern detector. > > Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu > and no issues. > > Ok for master? (I replied to a

Re: [PATCH v4 01/29] Add and organize macros.

Some initial comments. On 11/01/2021 11:10, g...@danielengel.com wrote: > From: Daniel Engel > > These definitions facilitate subsequent patches in this series. > > gcc/libgcc/ChangeLog: > 2021-01-07 Daniel Engel > > * config/arm/t-elf: Organize functions into logical groups. > *

Re: [PATCH] libstdc++: implement locale support for AIX

Hi David, Clement, > The patch is local to libstdc++ AIX support, so I believe that I can approve > it. have you considered merging the dragonfly and aix trees? I'm asking because it seems prudent to try and avoid creating more and more almost-but-not-quite-similar configurations (Solaris

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

On Sat, 9 Jan 2021 at 14:09, Christophe Lyon wrote: > > On Sat, 9 Jan 2021 at 13:27, Daniel Engel wrote: > > > > On Thu, Jan 7, 2021, at 4:56 AM, Richard Earnshaw wrote: > > > On 07/01/2021 00:59, Daniel Engel wrote: > > > > --snip-- > > > > > > > > On Wed, Jan 6, 2021, at 9:05 AM, Richard

Re: [PATCH v2] aarch64: Add cpu cost tables for A64FX

"Qian, Jianhua" writes: > Hi Richard > >> -Original Message- >> From: Richard Sandiford >> Sent: Friday, January 8, 2021 7:04 PM >> To: Qian, Jianhua/钱 建华 >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH v2] aarch64: Add cpu cost tables for A64FX >> >> Qian Jianhua writes: >> >

Re: [PATCH] Optimize macro: make it more predictable

I'm suggesting postponing this to GCC 12 as I'm planning a bigger target/optimize attribute (pragma) overhaul. Martin On 12/7/20 12:03 PM, Martin Liška wrote: PING^2 On 11/26/20 2:56 PM, Martin Liška wrote: PING^1 On 11/9/20 11:35 AM, Martin Liška wrote: On 11/3/20 2:34 PM, Jakub Jelinek

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

On 09/01/2021 18:04, Daniel Engel wrote: > On Sat, Jan 9, 2021, at 5:09 AM, Christophe Lyon wrote: >> On Sat, 9 Jan 2021 at 13:27, Daniel Engel wrote: >>> >>> On Thu, Jan 7, 2021, at 4:56 AM, Richard Earnshaw wrote: On 07/01/2021 00:59, Daniel Engel wrote: > --snip-- > > On Wed,

Re: [PATCH v4 02/29] Refactor 'clz' functions into a new file.

On 11/01/2021 15:26, Richard Earnshaw wrote: > On 11/01/2021 11:10, g...@danielengel.com wrote: >> From: Daniel Engel >> >> gcc/libgcc/ChangeLog: >> 2021-01-07 Daniel Engel >> >> * config/arm/lib1funcs.S: Move __clzsi2() and __clzdi2() to >> * config/arm/bits/clz2.S: New file. > > No,

Re: [PATCH] libstdc++: implement locale support for AIX

On 11/01/21 16:35 +0100, Rainer Orth wrote: Hi David, Clement, The patch is local to libstdc++ AIX support, so I believe that I can approve it. have you considered merging the dragonfly and aix trees? I'm asking because it seems prudent to try and avoid creating more and more

Re: [PATCH] Fix UBSAN bootstrap

On 1/11/21 5:38 AM, Jakub Jelinek wrote: On Mon, Jan 11, 2021 at 11:26:42AM +0100, Martin Liška wrote: Problem here was that GCC-related options are not applied in stage2 (and later stages). It's caused by fact that CXX is xg++ in stage2 (and later stages). Fixed with the following patch.

Re: --enable-link-serialization=1 doesn't work

On 1/9/21 7:52 PM, Matthias Klose wrote: > The attached patch makes the link targets a little bit more verbose. Ok to > commit? approved by Jakub on IRC, checked in. > It shows that --enable-link-serialization=1 doesn't work: > > $ grep ^Linking ../log > Linking gnat1 |==-- |

Re: [PATCH v4 03/29] Refactor 'ctz' functions into a new file.

On 11/01/2021 11:10, g...@danielengel.com wrote: > From: Daniel Engel > > gcc/libgcc/ChangeLog: > 2021-01-07 Daniel Engel > > * config/arm/lib1funcs.S: Move __ctzsi2() to > * config/arm/bits/ctz2.S: New file. Similar to the previous patch, just use ctz.S without the bits subdir.

Re: [PATCH] libstdc++: implement locale support for AIX

Hi Clement, > Would "Skip if target = aix" be ok, especially for the few that I have > absolutely no idea why they are failing ? you should try to avoid such skips if at all possible. Should the tests start to PASS in the future, either due to AIX changes or changes in libstdc++, this would go

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

On Mon, Jan 11, 2021, at 8:07 AM, Christophe Lyon wrote: > On Sat, 9 Jan 2021 at 14:09, Christophe Lyon > wrote: > > > > On Sat, 9 Jan 2021 at 13:27, Daniel Engel wrote: > > > > > > On Thu, Jan 7, 2021, at 4:56 AM, Richard Earnshaw wrote: > > > > On 07/01/2021 00:59, Daniel Engel wrote: > > > >

RE: [PATCH 1/8 v9]middle-end slp: Support optimizing load distribution

On Mon, 11 Jan 2021, Tamar Christina wrote: > Hi Richi, > > Attached is the updated patch. > > Note that testcases for all of these will be committed with the patch but I'm > Finishing up the 32-bit Arm changes to mirror the changes the AArch64 > maintainer > wanted and then have to do

[committed] d: Remove visibility and lookup deprecation

Hi, This patch merges the D front-end implementation with upstream dmd 2d3d13748, removing the visibility and lookup deprecation. The deprecation phase for access checks is finished. The `-ftransition=import` and `-ftransition=checkimports` switches no longer have an effect and are now removed.

[PATCH] tree-optimization/98526 - fix vectorizer reduction cost

This fixes a double-counting in the reduction cost when vectorizing the reduction through the regular vectorizable_* functions. Bootstrapped / tested on x86_64-unknown-linux-gnu, pushed. 2021-01-11 Richard Biener PR tree-optimization/98526 * tree-vect-loop.c

[PATCH] tree-optimization/91403 - avoid excessive code-generation

The vectorizer, for large permuted grouped loads, generates inefficient intermediate code (cleaned up only later) that runs into complexity issues in SCEV analysis and elsewhere. For the non-single-element interleaving case we already put a hard limit in place, this applies the same limit to the

Re: [PATCH] libstdc++: implement locale support for AIX

Hi David, Alright, I'll see what I can do. Would "Skip if target = aix" be ok, especially for the few that I have absolutely no idea why they are failing ? Clément From: David Edelsohn Sent: Monday, January 11, 2021 4:03 PM To: CHIGOT, CLEMENT Cc:

Re: [PATCH v4 04/29] Refactor 64-bit shift functions into a new file.

On 11/01/2021 11:10, g...@danielengel.com wrote: > From: Daniel Engel > > gcc/libgcc/ChangeLog: > 2021-01-07 Daniel Engel > > * config/arm/lib1funcs.S: Move __ashldi3(), __ashrdi3(), __lshldi3() to > * config/arm/bits/shift.S: New file. Again, drop the bits/ R. > --- >

Re: [PATCH v4 02/29] Refactor 'clz' functions into a new file.

On Mon, Jan 11, 2021, at 7:39 AM, Richard Earnshaw wrote: > On 11/01/2021 15:26, Richard Earnshaw wrote: > > On 11/01/2021 11:10, g...@danielengel.com wrote: > >> From: Daniel Engel > >> > >> gcc/libgcc/ChangeLog: > >> 2021-01-07 Daniel Engel > >> > >>* config/arm/lib1funcs.S: Move

Re: [committed] d: Support deprecated, @disable, and user-defined attributes on enum members

Excerpts from Andreas Schwab's message of January 10, 2021 9:08 am: > ../../gcc/d/dmd/parse.c: In member function 'Dsymbols* > Parser::parseDeclDefs(int, Dsymbol**, PrefixAttributes*)': > ../../gcc/d/dmd/parse.c:647:29: error: unused variable 'e' > [-Werror=unused-variable] > 647 |

Re: [PATCH] testsuite: Fix test failures from outputs.exp [PR98225]

Hi Alexandre, > On Jan 7, 2021, Bernd Edlinger wrote: > >> I don't know why that is there in the first place, as there >> are no C++ test cases, these files should not be created at all. > > collect2, on platforms that use it, create .cdtor files even for C. > David Edelsohn told me so back

Re: [PATCH v4 02/29] Refactor 'clz' functions into a new file.

On 11/01/2021 11:10, g...@danielengel.com wrote: > From: Daniel Engel > > gcc/libgcc/ChangeLog: > 2021-01-07 Daniel Engel > > * config/arm/lib1funcs.S: Move __clzsi2() and __clzdi2() to > * config/arm/bits/clz2.S: New file. No, please don't push these down into a subdirectory.

Re: [PATCH] libstdc++: implement locale support for AIX

>> Hi David, Clement, >> >>> The patch is local to libstdc++ AIX support, so I believe that I can >>> approve it. >> >>have you considered merging the dragonfly and aix trees? I'm asking >>because it seems prudent to try and avoid creating more and more >>almost-but-not-quite-similar

Re: [PATCH] libphobos: Allow building libphobos using Solaris/x86 assembler

Excerpts from Iain Buclaw's message of January 7, 2021 6:48 pm: > Excerpts from Rainer Orth's message of January 7, 2021 5:17 pm: >> Hi Iain, >> The Solaris assemblers don't support UTF-8 identifiers. Unless gdc can encode them in some way for toolchains like this (no idea if this is

Re: [PATCH] Properly release symtab::m_clones.

On 1/11/21 5:55 PM, Jan Hubicka wrote: The patch is about not using delete for a memory that is allocated by GGC. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR jit/98615 * symtab-clones.h

[pushed] aarch64: Add support for unpacked SVE ABD

This patch adds support for unpacked SVE SABD and UABD. It also rewrites the patterns so that they match as combine patterns without the need for REG_EQUAL notes. Finally, there was no pattern for merging with the second input, which can be handled by reversing the operands. The type suffix

[pushed] aarch64: Add support for unpacked SVE MULH

This patch extends the SMULH and UMULH support to unpacked vectors. The type suffix must be taken from the element size rather than the container size. The main use of these patterns is to support division and modulus by a constant. The conditional forms would be hard to trigger from non-ACLE

Re: [PATCH] match.pd: Add ~(X - Y) -> ~X + Y simplification [PR96685]

On 1/9/21 5:43 PM, Maciej W. Rozycki wrote: > On Mon, 21 Dec 2020, Jakub Jelinek wrote: > This patch adds the ~(X - Y) -> ~X + Y simplification requested in the PR (plus also ~(X + C) -> ~X + (-C) for constants C that can be safely negated. >>> This regresses VAX code produced

[PATCH 1/2] GCC: Check if AR works with --plugin and rc

AR from older binutils doesn't work with --plugin and rc: [hjl@gnu-cfl-2 bin]$ touch foo.c [hjl@gnu-cfl-2 bin]$ ar --plugin /usr/libexec/gcc/x86_64-redhat-linux/10/liblto_plugin.so rc libfoo.a foo.c [hjl@gnu-cfl-2 bin]$ ./ar --plugin /usr/libexec/gcc/x86_64-redhat-linux/10/liblto_plugin.so rc

[PATCH 2/2] Binutils: Check if AR works with --plugin and rc

Check if AR works with --plugin and rc before passing --plugin to AR and RANLIB. bfd/ PR ld/27173 binutils/ PR ld/27173 * configure: Regenerated. gas/ PR ld/27173 * configure: Regenerated. gprof/ PR ld/27173 * configure: Regenerated.

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

On 1/11/21 9:30 AM, Matthias Klose wrote: On 1/10/21 10:18 PM, Martin Sebor wrote: On 1/10/21 3:29 AM, Matthias Klose wrote: is the newline intended? It's followed by a debug_rtx call. To avoid the warning there shouldn't be any trailing punctuation or whitespace in the message.  The GCC

[pushed] aarch64: Add general unpacked SVE conditional binary arithmetic

This patch adds support for conditional binary ADD, SUB, MUL, SMAX, UMAX, SMIN, UMIN, LSL, LSR, ASR, AND, ORR and EOR. It's not really possible to split it up further given how the patterns are written. Min, max and right-shift need the element size rather than the container size. The others

[pushed] aarch64: Add support for unpacked SVE mult, max and min

This patch makes the SVE_INT_BINARY_IMM patterns support unpacked arithmetic, covering MUL, SMAX, SMIN, UMAX and UMIN. For min and max, the type suffix must be taken from the element size rather than the container size. The XFAILs are due to PR98602. Tested on aarch64-linux-gnu and

Re: [PATCH] VAX/testsuite: Remove notsi comparison elimination regressions

On 1/10/21 7:45 AM, Maciej W. Rozycki wrote: > On Fri, 8 Jan 2021, Jeff Law wrote: > >>> gcc/testsuite/ >>> * gcc.target/vax/cmpelim-eq-notsi.c: Use subtraction from a >>> constant then rather than addition. >>> * gcc.target/vax/cmpelim-le-notsi.c: Likewise. >>> *

Re: [PATCH v3] libgcc: Thumb-1 Floating-Point Library for Cortex M0

On Mon, 11 Jan 2021 at 17:18, Daniel Engel wrote: > > On Mon, Jan 11, 2021, at 8:07 AM, Christophe Lyon wrote: > > On Sat, 9 Jan 2021 at 14:09, Christophe Lyon > > wrote: > > > > > > On Sat, 9 Jan 2021 at 13:27, Daniel Engel wrote: > > > > > > > > On Thu, Jan 7, 2021, at 4:56 AM, Richard

[PATCH] Properly release symtab::m_clones.

The patch is about not using delete for a memory that is allocated by GGC. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR jit/98615 * symtab-clones.h (clone_info::release): Release

Re: [PATCH] Properly release symtab::m_clones.

> The patch is about not using delete for a memory that > is allocated by GGC. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > PR jit/98615 > * symtab-clones.h (clone_info::release):

Re: libstdc++ PR 57272 Fancy pointer support in Hashtable

Hi     I had another look to this attempt to properly support alloc fancy pointers.     I consider all your remarks appart from the big one below about all this being a waste of time :-)     I do not see why we should use the alloc fancy pointer type in our _Hashtable implementation

[pushed] aarch64: Add support for unpacked SVE ASRD

This patch adds support for both conditional and unconditional unpacked ASRD. This meant adding a new define_insn for the unconditional form, instead of reusing the conditional instructions. It also meant extending the current conditional patterns to support merging with any independent value,

Re: [patch] fix -Wformat-diag warnings in rs6000-call.c

On 1/10/21 10:18 PM, Martin Sebor wrote: > On 1/10/21 3:29 AM, Matthias Klose wrote: >> is the newline intended? It's followed by a debug_rtx call. > > To avoid the warning there shouldn't be any trailing punctuation > or whitespace in the message.  The GCC quoting directives should > be

Re: [PATCH v4 06/29] Import replacement 'ctz' functions from CM0 library

On 11/01/2021 11:10, g...@danielengel.com wrote: > From: Daniel Engel > > This version combines __ctzdi2() with __ctzsi2() into a single object with > an efficient tail call. The former implementation of __ctzdi2() was in C. > > On architectures without a clz instruction, this version merges

[PATCH 0/2] Check if AR works with --plugin and rc

AR from older binutils doesn't work with --plugin and rc: [hjl@gnu-cfl-2 bin]$ touch foo.c [hjl@gnu-cfl-2 bin]$ ar --plugin /usr/libexec/gcc/x86_64-redhat-linux/10/liblto_plugin.so rc libfoo.a foo.c [hjl@gnu-cfl-2 bin]$ ./ar --plugin /usr/libexec/gcc/x86_64-redhat-linux/10/liblto_plugin.so rc

Re: [PATCH 1/3] GCC: Pass --plugin to AR and RANLIB

> From: Luis Machado via Gcc-patches > Date: Mon, 11 Jan 2021 15:58:43 +0100 > This seems to have broken the builds on AArch64-Linux Ubuntu 18.04. > > make[2]: Entering directory 'binutils-gdb-master-bionic/libiberty' > rm -f ./libiberty.a pic/./libiberty.a noasan/./libiberty.a > ar --plugin

[pushed] aarch64: Add support for unpacked SVE conditional BIC

This patch adds support for unpacked conditional BIC. The type suffix could be taken from the element size or the container size, so the patch continues to use the element size. This is consistent with the existing support for unconditional BIC. Tested on aarch64-linux-gnu and aarch64_be-elf.

Re: [PATCH] tree-optimization/98221 - fix wrong unpack operation used for big-endian

On 1/11/21 3:02 AM, Andreas Krebbel via Gcc-patches wrote: > The vec-abi-varargs-1.c testcase on IBM Z currently fails. > > While adding an SI mode vector to a DI mode vector the first is unpacked > using: > > _28 = BIT_INSERT_EXPR <{ 0, 0, 0, 0 }, _2, 0>; > _34 = [vec_unpack_lo_expr] _28;

Re: [PATCH v4 05/29] Import replacement 'clz' functions from CM0 library

A general comment before we start: CLZ was added to the Arm ISA in Armv5. So all subsequent Arm versions (and all versions implementing thumb2) will have this instruction. So the only cases where you'll need a fallback are armv6m (and derivatives) and pre-armv5 (Arm or thumb1). So there's no

[gcc-10 backport] libiberty: Support the new ("v0") mangling scheme in rust-demangle

Could this commit be backported to the gcc-10 branch? We would like to switch the default name mangling scheme in Rust but are currently blocked on upstream tool support. commit 84096498a7bd788599d4a7ca63543fc7c297645e libiberty: Support the new ("v0") mangling scheme in rust-demangle

[pushed] aarch64: Add support for unpacked SVE shifts

This patch adds support for unpacked SVE LSL, ASR and LSR. For right shifts, the type suffix needs to be taken from the element size rather than the container size. Tested on aarch64-linux-gnu and aarch64_be-elf. Pushed to trunk. Richard gcc/ * config/aarch64/aarch64-sve.md (3)

[pushed] aarch64: Add support for unpacked SVE ADR

This patch extends the ADR patterns to handle unpacked vectors. They would work with both elements and containers, but since the instructions only support .s and .d, we get more coverage by using containers. Tested on aarch64-linux-gnu and aarch64_be-elf. Pushed to trunk. Richard gcc/

Re: [PATCH] c++: private inheritance access diagnostics fix [PR17314]

On 1/8/21 7:38 PM, Anthony Sharp wrote: Hi Jason, Thank you! To start with, do you have a copyright assignment on file or in the works already? Good point. I incorrectly assumed it would only be a minor contribution copyright-wise. > Mr Edelsohn gave me a template which I've now filled out

Re: [PATCH v4] rs6000, vector integer multiply/divide/modulo instructions

On Mon, 2020-12-07 at 16:31 -0800, Carl Love wrote: > Will: > > I have addressed you comments with regards to the Change Log entries. > > The extra define vec_div was removed. > > Added the missing entries for DIVU_V2DI DIVS_V2DI in rs6000-call.c. > > The extra MULLD_V2DI case statement

Re: [PATCH] libstdc++: implement locale support for AIX

On Mon, Jan 11, 2021 at 10:56 AM CHIGOT, CLEMENT wrote: > > >> Hi David, Clement, > >> > >>> The patch is local to libstdc++ AIX support, so I believe that I can > >>> approve it. > >> > >>have you considered merging the dragonfly and aix trees? I'm asking > >>because it seems prudent to try

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

On 1/9/21 5:23 PM, Patrick Palka wrote: This patch teaches find_template_parameters to visit the template represented by a CTAD placeholder, which is normally not visited by for_each_template_parm. This template may be a template template parameter (as in the first testcase), or it may

Re: [PATCH] binuitils: Check if AR is usable for LTO build

On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > checking for -plugin option... ar: no operation specified > Failed: ar --plugin >

Re: [PATCH 0/8] [RS6000] rs6000_rtx_costs V2

On Sat, Dec 05, 2020 at 07:42:07PM +1030, Alan Modra wrote: > Hi Segher, > I've been holding off pinging these knowing you had a lot of other > review work, but maybe that's settling down now? You already OK'd > 1/8, 2/8 and 6/8. Ping. > [PATCH 3/8] [RS6000] rs6000_rtx_costs tidy AND >

[wwwdocs] Update C++ DR table with new DRs

I pushed this patch to update the DR table with a few new DRs. Also update some of the older ones to reflect that they're included in C++20. Marek commit 6be6626d59e1c492d5e05606e5a6902feb9e5bac Author: Marek Polacek Date: Mon Jan 11 17:18:45 2021 -0500 C++ DRs: Add new DRs, update

Re: [PATCH v4 01/29] Add and organize macros.

On Mon, Jan 11, 2021, at 7:21 AM, Richard Earnshaw wrote: > Some initial comments. > > On 11/01/2021 11:10, g...@danielengel.com wrote: > > From: Daniel Engel > > > > These definitions facilitate subsequent patches in this series. > > > > gcc/libgcc/ChangeLog: > > 2021-01-07 Daniel Engel >

Re: [PATCH 1/2] GCC: Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 08:57:05AM -0800, H.J. Lu via Binutils wrote: > diff --git a/config/gcc-plugin.m4 b/config/gcc-plugin.m4 > index c5b72e9a13d..798a2054edd 100644 > --- a/config/gcc-plugin.m4 > +++ b/config/gcc-plugin.m4 > @@ -145,6 +145,18 @@ for plugin in $plugin_names; do > break >

Re: [PATCH] c++: ICE with constrained placeholder return type [PR98346]

On 1/7/21 4:06 PM, Patrick Palka wrote: This is essentially a followup to r11-3714 -- we ICEing from another "unguarded" call to build_concept_check, this time in do_auto_deduction, due to the presence of templated trees when !processing_template_decl. Bootstrapped and regtested on

Re: [PATCH] binuitils: Check if AR is usable for LTO build

On Mon, Jan 11, 2021 at 1:20 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > > > checking for -plugin option... ar: no operation specified > > Failed: ar --plugin > >

Re: [PATCH v4 02/29] Refactor 'clz' functions into a new file.

On 11/01/2021 15:58, Daniel Engel wrote: > > On Mon, Jan 11, 2021, at 7:39 AM, Richard Earnshaw wrote: >> On 11/01/2021 15:26, Richard Earnshaw wrote: >>> On 11/01/2021 11:10, g...@danielengel.com wrote: From: Daniel Engel gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel

Re: [PATCH] c++: ICE with constrained placeholder return type [PR98346]

On 1/11/21 4:40 PM, Jason Merrill wrote: On 1/7/21 4:06 PM, Patrick Palka wrote: This is essentially a followup to r11-3714 -- we ICEing from another "unguarded" call to build_concept_check, this time in do_auto_deduction, due to the presence of templated trees when !processing_template_decl.

[PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

If fancy_abort is called before the diagnostic subsystem is initialized, internal_error will crash internally in a way that prevents a useful message reaching the user. This can happen with libgccjit in the case of gcc_assert failures that occur outside of the libgccjit mutex that guards the rest

Re: [PATCH 0/2] Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 08:57:04AM -0800, H.J. Lu via Binutils wrote: > Check if AR works with --plugin and rc before passing --plugin to AR and > RANLIB. Thanks for looking at this, but next time please assign the bug to yourself. I fixed the bug too this morning, before seeing your email. --

[PATCH] c++: -Wmissing-field-initializers in unevaluated ctx [PR98620]

This PR wants us not to warn about missing field initializers when the code in question takes places in decltype and similar. Fixed thus. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? gcc/cp/ChangeLog: PR c++/98620 * typeck2.c (process_init_constructor_record):

[PATCH] binuitils: Check if AR is usable for LTO build

Check if AR is usable for LTO build with --enable-pgo-build=lto: checking for -plugin option... ar: no operation specified Failed: ar --plugin /usr/gcc-11.0.0-x32/libexec/gcc/x86_64-pc-linux-gnu/11.0.0/liblto_plugin.so rc no configure: error: AR with --plugin and rc is required for LTO build

Re: [PATCH 0/2] Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 3:05 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 08:57:04AM -0800, H.J. Lu via Binutils wrote: > > Check if AR works with --plugin and rc before passing --plugin to AR and > > RANLIB. > > Thanks for looking at this, but next time please assign the bug to > yourself.

Re: [PATCH 1/3] GCC: Pass --plugin to AR and RANLIB

This seems to have broken the builds on AArch64-Linux Ubuntu 18.04. make[2]: Entering directory 'binutils-gdb-master-bionic/libiberty' rm -f ./libiberty.a pic/./libiberty.a noasan/./libiberty.a ar --plugin /usr/lib/gcc/aarch64-linux-gnu/7/liblto_plugin.so rc ./libiberty.a \ ./regex.o

[COMMITED] MAINTAINERS: Add myself for write after approval

ChangeLog: 2021-01-12 Qian Jianhua * MAINTAINERS (Write After Approval): Add myself --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0aa23df57e..e88808f9fe2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -451,6 +451,7 @@ Daniel

Re: [PATCH] Handle fancy_abort before diagnostic initialization [PR98586]

On Mon, Jan 11, 2021 at 10:57 PM David Malcolm via Gcc-patches wrote: > > If fancy_abort is called before the diagnostic subsystem is initialized, > internal_error will crash internally in a way that prevents a useful > message reaching the user. > > This can happen with libgccjit in the case of

Re: [PATCH] binuitils: Check if AR is usable for LTO build

On Mon, Jan 11, 2021 at 02:52:43PM -0800, H.J. Lu wrote: > On Mon, Jan 11, 2021 at 1:20 PM Alan Modra wrote: > > > > On Mon, Jan 11, 2021 at 11:53:15AM -0800, H.J. Lu via Binutils wrote: > > > Check if AR is usable for LTO build with --enable-pgo-build=lto: > > > > > > checking for -plugin

Re: [PATCH] c++: -Wmissing-field-initializers in unevaluated ctx [PR98620]

On 1/11/21 6:19 PM, Marek Polacek wrote: This PR wants us not to warn about missing field initializers when the code in question takes places in decltype and similar. Hmm, the warning seems of questionable utility with templated code like this, but I guess this is a reasonable middle ground.

Re: [PATCH v4 05/29] Import replacement 'clz' functions from CM0 library

On Mon, Jan 11, 2021, at 8:32 AM, Richard Earnshaw wrote: > A general comment before we start: > > CLZ was added to the Arm ISA in Armv5. So all subsequent Arm versions > (and all versions implementing thumb2) will have this instruction. So > the only cases where you'll need a fallback are

Re: V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 4:22 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 04:07:22PM -0800, H.J. Lu wrote: > > These are not fatal errors. Here is the updated patch to use > > AC_MSG_WARN instead. OK for master? > > OK by me. Please squash the two patches. > I will keep 2 separate since I

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

On Mon, 11 Jan 2021, Jason Merrill wrote: > On 1/9/21 5:23 PM, Patrick Palka wrote: > > This patch teaches find_template_parameters to visit the template > > represented by a CTAD placeholder, which is normally not visited by > > for_each_template_parm. This template may be a template template >

[committed] analyzer: fix ICE merging dereferencing unknown ptrs [PR98628]

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-6603-gab88f3607233376c3145c320e92e71943a495bb5 gcc/analyzer/ChangeLog: PR analyzer/98628 * store.cc (binding_cluster::make_unknown_relative_to): Don't mark dereferenced unknown pointers

V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 3:27 PM Alan Modra wrote: > > On Mon, Jan 11, 2021 at 08:57:05AM -0800, H.J. Lu via Binutils wrote: > > diff --git a/config/gcc-plugin.m4 b/config/gcc-plugin.m4 > > index c5b72e9a13d..798a2054edd 100644 > > --- a/config/gcc-plugin.m4 > > +++ b/config/gcc-plugin.m4 > > @@

Re: V2 [PATCH 1/2] GCC: Check if AR works with --plugin and rc

On Mon, Jan 11, 2021 at 04:07:22PM -0800, H.J. Lu wrote: > These are not fatal errors. Here is the updated patch to use > AC_MSG_WARN instead. OK for master? OK by me. Please squash the two patches. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] c++: Fix ICE with CTAD in concept [PR98611]

On 1/11/21 8:08 PM, Patrick Palka wrote: On Mon, 11 Jan 2021, Jason Merrill wrote: On 1/9/21 5:23 PM, Patrick Palka wrote: This patch teaches find_template_parameters to visit the template represented by a CTAD placeholder, which is normally not visited by for_each_template_parm. This

Re: [PATCH] Fix UBSAN bootstrap

On Mon, Jan 11, 2021 at 11:26:42AM +0100, Martin Liška wrote: > Problem here was that GCC-related options are not applied in stage2 (and > later stages). > It's caused by fact that CXX is xg++ in stage2 (and later stages). > Fixed with the following patch. > > Ready to be installed? > Thanks, >

RE: [PATCH 1/8 v9]middle-end slp: Support optimizing load distribution

Hi Richi, Attached is the updated patch. Note that testcases for all of these will be committed with the patch but I'm Finishing up the 32-bit Arm changes to mirror the changes the AArch64 maintainer wanted and then have to do bootstrap which will take the majority of the day so wanted to get

RE: [PATCH 5/8 v9]middle-end slp: support complex multiply and complex multiply conjugate

Hi Richi, This adds support for complex multiply and complex multiply and accumulate to the vect pattern detector. Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu and no issues. Ok for master? (I replied to a comment at the very end of the mail from the previous patch)

[PATCH v4 01/29] Add and organize macros.

From: Daniel Engel These definitions facilitate subsequent patches in this series. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/t-elf: Organize functions into logical groups. * config/arm/lib1funcs.S: Add FUNC_START macro variations for weak functions and

[PATCH v4 00/29] libgcc: Thumb-1 Floating-Point Library for Cortex M0

From: Daniel Engel This patch revision is based on comments received against: As one point of comparison, a test program [1] links 916 bytes from libgcc with the patched toolchain vs 10276 bytes with

[PATCH v4 09/29] Import new 'ffs' functions from the CM0 library.

From: Daniel Engel The new functions provide an efficient tail call to __ctzsi2(), making them rather smaller and faster than the C versions. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/bits/ctz2.S: Add __ffssi2() and __ffsdi2(). * config/arm/t-elf: Add _ffssi2

[PATCH v4 06/29] Import replacement 'ctz' functions from CM0 library

From: Daniel Engel This version combines __ctzdi2() with __ctzsi2() into a single object with an efficient tail call. The former implementation of __ctzdi2() was in C. On architectures without a clz instruction, this version merges the formerly separate Thumb and ARM code sequences into a

[PATCH v4 14/29] Add branchless conditional sequences to the 64-bit comparison funtions.

From: Daniel Engel This effectively merges support for ARM architecture variants into a common function path with appropriate build conditions. ARM performance is 1-2 instructions faster/smaller; Thumb-2 is about 50%. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/bpabi.S:

[PATCH v4 02/29] Refactor 'clz' functions into a new file.

From: Daniel Engel gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/lib1funcs.S: Move __clzsi2() and __clzdi2() to * config/arm/bits/clz2.S: New file. --- libgcc/config/arm/bits/clz2.S | 124 ++ libgcc/config/arm/lib1funcs.S | 123

[PATCH v4 10/29] Import new 'parity' functions from the CM0 library.

From: Daniel Engel The functional overlap between the single- and double-word variants functions makes these versions about half the size of the C versions if both functions are linked together in an application. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel *

[PATCH v4 03/29] Refactor 'ctz' functions into a new file.

From: Daniel Engel gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/lib1funcs.S: Move __ctzsi2() to * config/arm/bits/ctz2.S: New file. --- libgcc/config/arm/bits/ctz2.S | 65 +++ libgcc/config/arm/lib1funcs.S | 65

[PATCH v4 08/29] Import new 'clrsb' functions from the CM0 library.

From: Daniel Engel The new functions provide an efficient tail call to __clzsi2(), making them rather smaller and faster than the C versions. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/bits/clz2.S: Add __clrsbsi2() and __clrsbdi2(). * config/arm/t-elf: Add

[PATCH v4 11/29] Import new 'popcnt' functions from the CM0 library.

From: Daniel Engel The functional overlap between the single- and double-word versions functions makes this implementation about 30% smaller than C when both functions are linked together in an appliation. gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/bits/popcnt.S: New

[PATCH v4 16/29] Refactor Thumb-1 64-bit division functions into a new file.

From: Daniel Engel gcc/libgcc/ChangeLog: 2021-01-07 Daniel Engel * config/arm/bpabi-v6m.S: Moved _ldivmod() and __uldivmod() to * config/arm/eabi/ldiv.S: New file. * config/arm/lib1funcs.S: #include eabi/ldiv.S (v6m only). --- libgcc/config/arm/bpabi-v6m.S | 81

[PATCH v4 20/29] Import single precision comparison functions from the CM0 library.

From: Daniel Engel These functions are significantly smaller and faster than the wrapper functions and soft-float implementation they replace. Using the first comparison operator (e.g. '<=') costs about 70 bytes initially, but every additional operator incrementally adds just 4 bytes. NOTE: It

  1   2   >