Re: [PATCH 1/2] libstdc++: Atomic wait/notify ABI stabilization

2024-03-09 Thread Jonathan Wakely
On Sat, 9 Mar 2024 at 12:18, Jonathan Wakely wrote: > > > > +template >> + __wait_result_type >> + __wait_for(const __platform_wait_t* __addr, __wait_args __args, >> +const chrono::duration<_Rep, _Period>& __rtime) noexcept >> +{ >> + if (!__rtime.count())

Reverting recent adjustment to expected output of sh port tests

2024-03-09 Thread Jeff Law
With Jakub's twiddle to the forward propagation pass, the assembly code for pr59533-1.c has returned to its previous state. Thus I've reverted my patch which adjusted the expected output. Jeffcommit 6f7d000fcacef31a6947f95021e445c846170f92 Author: jlaw Date: Sat Mar 9 21:33:47 2024 -0700

[committed] [target/102250] Document python requirement for risc-v

2024-03-09 Thread Jeff Law
Not sure why nobody's taken care of this yet. Under certain circumstances python may be needed if you're building a RISC-V compiler. Here's what I've checked in. Happy to adjust if folks want to wordsmith it further. Jeffcommit 7c8f0a79a7e1e42f846ddbca14b98b47ddcfd178 Author: jlaw Date:

[committed] [PR target/111362] Fix compare-debug issue with mode switching

2024-03-09 Thread Jeff Law
The issue here is the code we emit for mode-switching can change when -g is added to the command line. This is caused by processing debug notes occurring after a call which is the last real statement in a basic block. Without -g the CALL_INSN is literally the last insn in the block and the

Re: [PATCH v2] VECT: Fix ICE for vectorizable LD/ST when both len and store are enabled

2024-03-09 Thread Richard Biener
> Am 10.03.2024 um 04:14 schrieb pan2...@intel.com: > > From: Pan Li > > This patch would like to fix one ICE in vectorizable_store when both the > loop_masks and loop_lens are enabled. The ICE looks like below when build > with "-march=rv64gcv -O3". > > during GIMPLE pass: vect > test.c:

[PATCH v2] VECT: Fix ICE for vectorizable LD/ST when both len and store are enabled

2024-03-09 Thread pan2 . li
From: Pan Li This patch would like to fix one ICE in vectorizable_store when both the loop_masks and loop_lens are enabled. The ICE looks like below when build with "-march=rv64gcv -O3". during GIMPLE pass: vect test.c: In function ‘d’: test.c:6:6: internal compiler error: in

Re: [PATCH] fwprop: Restore previous behavior for forward propagation of RTL with MEMs [PR114284]

2024-03-09 Thread Richard Biener
> Am 09.03.2024 um 09:36 schrieb Jakub Jelinek : > > Hi! > > Before the recent PR111267 r14-8319 fwprop changes, fwprop would never try > to propagate what was not considered PROFITABLE, where the profitable part > actually was partly about profitability, partly about very good reasons > not

Re: [PATCH] bitint: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278]

2024-03-09 Thread Richard Biener
> Am 09.03.2024 um 09:28 schrieb Jakub Jelinek : > > Hi! > > The following testcase ICEs, because update-address-taken subpass of > fre5 rewrites > _BitInt(128) b; > vector(16) unsigned char _3; > > [local count: 1073741824]: > _3 = MEM [(char * {ref-all})p_2(D)]; > MEM [(char *

Re: [PATCH 1/2] libstdc++: Atomic wait/notify ABI stabilization

2024-03-09 Thread Jonathan Wakely
On Thu, 16 Nov 2023 at 13:49, Jonathan Wakely wrote: > From: Thomas Rodgers > > These two patches were written by Tom earlier this year, before he left > Red Hat. We should finish reviewing them for GCC 14 (and probably squash > them into one?) > > Tom, you mentioned further work that changes

[PATCH] bitint: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278]

2024-03-09 Thread Jakub Jelinek
Hi! The following testcase ICEs, because update-address-taken subpass of fre5 rewrites _BitInt(128) b; vector(16) unsigned char _3; [local count: 1073741824]: _3 = MEM [(char * {ref-all})p_2(D)]; MEM [(char * {ref-all})] = _3; b ={v} {CLOBBER(eos)}; to _BitInt(128) b;

[committed] i386: Regenerate i386.opt.urls

2024-03-09 Thread Jakub Jelinek
Hi! When I've added the -mnoreturn-no-callee-saved-registers option to i386.opt, I forgot to regenerate i386.opt.urls and Mark's CI kindly reminded me of that. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, verified

[patch,avr,applied] Add some more cost computation

2024-03-09 Thread Georg-Johann Lay
This adds cost computation for some insn combiner patterns and improves a few other nits. Johann -- AVR: Add cost computation for some insn combine patterns. gcc/ * config/avr/avr.cc (avr_rtx_costs_1) [PLUS]: Determine cost for usum_widenqihi and add_zero_extend1.

[PATCH] testsuite: xfail test for arm

2024-03-09 Thread Torbjörn SVENSSON
I don't know if this affects other targets than arm-none-eabi, so I used arm-*-*. If you think it should be *-*-* or some other target selector, please let me know what to use instead. Ok for releases/gcc-13? -- On arm-none-eabi, the test case fails with

[PATCH] [strub] improve handling of indirected volatile parms [PR112938]

2024-03-09 Thread Alexandre Oliva
The earlier patch for PR112938 arranged for volatile parms to be made indirect in internal strub wrapped bodies. The first problem that remained, more evident, was that the indirected parameter remained volatile, despite the indirection, but it wasn't regimplified, so indirecting it was

[PATCH] [tree-prof] skip if errors were seen [PR113681]

2024-03-09 Thread Alexandre Oliva
ipa_tree_profile asserts that the symtab is in IPA_SSA state, but we don't reach that state and ICE if e.g. ipa-strub passes report errors. Skip this pass if errors were seen. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog PR tree-optimization/113681 *

[PATCH] fwprop: Restore previous behavior for forward propagation of RTL with MEMs [PR114284]

2024-03-09 Thread Jakub Jelinek
Hi! Before the recent PR111267 r14-8319 fwprop changes, fwprop would never try to propagate what was not considered PROFITABLE, where the profitable part actually was partly about profitability, partly about very good reasons not to actually propagate and partly for cases where propagation is

Re: [PATCH] testsuite: xfail test for arm

2024-03-09 Thread Andrew Pinski
On Sat, Mar 9, 2024 at 1:07 AM Torbjörn SVENSSON wrote: > > I don't know if this affects other targets than arm-none-eabi, so I > used arm-*-*. If you think it should be *-*-* or some other target > selector, please let me know what to use instead. > > Ok for releases/gcc-13? Most likely should

RE: [PATCH v1] VECT: Bugfix ICE for vectorizable_store when both len and mask

2024-03-09 Thread Li, Pan2
Thanks Richard for comments. > That said, the assert you run into should be only asserted during transform, > not during analysis. Good to learn that the assertion is only valid during transform, I guess we may have almost the same case in vectorizable_load. I will try to test only allow