Go patch committed: check for ... with builtin functions

2011-03-25 Thread Ian Lance Taylor
The Go builtin functions other than append don't handle using ... to pass a varargs argument. This patch to the gccgo frontend checks for that. It also gives a better error message for an attempt to use ... with a type conversion. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. C

Go patch committed: better error setting const to nil

2011-03-25 Thread Ian Lance Taylor
This patch to the Go frontend gives a better error message when setting a const to nil. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d04de877d993 go/gogo.cc --- a/go/gogo.cc Fri Mar 25 22:31:14 2011 -0700 +++ b/go/gogo.cc Fri Mar 25 22:41:02

Go patch committed: Correctly parse case <-c <- v

2011-03-25 Thread Ian Lance Taylor
This patch to the Go frontend correctly parses select { case <-c <- v: } Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 51340e536e48 go/parse.cc --- a/go/parse.cc Fri Mar 25 13:39:15 2011 -0700 +++ b/go/parse.cc Fri Mar 25

Re: [PATCH 3/6] Allow jumps in epilogues

2011-03-25 Thread Richard Henderson
On 03/25/2011 10:34 AM, Bernd Schmidt wrote: > I don't know much about the unwinding code. I'm currently thinking about > writing out a cfi_remember_state at the start of the function, restoring > that clean state when necessary at the start of a new block and emitting > the necessary directives to

Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944)

2011-03-25 Thread Michael Matz
Hi, [sorry for breaking the threading I've deleted the mails I'm answering already] In any case, citing from http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01250.html > Here's the patch I came up with. It is on top of the previous one, so > if we want to backport to 4.6 later, both are neces

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Henderson
On 03/25/2011 11:49 AM, Richard Henderson wrote: > On 03/25/2011 10:51 AM, Richard Sandiford wrote: >> Thanks. I think it needs to be s/!= 4/>= 6/ though, so that >> match_scratches still work when 6 operands really are passed in. > > For the record, I audited all setmem and movmem patterns. > >

Re: More static checking fixes (unused LHS assignments)

2011-03-25 Thread Richard Henderson
On 03/25/2011 01:19 PM, Jeff Law wrote: > * var-tracking.c (canonicalize_values_mark): Delete unused > lhs assignment. > (canonicalize_values_star, set_variable_part): Likewise. > (clobber_variable_part, delete_variable_part): Likewise. Ok. r~

Re: PowerPC64 reload failure with misaligned fp load

2011-03-25 Thread Alan Modra
On Fri, Mar 25, 2011 at 09:36:04PM +0100, Ulrich Weigand wrote: > Looks good to me, except ... > > + mem = change_address (mem, VOIDmode, scratch_or_premodify); > > Maybe replace_equiv_address instead, to avoid losing the memory > attribute information (alignment, alias set, ...)? Yes, in fact

[v3] implement LWG issues 1514, 2030, 2031

2011-03-25 Thread Jonathan Wakely
2011-03-25 Jonathan Wakely * include/std/future (future::share): Add. (packaged_task::result_type): Remove as per LWG 2030. (packaged_task::packaged_task): Remove redundant constructors, as per LWG 1514. * testsuite/30_threads/future/members/share.cc: New

Re: [4.7] Avoid global state in sparc_handle_option

2011-03-25 Thread Eric Botcazou
> 2011-03-24 Joseph Myers > > * config/sparc/sparc-opts.h: New. > * config/sparc/sparc.c (sparc_handle_option, sparc_select, > sparc_cpu, fpu_option_set, TARGET_HANDLE_OPTION): Remove. > (sparc_option_override): Store processor_type enumeration rather > than string

Re: regex issue

2011-03-25 Thread Jonathan Wakely
On 25 March 2011 22:38, Jonathan Wakely wrote: > The tests are invalid. There were preconditions added to match_results > member functions recently, which we now check in debug mode, and those > tests violate them. > > I'll deal with it, thanks for testing it. > 2011-03-25 Jonathan Wakely

Go patch committed: clean up handling of undefined types

2011-03-25 Thread Ian Lance Taylor
While parsing, the Go frontend has to not consider an undefined type to be an error, since it might be defined later. After parsing is complete, an undefined type is an error in most cases, except perhaps for a reference to an imported variable that is not actually used. This patch tries to clean

Re: PowerPC64 reload failure with misaligned fp load

2011-03-25 Thread Ulrich Weigand
David Edelsohn wrote: > On Fri, Mar 25, 2011 at 11:09 AM, Alan Modra wrote: > > > Much of the following patch is based on Michael Meissner's support for > > vector reloads. =A0The predicates.md change teaches the predicate used > > by the "Y" constraint to check cmodel medium addresses in case su

[pph] Add hooks for writing/reading ASTs (2/2) (issue4275081)

2011-03-25 Thread Diego Novillo
Handle STATEMENT_LIST and add hooks for writing non-pointer values into bitpacks. This patch fixes most of the failures in pph.exp (only 14 remain). We now handle STATEMENT_LIST properly. The patch also introduces hooks for writing/reading non pointer values from trees. Tested on x86_64. Commi

[pph] Add hooks for writing/reading ASTs (1/2) (issue4306053)

2011-03-25 Thread Diego Novillo
Add pph_stream_write_tree and pph_stream_read_tree callbacks. Make them handle DECL_SAVED_TREE. This produces several new failures since it exposes more unhandled trees. Committed on pph branch. Fixes for the introduced failures coming up in the next patch. cp/ChangeLog.pph 2011-03-25 Diego N

More static checking fixes (unused LHS assignments)

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 var-tracking (and other modules) have a habit of assigning values to objects, then never using the values. We still need the RHS side effect in these cases, so the assignment was deleted leaving just the RHS as a statement. Fixed thusly for var-track

[PATCH] Don't use mempcpy in libquadmath

2011-03-25 Thread Jakub Jelinek
Hi! I've been removing mempcpy uses from libquadmath and replacing them with memcpy + increment, but apparently missed removing one letter in one case. Without a mempcpy prototype on targets that don't have mempcpy apparently gcc just warns, but optimizes it into memcpy anyway, so no big harm was

Re: PowerPC64 reload failure with misaligned fp load

2011-03-25 Thread David Edelsohn
On Fri, Mar 25, 2011 at 11:09 AM, Alan Modra wrote: > Much of the following patch is based on Michael Meissner's support for > vector reloads.  The predicates.md change teaches the predicate used > by the "Y" constraint to check cmodel medium addresses in case such > addresses should ever be gene

Re: PR 47487 powerpc64 ICE building libgo

2011-03-25 Thread David Edelsohn
On Fri, Mar 25, 2011 at 11:15 AM, Alan Modra wrote: > Bootstrapped etc. powerpc64-linux.  OK mainline? > >        PR target/47487 >        * config/rs6000/rs6000.c (rs6000_output_function_epilogue): Support >        GNU Go in traceback table. Okay. Thanks, David

go patch committed: Avoid double error on negative shift count

2011-03-25 Thread Ian Lance Taylor
This patch to the Go frontend avoids a double error when there is a negative shift count. We used to give a negative shift count error followed by an overflow error. This just gives the former. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 31a

Re: [PING^2]: For unreviewed patches

2011-03-25 Thread Kai Tietz
2011/3/25 Jeff Law : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/25/11 02:48, Kai Tietz wrote: >> Ping for following patches >> >> [patch libcpp]: Improve handling of DOS-filenames and -paths >> http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00742.html >> >> [patch gcc c++ c-family ja

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Henderson
On 03/25/2011 10:51 AM, Richard Sandiford wrote: > Thanks. I think it needs to be s/!= 4/>= 6/ though, so that > match_scratches still work when 6 operands really are passed in. For the record, I audited all setmem and movmem patterns. There are is only one that uses 6 operands: i386. There are

Re: [PING^2]: For unreviewed patches

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/11 02:48, Kai Tietz wrote: > Ping for following patches > > [patch libcpp]: Improve handling of DOS-filenames and -paths > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00742.html > > [patch gcc c++ c-family java fortan lto]: Fix DOS-filesyst

Re: Scheduler cleanups, 5/5

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/11 07:19, Bernd Schmidt wrote: > We can currently select an insn to be scheduled, only to find out that > it's not actually valid at the current time, either due to state > conflicts or being an asm with something else already scheduled in the

Re: Scheduler cleanups, 4/N

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/11 07:14, Bernd Schmidt wrote: > We have a mechanism to prevent the scheduler from touching certain > blocks; this is used by modulo scheduling. sched-ebb does not honor this > flag currently; this patch fixes it. Bootstrapped and tested on >

Re: Scheduler cleanups, 2/N

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/11 07:09, Bernd Schmidt wrote: > This prints a bit more information in debugging dumps. Bootstrapped and > tested on i686-linux. > OK. jeff -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - htt

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Sandiford
Richard Sandiford writes: > Er, >= 4 even... Or not, *sigh*. Time I went home... Richard

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Sandiford
Richard Sandiford writes: > Richard Henderson writes: >> This is due to a miscommunication between the middle-end and the backend >> about how many arguments the setmemhi pattern takes. >> >> (define_expand "setmemhi" >> [(parallel [(set (match_operand:BLK 0 "memory_operand" "") >>

Re: Tighten ARM's CANNOT_CHANGE_MODE_CLASS

2011-03-25 Thread Richard Sandiford
Richard Earnshaw writes: >> gcc/ >> * config/arm/arm.h (CANNOT_CHANGE_MODE_CLASS): Restrict FPA_REGS >> case to VFPv1. >> > > I think adding a comment that VFPv1 would require a restriction but that > that isn't supported would be useful. Then if the worst happens it will > be one less

Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-25 Thread Tobias Burnus
Dear Bob, Bob Deen wrote: Our code does not declare these routines to Fortran, therefore the procedure interface is unknown and this patch "should" not bother anything. Well, it also affects: SUBROUTINE foo() END SUBROUTINE foo and REAL FUNCTION bar() END FUNCTION bar that is proced

Re: [Patch, Fortran] PR 48174+45304: No varags if interface is known

2011-03-25 Thread Tobias Burnus
Dear Paul, Paul Richard Thomas wrote: Why did Jakub's patch for PR45304 not fix this? He visited the fix in your patch upon build_library_function_decl_1 and gfc_get_intrinsic_lib_fndecl. Well, my patch is in a way a follow up to Jakub's. His patch only fixed the library call definitions and

[PATCH] Simple cgraph_node() -> cgraph_get_node() conversions

2011-03-25 Thread Martin Jambor
Hi, The following is a part of http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01204.html - specifically it contains all the simple conversions of calls to cgraph_node to cgraph_get_node. Simple in the sense that checks whether the return value is not NULL are not necessary (or they are sometimes al

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Sandiford
Richard Henderson writes: > This is due to a miscommunication between the middle-end and the backend > about how many arguments the setmemhi pattern takes. > > (define_expand "setmemhi" > [(parallel [(set (match_operand:BLK 0 "memory_operand" "") >(match_operand 2 "const_int_

Re: [RFC PATCH] Typed DWARF stack

2011-03-25 Thread Cary Coutant
> This patch on top of > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01224.html > and > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg01723.html > implements parts of Cary's typed DWARF stack proposal: > http://www.dwarfstd.org/doc/040408.1.html I haven't looked at the patch yet, but this sounds g

Re: [PATCH 3/6] Allow jumps in epilogues

2011-03-25 Thread Bernd Schmidt
On 03/23/2011 06:19 PM, Richard Henderson wrote: > In general, with shrink-wrapping, we can have essentially arbitrary > differences in unwind info between blocks that are sequential. So, while that isn't the case just yet with the current shrink-wrapping patch, it seems I will either have to make

go patch committed: Give error on label defined but not used

2011-03-25 Thread Ian Lance Taylor
The Go language says that it is an error to define a label but not use it. This patch adds that error to the gccgo frontend. The patch includes some changes to the testsuite to avoid new errors. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r aa

Re: Cleaning up expand optabs code

2011-03-25 Thread Richard Henderson
On 03/25/2011 05:41 AM, Georg-Johann Lay wrote: >> On 03/22/2011 06:48 PM, Richard Henderson wrote: >> >>> Ok. Watch out for other target problems this week. > > libgcc fails to build for avr (SVN 171446) > > ../../../../../gcc.gnu.org/trunk/libgcc/../gcc/libgcc2.c: In function > '__negdi2': > .

Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)

2011-03-25 Thread Rainer Orth
I meant to include the final patch. Here it is. Rainer 2011-03-25 Rainer Orth PR boehm-gc/11412 * configure.ac (THREADCFLAGS): New variable. Use it instead of INCLUDES, AM_CPPFLAGS. <*-*-kfreebsd*-gnu> (THREADDLLIBS): Rename to THREADLIBS. Rem

[Patch, libgFortran] Fix MinGW64 compile warning

2011-03-25 Thread Tobias Burnus
The attached patch fixes a compiler warning on MinGW64 ../../../../../build/gcc/src/libgfortran/io/unix.c:51:0: warning: "lseek" redefined [enabled by default] which is due to MinGW64 now supporting LFS. (Seemingly, using a similar define as libgfortran.) The following patch should fix the is

Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)

2011-03-25 Thread Rainer Orth
Paolo Bonzini writes: >> @@ -116,7 +79,6 @@ >> "PICFLAG_FOR_TARGET=$(PICFLAG_FOR_TARGET)" \ >> "SHELL=$(SHELL)" \ >> "EXPECT=$(EXPECT)" \ >> -"RUNTEST=$(RUNTEST)" \ > > Leave this line here, and replace the definitions of EXPECT and RUNTEST in > boehm-gc/testsuite/Makefile.am w

[PATCH] Better .debug_aranges fix (PR debug/48253, take 3)

2011-03-25 Thread Jakub Jelinek
On Fri, Mar 25, 2011 at 05:17:07PM +0100, Jakub Jelinek wrote: > On Thu, Mar 24, 2011 at 06:08:01PM +0100, Jason Merrill wrote: > > This ought to cut down on the number of cases we have to handle in > > all the different places in dwarf2out that deal with this stuff. > > > > Does that make sense t

Re: [PATCH 1/4] Remove cgraph_node function and fixup all callers

2011-03-25 Thread Jan Hubicka
> > Seems OK, however.. > > To what extent is this an approval? :-) Approval only after you convince me on the questions bellow. > > > > Index: src/gcc/gimplify.c > > > === > > > --- src.orig/gcc/gimplify.c 2011-03-19 01:16:2

Re: [PATCH, 4.7] Have all inlining destinations "analyzed"

2011-03-25 Thread Jan Hubicka
> Ping. > > Thanks, > > Martin > > -- > On Sat, Mar 19, 2011 at 01:48:36AM +0100, Martin Jambor wrote: > > Hi, > > On Fri, Mar 11, 2011 at 03:30:53PM +0100, Jan Hubicka wrote: > > > Index: src/gcc/cgraph.c > > > ==

Re: [RFC PATCH] Typed DWARF stack

2011-03-25 Thread Roland McGrath
It's been a while since I read Cary's proposal, and I am no longer likely to do much work of my own in this area. So I'll just respond at the high level. I like very much the essential notion of the stack being of typed entities with no specification of how the consumer actually implements it. I

Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-25 Thread DJ Delorie
> dejagnu and expect used to have copies in the src tree but they were > removed a long time ago, so I think of the rules for them both as a > legacy (and I think those two go together). Our tree has dejagnu in it; it's an excellent way to store baseboards for ports we're working on or supporting

Improve jump threading #1 of N

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've been doing some research into improving certain aspects of our warnings, particularly removing false positives from the warnings which require dataflow information. I think it's reasonably well known that many of the false positives occur due to

[PATCH] Really make copyprop propagate constants

2011-03-25 Thread Richard Guenther
Back last year I made copyprop also propagate constants (if a copy chain ultimatively ends in a constant). At least I thought so, but it turns out I missed a piece. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-25 Richard Guenther * tree-ss

Re: [patch][ARM] Fix 16-bit -> 64-bit multiply and accumulate

2011-03-25 Thread Andrew Stubbs
On 28/01/11 15:20, Richard Earnshaw wrote: On Fri, 2011-01-28 at 15:13 +, Andrew Stubbs wrote: On 28/01/11 14:12, Richard Earnshaw wrote: So what happens to a variation of your testcase: long long foolong (long long x, short *a, short *b) { return x + (long long)*a * (long l

[PATCH] Better .debug_aranges fix (PR debug/48253, take 2)

2011-03-25 Thread Jakub Jelinek
On Thu, Mar 24, 2011 at 06:08:01PM +0100, Jason Merrill wrote: > This ought to cut down on the number of cases we have to handle in > all the different places in dwarf2out that deal with this stuff. > > Does that make sense to you? Here is updated patch, it is quite larger than the last one, beca

C++ PATCH for core issue 1135 (virtual and exception-specifications with default)

2011-03-25 Thread Jason Merrill
The resolution of core issue 1135 allows defaulted functions to be declared virtual or with an exception specification that matches the one on an implicit declaration; this patch implements that. Tested x86_64-pc-linux-gnu, applied to trunk. commit c0337ba692c6eadc1d63b96a80b71ac1d59b0e51 Autho

Re: [PATCH] Fix DW_OP_GNU_entry_value handling in .debug_loc duplicate removal

2011-03-25 Thread Richard Henderson
On 03/25/2011 03:59 AM, Jakub Jelinek wrote: > * dwarf2out.c (mem_loc_descriptor) : Compare > mode size instead of bitsize with DWARF2_ADDR_SIZE. > (hash_loc_operands, compare_loc_operands): Handle > DW_OP_GNU_entry_value. Ok. r~

Re: [patch i386 windows]: Introduce call-abi for 32-bit mingw and make callee_pop_aggregate_return attribute by default on for 32-bit mingw target

2011-03-25 Thread Kai Tietz
2011/3/25 Richard Henderson : > On 03/24/2011 10:35 AM, Kai Tietz wrote: >>       * config/i386/cygming.h (DWARF_FRAME_REGISTERS): Adjust comment. >>       (STACK_BOUNDARY): Check for bit-ness in case of MS_ABI. >>       * config/i386/i386.c (ix86_conditional_register_usage): Adjust >>       commen

C++ PATCH for c++/48289 (-pedantic breaks std::move)

2011-03-25 Thread Jason Merrill
The problem here was that we were improperly treating static_cast::type&&>(x) as an lvalue because the dereference was inside a NON_DEPENDENT_EXPR, which we always treat as an lvalue. That seems like a bad assumption, but we can fix this bug simply by moving the dereference outside. Tested x

[patch] Fix gcc.dg/vect/vect-cselim-1.c - PR target/48287

2011-03-25 Thread Ira Rosen
Hi, gcc.dg/vect/vect-cselim-1.c contains misaligned loads and is therefore not vectorizable on targets that don't support misaligned data accesses. This patch adds an xfail for such targets. Tested on powerpc64-suse-linux, and tested by Rainer on sparc-sun-solaris2.10. Committed as obvious. Ira

[pph] Add streaming hooks (issue4271074)

2011-03-25 Thread Diego Novillo
This patch adds streamer hooks for writing and reading trees. It is still very much WIP. In particular, the hooks for reading and writing may change. These callbacks are called from lto_write_tree and lto_read_tree after the common fields in the tree have been processed. They are responsibl

C++ PATCH to add -std=c++03

2011-03-25 Thread Jason Merrill
Since the most recent C++ standard is officially dated 2003 (representing the 1998 standard adjusted by the 2003 technical corrigendum) we really ought to support -std=c++03, meaning the same thing as -std=c++98 since we don't attempt to distinguish between the two. Tested x86_64-pc-linux-gnu,

[Patch] muldi3 for bfin

2011-03-25 Thread Henderson, Stuart
The attached patch adds the muldi3 function for bfin. 2011-03-25 Stuart Henderson From Bernd Schmidt * config/bfin/t-bfin (LIB1ASMFUNCS): Add muldi3 and umulsi3_highpart. * config/bfin/t-bfin-elf (LIB1ASMFUNCS): Add muldi3. * config/bfin/t-bfin-linux (LIB1ASMFUNCS): Add muldi3

Re: [patch i386 windows]: Introduce call-abi for 32-bit mingw and make callee_pop_aggregate_return attribute by default on for 32-bit mingw target

2011-03-25 Thread Richard Henderson
On 03/24/2011 10:35 AM, Kai Tietz wrote: > * config/i386/cygming.h (DWARF_FRAME_REGISTERS): Adjust comment. > (STACK_BOUNDARY): Check for bit-ness in case of MS_ABI. > * config/i386/i386.c (ix86_conditional_register_usage): Adjust > comment and use macro TARGET_64BIT_MS_ABI

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Richard Guenther
On Fri, Mar 25, 2011 at 4:33 PM, Jakub Jelinek wrote: > On Fri, Mar 25, 2011 at 09:30:22AM -0600, Jeff Law wrote: >> I'm not going to chime in on this specific problem; however, it is worth >> noting that many of the issues raised by the C++0x memory model also >> affect the linux kernel. > > But

Re: [testsuite] Fix gcc.dg/torture/pr47917.c on IRIX 6.5

2011-03-25 Thread Richard Guenther
On Fri, Mar 25, 2011 at 4:27 PM, Rainer Orth wrote: > The new gcc.dg/torture/pr47917.c test currently fails the execution test > on IRIX 6.5.  To get a C99-conformant snprintf, one needs to include > with _XOPEN_SOURCE defined as 500.  The following patch does > this. > > Tested with the appropri

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Jakub Jelinek
On Fri, Mar 25, 2011 at 09:30:22AM -0600, Jeff Law wrote: > I'm not going to chime in on this specific problem; however, it is worth > noting that many of the issues raised by the C++0x memory model also > affect the linux kernel. But what they are seeing are certainly store data races, not load r

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/11 09:20, Michael Matz wrote: > Even if there was such (IMO useless) hardware, or somebody would waste his > time in writing such (equally useless) virtual machine that can detect > fabricated problems somebody invented for some standard th

[testsuite] Fix gcc.dg/torture/pr47917.c on IRIX 6.5

2011-03-25 Thread Rainer Orth
The new gcc.dg/torture/pr47917.c test currently fails the execution test on IRIX 6.5. To get a C99-conformant snprintf, one needs to include with _XOPEN_SOURCE defined as 500. The following patch does this. Tested with the appropriate runtest invocations on mips-sgi-irix6.5 and i386-pc-solaris2

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Michael Matz
Hi, On Fri, 25 Mar 2011, Aldy Hernandez wrote: > > But speculative loads are never a problem. So I'd like to avoid > > cluttering GCC code with stuff to avoid them. I honestly don't care > > about diagnostic tools that fail to see if a value read is used or > > not. > > Frankly, I agree. T

PR 47487 powerpc64 ICE building libgo

2011-03-25 Thread Alan Modra
Bootstrapped etc. powerpc64-linux. OK mainline? PR target/47487 * config/rs6000/rs6000.c (rs6000_output_function_epilogue): Support GNU Go in traceback table. Index: gcc/config/rs6000/rs6000.c === --- gcc/con

PowerPC64 reload failure with misaligned fp load

2011-03-25 Thread Alan Modra
Compiler errors like the following have plagued powerpc64 gcc for a long time. error: insn does not satisfy its constraints: (insn 43020 13791 13792 1245 _thread.c:8306 (set (reg:DF 12 12) (mem:DF (plus:DI (reg:DI 3 3 [orig:4092 D.11951 ] [4092]) (const_int 15 [0xf])) [0 S8

[PATCH] Baby-step for cleaning up the gimple verifier(s)

2011-03-25 Thread Richard Guenther
This merges the machinery for verify_stmts and verify_types_in_gimple_*. A step in the direction to merge the various verifications we do on gimple. A further step would move the calls to verify_expr to appropriate places when verifying stmts instead of walking all ops. The goal is still that th

Re: More toplevel configure.ac pruning

2011-03-25 Thread Joseph S. Myers
On Fri, 25 Mar 2011, Rainer Orth wrote: > "Joseph S. Myers" writes: > > > (powerpcle-*-solaris*): Don't disable make expect gnuserv on > > target. > > As I happen to see this: Solaris/PowerPC is ancient history by now > (2.5.1, 2.6, I believe). This can probably go. It appears there's

Re: [testsuite] Mark gcc.dg/graphite/block-[3478].c as expensive (PR testsuite/48283)

2011-03-25 Thread Richard Guenther
On Fri, 25 Mar 2011, Rainer Orth wrote: > As discussed in the PR, I'd like to skip the 4 very expensive > gcc.dg/graphite/block-?.c tests for now. > > Tested with the appropriate runtest invocation with and without > GCC_TEST_RUN_EXPENSIVE set. > > Ok for mainline? Ok. Thanks, Richard. >

Re: Cleaning up expand optabs code

2011-03-25 Thread Georg-Johann Lay
r/4.7.0/ -isystem /mnt/nfs/home/georg/gnu/build/gcc-4.6-avr/gcc/include -isystem /mnt/nfs/home/georg/gnu/build/gcc-4.6-avr/gcc/include-fixed libgcc2-negdi2.c -quiet -dumpbase libgcc2-negdi2.c -auxbase libgcc2-negdi2 -Os -version -o libgcc2-negdi2.s (gdb) cd ~/test (gdb) r GNU C (GCC) version 4.7.0

[testsuite] Mark gcc.dg/graphite/block-[3478].c as expensive (PR testsuite/48283)

2011-03-25 Thread Rainer Orth
As discussed in the PR, I'd like to skip the 4 very expensive gcc.dg/graphite/block-?.c tests for now. Tested with the appropriate runtest invocation with and without GCC_TEST_RUN_EXPENSIVE set. Ok for mainline? Rainer 2011-03-25 Rainer Orth PR testsuite/48283 * gcc

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Aldy Hernandez
But hoisting global in this case doesn't result in a data race, since the loop always accesses global and contains no synchronisation code. If it were only accessed conditionally, as in the examples under "Avoiding Speculation" on that page, then there would be a race in hoisting it, but not fo

Re: Cleaning up expand optabs code

2011-03-25 Thread Georg-Johann Lay
Andreas Krebbel schrieb: > On 03/22/2011 06:48 PM, Richard Henderson wrote: > >> Ok. Watch out for other target problems this week. libgcc fails to build for avr (SVN 171446) ../../../../../gcc.gnu.org/trunk/libgcc/../gcc/libgcc2.c: In function '__negdi2': ../../../../../gcc.gnu.org/trunk/libgc

Re: More toplevel configure.ac pruning

2011-03-25 Thread Rainer Orth
"Joseph S. Myers" writes: > (powerpcle-*-solaris*): Don't disable make expect gnuserv on > target. As I happen to see this: Solaris/PowerPC is ancient history by now (2.5.1, 2.6, I believe). This can probably go. Rainer -- -

Re: [PATCH][ARM] Discourage use of NEON on Cortex-A8

2011-03-25 Thread Andrew Stubbs
On 24/03/11 13:22, Richard Earnshaw wrote: OK Committed, thanks. Andrew

Re: [PATCH] small refactoring in fold-const.c

2011-03-25 Thread Diego Novillo
On Fri, Mar 25, 2011 at 07:52, Nathan Froyd wrote: >        * fold-const.c (expr_location_or): New function. >        (fold_truth_not_expr): Call it. OK. Diego.

[PATCH] small refactoring in fold-const.c

2011-03-25 Thread Nathan Froyd
The patch below just moves the pattern: x = EXPR_LOCATION (t) if (x == UNKNOWN_LOCATION) x = loc into its own function. Tested on x86_64-unknown-linux-gnu. OK to commit? * fold-const.c (expr_location_or): New function. (fold_truth_not_expr): Call it. diff --git a/gcc/f

[PATCH] fix PR bootstrap/48282

2011-03-25 Thread Nathan Froyd
I've applied the obvious patch below to fix PR bootstrap/48282. -Nathan PR bootstrap/4828 Revert: 2011-03-24 Nathan Froyd * function.c (instantiate_virtual_regs): Use FOR_EACH_BB and FOR_BB_INSNS_SAFE to iterate through insns. Re-indent. (pass_

Re: More toplevel configure.ac pruning

2011-03-25 Thread Paolo Bonzini
On 03/25/2011 12:33 PM, Joseph S. Myers wrote: This patch removes native_only, and removes code disabling various components (not in gcc or src) on various hosts or targets, on the basis you give that if you put such a component in tree you want it to be built (which I think applies even for any

Re: More toplevel configure.ac pruning

2011-03-25 Thread Joseph S. Myers
On Fri, 25 Mar 2011, Paolo Bonzini wrote: > Removing the whole native_only stuff is preapproved. > > These days, if you really really want to drop sed or tar in-tree, you want it > to be built. Whether to keep these modules is another story, but this can go > in the meanwhile. This patch remove

Re: Tighten ARM's CANNOT_CHANGE_MODE_CLASS

2011-03-25 Thread Richard Earnshaw
On Fri, 2011-03-25 at 09:28 +, Richard Sandiford wrote: > Richard Earnshaw writes: > > On Thu, 2011-03-24 at 15:40 +, Richard Sandiford wrote: > >> gcc/ > >>* config/arm/arm.h (CANNOT_CHANGE_MODE_CLASS): Restrict FPA_REGS > >>case to VFPv1. > >> > > > > GCC doesn't support VFPv1

Re: More toplevel configure.ac pruning

2011-03-25 Thread Paolo Bonzini
On 03/25/2011 12:03 PM, Joseph S. Myers wrote: > Removing the whole native_only stuff is preapproved. What about my patch your just replied to as a first (or Nth) step? Sure, if I didn't write an explicit okay that was just a mistake. :) Paolo

Re: [testsuite, ada] Convert ACATS to DejaGnu (PR testsuite/37703)

2011-03-25 Thread Rainer Orth
Mark Mitchell writes: > On 2/1/2011 6:24 PM, Joseph S. Myers wrote: > >> For the general issue: a slow test appears to have served its purpose by >> showing up a (target-specific) bug in the compiler. > > Indeed. However, that doesn't justify having lots of slow tests. What > it does justify

Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-25 Thread Paolo Bonzini
On 03/25/2011 11:59 AM, Joseph S. Myers wrote: * Maybe turn it into a build tool, and it may even make sense: dejagnu dejagnu and expect used to have copies in the src tree but they were removed a long time ago, so I think of the rules for them both as a legacy (and I think those two go togethe

Re: More toplevel configure.ac pruning

2011-03-25 Thread Joseph S. Myers
On Fri, 25 Mar 2011, Paolo Bonzini wrote: > On 03/24/2011 09:12 PM, Joseph S. Myers wrote: > > -native_only="autoconf automake libtool fileutils find gawk gettext gzip > > hello indent m4 rcs recode sed shellutils tar textutils uudecode wdiff > > target-groff guile perl time ash bash bzip2 prms gn

Re: mt-mep using EXTRA_TARGET_HOST_ALL_MODULES?

2011-03-25 Thread Joseph S. Myers
On Fri, 25 Mar 2011, Paolo Bonzini wrote: > > My question is really whether people are using *any* of the following > > in-tree (in a way that wouldn't better be served by either some other > > package management system, or by their maintaining a local fork of the GCC > > or src tree): bison byacc

[PATCH] Fix DW_OP_GNU_entry_value handling in .debug_loc duplicate removal

2011-03-25 Thread Jakub Jelinek
Hi! While working on a patch I'll post momentarily, I've noticed two issues: 1) DW_OP_GNU_entry_value wasn't being handled by hash_loc_operands/compare_loc_operands, which means different entry values could be considered the same and a wrong location list could be used; the entry value pa

Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)

2011-03-25 Thread Paolo Bonzini
On 03/21/2011 01:59 PM, Rainer Orth wrote: diff -r 8efcb4b03d45 boehm-gc/Makefile.am --- a/boehm-gc/Makefile.am Sun Mar 20 14:28:11 2011 +0100 +++ b/boehm-gc/Makefile.am Sun Mar 20 21:37:14 2011 +0100 @@ -4,10 +4,10 @@ ## files that should be in the distribution are not mentioned in t

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011-03-25 Thread Kai Tietz
2011/3/25 Jason Merrill : > OK. > > Jason > Committed at revision 171445. Thanks, Kai

Re: [PATCH 1/4] Remove cgraph_node function and fixup all callers

2011-03-25 Thread Martin Jambor
Hi, On Wed, Mar 23, 2011 at 10:08:53AM +0100, Jan Hubicka wrote: > > 2011-03-18 Martin Jambor > > > > * cgraph.h (cgraph_node): Remove function declaration. > > (cgraph_create_node): Declare. > > (cgraph_get_create_node): Likewise. > > (cgraph_do_get_node): New function. > > >

[PATCH] Remove -O0 special casing in the stmt verifier

2011-03-25 Thread Richard Guenther
Not necessary anymore. Bootstrapped and tested on x86_64-unknonw-linux-gnu, applied to trunk. Richard. 2011-03-25 Richard Guenther * tree-cfg.c (verify_gimple_assign_unary): Drop special casing of complex types at -O0. (verify_gimple_assign_binary): Likewise.

Re: [v3] Fix negative_binomial_distribution

2011-03-25 Thread Paolo Carlini
... tweaking the fix like this makes for slightly faster repeated calls (spares a division) and also makes clearer that we had a plain typo p / (1 - p) for (1 - p) / p, grrr.. Double checked Devroye in the meanwhile. Committed to mainline, will be in 4.6.1. Paolo. /// 2011-03-25

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011-03-25 Thread Jason Merrill
OK. Jason

Re: [cxx-mem-model] disallow load data races (1 of some)

2011-03-25 Thread Richard Guenther
On Fri, Mar 25, 2011 at 12:57 AM, Andrew MacLeod wrote: >> On Thu, 24 Mar 2011, Aldy Hernandez wrote: >> >>> This work is independent of the C++ memory model.  It is just to prevent >>> the >>> optimizers from introducing new data races due to code movement. This >>> initial >>> pass is just to ma

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011-03-25 Thread Kai Tietz
2011/3/25 Jason Merrill : > On 03/24/2011 08:44 PM, Kai Tietz wrote: >> >> +static bool >> +attribute_value_equal (const_tree attr1, const_tree attr2) >> +{ >> +  if (attr1 == attr2) >> +    return true; > > I still think this test should be comparing TREE_VALUEs. > > Jason > Ok, it makes sense to

Re: [patch middle-end c c++]: Optimize cost of comp_type_attributes

2011-03-25 Thread Jason Merrill
On 03/24/2011 08:44 PM, Kai Tietz wrote: +static bool +attribute_value_equal (const_tree attr1, const_tree attr2) +{ + if (attr1 == attr2) +return true; I still think this test should be comparing TREE_VALUEs. Jason

Re: Tighten ARM's CANNOT_CHANGE_MODE_CLASS

2011-03-25 Thread Richard Sandiford
Richard Earnshaw writes: > On Thu, 2011-03-24 at 15:40 +, Richard Sandiford wrote: >> gcc/ >> * config/arm/arm.h (CANNOT_CHANGE_MODE_CLASS): Restrict FPA_REGS >> case to VFPv1. >> > > GCC doesn't support VFPv1 (see the all_fpus table), and I don't think > many chips based on that ev

[PING^2]: For unreviewed patches

2011-03-25 Thread Kai Tietz
Ping for following patches [patch libcpp]: Improve handling of DOS-filenames and -paths http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00742.html [patch gcc c++ c-family java fortan lto]: Fix DOS-filesystem issues http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00824.html Kai

Re: More toplevel configure.ac pruning

2011-03-25 Thread Paolo Bonzini
On 03/24/2011 09:12 PM, Joseph S. Myers wrote: -native_only="autoconf automake libtool fileutils find gawk gettext gzip hello indent m4 rcs recode sed shellutils tar textutils uudecode wdiff target-groff guile perl time ash bash bzip2 prms gnuserv target-gperf" +native_only="autoconf automake l

Re: Remove old host cases from toplevel configure

2011-03-25 Thread Paolo Bonzini
On 03/24/2011 08:49 PM, Joseph S. Myers wrote: Related to that point, I notice a piece of code starting "we might need to use some other shell than /bin/sh for running subshells" that tries to determine a shell on Windows hosts. It's autoconf's job to find a suitable shell, so if this code is st

  1   2   >