Re: Adjust omp-low test for alignment

2012-02-01 Thread Andreas Krebbel
On Sat, Nov 26, 2011 at 04:05:08PM -0800, Richard Henderson wrote: The m68k-linux failure for the various omp atomic tests is due to the fact that BIGGEST_ALIGNMENT is 16 bits on that platform. I think it's pretty reasonable to assume that if something is aligned to BIGGEST_ALIGNEMENT, then

Re: [trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-02-01 Thread Richard Guenther
On Tue, Jan 31, 2012 at 6:11 PM, Patrick Marlier patrick.marl...@gmail.com wrote: In the PR testcase, a call to __builtin_prefetch is done. When this function call comes into expand_call_tm, there is no cgraph_node associated for this builtin and thus node-local fails. trans-mem.c

Re: [PATCH] Clarify inline flag documentation

2012-02-01 Thread Richard Guenther
On Tue, 31 Jan 2012, Richard Guenther wrote: Thus, the following tries to clarify the documentation of -fno-inline and -finline-functions. Does that help? lxo noticed a completely off comment in common.opt so I adjusted documentation therein as well. Committed. Richard. 2012-02-01

Re: [patch libjava]: Fix PR target/51500

2012-02-01 Thread Kai Tietz
2012/1/30 Andrew Haley a...@redhat.com: On 01/29/2012 02:15 PM, Kai Tietz wrote: 2012-01-29  Kai Tietz  kti...@redhat.com       PR target/51500       * interpret.cc (_Jv_init_cif): Handle thiscall       convention for 32-bit Windows.       * java/lang/reflect/natMethod.cc

[Patch/ada] Fix thinko in Loop_Statement_to_gnu

2012-02-01 Thread Tristan Gingold
Hi, this patchlet fixes a thinko in Loop_Statement_to_gnu: size_type_node was used instead of sizetype. Privately approved by Eric. Committed on trunk. Tristan. gcc/ada 2012-02-01 Tristan Gingold ging...@adacore.com * gcc-interface/trans.c (Loop_Statement_to_gnu): Use sizetype

Ping^5: Out-of-order update of new_spill_reg_store[]

2012-02-01 Thread Richard Sandiford
Ping for this reload inheritance patch: http://gcc.gnu.org/ml/gcc-patches/2011-12/msg00266.html or perhaps the original: http://gcc.gnu.org/ml/gcc-patches/2011-10/msg00663.html It fixes some wrong-code regressions in execute/scal-to-vec1.c on mips64-linux-gnu and mips64-elf. Richard

Re: [patch libjava]: Fix PR target/51500

2012-02-01 Thread Andrew Haley
On 02/01/2012 09:47 AM, Kai Tietz wrote: I sent update-patch to ML for libffi to support closure-code for thiscall. So the hunk in patch for java/lang/reflect/natVMProxy.cc (ncode): Force SYSV closure for 32-bit Windows. Isn't necessary, if the fix in libffi gets applied. Ok to commit

[google] Backport ThreadSanitizer instrumentation pass from google/main to google/gcc-4_6 (issue5610048)

2012-02-01 Thread Dmitriy Vyukov
This is for google/gcc-4_6 branch. Backport ThreadSanitizer (tsan) instrumentation pass from google/main. * tree-tsan.c: New file. * tree-tsan.h: New file. * tree-pass.h: Add tsan pass. * passes.c: Add tsan pass. * toplev.c (compile_file): Call

Re: [Patch, Fortran] PR52059 - Scalarizing fix - only add array ref to a variable

2012-02-01 Thread Mikael Morin
On 31.01.2012 23:22, Tobias Burnus wrote: Dear all, I have no idea about the scalarizer, but the attached patch fixes the test case and somehow adding an array ref to a scalar looks odd to me ... ?? The condition is about an array without array ref, isn't it? We can't access the array part of

Re: [wwwdocs] Add section on diagnostics conventions

2012-02-01 Thread Gabriel Dos Reis
On Tue, Jan 31, 2012 at 7:50 PM, Diego Novillo dnovi...@google.com wrote: On Mon, Jan 30, 2012 at 15:21, Joseph S. Myers jos...@codesourcery.com wrote: On Sun, 29 Jan 2012, Diego Novillo wrote: +licodeinternal_error/code is used for conditions that should not +be triggered by any user input

Re: [Patch, Fortran] PR 52024 - fix .mod issue with type-bound operator check

2012-02-01 Thread Mikael Morin
On 31.01.2012 23:41, Tobias Burnus wrote: Tobias Burnus wrote: Unfortunately, it turns out that the check does not handle inheritance well. At least I would expect that the attached test case is valid (and it compiles with NAG 5.1), but it is rejected with GCC 4.6 and 4.7. Actually, I

[AVR,testsuite,trunk,4.6,committed]: Add test case for PR51374.

2012-02-01 Thread Georg-Johann Lay
http://gcc.gnu.org/viewcvs?view=revisionrevision=183796 http://gcc.gnu.org/viewcvs?view=revisionrevision=183797 Johann

Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Georg-Johann Lay
http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01502.html Georg-Johann Lay wrote: Jakub Jelinek wrote: On Fri, Jan 13, 2012 at 07:40:59PM +0100, Georg-Johann Lay wrote: The ilp32 is the closes match: The source casts pointer to int, int to pointer, long to int, uses 32-bit initializers for

Re: Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Jakub Jelinek
On Wed, Feb 01, 2012 at 02:00:53PM +0100, Georg-Johann Lay wrote: * gcc.dg/lto/20091013-1_1.c: xfail for avr. * gcc.dg/lto/20091013-1_2.c: xfail for avr. If it is just because of the warnings, can't you add -Wno-int-to-pointer-cast -Wno-pointer-to-int-cast to dg-options? Also, not

[PATCH][RFC] Fix PR48124

2012-02-01 Thread Richard Guenther
This fixes PR48124 where a bitfield store leaks into adjacent decls if the decl we store to has bigger alignment than what its type requires (thus there is another decl in that padding). What we need to do is limit what get_best_mode returns and we can do so by specifying a mode on the MEM we

Re: [arm] Improve longlong.h umul_ppmm, count_trailing_zeros

2012-02-01 Thread Richard Earnshaw
On 31/01/12 05:15, Richard Henderson wrote: I noticed this accidentally, while looking for something else. There are significant improvements in the DImode multiplication and division routines for armv4+. Despite how trivial this is, I assume this must wait for stage1. Ok? r~

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jakub Jelinek
On Mon, Jan 30, 2012 at 03:26:32PM -0500, Jason Merrill wrote: On 01/30/2012 11:11 AM, Jakub Jelinek wrote: Can't tlink just take into account that sometimes different symbols mangle the same, and handle those as a group (i.e. if the linker output requests S::~S(), and *.rpo files contain

Re: Ping #1: [Patch,testsuite]: Fix testcase that bangs long and int against void*

2012-02-01 Thread Georg-Johann Lay
Jakub Jelinek wrote: On Wed, Feb 01, 2012 at 02:00:53PM +0100, Georg-Johann Lay wrote: * gcc.dg/lto/20091013-1_1.c: xfail for avr. * gcc.dg/lto/20091013-1_2.c: xfail for avr. If it is just because of the warnings, can't you add -Wno-int-to-pointer-cast -Wno-pointer-to-int-cast to

Go patch committed: Accept general expression in case x := -c

2012-02-01 Thread Ian Lance Taylor
The Go language specification permits a general expression in select { case x := -c: } which basically means that it can look like case x := (-c): The gccgo parser was failing to handle that case. This patch fixes it. Bootstrapped and ran Go testsuite on

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jason Merrill
On 02/01/2012 08:56 AM, Jakub Jelinek wrote: Sure, but would they ever be provided by different CUs? If some CU says it can provide _ZN1SD1Ev, doesn't it either always say that it can provide _ZN1SD2Ev, or none of the CU is able to provide the latter (at least in valid C++ without ODR

Re: Static branch prediction: compare IV to loop bound variable (issue 5504086)

2012-02-01 Thread Dehao Chen
There are still some minor bugs in the current implementation, which is fixed by the attached patch: passed bootstrap/regression tests for both google-4_6 and google-main branch. ok for google branch? Thanks, Dehao gcc/ChangeLog.google-4_6 2012-01-31 Dehao Chen de...@google.com *

Re: Out-of-order update of new_spill_reg_store[]

2012-02-01 Thread Ulrich Weigand
Richard Sandiford wrote: Bernd Schmidt ber...@codesourcery.com writes: gcc/ * reload1.c (reload_regs_reach_end_p): Replace with... (reload_reg_rtx_reaches_end_p): ...this function. (new_spill_reg_store): Update commentary. (emit_input_reload_insns): Don't clear

[PATCH] Don't ICE in vectorizer when testing if a pattern stmt is used by another pattern stmt (PR tree-optimization/52073)

2012-02-01 Thread Jakub Jelinek
Hi! vinfo_for_stmt can't be used on stmts outside of the current loop. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-02-01 Jakub Jelinek ja...@redhat.com PR tree-optimization/52073 * tree-vect-stmts.c (vect_mark_relevant): When checking uses of

Re: Static branch prediction: compare IV to loop bound variable (issue 5504086)

2012-02-01 Thread Xinliang David Li
ok. thanks, David On Wed, Feb 1, 2012 at 7:33 AM, Dehao Chen de...@google.com wrote: There are still some minor bugs in the current implementation, which is fixed by the attached patch: passed bootstrap/regression tests for both google-4_6 and google-main branch. ok for google branch?

[PATCH] Fix expansion of constants with -fsection-anchors (PR middle-end/52074)

2012-02-01 Thread Jakub Jelinek
Hi! For EXPAND_NORMAL we shouldn't be returning (plus (reg) (const_int)), that should be limited to EXPAND_SUM and higher modifiers. But with -fsection-anchors we sometimes do. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, tested with cross to powerpc64-linux on the

Re: PR middle-end/24306 revisited: va_arg and zero-sized objects

2012-02-01 Thread nick clifton
Hi Richard, [ Nick, you might remember mentioning this bug a few months back. I think I've finally got a proper fix, rather than the failed attempt I originally sent. ] Thanks for fixing this. I am going to copy your patch into our internal sources and mark it as a local fix on the

Re: [wwwdocs] Add section on diagnostics conventions

2012-02-01 Thread Georg-Johann Lay
Diego Novillo wrote: This is the first of a few patches to update GCC's documentation with the proposed conventions in the GCC Development Conventions document that Joseph and I published last year

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 06:56 AM, Jakub Jelinek wrote: Do users really want to demangle linker maps? I would never want that, e.g. because it is ambiguous and less compact. IMHO the best is just to back out the changes that introduced this regression. I don't think this is even really a regression. I

[pph] Make tracing more robust. (issue5616043)

2012-02-01 Thread Lawrence Crowl
This patch makes tracing more robust. It attempts to use type dumping where possible, use the PPH merge name where possible, and otherwise use ?. It protects protecting existing type dump machinery against some unexpected nulls. It changes tree streaming to write decl minimal fields first, so

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Jason Merrill
On 02/01/2012 01:51 PM, Sandra Loosemore wrote: I don't think this is even really a regression. The testcase works with 4.6 and not with pre-4.7; that makes it a regression. I haven't actually sat down to try to reproduce this, but backing out the previous patch would leave the -frepo

Re: [PATCH, go]: Do not panic in test/nilptr.go

2012-02-01 Thread Uros Bizjak
On Tue, Jan 31, 2012 at 8:36 PM, Ian Lance Taylor i...@google.com wrote: There is no need for a panic in test/nilptr.go if array doesn't get allocated in first 256 meg of memory. The compiler has nothing to do with this. This is true but this does not seem like the right patch. I think I

Re: [patch, fortran] Fix PR 51958, wrong-code regression with function elimination

2012-02-01 Thread Thomas Koenig
Hi Steve, On Wed, Feb 01, 2012 at 12:47:28AM +0100, Thomas Koenig wrote: Hi Steve, + else_stmt-expr1 = NULL; + else_stmt-next = c_if1; + else_stmt-block = NULL; + else_stmt-next = c_if1; Is one of the else_stmt-next = c_if1; redundant? Definitely. I'll take it out

Re: [google] Propagate profile information to RTL level during switch expansion

2012-02-01 Thread Easwaran Raman
On Tue, Jan 31, 2012 at 10:16 PM, Xinliang David Li davi...@google.com wrote: Ok for google branch with minor changes below. thanks, David +#define case_probability(x, y) ((y) ? ((x) * REG_BR_PROB_BASE  / (y))  : -1) + Using upper case for macro? From

Re: Adding html documentation for svn mobile branches

2012-02-01 Thread Diego Novillo
On 2/1/12 11:44 AM, Ahmad Sharif wrote: Diego, does this patch look OK for submission? Looks fine. Thanks. Diego.

Re: [google] Propagate profile information to RTL level during switch expansion

2012-02-01 Thread Xinliang David Li
thanks. ok for google/gcc_46 branch. David On Wed, Feb 1, 2012 at 11:52 AM, Easwaran Raman era...@google.com wrote: On Tue, Jan 31, 2012 at 10:16 PM, Xinliang David Li davi...@google.com wrote: Ok for google branch with minor changes below. thanks, David +#define case_probability(x, y)

Go patch committed: Don't crash on switch _ := v.(type)

2012-02-01 Thread Ian Lance Taylor
This patch to the Go compiler avoids crashing on switch _ := v.(type). Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 6cc0b85ab55c go/parse.cc --- a/go/parse.cc Wed Feb 01 11:15:32 2012 -0800 +++ b/go/parse.cc Wed Feb 01 12:38:57 2012 -0800 @@

Re: [PATCH] Fix PR 51910, -frepo/linker demangling interaction

2012-02-01 Thread Sandra Loosemore
On 02/01/2012 12:31 PM, Jason Merrill wrote: Why do you want the link map to be demangled? It seems more reliable to deal with mangled symbols; there's always c++filt if you want to check what the symbols demangle to. It's certainly more reliable for automated tools to deal with mangled

Re: Out-of-order update of new_spill_reg_store[]

2012-02-01 Thread Richard Sandiford
Thanks for looking at this. Ulrich Weigand uweig...@de.ibm.com writes: Richard Sandiford wrote: Either way, the idea is that new_spill_reg_store[R] is only valid for reload registers R that reach the end of the reload sequence. We really should check that H1 reaches the end

libgo patch committed: Make sure file is not closed early

2012-02-01 Thread Ian Lance Taylor
This patch to libgo fixes the test for leaked file descriptors. In some cases the file, expected to be open, could be collected by the garbage collector and closed. This then caused the next call to open to return that descriptor rather than the expected one, causing the test to fail. This patch

Re: [trans-mem, PATCH] do not dereference node if null in expand_call_tm (PR middle-end/52047)

2012-02-01 Thread Patrick Marlier
On 02/01/2012 03:59 AM, Richard Guenther wrote: The patch looks ok, but I'm not sure why you do not get a cgraph node here - cgraph doesn't really care for builtins as far as I can see. Honza? I cannot help on this... Don't you maybe want to handle builtins in a special way here? Indeed, I

Re: [PATCH, go]: Do not panic in test/nilptr.go

2012-02-01 Thread Ian Lance Taylor
Uros Bizjak ubiz...@gmail.com writes: Attached is the patch I have committed. Thanks for taking care of that. (BTW: Do you have any idea on what to do with excessive memory usage in chan/select2.go? ) At this point I don't. It's sort of peculiar. Sending an int on a channel should not

Go patch committed: Fix type checking for append

2012-02-01 Thread Ian Lance Taylor
The Go language specification says that for append(a1, a2) a1 must be a slice. If the element type of a1 is T, then a2 must be assignable to the type []T. The gccgo frontend was incorrectly requiring that a2 be assignable to the type of a1. This patch corrects that. Bootstrapped and

Too much memory in chan/select2.go used

2012-02-01 Thread Uros Bizjak
On Wed, Feb 1, 2012 at 10:27 PM, Ian Lance Taylor i...@google.com wrote: (BTW: Do you have any idea on what to do with excessive memory usage in chan/select2.go? ) At this point I don't.  It's sort of peculiar.  Sending an int on a channel should not use any memory.  The test is careful to

Configuring gcc without symlink support

2012-02-01 Thread Earl Chew
Some environments don't support symbolic links :-( If ln -s is not supported, configure can figure it out, and as a last resort uses: LN_S = cp -p I've found two problems with this. The first problem is that LN_S is not propagated past the top-level Makefile. This can manifest as strange

[PATCH] [MIPS] fix mips_prepend insn.

2012-02-01 Thread Liu
Hi all This is the bugfix patch for mips_prepend, please review. Jia Liu diff --git a/gcc/config/mips/mips-dspr2.md b/gcc/config/mips/mips-dspr2.md index 5ae902f..6853b9d 100644 --- a/gcc/config/mips/mips-dspr2.md +++ b/gcc/config/mips/mips-dspr2.md @@ -345,7 +345,7 @@ (set_attr mode

[pph] Minimal type merging. (issue5620047)

2012-02-01 Thread Lawrence Crowl
This patch adds minimal type merging. It unifies the existence of types for a struct decl. The method is to emit a merge key for the type when we emit a merge key for the struct decl. Test x4structover1.cc is now passing. The next step is to merge struct definitions. For that we have test

Re: [pph] Minimal type merging. (issue5620047)

2012-02-01 Thread Diego Novillo
On Wed, Feb 1, 2012 at 18:44, Lawrence Crowl cr...@google.com wrote: @@ -1393,7 +1393,12 @@ dump_function_decl (tree t, int flags)     }   fntype = TREE_TYPE (t); -  parmtypes = FUNCTION_FIRST_USER_PARMTYPE (t); +  gcc_assert (fntype) You forgot a semi-colon :) Fixed. Diego.

[pph] More GC fixes (issue5606049)

2012-02-01 Thread Diego Novillo
This patch extends the hack I added in http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01031.html to pacify the garbage collector. I have to keep using the same fake GC root because these trees are added to structures that I can't seem to get properly annotated for GC. In particular, I'm having

[PATCH, rs6000] Add support for the POWER7 dcffix instruction

2012-02-01 Thread Peter Bergner
The POWER Toolchain IPC team who is adding POWER7 support to valgrind reminded me that Power ISA 2.06 added a new convert from integer to decimal64 dfp instruction. The following patch adds support for it. This passed bootstrap and regression testing with no regressions. Is this ok? If so, when

Re: [wwwdocs] Add section on diagnostics conventions

2012-02-01 Thread Diego Novillo
On Wed Feb 1 09:15:51 2012, Georg-Johann Lay wrote: Diego Novillo wrote: This is the first of a few patches to update GCC's documentation with the proposed conventions in the GCC Development Conventions document that Joseph and I published last year

Re: [wwwdocs] Add section on diagnostics conventions

2012-02-01 Thread Diego Novillo
Thanks. I've incorporated your feedback in the attached patch. OK for wwwdocs? Diego. ? 00.diff ? codingconventions.html.orig Index: codingconventions.html === RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v

Re: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-01 Thread Liu
diff --git a/gcc/config/mips/mips-dspr2.md b/gcc/config/mips/mips-dspr2.mdindex 5ae902f..6853b9d 100644--- a/gcc/config/mips/mips-dspr2.md+++ b/gcc/config/mips/mips-dspr2.md@@ -345,7 +345,7 @@    (set_attr modeSI)])  (define_insn mips_prepend-  [(set (match_operand:SI 0 register_operand =d)+

Re: [PATCH, rs6000] Add support for the POWER7 dcffix instruction

2012-02-01 Thread David Edelsohn
On Wed, Feb 1, 2012 at 10:00 PM, Peter Bergner berg...@vnet.ibm.com wrote: The POWER Toolchain IPC team who is adding POWER7 support to valgrind reminded me that Power ISA 2.06 added a new convert from integer to decimal64 dfp instruction.  The following patch adds support for it. This passed

Re: Configuring gcc without symlink support

2012-02-01 Thread Andris Pavenis
On 02/02/2012 12:41 AM, Earl Chew wrote: Some environments don't support symbolic links :-( If ln -s is not supported, configure can figure it out, and as a last resort uses: LN_S = cp -p I've found two problems with this. The first problem is that LN_S is not propagated past the top-level

Go patch committed: Fix method expression parameter references

2012-02-01 Thread Ian Lance Taylor
The Go frontend had a couple of bugs when using method expressions with parameters. It crashed if the parameters had no names. And it did the wrong thing if the types were imported. This patch fixes both problems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to

libgo patch committed: Add syscall.Times

2012-02-01 Thread Ian Lance Taylor
This patch to libgo adds the syscall.Times function, which corresponds to the POSIX function times. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 492a0c57d461 libgo/go/syscall/libcall_posix.go --- a/libgo/go/syscall/libcall_posix.go Wed Feb

Re: [PATCH] Don't ICE in vectorizer when testing if a pattern stmt is used by another pattern stmt (PR tree-optimization/52073)

2012-02-01 Thread Ira Rosen
Jakub Jelinek ja...@redhat.com wrote on 01/02/2012 06:40:13 PM: Hi! Hi, vinfo_for_stmt can't be used on stmts outside of the current loop. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Yes. Thanks, Ira 2012-02-01 Jakub Jelinek ja...@redhat.com PR

Merged trunk to gccgo branch

2012-02-01 Thread Ian Lance Taylor
I merged trunk revision 183826 to the gccgo branch. Ian