Re: [Patch, Fortran, OOP] PR 52968: Call to type-bound procedure wrongly rejected

2012-04-16 Thread Tobias Burnus
Janus Weil wrote: here is a small patch for an OOP problem. For discussion see the PR. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? OK and thanks for the patch. Note, however, that since Bernhard's patch*, using cleanup-modules is usually not needed. *

Re: [C++ Patch] PR 49152

2012-04-16 Thread Gabriel Dos Reis
On Mon, Apr 16, 2012 at 12:42 AM, Marc Glisse marc.gli...@inria.fr wrote: On Sun, 15 Apr 2012, Gabriel Dos Reis wrote: a hybrid approach; I would suggest something like this: (a) if caret is in effect, then print the caret pointing to the symbol in question; otherwise (b) print the symbol

[Fortran] Patch ping

2012-04-16 Thread Tobias Burnus
Dear all, first, I would like to ping my patch: - [Patch, Fortran] PR52864 - fix actual/formal checks http://gcc.gnu.org/ml/fortran/2012-04/msg00059.html Other patches with pending review: - [Patch, Fortran, F03] PR52909: Procedure pointers not private to modules

Re: [Patch, Fortran, OOP] PR 52968: Call to type-bound procedure wrongly rejected

2012-04-16 Thread Janus Weil
Hi Tobias, here is a small patch for an OOP problem. For discussion see the PR. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? OK and thanks for the patch. thanks for the review. Committed as r186486. Note, however, that since Bernhard's patch*, using cleanup-modules is usually not

Re: [PATCH] Fix PR52976

2012-04-16 Thread Richard Guenther
On Sat, Apr 14, 2012 at 7:05 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: This patch corrects two errors in reassociating expressions with repeated factors.  First, undistribution needs to recognize repeated factors.  For now, repeated factors will be ineligible for this

Re: RFA: Remove ADDRESS handling from gen*.c

2012-04-16 Thread Richard Guenther
On Sun, Apr 15, 2012 at 5:09 PM, Richard Sandiford rdsandif...@googlemail.com wrote: ADDRESS has long had no meaning in .md files.  This patch removes the associated gen* support. Borders on the obvious, but just to be sure: bootstrapped regression tested on x86_64-linux-gnu.  OK to install?

Re: [doc] tm.texi: Move NO_DOLLAR_IN LABEL and NO_DOT_IN_LABEL to Label Output section (was: GCC 4.6.1 likes to rename my functions)

2012-04-16 Thread Richard Guenther
On Mon, Apr 16, 2012 at 2:10 AM, Gerald Pfeifer ger...@pfeifer.com wrote: On Wed, 6 Jul 2011, Paulo J. Matos wrote: On 06/07/11 16:08, Richard Guenther wrote: See cgraph.c:clone_function_name, it uses the NO_DOT_IN_LABEL and NO_DOLLAR_IN_LABEL target macros and ASM_FORMAT_PRIVATE_NAME. Why

[PATCH] Fix parts of PR52975

2012-04-16 Thread Richard Guenther
When looking at the code we produce from if-conversion and vectorization I noticed several things. For one, we are not handling TARGET_MEM_REF in operand_equal_p which means that DOM does not clean up loads/stores of that form (to the extent DOM can do that anyway). Also we never simplify the

[testsuite] Fix plugin testsuite, remove uses of TODO_dump_func (PR testsuite/52948)

2012-04-16 Thread Rainer Orth
As reported in PR testsuite/52948, several plugin testcases were failing since the removal of TODO_dump_func: UNRESOLVED: selfassign.c compilation, -I. -I/vol/gcc/src/hg/trunk/local/gcc/testsuite -I/vol/gcc/src/hg/trunk/local/gcc/testsuite/../../gcc

Use target_alias in validate_failures.py

2012-04-16 Thread Rainer Orth
When I tried contrib/testsuite-management/validate_failures.py for the first time this weekend, I ran into the following problem: while it works fine for a i386-pc-solaris2.11 bootstrap, it fails instead for a amd64-pc-solaris2.11 bootstrap: error: 11-gcc-64/build is not a valid GCC top

[PATCH] Fix PR52975

2012-04-16 Thread Richard Guenther
This fixes the missed cleanup opportunities from the if-conversion mess. We should try to produce consistent predicates - thus not do overly optimistic simplifications on them. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-04-16 Richard Guenther

Re: [PATCH] Fix PR52976

2012-04-16 Thread William J. Schmidt
On Mon, 2012-04-16 at 11:01 +0200, Richard Guenther wrote: On Sat, Apr 14, 2012 at 7:05 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: This patch corrects two errors in reassociating expressions with repeated factors. First, undistribution needs to recognize repeated factors.

Re: [PATCH][ARM] NEON DImode neg

2012-04-16 Thread Richard Earnshaw
On 14/04/12 14:11, Andrew Stubbs wrote: And now with the patch. :( On 14/04/12 13:48, Andrew Stubbs wrote: On 12/04/12 16:48, Richard Earnshaw wrote: If negation in Neon needs a scratch register, it seems to me to be somewhat odd that we're disparaging the ARM version. Also, wouldn't it

Re: [PATCH][configure] Make sure CFLAGS_FOR_TARGET And CXXFLAGS_FOR_TARGET contain -O2

2012-04-16 Thread Christophe Lyon
Ping? On 29.03.2012 13:48, Christophe Lyon wrote: Hello, According to a comment in configure/configure.ac: # We want to ensure that TARGET libraries (which we know are built with # gcc) are built with -O2 -g, so include those options when setting # CFLAGS_FOR_TARGET and CXXFLAGS_FOR_TARGET.

[PATCH] Fix PR52977

2012-04-16 Thread Richard Guenther
This fixes PR52977 - for PCH to work with its pointer relocation code we have to avoid dereferencing pointers to compute array lengths in structures. So we have to unfortunately keep duplicated info about VECTOR_CST vector lengths. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to

Re: [PATCH] Fix PR52977

2012-04-16 Thread Steven Bosscher
On Mon, Apr 16, 2012 at 3:19 PM, Richard Guenther rguent...@suse.de wrote: This fixes PR52977 - for PCH to work with its pointer relocation code we have to avoid dereferencing pointers to compute array lengths in structures.  So we have to unfortunately keep duplicated info about VECTOR_CST

Re: [PATCH] Fix PR52977

2012-04-16 Thread Richard Guenther
On Mon, 16 Apr 2012, Steven Bosscher wrote: On Mon, Apr 16, 2012 at 3:19 PM, Richard Guenther rguent...@suse.de wrote: This fixes PR52977 - for PCH to work with its pointer relocation code we have to avoid dereferencing pointers to compute array lengths in structures.  So we have to

Re: RFA: always supply a mode to plus_constant

2012-04-16 Thread Richard Earnshaw
On 15/04/12 10:29, Richard Sandiford wrote: As mentioned in the discussion of Mike's 2HWI patch, plus_constant is AFAIK the only rtl routine that handles arithmetic on CONST_INT without specifying the mode of the CONST_INT. That means it isn't always able to generate the right result. E.g.

Re: [PATCH] Fix PR52977

2012-04-16 Thread Diego Novillo
On Mon, Apr 16, 2012 at 10:23, Richard Guenther rguent...@suse.de wrote: On Mon, 16 Apr 2012, Steven Bosscher wrote: On Mon, Apr 16, 2012 at 3:19 PM, Richard Guenther rguent...@suse.de wrote: This fixes PR52977 - for PCH to work with its pointer relocation code we have to avoid

Re: [PATCH] Fix PR52977

2012-04-16 Thread Richard Guenther
On Mon, 16 Apr 2012, Diego Novillo wrote: On Mon, Apr 16, 2012 at 10:23, Richard Guenther rguent...@suse.de wrote: On Mon, 16 Apr 2012, Steven Bosscher wrote: On Mon, Apr 16, 2012 at 3:19 PM, Richard Guenther rguent...@suse.de wrote: This fixes PR52977 - for PCH to work with its

Symbol table 5/many: Introduce symtab.c and commonize linked list of symbol table entries

2012-04-16 Thread Jan Hubicka
Hi, this patch starts with process of commonizing code that should be in symtab.c. It moves linked lists out of cgraph and varpool nodes into the symbol base type and compensates all remaining places we walk the lists directly to use the accessor functions. Finally bit of benefits and code

Re: [C++ Patch] PR 49152

2012-04-16 Thread Gabriel Dos Reis
On Mon, Apr 16, 2012 at 8:31 AM, Paolo Carlini paolo.carl...@oracle.com wrote: Hi, On Mon, Apr 16, 2012 at 12:42 AM, Marc Glissemarc.gli...@inria.fr  wrote: On Sun, 15 Apr 2012, Gabriel Dos Reis wrote: a hybrid approach; I would suggest something like this: (a) if caret is in effect, then

Re: [Patch ARM] Fix PR51819.

2012-04-16 Thread Ramana Radhakrishnan
Hi Uli, Apologies for the delayed response. Shouldn't the check be implemented along the following lines?        if (memsize == 32 (align % 32) == 0)          align_bits = 256;        else if ((memsize == 16 || memsize == 32) (align % 16) == 0)          align_bits = 128;        else if

Re: [patch optimization]: Add some basic folding for ==/!= comparison

2012-04-16 Thread Kai Tietz
2012/4/12 Richard Guenther richard.guent...@gmail.com: On Thu, Apr 5, 2012 at 6:15 PM, Kai Tietz ktiet...@googlemail.com wrote: Hello, this patch adds some basic folding capabilities to fold-const for equal and none-equal comparisons on integer typed argument. ChangeLog 2012-04-05  Kai

Re: [PATCH] Fix PR52977

2012-04-16 Thread Diego Novillo
On 4/16/12 10:43 AM, Richard Guenther wrote: Well, the number one advantage of replacing PCH is that it would kill the current PCH implementation which is tied to our garbage collector... Sure. That too. Diego.

Re: Use target_alias in validate_failures.py

2012-04-16 Thread Diego Novillo
On 4/16/12 7:32 AM, Rainer Orth wrote: Btw., it occured to me that it might be useful to add an option to locate out-of-tree manifests. I often have several source trees (unmodified sources, ones with local patches) and would like to share manifests between them. While this can be achieved

C++ PATCH for c++/51148 (missed error on unexpanded pack in friend declaration)

2012-04-16 Thread Jason Merrill
Just another place we need to call check_for_bare_parameter_packs. Tested x86_64-pc-linux-gnu, applying to trunk. commit 616afbea9bf859633ade63b6536e5b63be5a19e6 Author: Jason Merrill ja...@redhat.com Date: Mon Apr 16 09:23:41 2012 -0400 PR c++/51148 * friend.c (make_friend_class):

Re: [PATCH] Prevent 'control reaches end of non-void function' warning for DO_WHILE

2012-04-16 Thread Jason Merrill
On 04/14/2012 05:43 PM, Tom de Vries wrote: + tree expr = NULL; + append_to_statement_list (*block,expr); + *block = expr; Rather than doing this dance here, I think it would be better to enhance append_to_statement_list to handle the case of the list argument being a

[v3, testsuite] Fix merging default libstdc++.log

2012-04-16 Thread Rainer Orth
I've long noticed that libstdc++.log (unlike libstdc++.sum) doesn't contain log entries for tests run from abi.exp, but hadn't looked closer, getting used to check libstdc++.log.sep instead which contained everything I expected. This weekend, I've observed the same for the prettyprinters.exp

[PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
Hello, Here is patch for i386 Android support. It is the second part of previously splitted patch (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first part has been committed (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00378.html). Bootstrapped and checked on linux-x86_64. OK for

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread H.J. Lu
On Mon, Apr 16, 2012 at 8:33 AM, Ilya Enkovich enkovich@gmail.com wrote: Hello, Here is patch for i386 Android support. It is the second part of previously splitted patch (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first part has been committed

Re: [Patch ARM] Fix PR51819.

2012-04-16 Thread Ulrich Weigand
Ramana Radhakrishnan wrote: This looks OK to me. Looking at the ISA documents and the variants of the vldn instructions your summary is correct. The alignment specifier should not be greater than the memory size being transferred and checking this in this form is OK . Thanks, Ramana! I've

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android support. Thanks. H.J. --- Hi, The first part will just add empty file. What is the reason to do it? Testing will not even reveal if I added it incorrectly.

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich enkovich@gmail.com wrote: Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android support. Thanks. H.J. --- Hi, The first part will just add empty file. What

Symbol table 6/many: Symbol table hashes

2012-04-16 Thread Jan Hubicka
Hi, this patch moves cgraph/varpool hashes into symbol table hashes, so the symbol table is actually almost a symbol table ;) Work done. Bootstrapped/regtested x86_64-linux. Will commit it after bit of more testing - the assembler name handling is slipperly wrt aliases. Honza * cgraph.c

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread H.J. Lu
On Mon, Apr 16, 2012 at 9:08 AM, Ilya Enkovich enkovich@gmail.com wrote: On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich enkovich@gmail.com wrote: Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android

Re: RFA: always supply a mode to plus_constant

2012-04-16 Thread Michael Eager
On 04/15/2012 02:29 AM, Richard Sandiford wrote: alpha-linux-gnu arm-linux-gnueabi avr-rtems bfin-elf c6x-elf cr16-elf cris-elf epiphany-elf fr30-elf frv-linux-gnu h8300-elf ia64-linux-gnu iq2000-elf lm32-elf m32c-elf m32r-elf m68k-linux-gnu mcore-elf mep-elf

Re: [Fortran] Patch ping

2012-04-16 Thread Thomas Koenig
Hi Tobias, - [patch, fortran] Trim spaces on list-directed reads http://gcc.gnu.org/ml/fortran/2012-04/msg00040.html That one was committed: http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00417.html Jerry indicated that this would also be OK for a backport; I'll do that within a few days unless

Re: [PATCH] Fix PR52977

2012-04-16 Thread Steven Bosscher
On Mon, Apr 16, 2012 at 3:38 PM, Diego Novillo dnovi...@google.com wrote: I'm not sure PPH will replace PCH - will it? In theory, it may.  But it's not in the immediate plans. IMHO, the case for including PPH would be much stronger if replacing PCH would be included in the immediate to

Re: [patch optimization]: Add some basic folding for ==/!= comparison

2012-04-16 Thread Richard Guenther
On Mon, Apr 16, 2012 at 3:58 PM, Kai Tietz ktiet...@googlemail.com wrote: 2012/4/12 Richard Guenther richard.guent...@gmail.com: On Thu, Apr 5, 2012 at 6:15 PM, Kai Tietz ktiet...@googlemail.com wrote: Hello, this patch adds some basic folding capabilities to fold-const for equal and

Re: [testsuite] Fix plugin testsuite, remove uses of TODO_dump_func (PR testsuite/52948)

2012-04-16 Thread Xinliang David Li
cc Richard. thanks, David On Mon, Apr 16, 2012 at 3:24 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: As reported in PR testsuite/52948, several plugin testcases were failing since the removal of TODO_dump_func: UNRESOLVED: selfassign.c compilation, -I.

Re: [patch optimization]: Add some basic folding for ==/!= comparison

2012-04-16 Thread Kai Tietz
2012/4/16 Richard Guenther richard.guent...@gmail.com: On Mon, Apr 16, 2012 at 3:58 PM, Kai Tietz ktiet...@googlemail.com wrote: 2012/4/12 Richard Guenther richard.guent...@gmail.com: On Thu, Apr 5, 2012 at 6:15 PM, Kai Tietz ktiet...@googlemail.com wrote: Hello, this patch adds some basic

Re: PING: PATCH: Backport x32 support to libtool

2012-04-16 Thread H.J. Lu
On Tue, Apr 3, 2012 at 7:49 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Mar 29, 2012 at 7:34 AM, H.J. Lu hjl.to...@gmail.com wrote: On Sat, Mar 3, 2012 at 9:54 AM, H.J. Lu hongjiu...@intel.com wrote: Hi, This patch backports x32 support to libtool:

Re: [v3, testsuite] Fix merging default libstdc++.log

2012-04-16 Thread Mike Stump
On Apr 16, 2012, at 8:03 AM, Rainer Orth wrote: I've long noticed that libstdc++.log (unlike libstdc++.sum) doesn't contain log entries for tests run from abi.exp, but hadn't looked closer, getting used to check libstdc++.log.sep instead which contained everything I expected. ok for

Re: RFC reminder: an alternative -fsched-pressure implementation

2012-04-16 Thread Vladimir Makarov
On 04/10/2012 09:35 AM, Richard Sandiford wrote: Hi Vlad, Back in Decemember, when we were still very much in stage 3, I sent an RFC about an alternative implementation of -fsched-pressure. Just wanted to send a reminder now that we're in the proper stage:

[Patch,AVR]: Auto-generate all -mmcu= options in documentation.

2012-04-16 Thread Georg-Johann Lay
This patch adds a new file ./gcc/doc/avr-mmcu.texi that lists all valid -mmcu= settings and replaces the respective text in invoke.texi by @include avr-mmcu.texi Up to now, there is no complete list of -mmcu= options, and a list is hard to maintain by hand because it contains more than 180

[PATCH] arm.md: Use the revsh and rev16 instructions for BSWAP:HI RTL in armv6 and up

2012-04-16 Thread Louis Kruger
This patch teaches the arm target about the rev16 and revsh instructions which can efficiently execute the recently added __builtin_bswap16() function (BSWAP:HI in RTL) These instructions are available in thumb and arm modes on armv6 architecture and up. Before this patch, short swaps16(short x)

Re: [PATCH] Fix PR52977

2012-04-16 Thread Mike Stump
On Apr 16, 2012, at 6:43 AM, Richard Guenther wrote: Well, the number one advantage of replacing PCH is that it would kill the current PCH implementation which is tied to our garbage collector... If compile speed isn't important to people, there is little reason to keep pch around. Once that

Re: [PATCH] Atom: Scheduler improvements for better imul placement

2012-04-16 Thread Igor Zamyatin
On Fri, Apr 13, 2012 at 4:20 PM, Andrey Belevantsev a...@ispras.ru wrote: On 13.04.2012 14:18, Igor Zamyatin wrote: On Thu, Apr 12, 2012 at 5:01 PM, Andrey Belevantseva...@ispras.ru  wrote: On 12.04.2012 16:38, Richard Guenther wrote: On Thu, Apr 12, 2012 at 2:36 PM, Igor

Re: Propagate profile counts after switch case expansion (issue5896043)

2012-04-16 Thread Easwaran Raman
Ping. On Mon, Apr 9, 2012 at 2:33 PM, Easwaran Raman era...@google.com wrote: On Sun, Mar 25, 2012 at 9:40 PM, Easwaran Raman era...@google.com wrote: On Sun, Mar 25, 2012 at 12:22 PM, Jan Hubicka hubi...@ucw.cz wrote: This patch propagates execution count of thee case labels of a switch-case

C++ PATCH for c++/38543 (specialization of variadic function template)

2012-04-16 Thread Jason Merrill
The old code that compares the number of parameter types doesn't work in the age of variadic templates. Instead, we should take the deduced template arguments, substitute them in, and see if the result is what we're looking for. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: [Fortran] Patch ping

2012-04-16 Thread Tobias Burnus
Thomas Koenig wrote: - [patch, fortran] Trim spaces on list-directed reads http://gcc.gnu.org/ml/fortran/2012-04/msg00040.html That one was committed: http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00417.html Jerry indicated that this would also be OK for a backport; I'll do that within a few

[patch] Remove strange case cost code

2012-04-16 Thread Steven Bosscher
Hello, There is code in stmt.c since the initial checkin, that tries to balance a switch tree according to some ascii heuristics. I see a couple of problems with this code: 1. It doesn't seem to help much. With the attached patch to remove the code, I see no compile time changes to e.g. compile

Go patch committed: Avoid infinite recursion in string constant eval

2012-04-16 Thread Ian Lance Taylor
This patch from Rémy Oudompheng avoids an infinite recursion in the Go frontend when evaluating a string constant. It avoids a compiler crash on invalid code like const f, g = g, f func S() []byte { return []byte(f) } Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu.

[C++ Patch] PR 53003

2012-04-16 Thread Paolo Carlini
Hi, I had a look to this Segmentation fault in cp_parser_member_declaration and what happens is that initializer_token_start is still null (as initialized) when we get to: if (initializer) error_at (initializer_token_start-location, pure-specifier on

C++ PATCH for c++/52008 (ICE with variadic partial specialization)

2012-04-16 Thread Jason Merrill
In this testcase, the partial specialization has fewer template arguments than the primary template has parameters, which was confusing GCC. Let's give an error for this case because the partial specialization isn't more specialized than the primary template. Tested x86_64-pc-linux-gnu,

C++ PATCH for c++/50830 (another variadic template template parameter issue)

2012-04-16 Thread Jason Merrill
Here, we were getting confused and thinking that an argument pack of template template arguments wasn't suitable for a template template parameter pack. But it is. Tested x86_64-pc-linux-gnu, applying to trunk. commit 6143aa83bb48ef7c9d2bbcb0dff13a964036b3d1 Author: Jason Merrill

C++ PATCH for c++/50303 (failure using template template parameter pack in a pack expansion)

2012-04-16 Thread Jason Merrill
When substituting into a template template parameter pack pattern with a set of template arguments, we want to use tsubst_expr so that we get the substituted result; tsubst tries and fails to build up a new template template parameter. Tested x86_64-pc-linux-gnu, applying to trunk. commit