Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-25 Thread Maxim Kuvyrkov
On 18/04/2012, at 9:17 PM, Richard Guenther wrote: On Wed, Apr 18, 2012 at 4:15 AM, Maxim Kuvyrkov ma...@codesourcery.com wrote: Steven, Jorn, I am looking into fixing performance regression on EEMBC's bitmnp01, and a version of your combined patch attached to PR38785 still works very

Re: [Patch, Fortran] PR52864 - fix actual/formal checks

2012-04-25 Thread Tobias Burnus
Hello Mikael, thanks for the review. Regarding: Mikael Morin wrote: is there a reason to guard the class_pointer condition with attr.class_ok in the first conditional and with CLASS_DATA(...) != NULL in the two other ones? Not that it matters much, and in fact, I think the patch as is is

Re: FW: [v3] libstdc++/52689 testcase

2012-04-25 Thread Igor Zamyatin
This testcase is reported as failed on x86 Noticed that this testcase wasn't put in as part of the patch. Fixed as follows. tested x86/linux -benjamin

combine_conversions int-double-int

2012-04-25 Thread Marc Glisse
Hello, a conversion like int-double-int is just the identity, as long as double is big enough to represent all ints exactly. The most natural way I found to do this optimization is the attached: 2012-04-25 Marc Glisse marc.gli...@inria.fr PR middle-end/27139 *

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Andi Kleen
Tree level unrollers (cunrolli and cunroll) do complete unroll. At O2, both of them are turned on, but gcc does not allow any code growth -- which makes them pretty useless at O2 (very few loops qualify). The default max complete peel iteration is also too low compared with both icc and llvm.

Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Richard Guenther
On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote: It seems an obvious cleanup to me. OK? 2012-04-24 Manuel López-Ibáñez m...@gcc.gnu.org gcc/ * tree-pretty-print.h (default_tree_printer): Do not declare. * tree-diagnostic.c: Include tree-pretty-print.h, tree-pass.h and

[PATCH] Validate the HLE memory models.

2012-04-25 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com This is on top of Kirill's latest patch. Based on the earlier discussion. Warn and enforce reasonable memory models for HLE ACQUIRE and RELEASE. It's not useful to have a weaker compiler memory model than what the CPU implements for a transaction. With

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

2012-04-25 Thread Richard Guenther
On Tue, 24 Apr 2012, Ulrich Weigand wrote: Hello, PR 52633 is caused by bad interaction between two different vectorizer pattern recognition passed. A minimal test case is: void test (unsigned short *x, signed char *y) { int i; for (i = 0; i 32; i++) x[i] = (short) (y[i]

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

2012-04-25 Thread Jakub Jelinek
On Wed, Apr 25, 2012 at 10:29:36AM +0200, Richard Guenther wrote: Does this look reasonable? Any comments or suggestions appreciated! Yes, getting rid of this fragile interaction by doing more work in vect_recog_widen_shift_pattern sounds like the correct thing to do. Or give up when

[PATCH, tree-optimization] Fix for PR 52868

2012-04-25 Thread Igor Zamyatin
Hi all! I'd like to post for review the patch which makes some costs adjusting in get_computation_cost_at routine in ivopts part. As mentioned in the PR changes also fix the bwaves regression from PR 52272. Also changes introduce no degradations on spec2000/2006 and EEMBC1.1/2.0(this was measured

Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Manuel López-Ibáñez
On 25 April 2012 10:27, Richard Guenther rguent...@suse.de wrote: On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote: It seems an obvious cleanup to me. OK? 2012-04-24  Manuel López-Ibáñez  m...@gcc.gnu.org gcc/       * tree-pretty-print.h (default_tree_printer): Do not declare.       *

Re: combine_conversions int-double-int

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 10:12 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, a conversion like int-double-int is just the identity, as long as double is big enough to represent all ints exactly. The most natural way I found to do this optimization is the attached: 2012-04-25  Marc

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Richard Guenther
On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson tejohn...@google.com wrote: This patch adds heuristics to limit unrolling in loops with branches that may increase branch mispredictions. It affects loops that are not frequently iterated, and that are nested within a hot region of code that

Re: [PATCH 04/11] Fix expansion point loc for macro-like tokens

2012-04-25 Thread Dodji Seketeli
Jason Merrill ja...@redhat.com writes: On 04/10/2012 03:42 PM, Dodji Seketeli wrote: In that case, besides returning NULL, enter_macro_context sets pfile-context-c.macro to NULL, making cpp_get_token_1 forget to set the location of the vari to the expansion point of A. This seems like a bug

Re: [PATCH, tree-optimization] Fix for PR 52868

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 10:56 AM, Igor Zamyatin izamya...@gmail.com wrote: Hi all! I'd like to post for review the patch which makes some costs adjusting in get_computation_cost_at routine in ivopts part. As mentioned in the PR changes also fix the bwaves regression from PR 52272. Also

Re: [PATCH] Fix VRP ICE on x cst1; if (x cmp cst2) (PR tree-optimization/53058, take 2)

2012-04-25 Thread Jakub Jelinek
On Tue, Apr 24, 2012 at 10:33:58AM +0200, Richard Guenther wrote: So like this instead? Yes! Unfortunately that didn't bootstrap, apparently double-int.h is included in gen* which aren't linked with double-int.o, and the inlines stay at -O0 or with -fkeep-inline-functions. Even guarding

Re: combine_conversions int-double-int

2012-04-25 Thread Marc Glisse
First, thanks a lot for answering. On Wed, 25 Apr 2012, Richard Guenther wrote: On Wed, Apr 25, 2012 at 10:12 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, a conversion like int-double-int is just the identity, as long as double is big enough to represent all ints exactly. The most

Re: [PATCH 05/11] Make expand_location resolve to locus in main source file

2012-04-25 Thread Dodji Seketeli
On 04/10/2012 03:49 PM, Dodji Seketeli wrote: Apparently, quite some places in the compiler (like the C/C++ preprocessor, the debug info machinery) expect expand_location to resolve to locations that are in the main source file, even if the token at stake comes from a macro that was defined

Re: [C++ Patch] PR 39970

2012-04-25 Thread Paolo Carlini
On 04/25/2012 01:41 AM, Jason Merrill wrote: On 04/24/2012 05:24 PM, Paolo Carlini wrote: Perhaps we aren't checking default arguments unless they're actually used; a could change that if they aren't dependent. Your reply reached the mailing list a bit mangled, could you please clarify? If

Re: [PATCH] Fix for PR51879 - Missed tail merging with non-const/pure calls

2012-04-25 Thread Richard Guenther
On Tue, Apr 24, 2012 at 11:19 PM, Tom de Vries tom_devr...@mentor.com wrote: On 17/04/12 14:24, Richard Guenther wrote: On Sat, Apr 14, 2012 at 9:26 AM, Tom de Vries tom_devr...@mentor.com wrote: On 27/01/12 21:37, Tom de Vries wrote: On 24/01/12 11:40, Richard Guenther wrote: On Mon, Jan 23,

Re: [PATCH] Fix VRP ICE on x cst1; if (x cmp cst2) (PR tree-optimization/53058, take 2)

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 11:21 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Apr 24, 2012 at 10:33:58AM +0200, Richard Guenther wrote: So like this instead? Yes! Unfortunately that didn't bootstrap, apparently double-int.h is included in gen* which aren't linked with double-int.o, and

Re: move default_tree_printer out of toplev.c

2012-04-25 Thread Richard Guenther
On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: On 25 April 2012 10:27, Richard Guenther rguent...@suse.de wrote: On Tue, 24 Apr 2012, Manuel López-Ibáñez wrote: It seems an obvious cleanup to me. OK? 2012-04-24  Manuel López-Ibáñez  m...@gcc.gnu.org gcc/       *

Re: [PATCH] Fix for PR51879 - Missed tail merging with non-const/pure calls

2012-04-25 Thread Jakub Jelinek
On Wed, Apr 25, 2012 at 11:57:09AM +0200, Richard Guenther wrote: void *foo () { return __builtin_return_address (0); } void *bar (_Bool b) { if (b) return foo (); else return foo (); } int main() { if (bar(true) == bar(false)) abort (); } ok ... outside

Re: [PATCH] Fix for PR51879 - Missed tail merging with non-const/pure calls

2012-04-25 Thread Tom de Vries
On 25/04/12 12:09, Jakub Jelinek wrote: On Wed, Apr 25, 2012 at 11:57:09AM +0200, Richard Guenther wrote: void *foo () { return __builtin_return_address (0); } void *bar (_Bool b) { if (b) return foo (); else return foo (); } int main() { if (bar(true) ==

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Manuel López-Ibáñez
On 25 April 2012 00:01, Joseph S. Myers jos...@codesourcery.com wrote: On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: Wshadow warns whenever any declaration shadows a global function declaration. This is almost always noise, since most (always?) of the time one cannot mistakenly replace a

Re: Continue strict-volatile-bitfields fixes

2012-04-25 Thread Thomas Schwinge
Hi! On Thu, 19 Apr 2012 19:46:17 +0200, I wrote: Here is my current test case, reduced from gcc.dg/tree-ssa/20030922-1.c: extern void abort (void); enum tree_code { BIND_EXPR, }; struct tree_common { enum tree_code code:8; }; void

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
This caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53088 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53089 The first one seems just moved warning because of different gimplification order. Fixed thus. Note that the warning comes out at weird place with input_location, but that

[PING][Patch, Testsuite] fix failure in test gcc.dg/pr52283.c

2012-04-25 Thread Greta Yorsh
PING! Here is the original post: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01235.html This patch fixes the failure in gcc.dg/pr52283.c by adding the missing dg-warning and dg-options. OK for trunk? Thanks, Greta gcc/testsuite/ChangeLog 2012-04-20 Greta Yorsh greta.yo...@arm.com

Re: RFC reminder: an alternative -fsched-pressure implementation

2012-04-25 Thread Ulrich Weigand
Richard Sandiford wrote: Vladimir Makarov vmaka...@redhat.com writes: Taking your results for S390 and ARM with Neon into account, I guess it should be included and probably made by default for these 2 targets (for sure for s390). OK, thanks to both of you. Ulrich and Andreas: would

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

2012-04-25 Thread Ulrich Weigand
Jakub Jelinek wrote: On Wed, Apr 25, 2012 at 10:29:36AM +0200, Richard Guenther wrote: Does this look reasonable? Any comments or suggestions appreciated! Yes, getting rid of this fragile interaction by doing more work in vect_recog_widen_shift_pattern sounds like the correct thing to

Re: [PR tree-optimization/52558]: RFC: questions on store data race

2012-04-25 Thread Richard Guenther
On Tue, Apr 24, 2012 at 7:43 PM, Aldy Hernandez al...@redhat.com wrote: On 04/13/12 03:46, Richard Guenther wrote: On Fri, Apr 13, 2012 at 12:11 AM, Aldy Hernandezal...@redhat.com  wrote: Richard.  Thanks so much for reviewing and providing an alternative approach, which AFAICT provides

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

2012-04-25 Thread Ulrich Weigand
Richard Guenther wrote: On Tue, 24 Apr 2012, Ulrich Weigand wrote: Does this look reasonable? Any comments or suggestions appreciated! Yes, getting rid of this fragile interaction by doing more work in vect_recog_widen_shift_pattern sounds like the correct thing to do. OK, I'll try to

[PATCH] Fix bitfield expansion (PR middle-end/52979)

2012-04-25 Thread Jakub Jelinek
Hi! This patch fixes the attached execute/ testcases. In some cases get_best_mode was ignoring bitregion_* restrictions and returned mode that overlapped into adjacent non-bitfields, or store_bit_field_1 for insv could ignore those restrictions completely. After fixing that I've run into several

[Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Greta Yorsh
The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon enabled: FAIL: gcc.dg/vect/slp-perm-8.c scan-tree-dump-times vect vectorized 1 loops 2 The test expects 2 loops to be vectorized, while gcc successfully vectorizes 3 loops in this test using neon on arm. This patch adjusts the

Re: Continue strict-volatile-bitfields fixes

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 1:27 PM, Thomas Schwinge tho...@codesourcery.com wrote: Hi! On Thu, 19 Apr 2012 19:46:17 +0200, I wrote: Here is my current test case, reduced from gcc.dg/tree-ssa/20030922-1.c:     extern void abort (void);     enum tree_code     {       BIND_EXPR,     };    

Re: [PING][Patch, Testsuite] fix failure in test gcc.dg/pr52283.c

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 1:40 PM, Greta Yorsh greta.yo...@arm.com wrote: PING! Here is the original post: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01235.html This patch fixes the failure in gcc.dg/pr52283.c by adding the missing dg-warning and dg-options. OK for trunk? Didn't I approve

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Joseph S. Myers
On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: On 25 April 2012 00:01, Joseph S. Myers jos...@codesourcery.com wrote: On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: Wshadow warns whenever any declaration shadows a global function declaration. This is almost always noise, since most

Re: [PATCH] Fix bitfield expansion (PR middle-end/52979)

2012-04-25 Thread Richard Guenther
On Wed, 25 Apr 2012, Jakub Jelinek wrote: Hi! This patch fixes the attached execute/ testcases. In some cases get_best_mode was ignoring bitregion_* restrictions and returned mode that overlapped into adjacent non-bitfields, or store_bit_field_1 for insv could ignore those restrictions

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh greta.yo...@arm.com wrote: The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon enabled: FAIL: gcc.dg/vect/slp-perm-8.c scan-tree-dump-times vect vectorized 1 loops 2 The test expects 2 loops to be vectorized, while gcc successfully

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 5:36 AM, Manuel López-Ibáñez lopeziba...@gmail.com wrote: On 25 April 2012 00:01, Joseph S. Myers jos...@codesourcery.com wrote: On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: Wshadow warns whenever any declaration shadows a global function declaration. This is almost

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 6:54 AM, Joseph S. Myers jos...@codesourcery.com wrote: On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: On 25 April 2012 00:01, Joseph S. Myers jos...@codesourcery.com wrote: On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: Wshadow warns whenever any declaration

Re: PowerPC prologue and epilogue 6

2012-04-25 Thread David Edelsohn
On Wed, Apr 25, 2012 at 1:20 AM, Alan Modra amo...@gmail.com wrote: This patch adds a testcase to verify register saves and restores. I tried to write it so that it will run on all powerpc targets.  From past experience it probably won't.  OK to apply anyway, and fix fallout later?        *

Re: [PATCH] reload: Try alternative with swapped operands before going to the next

2012-04-25 Thread Ulrich Weigand
Andreas Krebbel wrote: 2011-11-17 Andreas Krebbel andreas.kreb...@de.ibm.com * reload.c (find_reloads): Change the loop nesting when trying an alternative with swapped operands. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and

[PATCH] Fix testsuite fallout of last patch

2012-04-25 Thread Richard Guenther
Committed, tested on x86_64-unknown-linux-gnu. Richard. 2012-04-25 Richard Guenther rguent...@suse.de * gcc.target/i386/l_fma_float_5.c: Adjust. * gcc.target/i386/l_fma_double_4.c: Likewise. * gcc.target/i386/l_fma_float_2.c: Likewise. *

fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-04-25 Thread Olivier Hainque
Hello, For the PA(1).Z := 44; assignment in the attached Ada testcase, we observe the gcc 4.5 SRA pass performing an invalid transformation, turning: struct { system__pack_48__bits_48 OBJ; } D.1432; D.1432.OBJ = D.1435; T1b.F = VIEW_CONVERT_EXPRstruct pt__point(D.1432); into:

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

2012-04-25 Thread Dodji Seketeli
Gabriel Dos Reis g...@integrable-solutions.net writes: On Wed, Apr 11, 2012 at 3:46 AM, Dodji Seketeli do...@redhat.com wrote: There are various conversion related warnings that trigger on potentially dangerous uses of NULL (or __null).  NULL is defined as a macro in a system header, so

Re: [PING][Patch, Testsuite] fix failure in test gcc.dg/pr52283.c

2012-04-25 Thread Mike Stump
On Apr 25, 2012, at 4:52 AM, Richard Guenther wrote: On Wed, Apr 25, 2012 at 1:40 PM, Greta Yorsh greta.yo...@arm.com wrote: PING! Here is the original post: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01235.html This patch fixes the failure in gcc.dg/pr52283.c by adding the missing

[PATCH] Default to -gdwarf-4

2012-04-25 Thread Jakub Jelinek
Hi! For reasonable debugging experience recent GCC versions need GDB = 7.0 for quite some time, and DWARF4 is almost 2 years old now, and offers lots of improvements over DWARF2 we still default to. So, I'd like to make -gdwarf-4 (just the version, of course -g is needed to enable debug info

Re: [PATCH] Make sizetypes no longer sign-extending

2012-04-25 Thread Richard Guenther
On Tue, 24 Apr 2012, Richard Guenther wrote: On Tue, 24 Apr 2012, Richard Guenther wrote: I've been carrying this patch for quite some while now and really want to go forward with it - the problem is that while all default languages work fine after this patch Ada shows some testsuite

Re: [PATCH, PR38785] Throttle PRE at -O3

2012-04-25 Thread Gerald Pfeifer
On Wed, 25 Apr 2012, Maxim Kuvyrkov wrote: OK. Gerald, does the patch for gcc-4.8/changes.html look OK? Yes, it does, thank you. Just add a and the in three places, as in A new option, the...optimization and at the...level when committing it, please. Cheers, Gerald

[PATCH 10/13] Fix location for static class members

2012-04-25 Thread Dodji Seketeli
Consider the test case g++.dg/other/offsetof5.C: #include stddef.h struct A { char c; int i; }; int j = offsetof (A, i);// { dg-warning invalid access|offsetof } template typename T struct S { T h; T i; static const int

Re: combine_conversions int-double-int

2012-04-25 Thread Marc Glisse
On Wed, 25 Apr 2012, Richard Guenther wrote: On Wed, Apr 25, 2012 at 10:12 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, a conversion like int-double-int is just the identity, as long as double is big enough to represent all ints exactly. The most natural way I found to do this

PATCH: PR debug/52857: DW_OP_GNU_regval_type is generated with INVALID_REGNUM

2012-04-25 Thread H.J. Lu
Hi, We may generate DW_OP_GNU_regval_type with INVALID_REGNUM. This patch adds an assert to make sure that we don't. OK for trunk? Thanks. H.J. --- 2012-04-06 H.J. Lu hongjiu...@intel.com PR debug/52857 * dwarf2out.c (dbx_reg_number): Assert return value !=

[PATCH 11/13] Fix va_start related location

2012-04-25 Thread Dodji Seketeli
In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being emitted because the relevant location was inside the var_start macro defined in a system header. It can even point to a token for a builtin macro there. This patch unwinds to the first token in real source code in that case.

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 8:42 AM, Dodji Seketeli do...@redhat.com wrote: Gabriel Dos Reis g...@integrable-solutions.net writes: On Wed, Apr 11, 2012 at 3:46 AM, Dodji Seketeli do...@redhat.com wrote: There are various conversion related warnings that trigger on potentially dangerous uses of

Re: [PATCH 11/13] Fix va_start related location

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli do...@redhat.com wrote: In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being emitted because the relevant location was inside the var_start macro defined in a system header.  It can even point to a token for a builtin macro there.  

Re: [PATCH 10/13] Fix location for static class members

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 8:55 AM, Dodji Seketeli do...@redhat.com wrote: Consider the test case g++.dg/other/offsetof5.C:    #include stddef.h    struct A    {      char c;      int i;    };    int j = offsetof (A, i);            // { dg-warning invalid access|offsetof }    template

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 3:37 PM, Olivier Hainque hain...@adacore.com wrote: Hello, For the  PA(1).Z := 44; assignment in the attached Ada testcase, we observe the gcc 4.5 SRA pass performing an invalid transformation, turning:  struct {    system__pack_48__bits_48 OBJ;  } D.1432;  

[PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Dodji Seketeli
Even after all the patches I have already submitted for this -ftrack-macro-expansion business, some test cases where errors happens on tokens that are defined in macros see their output change in an incompatible way, when you run them with or without -ftrack-macro-expansion. I think this is

[C++ Patch] PR 53096

2012-04-25 Thread Paolo Carlini
Hi, this PR is about the resolution of core/1333 being unimplemented, thus we reject things like: struct foo { foo(foo) = default; // ERROR HERE }; (and this can be annoying, as explained by Eric on the reflector, for example when one has to resort to out-of-class

RE: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Greta Yorsh
Richard Guenther wrote: On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh greta.yo...@arm.com wrote: Richard Guenther wrote: On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh greta.yo...@arm.com wrote: The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon enabled: FAIL:

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 4:27 PM, Greta Yorsh greta.yo...@arm.com wrote: Richard Guenther wrote: On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh greta.yo...@arm.com wrote: Richard Guenther wrote: On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh greta.yo...@arm.com wrote: The test

Re: [PATCH, tree-optimization] Fix for PR 52868

2012-04-25 Thread Igor Zamyatin
On Wed, Apr 25, 2012 at 1:14 PM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Apr 25, 2012 at 10:56 AM, Igor Zamyatin izamya...@gmail.com wrote: Hi all! I'd like to post for review the patch which makes some costs adjusting in get_computation_cost_at routine in ivopts part. As

[PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

2012-04-25 Thread Dodji Seketeli
Hopefully closing the series, this patch switches the compiler to -ftrack-macro-expansion=2 by default. Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. libcpp/ * init.c (cpp_create_reader): Switch -ftrack-macro-expansion=2 on by default. Add comments.

Re: [PATCH, tree-optimization] Fix for PR 52868

2012-04-25 Thread Richard Guenther
On Wed, Apr 25, 2012 at 4:32 PM, Igor Zamyatin izamya...@gmail.com wrote: On Wed, Apr 25, 2012 at 1:14 PM, Richard Guenther richard.guent...@gmail.com wrote: On Wed, Apr 25, 2012 at 10:56 AM, Igor Zamyatin izamya...@gmail.com wrote: Hi all! I'd like to post for review the patch which makes

Re: [C] improve missing initializers diagnostics

2012-04-25 Thread H.J. Lu
On Sat, Apr 21, 2012 at 4:58 AM, Manuel López-Ibáñez lopeziba...@gmail.com wrote: This patch improves missing initializers diagnostics. From: pr36446.c:13:3: warning: missing initializer [-Wmissing-field-initializers]   .h = {1},   ^ pr36446.c:13:3: warning: (near initialization for

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

2012-04-25 Thread Dodji Seketeli
Gabriel Dos Reis g...@integrable-solutions.net writes: Thanks. But a point of the suggestion was that we won't need the same comment/explanation duplicated over at least 3 places. Just one. All those three places deal exactly with one instance: null pointer constant. That deserves a

RE: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Greta Yorsh
-Original Message- From: Richard Guenther [mailto:richard.guent...@gmail.com] Sent: 25 April 2012 15:32 To: Greta Yorsh Cc: gcc-patches@gcc.gnu.org; mikest...@comcast.net; r...@cebitec.uni- bielefeld.de; Richard Earnshaw Subject: Re: [Patch, testsuite] fix failure in test

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
Hi, the fortran problem is caused by fact that fortran does nested funtions that are static constructors. I did not really think of that case in cgraph construction code. Fixed thus. Honza PR middle-end/53089 * cgraphunit.c (cgraph_process_new_functions): Do not enqueue new

[Ada] Atomic protected types

2012-04-25 Thread Arnaud Charlet
This patch cleans up the implementation of atomic protected types. No changes in behavior. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-04-25 Hristian Kirtchev kirtc...@adacore.com * exp_ch9.adb: Rename Lock_Free_Sub_Type to Lock_Free_Subprogram. Remove type

Re: [PATCH 11/13] Fix va_start related location

2012-04-25 Thread Dodji Seketeli
Gabriel Dos Reis g...@integrable-solutions.net writes: On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli do...@redhat.com wrote: In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being emitted because the relevant location was inside the var_start macro defined in a system header.  

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

2012-04-25 Thread Gabriel Dos Reis
OK, thanks! -- Gaby

Re: [PATCH 11/13] Fix va_start related location

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 10:20 AM, Dodji Seketeli do...@redhat.com wrote: Gabriel Dos Reis g...@integrable-solutions.net writes: On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli do...@redhat.com wrote: In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being emitted because the

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 9:16 AM, Dodji Seketeli do...@redhat.com wrote: Even after all the patches I have already submitted for this -ftrack-macro-expansion business, some test cases where errors happens on tokens that are defined in macros see their output change in an incompatible way, when

Re: [PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

2012-04-25 Thread Gabriel Dos Reis
On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli do...@redhat.com wrote: Hopefully closing the series, this patch switches the compiler to -ftrack-macro-expansion=2 by default. Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. Makes sense to me; Tom? -- Gaby

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Tue, Apr 24, 2012 at 4:38 PM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson tejohn...@google.com wrote:        * params.def (PARAM_MIN_ITER_UNROLL_WITH_BRANCHES): New param.        (PARAM_UNROLL_OUTER_LOOP_BRANCH_BUDGET): Ditto. You should

Re: [PATCH 05/11] Make expand_location resolve to locus in main source file

2012-04-25 Thread Dodji Seketeli
I have re-based my tree on top of a recent tree that incorporates the changes for caret diagnostics and I had to update this patch accordingly. Here is its new version on trunk of today. It basically updates the new diagnostic_show_locus function to point to spelling locations. The patch does

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Tue, Apr 24, 2012 at 6:13 PM, Andi Kleen a...@firstfloor.org wrote: tejohn...@google.com (Teresa Johnson) writes: This patch adds heuristics to limit unrolling in loops with branches that may increase branch mispredictions. It affects loops that are not frequently iterated, and that are

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Teresa Johnson
On Wed, Apr 25, 2012 at 2:03 AM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson tejohn...@google.com wrote: This patch adds heuristics to limit unrolling in loops with branches that may increase branch mispredictions. It affects loops that

Re: [RFA] Update config.sub to 2012-04-18 version.

2012-04-25 Thread Joel Brobecker
ChangeLog: * config.sub: Update to 2012-04-18 version from official repo. Thanks to everyone who answered. This patch is no in, both GCC src. -- Joel

Re: [PATCH] Default to -gdwarf-4

2012-04-25 Thread Richard Henderson
On 04/25/12 06:47, Jakub Jelinek wrote: 2012-04-25 Jakub Jelinek ja...@redhat.com * common.opt (flag_debug_types_section): Default to 0. (dwarf_version): Default to 4. (dwarf_record_gcc_switches): Default to 1. (dwarf_strict): Default to 0. * toplev.c

Re: [C] improve missing initializers diagnostics

2012-04-25 Thread Manuel López-Ibáñez
On 25 April 2012 16:46, H.J. Lu hjl.to...@gmail.com wrote: On Sat, Apr 21, 2012 at 4:58 AM, Manuel López-Ibáñez lopeziba...@gmail.com wrote: This patch improves missing initializers diagnostics. From: pr36446.c:13:3: warning: missing initializer [-Wmissing-field-initializers]   .h = {1},  

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

2012-04-25 Thread Xinliang David Li
I think the general mechanism applies to most of the targets. What is needed is target specific parameter (branch budget) tuning which can be done separately -- there exist a way to do that already. David On Wed, Apr 25, 2012 at 2:03 AM, Richard Guenther richard.guent...@gmail.com wrote: On

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

2012-04-25 Thread Richard Earnshaw
On 25/04/12 15:31, Richard Guenther wrote: On Wed, Apr 25, 2012 at 4:27 PM, Greta Yorsh greta.yo...@arm.com wrote: Richard Guenther wrote: On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh greta.yo...@arm.com wrote: Richard Guenther wrote: On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh

Re: various minor obvious fixes in th track-macro-expansion code

2012-04-25 Thread Dodji Seketeli
Manuel López-Ibáñez lopeziba...@gmail.com writes: Hi Dodji, Hello Manuel, Sorry for my late reply, I was on the road. I was going to commit this as obvious, but I want to make sure that it doesn't conflict with your new track-macro-expansion patches. It can also wait until you commit all

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Steven Bosscher
On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka hubi...@ucw.cz wrote: + /* Return true when there are references to NODE.  */ + + static bool + referred_to_p (symtab_node node) + { +   int i; +   struct ipa_ref *ref; + +   for (i = 0; ipa_ref_list_referring_iterate (node-symbol.ref_list, i,

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka hubi...@ucw.cz wrote: + /* Return true when there are references to NODE.  */ + + static bool + referred_to_p (symtab_node node) + { +   int i; +   struct ipa_ref *ref; + +   for (i = 0; ipa_ref_list_referring_iterate

Re: Symbol table 14/many: cleanups of cgraphunit.c

2012-04-25 Thread Steven Bosscher
Hello, Thanks for this work! Below are a bunch of spelling fixes ;-) On Wed, Apr 25, 2012 at 6:32 PM, Jan Hubicka hubi...@ucw.cz wrote: --- 19,28  along with GCC; see the file COPYING3.  If not see  http://www.gnu.org/licenses/.  */ ! /* This module implements main driver of

Re: [PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

2012-04-25 Thread Tom Tromey
Gaby == Gabriel Dos Reis g...@integrable-solutions.net writes: Gaby On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli do...@redhat.com wrote: Hopefully closing the series, this patch switches the compiler to -ftrack-macro-expansion=2 by default. Tested and bootstrapped on

Re: FW: [v3] libstdc++/52689 testcase

2012-04-25 Thread Jonathan Wakely
On 25 April 2012 08:33, Igor Zamyatin wrote: This testcase is reported as failed on x86 Yep. http://gcc.gnu.org/ml/gcc-testresults/2012-04/msg02547.html Benjamin? Noticed that this testcase wasn't put in as part of the patch. Fixed as follows. tested x86/linux -benjamin

[v3] fix scoped_allocator problems

2012-04-25 Thread Jonathan Wakely
* include/std/scoped_allocator (scoped_allocator::__outermost): Do not pass non-POD to varargs function. * testsuite/20_util/scoped_allocator/1.cc: Fix test. This fixes a potential problem in scoped_allocator and fixes a broken test (and ensures it actually runs!) Tested

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Jan Hubicka
On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka hubi...@ucw.cz wrote: + /* Return true when there are references to NODE.  */ + + static bool + referred_to_p (symtab_node node) + { +   int i; +   struct ipa_ref *ref; + +   for (i = 0; ipa_ref_list_referring_iterate

Re: Symbol table 14/many: cleanups of cgraphunit.c

2012-04-25 Thread Jan Hubicka
Hello, Thanks for this work! Below are a bunch of spelling fixes ;-) Thanks!        The function can be called multiple times when multiple source level !       compilation units are combined. Is this still applicable? I thought -combine was removed. Or is this for things like

Re: PATCH: PR debug/52857: DW_OP_GNU_regval_type is generated with INVALID_REGNUM

2012-04-25 Thread Richard Henderson
On 04/25/12 06:59, H.J. Lu wrote: PR debug/52857 * dwarf2out.c (dbx_reg_number): Assert return value != INVALID_REGNUM. Ok. r~

Re: Symbol table 13/many: reachability code rewrite

2012-04-25 Thread Richard Henderson
On 04/25/12 11:46, Jan Hubicka wrote: On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka hubi...@ucw.cz wrote: + /* Return true when there are references to NODE. */ + + static bool + referred_to_p (symtab_node node) + { + int i; + struct ipa_ref *ref; + + for (i = 0;

[PATCH][Cilkplus] Elemental function insertion

2012-04-25 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilkplus branch affecting both C and C++ compilers. This patch will insert elemental functions when the loop is vectorized. Thanking You, Yours Sincerely, Balaji V. Iyer.diff --git a/gcc/cilk.h b/gcc/cilk.h index 27d5dd0..27ccd16 100644 ---

[PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

2012-04-25 Thread Jakub Jelinek
Hi! We have a splitter for reg1 = reg2 0x, but only if regnums are different. But movl %edi, %edi is a cheaper variant of andq $0x, %rdi even with the same register and doesn't clobber flags, so this patch attempts to expand it as a zero extension early. Bootstrapped/regtested

Re: [PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

2012-04-25 Thread Richard Henderson
On 04/25/12 12:14, Jakub Jelinek wrote: 2012-04-25 Jakub Jelinek ja...@redhat.com PR target/53110 * config/i386/i386.md (andmode3): For andq $0x, reg instead expand it as zero extension. Ok. r~

FW: [PATCH][Cilkplus] Elemental function insertion

2012-04-25 Thread Iyer, Balaji V
Sorry, I forgot to include Changelog entries. I am attaching the updated patch. Thanks, Balaji V. Iyer. From: Iyer, Balaji V Sent: Wednesday, April 25, 2012 3:08 PM To: gcc-patches@gcc.gnu.org Subject: [PATCH][Cilkplus] Elemental function insertion

Re: [PATCH] Validate the HLE memory models.

2012-04-25 Thread Richard Henderson
On 04/25/12 01:29, Andi Kleen wrote: gcc/: 2012-04-24 Andi Kleen a...@linux.intel.com * builtins.c (get_memmodel): Add val. Call target.memmodel_check and return new variable. * config/i386/i386.c (ix86_memmodel_check): Add. (TARGET_MEMMODEL_MASK): Replace with

  1   2   >