Re: [patch, committed] invoke.texi: clean up texinfo markup

2012-05-03 Thread Sandra Loosemore
On 05/02/2012 12:41 AM, Gerald Pfeifer wrote: Hi Sandra, On Fri, 6 Apr 2012, Sandra Loosemore wrote: This is another installment in my series of cleanups to invoke.texi. In this patch I have taken a break from nit-picking grammar and have nit-picked some Texinfo markup issues instead.

Re: [PATCH] [i386] fma3 instruction generation for 'march=native' in AMD processors

2012-05-03 Thread Gopalasubramanian, Ganesh
I have added the ChangeLog and modified the patch. Is it OK to commit to trunk? Regards Ganesh 2012-05-03 Ganesh Gopalasubramanian ganesh.gopalasubraman...@amd.com * config/i386/driver-i386.c (host_detect_local_cpu): Reset has_fma4 for AMD processors with both fma3 and fma4

Re: [PATCH] [i386] fma3 instruction generation for 'march=native' in AMD processors

2012-05-03 Thread Uros Bizjak
Hello! 2012-05-03 Ganesh Gopalasubramanian ganesh.gopalasubraman...@amd.com * config/i386/driver-i386.c (host_detect_local_cpu): Reset has_fma4 for AMD processors with both fma3 and fma4 support. OK. Thanks, Uros.

Re: [patch] For alpha-vms, unset flag_jump_tables if flag_pic is nonzero

2012-05-03 Thread Tristan Gingold
On May 2, 2012, at 11:45 PM, Richard Henderson wrote: On 05/02/2012 12:26 PM, Steven Bosscher wrote: * config/alpha/vms.h (SUBTARGET_OVERRIDE_OPTIONS): For pic code, unset flag_jump_tables. * stmt.c (expand_case): Remove special flag_pic case conditional on

Re: [patch] For alpha-vms, unset flag_jump_tables if flag_pic is nonzero

2012-05-03 Thread Tristan Gingold
On May 2, 2012, at 9:12 PM, Steven Bosscher wrote: Hello, alpha-vms is the only target that does not define ASM_OUTPUT_ADDR_DIFF_ELT. That makes the code in stmt.c to handle this case alpha-vms specific. But there is a better way to handle this: Just mimic -fno-jump-tables if flag_pic is

Re: [PATCH] Fix predcom VTA ICE (PR debug/53174)

2012-05-03 Thread Richard Guenther
On Wed, 2 May 2012, Jakub Jelinek wrote: Hi! single_nonlooparound_use ignores debug uses (otherwise we end up with -fcompare-debug failures), but when removing stmts we need to reset the debug uses, otherwise e.g. the testcase below ICEs. Alex, if you have better ideas how to reconstruct

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-05-03 Thread Olivier Hainque
On Apr 30, 2012, at 16:18 , Olivier Hainque wrote: Can you formally relate those three representations and tell me why VIEW_CONVERT_EXPR is useful (not only convenient because of less operands) to use on lvalues (thus memory, compared to registers or constants)? I have ideas on how they are

Re: [i386] access subvectors

2012-05-03 Thread Richard Guenther
On Wed, May 2, 2012 at 11:46 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, I definitely don't expect the attached patch to be accepted, but I would like some advice on the direction to go, and a patch that passes the testsuite and does the optimization I want on a couple testcases seems

[PATCH] Fix PR53144

2012-05-03 Thread Richard Guenther
This fixes PR53144 - we were assigning a constant value-id to a non-constant value. That breaks bitmap set invariants and thus we end up endlessly inserting things. Oops. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk and branch. Richard. 2012-05-03 Richard Guenther

[patch] Fix dominance info in switch conversion

2012-05-03 Thread Steven Bosscher
Hello, Throwing away dominance info is wasteful if it is so easy to fix. The immediate dominators are easily known, and iterate_fix_dominators() can take care of the rest. And if we're doing to free post-dominance info anyway, do it early to save some work. Bootstrappedtested on

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread Richard Sandiford
David Miller da...@davemloft.net writes: From: Richard Sandiford rdsandif...@googlemail.com Date: Wed, 02 May 2012 20:37:58 +0100 I think the DSE assuption is fair though. If you reuse MEMs like this, then they're no longer just serving the purpose described by MEM_EXPR. The following

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 10:31 AM, Richard Sandiford rdsandif...@googlemail.com wrote: David Miller da...@davemloft.net writes: From: Richard Sandiford rdsandif...@googlemail.com Date: Wed, 02 May 2012 20:37:58 +0100 I think the DSE assuption is fair though.  If you reuse MEMs like this, then

Re: [patch] Fix dominance info in switch conversion

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 10:29 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, Throwing away dominance info is wasteful if it is so easy to fix. The immediate dominators are easily known, and iterate_fix_dominators() can take care of the rest. And if we're doing to free post-dominance

[google/gcc-4_6_2-mobile] Port of Android target support in i386 for google/gcc-4_6_2-mobile branch

2012-05-03 Thread Ilya Enkovich
Hi, here is a port of Android support patch (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00944.html) for google/gcc-4_6_2-mobile branch. Is it OK? Bootstrapped on linux-x86_64. Successfullly used for NDK release build and Android ICS build. Thanks, Ilya --- 2012-05-03 Enkovich Ilya

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread Richard Sandiford
Richard Guenther richard.guent...@gmail.com writes: On Thu, May 3, 2012 at 10:31 AM, Richard Sandiford rdsandif...@googlemail.com wrote: David Miller da...@davemloft.net writes: From: Richard Sandiford rdsandif...@googlemail.com Date: Wed, 02 May 2012 20:37:58 +0100 I think the DSE

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread David Miller
From: Richard Guenther richard.guent...@gmail.com Date: Thu, 3 May 2012 10:42:30 +0200 On Thu, May 3, 2012 at 10:31 AM, Richard Sandiford rdsandif...@googlemail.com wrote: David Miller da...@davemloft.net writes: From: Richard Sandiford rdsandif...@googlemail.com Date: Wed, 02 May 2012

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread David Miller
From: Richard Sandiford rdsandif...@googlemail.com Date: Thu, 03 May 2012 10:17:44 +0100 Richard Guenther richard.guent...@gmail.com writes: On Thu, May 3, 2012 at 10:31 AM, Richard Sandiford rdsandif...@googlemail.com wrote: David Miller da...@davemloft.net writes: From: Richard Sandiford

[PATCH] Fix gfortran.dg/pr52621.f90 testcase

2012-05-03 Thread Richard Guenther
Committed as obvious. Richard. 2012-05-03 Richard Guenther rguent...@suse.de * gfortran.dg/pr52621.f90: Add -w to avoid diagnostic about unsupported prefetching support. Index: gcc/testsuite/gfortran.dg/pr52621.f90

[Patch, Fortran] PR53111 - fix -std=f95 diagnostic regression (constructor patch)

2012-05-03 Thread Tobias Burnus
Dear all, attached you find a patch for a -std=f95 diagnostic issue related to F2003 constructors, which is a 4.7/4.8 rejects-valid regression. It was build and regtested on x86-64-linux. OK for 4.7 and the trunk? Note that a valid-F95 special case is still rejected with -std=f95 (cf.

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 11:38 AM, David Miller da...@davemloft.net wrote: From: Richard Sandiford rdsandif...@googlemail.com Date: Thu, 03 May 2012 10:17:44 +0100 Richard Guenther richard.guent...@gmail.com writes: On Thu, May 3, 2012 at 10:31 AM, Richard Sandiford rdsandif...@googlemail.com

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread David Miller
From: Richard Guenther richard.guent...@gmail.com Date: Thu, 3 May 2012 11:48:03 +0200 calls.c is unsafe, too. Which is probably why making DSE stronger for calls using the usual alias predicates did not work. Well, when calls.c does something more sophisticated we can do similarly for cases

Re: [C11-atomic] [patch] gimple atomic statements

2012-05-03 Thread Richard Guenther
On Fri, Apr 27, 2012 at 2:31 PM, Andrew MacLeod amacl...@redhat.com wrote: On 04/27/2012 04:37 AM, Richard Guenther wrote: Since integral atomics are always of an unsigned type ,  I could switch over and use 'unsigned size' instead of 'tree fntype' for them (I will rename it), but then

[PATCH] Fix __ATOMIC_HLE* defines (PR target/53194)

2012-05-03 Thread Jakub Jelinek
Hi! On Wed, May 02, 2012 at 07:37:15PM +0400, Kirill Yukhin wrote: Otherwise, this looks good. Thanks, I've applied inputs! Comitted to MT: http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00047.html As I mentioned in http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00730.html this doesn't really

Re: [PATCH] Fix __ATOMIC_HLE* defines (PR target/53194)

2012-05-03 Thread Uros Bizjak
On Thu, May 3, 2012 at 12:05 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, May 02, 2012 at 07:37:15PM +0400, Kirill Yukhin wrote: Otherwise, this looks good. Thanks, I've applied inputs! Comitted to MT: http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00047.html As I mentioned in

[PATCH] Fix some hle* tests

2012-05-03 Thread Jakub Jelinek
Hi! During testing with older gas I've noticed failures, where 0xf2 was a pasto instead of the right 0xf3 for xrelease insn. Fixed thusly, regtested on x86_64-linux and i686-linux, ok for trunk? BTW, I wonder if dg-options shouldn't select -march=i686 for !lp64, if somebody configures gcc to

Re: [PATCH, reload] Fix bug pr52804, RELOAD pass reloads wrong register on ARM for cortex-m0

2012-05-03 Thread Ulrich Weigand
Bin Cheng wrote: Thanks for reviewing, I modified the ChangeLog. Is it ok for trunk and 4.7? Yes, this is OK for trunk. Once it has been in trunk for a week or so and nobody reported any regressions, it would also be OK to backport to 4.7. Thanks, Ulrich -- Dr. Ulrich Weigand GNU

improve collect2 to preserve a RO output as the linker does

2012-05-03 Thread Olivier Hainque
Hello, This is a followup on an old issue first discussed at http://gcc.gnu.org/ml/gcc-patches/2008-05/msg01290.html The original problem is still visible today: While some target linkers silently replace read-only output files, others report an error in such circumstances. [...]

Re: [PATCH] Fix some hle* tests

2012-05-03 Thread Uros Bizjak
On Thu, May 3, 2012 at 12:08 PM, Jakub Jelinek ja...@redhat.com wrote: During testing with older gas I've noticed failures, where 0xf2 was a pasto instead of the right 0xf3 for xrelease insn. Fixed thusly, regtested on x86_64-linux and i686-linux, ok for trunk? BTW, I wonder if dg-options

Re: fix ppc-aix build failures with spaces in CC (internal) variable

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00661.html Thanks in advance, Olivier On Apr 11, 2012, at 16:43 , Olivier Hainque wrote: We sometimes get to invoke Makefile targets with a CC variable value containing spaces (for extra options, typically). This causes failure

Re: [PATCH] Fix for PR51879 - Missed tail merging with non-const/pure calls

2012-05-03 Thread Richard Guenther
On Wed, May 2, 2012 at 4:06 PM, Tom de Vries tom_devr...@mentor.com wrote: On 27/04/12 11:01, Richard Guenther wrote: SNIP I see you do not handle SNIP struct S { int i; }; struct S foo (void); struct S bar (void) {   struct S s1, s2;   if (...)    s = foo ();   else    s = foo ();

Re: [PATCH] teach emit_store_flag to use clz/ctz

2012-05-03 Thread Paolo Bonzini
Il 03/05/2012 11:57, Richard Guenther ha scritto: Hmm, I'll let target maintainers have a look at this - it's non-obvious for arm (the only case I looked at) at least. My guess is that the difference was to allow __builtin_ctz to be optimized and CTZ to be always well-defined (which

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 11:52 AM, David Miller da...@davemloft.net wrote: From: Richard Guenther richard.guent...@gmail.com Date: Thu, 3 May 2012 11:48:03 +0200 calls.c is unsafe, too.  Which is probably why making DSE stronger for calls using the usual alias predicates did not work. Well,

RE: Propose to add a new argument MULTILIB_REQUIRED in multilib framework

2012-05-03 Thread Terry Guo
Hi Joseph, On Tue, 17 Apr 2012, Terry Guo wrote: 2012-04-17 Terry Guo terry@arm.com * Makefile.in (s-mlib): Add new argument MULTILIB_REQUIRED. * genmultilib (MULTILIB_REQUIRED): New. You need to add documentation in fragments.texi for MULTILIB_REQUIRED.

ping: latch mem to reg before multi-access in convert_move

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00298.html Thanks in advance, Olivier On Apr 5, 2012, at 17:30 , Olivier Hainque wrote: ... The original problem we had with this was the introduction of an artificial race condition in addition to the potential performance

[committed] Fix ARM ICE in arm_select_dominance_cc_mode (PR target/53187)

2012-05-03 Thread Jakub Jelinek
Hi! This patch fixes ICE in arm_select_dominance_cc_mode during combine, which tries to match some rtl expression which has (unlt:SI (reg:CCFPE cc) (const_int 0)) deep inside it (the match will fail), during simplification SELECT_CC_MODE is used and as arm_select_cc_mode returns CCmode for the

Re: divide 64-bit by constant for 32-bit target machines

2012-05-03 Thread Dinar Temirbulatov
Hi, Here is updated version of patch. I added comments describing the algorithm. Hi Dinar.  I'm afraid it gives the wrong results for some dividends  * 82625484914982912 / 2023346444509052928: gives 4096, should be zero  * 18317463604061229328 / 2023346444509052928: gives 4109, should be 9  *

ping: use longcall to abort from !pic trampoline setup on ppc-vxworks

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00808.html Thanks in advance, Olivier On Apr 13, 2012, at 10:08 , Olivier Hainque wrote: ... Relocation troubles (24bit reloc overflows) might show up when module instructions contain short references to kernel symbols and the

[PATCH] Fix gcc-{ar,nm,ranlib} (PR plugins/53126)

2012-05-03 Thread Jakub Jelinek
Hi! What gcc-ar does to find the plugin is significantly different from what gcc driver does. This patch makes it behave tiny bit closer to what the driver does, in particular if GCC_EXEC_PREFIX isn't defined in the environment, it will use standard_libexec_prefix if gcc-{ar,nm,ranlib} program

Re: [PATCH] Fix gcc-{ar,nm,ranlib} (PR plugins/53126)

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 12:49 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! What gcc-ar does to find the plugin is significantly different from what gcc driver does.  This patch makes it behave tiny bit closer to what the driver does, in particular if GCC_EXEC_PREFIX isn't defined in the

Re: [C++ Patch] PR 53186

2012-05-03 Thread Paolo Carlini
On 05/03/2012 03:27 AM, Paolo Carlini wrote: Hi, Vincenzo reported today that the work done by Roberto on devirtualizing final methods, doesn't cover operators (of all sorts). Thus I prepared the below, which passes the testsuite on x86_64-linux. ... I have an alternate proposal, which

RE: Propose to add a new argument MULTILIB_REQUIRED in multilib framework

2012-05-03 Thread Joseph S. Myers
On Thu, 3 May 2012, Terry Guo wrote: Thanks for your reminding. The attached patch added the missing documentation. Please help to review. Please send the complete new patch, including documentation, for review (unless the rest has been reviewed). +@item MULTILIB_REQUIRED +Sometimes when

[PATCH] PRE TLC

2012-05-03 Thread Richard Guenther
When looking at PR53168 I noticed that clean () can be optimized and simplified quite a bit. Likewise that we do not dump whether we find a partial or a partial partial redundancy, nor dump the insert iteration. Also dumping the PRE sets is tedious from inside gdb so this adds a debug function

[google] re-enable r185948

2012-05-03 Thread Dehao Chen
Hi, This patch was reverted because of performance degradation. However, it turns out to be an innocent performance loss. Thus we want to reenable it in google branches. Passed bootstrap and gcc regression tests and google performance tests. OK for google branch? Thanks, Dehao

Re: [PATCH] Fix some hle* tests

2012-05-03 Thread Uros Bizjak
On Thu, May 3, 2012 at 12:17 PM, Uros Bizjak ubiz...@gmail.com wrote: BTW, I wonder if dg-options shouldn't select -march=i686 for !lp64, if somebody configures gcc to default to -march=i386, I guess xadd etc. won't be emitted there. You can add -march=x86-64 unconditionally to these test.

ping: recognize .persistent.bss sections as bss

2012-05-03 Thread Olivier Hainque
Hello, Ping for http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00833.html Thanks in advance, Olivier On Apr 13, 2012, at 15:06 , Olivier Hainque wrote: For several years now, Ada has support for a Persistent_BSS pragma that let users place data in a .persistent.bss section. This section: -

[PATCH, alpha]: Remove MAX_OFILE_ALIGNMENT definition

2012-05-03 Thread Uros Bizjak
Hello! This #define is the same as in generic config/elfos.h. 2012-05-03 Uros Bizjak ubiz...@gmail.com * config/alpha/elf.h (MAX_OFILE_ALIGNMENT): Remove. Tested on alphaev68-pc-linux-gnu, committed to mainline SVN. Uros. Index: config/alpha/elf.h

RE: Propose to add a new argument MULTILIB_REQUIRED in multilib framework

2012-05-03 Thread Terry Guo
Hi Joseph, On Thu, 3 May 2012, Terry Guo wrote: Thanks for your reminding. The attached patch added the missing documentation. Please help to review. Please send the complete new patch, including documentation, for review (unless the rest has been reviewed). +@item

RE: Propose to add a new argument MULTILIB_REQUIRED in multilib framework

2012-05-03 Thread Joseph S. Myers
On Thu, 3 May 2012, Terry Guo wrote: 2012-05-03 Terry Guo terry@arm.com * Makefile.in (s-mlib): Add new argument MULTILIB_REQUIRED. * genmultilib (MULTILIB_REQUIRED): New. * doc/fragments.texi: Document the MULTILIB_REQUIRED. This is OK, with copyright dates

[PATCH] More PRE TLC

2012-05-03 Thread Richard Guenther
This moves handling of trapping ops to prune_clobbered_mems and compute_avail, similar to how I moved handling of clobbered mems earlier. It fixes one existing testcase even. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-05-03 Richard Guenther rguent...@suse.de

rfa: Tighten basic_block_def (inline il.gimple)

2012-05-03 Thread Michael Matz
Hi, this removes the XXXs I added with my prev/next shuffling. A reason for some conditionals in iterator setups is that ENTRY/EXIT bbs don't have il.gimple setup, while all other blocks have it always initialized (well, as long as !BB_RTL of course). That annoyed me, but instead of simply

Re: [C++ Patch] PR 53186

2012-05-03 Thread Jason Merrill
What if we moved all the devirtualization logic from build_new_method_call_1 to build_over_call? Jason

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

2012-05-03 Thread Olivier Hainque
On May 3, 2012, at 12:24 , Richard Guenther wrote: One area of potential difference came to mind yesterday: regarding the processing of type alignment differences. VCE to more aligned (of the same size) would make a temp copy to yield a correctly aligned object. Would MEM_REF do that as

Re: divide 64-bit by constant for 32-bit target machines

2012-05-03 Thread Richard Earnshaw
On 03/05/12 11:27, Dinar Temirbulatov wrote: Hi, Here is updated version of patch. I added comments describing the algorithm. Hi Dinar. I'm afraid it gives the wrong results for some dividends * 82625484914982912 / 2023346444509052928: gives 4096, should be zero * 18317463604061229328 /

Re: [C++ Patch] PR 53186

2012-05-03 Thread Paolo Carlini
On 05/03/2012 03:08 PM, Jason Merrill wrote: What if we moved all the devirtualization logic from build_new_method_call_1 to build_over_call? Doh, you are absolutely right, the below, very simple, appears to work well. Probably I was afraid that we could have issues with the other

Re: [C++ Patch] PR 53186

2012-05-03 Thread Jason Merrill
OK. Seems safe enough for 4.7.1. Jason

Re: [PATCH] libatomic, v2

2012-05-03 Thread Jason Merrill
On 05/02/2012 09:14 AM, Richard Henderson wrote: On 05/02/2012 05:48 AM, Andreas Krebbel wrote: configure.ac:26: error: Please use exactly Autoconf 2.64 instead of 2.65. ../config/override.m4:12: _GCC_AUTOCONF_VERSION_CHECK is expanded from... configure.ac:26: the top level autom4te: m4 failed

Re: rfa: Tighten basic_block_def (inline il.gimple)

2012-05-03 Thread Richard Guenther
On Thu, May 3, 2012 at 3:08 PM, Michael Matz m...@suse.de wrote: Hi, this removes the XXXs I added with my prev/next shuffling.  A reason for some conditionals in iterator setups is that ENTRY/EXIT bbs don't have il.gimple setup, while all other blocks have it always initialized (well, as

[PATCH] Hoist adjacent pointer loads

2012-05-03 Thread William J. Schmidt
This patch was posted for comment back in February during stage 4. It addresses a performance issue noted in the EEMBC routelookup benchmark on a common idiom: if (...) x = y-left; else x = y-right; If the two loads can be hoisted out of the if/else, the if/else can be replaced by a

Re: [C++ Patch] PR 53186

2012-05-03 Thread Paolo Carlini
On 05/03/2012 04:00 PM, Jason Merrill wrote: OK. Seems safe enough for 4.7.1. Applied, thanks! Paolo.

Re: fix ppc-aix build failures with spaces in CC (internal) variable

2012-05-03 Thread David Edelsohn
On Thu, May 3, 2012 at 6:19 AM, Olivier Hainque hain...@adacore.com wrote: We sometimes get to invoke Makefile targets with a CC variable value containing spaces (for extra options, typically). This causes failure at some stages on powerpc-aix from mh-ppc-aix which has  LDFLAGS = `case

Re: [PATCH] teach emit_store_flag to use clz/ctz

2012-05-03 Thread Richard Henderson
On Fri, Apr 27, 2012 at 2:43 PM, Paolo Bonzinibonz...@gnu.org wrote: Interesting, first time I hear about this... ... except that no target sets the macros to 2, and all of them could (as far as I could see). Looks like the code trumps the documentation; how does this look? No target sets

Re: [PATCH] teach emit_store_flag to use clz/ctz

2012-05-03 Thread Richard Henderson
On 05/03/2012 03:23 AM, Paolo Bonzini wrote: - ctzsi4 expands to bitrev + clz:SI, so it will return 32 too. ctz:SI will never appear at all in the RTX stream, so you can define its value at zero to be whatever you want. Hence the correct valid of CTZ_DEFINED_VALUE_AT_ZERO is also 2. That's

Re: [PATCH] teach emit_store_flag to use clz/ctz

2012-05-03 Thread Paolo Bonzini
Il 03/05/2012 17:10, Richard Henderson ha scritto: ... except that no target sets the macros to 2, and all of them could (as far as I could see). Looks like the code trumps the documentation; how does this look? No target sets to 2? You mean like mips? You forgot to look at the

Re: fix ppc-aix build failures with spaces in CC (internal) variable

2012-05-03 Thread Olivier Hainque
On May 3, 2012, at 16:45 , David Edelsohn wrote: * config/mh-ppc-aix (LDFLAGS): Quote $(CC). Okay. Committed, thanks :)

Re: RFA: PR target/53120, constraint modifier + on operand tied by matching-constraint, 0.

2012-05-03 Thread DJ Delorie
Make sure a match_dup will still match the generated pattern later, I've had problems with match_dup not matching two rtx that rtx_equals() says are the same but not physically the same.

Re: [PATCH] Hoist adjacent pointer loads

2012-05-03 Thread Jeff Law
On 05/03/2012 08:33 AM, William J. Schmidt wrote: This patch was posted for comment back in February during stage 4. It addresses a performance issue noted in the EEMBC routelookup benchmark on a common idiom: if (...) x = y-left; else x = y-right; If the two loads can be

rfa: shrink rtl_bb_info

2012-05-03 Thread Michael Matz
Hi, Richi made some good points about my last patch, related to struct rtl_bb_info. Even though it's not that important to shrink it (only few BBs are in RTL mode) there's no need to waste space. My last patch created an unused pointer-sized hole in RTL mode, which we can just as well use

Go patch committed: Fix global dependencies for a, b = foo()

2012-05-03 Thread Ian Lance Taylor
This patch to the Go frontend fixes the dependency analysis for code like func foo() (int, int) var c = b var a, b = foo() This code used to crash the compiler because the initialization of c would refer to b, which would build the call, and then the initialization of a would not be able to see

Re: [google] re-enable r185948

2012-05-03 Thread Xinliang David Li
ok. Is the change in google-47 branch? Please also submit this to trunk (there was also a previous one pending). thanks, David On Thu, May 3, 2012 at 4:44 AM, Dehao Chen de...@google.com wrote: Hi, This patch was reverted because of performance degradation. However, it turns out to be an

[v3] doxygen markup for template parameters

2012-05-03 Thread Benjamin De Kosnik
In libstdc++/44015, there is a request for doxygen markup on template parameters, including default arguments. This is a kind of markup that libstdc++ has mostly not done, or done inconsistently. So, here's how I think it should be done, at least for io and containers. See generated files

[patch] PR29442 - split insn-attrtab.c in three parts

2012-05-03 Thread Steven Bosscher
Hello, How does one turn random volunteer GCC hackers into spoiled brats? Give them Big Iron to play with, like IBM's donation to the compile farm aka gcc110. If you do make -k 64 on a machine like that, a GCC build takes _minutes_, and that's so slooow... Part of the problem is

Re: [C11-atomic] [patch] gimple atomic statements

2012-05-03 Thread Andrew MacLeod
On 05/03/2012 05:59 AM, Richard Guenther wrote: the type can be removed from the structure and now there would be no wastage. Is that reasonable? types in ops is a bad idea (tried that once - heh), it wrecks too much generic code. heh, no doubt. As I Iooked at handling the generic atomics,

two libatomic configure updates

2012-05-03 Thread Richard Henderson
The first, reported by David re a ppc32 build failure. I don't understand why gcc_no_link would be true in that case, but it does point out a real bug. And possibly the same one that was reported against darwin overnight. The second, pointed out by Jason re enabling maintainer mode. Both

Re: Symbol table 6/many: Symbol table hashes

2012-05-03 Thread Martin Jambor
Hi, a bit late, but I do have two tiny comments nevertheless... On Mon, Apr 16, 2012 at 06:09:40PM +0200, Jan Hubicka wrote: Hi, this patch moves cgraph/varpool hashes into symbol table hashes, so the symbol table is actually almost a symbol table ;) Work done. Bootstrapped/regtested

Re: [PATCH] teach emit_store_flag to use clz/ctz

2012-05-03 Thread Richard Henderson
On 05/03/2012 08:23 AM, Paolo Bonzini wrote: Yeah, not as I posted... of course config/mips/mips.h needs change, but do you disagree that all targets_do_ have the same value at zero for the optab as they have for RTL? I don't agree without a port-by-port review, no. If, as you suggest, we

Re: [PATCH] Hoist adjacent pointer loads

2012-05-03 Thread William J. Schmidt
On Thu, 2012-05-03 at 09:40 -0600, Jeff Law wrote: On 05/03/2012 08:33 AM, William J. Schmidt wrote: This patch was posted for comment back in February during stage 4. It addresses a performance issue noted in the EEMBC routelookup benchmark on a common idiom: if (...) x =

Re: [PATCH] Fix overzealous DSE on sparc

2012-05-03 Thread David Miller
From: Richard Guenther richard.guent...@gmail.com Date: Thu, 3 May 2012 12:25:11 +0200 On Thu, May 3, 2012 at 11:52 AM, David Miller da...@davemloft.net wrote: From: Richard Guenther richard.guent...@gmail.com Date: Thu, 3 May 2012 11:48:03 +0200 calls.c is unsafe, too.  Which is probably

Go patch committed: Build interfaces tables for imported interfaces

2012-05-03 Thread Ian Lance Taylor
This patch to the Go frontend fixes a bug that can arise when a type in package A inherits from a type in package B, where the type in package B has a hidden method, and a third package C tries to convert the package A type to the B interface type. The compiler was failing to generate the

Re: [PATCH] Hoist adjacent pointer loads

2012-05-03 Thread Jeff Law
On 05/03/2012 10:47 AM, William J. Schmidt wrote: Yes and no. What's important is that you don't want to introduce page faults (or less urgently, cache misses) by speculating the load. So the patch is currently extremely constrained, and likely will always stay that way. Only fields that

Re: Optimize calls to functions that return one of their arguments

2012-05-03 Thread Richard Sandiford
Richard Guenther richard.guent...@gmail.com writes: On Sat, Apr 28, 2012 at 5:31 PM, Bernd Schmidt ber...@codesourcery.com wrote: This patch allows us to recognize that even if the argument to memcpy lives across the call, we can allocate it to a call-used register by reusing the return

[PATCH] libgcov support for profile collection in region of interest (issue6186044)

2012-05-03 Thread Teresa Johnson
This patch adds functionality to libgcov to enable user applications to collect profile data only in regions of interest. This is useful, for example, to collect profile data from a long-running server only during the time when it is serving requests. Specifically, the new routines __gcov_reset

[PATCH, powerpc] PR 53199, fix usage of __builtin_bswap64 on power6

2012-05-03 Thread Michael Meissner
In trying to build machine specific versions of glibc with newer compilers, we ran into a bug where the current glibc would not build on power6. This was due to glibc using the __builtin_swap64 builtin. Power6 sets the -mavoid-indexed-addresses option. The splitter that I wrote when I wrote the

[obvious] Do not declare flag_permissive explicitly and delete unused global var

2012-05-03 Thread Manuel López-Ibáñez
I will commit this as obvious shortly. Bootstrapped and regression tested x86_64-linux-gnu languages=all,ada,obj-c++ 2012-05-03 Manuel López-Ibáñez m...@gcc.gnu.org gcc/ * flags.h (flag_permissive): Do not declare. c-family/ * c.opt (fpermissive): Add Var(flag_permissive). gcc/

Re: [PATCH] Hoist adjacent pointer loads

2012-05-03 Thread William J. Schmidt
On Thu, 2012-05-03 at 11:44 -0600, Jeff Law wrote: On 05/03/2012 10:47 AM, William J. Schmidt wrote: Yes and no. What's important is that you don't want to introduce page faults (or less urgently, cache misses) by speculating the load. So the patch is currently extremely constrained,

Re: [patch] PR29442 - split insn-attrtab.c in three parts

2012-05-03 Thread Mike Stump
On May 3, 2012, at 9:31 AM, Steven Bosscher wrote: How does one turn random volunteer GCC hackers into spoiled brats? Give them Big Iron to play with, like IBM's donation to the compile farm aka gcc110. If you do make -k 64 on a machine like that, a GCC build takes _minutes_, and that's so

Ping: always supply a mode to plus_constant

2012-05-03 Thread Richard Sandiford
Ping for this patch to always supply a mode to plus_constant: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00892.html I've done a diff of the changes since the original test revision (which was r186448 FWIW) and there's only been one plus_constant- related change since then: Alan's rs6000

[C++ Patch] fix semi-random template specialization ICE

2012-05-03 Thread Alexandre Oliva
I've recently started getting “libstdc++-v3/include/functional:2057:63: internal compiler error: tree check: expected tree_vec, have error_mark in comp_template_args_with_info, at cp/pt.c:7038” on i686-linux-gnu, building libstdc++-v3/src/c++11/functexcept.cc -fPIC, at stage1 and on

Re: [PATCH] Hoist adjacent pointer loads

2012-05-03 Thread Jeff Law
On 05/03/2012 12:11 PM, William J. Schmidt wrote: However, from the wiki page I see: A speculative load which has its results thrown away are considered to not have changed the semantics of the program, and are therefore allowed. That seems to cover the case here: the load is hoisted, but if

[PR52983] eliminate autoinc from debug_insn locs (was: Re: fix left-over debug insns in DCE)

2012-05-03 Thread Alexandre Oliva
My recent patch for PR48866, that introduced dead_debug_insert_temp() with DEBUG_TEMP_BEFORE_WITH_VALUE as a possibility for keeping expressions about to be DCE'd, caused regressions on ppc because it would take MEMs with autoinc addressing modes, which would be rejected down the road. This patch

[Patch, Fortran] PR53175 - Fix another fallout of the TREE_PUBLIC=0 module variable patch

2012-05-03 Thread Tobias Burnus
A PRIVATE module variable, which is used in the specification expression of a function result variable cannot be TREE_PUBLIC()=0, unless the function itself is PRIVATE and also not accessible via type-bound procedures or a generic name. (The issue is gfortran specific as most compilers do not

Re: Restore bootstrap (PR53197)

2012-05-03 Thread Alexandre Oliva
On May 2, 2012, Michael Matz m...@suse.de wrote: my gimple_seq reshuffling broke boostrap on some machines. In particular on those for which contrib/compare-debug works, meaning that bootstrap-debug is selected as default BUILD_CONFIG (none of my machines pass the respective configure.ac

Fix LTO spec2k6 build

2012-05-03 Thread Jan Hubicka
Hi, this patch fixes one place where I misupdated cgraph_remove_unreachable_nodes while removing reachable flag. Bootstrapped/regtested x86_64-linux and comitted. Honza Index: ChangeLog === --- ChangeLog (revision 187113) +++

Fix emutls code handling aliases

2012-05-03 Thread Jan Hubicka
Hi, this patch fixes a bug I apparently intoduced while updating the code for new alias API. Instead of creating alias of emutls var it now creates alias of target var that leads to ICE later (or a wrong code when ICE is worked around). Bootstrapped/regtested x86_64-linux with emutls and

Re: Ping: always supply a mode to plus_constant

2012-05-03 Thread Richard Henderson
On 05/03/2012 11:15 AM, Richard Sandiford wrote: Ping for this patch to always supply a mode to plus_constant: http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00892.html Ok. r~

Re: [C Patch]: pr52543

2012-05-03 Thread Georg-Johann Lay
Richard Sandiford wrote: Ian Lance Taylor i...@google.com writes: Richard Sandiford rdsandif...@googlemail.com writes: Does anyone else have any thoughts before I make that change? I think that one of you should try to write a test case where it makes a difference, and add the test case to

DWARF patch to reduce the number of inter-CU refs

2012-05-03 Thread Jason Merrill
Here's the patch to perform that optimization I was talking about on the DWARF list: if we have multiple sig8 or symbolic references to another type, build up a local stub and redirect all the references there so that we are left with only one. If we left a skeleton in this CU when we split

Re: [patch] PR29442 - split insn-attrtab.c in three parts

2012-05-03 Thread Richard Henderson
On 05/03/2012 09:31 AM, Steven Bosscher wrote: +/* This gen* file is unique, in that it writes out multiple files. + + Before GCC 4.8, insn-attrtab.c was written out containing many large + functions and tables. This made insn-attrtab.c_the_ bottle-neck in + a parallel build, and even

Re: DWARF patch to reduce the number of inter-CU refs

2012-05-03 Thread Cary Coutant
Incidentally, I notice that we have unnecessary duplication in the type units.  For instance, with nested-3.C:        .uleb128 0x2    # (DIE (0x25) DW_TAG_namespace)        .long   .LASF0  # DW_AT_name: thread                        # DW_AT_declaration        .long   0x34    # DW_AT_sibling

Re: DWARF patch to reduce the number of inter-CU refs

2012-05-03 Thread Jason Merrill
On 05/03/2012 04:17 PM, Cary Coutant wrote: I believe I was just replicating the existing practice of putting definitions at the top level, with a DW_AT_specification pointing to a declaration DIE within the namespace/class hierarchy when necessary. Yeah, I seem to remember there being a

[v3] testsuite_flags vs. -ftrack-macro-expansion

2012-05-03 Thread Benjamin De Kosnik
Enables -ftrack-macro-expansion when running libstdc++ testsuite. tested x86/linux -benjamin2012-05-03 Benjamin Kosnik b...@redhat.com * scripts/testsuite_flags.in (cxxflags): Remove -ftrack-macro-expansion=0. diff --git a/libstdc++-v3/scripts/testsuite_flags.in

  1   2   >