Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Georg-Johann Lay
Joern Rennecke: David Edelsohn: Oleg Endo: Hmm .. the ACK status so far is: Not sure if we are supposed to acknowledge all the straigtforward argument additions... at any rate, the epiphany hunk is OK. I think I'll make use of the new functionality eventually, but prefer to be able to test

Re: [Patch, PR 54128] ira.c change to fix mips bootstrap

2012-09-05 Thread Jakub Jelinek
On Fri, Aug 31, 2012 at 10:58:51AM -0700, Steve Ellcey wrote: Here is my patch to fix the bootstrap comparision failure (PR 54128) on MIPS. The reason for the comparision failure was a difference in register usage and I tracked it down to build_insn_chain which checked all instructions for

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Markus Trippelsdorf
On 2012.09.04 at 14:23 -0700, Teresa Johnson wrote: I just committed the patch (included below). I implemented the occupancy bit vector approach for recording non-zero histogram entries, and a few issues uncovered with the merging in a profiled bootstrap. Passes both bootstrap and

Re: [PATCH] Set correct source location for deallocator calls

2012-09-05 Thread Andrew Haley
On 09/04/2012 09:31 PM, Dehao Chen wrote: Looks like even with addr2line properly installed, the gcj generated code cannot get the correct source file/lineno. Do I need to pass in #javac stacktrace.java #java stacktrace stacktrace.e(stacktrace.java:42) stacktrace.d(stacktrace.java:38)

Re: [PATCH] Set correct source location for deallocator calls

2012-09-05 Thread Andrew Pinski
On Wed, Sep 5, 2012 at 12:29 AM, Andrew Haley a...@redhat.com wrote: On 09/04/2012 09:31 PM, Dehao Chen wrote: Looks like even with addr2line properly installed, the gcj generated code cannot get the correct source file/lineno. Do I need to pass in #javac stacktrace.java #java stacktrace

Re: [PATCH, M68K] Fix ICE from scheduler improvement

2012-09-05 Thread Andreas Schwab
Maxim Kuvyrkov ma...@codesourcery.com writes: No. This hunk makes m68k scheduling support pick up the new state. Can you reformulate the comment to clarify that? Ok with that change. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5

Re: [PATCH, libstdc++] Add proper OpenBSD support

2012-09-05 Thread Jonathan Wakely
I'll look at this more carefully later today when I get back from a holiday, but it looks ok after a quick glance. I've CC'd gcc-patches, as required for all patches. Thanks. On Sep 4, 2012 10:27 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Fixes a few testcases.  Mostly based on the

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Oleg Endo
Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany[ ] i386 [ ] ia64 [x] iq2000[ ] lm32[ ] m32c [x] m32r [x] mcore [ ] mep [x] microblaze [x] mips [x] mmix [x]

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Uros Bizjak
On Wed, Sep 5, 2012 at 10:16 AM, Oleg Endo oleg.e...@t-online.de wrote: Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany[ ] i386 [ ] ia64 [x] iq2000[ ] lm32[ ] m32c [x] m32r

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Olivier Hainque
On Sep 4, 2012, at 22:42 , Hans-Peter Nilsson h...@bitrange.com wrote: Please, no inlining. Think of stack back-traces and their use when debugging. But, there was a talk at the GNU Tools Cauldron with related contents -

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Matthew Gretton-Dann
On 4 September 2012 21:42, Hans-Peter Nilsson h...@bitrange.com wrote: On Mon, 3 Sep 2012, Richard Guenther wrote: On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther rguent...@suse.de wrote: This adds a new optimization level, -Og, as previously discussed. It aims at providing fast

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 10:46 AM, Matthew Gretton-Dann matthew.gretton-d...@linaro.org wrote: Please, no inlining. Think of stack back-traces and their use when debugging. I would argue [without sufficient knowledge of how easy this would actually be to do in a real compiler :-)] that this is

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Matthew Gretton-Dann
On 5 September 2012 09:55, Steven Bosscher stevenb@gmail.com wrote: On Wed, Sep 5, 2012 at 10:46 AM, Matthew Gretton-Dann matthew.gretton-d...@linaro.org wrote: Please, no inlining. Think of stack back-traces and their use when debugging. I would argue [without sufficient knowledge of

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Richard Guenther
On Wed, 5 Sep 2012, Matthew Gretton-Dann wrote: On 5 September 2012 09:55, Steven Bosscher stevenb@gmail.com wrote: On Wed, Sep 5, 2012 at 10:46 AM, Matthew Gretton-Dann matthew.gretton-d...@linaro.org wrote: Please, no inlining. Think of stack back-traces and their use when

Re: [PATCH, libstdc++] Add proper OpenBSD support

2012-09-05 Thread Mark Kettenis
Date: Wed, 5 Sep 2012 10:55:27 +0300 From: Jonathan Wakely jwakely@gmail.com I'll look at this more carefully later today when I get back from a holiday, but it looks ok after a quick glance. Great! I've CC'd gcc-patches, as required for all patches. Sorry 'bout that. Bit of a brain

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Jakub Jelinek
On Wed, Sep 05, 2012 at 11:07:17AM +0200, Richard Guenther wrote: But that's not a problem with inlining, that's a problem with allowing things to happen out of order (for some definition of things and order) - which in my understanding -Og is going to tie down. Yes, the goal is

Re: [PATCH] Clarify gcc-{ar,nm,ranlib} usage in the documentation

2012-09-05 Thread Richard Guenther
On Tue, Sep 4, 2012 at 6:42 PM, Andi Kleen a...@firstfloor.org wrote: From: Andi Kleen a...@linux.intel.com Make it clear in the documentation that with -fno-fat-lto-objects the gcc-* wrappers should be used to pass the linker plugin. Ok. Thanks, Richard. gcc/: 2012-09-04 Andi Kleen

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Richard Earnshaw
On 05/09/12 09:16, Oleg Endo wrote: Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany[ ] i386 [ ] ia64 [x] iq2000[ ] lm32[ ] m32c [x] m32r [x] mcore [ ] mep [x]

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Denis Chertykov
2012/9/5 Oleg Endo oleg.e...@t-online.de: Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany[ ] i386 [ ] ia64 [x] iq2000[ ] lm32[ ] m32c [x] m32r [x] mcore [ ] mep

Re: [PATCH] Reduce memory usage for storing LTO decl resolutions

2012-09-05 Thread Richard Guenther
On Wed, Sep 5, 2012 at 12:49 AM, Steven Bosscher stevenb@gmail.com wrote: On Tue, Sep 4, 2012 at 6:43 PM, Andi Kleen a...@firstfloor.org wrote: +/* Compact representation of a index - resolution pair. Unpacked to an + vector later. */ +struct res_pair +{ +

Re: faster random number engine

2012-09-05 Thread Paolo Carlini
On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote: Nice! Thanks. Here's a small patchlet to set the abi version to .18. With this, check-abi will pass. tested x86/linux Benjamin, is this still uncommitted? I'm seeing abi_check failing... Thanks, Paolo.

RE: Ping: [PATCH] Enable bbro for -Os

2012-09-05 Thread Zhenqiang Chen
-Original Message- From: Richard Guenther [mailto:richard.guent...@gmail.com] Sent: Tuesday, September 04, 2012 6:31 PM To: Zhenqiang Chen Cc: Steven Bosscher; gcc-patches@gcc.gnu.org Subject: Re: Ping: [PATCH] Enable bbro for -Os On Wed, Aug 29, 2012 at 10:42 AM, Zhenqiang Chen

Re: [PATCH] Set correct source location for deallocator calls

2012-09-05 Thread Mark Wielaard
On Tue, 2012-09-04 at 18:17 +0100, Bryce McKinlay wrote: libgcj wouldn't actually use it for unwinding, we already have all that. We'd just use it to read DWARF debug info and give us the source code line numbers. Casey Marshell did also write that part some time ago, but it was never

Re: [patch] PR bootstrap/54453 (libstdc++ doesn't build)

2012-09-05 Thread Paolo Carlini
On 09/01/2012 08:10 PM, Steven Bosscher wrote: Hello, r190783 breaks bootstrap on powerpc64-unknown-linux-gnu. The problem is caused by a regexp that used to check for space|tab before the patch but now only looks for tab. The attached patch fixes this problem for me, but I'm not sure why (I

[PATCH,i386] fma4 addition for bdver2

2012-09-05 Thread Gopalasubramanian, Ganesh
Hello, FMA4 and FMA3 ISA are implemented in bdver2 target. FMA3 is selected by default. This patch supports the use of FMA4 intrinsics for bdver2 targets. Is it OK for trunk? Regards Ganesh 2012-09-05 Ganesh Gopalasubramanian ganesh.gopalasubraman...@amd.com * config/i386/i386.md :

Re: [C++ Patch] PR 54191

2012-09-05 Thread Paolo Carlini
On 08/28/2012 01:49 AM, Jason Merrill wrote: OK. Thanks Jason. I have now committed the patch together with the three additional tests which depended on instantiation_dependent_p. Thanks again, Paolo.

Re: [PATCH,i386] fma4 addition for bdver2

2012-09-05 Thread Uros Bizjak
On Wed, Sep 5, 2012 at 12:10 PM, Gopalasubramanian, Ganesh ganesh.gopalasubraman...@amd.com wrote: FMA4 and FMA3 ISA are implemented in bdver2 target. FMA3 is selected by default. This patch supports the use of FMA4 intrinsics for bdver2 targets. Is it OK for trunk? OK. I will backport this

Re: faster random number engine

2012-09-05 Thread Paolo Carlini
On 09/05/2012 11:53 AM, Paolo Carlini wrote: On 08/30/2012 06:37 PM, Benjamin De Kosnik wrote: Nice! Thanks. Here's a small patchlet to set the abi version to .18. With this, check-abi will pass. tested x86/linux Benjamin, is this still uncommitted? I'm seeing abi_check failing... Ok, now I

RE: [PATCH] PR45070: Fix wrong epilogue code for cortex-m0/Os

2012-09-05 Thread Bin Cheng
-Original Message- From: Ramana Radhakrishnan Sent: Tuesday, September 04, 2012 4:03 PM To: Bin Cheng Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR45070: Fix wrong epilogue code for cortex-m0/Os I ran regression test with/without Os for cortex-m0 and everything is ok.

Re: [PATCH] Reduce memory usage for storing LTO decl resolutions

2012-09-05 Thread Diego Novillo
On 2012-09-04 18:49 , Steven Bosscher wrote: Did you mean to use DEF_VEC_O here? (Not sure it matters after the vec rewrite for c++) It doesn't anymore. But it will matter for backports. Diego.

[RFA 1/n] Fix if conversion interactions with block partitioning

2012-09-05 Thread Matthew Gretton-Dann
All, This is the first patch in a series with the ultimate aim of enabling -freorder-blocks-and-partition in the ARM backend. However, whilst working on this I have come across a number of midend issues which should be fixed individually. This patch fixes an ICE during if-conversion. The

[RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Matthew Gretton-Dann
All, When implementing ARM/Thumb support for -freorder-blocks-and-partition I encountered the following silent code generation fault. Given the following CFG: | | 93 97 | | (FALLTHRU)(CROSSING) \ / \\ /---/

Re: [Test] contrib/test_installed modified to set specific gcov

2012-09-05 Thread Anna Tikhonova
Ok for trunk, 4.7, 4.6? 2012/8/17 Anna Tikhonova anna.m.tikhon...@gmail.com: Ping one more time. 2012/8/10 Anna Tikhonova anna.m.tikhon...@gmail.com: Ping. 2012/8/8 Anna Tikhonova anna.m.tikhon...@gmail.com: Hi, while running check for Android NDK compiler (I've used

Re: [RFA 1/n] Fix if conversion interactions with block partitioning

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 1:25 PM, Matthew Gretton-Dann wrote: + /* If the two blocks are in different partitions we do not want to mark + this as a fallthru edge. */ + if (BB_PARTITION (b) != BB_PARTITION (c)) +return; + I think you should look for a REG_CROSSING_JUMP note on

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: Whilst this fix works for this particular case I am not sure it is the best fix for the general issue, and so if others have a better idea how to fix this I would be very happy. postreload-gcse.c is broken in interesting ways. Look at

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Richard Earnshaw
On 05/09/12 13:02, Steven Bosscher wrote: On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: Whilst this fix works for this particular case I am not sure it is the best fix for the general issue, and so if others have a better idea how to fix this I would be very happy.

Re: [patch] PR bootstrap/54453 (libstdc++ doesn't build)

2012-09-05 Thread Ulrich Drepper
On Wed, Sep 5, 2012 at 6:08 AM, Paolo Carlini paolo.carl...@oracle.com wrote: Uli, I'm not sure to understand why that commit of yours changed that specific regexp, Completely unintended, I thought I mentioned this already. The problem is emacs's whitespace mode which made those changes.

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Matthew Gretton-Dann
On 5 September 2012 13:45, Richard Earnshaw rearn...@arm.com wrote: On 05/09/12 13:02, Steven Bosscher wrote: On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: Whilst this fix works for this particular case I am not sure it is the best fix for the general issue, and so if others have

[PATCH] Avoid repeated SSA updates during loop unrolling

2012-09-05 Thread Richard Guenther
This cuts another 250s off the testcase in PR46590 by calling update_ssa from complete unrolling only after all innermost loops are processed once. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2012-09-05 Richard Guenther rguent...@suse.de PR

[fortran, committed] PR 54474 assumed rank testsuite fix (was: Re: [Patch, Fortran, committed] Fix PR54467 (TBP ICEs due to _final wrapper disabling))

2012-09-05 Thread Mikael Morin
On 04/09/2012 00:19, Dominique Dhumieres wrote: Hi Tobias, The lines 6 and 12 of gfortran.dg/coarray_poly_3.f90 need some adjustment along the line: For what's worth, the testsuite change was part of patch (b) at http://gcc.gnu.org/ml/fortran/2012-08/msg00201.html while it should have been

Re: Minor reorganization in bb-reorder.c

2012-09-05 Thread Eric Botcazou
The file contains 3 RTL optimization passes, the gate and worker functions of which are strangely intertwined. More cosmetic changes: a few clarifications in the head comment of the file, a handful of long lines and other formatting nits. No functional changes. Tested on x86_64-suse-linux,

Re: [PATCH] Enable bbro for -Os

2012-09-05 Thread Eric Botcazou
Basic block reordering is disabled for -Os from gcc 4.7 since the pass will lead to big code size regression. But benchmarks logs also show there are lots of regression due to poor code layout compared with 4.6. The patch is to enable bbro for -Os. When optimizing for size, it * avoid

Add a configure option to disable system header canonicalizations (issue6495088)

2012-09-05 Thread Simon Baldwin
Add a configure option to disable system header canonicalizations. Libcpp may canonicalize system header paths with lrealpath() for diagnostics, dependency output, and similar. If gcc is held in a symlink farm the canonicalized paths may be meaningless to users, and will also conflict with build

Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-09-05 Thread Ian Lance Taylor
On Wed, Sep 5, 2012 at 6:56 AM, Simon Baldwin sim...@google.com wrote: Add a configure option to disable system header canonicalizations. Why should this be a configure option rather than a command-line option? Ian Libcpp may canonicalize system header paths with lrealpath() for

Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-09-05 Thread Simon Baldwin
On 5 September 2012 16:03, Ian Lance Taylor i...@google.com wrote: On Wed, Sep 5, 2012 at 6:56 AM, Simon Baldwin sim...@google.com wrote: Add a configure option to disable system header canonicalizations. Why should this be a configure option rather than a command-line option? The underlying

Re: Scheduler: Allow breaking dependencies by modifying patterns

2012-09-05 Thread Bernd Schmidt
On 08/03/2012 02:05 PM, Bernd Schmidt wrote: This patch allows us to change rn++ rm=[rn] into rm=[rn + 4] rn++ Ping. Bernd

Re: Add a configure option to disable system header canonicalizations (issue6495088)

2012-09-05 Thread Ian Lance Taylor
On Wed, Sep 5, 2012 at 7:23 AM, Simon Baldwin sim...@google.com wrote: On 5 September 2012 16:03, Ian Lance Taylor i...@google.com wrote: On Wed, Sep 5, 2012 at 6:56 AM, Simon Baldwin sim...@google.com wrote: Add a configure option to disable system header canonicalizations. Why should this

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
Sorry about that. I am right now trying to reproduce the profiledbootstrap problem that H.J. reported, which is on x86_64-unknown-linux-gnu where I had successfully done a profiledbootstrap before my commit. Unfortunately after svn updating my client I am hitting an unrelated build problem with

[PATCH, i386]: Remove reg_not_xmm0_operand and similar hacks

2012-09-05 Thread Uros Bizjak
Hello! Attached patch removes various *_not_xmm0_operand hacks. These were used to prevent combine from moving xmm0 register to the wrong place, but recently we implemented better approach. 2012-09-05 Uros Bizjak ubiz...@gmail.com * config/i386/sse.md

Re: [RFA 2/n] Don't lift loads above register using jumps in postreload-gcse.c

2012-09-05 Thread Steven Bosscher
On Wed, Sep 5, 2012 at 3:18 PM, Matthew Gretton-Dann matthew.gretton-d...@linaro.org wrote: On 5 September 2012 13:45, Richard Earnshaw rearn...@arm.com wrote: On 05/09/12 13:02, Steven Bosscher wrote: On Wed, Sep 5, 2012 at 1:42 PM, Matthew Gretton-Dann wrote: Whilst this fix works for this

[PATCH] Fix strspn/strcspn builtin folding (PR middle-end/54486)

2012-09-05 Thread Jakub Jelinek
Hi! fold_builtin_str*spn in this case returns sizetype typed constant instead of size_t, which makes -Wformat warn. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.7? 2012-09-05 Jakub Jelinek ja...@redhat.com PR middle-end/54486 *

[PATCH] Fix sel-sched ICE with asm goto (PR rtl-optimization/54455)

2012-09-05 Thread Jakub Jelinek
Hi! As discussed in the PR, sel-sched doesn't handle correctly tidying of empty blocks if fallthru predecessor ends with asm goto that has some labels on the empty block in addition to the fallthru edge. cfgrtl.c can handle that, so this patch just gives up on it on the sel-sched side. The

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread H.J. Lu
On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry about that. I am right now trying to reproduce the profiledbootstrap problem that H.J. reported, which is on x86_64-unknown-linux-gnu where I had successfully done a profiledbootstrap before my commit.

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
On Wed, Sep 5, 2012 at 8:44 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry about that. I am right now trying to reproduce the profiledbootstrap problem that H.J. reported, which is on x86_64-unknown-linux-gnu where I had

[Patch ARM] implement bswap16

2012-09-05 Thread Christophe Lyon
Hi, This patch implements __builtin_bswap16() on ARM (v6 and above) using revsh with a signed input and rev16 with an unsigned input. It is pretty much equal to the patch posted some time ago http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00962.html, but it's hard to write such patterns

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread H.J. Lu
On Wed, Sep 5, 2012 at 8:50 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Sep 5, 2012 at 8:44 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry about that. I am right now trying to reproduce the profiledbootstrap

Re: [PATCH] Fix strspn/strcspn builtin folding (PR middle-end/54486)

2012-09-05 Thread Diego Novillo
On 2012-09-05 11:40 , Jakub Jelinek wrote: 2012-09-05 Jakub Jelinek ja...@redhat.com PR middle-end/54486 * builtins.c (fold_builtin_strspn, fold_builtin_strcspn): Use build_int_cst with size_type_node instead of size_int. * c-c++-common/pr54486.c: New test.

Patch ping^2

2012-09-05 Thread Jakub Jelinek
http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01100.html - C++ -Wsizeof-pointer-memaccess support (C is already in)

Re: [PATCH] Add counter histogram to fdo summary (issue6465057)

2012-09-05 Thread Teresa Johnson
On Wed, Sep 5, 2012 at 9:13 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:50 AM, Teresa Johnson tejohn...@google.com wrote: On Wed, Sep 5, 2012 at 8:44 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Sep 5, 2012 at 8:09 AM, Teresa Johnson tejohn...@google.com wrote: Sorry

Fix argument spelling in uninstantiated vec_t function

2012-09-05 Thread Diego Novillo
Caught by Clang (which also checks uninstantiated templates). PR bootstrap/54484 * vec.h (vec_t::lower_bound): Fix spelling of LESSTHAN argument. diff --git a/gcc/vec.h b/gcc/vec.h index 441c9b5..fbf95d2 100644 --- a/gcc/vec.h +++ b/gcc/vec.h @@ -1075,7 +1075,7 @@

Re: [C++ Patch] PR 18747

2012-09-05 Thread Paolo Carlini
Hi, On 08/31/2012 11:32 PM, Jason Merrill wrote: Since you're traveling, I poked at this myself some more. The issue here is that there are too many template headers for the declaration, so we want to figure out what the right number is and give an appropriate message. Tested

Re: [C++ Patch] PR 18747

2012-09-05 Thread Paolo Carlini
On 09/05/2012 06:41 PM, Paolo Carlini wrote: Thanks for looking into this. Now I wonder if we made progress on a couple of long standing PRs where we weren't strict enough by one with the number of 'template '. Let me check... Nope, apparently c++/24314 is still there. But maybe it's easier to

[Patch, Fortran, committed] PR54462 - fix ICE on invalid

2012-09-05 Thread Tobias Burnus
Rather obvious fix. gfc_undo_symbols segfaulted when the COMMON statement aborted before the common symtree was created. Committed as Rev. 190989. Hopefully, that's the last fall out of my memory clean up patch. The hopefully last issue with the current FINAL patch has already been fixed by

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Oleg Endo
On Wed, 2012-09-05 at 13:44 +0400, Denis Chertykov wrote: 2012/9/5 Oleg Endo oleg.e...@t-online.de: Updated ACK table: [x] target-independent bits [ ] alpha [x] arm [ ] avr [ ] bfin [ ] cr16 [x] cris [x] epiphany[ ] i386 [ ] ia64 [x] iq2000[ ]

Re: Change double_int calls to new interface.

2012-09-05 Thread Lawrence Crowl
On 9/5/12, Richard Guenther rguent...@suse.de wrote: On Tue, 4 Sep 2012, Lawrence Crowl wrote: Modify gcc/*.[hc] double_int call sites to use the new interface. This change entailed adding a few new methods to double_int. Other changes will happen in separate patches. Once all uses of the

Re: [C++ Patch] PR 18747

2012-09-05 Thread Paolo Carlini
On 09/05/2012 06:52 PM, Paolo Carlini wrote: On 09/05/2012 06:41 PM, Paolo Carlini wrote: Thanks for looking into this. Now I wonder if we made progress on a couple of long standing PRs where we weren't strict enough by one with the number of 'template '. Let me check... Nope, apparently

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread DJ Delorie
I don't feel the m32c change needs my specific ack, it's a harmless change that goes with the ack for the feature itself. However, I will note that m32c does have different costs for addresses in different address spaces, at least when -Os.

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-05 Thread Oleg Endo
On Wed, 2012-09-05 at 14:39 -0400, DJ Delorie wrote: I don't feel the m32c change needs my specific ack, it's a harmless change that goes with the ack for the feature itself. However, I will note that m32c does have different costs for addresses in different address spaces, at least when

Re: Change double_int calls to new interface.

2012-09-05 Thread Marc Glisse
On Wed, 5 Sep 2012, Lawrence Crowl wrote: On 9/5/12, Richard Guenther rguent...@suse.de wrote: The tmin.cmp (tmax, uns) 0 kind of things look odd - definitely methods like tmin.gt (tmax, uns) would be nice to have. Or even better, get rid of the 'uns' parameters and provide a struct

Re: [v3] libstdc++/54296

2012-09-05 Thread François Dumont
On 09/05/2012 11:58 AM, Paolo Carlini wrote: Hi, On 09/04/2012 10:08 PM, François Dumont wrote: Hi I managed to do the test with Valgrind and so confirm the fix with the attached patch (unmodified since last proposal). Patch is Ok, thanks for your patience and thanks again for all your

[PATCH, libgfortran]: Use __builtin_ia32_{stmxcsr,ldmxcsr} intrinsics in config/fpu-i387.h

2012-09-05 Thread Uros Bizjak
Hello! This patch substitutes volatile asms with equivalent intrinsics. 2012-09-05 Uros Bizjak ubiz...@gmail.com * config/fpu-387.h (set_fpu): Use __builtin_ia32_stmxcsr and __builtin_ia32_ldmxcsr intrinsics. Tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline an 4.7

Re: Change double_int calls to new interface.

2012-09-05 Thread Lawrence Crowl
On 9/5/12, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 5 Sep 2012, Lawrence Crowl wrote: On 9/5/12, Richard Guenther rguent...@suse.de wrote: The tmin.cmp (tmax, uns) 0 kind of things look odd - definitely methods like tmin.gt (tmax, uns) would be nice to have. Or even better, get rid

[patch] Random cleanups

2012-09-05 Thread Steven Bosscher
Hello, Just some cleanups I did while working on something bigger. OK for trunk? Ciao! Steven * graphite.c (print_global_statistics): Use EDGE_COUNT instead of VEC_length. (print_graphite_scop_statistics): Likewise. * graphite-scop-detection.c (get_bb_type): Use

[patch] Fix bitmap_last_set_bit

2012-09-05 Thread Steven Bosscher
Hi, bitmap.c:bitmap_last_set_bit() is not used by any code in the current GCC trunk, but I'm using it and I noticed it returns an incorrect result. This patch rewrites most of the function to return the correct result. Not sure how to test this other than to say that my code, that uses this

[PATCH] Fix PR 54494, removal of volatile store in strlen optimization

2012-09-05 Thread Andrew Pinski
Hi, The problem here is the strlen optimization tries to remove a null character store as we already have done it but it does it for a volatile store which is not a valid thing to do. This patch fixes the problem by ignoring statements which have volatile operands. OK? Bootstrapped and tested

Re: [patch, mips] New mips triplet for multilib linux builds

2012-09-05 Thread Steve Ellcey
On Tue, 2012-09-04 at 23:55 +0100, Richard Sandiford wrote: If we do that, then your DRIVER_SELF_SPECS can further have: MIPS_ISA_SYNCI_SPEC where the definition: /* Infer a -msynci setting from a -mips argument, on the assumption that -msynci is desired where possible. */

Re: [PATCH, libgfortran]: Use __builtin_ia32_{stmxcsr,ldmxcsr} intrinsics in config/fpu-i387.h

2012-09-05 Thread Uros Bizjak
On Wed, Sep 5, 2012 at 9:53 PM, Uros Bizjak ubiz...@gmail.com wrote: This patch substitutes volatile asms with equivalent intrinsics. 2012-09-05 Uros Bizjak ubiz...@gmail.com * config/fpu-387.h (set_fpu): Use __builtin_ia32_stmxcsr and __builtin_ia32_ldmxcsr intrinsics.

Re: [PATCH, libgfortran]: Use __builtin_ia32_{stmxcsr,ldmxcsr} intrinsics in config/fpu-i387.h

2012-09-05 Thread Uros Bizjak
On Wed, Sep 5, 2012 at 11:30 PM, Uros Bizjak ubiz...@gmail.com wrote: * config/fpu-387.h (set_fpu): Use __builtin_ia32_stmxcsr and __builtin_ia32_ldmxcsr intrinsics. Tested on x86_64-pc-linux-gnu {,-m32}, committed to mainline an 4.7 branch. I forgot that these builtins are

Re: [PATCH] Fix PR 54494, removal of volatile store in strlen optimization

2012-09-05 Thread Jakub Jelinek
On Wed, Sep 05, 2012 at 02:10:03PM -0700, Andrew Pinski wrote: The problem here is the strlen optimization tries to remove a null character store as we already have done it but it does it for a volatile store which is not a valid thing to do. This patch fixes the problem by ignoring

[Patch, Fortran] PR54463 - fix -fexternal-matmul with -fdefault-real-8

2012-09-05 Thread Tobias Burnus
Rather obvious fix. Build on x86-64-linux. OK for the trunk when regtesting has succeeded? Tobias 2012-09-06 Tobias Burnus PR fortran/54463 * trans-intrinsic.c (gfc_conv_intrinsic_funcall): Fix matmul call to BLAS if the default-kind has been promoted. 2012-09-06 Tobias Burnus PR

Re: [Patch, Fortran] PR54463 - fix -fexternal-matmul with -fdefault-real-8

2012-09-05 Thread Steve Kargl
On Wed, Sep 05, 2012 at 11:55:54PM +0200, Tobias Burnus wrote: Rather obvious fix. Build on x86-64-linux. OK for the trunk when regtesting has succeeded? Yes. -- Steve

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Alexandre Oliva
On Sep 5, 2012, Richard Guenther rguent...@suse.de wrote: Yes, the goal is definitely to avoid the jumping back and forth on source lines you can see when debugging optimized programs. Hmm... If that's the goal, how about adding to the mix the Statement Frontier Notes proposal I advanced in

[Patch ARM] big-endian support for Neon vext tests

2012-09-05 Thread Christophe Lyon
Hello, Although the recent optimization I have committed to use Neon vext instruction for suitable builtin_shuffle calls does not support big-endian yet, I have written a patch to the existing testcases such they now support big-endian mode. I think it's worth improving these tests since writing

Re: [PATCH] Fix valtrack ICE (PR debug/53923)

2012-09-05 Thread Alexandre Oliva
On Aug 20, 2012, Jakub Jelinek ja...@redhat.com wrote: On the testcase from this PR on AVR (from libgcc, thus not including it into testsuite/) we ICE, because dead_debug_insert_temp is called several times on the same insn, for multi-register hard register for each regno in it (except the

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2012-09-05 Thread Alexandre Oliva
Hi, Richi, Sorry if this comes in late. I'd saved your message for careful analysis and I only got back to it now. On Aug 1, 2012, Richard Guenther richard.guent...@gmail.com wrote: On Fri, Dec 2, 2011 at 8:28 PM, Jakub Jelinek ja...@redhat.com wrote: PR debug/50317 * tree-ssa.c

Re: [PATCH] Fix PR 54494, removal of volatile store in strlen optimization

2012-09-05 Thread Andrew Pinski
On Wed, Sep 5, 2012 at 2:36 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Sep 05, 2012 at 02:10:03PM -0700, Andrew Pinski wrote: The problem here is the strlen optimization tries to remove a null character store as we already have done it but it does it for a volatile store which is not

Re: [Patch, PR 54128] ira.c change to fix mips bootstrap

2012-09-05 Thread Steve Ellcey
On Wed, 2012-09-05 at 08:15 +0200, Jakub Jelinek wrote: The debug insns generally shouldn't extend the lifetime of pseudos (see the valtrack.c stuff), so if you hit this, there is probably some earlier bug that didn't reset/adjust the debug insns in question. I'm not saying the ira.c patch is

[PATCH] Merging Cilk Plus to GCC (2 of approximately 22)

2012-09-05 Thread Iyer, Balaji V
Hello Everyone, Attached, please find a patch that will add regression test cases for elemental function implementation in C. Here are the Changelog entries: === gcc/testsuite/ChangeLog 2012-09-05 Balaji V. Iyer

Re: [C++ Patch] PR 18747

2012-09-05 Thread Jason Merrill
On 09/05/2012 02:17 PM, Paolo Carlini wrote: In fact, something seems weird earlier, in cp_parser_check_template_parameters. It has: /* If there are the same number of template classes and parameter lists, that's OK. */ if (parser-num_template_parameter_lists == num_templates)

Re: [PATCH] Merging Cilk Plus into Trunk (Patch 1 of approximately 22)

2012-09-05 Thread Joseph S. Myers
On Wed, 5 Sep 2012, Iyer, Balaji V wrote: Attached, please find the 1st of ~22 patches that implements Cilk Plus. This patch will implement Elemental Functions into the C compiler. Please check it in to the trunk if it looks OK. Below, I will give you a small example about

Re: [PATCH] Merging Cilk Plus to GCC (2 of approximately 22)

2012-09-05 Thread Joseph S. Myers
On Wed, 5 Sep 2012, Iyer, Balaji V wrote: Hello Everyone, Attached, please find a patch that will add regression test cases for elemental function implementation in C. Can the tests be arranged so that all functionality that isn't intrinsically target-specific is tested for all

Re: [PATCH] Merging Cilk Plus into Trunk (Patch 1 of approximately 22)

2012-09-05 Thread Gabriel Dos Reis
On Wed, Sep 5, 2012 at 5:09 PM, Iyer, Balaji V balaji.v.i...@intel.com wrote: Hello Everyone, Attached, please find the 1st of ~22 patches that implements Cilk Plus. This patch will implement Elemental Functions into the C compiler. Please check it in to the trunk if it looks OK.

[google] remove versioned symbols from libstdc++.a

2012-09-05 Thread Ollie Wild
This is a Google-local fix to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54482. When configured with --with-pic, libstdc++.a includes versioned symbols, preventing it from being linked into shared libraries. The ultimate cause of this is a misuse of -DPIC as a proxy for, I'm being compiled into

Re: [PATCH 1/2] gcc symbol database

2012-09-05 Thread Yunfeng ZHANG
What progress about my patch?

[google/gcc-4_7] Backport patch for comdat types problem

2012-09-05 Thread Cary Coutant
This patch is for the google/gcc-4_7 branch. Backport upstream patch to fix a problem where type signature does not include the type's context. Tested with bootstrap and regression tests. 2012-07-19 Jason Merrill ja...@redhat.com PR debug/53235 * dwarf2out.c

[wwwdocs] Fix a href vs a name confusion in codingrationale.html

2012-09-05 Thread Gerald Pfeifer
That was an interesting one to find and understand: this was not supposed to be a link, but setting of an anchor. Fix a href vs a name confusion in codingrationale.html; applied. Gerald Index: codingrationale.html === RCS file:

[patch, score] Remove TARGET_LEGITIMIZE_ADDRESS define

2012-09-05 Thread Liqin Chen
Remove inconsistent code and macro define in score backend, Use gcc default code instead. --liqin ChangeLog: 2012-09-06 Chen Liqin liqin@gmail.com * config/score/score.c : Remove TARGET_LEGITIMIZE_ADDRESS define and score_legitimize_address function, use compiler default

Re: [google/gcc-4_7] Backport patch for comdat types problem

2012-09-05 Thread Paul Pluzhnikov
On Wed, Sep 5, 2012 at 7:46 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Approved for google/gcc-4_7 branch. Thanks, -- Paul Pluzhnikov

Re: [google/gcc-4_7] Backport patch for comdat types problem

2012-09-05 Thread Cary Coutant
This patch is for the google/gcc-4_7 branch. Approved for google/gcc-4_7 branch. Thanks, committed at r191005. -cary

Re: [wwwdocs] PATCH for Re: Commit: XStormy16: Add support for -fstack-usage

2012-09-05 Thread Gerald Pfeifer
On Mon, 3 Sep 2012, nick clifton wrote: I like the full xstormy16 as well. I think that the fact that the gcc backend sources are in a directory called stormy16 is just a historical curiosity... Now that we are using svn, you could do a mv and change this. :) And the following patch updated

  1   2   >