Re: LRA has been merged into trunk.

2012-10-26 Thread H.J. Lu
On Wed, Oct 24, 2012 at 3:16 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Oct 23, 2012 at 8:46 AM, Vladimir Makarov vmaka...@redhat.com wrote: Hi, I was going to merge LRA into trunk last Sunday. It did not happen. LRA was actively changed last 4 weeks by implementing reviewer's proposals

Re: [patch, applied] avr RTEMS config/avr/* cleanups.

2012-10-26 Thread Ralf Corsepius
On 10/26/2012 06:48 AM, Georg-Johann Lay wrote: Ralf Corsepius schrieb: I've applied the patch below to trunk and gcc-4.7-branch. It contains 2 RTEMS specific cleanups which have been in use for avr-rtems for quite a while. Ralf 2012-10-26 Ralf Corsépius ralf.corsep...@rtems.org *

Re: LRA has been merged into trunk.

2012-10-26 Thread David Miller
From: H.J. Lu hjl.to...@gmail.com Date: Thu, 25 Oct 2012 22:59:58 -0700 On Wed, Oct 24, 2012 at 3:16 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Oct 23, 2012 at 8:46 AM, Vladimir Makarov vmaka...@redhat.com wrote: Hi, I was going to merge LRA into trunk last Sunday. It did not happen.

Re: LRA has been merged into trunk.

2012-10-26 Thread H.J. Lu
On Thu, Oct 25, 2012 at 11:12 PM, David Miller da...@davemloft.net wrote: From: H.J. Lu hjl.to...@gmail.com Date: Thu, 25 Oct 2012 22:59:58 -0700 On Wed, Oct 24, 2012 at 3:16 AM, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Oct 23, 2012 at 8:46 AM, Vladimir Makarov vmaka...@redhat.com wrote:

Re: LRA has been merged into trunk.

2012-10-26 Thread Jakub Jelinek
On Thu, Oct 25, 2012 at 11:15:06PM -0700, H.J. Lu wrote: Should there be a -fno-ira option before reload pass is removed? It will be useful to investiage IRA regressions. You mean -fno-lra, and s/IRA/LRA/, right? I think the reason for no compiler switch is that while returning false from

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread H.J. Lu
On Thu, Oct 25, 2012 at 8:53 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 3:34 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 3:13 PM, Richard Sandiford rdsandif...@googlemail.com wrote: H.J. Lu hjl.to...@gmail.com writes: On Thu, Oct 25, 2012 at 12:57 PM,

Re: LRA has been merged into trunk.

2012-10-26 Thread H.J. Lu
On Thu, Oct 25, 2012 at 11:21 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 25, 2012 at 11:15:06PM -0700, H.J. Lu wrote: Should there be a -fno-ira option before reload pass is removed? It will be useful to investiage IRA regressions. You mean -fno-lra, and s/IRA/LRA/, right? I

[PR54693] loss of debug info in jump threading and loop ivopts

2012-10-26 Thread Alexandre Oliva
Both jump threading and loop induction variable optimizations were dropping useful debug information, and it took improvements in both for debug info about relevant variables in the enclosed testcase to survive all the way to the end. The first problem was that jump threading could bypass blocks

Re: RFA: displacement handling in equiv_address_substitution

2012-10-26 Thread Richard Sandiford
Richard Sandiford rdsandif...@googlemail.com writes: Vladimir Makarov vmaka...@redhat.com writes: On 10/25/2012 05:45 AM, Richard Sandiford wrote: Hi Vlad, As discussed in the reviews, one of the things that worried me was the combination of: 1) the displacement fixup code in

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 04:30:41AM -0200, Alexandre Oliva wrote: From: Alexandre Oliva lxol...@fsfla.org for gcc/ChangeLog PR debug/54693 * config/i386/i386.c (add_parameter_dependencies): Stop backward scan at the insn before the incoming head.

Re: [PATCH] Use define_memory_constraint on sparc when necessary.

2012-10-26 Thread Eric Botcazou
While playing around with LRA on sparc I noticed that we had some poorly formed target memory constraints on sparc. In particular, they were not using define_memory_constraint, so we would not get a true return from EXTRA_MEMORY_CONSTRAINT for them. Also, these were matching 'reg' objects

Re: [PATCH] Use define_memory_constraint on sparc when necessary.

2012-10-26 Thread David Miller
From: Eric Botcazou ebotca...@adacore.com Date: Fri, 26 Oct 2012 09:40:08 +0200 While playing around with LRA on sparc I noticed that we had some poorly formed target memory constraints on sparc. In particular, they were not using define_memory_constraint, so we would not get a true return

Re: [RFC PATCH] Enable LRA on Sparc.

2012-10-26 Thread Eric Botcazou
With Richard Sandiford's address decomposition patch, Sparc looks really good on the 32-bit side. This is the patch I am using. 2012-10-25 David S. Miller da...@davemloft.net * config/sparc/sparc.c (sparc_lra_p): New function. (sparc_spill_class): New function.

Re: [patch, applied] avr RTEMS config/avr/* cleanups.

2012-10-26 Thread Ralf Corsepius
On 10/26/2012 07:57 AM, Ralf Corsepius wrote: On 10/26/2012 06:48 AM, Georg-Johann Lay wrote: Ralf Corsepius schrieb: I've applied the patch below to trunk and gcc-4.7-branch. It contains 2 RTEMS specific cleanups which have been in use for avr-rtems for quite a while. Ralf 2012-10-26 Ralf

Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2012-10-26 Thread Uros Bizjak
On Wed, Oct 24, 2012 at 1:06 PM, Uros Bizjak ubiz...@gmail.com wrote: On Wed, Oct 24, 2012 at 12:52 PM, H.J. Lu hjl.to...@gmail.com wrote: Please take a look at the attached patch. I changed the asm-pattern implementation according to your recomendation. Changed the name of feature option

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread Richard Sandiford
Sorry HJ, I got your message just after committing. H.J. Lu hjl.to...@gmail.com writes: Please try your patch on Linux/ia32 with go enabled. There is one go test which runs for a long time: 8149 hjl 20 0 49388 40m 9.8m R 99.3 0.3 15:18.35 go1 and it is still running. Are you

Re: [PATCH] Improve expansion into DEBUG_IMPLICIT_PTR (PR debug/54970)

2012-10-26 Thread Alexandre Oliva
On Oct 18, 2012, Jakub Jelinek ja...@redhat.com wrote: 2012-10-18 Jakub Jelinek ja...@redhat.com PR debug/54970 * cfgexpand.c (expand_debug_expr): Expand MEM_REF[var, n] as DEBUG_IMPLICIT_PTR + n if var expands to DEBUG_IMPLICIT_PTR. * tree-sra.c

Re: [PATCH] Use define_memory_constraint on sparc when necessary.

2012-10-26 Thread Eric Botcazou
Thanks for catching this. Also the comment at the top can now mention the now-available constraint letter as well. Ah, yes. And doc/md.texi be adjusted accordingly. -- Eric Botcazou

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-10-26 Thread Eric Botcazou
Eric and Rainer, I think that functionally this patch is fully ready to go into the tree except for the Solaris aspects which I do not have the means to work on. Have either of you made any progress in this area? Not yet, but I'll have a look at the beginning of next week. Some remarks:

Re: [RFC PATCH] Enable LRA on Sparc.

2012-10-26 Thread David Miller
From: Eric Botcazou ebotca...@adacore.com Date: Fri, 26 Oct 2012 10:04:13 +0200 With Richard Sandiford's address decomposition patch, Sparc looks really good on the 32-bit side. This is the patch I am using. 2012-10-25 David S. Miller da...@davemloft.net * config/sparc/sparc.c

Re: [RFC PATCH] Enable LRA on Sparc.

2012-10-26 Thread Eric Botcazou
But honestly I think the cbcond patch has higher priority, are you going to work on those solaris bits? Yes, I'll at least make sure that the patch can be installed without breaking the Solaris port. -- Eric Botcazou

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-10-26 Thread Rainer Orth
David Miller da...@davemloft.net writes: Eric and Rainer, I think that functionally this patch is fully ready to go into the tree except for the Solaris aspects which I do not have the means to work on. Have either of you made any progress in this area? Just wondering if either of you have

Re: [PATCH v3] Add support for sparc compare-and-branch

2012-10-26 Thread David Miller
From: Eric Botcazou ebotca...@adacore.com Date: Fri, 26 Oct 2012 10:57 +0200 @@ -1088,7 +1093,12 @@ sparc_option_override (void) if (TARGET_VIS3) target_flags |= MASK_VIS2 | MASK_VIS; - /* Don't allow -mvis, -mvis2, -mvis3, or -mfmaf if FPU is disabled. */ + /* -mcbcond implies

[PATCH, PR 54971] A SRA debug enhancement

2012-10-26 Thread Martin Jambor
Hi, the following patch fixes PR 54971 by creating extra for-debug-statements-only declarations for parts of aggregates that are never read and then creates debug bind statements so that the value of the non-used part is accessible from debug info. Bootstrapped and tested on x86_64-linux without

Re: [PATCH, PR 54971] A SRA debug enhancement

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 11:22:54AM +0200, Martin Jambor wrote: the following patch fixes PR 54971 by creating extra for-debug-statements-only declarations for parts of aggregates that are never read and then creates debug bind statements so that the value of the non-used part is accessible

RE: [PATCH] [AArch64] Add vcond, vcondu support.

2012-10-26 Thread James Greenhalgh
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Marcus Shawcroft Sent: 15 October 2012 12:37 To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] [AArch64] Add vcond, vcondu support. On 09/10/12 12:08, James Greenhalgh wrote:

Re:

2012-10-26 Thread Richard Biener
On Thu, Oct 25, 2012 at 10:56 PM, Lawrence Crowl cr...@googlers.com wrote: Change hash_table to support a comparator type different from the value type stored in the hash table. The 'find' functions now may take a different type from the value type. This requires introducing a second typedef

Re: [PATCH] Intrinsics for fxsave[,64], xsave[,64], xsaveopt[,64]

2012-10-26 Thread Kirill Yukhin
Hi, So, the patch is OK for mainline (with -mxsave removed from sse-X tests). Please commit the patch to mainline SVN. Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00963.html Thanks, K

Re: LRA has been merged into trunk.

2012-10-26 Thread Richard Biener
On Fri, Oct 26, 2012 at 8:30 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 11:21 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 25, 2012 at 11:15:06PM -0700, H.J. Lu wrote: Should there be a -fno-ira option before reload pass is removed? It will be useful to investiage

RE: [PATCH] [AArch64] Refactor Advanced SIMD builtin initialisation.

2012-10-26 Thread James Greenhalgh
-Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Marcus Shawcroft Sent: 15 October 2012 12:35 To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] [AArch64] Refactor Advanced SIMD builtin initialisation. On 05/10/12 16:52,

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-26 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: + location_t location = gimple_location (call); I'd call the var just loc, that is far more commonly used and shorter. Done. + /* If we initially had an instruction like: + + int n = strlen (str) + + we now want to instrument the access

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 12:13:16PM +0200, Dodji Seketeli wrote: * asan.c (insert_if_then_before_iter, instrument_mem_region_access, (instrument_strlen_call, maybe_instrument_builtin_call, (maybe_instrument_call): New static functions. (create_cond_insert_point): Renamed

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread Richard Sandiford
Richard Sandiford rdsandif...@googlemail.com writes: Sorry HJ, I got your message just after committing. H.J. Lu hjl.to...@gmail.com writes: Please try your patch on Linux/ia32 with go enabled. There is one go test which runs for a long time: 8149 hjl 20 0 49388 40m 9.8m R 99.3

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread H.J. Lu
On Fri, Oct 26, 2012 at 3:55 AM, Richard Sandiford rdsandif...@googlemail.com wrote: Richard Sandiford rdsandif...@googlemail.com writes: Sorry HJ, I got your message just after committing. H.J. Lu hjl.to...@gmail.com writes: Please try your patch on Linux/ia32 with go enabled. There is one

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 04:33:07AM -0700, H.J. Lu wrote: You are right. reflect test took a long time to compile. It has nothing to with LRA. About the nothing to do with LRA I'm not sure, because on Tuesday my make -j48 -k check (slowish 16way box, yes,rtl checking) took just 30 minutes and

Re: LRA has been merged into trunk.

2012-10-26 Thread H.J. Lu
On Fri, Oct 26, 2012 at 2:54 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, Oct 26, 2012 at 8:30 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 11:21 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 25, 2012 at 11:15:06PM -0700, H.J. Lu wrote: Should there be

Re: Additional fix for pre-reload schedule on x86 targets.

2012-10-26 Thread Kirill Yukhin
If it were not approved yet by an insn scheduler maintainer, it is ok for me. As Uros wrote that he rubberstamps the patch if a scheduler maintainer approves it, so you can commit it into the mainline. Checked in: http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00965.html K

Re: [Patch] Potential fix for PR55033

2012-10-26 Thread Sebastian Huber
Hello, here is a test case for PR55033. -- Sebastian Huber, embedded brains GmbH Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany Phone : +49 89 18 90 80 79-6 Fax : +49 89 18 90 80 79-9 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese

[PATCH] 2nd try to fix PR53695, loops and tracer

2012-10-26 Thread Richard Biener
This is the 2nd try fixing fallout of preserving loop structure over tracer. It makes tracer call fix_loop_structure explicitely (instead of relying on some cfghook setting LOOPS_NEED_FIXUP), it is quite expected that fixups are needed. But then we run into the issue that fix_loop_structure

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-26 Thread Diego Novillo
On Fri, Oct 26, 2012 at 4:40 AM, Kostya Serebryany k...@google.com wrote: One thing I overlooked before. In the gcc patch we are using -fasan flag name, while clang uses -f[no-]address-sanitizer (it used to be -fasan in early patches, but was renamed before submitting to trunk). Do we want

Re: [C++ Patch] PR 54984

2012-10-26 Thread Jason Merrill
On 10/25/2012 09:15 PM, Paolo Carlini wrote: I'm not sure the testcase can't be improved, I'm not very familiar with dg-final. You could do an execution test using a user-defined operator new which initializes the memory to something other than 0. OK with that change. Also, in case we

Re: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2)

2012-10-26 Thread Roman Zhuykov
This caused http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55081 -- Roman Zhuykov

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-26 Thread Eric Botcazou
I noticed that in r151350, Micheal changed from set_expr_location_r to SET_EXPR_LOCATION. Any insights why the recursive call is replaced? Looks to me if we reset the location for first level expr here, there is no reason that we don't reset expr for deeper levels. Or shall we simply remove

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-26 Thread Diego Novillo
On Fri, Oct 19, 2012 at 10:33 PM, Sriraman Tallam tmsri...@google.com wrote: Yes, the support is only for C++ for now. target attribute is not new and if the user tries to use this with 'C' then a duplicate defintion error would occur just like now. I have plans to implement this for C too.

Re: [C++ Patch] PR 54984

2012-10-26 Thread Paolo Carlini
Hi, On 10/26/2012 02:44 PM, Jason Merrill wrote: On 10/25/2012 09:15 PM, Paolo Carlini wrote: I'm not sure the testcase can't be improved, I'm not very familiar with dg-final. You could do an execution test using a user-defined operator new which initializes the memory to something other

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-26 Thread Michael Matz
Hi, On Thu, 25 Oct 2012, Dehao Chen wrote: * cfgexpand.c (set_expr_location_r): New callback function. (gimple_assign_rhs_to_tree): Walk the expr recursively. (expand_call_stmt): Likewise. (expand_gimple_stmt_1): Likewise. This cannot be right. You're going to propagate a toplevel

Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
Committed. 2012-10-26 Edward Smith-Rowland 3dw...@verizon.net * include/std/system_error (system_error(error_code, const char*), system_error(int, const error_category, const char*)): New. * include/std/stdexcept ( logic_error(const char*), domain_error(const

[PATCH][Revised] Fix target/PR55061

2012-10-26 Thread Jack Howarth
Currently gcc trunk fails to bootstrap on powerpc-apple-darwin9, using the default system compiler, in libbacktrace due to the absence of _Unwind_GetIPInfo() in the unwind.h header of Apple gcc 4.0.1 compiler. The attached patch eliminates this failure by enhancing the configure.ac test for

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Paolo Carlini
On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo.

Re: [PATCH] rs6000: Disable generation of lwa in 32-bit mode

2012-10-26 Thread Peter Bergner
On Fri, 2012-10-26 at 15:00 +1030, Alan Modra wrote: On Thu, Oct 25, 2012 at 03:57:38PM -0700, Segher Boessenkool wrote: for most others. This patch disables all lwa insns in 32-bit mode. We can later re-enable it if the assembler used handles it properly, Well, you can now do that.

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
On 10/26/2012 10:26 AM, Paolo Carlini wrote: On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo. Sorry, i though it was OK. Do you want me to roll back? do you want to? Ed

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Ed Smith-Rowland
On 10/26/2012 10:26 AM, Paolo Carlini wrote: On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo. Well, the commit had failed anyway... ChangeLog out of date. So I'll wait. Ed

Re: Add C++11 const char* overloads for exception classes.

2012-10-26 Thread Paolo Carlini
On 10/26/2012 04:36 PM, Ed Smith-Rowland wrote: On 10/26/2012 10:26 AM, Paolo Carlini wrote: On 10/26/2012 04:11 PM, Ed Smith-Rowland wrote: Committed. I can't find the message actually approving the patch. And personally I'm a bit nervous about it. Paolo. Sorry, i though it was OK. Do

Re: [PATCH][Revised] Fix target/PR55061

2012-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2012 at 7:15 AM, Jack Howarth howa...@bromo.med.uc.edu wrote: libbacktrace/ 2012-10-26 Jack Howarth howa...@bromo.med.uc.edu target/PR55061 * configure.ac: Check for _Unwind_GetIPInfo function declaration. * configure: Regenerate. This is OK.

Re: Top Level GCC change questions

2012-10-26 Thread nick clifton
Hi Steve, It looks like there is another patch that has not been checked in to the GCC top level tree but not binutils and a patch in binutils but not GCC. Is there any automation for this or is it still up to each person checking in files to copy stuff over by hand? As far as I know it is

Re: Fix bugs introduced by switch-case profile propagation

2012-10-26 Thread Jan Hubicka
Hi, On Tue, Oct 23, 2012 at 3:03 AM, Jan Hubicka hubi...@ucw.cz wrote: Ping. On Wed, Oct 17, 2012 at 1:48 PM, Easwaran Raman era...@google.com wrote: Hi, This patch fixes bugs introduced by my previous patch to propagate profiles during switch expansion. Bootstrap and

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-26 Thread Xinliang David Li
Yes. David On Fri, Oct 26, 2012 at 5:35 AM, Diego Novillo dnovi...@google.com wrote: On Fri, Oct 26, 2012 at 4:40 AM, Kostya Serebryany k...@google.com wrote: One thing I overlooked before. In the gcc patch we are using -fasan flag name, while clang uses -f[no-]address-sanitizer (it used to

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 08:48:10AM -0700, Xinliang David Li wrote: Yes. On Fri, Oct 26, 2012 at 5:35 AM, Diego Novillo dnovi...@google.com wrote: On Fri, Oct 26, 2012 at 4:40 AM, Kostya Serebryany k...@google.com wrote: One thing I overlooked before. In the gcc patch we are using -fasan

Re: [asan] New transitional branch to port ASAN to trunk

2012-10-26 Thread Xinliang David Li
yes -- there is no need to change any developer only internal names. David On Fri, Oct 26, 2012 at 8:49 AM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Oct 26, 2012 at 08:48:10AM -0700, Xinliang David Li wrote: Yes. On Fri, Oct 26, 2012 at 5:35 AM, Diego Novillo dnovi...@google.com wrote:

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-26 Thread Jan Hubicka
Hi, sorry for jumping in late, for too long I did not had chnce to look at my TODO. I have two comments... Index: gcc/cgraphbuild.c === --- gcc/cgraphbuild.c (revision 192623) +++ gcc/cgraphbuild.c (working copy) @@ -34,6 +34,7

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-26 Thread Xinliang David Li
On Fri, Oct 26, 2012 at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, sorry for jumping in late, for too long I did not had chnce to look at my TODO. I have two comments... Index: gcc/cgraphbuild.c === --- gcc/cgraphbuild.c

Fix minor bug in accounting external functions

2012-10-26 Thread Jan Hubicka
Hi, inliner knows that removing external function is not going to save any code, but it should also know that inlining into external function that is itself not inline (yet) does not cost you anything either. Bootstrapped/regtested x86_64-linux, comitted. Honza Index: ipa-inline-transform.c

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-26 Thread Sriraman Tallam
On Fri, Oct 26, 2012 at 9:07 AM, Xinliang David Li davi...@google.com wrote: On Fri, Oct 26, 2012 at 8:54 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, sorry for jumping in late, for too long I did not had chnce to look at my TODO. I have two comments... Index: gcc/cgraphbuild.c

Re: Change hash_table for separate comparator, documentation, cleanups...

2012-10-26 Thread Lawrence Crowl
On 10/26/12, Richard Biener richard.guent...@gmail.com wrote: On Oct 25, 2012 Lawrence Crowl cr...@googlers.com wrote: Change hash_table to support a comparator type different from the value type stored in the hash table. The 'find' functions now may take a different type from the value

[PATCH] Inter-bb range test optimization (PRs tree-optimization/19105, tree-optimization/21643, tree-optimization/46309)

2012-10-26 Thread Jakub Jelinek
Hi! This patch extends optimize_range_tests optimization, so that it handles also the cases where the truth or || has been gimplifed as a series of GIMPLE_CONDs or mixture thereof and BIT_{AND,IOR}_EXPR stmts. Example of code it handles is e.g.: bb 2: v1_3 = a_2(D) != 3; v2_4 = a_2(D) !=

Re: PR tree-optimization/54985

2012-10-26 Thread Jeff Law
On 10/23/2012 03:43 PM, Jakub Jelinek wrote: On Tue, Oct 23, 2012 at 03:34:46PM -0600, Jeff Law wrote: I think it should be backported to 4.7, perhaps with a few days delay after the trunk commit. Do we even have debug statements after control flow statements? They shouldn't be there, so if

[PATCH] PR c++/54955 - Fail to parse alignas expr at the beginning of a declaration

2012-10-26 Thread Dodji Seketeli
Hello, In this PR, G++ embarrassingly fails to parse the simple alignas expression below: alignas(double) int f; even though the simple-declaration production in Clause 7 suggests otherwise. Fixed thus and tested on x86_64-unknown-linux-gnu against trunk. gcc/cp PR c++/54955

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-26 Thread Jeff Law
On 10/26/2012 12:30 AM, Alexandre Oliva wrote: Propagate debug stmts for jump threading From: Alexandre Olivalxol...@fsfla.org for gcc/ChangeLog PR debug/54693 * tree-ssa-threadedge.c (thread_around_empty_block): Copy debug temps from predecessor before threading. So

libgo patch committed: Fix test

2012-10-26 Thread Ian Lance Taylor
Uros investigated a libgo testsuite failure on Alpha GNU/Linux that looked like a GC bug but turned out to simply be a testsuite bug. In Go when the garbage collector collects an os.File it closes the file descriptor. The syscall/creds_test test would call socketpair(), and defer closing both

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 11:42:20AM -0600, Jeff Law wrote: On 10/26/2012 12:30 AM, Alexandre Oliva wrote: Propagate debug stmts for jump threading for gcc/ChangeLog PR debug/54693 * tree-ssa-threadedge.c (thread_around_empty_block): Copy debug temps from predecessor before

[PATCH, i386]: Use __builtin_ia32_fxsave in crtfastmath.c

2012-10-26 Thread Uros Bizjak
Hello! Attached patch introduces __builtin_ia32_fxsave to crtfastmath.c. In addition, it clears only fxsave.mxcsr_mask, as we will look at this field only. Also, we don't have to execute additional stmxcsr, since fxsave also saves this register. 2012-10-26 Uros Bizjak ubiz...@gmail.com

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-26 Thread Jeff Law
On 10/26/2012 11:51 AM, Jakub Jelinek wrote: The debug stmts are already in SSA form, and, being debug stmts, they are always just consumers of SSA names, not defining stmts, and Alex' patch is just copying them over from a predecessor bb to a successor bb that has a single predecessor (the one

Re: [PATCH GCC]Fix test case failure reported in PR54989

2012-10-26 Thread Jeff Law
On 10/22/2012 02:15 AM, Bin Cheng wrote: -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Monday, October 22, 2012 3:16 PM To: Bin Cheng Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH GCC]Fix test case failure reported in PR54989 On Mon, Oct 22, 2012 at

[PATCH] Improve valtrack handling during fast DCE (PR debug/54953)

2012-10-26 Thread Jakub Jelinek
Hi! If DCE is not going to remove some insn, as it is needed, but the pseudo it sets is REG_DEAD before some debug insn which uses the pseudo, DCE + valtrack still insert a debug temporary before the insn with the value instead of after it with the pseudo it sets. This is undesirable if SET_SRC

Re: [m68k] Fix option handling for -m68020-40 and -m68020-60

2012-10-26 Thread Andreas Schwab
Gunther Nikl gn...@users.sourceforge.net writes: The patch should be installed on trunk and on the 4.7 branch. Thanks, done. The 4.7 branch required some adjustment, since it's not compiled as C++. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B

[PATCH] add check_effective_target_masm_intel

2012-10-26 Thread Jack Howarth
Currently targets like darwin which use older assemblers which lack support for the -masm=intel command line option fail these tests. The attached patch adds a proc for check_effective_target_masm_intel to target-supports.exp and uses it in the gcc.target/i386/asm-dialect-1.c test case. Tested

[C++ PATCH] Improve -std=c++98 static var initializers with sizeof (PR c++/55081)

2012-10-26 Thread Jakub Jelinek
Hi! The SIZEOF_EXPR delayed folding caused another problem as the following testcase shows for -std=c++98. Fixed by always performing maybe_constant_init, even for C++98. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-10-26 Jakub Jelinek ja...@redhat.com

libbacktrace patch committed: Don't warn about missing shared libs

2012-10-26 Thread Ian Lance Taylor
I have not been able to recreate PR 55087, but it seems to be pointing out a case where libbacktrace is issuing an error attempting to open a shared library that does not exist (in this case it's the VDSO library, which never exists in the file system as far as I know). This patch to libbacktrace

Re: [C++ PATCH] Improve -std=c++98 static var initializers with sizeof (PR c++/55081)

2012-10-26 Thread Jason Merrill
OK. Jason

Re: [PATCH] PR c++/54955 - Fail to parse alignas expr at the beginning of a declaration

2012-10-26 Thread Jason Merrill
On 10/26/2012 01:37 PM, Dodji Seketeli wrote: cp_next_tokens_can_be_std_attribute_p (cp_parser *parser) { - return cp_nth_tokens_can_be_std_attribute_p (parser, 1); + cp_token *token = cp_lexer_peek_token (parser-lexer); + + return (cxx_dialect = cxx0x + (token-type == CPP_KEYWORD

Re: [PATCH] add check_effective_target_masm_intel

2012-10-26 Thread Mike Stump
On Oct 26, 2012, at 12:14 PM, Jack Howarth howa...@bromo.med.uc.edu wrote: Currently targets like darwin which use older assemblers which lack support for the -masm=intel command line option fail these tests. The attached patch adds a proc for check_effective_target_masm_intel to

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread H.J. Lu
On Fri, Oct 26, 2012 at 4:51 AM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Oct 26, 2012 at 04:33:07AM -0700, H.J. Lu wrote: You are right. reflect test took a long time to compile. It has nothing to with LRA. About the nothing to do with LRA I'm not sure, because on Tuesday my make -j48

PR c/51294 spurious warning from -Wconversion in C and C++ in conditional expressions

2012-10-26 Thread Manuel López-Ibáñez
A long standing issue with Wconversion. Fixed thusly. Bootstrapped and regression tested on x86_64-linux-gnu. OK? 2012-10-26 Manuel López-Ibáñez m...@gcc.gnu.org PR c/51294 c-family/ * c-common.c (conversion_warning): Handle conditional expressions. testsuite/ *

Re: [PATCH] Inter-bb range test optimization (PRs tree-optimization/19105, tree-optimization/21643, tree-optimization/46309)

2012-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2012 at 07:27:43PM +0200, Jakub Jelinek wrote: This patch extends optimize_range_tests optimization, so that it handles also the cases where the truth or || has been gimplifed as a series of GIMPLE_CONDs or mixture thereof and BIT_{AND,IOR}_EXPR stmts. Some statistics from

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-26 Thread Dehao Chen
Hi, I've updated the patch: 1. abandon the changes in cfgexpand.c 2. set the block for trees when lowering gimple stmt. 3. add a unittest. However, this patch will trigger two lto bug when asserting LTO_NO_PREVAIL for TREE_CHAIN. After debugging for a while, I found that the problem was also

[rl78] fix __far reg+addend addresses

2012-10-26 Thread DJ Delorie
Commited. * config/rl78/rl78.c (rl78_as_legitimate_address): Do not allow reg+addend addresses for the _far namespace. Index: gcc/config/rl78/rl78.c === --- gcc/config/rl78/rl78.c (revision 192862) +++

[lra] branch was merged with trunk

2012-10-26 Thread Vladimir Makarov
LRA branch was merged with trunk @ 192861. It was successfully bootstrapped on x86/x86-64. Committed as rev. 192865.

[lra] patch for the flag to swith off/on LRA.

2012-10-26 Thread Vladimir Makarov
The following patch implements a flag (-flra/-fno-lra) to switch on/off LRA for targets on which it was ported. By default, LRA is switch on. The flag is not documented as it will not live for a long time. The patch was successfully bootstrapped on x86/x86-64. Committed as rev 192867.

Re: *ping* [patch, fortran] Handle -Wextra, -fcompare-reals is implied with -Wextra

2012-10-26 Thread Andreas Schwab
Thomas Koenig tkoe...@netcologne.de writes: Index: trans.c === --- trans.c (revision 192638) +++ trans.c (working copy) @@ -814,26 +814,23 @@ gfc_allocate_allocatable (stmtblock_t * block, tre } -/* Free a given

[patch] Apply conditional down cast to cgraph.h et.al.

2012-10-26 Thread Lawrence Crowl
This patch implements generic type query and conversion functions, and applies them to the use of cgraph_node, varpool_node, and symtab_node. The functions are: bool is_a TYPE (pointer) Tests whether the pointer actually points to a more derived TYPE. TYPE *as_a TYPE (pointer) Converts

Re: [patch] Unify bitmap interface.

2012-10-26 Thread Lawrence Crowl
On 10/25/12, Lawrence Crowl cr...@googlers.com wrote: This patch implements the unification of the *bitmap interfaces as discussed. Essentially, we rename ebitmap and sbitmap functions to use the same names as the bitmap functions. This rename works because we can now overload on the bitmap

Re: RFC/A: A generic decompose_address routine

2012-10-26 Thread H.J. Lu
On Thu, Oct 25, 2012 at 8:53 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 3:34 PM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Oct 25, 2012 at 3:13 PM, Richard Sandiford rdsandif...@googlemail.com wrote: H.J. Lu hjl.to...@gmail.com writes: On Thu, Oct 25, 2012 at 12:57 PM,

[PATCH] Update sparc constraint comments and documentation.

2012-10-26 Thread David Miller
While I was here I filled in some gaps in the documentation. Committed to master. * config/sparc/constraints.md: Update unused letter list, move w near other memory constraints. Remove no longer relevant comment. * doc/md.texi: Sync sparc constraint

RE: [PATCH GCC]Fix test case failure reported in PR54989

2012-10-26 Thread Bin Cheng
-Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Saturday, October 27, 2012 2:54 AM To: Bin Cheng Cc: 'Jakub Jelinek'; gcc-patches@gcc.gnu.org Subject: Re: [PATCH GCC]Fix test case failure reported in PR54989 On 10/22/2012 02:15 AM, Bin Cheng wrote:

[PATCH] Fix libbacktrace on 32-bit sparc

2012-10-26 Thread David Miller
I'm getting a SIGBUS on every backtrace libbacktrace generates on 32-bit sparc builds. The crashes usually happen in add_function_range(), where 'p' is not 8-byte aligned. It seems that the vector code doesn't take care to align the pointers it returns. I cribbed the size alignment done in

Re: [PATCH] rs6000: Disable generation of lwa in 32-bit mode

2012-10-26 Thread Segher Boessenkool
for most others. This patch disables all lwa insns in 32-bit mode. We can later re-enable it if the assembler used handles it properly, Well, you can now do that. Mainline gas and ld are now fixed. Yes, you are much too quick for me to keep up. Thank you! Now that gas and ld are fixed,