Jack,
On Wed, Feb 6, 2013 at 10:27 PM, Jack Howarth wrote:
>I think you are making this much more complex than it really is.
> The ENDFILE_SPEC on ppc is obtained from gcc/config/darwin.h and is
> only...
>
> #define TM_DESTRUCTOR "%{fgnu-tm: -lcrttme.o}"
>
> whereas for intel darwin, it is d
This patch is the google/main version of this pending patch for trunk:
http://gcc.gnu.org/ml/gcc-patches/2013-02/msg00260.html
I've modified GCC to generate line number tables at -g1, and we
already have the -gmlt option in google/main as a synonym for -g1. The
patch also changes -g so that it ha
After fixing PR54009 (again), I thought I'd take a look at why reload
is generating the following correct but poor code
stw 10,8(1)
stw 11 12(1)
...
lfd 0,8(1)
stfd 0,x+32764@l(9)
rather than
addi 9,x+32764@l(9)
...
stw 10,0(9)
stw 11 4(9)
This code sequence is from
(set (mem/c:DF (lo
On Wed, Feb 06, 2013 at 01:24:43PM -0500, David Edelsohn wrote:
> We just need to tweak it until we close these corner cases.
>
> Do you have a testcase that can be added?
David's "corner case" comment prompted me to look at this again, and
sure enough, there was another case that could be trigge
Hi,
I have attached a patch documenting Function Multiversioning and
added a few more tests. I have also updated the wiki
http://gcc.gnu.org/wiki/FunctionMultiVersioning. Please let me know if
there are any more tests you specifically want.
Please review.
Thanks
Sri
On Wed, Jan 30, 2013 at
On Wed, Feb 06, 2013 at 09:15:20PM +0100, Patrick Marlier wrote:
> About this old patch
> http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00851.html, I though that
> "&& !defined (__MACH__)" should be changed but it seems the best
> way...
Actually on reflection this conditional may be why the propos
Hi!
On Mon, 05 Nov 2012 07:09:43 +0100, I wrote:
> On Fri, 28 Sep 2012 09:56:41 +0200, Samuel Thibault
> wrote:
> > Thomas Schwinge, le Thu 27 Sep 2012 09:15:23 +0200, a écrit :
> > > On Wed, 26 Sep 2012 16:02:29 +0200, Svante Signell
> > > wrote:
> > > > gdb does not build from source any lon
On Wed, Feb 6, 2013 at 5:32 PM, Cary Coutant wrote:
> This patch adds -g[no-]fission as a synonym for -g[no-]split-dwarf,
> and modifies the existing stub we have for -gmlt to make it a synonym
> for -g1. The implementation of -gsplit-dwarf is already in trunk (and
> therefore g/i), and the implem
On Solaris the libgo networking library uses select. This patch
implements some fixes for that code. The Close method is changed to
actually do something; this is mainly for testing purposes. More
importantly, when a socket is closed, the select needs to be restarted
so that the callers see the
This patch adds -g[no-]fission as a synonym for -g[no-]split-dwarf,
and modifies the existing stub we have for -gmlt to make it a synonym
for -g1. The implementation of -gsplit-dwarf is already in trunk (and
therefore g/i), and the implementation of -g1 to produce line tables
will be submitted for
Because Peter Bergner most recently worked on embedded PPC targets, I
had asked him to double-check the patch before approving it.
Hopefully he will give me some feedback soon.
Thanks, David
> Yes, this works perfectly, Jakub any objections?
>
> gcc/
>
> 2013-02-06 David S. Miller
>
> * var-tracking.c (vt_add_function_parameter): Test the presence of
> HAVE_window_save properly and do not remap argument registers when
> we have a leaf function.
Please put it on
Jakub Jelinek writes:
> On Sun, Feb 03, 2013 at 10:38:05AM +, Richard Sandiford wrote:
>> Most of the files here say "This file is part of the GNU C Library"
>> or "the GNU MP Library", so maybe we don't actually want to update them.
>> Please let me know if so.
>>
>> Tested on x86_64-linux-g
Ben Elliston writes:
> On Mon, Feb 04, 2013 at 12:12:14PM -0800, Bruce Korb wrote:
>
>> If you update a chapter, the book copyright date is updated. Makes more
>> sense
>> to me.
>
> OK. That's fine with me, then.
Thanks, I installed the patch and added libdecnumber to the list
of default direc
I misspelled srcdir in an assertion (sorry David!).
Committed to trunk.
* testsuite-management/validate_failures.py: Fix typo.
diff --git a/contrib/testsuite-management/validate_failures.py
b/contrib/testsuite-management/validate_failures.py
index 76f9aab..74dbcfb 100755
--- a/contrib/
On Wed, Feb 06, 2013 at 09:15:20PM +0100, Patrick Marlier wrote:
> On Wed, Feb 6, 2013 at 6:28 PM, Iain Sandoe wrote:
> >
> > On 6 Feb 2013, at 17:20, Jack Howarth wrote:
> >
> >> On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote:
> >>> Hi Jack,
> >>>
> >>> Thanks for having a look a
Since the patch to add C++11 opaque enum declarations went in, we
haven't been giving a diagnostic about defining a nested enum that was
never declared.
Tested x86_64-pc-linux-gnu, applying to trunk.
commit fc9c83ce083e197c17ad7377431ff219e43d7eff
Author: Jason Merrill
Date: Wed Feb 6 15:06:
On Feb 6, 2013, at 1:20 AM, Sebastian Huber
wrote:
> Would someone mind having a look at this.
GIven where we are in the release cycle, I'd prefer a ppc person to double
check (by reviewing and approving). I don't see reason why it cannot be
approved…
On Feb 6, 2013, at 1:20 AM, Sebastian Huber
wrote:
> Would someone mind having a look at this.
GIven where we are in the release cycle, I'd prefer a ppc person to double
check (by reviewing and approving). I don't see reason why it cannot be
approved...
On Feb 6, 2013, at 7:44 AM, Jack Howarth wrote:
>Don't you need assembler support for the constructor init priorities to be
> called in the correct order when they reside in static or shared libraries?
No. It can be done without assembler support.
On Feb 6, 2013, at 6:23 AM, Alexander Potapenko wrote:
> I can't see how full init_priority support can work without proper aid
> from ld and/or the dynamic linker.
I can, but, I don't see that that matters much. It is a mere matter of
software. Rough sketch, define an encoding of the priority
When using validate_failures.py with --manifest and --results, we
don't need a GCC build directory. This is useful when using the
validator outside of the build tree. We were insisting on finding
a valid build tree regardless of those options.
Tested on x86_64. Committed to trunk.
* te
From: Eric Botcazou
Date: Wed, 06 Feb 2013 11:13:30 +0100
> I think testing crtl->uses_only_leaf_regs is sufficient here (and
> while you're at it, you could also test the value of
> HAVE_window_save, which can be 0 if -mflat is passed on the SPARC),
> so
>
> #ifdef HAVE_window_save
> if (HA
On Wed, Feb 6, 2013 at 6:28 PM, Iain Sandoe wrote:
>
> On 6 Feb 2013, at 17:20, Jack Howarth wrote:
>
>> On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote:
>>> Hi Jack,
>>>
>>> Thanks for having a look at this.
>>>
>>> However I don't understand why you need this:
>>>
>>> Index: gcc/
A long time ago, I proposed a -gmlt option to generate "minimal line
tables" (basically -g1 + line tables):
http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02075.html
The consensus from that thread was that instead of a new option, we
should just modify -g1 to produce line tables (the documented pur
On 02/06/2013 11:11 AM, Eric Botcazou wrote:
I think there is no point in creating a REG_EQUAL note when you're trying to
propagate a pseudo (or a subreg of a pseudo here). As a matter of fact,
that's what CSE explicitly does not:
Agreed. I have a hard time seeing where having a REG_EQUAL not
>> As for a test case, a lot of test cases in class_optional_2.f90
>> are commented out. Some of these could probably be uncommented
>> now, but it is not too urgent now.
>
> Good point! I think we should do it now – otherwise, we will forget it. (But
> one should test using valgrind whether it rea
This patch extends verify_loop_structure by checking that header's
are really its own headers (this proved as useful in PR56181).
The bulk of the code is taken from flow_loops_find.
Bootstrapped on x86_64 linux. The only fallout now is (for C/C++):
FAIL: gcc.dg/torture/pr54458.c -O3 -fomit-frame
On Wed, Feb 06, 2013 at 05:28:33PM +, Iain Sandoe wrote:
>
> On 6 Feb 2013, at 17:20, Jack Howarth wrote:
>
> > On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote:
> >> Hi Jack,
> >>
> >> Thanks for having a look at this.
> >>
> >> However I don't understand why you need this:
On Wed, Feb 6, 2013 at 8:38 AM, Alan Modra wrote:
> My PR54131 fix caused PR54009 to raise its ugly head again. Allowing
> all LO_SUM addresses in the 'Y' constraint (mem_operand_gpr) wasn't
> quite correct. We still need to check for wrap when offsetting for
> multiple words/regs. Fixing that
This is the miscompilation of the Ada front-end (ureal.adb) on x86-64/Linux
with profiled bootstrap and another instance of the infamous webizer bug,
whereby a REG_EQUAL note for a dead pseudo-register ends up creating an insn
that wrongly zeroes another pseudo-register.
The origin is fwprop1:
Thomas Koenig wrote:
One thing that you can do is to change this to
+ if (unlikely(source->base_addr == NULL))
+ return NULL;
to minimize the runtime impact.
As Jakub already wrote in his reply, the middle end already assumes the
condition as unlikely.
(The middle end always does so for "==
Hi Janus,
after Tobias' approval, two remarks:
One thing that you can do is to change this to
+ if (unlikely(source->base_addr == NULL))
+return NULL;
to minimize the runtime impact.
As for a test case, a lot of test cases in class_optional_2.f90
are commented out. Some of these could p
Janus Weil wrote:
here is a close-to-obvious patch which should fix the occasional
failures of class_optional_2.f90 in the testsuite.
Thanks!
On second thought, I decided to move this check inside of
internal_pack. While this can potentially decrease performance (due to
the additional functio
On 6 Feb 2013, at 17:20, Jack Howarth wrote:
> On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote:
>> Hi Jack,
>>
>> Thanks for having a look at this.
>>
>> However I don't understand why you need this:
>>
>> Index: gcc/config/i386/darwin.h
>> =
On Wed, Feb 06, 2013 at 05:37:12PM +0100, Patrick Marlier wrote:
> Hi Jack,
>
> Thanks for having a look at this.
>
> However I don't understand why you need this:
>
> Index: gcc/config/i386/darwin.h
> ===
> --- gcc/config/i386/darw
On Fri, Dec 07, 2012 at 10:31:57AM -0500, Diego Novillo wrote:
>On Thu, Dec 6, 2012 at 1:12 PM, Bernhard Reutner-Fischer
> wrote:
>
>> def IsComment(line):
>>"""Return True if line is a comment."""
>> - return line.startswith('#')
>> + return bool(re.matches("#", line))
>
>startswith() is a
On Wed, Feb 6, 2013 at 11:42 AM, Simon Baldwin wrote:
> Ignore r194995 for gcc pr55852.
>
> Okay for google/gcc-4_7 branch? Thanks.
OK.
Diego.
Ignore r194995 for gcc pr55852.
Okay for google/gcc-4_7 branch? Thanks.
Index: contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail
===
--- contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail (revision
195808)
+++ c
Hi Jack,
Thanks for having a look at this.
However I don't understand why you need this:
Index: gcc/config/i386/darwin.h
===
--- gcc/config/i386/darwin.h (revision 195764)
+++ gcc/config/i386/darwin.h (working copy)
@@ -131,8 +131,7
On Wed, Feb 06, 2013 at 04:30:41PM +0100, Janus Weil wrote:
> internal_pack. While this can potentially decrease performance (due to
> the additional function call, which I hope is negligible), it ensures
You mean comparison + conditional jump (predicted unlikely to jump).
> that this check is re
On Wed, Feb 6, 2013 at 7:44 AM, Jack Howarth wrote:
> On Wed, Feb 06, 2013 at 07:36:06AM -0800, Ian Lance Taylor wrote:
>> On Wed, Feb 6, 2013 at 7:14 AM, Alexander Potapenko
>> wrote:
>> >
>> > I understand and fully support your desire for intra-module ctor/dtor
>> > priority.
>> > My comment
On Wed, Feb 06, 2013 at 07:36:06AM -0800, Ian Lance Taylor wrote:
> On Wed, Feb 6, 2013 at 7:14 AM, Alexander Potapenko wrote:
> >
> > I understand and fully support your desire for intra-module ctor/dtor
> > priority.
> > My comment was meant to reply to Mike (sorry for top-posting it,
> > again
On Wed, Feb 6, 2013 at 7:14 AM, Alexander Potapenko wrote:
>
> I understand and fully support your desire for intra-module ctor/dtor
> priority.
> My comment was meant to reply to Mike (sorry for top-posting it,
> again), who, as far as I understood him, wanted to see full
> init_priority support
On Wed, Feb 06, 2013 at 07:14:07PM +0400, Alexander Potapenko wrote:
> > Alexander,
> >I never claimed full init priority support however FSF gcc on darwin
> > currently
> > has no init priority support at all. Since Mike wanted to sort the
> > destructors as
> > well as the constructors and
Hi all,
here is a close-to-obvious patch which should fix the occasional
failures of class_optional_2.f90 in the testsuite.
The problem was that we call _gfortran_internal_pack on an array
descriptor for a non-existent array. This can happen, for example,
when passing a NULL array pointer to an o
> Alexander,
>I never claimed full init priority support however FSF gcc on darwin
> currently
> has no init priority support at all. Since Mike wanted to sort the
> destructors as
> well as the constructors and this achieves usable intra-module init priority
> support
> for FSF gcc darwin,
On Wed, Feb 6, 2013 at 4:07 PM, Michael Matz wrote:
> Hi,
>
> On Wed, 6 Feb 2013, Richard Biener wrote:
>
>> realloc can also effectively free memory. But the above no longer
>> considers free () a freeing call as well?!
>
> free is not ECF_LEAF, so is handled correctly, like tm_free. I didn't
>
Hi,
On Wed, 6 Feb 2013, Richard Biener wrote:
> realloc can also effectively free memory. But the above no longer
> considers free () a freeing call as well?!
free is not ECF_LEAF, so is handled correctly, like tm_free. I didn't
consider realloc, it's indeed not handled.
> That said, please
On Wed, Feb 06, 2013 at 06:23:50PM +0400, Alexander Potapenko wrote:
> I can't see how full init_priority support can work without proper aid
> from ld and/or the dynamic linker. According to the Apple people,
> those don't treat the cross-module priorities properly, so there's
> little that can be
On Wed, Feb 6, 2013 at 3:20 PM, Michael Matz wrote:
> Hi,
>
> On Wed, 6 Feb 2013, Jakub Jelinek wrote:
>
>> First of all, I'd use gimple_call_builtin_p (call, BUILT_IN_NORMAL)
>> test. And, the function should certainly conservatively return false
>> for all builtins that aren't (gimple_call_flag
I can't see how full init_priority support can work without proper aid
from ld and/or the dynamic linker. According to the Apple people,
those don't treat the cross-module priorities properly, so there's
little that can be done on the compiler side.
On Mon, Feb 4, 2013 at 11:39 PM, Mike Stump wro
Hi,
On Wed, 6 Feb 2013, Jakub Jelinek wrote:
> First of all, I'd use gimple_call_builtin_p (call, BUILT_IN_NORMAL)
> test. And, the function should certainly conservatively return false
> for all builtins that aren't (gimple_call_flags (call) & ECF_LEAF) != 0,
> otherwise they might call hook
The attached patch eliminates the failure of the libitm.c++/eh-1.C execution
test on darwin10
and later, PR55693. With the introduction of c++ weak-symbol coalescing in Mac
OS X 10.6, dyld no
longer looks up weak symbols that reside in object files rather than shared
libraries. This prevents
On Wed, Feb 06, 2013 at 02:45:10PM +0100, Michael Matz wrote:
> @@ -1329,20 +1337,53 @@ add_or_mark_expr (basic_block bb, tree e
> }
> }
>
> +/* Return true when CALL is a call stmt that definitely doesn't
> + free any memory or makes it unavailable otherwise. */
> +static bool
> +nonfre
Hi,
marking of non-trapping accesses currently has an issue when there's a
call between the dominated and the dominating access (that makes the
former non-trapping), namely when that call frees the accessed memory (or
makes it unavailable via other means).
Instead of a full-blown algorithm ite
My PR54131 fix caused PR54009 to raise its ugly head again. Allowing
all LO_SUM addresses in the 'Y' constraint (mem_operand_gpr) wasn't
quite correct. We still need to check for wrap when offsetting for
multiple words/regs. Fixing that means the LO_SUM addresses not
accepted by 'Y' need an addr
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied.
Richard.
2013-02-06 Richard Biener
* tracer.c (tracer): Mark loops with LOOPS_NEED_FIXUP
instead of calling fix_loop_structure.
Index: gcc/tracer.c
=
This implements the front-end part of pragma No_Inline, which makes it possible
for the programmer to suppress inlining on a finer-grained basis than
-fno-inline. This pragma is strictly equivalent to the "noinline" attribute
supported by the C family of compilers.
The interaction with the other
Use a simple lock when updating the base values (ticks, time, clock).
Tested on x86_64-pc-linux-gnu, committed on trunk
2013-02-06 Pascal Obry
* s-osprim-mingw.adb (Clock): Make sure we copy all data locally
to avoid interleaved modifications that could happen from another
This patch adds a missing case to the accessibility mechanism. The machinery
can now recognize a rewritten interface conversion and properly extract the
level of the operand.
-- Source --
-- types.ads
package Types is
type Iface is limited interface;
type Any_Ifa
> > Did you check that this patch also works fine with mingw64? This is the
> > main environment now used, so it's important to verify that these changes
> > are compatible with both mingw32 and mingw64.
> I'm only able ot test for mingw64 at the moment as you see above,
> x86_64-w64-mingw32 is min
This is the front-end implementation of the new Loop_Optimize pragma, which
makes it possible for the programmer to control the optimizations applied to
loops on an individual basis.
Tested on x86_64-pc-linux-gnu, committed on trunk
2013-02-06 Eric Botcazou
* snames.ads-tmpl (Name_Loo
When gnatmake is invoked with a project file, gnatbind is no longer
invoked by gnatmake with -I-. The test is to invoke gnatmake with
a project file: gnatbind should not be invoked with -I-.
Tested on x86_64-pc-linux-gnu, committed on trunk
2013-02-06 Vincent Celier
* make.adb (Gnatma
Removes the access to all variables. This was put in place to workaround
a limitation of the linker auto-import support which was not able to
handle works lager than 32 bits.
Tested on x86_64-pc-linux-gnu, committed on trunk
2013-02-06 Pascal Obry
* s-osprim-mingw.adb: Removes workaro
Hi!
use_pointer_for_field in some cases returns true to avoid copy-in/out,
which results in the address of the decl being passed around instead of
the decl itself.
But for RESULT_DECL or PARM_DECL of REFERENCE_TYPE we generate only
copy-in, not copy-out (as references can't change), so there is no
This patch corrects the decoration of type attribute Has_Unknown_Discriminants
when building the full view of a private subtype.
-- Source --
-- root.ads
package Root is
end Root;
-- root-scopes.ads
package Root.Scopes is
type Scope_T is interface;
function Sc
> I like to have this in trunk as soon as possible, because I want to backport
> to 4.7.3 before the release.
>
> Tested on x86_64-w64-mingw32 and x86_64-unknown-gnu-linux.
Did you check that this patch also works fine with mingw64? This is the main
environment now used, so it's important to veri
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I like to have this in trunk as soon as possible, because I want to backport
to 4.7.3 before the release.
Tested on x86_64-w64-mingw32 and x86_64-unknown-gnu-linux.
Cheers
Rainer
Am 03.01.2013 14:06, schrieb Rainer Emrich:
> Hello,
>
> this trivia
We introduce the profile Rational and the corresponding pragma to support
legacy Rational code that accepts subprogram renaming declarations that are
not conformant to the RM.
The following program, compiled with -gnatc, must generate the message:
ren.ads:12:51: subprogram cannot rename itself
On assignments to tagged types the compiler unconditionally generates
the runtime check of the tag (even when compiling with -gnatp). After
this patch such extra runtime check is not generated.
package Test is
type Tagged_Simple_Record is tagged
record
Field1 : Integer;
end
This patch suppresses the resolution of the prefix of attribute Loop_Entry. The
resolution still takes place after Loop_Entry has been transformed into the
initialization expression of a constant. The delay ensures that any generated
checks or temporaries are inserted before the relocated prefix.
The frontend was unconditionally generating a read reference for OUT
parameters. After this patch the compiler generates the read reference
only for those cases specified by RM 6.4.1(12).
package Pkg is
procedure Write (I : out Integer);
procedure Update (I : in out Integer);
end Pkg;
package
Finalization of temporary controlled function results in expression with
actions nodes in the context of return statements:
This patch adds logic to recognize a simple return statement as one of the
cases that require special processing with respect to temporary controlled
function results that ap
> Now that I understand fully what we're trying to accomplish with the
> DT_OP_GNU_entry_value and DT_OP_GNU_call_site_parameter extensions, it
> does in fact seem like we will need to do leaf register remapping in
> var-tracking.c
>
> Here below is a patch I'm playing with. It's a rough draft bu
This patch adds machinery to properly finalize temporary controlled function
results that appear in N_Expression_With_Actions nodes as well as case and if
expressions. In general, such temporaries must be finalized after the related
context is elaborated/evaluated.
-- Source --
--
Hi,
this patch fixes an issue about recursice LN_S for mingw-host. The
issue was already addressed by autotools, but an upgrade of version
isn't suitable right now.
For further information see the bug-report PR 52122.
ChangeLog libada/
PR target/52122
* Makefile.in (LN_S_RECUSIV
The specification for N_Pragma nodes requires that all pragma arguments
by represented by N_Pragma_Associatin nodes, but in several cases naked
expressions appeared. This patch corrects this irregularity, and also
cleans up the format of Make_Pragma calls throughout these files. This
was noticed du
This couple of adjustments paves the way for the full coordination of Pragma
Warnings with the warnings issued by the diagnostic engine of the middle-end.
Tested on x86_64-pc-linux-gnu, committed on trunk
2013-02-06 Eric Botcazou
* erroutc.adb (Validate_Specific_Warning): Do not issue
On 12/18/12 13:33, Kyrylo Tkachov wrote:
Hi all,
This patch adds support for the vectorisation of the rounding functions:
floorf, ceilf, truncf, roundf. These can be implemented using the ARMv8 NEON
instructions: vrintm, vrintp, vrintz, vrinta.
This is done by defining the TARGET_VECTORIZE_BUILT
On 12/18/12 13:33, Kyrylo Tkachov wrote:
Hi all,
This patch does some refactoring by moving the definitions of the NEON
builtins to a separate file (arm_neon_builtins.def) and includes that when
initialising the neon_builtin_data array and also during
the definition of enum arm_builtins (with ap
Would someone mind having a look at this.
On 01/29/2013 03:38 PM, Sebastian Huber wrote:
2013-01-18 Sebastian Huber
* lib/target-supports.exp
(check_effective_target_powerpc_eabi_ok): New.
* gcc.target/powerpc/ppc-eabi.c: Use require effective target
powerpc_e
Paolo Carlini writes:
>> Since commit r195676[1], it looks like
>> libstdc++-v3/src/c++11/hashtable_c++0x.cc is missing an explicit
>> instantiation for std::lower_bound. This leads to libstdc++.so having
>> the symbol for that (missing) instantiation be undefined, thus
>> preventing executables
83 matches
Mail list logo
