[patch][wwwdocs] gcc 4.8 changes - AMD new cores

2013-02-13 Thread Gopalasubramanian, Ganesh
Hello, This patch adds short words about the new AMD cores that got enabled in GCC-4.8. OK for the wwwdocs? Regards Ganesh Index: gcc-4.8/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/changes.html,v retrieving

Re: [PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-13 Thread Richard Biener
On Tue, 12 Feb 2013, Marcus Shawcroft wrote: On 12 February 2013 15:38, Richard Biener rguent...@suse.de wrote: On Tue, 12 Feb 2013, Marcus Shawcroft wrote: Sorry, I'll send that again copying gcc-patches in this time... -- Forwarded message -- From: Marcus

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Andreas Schwab
) Excess errors: /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12.h:5:47: warning: target attribute is not supported on this machine [-Wattributes] /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12.h:6:46: warning: target attribute is not supported on this machine

[PATCH] Fix mn10300 compile

2013-02-13 Thread Richard Biener
The following fixes compilation of mn10300 which broke when the interface to flow_loops_find changed (as reported in a comment in PR56294). I took the liberty to use the proper interface for initializing the loop tree. Built a mn10300 cc1, committed as obvious. Richard. 2013-02-13 Richard

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 01:19:47PM +0400, Konstantin Serebryany wrote: The attached patch is the libsanitizer merge from upstream r175042. Lots of changes. Among other things: - x86_64 linux: change the shadow offset to 0x7fff8000 (~5% speedup) - the new asan allocator is enabled on Mac

Re: [Patch,avr]: Add more devices take #2: 1/2

2013-02-13 Thread Georg-Johann Lay
Let me drop this, I was thinking too complicated. src/gas/config/tc-avr.c reads: static struct mcu_type_s mcu_types[] = { {avr1, AVR_ISA_AVR1,bfd_mach_avr1}, /* TODO: insruction set for avr2 architecture should be AVR_ISA_AVR2, but set to AVR_ISA_AVR25 for some following version

[PATCH] Fix RTL unswitching loop verification ICE

2013-02-13 Thread Richard Biener
This fixes the reported ICE on arm. Similar to tree level unswitching RTL level unswitching can expose formerly irreducible regions as new loops. The following patch makes sure to discover them (we now verify we do). Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard.

Re: [Patch,avr]: Add more devices take #2: 2/2

2013-02-13 Thread Georg-Johann Lay
And here 2/2 with the device - arch mapping for gas. Ok for trunk? Johann * config/avr/avr.h (device_to_arch): Rename to device_to_ld. (avr_device_to_arch): Rename to avr_device_to_ld. (avr_device_to_as): New prototype. (EXTRA_SPEC_FUNCTIONS): Add device_to_as.

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 02:28:25PM +0400, Konstantin Serebryany wrote: Right. In LLVM we test only with ASAN_FLEXIBLE_MAPPING_AND_OFFSET==1, so this came unnoticed. Fixed in r175049. ... This is ok, thanks. Jakub

Re: expansion of vector shifts...

2013-02-13 Thread Richard Biener
On Tue, Feb 12, 2013 at 11:31 PM, David Miller da...@davemloft.net wrote: From: David Miller da...@redhat.com Date: Fri, 16 Nov 2012 00:33:05 -0500 (EST) From: Richard Sandiford rdsandif...@googlemail.com Date: Mon, 29 Oct 2012 10:14:53 + ...given that the code is like you say written:

Re: [GCC 4.8 changes] PATCH: Mention several user-visible changes for x86

2013-02-13 Thread Igor Zamyatin
Please also mention new -mfxsr, -mxsave and -mxsaveopt options. li New built-in functions to detect run-time CPU type and ISA: ul liA built-in function code__builtin_cpu_is/code has been added to *** *** 524,529 --- 530,538 a

Re: [GCC 4.8 changes] PATCH: Mention several user-visible changes for x86

2013-02-13 Thread Uros Bizjak
On Wed, Feb 13, 2013 at 12:17 PM, Igor Zamyatin izamya...@gmail.com wrote: Please also mention new -mfxsr, -mxsave and -mxsaveopt options. li New built-in functions to detect run-time CPU type and ISA: ul liA built-in function code__builtin_cpu_is/code has been added to

Re: [PATCH] Fix RTL unswitching loop verification ICE

2013-02-13 Thread Marcus Shawcroft
On 13 February 2013 10:11, Richard Biener rguent...@suse.de wrote: This fixes the reported ICE on arm. Similar to tree level unswitching RTL level unswitching can expose formerly irreducible regions as new loops. The following patch makes sure to discover them (we now verify we do).

Re: FW: [PATCH] [MIPS] microMIPS gcc support

2013-02-13 Thread Richard Sandiford
Moore, Catherine catherine_mo...@mentor.com writes: Index: config/mips/mips.c == = --- config/mips/mips.c (revision 195351) +++ config/mips/mips.c (working copy) @@ -77,6 +77,9 @@ along with GCC; see the file

[PATCH] Fix PR56295, part 2

2013-02-13 Thread Richard Biener
This fixes part 2 of PR56295, it un-does MEM_REF wrapping on the writer side. Otherwise code-generation differences at compile-time appear -flto vs. -fno-lto (with fat LTO objects). LTO bootstrap regtest running on x86_64-unknown-linux-gnu. Richard. 2013-02-13 Richard Biener

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 11:32:00AM +0100, Jakub Jelinek wrote: On Wed, Feb 13, 2013 at 02:28:25PM +0400, Konstantin Serebryany wrote: Right. In LLVM we test only with ASAN_FLEXIBLE_MAPPING_AND_OFFSET==1, so this came unnoticed. Fixed in r175049. ... This is ok, thanks. Unfortunately,

[PATCH] Fix PR50494

2013-02-13 Thread Richard Biener
This should fix PR50494 - when we gimplify a local initializer via a block copy and emit a constant to the constant pool we stream the representative VAR_DECL with LTO, including its eventually changed alignment. When we then lookup RTL for this constant at /* If this variable belongs to the

[Patch, Fortran, Committed] PR testsuite/56082 / PR fortran/56304 (libquad) Test-case fixes

2013-02-13 Thread Tobias Burnus
I have committed a fix for PR 56082, where the test case assumed that C_Bool is a byte wide (kind=1); however, on 32bit Darwin, C_Bool is by default an int (kind=4) – hence, a warning is not printed. The change was to use logical(kind=2) for the example, assuming C_Bool is never kind=2.

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Konstantin Serebryany
On Wed, Feb 13, 2013 at 3:59 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 11:32:00AM +0100, Jakub Jelinek wrote: On Wed, Feb 13, 2013 at 02:28:25PM +0400, Konstantin Serebryany wrote: Right. In LLVM we test only with ASAN_FLEXIBLE_MAPPING_AND_OFFSET==1, so this came

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 04:32:33PM +0400, Konstantin Serebryany wrote: Unfortunately, it seems everything fails with that change :( on Linux. The problem is that the default prelink library range for x86_64 is 0x30LL to 0x40LL, and that unfortunately overlaps Forgive my

Re: [patch][wwwdocs] gcc 4.8 changes - AMD new cores

2013-02-13 Thread Mikael Morin
Le 13/02/2013 09:32, Gopalasubramanian, Ganesh a écrit : +liSupport for new AMD family 16h processors (Jaguar core) is now available + through code-march=btver2/code and code-mtune=btver2/code options./li s/btver2/bdver2/ ?

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Konstantin Serebryany
On Wed, Feb 13, 2013 at 4:48 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:32:33PM +0400, Konstantin Serebryany wrote: Unfortunately, it seems everything fails with that change :( on Linux. The problem is that the default prelink library range for x86_64 is

Re: [patch][wwwdocs] gcc 4.8 changes - AMD new cores

2013-02-13 Thread Richard Biener
On Wed, Feb 13, 2013 at 1:55 PM, Mikael Morin mikael.mo...@sfr.fr wrote: Le 13/02/2013 09:32, Gopalasubramanian, Ganesh a écrit : +liSupport for new AMD family 16h processors (Jaguar core) is now available + through code-march=btver2/code and code-mtune=btver2/code options./li

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 04:57:30PM +0400, Konstantin Serebryany wrote: On Wed, Feb 13, 2013 at 4:48 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:32:33PM +0400, Konstantin Serebryany wrote: Unfortunately, it seems everything fails with that change :( on Linux. The

Re: [patch][wwwdocs] gcc 4.8 changes - AMD new cores

2013-02-13 Thread Mikael Morin
Le 13/02/2013 14:00, Richard Biener a écrit : Of course not. Next they'll add blver ... Sorry

[AArch64-4.7] Backport: Implement section anchors

2013-02-13 Thread James Greenhalgh
Hi, This patch is a backport of the section anchors support introduced to aarch64-branch here: http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00384.html The patch has been tested for aarch64-none-elf with only a known regression, fixed by backporting this patch by Andrew Pinski:

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Richard Biener
On Wed, Feb 13, 2013 at 2:07 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:57:30PM +0400, Konstantin Serebryany wrote: On Wed, Feb 13, 2013 at 4:48 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:32:33PM +0400, Konstantin Serebryany wrote:

Re: [AArch64-4.7] Backport: Implement section anchors

2013-02-13 Thread Marcus Shawcroft
On 13 February 2013 13:26, James Greenhalgh james.greenha...@arm.com wrote: Hi, This patch is a backport of the section anchors support introduced to aarch64-branch here: http://gcc.gnu.org/ml/gcc-patches/2012-09/msg00384.html The patch has been tested for aarch64-none-elf with only a

[AArch64-4.7] Backport: Fix g++.dg/abi/aarch64_guard1.C

2013-02-13 Thread James Greenhalgh
Hi, If we enable section anchors by default we must fix the ABI testcase which is not expecting section anchors. This was fixed by Andrew Pinski on trunk here: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00580.html So we backport that fix. I've tested this with no regressions on

Re: [AArch64-4.7] Backport: Fix g++.dg/abi/aarch64_guard1.C

2013-02-13 Thread Marcus Shawcroft
On 13 February 2013 13:28, James Greenhalgh james.greenha...@arm.com wrote: Hi, If we enable section anchors by default we must fix the ABI testcase which is not expecting section anchors. This was fixed by Andrew Pinski on trunk here:

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 02:27:56PM +0100, Richard Biener wrote: ASAN could set an ELF flag on the executable to tell the kernel not to use prelinked objects? That is, similar to how we handle executable stacks? But we don't have such a flag right now, and what should old kernels that don't

[PATCH,ARM] Peephole individual LDR/STD into LDRD/STRD

2013-02-13 Thread Greta Yorsh
This patch defines peephole2 patterns that merge two individual LDR instructions into LDRD instruction (resp. STR into STRD) whenever possible using the following transformations: * reorder two memory accesses, * rename registers when storing two constants, and * reorder target registers of a load

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Konstantin Serebryany
On Wed, Feb 13, 2013 at 5:07 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:57:30PM +0400, Konstantin Serebryany wrote: On Wed, Feb 13, 2013 at 4:48 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 04:32:33PM +0400, Konstantin Serebryany wrote:

Re: [Patch, Fortran, Committed] PR testsuite/56082 / PR fortran/56304 (libquad) Test-case fixes

2013-02-13 Thread Janus Weil
Hi Tobias, since you're fixing test cases: What about PR 55852 comment 10? The test case fails because the match is too strict. $ grep iszs intrinsic_size_3.f90.003t.original integer(kind=2) iszs; iszs = (integer(kind=2)) MAX_EXPR (D.854-dim[0].ubound - D.854-dim[0].lbound) + 1, 0;

C++ PATCH for c++/56135 (wrong 'this' capture)

2013-02-13 Thread Jason Merrill
When the only use of 'this' is implicitly by a dependent name, we don't see the capture until instantiation time. Don't clobber its capture list entry when we instantiate the ones seen at template definition time. Tested x86_64-pc-linux-gnu, applying to trunk. commit

C++ PATCH for c++/56155 (wrong type for enumerator)

2013-02-13 Thread Jason Merrill
Within the { } of an enum-specifier with a fixed underlying type, the enumerators are supposed to have that type. A comment in build_enumerator mentioned that requirement, but nothing actually implemented it. Tested x86_64-pc-linux-gnu, applying to trunk. commit

C++ PATCH for c++/55993 (wrong error with constexpr)

2013-02-13 Thread Jason Merrill
When we added empty base handling to the ADDR_EXPR case in cxx_fold_indirect_ref, we forgot to add it to the POINTER_PLUS_EXPR case as well. Tested x86_64-pc-linux-gnu, applying to trunk. commit ed30015624f7d3f396e11fd5d96b548348a74688 Author: Jason Merrill ja...@redhat.com Date: Tue Feb 12

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-13 Thread Jason Merrill
On 02/12/2013 07:55 AM, Paolo Carlini wrote: Again, the current status is in a sense good because when the _GLIBCXX_HAVE_AT_QUICK_EXIT and _GLIBCXX_HAVE_QUICK_EXIT are defined, thus the system has the functions in its c library, including cstdlib makes available the functions in namespace std

[Patch] Cleanup gcc.target/arm/interrupt-*.c for thumb mode

2013-02-13 Thread Greta Yorsh
The tests gcc.target/arm/interrupt-*.c are for ARM mode only. This patch uses effective target arm_notthumb instead of __thumb_ predefine, removes unreachable code, and fixes typos. Ok for trunk? Thanks, Greta ChangeLog gcc/testsuite/ 2012-02-13 Greta Yorsh greta.yo...@arm.com *

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jack Howarth
On Wed, Feb 13, 2013 at 11:32:00AM +0100, Jakub Jelinek wrote: On Wed, Feb 13, 2013 at 02:28:25PM +0400, Konstantin Serebryany wrote: Right. In LLVM we test only with ASAN_FLEXIBLE_MAPPING_AND_OFFSET==1, so this came unnoticed. Fixed in r175049. ... This is ok, thanks. Jakub

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-13 Thread Paolo Carlini
Hi, On 02/13/2013 03:38 PM, Jason Merrill wrote: On 02/12/2013 07:55 AM, Paolo Carlini wrote: Again, the current status is in a sense good because when the _GLIBCXX_HAVE_AT_QUICK_EXIT and _GLIBCXX_HAVE_QUICK_EXIT are defined, thus the system has the functions in its c library, including

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 05:39:15PM +0400, Konstantin Serebryany wrote: No. You can disable it for the whole system (prelink -ua), but that is not a sane requirement to running sanitized programs. Why not? :) Because that is a fully system operation, requires root access, etc. The fact

[PATCH] For asm n and similar constraints use maybe_const_value (PR c++/56302)

2013-02-13 Thread Jakub Jelinek
Hi! My SIZEOF_EXPR deferred folding changes regressed some sys/sdt.h macros at -O0, the sizeof in there is no longer folded, so instead of say n (-8) we ended up with n (-1 * (int) sizeof (void *)) and similar, and as at -O0 we don't really optimize, the asm got rejected. Fixed thusly,

[PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Jakub Jelinek
Hi! As agreed on in the PR, here is the revertion of 3 commits, so that PCH works again for -gstabs and other debug info formats for 4.8 release. For 4.9 we should either remove support for anything non-DWARF, or hope somebody steps up and fixes dbxout.c etc. not to emit debug info right away,

Re: [PATCH] For asm n and similar constraints use maybe_const_value (PR c++/56302)

2013-02-13 Thread Jason Merrill
OK.

[committed] Revert 0x7fff8000 shadow offset for now

2013-02-13 Thread Jakub Jelinek
Hi! So that we don't keep GCC trunk in known broken state, I've bootstrapped/regtested this change and installed it. 2013-02-13 Jakub Jelinek ja...@redhat.com * config/i386/i386.c (ix86_asan_shadow_offset): Revert last change. * asan/asan_mapping.h (SHADOW_OFFSET): Set to

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jack Howarth
On Wed, Feb 13, 2013 at 04:19:14PM +0100, Jakub Jelinek wrote: The reexec is problematic, what if the program already in constructors run before __asan_init (perhaps ctors of other libraries etc.) does something that really shouldn't be done twice? Jakub, Wouldn't sorting all of the

C++ PATCH for c++/55879 (constexpr confusion with invisible references)

2013-02-13 Thread Jason Merrill
In this PR, the constexpr evaluator was confused by a parameter that changed to a reference type after the constant expression body was saved for later evaluation; we ended up trying to evaluate an address of an address, since we added one address on the caller side to pass to the invisible

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-13 Thread Aldy Hernandez
Richard. I made all the changes you suggested. I also changed other instances of s/this_target_optabs/this_fn_optabs/ which I forgot in the previous iteration. And I also changed save_optabs_if_changed() to use this_fn_optabs, since init_all_optabs() will generate the optabs into

patch to fix PR56184

2013-02-13 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56184 The problem was in that reg equiv was not corrected for a split pseudo because of incorrect code for recognition of situation when a split pseudo was created. The patch was successfully bootstrapped and tested on

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-13 Thread Richard Sandiford
Aldy Hernandez al...@redhat.com writes: Richard. I made all the changes you suggested. I also changed other instances of s/this_target_optabs/this_fn_optabs/ which I forgot in the previous iteration. And I also changed save_optabs_if_changed() to use this_fn_optabs, since

[PATCH] : Fix for PR 52123 additional patch for 32bit mingw

2013-02-13 Thread Rainer Emrich
Here's a simple additional patch against trunk for 32bit mingw. OK to apply? Rainer 2013-02-13 Rainer Emrich rai...@emrich-ebersheim.de PR target/52123 * tracebak.c: Cast from pointer via FARPROC Index: ada/tracebak.c

Re: [PATCH] : Fix for PR 52123 additional patch for 32bit mingw

2013-02-13 Thread Arnaud Charlet
Here's a simple additional patch against trunk for 32bit mingw. OK to apply? OK, thanks. Rainer 2013-02-13 Rainer Emrich rai...@emrich-ebersheim.de PR target/52123 * tracebak.c: Cast from pointer via FARPROC

Re: patch to fix PR56184

2013-02-13 Thread Jeff Law
On 02/13/13 10:44, Vladimir Makarov wrote: The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56184 The problem was in that reg equiv was not corrected for a split pseudo because of incorrect code for recognition of situation when a split pseudo was created. The patch was

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-13 Thread Aldy Hernandez
Sorry, just noticed: + /* If the optabs changed, record it in the node. */ + if (memcmp (tmp_target_optabs, default_target_optabs, + sizeof (struct target_optabs))) This should be this_target_optabs rather than default_target_optabs. Nothing but target code and initialisers

[PATCH] : Fix for PR 52123 backport for gcc-4.7.3

2013-02-13 Thread Rainer Emrich
Backport to 4.7.3, tested on i686-w64-mingw32, x86_64-w64-mingw32 and x86_64-unknown-gnu-linux. OK to apply? Rainer 2013-02-13 Rainer Emrich rai...@emrich-ebersheim.de PR target/52123 * adaint.c (__gnat_check_OWNER_ACL): Cast from pointer via SECURITY_DESCRIPTOR *

Re: [PATCH] : Fix for PR 52123 backport for gcc-4.7.3

2013-02-13 Thread Arnaud Charlet
Backport to 4.7.3, tested on i686-w64-mingw32, x86_64-w64-mingw32 and x86_64-unknown-gnu-linux. OK to apply? OK 2013-02-13 Rainer Emrich rai...@emrich-ebersheim.de PR target/52123 * adaint.c (__gnat_check_OWNER_ACL): Cast from pointer via SECURITY_DESCRIPTOR *

C++ PATCH for c++/55720 (link error with lambda conversion)

2013-02-13 Thread Jason Merrill
Most of the G++ linkage code really needs to be torn out in favor of just using cgraph. Until that happens, we need to set TREE_USED here so that decl_needed_p will return true and allow cgraph to consider the function. Tested x86_64-pc-linux-gnu, applying to trunk and 4.7. commit

Re: expansion of vector shifts...

2013-02-13 Thread David Miller
From: Richard Biener richard.guent...@gmail.com Date: Wed, 13 Feb 2013 12:15:13 +0100 On Tue, Feb 12, 2013 at 11:31 PM, David Miller da...@davemloft.net wrote: Maybe what we really mean to do here is check both op1 and SUBREG_REG (op1) against SCALAR_INT_MODE_P instead of INTEGRAL_MODE_P?

Re: [Patch, Fortran] Remove the Fortran-only flag -fno-whole-file

2013-02-13 Thread Tobias Burnus
*** PING *** I think it is now a bit late for 4.8. Thus, I change my request to: OK for the 4.9 trunk? Tobias On January 5, 2013 00:31, Tobias Burnus wrote: This patch removes -fno-whole-file. (Actually, it turns it into Ignore.) Reasoning: * -fwhole-file/-fno-whole-file was added in

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Jeff Law
On 02/13/13 08:54, Jakub Jelinek wrote: Hi! As agreed on in the PR, here is the revertion of 3 commits, so that PCH works again for -gstabs and other debug info formats for 4.8 release. For 4.9 we should either remove support for anything non-DWARF, or hope somebody steps up and fixes dbxout.c

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread H.J. Lu
On Wed, Feb 13, 2013 at 1:19 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: Hi, The attached patch is the libsanitizer merge from upstream r175042. Lots of changes. Among other things: - x86_64 linux: change the shadow offset to 0x7fff8000 (~5% speedup) - the new asan

Re: [PATCH][C++11][ PR55582] Let string literals starting with lower-case 's' be a user-defined literal instead of string + macro.

2013-02-13 Thread Jason Merrill
I just noticed this patch. Since it was submitted well before the end of stage 3 and looks quite safe, it's OK to go in for 4.8. Please remember to CC/ping me for C++ patches. Thanks, Jason

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Sriraman Tallam
. +// { dg-do compile } + +#include mv12.h + +__attribute__ ((target (sse4.2))) +int foo () FAIL: g++.dg/ext/mv12-aux.C -std=c++11 (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20130213/gcc/testsuite/g++.dg/ext/mv12.h:5:47: warning: target attribute is not supported

[PATCH] Small asan improvement

2013-02-13 Thread Jakub Jelinek
Hi! This is just a small improvement for Dodji's work. We can flush the hash table with memory references known to be instrumented only at extended basic block boundaries, no need to flush it at every bb (of course, for 4.9 we want to do something better). And, now that we have

Re: [patch, Fortran] Fix PR 56224

2013-02-13 Thread Thomas Koenig
*ping* I'd like to get this into 4.8 before release. This version of the patch should fix that particular issue, and also has no test cases. Regression-tested. OK? I can leave out the FIXME if people object. Thomas

Re: [Patch, Fortran] Remove the Fortran-only flag -fno-whole-file

2013-02-13 Thread Steve Kargl
On Wed, Feb 13, 2013 at 07:20:10PM +0100, Tobias Burnus wrote: *** PING *** I think it is now a bit late for 4.8. Thus, I change my request to: OK for the 4.9 trunk? IMHO, yes. Don't know if others have an opinion, but waiting any longer would seem to be counter productive. -- Steve

Re: [patch, Fortran] Fix PR 56224

2013-02-13 Thread Tobias Burnus
Thomas Koenig wrote: *ping* * pong * I'd like to get this into 4.8 before release. Others as well, given that it is a release-blocking P1 regression … However, I have already approved it: http://gcc.gnu.org/ml/fortran/2013-02/msg00061.html Tobias

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Diego Novillo
On Tue, Feb 12, 2013 at 2:47 PM, Lawrence Crowl cr...@google.com wrote: @@ -182,24 +163,9 @@ default_emutls_var_init (tree to, tree d static tree get_emutls_object_type (void) { - tree type, type_name, field; - - type = emutls_object_type; - if (type) -return type; - -

Keep the macro complex in C++03

2013-02-13 Thread Marc Glisse
Hello, this patch was tested on x86_64-linux-gnu. For the testcase, I randomly picked c99.cc which I copied and c++11 - c++98, _Complex - complex, but anything using the macro would do. 2013-02-13 Marc Glisse marc.gli...@inria.fr PR libstdc++/56111 * include/std/complex

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 12:07:52PM -0600, Aldy Hernandez wrote: Sorry, just noticed: + /* If the optabs changed, record it in the node. */ + if (memcmp (tmp_target_optabs, default_target_optabs, + sizeof (struct target_optabs))) This should be this_target_optabs rather than

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Lawrence Crowl
On 2/13/13, Diego Novillo dnovi...@google.com wrote: On Tue, Feb 12, 2013 at 2:47 PM, Lawrence Crowl cr...@google.com wrote: @@ -182,24 +163,9 @@ default_emutls_var_init (tree to, tree d static tree get_emutls_object_type (void) { - tree type, type_name, field; - - type =

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 11:23:24AM -0700, Jeff Law wrote: On 02/13/13 08:54, Jakub Jelinek wrote: That looks just like the patch I have here. Yet, I'm still seeing failures: Running target unix/-m32/-gstabs Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Diego Novillo
Thanks. The patch is OK for the branch. You can address Nathan's review after he's back and gets a chance to look at it. Let me know when the patch is in. I've got another merge in process. Diego.

Re: libsanitizer merge from upstream r175042

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 11:48:32AM -0500, Jack Howarth wrote: On Wed, Feb 13, 2013 at 04:19:14PM +0100, Jakub Jelinek wrote: The reexec is problematic, what if the program already in constructors run before __asan_init (perhaps ctors of other libraries etc.) does something that really

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 10:57:42AM -0800, Sriraman Tallam wrote: I committed a trivial patch to fix this problem. mv12-aux.C is auxiliary to mv12.C and should have the same test directives as mv12.C. 2013-02-13 Sriraman Tallam tmsri...@google.com * g++.dg/ext/mv12-aux.C: Add

[PATCH] [asan] Fix a thinko leading to a crash

2013-02-13 Thread Dodji Seketeli
Hello, It appeared that in my previous patch, a stupid thinko can lead to a crash when instrumenting some builtin functionsK. Fixed thus. Tested against trunk on x86_64-unknown-linux-gnu, and a bootstrap is underway. gcc/ * asan.c (instrument_builtin_call): Really put the length of

Re: [PATCH] Small asan improvement

2013-02-13 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: This is just a small improvement for Dodji's work. We can flush the hash table with memory references known to be instrumented only at extended basic block boundaries, no need to flush it at every bb (of course, for 4.9 we want to do something better).

Re: [PATCH] [asan] Fix a thinko leading to a crash

2013-02-13 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 09:37:42PM +0100, Dodji Seketeli wrote: Hello, It appeared that in my previous patch, a stupid thinko can lead to a crash when instrumenting some builtin functionsK. Fixed thus. Tested against trunk on x86_64-unknown-linux-gnu, and a bootstrap is underway. gcc/

Re: [patch] fix libstdc++/56278

2013-02-13 Thread François Dumont
Committed then. 2013-02-13 François Dumont fdum...@gcc.gnu.org * include/bits/hashtable_policy.h (_Hash_code_base): Restore default constructor protected. * include/bits/hashtable.h: static assert that _Hash_code_base has a default constructor available through inheritance.

Re: Keep the macro complex in C++03

2013-02-13 Thread Paolo Carlini
Hi, 2013-02-13 Marc Glisse marc.gli...@inria.fr PR libstdc++/56111 * include/std/complex (complex): Undefine. * include/c_compatibility/complex.h (complex): Only undefine if complex has been included. * testsuite/26_numerics/complex/56111.cc: New testcase.

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Steven Bosscher
On Wed, Feb 13, 2013 at 4:54 PM, Jakub Jelinek wrote: Hi! As agreed on in the PR, here is the revertion of 3 commits, so that PCH works again for -gstabs and other debug info formats for 4.8 release. For 4.9 we should either remove support for anything non-DWARF, or hope somebody steps up

Re: [PING^5] PR 54805: __gthread_tsd* in vxlib-tls.c

2013-02-13 Thread rbmj
On 18-Jan-13 20:35, Maxim Kuvyrkov wrote: On 19/01/2013, at 9:18 AM, rbmj wrote: -150,7 +158,7 @@ static __gthread_once_t tls_init_guard = need to read tls_keys.dtor[key] atomically. */ static void -tls_delete_hook (void *tcb ATTRIBUTE_UNUSED) +tls_delete_hook (void *tcb) Don't

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread David Edelsohn
The AIX system supports DWARF debugging, but GCC does not generate it on AIX and GDB does not consume it on AIX. There is no way that I will allow experimental DWARF support to be enabled at the same time STABS support is removed. This is a non-starter. If you want to disable PCH on STABS

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Douglas B Rupp
On 02/13/2013 01:12 PM, Steven Bosscher wrote: * ix86-*-interix* - no solution immediately available, and no-one listed in MAINTAINERS to ask for help, so maybe Doug can say something about this one? Microsoft has pulled the plug on Interix, Windows 7 will be the last version of

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

2013-02-13 Thread Sriraman Tallam
On Wed, Feb 13, 2013 at 12:14 PM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Feb 13, 2013 at 10:57:42AM -0800, Sriraman Tallam wrote: I committed a trivial patch to fix this problem. mv12-aux.C is auxiliary to mv12.C and should have the same test directives as mv12.C. 2013-02-13 Sriraman

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Lawrence Crowl
On 2/13/13, Diego Novillo dnovi...@google.com wrote: Thanks. The patch is OK for the branch. You can address Nathan's review after he's back and gets a chance to look at it. Let me know when the patch is in. I've got another merge in process. Committed. -- Lawrence Crowl

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Jeff Law
On 02/13/13 13:07, Jakub Jelinek wrote: On Wed, Feb 13, 2013 at 11:23:24AM -0700, Jeff Law wrote: On 02/13/13 08:54, Jakub Jelinek wrote: That looks just like the patch I have here. Yet, I'm still seeing failures: Running target unix/-m32/-gstabs Using /usr/share/dejagnu/baseboards/unix.exp

RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-13 Thread Chao-Ying Fu
Hello All, Once in a while we got reports about programs (ex: WebKit, FireFox) crash due to ldc1/sdc1 unaligned accesses on MIPS targets. The root cause is that programmers neglect the alignment issue and cast arbitrary pointers to point to double variables. Although the correct solution

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2013-02-13 Thread Vladimir Makarov
On 13-02-07 2:11 PM, Tom de Vries wrote: Vladimir, On 25/01/13 16:36, Vladimir Makarov wrote: On 01/25/2013 08:05 AM, Tom de Vries wrote: Vladimir, this patch adds analysis of register usage of functions for usage by IRA. The patch: - adds analysis in pass_final to track which hard

Document ?: for vectors

2013-02-13 Thread Marc Glisse
Hello, today I found this patch that I had written a couple months ago, and I am wondering whether we want it for 4.8. I am tempted to keep ?: undocumented as long as the C front-end doesn't have it. The fact that very few optimizations are done on it (and some might still be broken) is

Re: RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-13 Thread Andrew Pinski
On Wed, Feb 13, 2013 at 2:14 PM, Chao-Ying Fu chao-ying...@imgtec.com wrote: Hello All, Once in a while we got reports about programs (ex: WebKit, FireFox) crash due to ldc1/sdc1 unaligned accesses on MIPS targets. The root cause is that programmers neglect the alignment issue and cast

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread John David Anglin
On 2013-02-13 3:33 PM, David Edelsohn wrote: Perhaps Dave can explain what would have to be done to move this platform to DWARF2...? I had looked at this a bit in the past. I don't think it's that difficult to add DWARF2 support to GCC on hppa. Although we don't support named

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Steven Bosscher
On Thu, Feb 14, 2013 at 12:17 AM, John David Anglin wrote: On 2013-02-13 3:33 PM, David Edelsohn wrote: Perhaps Dave can explain what would have to be done to move this platform to DWARF2...? I had looked at this a bit in the past. I don't think it's that difficult to add

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-13 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 12:41:30AM +0100, Steven Bosscher wrote: I agree with David that it might be better to give up pch. That'd be a really a good start. You can do it with say following patch instead, PCH is just a compile time optimization, so for -gstabs IMHO it is just fine if we just

[google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Hi, I have attached a patch for the reordering plugin to display appropriate error messages when incorrect options are passed or when some API is unavailable. The plugin will use the ld_plugin_message linker API to flag errors (fatal or non-fatal) when incorrect options are passed or when

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Xinliang David Li
when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at some point when the null pointer is referenced later? David On Wed, Feb 13, 2013 at 4:19 PM, Sriraman Tallam tmsri...@google.com wrote: Hi, I have attached a patch for the reordering

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote: when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at some point when the null pointer is referenced later? It cannot be referenced later as the handlers will not get

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Sriraman Tallam
Updated patch attached. Thanks Sri On Wed, Feb 13, 2013 at 4:39 PM, Sriraman Tallam tmsri...@google.com wrote: On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote: when split_segment is specified but the API does not exist, why not making it fatal ? Will it crash at

Re: [google][4.7] Minor Function reordering plugin enhancements.

2013-02-13 Thread Xinliang David Li
ok. thanks, David On Wed, Feb 13, 2013 at 4:41 PM, Sriraman Tallam tmsri...@google.com wrote: Updated patch attached. Thanks Sri On Wed, Feb 13, 2013 at 4:39 PM, Sriraman Tallam tmsri...@google.com wrote: On Wed, Feb 13, 2013 at 4:32 PM, Xinliang David Li davi...@google.com wrote:

  1   2   >