Re: [PATCH] Convert more passes to new dump framework

2013-08-31 Thread Sharad Singhai
On Fri, Aug 30, 2013 at 9:58 PM, Teresa Johnson tejohn...@google.com wrote: Besides, we might also want to use the same machinery (dump_printf_loc etc) for dump file dumping. The current behavior of using '-details' to turn on opt-info-all messages for dump files are not desirable.

Re: [PATCH] Convert more passes to new dump framework

2013-08-31 Thread Bernhard Reutner-Fischer
On 30 August 2013 23:23:16 Teresa Johnson tejohn...@google.com wrote: On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li davi...@google.com wrote: On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson tejohn...@google.com wrote: On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li davi...@google.com

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-31 Thread Richard Biener
Jakub Jelinek ja...@redhat.com wrote: On Fri, Aug 30, 2013 at 11:28:34AM -0400, Diego Novillo wrote: Well, it was a wrong decision then. For some smaller types writing manual marker might be a sensible thing, or for some extra complicated constructs. But here we're talking about the most

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-31 Thread Richard Biener
Diego Novillo dnovi...@google.com wrote: On Fri, Aug 30, 2013 at 11:37 AM, Jakub Jelinek ja...@redhat.com wrote: Teaching the gengtype parser about {struct,class} name : public {struct,class} someothername { ... } as opposed to current {struct,class} name { ... } shouldn't be that hard.

Re: [Patch] Rewrite regex matchers

2013-08-31 Thread Paolo Carlini
Hi, stephen.w...@bregmasoft.ca wrote: Other than the test case (breaks on mingw32 target) this is looking very sweet. Could you please show some details? I suppose he referred to the char/wchar_t split which I described... Thanks! Paolo

Re: Fix OBJ_TYPE_REF handling in ipa-cp

2013-08-31 Thread Jan Hubicka
Bootstrapped/regtesed x86_64-linux. Martin, please can you review the change? * ipa-prop.c (ipa_set_jf_known_type): Check that component type is a record type with BINFO. (detect_type_change_ssa): Add comp_type argument. (compute_complex_assign_jump_func): Add

[PATCH, alpha]: Fix recent gfortran.dg/pr32533.f90 test failure

2013-08-31 Thread Uros Bizjak
Hello! The compilation emitted following sequence for cmove with unsigned compare, resulting in gfortran.dg/pr32533.f90 runtime failure [1]: (insn 70 69 71 (set (reg:DI 143) (leu:DI (reg:DI 139) (const_int 18 [0x12]))) -1 (nil)) (insn 71 70 72 (set (reg:DF 144)

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-31 Thread Basile Starynkevitch
On Sat, 2013-08-31 at 11:57 +0200, Richard Biener wrote: Diego Novillo dnovi...@google.com wrote: Yes. Lawrence and I thought about moving gengtype inside g++. That seemed like a promising approach. What do you do during stage1? Have a collector that never collects? We could imagine

[PATCH 3/6 v2] Autogenerated conversion of gimple to C++

2013-08-31 Thread David Malcolm
On Thu, 2013-08-29 at 12:20 -0400, David Malcolm wrote: This patch is 110KB in size, so to avoid mailing-list size limits I've uploaded it to: http://dmalcolm.fedorapeople.org/gcc/large-patches/a89d361b4f95dd216e1d29cb44fbaf90372c48b8-0003-Autogenerated-conversion-of-gimple-to-C.patch The

Fix integer overflow when scaling counts in inliner

2013-08-31 Thread Jan Hubicka
Hi, PPC64 lto profiledbootstrap failes because counts get negative in iteger scalling. Because of lost comdat samples, we end up with function called twice being inlinined into an call happening few thousdand times. gcov_scale is then large and apply_scale should not truncate it to 32bit.

[PATCH 6/6 v2] Add manual GTY hooks

2013-08-31 Thread David Malcolm
On Fri, 2013-08-30 at 10:04 +0200, Richard Biener wrote: On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm dmalc...@redhat.com wrote: * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)). (gt_pch_nx (gimple)): Likewise. (gt_pch_nx (gimple,

Re: [PATCH 0/6] Convert gimple to a C++ class hierarchy

2013-08-31 Thread Diego Novillo
On Sat, Aug 31, 2013 at 5:57 AM, Richard Biener richard.guent...@gmail.com wrote: What do you do during stage1? Have a collector that never collects? Yes. That was the pebble in the shoe. The cc1plus built for the purposes of gengtype does not need to look at a lot of code, so turning off

Re: [PATCH] Convert more passes to new dump framework

2013-08-31 Thread Teresa Johnson
On Sat, Aug 31, 2013 at 12:26 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On 30 August 2013 23:23:16 Teresa Johnson tejohn...@google.com wrote: On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li davi...@google.com wrote: On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson

Fix speculative edge reference lookup

2013-08-31 Thread Jan Hubicka
Hi, this patch fixes ugly thinko when looking up reference for a speculative call. Without LTO we can end up choosing wrong alternative for function with many devirtualizations (as it happens for PPC64) Bootstrapped/regtested ppc64-linux, comitted. Honza Index: ChangeLog

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-31 Thread David Malcolm
On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm dmalc...@redhat.com wrote: * gimple.c (gt_ggc_mx (gimple)): New, as required by GTY((user)).

Fix fork instrumentation for libgcov

2013-08-31 Thread Jan Hubicka
Hi, as noticed by Martin Liska, -O0 -fprofile-generate code won't land into __gcov_fork. This is due to early exit from expand_builtin. Fixed and will be comitted as obvious. Honza * builtins.c (expand_builtin): Do not exit early for gcov instrumented functions. *

Re: Ubsan merged into trunk

2013-08-31 Thread Iain Sandoe
Hi, On 30 Aug 2013, at 20:43, Jakub Jelinek wrote: On Fri, Aug 30, 2013 at 09:38:01PM +0200, Dominique Dhumieres wrote: I've just merged ubsan into trunk. Please send complaints my way. Bootstrap is broken on x86_64-apple-darwin10: (wonder why not libasan_la_LIBADD =

Re: Ubsan merged into trunk

2013-08-31 Thread Marek Polacek
On Sat, Aug 31, 2013 at 04:04:03PM +0100, Iain Sandoe wrote: Hi, On 30 Aug 2013, at 20:43, Jakub Jelinek wrote: On Fri, Aug 30, 2013 at 09:38:01PM +0200, Dominique Dhumieres wrote: I've just merged ubsan into trunk. Please send complaints my way. Bootstrap is broken on

Re: Ubsan merged into trunk

2013-08-31 Thread Marek Polacek
On Fri, Aug 30, 2013 at 06:58:06PM -0400, David Edelsohn wrote: This patch / merge broke bootstrap on AIX: In file included from ./tm.h:18:0, from /home/dje/src/src/gcc/function.h:26, from /home/dje/src/src/gcc/basic-block.h:25, from

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-31 Thread Jan Hubicka
Hi, With Martin we made script for testing the profiling failures. First do ld --verbose ~/script then apply --- /home/jh/script22013-08-31 17:59:11.0 +0200 +++ /home/jh/script 2013-08-31 17:39:40.0 +0200 @@ -1,12 +1,3 @@ -GNU ld (GNU Binutils for Debian)

Remove hash from remember_with_vars

2013-08-31 Thread Jan Hubicka
Hi, remember_with_vars walks trees that are read from file (now unique) and looks for fields that can contain pointers to vars or functions and if so, it records them to global hashtable for later fixup. This is quite wasteful, because the hash is querried many times. We can simply walk all fields

Re: [PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

2013-08-31 Thread Joseph S. Myers
On Sat, 31 Aug 2013, Cong Hou wrote: I don't see why it would be unsafe for logb - can you give an example (exact float input value as hex float, and the values you believe logb should return for float and double). Please try the following code (you will get different results whether

Re: Remove hash from remember_with_vars

2013-08-31 Thread Richard Biener
Jan Hubicka hubi...@ucw.cz wrote: Hi, remember_with_vars walks trees that are read from file (now unique) and looks for fields that can contain pointers to vars or functions and if so, it records them to global hashtable for later fixup. This is quite wasteful, because the hash is querried many

Re: [PATCH 6/6] Add manual GTY hooks

2013-08-31 Thread Richard Biener
David Malcolm dmalc...@redhat.com wrote: On Fri, 2013-08-30 at 10:09 +0200, Richard Biener wrote: On Thu, Aug 29, 2013 at 9:44 PM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Aug 29, 2013 at 6:20 PM, David Malcolm dmalc...@redhat.com wrote: * gimple.c (gt_ggc_mx (gimple)):

Re: Remove hash from remember_with_vars

2013-08-31 Thread Bernhard Reutner-Fischer
On 31 August 2013 19:15:46 Richard Biener rguent...@suse.de wrote: Jan Hubicka hubi...@ucw.cz wrote: Hi, remember_with_vars walks trees that are read from file (now unique) and looks for fields that can contain pointers to vars or functions and if so, it records them to global hashtable for

Re: [patch, fortran, docs] Unformatted sequential and special files

2013-08-31 Thread Janne Blomqvist
On Fri, Aug 30, 2013 at 8:18 PM, Thomas Koenig tkoe...@netcologne.de wrote: Hello world, the attached patch documents the format for unformatted sequential files and what is, and is not, supported with special files. Tested with make dvi and make info. OK for trunk? The unformatted

Re: Ubsan merged into trunk

2013-08-31 Thread Dominique Dhumieres
bootstrapped x86_64-darwin12 for c,c++ and fortran ... Bootstrapped x86_64-apple-darwin10 for c,c++,fortran,java and also tested asan.exp and ubsan.exp for gcc and g++. Thanks for the patch, Dominique

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-08-31 Thread Eric Botcazou
This patch fixes that by introducing GXX_LINK which is GCC_LINK except that CXX (e.g. xg++) instead of CC (e.g. xgcc) is invoked. Eric, are there other executables that need to be linked with GXX_LINK too but aren't triggered yet? Yes, all not covered executables linking with TOOLS_LIBS

Re: Ada PATCH: Fix ada/58239 by linking with xg++, not xgcc

2013-08-31 Thread Gabriel Dos Reis
Eric Botcazou ebotca...@adacore.com writes: | This patch fixes that by introducing GXX_LINK which is GCC_LINK except | that CXX (e.g. xg++) instead of CC (e.g. xgcc) is invoked. | | Eric, are there other executables that need to be linked with GXX_LINK | too but aren't triggered yet? | |

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-08-31 Thread Jan Hubicka
Hi, I run my script on execute testsuite and looked into few testcases. The problem I found was roundoff errors - i.e. when expanding switch we set 50% chage that out of bound value is above or bellow. Both gets rounded to 0, because switch is executed once and the value is bellow. Partly

[PATCH,fixincldes] AIX assert.h static_assert

2013-08-31 Thread David Edelsohn
In a recent change to AIX 7, the assert.h header defines static_assert. I presume this was intended not to avoid conflicts with the new C++ keyword. Sigh. However, the definition is not protected from C++, which causes problem if the header is included in C++ code, which it is in libstdc++.

Re: [PATCH,fixincldes] AIX assert.h static_assert

2013-08-31 Thread Bruce Korb
Sure. Looks fine. Please apply to all active branches. On Sat, Aug 31, 2013 at 4:40 PM, David Edelsohn dje@gmail.com wrote: