Re: [Patch, i386] PR 59422 - Support more targets for function multi versioning

2013-12-26 Thread Uros Bizjak
On Thu, Dec 26, 2013 at 7:28 AM, Gopalasubramanian, Ganesh ganesh.gopalasubraman...@amd.com wrote: (get_amd_cpu): Handle AMD_BOBCAT, AMD_JAGUAR, AMDFAM15H_BDVER2 and AMDFAM15H_BDVER3. As mentioned earlier, we would like to stick with BTVER1 and BTVER2 instead of using BOBCAT or

RE: [Patch, i386] PR 59422 - Support more targets for function multi versioning

2013-12-26 Thread Gopalasubramanian, Ganesh
I'm sorry I didn't notice previous conversation. Please install ASAP. Thanks Uros! Committed to revision 206210. - Ganesh

Re: [PATCH i386 4/8] [AVX512] [7/8] Add substed patterns: `round for expand' subst.

2013-12-26 Thread Kirill Yukhin
Hello Uros, On 23 Dec 17:46, Uros Bizjak wrote: This round_expand_predicate is the predicate substitution I was referred to in the review of 5/8. Please use it also in insn patterns, perhaps renamed as round_predicate This is drawback of substs. We bind given subst attribute to given subst

Re: [Patch, i386] PR 59422 - Support more targets for function multi versioning

2013-12-26 Thread Allan Sandfeld Jensen
On Thursday 26 December 2013, Gopalasubramanian, Ganesh wrote: Hi, (get_amd_cpu): Handle AMD_BOBCAT, AMD_JAGUAR, AMDFAM15H_BDVER2 and AMDFAM15H_BDVER3. As mentioned earlier, we would like to stick with BTVER1 and BTVER2 instead of using BOBCAT or JAGUAR. Attached patch does the

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread Jan Hubicka
Hi Honza, We have combined generic32 and generic64 into generic. There is no need to check generic anymore. Also we shouldn't change -mtune=i686 into -mtune=generic. OK to install? The i686-generic change was intended to get generic optimized code for i686-linux configuration rather than

Re: [PATCH i386 4/8] [AVX512] [5/8] Add substed patterns: rounding subst.

2013-12-26 Thread Kirill Yukhin
Hello, On 23 Dec 17:26, Uros Bizjak wrote: On Mon, Dec 23, 2013 at 5:11 PM, Uros Bizjak ubiz...@gmail.com wrote: So, OK for mainline, but I would kindly ask you to please wait a couple of days for possible Richard's comments When substituting constraints, please also substitute

PATCH: PR target/59601: [4.9 Regression] __attribute__ ((target(arch=corei7))) won't match Westmere processor

2013-12-26 Thread H.J. Lu
Hi, After my Intel processor name cleanup, __attribute__ ((target(arch=corei7))) is translated to PROCESSOR_NEHALEM mapped to M_INTEL_COREI7_NEHALEM. We used to hav e __attribute__ ((target(arch=corei7))) to cover M_INTEL_COREI7_. Now it only covers M_INTEL_COREI7_NEHALEM. We have

Re: [RFC][gomp4] Offloading: Add device initialization and host-target function mapping

2013-12-26 Thread Ilya Verbin
Ping. (Patch is slightly updated) On 20 Dec 21:18, Ilya Verbin wrote: Hi Jakub, Could you please take a look at this patch for libgomp? It adds new function GOMP_register_lib, that should be called from every exec/lib with target regions (that was done in patch [1]). This function

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread H.J. Lu
On Thu, Dec 26, 2013 at 4:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, We have combined generic32 and generic64 into generic. There is no need to check generic anymore. Also we shouldn't change -mtune=i686 into -mtune=generic. OK to install? The i686-generic change was intended to

Re: PATCH: PR target/59601: [4.9 Regression] __attribute__ ((target(arch=corei7))) won't match Westmere processor

2013-12-26 Thread Uros Bizjak
On Thu, Dec 26, 2013 at 2:25 PM, H.J. Lu hongjiu...@intel.com wrote: After my Intel processor name cleanup, __attribute__ ((target(arch=corei7))) is translated to PROCESSOR_NEHALEM mapped to M_INTEL_COREI7_NEHALEM. We used to hav e __attribute__ ((target(arch=corei7))) to cover

[PATCH, i386]: Use vendor signatures from cpuid.h in cpuinfo.c

2013-12-26 Thread Uros Bizjak
Hello! Use the same definitions from common header. 2013-12-26 Uros Bizjak ubiz...@gmail.com * config/i386/cpuinfo.c (enum vendor_signatures): Remove. (__cpu_indicator_init): Use signature_INTEL_ebx and signature_AMD_ebx from cpuid.h to check vendor signatures. No functional

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread Jan Hubicka
On Thu, Dec 26, 2013 at 4:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, We have combined generic32 and generic64 into generic. There is no need to check generic anymore. Also we shouldn't change -mtune=i686 into -mtune=generic. OK to install? The i686-generic change was

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread H.J. Lu
On Thu, Dec 26, 2013 at 7:45 AM, Jan Hubicka hubi...@ucw.cz wrote: On Thu, Dec 26, 2013 at 4:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, We have combined generic32 and generic64 into generic. There is no need to check generic anymore. Also we shouldn't change -mtune=i686 into

Re: PATCH: PR target/59587: cpu_names in i386.c is accessed with wrong index

2013-12-26 Thread H.J. Lu
On Wed, Dec 25, 2013 at 12:49 PM, Uros Bizjak ubiz...@gmail.com wrote: TARGET_CPU_DEFAULT is left over for 32-bit target before --with-arch= and --with-cpu= were added. Today, -mtune=xxx -march=xxx are always passed to cc1 by GCC driver. If cc1 is run by hand and -mtune=xxx -march=xxx aren't

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread H.J. Lu
On Thu, Dec 26, 2013 at 8:06 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Dec 26, 2013 at 7:45 AM, Jan Hubicka hubi...@ucw.cz wrote: On Thu, Dec 26, 2013 at 4:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, We have combined generic32 and generic64 into generic. There is no need to

Re: New prologue/epilogue code for i386 string functions

2013-12-26 Thread H.J. Lu
On Tue, Oct 22, 2013 at 8:58 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch adds code to produce prologues/epilogues as suggested by Ondrej Bilka (I described more the approach in http://gcc.gnu.org/ml/gcc-patches/2013-09/msg02082.html) This patch is updated and cleaned up version

Re: PATCH: PR target/59588: Don't check/change generic/i686 tuning

2013-12-26 Thread H.J. Lu
On Thu, Dec 26, 2013 at 11:11 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Dec 26, 2013 at 8:06 AM, H.J. Lu hjl.to...@gmail.com wrote: On Thu, Dec 26, 2013 at 7:45 AM, Jan Hubicka hubi...@ucw.cz wrote: On Thu, Dec 26, 2013 at 4:38 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi Honza, We have

Re: [patch] powerpc64 FreeBSD support for boehm-gc

2013-12-26 Thread Andrew Haley
On 12/26/2013 12:11 AM, Andreas Tobler wrote: On 21.12.13 18:27, Andrew Haley wrote: On 12/20/2013 10:15 PM, Andreas Tobler wrote: Ok for gcc trunk? OK, thanks. May I get this one down to 4.8 too? Not really needed, but for completeness. Results will follow... No objections from me.

PATCH: PR target/59605: Create jump_around_label only if it doesn't exist

2013-12-26 Thread H.J. Lu
Hi Honza, r203937 may create jump_around_label earlier. But later code doesn't check if jump_around_label exists. This patch fixes it. Tested on Linux/x86-64. OK to install? Thanks. H.J. -- gcc/ 2013-12-26 H.J. Lu hongjiu...@intel.com PR target/59605 * config/i386/i386.c

Re: [PATCH][x86] march aliases

2013-12-26 Thread Ryan Hill
On Mon, 23 Dec 2013 05:10:06 -0800 H.J. Lu hjl.to...@gmail.com wrote: This is the patch I checked in. I will submit separate patches for other parts. Please be sure to update changes.html. -- Ryan Hillpsn: dirtyepic_sk gcc-porting/toolchain/wxwidgets @ gentoo.org

Re: [Patch] PR55189 enable -Wreturn-type by default

2013-12-26 Thread Chung-Ju Wu
2013/12/21 Sylvestre Ledru sylves...@debian.org: Hello Following this thread http://gcc.gnu.org/ml/gcc/2013-11/msg00260.html and this bug, http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55189 I would like to propose the two following patches: I am activating -Wreturn-type by defaut and add

Re: [Patch] PR55189 enable -Wreturn-type by default

2013-12-26 Thread Yury Gribov
Chung-Wu wrote: But I notice your ChangeLog formatting is not correct. You can refer to other entries in ChangeLog to refine yours, and then resubmit the patch for review. :) Or - use contrib/mklog to autogenerate template ChangeLog for you. -Y