Re: [PATCH][AArch64] Specify CRC and Crypto support for Cortex-A53, A57

2014-01-23 Thread Kyrill Tkachov
On 16/01/14 18:10, Kyrill Tkachov wrote: Hi all, The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions to the ARMv8-A architecture. This patch adds that information to their definitions in aarch64-cores.def. Tested aarch64-none-elf with no regressions. Ok for trunk? (or

Re: [C PATCH] Disallow subtracting pointers to empty structs (PR c/58346)

2014-01-23 Thread Marek Polacek
Ping. On Thu, Jan 16, 2014 at 07:52:43PM +0100, Marek Polacek wrote: On Wed, Jan 15, 2014 at 09:23:06PM +, Joseph S. Myers wrote: On Wed, 15 Jan 2014, Marek Polacek wrote: +/* Return true if T is a pointer to a zero-sized struct/union. */ + +bool

Re: [PATCH] fix for PR 59825

2014-01-23 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 10:40:31PM +, Iyer, Balaji V wrote: --- a/gcc/c/c-array-notation.c +++ b/gcc/c/c-array-notation.c @@ -1218,22 +1218,22 @@ fix_return_expr (tree expr) return new_mod_list; } -/* Walks through tree node T and find all the call-statements that do not return

Re: FW: [GOMP4][PATCH] SIMD-enabled functions (formerly Elemental functions) for C++

2014-01-23 Thread Jakub Jelinek
On Mon, Jan 20, 2014 at 03:42:02AM +, Iyer, Balaji V wrote: I forgot to add the 2 changelog entries for decl.c and pt.c. The patch is attached again with the corrected Changelogs. This is ok for trunk, thanks. Jakub

Re: [C++ patch] PR 59482

2014-01-23 Thread Paolo Carlini
Hi, On 01/22/2014 11:38 PM, Ville Voutilainen wrote: Oh, I was expecting Jason would do that. Note that Marek Polacek pointed out two formatting issues: - comments should have full stop and two spaces at the end Yes, will fix in my next commit touching that file. - also two spaces before

Re: Reload codegen improvement

2014-01-23 Thread Chung-Lin Tang
On 14/1/8 12:22 AM, Bernd Schmidt wrote: This fixes a problem identified by Chung-Lin. Once reload is done, all equivalencing insns for pseudos that didn't get a hard reg but could be eliminated using their REG_EQUIV are deleted. However, we still can produce reloads and reload insns for them

Re: [PATCH][AVX512] Add forgotten intrinsics.

2014-01-23 Thread Ilya Tocar
I found out that we forgot to implement some of AVX512 intrinsics. Here is a patch that adds them. Sorry for huge patch, but changes are mostly trivial. Ok for trunk? ... This is the same as the second alternative of the avx512f_codepmov_src_lower2_mask pattern. Please change the

Re: [PATCH] _Cilk_for for C and C++

2014-01-23 Thread Jakub Jelinek
On Sun, Jan 19, 2014 at 04:50:39AM +, Iyer, Balaji V wrote: I have answered your questions below. In addition to your changes, I have also fixed the issues Aldy pointed out and have answered his questions in that thread. With this email I have attached two patches and 2 change-logs (for C

Re: [PATCH] fix for PR 59825

2014-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2014 at 10:27:58AM +0100, Jakub Jelinek wrote: On Mon, Jan 20, 2014 at 10:40:31PM +, Iyer, Balaji V wrote: --- a/gcc/c/c-array-notation.c +++ b/gcc/c/c-array-notation.c @@ -1218,22 +1218,22 @@ fix_return_expr (tree expr) return new_mod_list; } -/* Walks

Re: [Patch, fortran] PR59414 [4.8/4.9 Regression] [OOP] ICE in in gfc_conv_expr_descriptor on ALLOCATE inside SELECT TYPE

2014-01-23 Thread Paul Richard Thomas
Dear Janus, snip well, actually the selector in the test case is not an array. And polymorphic arrays as such have been supported since 4.7. duuh! Shows how time flies when you're having fun! Bootstrapped and regtested on FC17/x86_64 - OK for trunk and, after a decent delay, 4.8?

[build] PR 43538: Don't overwrite CXXFLAGS_FOR_TARGET in config/mt-gnu

2014-01-23 Thread Marc Glisse
Hello, although setting CFLAGS_FOR_TARGET before compiling gcc works fine, CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that. I tested the patch by doing a regular bootstrap+testsuite on x86_64-unknown-linux-gnu. I also did a non-bootstrap build where I set

[PING] Fix test case vect-nop-move.c

2014-01-23 Thread Bernd Edlinger
Hi, this might be almost obvious? Thanks Bernd. Date: Mon, 13 Jan 2014 12:13:53 +0100 Hello, there is another test case, that misses the necessary check_vect() runtime check. Tested on i686-pc-linux-gnu. OK for trunk? Regards Bernd.

Re: [PING] Fix test case vect-nop-move.c

2014-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2014 at 12:49:06PM +0100, Bernd Edlinger wrote: Hi, this might be almost obvious? No, check_vect () has to preceed all the vector statements in main, or often even better if main contains just check_vect () call and call to some other noinline routine that has the vector stuff

Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread Marcus Shawcroft
On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com wrote: Hi, This patch fixes vector shift by 64 behavior to meet reference manual expectations. Testcase included to check that expectations are now met. No regressions found. Is patch OK? OK /Marcus

[PATCH] Fix for PR57316 (avoid building sanitizer on old kernels)

2014-01-23 Thread Yury Gribov
Hi, Attached patch disables libsanitizer on older Linux distribs which lack necessary syscalls (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57316 for more details). Bootstrapped/regtested on x64. Ok to commit? -- Best regards, Yury Gribov 2014-01-22 ygribov ygri...@samsung.com

[patch] Update libstdc++ FAQ

2014-01-23 Thread Jonathan Wakely
This expands the FAQ answer on dynamic linking, to be more explicit for people who don't understand the concepts. It also corrects an incorrect symver in abi.xml * doc/xml/faq.xml (a-how_to_set_paths): Expand FAQ answer. * doc/xml/manual/abi.xml (abi.versioning.history): Correct

Re: [PATCH] Fix use-after-return-1.c

2014-01-23 Thread Maxim Ostapenko
Mike Stump wrote: This patch fixes c-c++-common/asan/use-after-return-1.c not to fail on darwin target (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897). Ok to commit? Ok. Commited in 206961. -Maxim.

Re: [PATCH] Fix for PR57316 (avoid building sanitizer on old kernels)

2014-01-23 Thread Jakub Jelinek
On Thu, Jan 23, 2014 at 04:33:28PM +0400, Yury Gribov wrote: Attached patch disables libsanitizer on older Linux distribs which lack necessary syscalls (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57316 for more details). Bootstrapped/regtested on x64. Ok to commit? Ok, thanks, but:

Re: Reload codegen improvement

2014-01-23 Thread Bernd Schmidt
On 01/23/2014 10:44 AM, Chung-Lin Tang wrote: On 14/1/8 12:22 AM, Bernd Schmidt wrote: This fixes a problem identified by Chung-Lin. Once reload is done, all equivalencing insns for pseudos that didn't get a hard reg but could be eliminated using their REG_EQUIV are deleted. However, we still

Re: [PATCH i386 11/8] [AVX512] [2/2] Add missing packed PF gathers/scatters.

2014-01-23 Thread Uros Bizjak
On Tue, Jan 21, 2014 at 7:52 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hello, This is non-trivial part of the patch. On 15 Jan 20:53, Uros Bizjak wrote: On Tue, Jan 14, 2014 at 7:13 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Did you try to add DF/SF mode to the unspec? I am

[committed] Fix OpenMP reduction with _Complex vars (PR middle-end/58809)

2014-01-23 Thread Jakub Jelinek
Hi! /|/^ are all rejected for _Complex vars, both floating and integral, thus OpenMP /|/^/min/max reductions should be rejected for those vars similarly. In OpenMP 4.1 hopefully they'll be allowed for user defined reductions at least, but they aren't right now. Below is trunk patch I've

Re: [C++ Patch] PR 58980

2014-01-23 Thread Jason Merrill
On 01/22/2014 04:29 PM, Paolo Carlini wrote: On 01/22/2014 10:10 PM, Jason Merrill wrote: Yep, that's along the lines I was thinking of. But again, prev_scope is irrelevant here, so the new code shouldn't mention it at all. Well, in practice I have to mention it in the error_at itself. Why?

Re: [PATCH] Fix for PR57316 (avoid building sanitizer on old kernels)

2014-01-23 Thread Yury Gribov
Jakub wrote: Ok to commit? Ok, thanks, but: Done, r206966. Put your real name here instead. PR sanitizer/57316 Oh my, fixed. -Y

Re: [Patch, microblaze]: Add __builtin_trap instruction pattern

2014-01-23 Thread Michael Eager
On 11/25/13 23:47, David Holsgrove wrote: Implement the trap pattern for MicroBlaze using matching ABORT_INSTRUCTION used in glibc. Resolves recent build failure while building glibc, also encountered by ARM and AARCH64 and discussed here;

Re: [C++ Patch] PR 58980

2014-01-23 Thread Paolo Carlini
Hi, On 01/23/2014 03:05 PM, Jason Merrill wrote: On 01/22/2014 04:29 PM, Paolo Carlini wrote: On 01/22/2014 10:10 PM, Jason Merrill wrote: Yep, that's along the lines I was thinking of. But again, prev_scope is irrelevant here, so the new code shouldn't mention it at all. Well, in practice I

[committed][PATCH AArch64_BE] Big-Endian lane numbering fix

2014-01-23 Thread Kyrill Tkachov
Hi all, I've committed this 4-patch series to aarch64 at: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00970.html http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00972.html http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00974.html http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00975.html as revisions

[PATCH, ARM][PING] Reintroduce minipool ranges for zero-extension insn patterns

2014-01-23 Thread Yury Gribov
Hi, Julian Brown has proposed patch (http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01191.html) for the dreadful push_minipool_fix error (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49423) in June but it didn't seem to get enough attention. Can we submit it? -- Best regards, Yury

Re: [C++ Patch] PR 58980

2014-01-23 Thread Paolo Carlini
On 01/23/2014 04:01 PM, Paolo Carlini wrote: Hi, On 01/23/2014 03:05 PM, Jason Merrill wrote: On 01/22/2014 04:29 PM, Paolo Carlini wrote: On 01/22/2014 10:10 PM, Jason Merrill wrote: Yep, that's along the lines I was thinking of. But again, prev_scope is irrelevant here, so the new code

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-23 Thread Jan Hubicka
FAIL: gcc.dg/guality/pr54693-2.c -O3 -fomit-frame-pointer -funroll-loops line 21 i == v + 1 FAIL: gcc.target/i386/pr35767-5.c scan-assembler-not movups Should we fix FAIL: gcc.target/i386/pr35767-5.c scan-assembler-not movups I will look into this one. It did not failed for me

Re: [C++ Patch] PR 58980

2014-01-23 Thread Jason Merrill
On 01/23/2014 10:30 AM, Paolo Carlini wrote: To be clear if we use %qT with nested_name_specifier we get: 58980.C:5:8: error: ‘typename A template-parameter-1-1 ::B’ has not been declared which frankly seems suboptimal to me, both vs the non-template case and the use of typename. If you want

Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread Alex Velenko
Hi, Could someone, please, commit this patch, as I do not have permissions to do so. Kind regards, Alex On 23/01/14 12:04, Marcus Shawcroft wrote: On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com wrote: Hi, This patch fixes vector shift by 64 behavior to meet reference manual

Re: [C++ Patch] PR 58980

2014-01-23 Thread Paolo Carlini
On 01/23/2014 04:50 PM, Jason Merrill wrote: On 01/23/2014 10:30 AM, Paolo Carlini wrote: To be clear if we use %qT with nested_name_specifier we get: 58980.C:5:8: error: ‘typename A template-parameter-1-1 ::B’ has not been declared which frankly seems suboptimal to me, both vs the

Re: [C++ Patch] PR 58980

2014-01-23 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH][AArch64] Vector shift by 64 fix

2014-01-23 Thread James Greenhalgh
On Thu, Jan 23, 2014 at 03:57:33PM +, Alex Velenko wrote: Hi, Could someone, please, commit this patch, as I do not have permissions to do so. Please don't top-post on this list. On 23/01/14 12:04, Marcus Shawcroft wrote: On 6 January 2014 11:52, Alex Velenko alex.vele...@arm.com

[C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread Marek Polacek
shorten_compare can produce a better locinfo if we pass location from {,cp_}build_binary_op to it; op0/op1 there don't have location. Furthermore, I see no reason why use input_location in parser_build_binary_op when we can use more accurate location. I don't know if/how I can test the column

RE: [PATCH] _Cilk_for for C and C++

2014-01-23 Thread Iyer, Balaji V
Hi Jakub, -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Thursday, January 23, 2014 5:13 AM To: Iyer, Balaji V Cc: Jason Merrill; 'Jeff Law'; 'Aldy Hernandez'; 'gcc-patches@gcc.gnu.org'; 'r...@redhat.com' Subject: Re: [PATCH] _Cilk_for for C and C++ On

[Ada] Remove unused node N_Subprogram_Info

2014-01-23 Thread Arnaud Charlet
This is an internal change only, does not affect functionality, so no test needed. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-23 Robert Dewar de...@adacore.com * exp_util.adb, sinfo.adb, sinfo.ads, sem.adb, sem_res.adb, expander.adb, exp_ch11.adb, exp_ch11.ads,

[Ada] Fix detection of unmodified variables in -gnatc mode

2014-01-23 Thread Arnaud Charlet
For an implicit dereference such as J.K where J is of an access type, the compiler incorrectly assumed that an assignment to J.K would modify J if operating in semantics only (-gnatc) mode. The following example gives the warning indicated if compiled with -gnatwa with or without -gnatc 1.

Re: [ARM] fix big.LITTLE spec rewriting

2014-01-23 Thread James Greenhalgh
*Ping* On Tue, Jan 21, 2014 at 10:52:14AM +, James Greenhalgh wrote: Hi, As with the AArch64 case, ( http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01317.html ) the way that we rewrite command lines for big.LITTLE systems causes bugs where more than one source file is to be used.

Re: [AArch64] fix big.LITTLE spec rewriting

2014-01-23 Thread James Greenhalgh
*ping* On Tue, Jan 21, 2014 at 10:48:04AM +, James Greenhalgh wrote: Hi, As Charles Baylis pointed out here: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00921.html The way that we rewrite command lines for big.LITTLE systems causes bugs where more than one source file is to be

RE: [PATCH] fix for PR 59825

2014-01-23 Thread Iyer, Balaji V
-Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Thursday, January 23, 2014 5:28 AM To: Iyer, Balaji V Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] fix for PR 59825 On Thu, Jan 23, 2014 at 10:27:58AM +0100, Jakub Jelinek wrote: On Mon, Jan 20, 2014 at

[Ada] Restrictions on 'Old in a postcondition.

2014-01-23 Thread Arnaud Charlet
RM 6.1.1 (26/3) specifies that if the prefix of 'Old wihin a postcondition is potentially unevaluated, as in the right-hand side of a short-circuit operation then the prefix can only be an entity name. Compiling main.adb must yield: p.ads:5:44: prefix that is potentially unevaluated must

[Ada] Fix problem in save/restore of SPARK_Mode

2014-01-23 Thread Arnaud Charlet
The previous checkin for saving and restoring SPARK_Mode was not complete, and as a result the SPARK_Mode_Pragma was not properly set in some cases. The following test program: 1. package Pack_Size1 is 2.pragma SPARK_Mode (On); 3.procedure P; 4. end Pack_Size1;

Commit: MSP430: Linker script renaming

2014-01-23 Thread Nick Clifton
Hi Guys, I am committing the patch below which changes the MCU specific linker script naming scheme for the MSP430. TI have now decided to replace the MCU specific directories containing memory.ld and peripherals.ld scripts with individual MCU scripts. The patch also updates the -mcpu

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2014-01-23 Thread Jakub Jelinek
On Wed, Jan 22, 2014 at 09:16:02AM +0100, Dodji Seketeli wrote: +static fcache* +add_file_to_cache_tab (const char *file_path) +{ + + FILE *fp = fopen (file_path, r); + if (ferror (fp)) +{ + fclose (fp); + return NULL; +} I've seen various segfaults here when playing

[patch] fix libstdc++/59872

2014-01-23 Thread Jonathan Wakely
This fixes a recent regression introduced when I added C++ allocator support to the RB trees. Tested x86_64-linux, committed to trunk. PR libstdc++/59872 * include/bits/stl_map.h (map::operator=(map)): Fix comment. * include/bits/stl_multimap.h

Re: [C PATCH] Disallow subtracting pointers to empty structs (PR c/58346)

2014-01-23 Thread Joseph S. Myers
On Thu, 23 Jan 2014, Marek Polacek wrote: 2014-01-16 Marek Polacek pola...@redhat.com PR c/58346 c-family/ * c-common.c (pointer_to_zero_sized_aggr_p): New function. * c-common.h: Declare it. cp/ * typeck.c (pointer_diff): Give an error on arithmetic on pointer

Re: [C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread Joseph S. Myers
On Thu, 23 Jan 2014, Marek Polacek wrote: shorten_compare can produce a better locinfo if we pass location from {,cp_}build_binary_op to it; op0/op1 there don't have location. Furthermore, I see no reason why use input_location in parser_build_binary_op when we can use more accurate location.

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-23 Thread Joseph S. Myers
On Wed, 22 Jan 2014, Marek Polacek wrote: 2014-01-22 Marek Polacek pola...@redhat.com PR c/59871 c/ * c-typeck.c (build_compound_expr): Warn even for right-hand operand of a comma expression. (emit_side_effect_warnings): Likewise. libdecnumber/ *

Re: [PATCH] add __attribute__ ((designated_init))

2014-01-23 Thread Joseph S. Myers
On Mon, 20 Jan 2014, Tom Tromey wrote: I wrote a new test case covering the same cases that the sparse test case covers. I also added tests for applying the attribute to non-struct types; note that in this case sparse issues a warning but gcc issues an error. I think an error is more

[PATCH] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
Hi all. Jakub, could you review these patches, if they are OK to gomp-4_0-branch? Thomas, please, have a look whether this implementation applies current OpenACC support style. These patches port OpenACC 1.0 support in fortran front-end from openacc-1_0-branch to gomp-4_0-branch. In

[PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From 69bf2531e4512b7cdb2feba8541de1eaf9c2aa56 Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:05:11 +0400 Subject: [PATCH 2/6] OpenACC fortran FE part 2 --- gcc/fortran/openmp.c | 1032 +- 1 file

[PATCH 1/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From 84dc72f88c1b23ae995afdda0b946ebd73af102f Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:04:37 +0400 Subject: [PATCH 1/6] OpenACC fortran FE part 1 --- gcc/fortran/decl.c| 1 + gcc/fortran/dump-parse-tree.c | 203

[PATCH 3/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From 0658580cf665b8da8cc4533901989b7a1d54f73a Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:06:00 +0400 Subject: [PATCH 3/6] OpenACC fortran FE part 3 --- gcc/fortran/trans-decl.c | 7 + gcc/fortran/trans-openmp.c | 526

[PATCH 4/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From 37806068fffcab95a21b51829c900d49be14961d Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:08:05 +0400 Subject: [PATCH 4/6] OpenACC GENERIC nodes --- gcc/gimplify.c | 73 gcc/omp-low.c | 84 --

[PATCH 5/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From ae0ba17c51f6ed3529976a0cdf8f80046d1ed9b7 Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:10:41 +0400 Subject: [PATCH 5/6] OpenACC fortran tests --- gcc/testsuite/gfortran.dg/goacc/branch.f95 | 55 +

[PATCH 6/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
From 668a50443d0a70a633707ec49759d9e8b6d00b1e Mon Sep 17 00:00:00 2001 From: Ilmir Usmanov i.usma...@samsung.com Date: Thu, 23 Jan 2014 21:26:50 +0400 Subject: [PATCH 6/6] OpenACC GENERIC docs --- gcc/doc/generic.texi | 40 1 file changed, 40

[PATCH 7/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-01-23 Thread Ilmir Usmanov
Finally, ChangeLog entry. 23-01-2014 Ilmir Usmanov i.usma...@samsung.com Add OpenACC 1.0 support to fortran FE and GENERIC, except loop directive and subarrays. gcc/fortran/ * decl.c (gfc_match_end): Match end of OpenACC region. * dump-parse-tree.c

Re: [C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread Marek Polacek
On Thu, Jan 23, 2014 at 05:50:23PM +, Joseph S. Myers wrote: On Thu, 23 Jan 2014, Marek Polacek wrote: shorten_compare can produce a better locinfo if we pass location from {,cp_}build_binary_op to it; op0/op1 there don't have location. Furthermore, I see no reason why use

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-01-23 Thread Jason Merrill
On 01/16/2014 02:44 PM, Jason Merrill wrote: To avoid spurious warnings on code with infinite loops we could add a simple check for infinite loops and suppress the warning in that case. Basically, if we see a loop with an always-true condition and no breaks. Like so: Tested

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-01-23 Thread Sylvestre Ledru
On 23/01/2014 10:48, Jason Merrill wrote: On 01/16/2014 02:44 PM, Jason Merrill wrote: To avoid spurious warnings on code with infinite loops we could add a simple check for infinite loops and suppress the warning in that case. Basically, if we see a loop with an always-true condition and no

Re: [PATCH] PR59909, Fix powerpcle64 power8 bootstrap (quad memory support)

2014-01-23 Thread David Edelsohn
On Wed, Jan 22, 2014 at 1:50 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: The current trunk will not bootstrap on a powerpcle64 power8 box if --with-cpu=power8 is selected. This has been traced down to the fact that we did not swap the double words when we used the quad memory

Handle XOR in canonicalize_condition

2014-01-23 Thread Richard Sandiford
This patch fixes gcc.dg/unroll_1.c for MIPS16. There were two problems, one in the testcase itself and one in the rtl code. The testcase problem was that gcc.dg/unroll_1.c forces loop2_unroll to be run via -fenable-rtl-loop2_unroll but it doesn't explicitly force the associated init pass (loop2)

Re: [PATCH] PR59909, Fix powerpcle64 power8 bootstrap (quad memory support)

2014-01-23 Thread Michael Meissner
On Thu, Jan 23, 2014 at 01:58:15PM -0500, David Edelsohn wrote: The patch is okay, but please clarify the sync.md ChangeLog to mention what you did for the patterns, like new patterns, new attrs, which patterns are changed to swap double words in LE mode. In looking to write better comments, I

Re: [GOOGLE] Builtins handling in IVOPT

2014-01-23 Thread Xinliang David Li
Two patches are ok with the following change * change PARAM_AVG_LOOP_NITER to PARAM_IVOPT_AVG_LOOP_NITER; (The base version of the patch is not correct). thanks, David On Wed, Jan 22, 2014 at 9:52 PM, Wei Mi w...@google.com wrote: Comments added. I create another patch to add the parameter

patch to fix PR59915

2014-01-23 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59915 The patch was successfully bootstrapped and tested on x86/x86-64 and ppc64 (with -mlra). Committed as rev. 207007. 2014-01-23 Vladimir Makarov vmaka...@redhat.com PR regression/59915 *

Re: [C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread Joseph S. Myers
On Thu, 23 Jan 2014, Marek Polacek wrote: 2014-01-23 Marek Polacek pola...@redhat.com PR c/59846 c-family/ * c-common.c (shorten_compare): Add location_t parameter. * c-common.h (shorten_binary_op): Adjust declaration. cp/ * typeck.c (cp_build_binary_op): Pass

[jit] Introduce add_stmt helper method.

2014-01-23 Thread David Malcolm
Committed to dmalcolm/jit branch: gcc/jit/ * internal-api.h (gcc::jit::function::add_stmt): New. * internal-api.c (gcc::jit::function::add_eval): Replace use of tsi_link_stmt with call to add_stmt. (gcc::jit::function::add_assignment): Likewise.

[RFA][PATCH] Fix tree-optimization/59919

2014-01-23 Thread Jeff Law
As noted in the PR, we have a call to a non-returning function which occurs within a function that calls setjmp. The non-returning call ends its containing basic block and there are no normal outgoing edges from that block. Because the containing function calls setjmp, there is an abnormal

[jit] Fix how locals are created; add BIND_EXPR

2014-01-23 Thread David Malcolm
Committed to dmalcolm/jit: Attempting to add test coverage uncovered that locals weren't being associated with their functions, leading to crashes later on in the compile for various valid constructs. To fix this, we now set the DECL_CONTEXT of locals to be the FUNCTION_DECL. To do so, we also

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread Eric Botcazou
* config/i38/x86-tune.def: Disable X86_TUNE_ACCUMULATE_OUTGOING_ARGS for generic and recent AMD chips The ChangeLog reads: 2014-01-22 Jan Hubicka j...@suse.cz * config/i386/x86-tune.def (X86_TUNE_ACCUMULATE_OUTGOING_ARGS): Enable for generic and recent AMD

[jit] Add GCC_JIT_BOOL_OPTION_DUMP_GENERATED_CODE

2014-01-23 Thread David Malcolm
Committed to dmalcolm/jit: Add a debug flag for dumping the generated assembler to stderr: GCC_JIT_BOOL_OPTION_DUMP_GENERATED_CODE This is technically an ABI change, since the value is added before some existing values, but we don't yet guarantee an ABI. gcc/jit/ * libgccjit.h (enum

Re: Two build != host fixes

2014-01-23 Thread Alan Modra
On Wed, Jan 22, 2014 at 09:21:46PM -0700, Jeff Law wrote: * Makefile.in (BUILD_CPPFLAGS): Do not use ALL_CPPFLAGS. * configure.ac recursive call for build != host: Define GENERATOR_FILE. Comment. Use CXX_FOR_BUILD, CXXFLAGS_FOR_BUILD and LD_FOR_BUILD too. *

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread Jan Hubicka
* config/i38/x86-tune.def: Disable X86_TUNE_ACCUMULATE_OUTGOING_ARGS for generic and recent AMD chips The ChangeLog reads: 2014-01-22 Jan Hubicka j...@suse.cz * config/i386/x86-tune.def (X86_TUNE_ACCUMULATE_OUTGOING_ARGS): Enable for generic and recent AMD

Re: [C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread H.J. Lu
On Thu, Jan 23, 2014 at 10:44 AM, Marek Polacek pola...@redhat.com wrote: On Thu, Jan 23, 2014 at 05:50:23PM +, Joseph S. Myers wrote: On Thu, 23 Jan 2014, Marek Polacek wrote: shorten_compare can produce a better locinfo if we pass location from {,cp_}build_binary_op to it; op0/op1

Re: [C PATCH] Improve locinfo a bit (PR c/59846)

2014-01-23 Thread Marek Polacek
On Thu, Jan 23, 2014 at 03:18:55PM -0800, H.J. Lu wrote: It failed on Linux/x86: FAIL: gcc.dg/pr59846.c (test for excess errors) FAIL: gcc.dg/pr59846.c (test for warnings, line 14) FAIL: gcc.dg/pr59846.c (test for warnings, line 8) Ooops, yeah. I'll install a fix tomorrow. Marek

Re: [PATCH #2] PR59909, Fix powerpcle64 power8 bootstrap (quad memory support)

2014-01-23 Thread Michael Meissner
This is my fixed patch that correctly swaps the words for atomic quad memory accesses in little endian. It would be nice in the future to eliminate some of the extra moves for things like compare and add. I have tested this with a bootstrap (using --with-cpu=power8) on a little endian power8

[PATCH, rs6000] Avoid optimization problem for VEC_PERM_EXPR

2014-01-23 Thread Bill Schmidt
Hi, While testing another patch, I hit a regression at -O2 for two of the vector shuffle tests. This patch fixes the problem. The problem was introduced with the little endian fixes for VEC_PERM_EXPR. The original change performed the necessary transformation at expand time, but this is

Re: [PATCH] add __attribute__ ((designated_init))

2014-01-23 Thread Tom Tromey
Joseph I think the test should also cover cases with designators such Joseph as .d.x = 1. +static tree handle_designated_init (tree *, tree, tree, int, bool *); Joseph handle_designated_init_attribute would seem a better name. + error (designated_init attribute is only valid on struct

[PATCH, rs6000] Implement -maltivec=be for vec_mergeh and vec_mergel Altivec builtins

2014-01-23 Thread Bill Schmidt
Hi, This patch continues the series of changes to the Altivec builtins to accommodate big-endian element order when targeting a little endian machine. Here the focus is on the vector merge-high and merge-low operations. The primary change is in altivec.md. As an example, look at the pattern

[Google gcc-4_8] always emit __gcov_get_profile_prefix when linking libgcov.a

2014-01-23 Thread Rong Xu
Hi, This patch is for google/gcc-4_8 branch. It fixes a regression in earlier libgcov refactoring. Thanks, -Rong 2014-01-23 Rong Xu x...@google.com * libgcov-driver.c (__gcov_get_profile_prefix): Always emit this function. Index: libgcov-driver.c

Re: [Google gcc-4_8] always emit __gcov_get_profile_prefix when linking libgcov.a

2014-01-23 Thread Xinliang David Li
ok. David On Thu, Jan 23, 2014 at 4:21 PM, Rong Xu x...@google.com wrote: Hi, This patch is for google/gcc-4_8 branch. It fixes a regression in earlier libgcov refactoring. Thanks, -Rong 2014-01-23 Rong Xu x...@google.com * libgcov-driver.c (__gcov_get_profile_prefix):

Re: [PATCH] Set correct probability for ORDER/UNORDER jumps

2014-01-23 Thread Xinliang David Li
Is it possible to add a test case? David On Wed, Jan 22, 2014 at 6:08 PM, Dehao Chen de...@google.com wrote: During floating point comparison, compiler inserts conditional jumps to check if the operand is NAN. These type of checks are normally false. However, compiler sets the probability the

Re: [PATCH #2] PR59909, Fix powerpcle64 power8 bootstrap (quad memory support)

2014-01-23 Thread David Edelsohn
On Thu, Jan 23, 2014 at 6:35 PM, Michael Meissner meiss...@linux.vnet.ibm.com wrote: This is my fixed patch that correctly swaps the words for atomic quad memory accesses in little endian. It would be nice in the future to eliminate some of the extra moves for things like compare and add.

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread Jan Hubicka
Hi, this is improved patch I am testing. The basic idea is to remove push expanders for cases where we do not have push instruction anyway. emit_move_insns then resorts to unconditonally call move expander with push operand. I expended ix86_expand_vector_move to handle it gracefully and for that

Re: [PATCH, rs6000] Avoid optimization problem for VEC_PERM_EXPR

2014-01-23 Thread David Edelsohn
On Thu, Jan 23, 2014 at 6:43 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Hi, While testing another patch, I hit a regression at -O2 for two of the vector shuffle tests. This patch fixes the problem. The problem was introduced with the little endian fixes for VEC_PERM_EXPR. The

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread H.J. Lu
On Thu, Jan 23, 2014 at 4:39 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this is improved patch I am testing. The basic idea is to remove push expanders for cases where we do not have push instruction anyway. emit_move_insns then resorts to unconditonally call move expander with push operand.

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread Jan Hubicka
This piece code is wrong for x32: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59929 Though an independent bug ;) I am testing: diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index ddc3be6..92e8fd0 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@

Go patch committed: Convert named types before flattening

2014-01-23 Thread Ian Lance Taylor
This patch to the Go frontend from Chris Manghane converts named types before the flattening pass. This will permit the flattening pass to get the size of types where necessary. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 124e26b93f79

Re: [PATCH, rs6000] Avoid optimization problem for VEC_PERM_EXPR

2014-01-23 Thread Bill Schmidt
On Thu, 2014-01-23 at 19:42 -0500, David Edelsohn wrote: On Thu, Jan 23, 2014 at 6:43 PM, Bill Schmidt wschm...@linux.vnet.ibm.com wrote: Hi, While testing another patch, I hit a regression at -O2 for two of the vector shuffle tests. This patch fixes the problem. The problem was

[jit] Add contrib/jit-coverage-report.py

2014-01-23 Thread David Malcolm
Whilst reimplementing the API to remove the need to use callbacks, I noticed that although all the tests were passing, some API functions were still stubbed out in my new implementation i.e. we're missing test coverage. The following script (crudely) determines which API symbols are used in which

RE: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2014-01-23 Thread Bernd Edlinger
Hi, On Thu, 23 Jan 2014 18:12:45, Jakub Jelinek wrote: On Wed, Jan 22, 2014 at 09:16:02AM +0100, Dodji Seketeli wrote: +static fcache* +add_file_to_cache_tab (const char *file_path) +{ + + FILE *fp = fopen (file_path, r); + if (ferror (fp)) + { + fclose (fp); + return NULL; + }

Re: Disable accumulate-outgoing-args for Generic and Buldozers

2014-01-23 Thread H.J. Lu
On Thu, Jan 23, 2014 at 4:54 PM, Jan Hubicka hubi...@ucw.cz wrote: This piece code is wrong for x32: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59929 Though an independent bug ;) I am testing: diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index ddc3be6..92e8fd0 100644

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2014-01-23 Thread Dodji Seketeli
Jakub Jelinek ja...@redhat.com writes: On Wed, Jan 22, 2014 at 09:16:02AM +0100, Dodji Seketeli wrote: +static fcache* +add_file_to_cache_tab (const char *file_path) +{ + + FILE *fp = fopen (file_path, r); + if (ferror (fp)) +{ + fclose (fp); + return NULL; +}