Re: Move DECL_INIT_PRIORITY/FINI_PRIORITY to symbol table

2014-06-23 Thread Jan Hubicka
Jan Hubicka hubi...@ucw.cz writes: this patch moves init and fini priorities to symbol table instead of trees. They are already in on-side hashtables, but the hashtables are now maintaned by symbol table. This is needed for correctness with LTO. This breaks gcc.dg/initpri3.c. The

[PATCH, 1/10] two hooks for conditional compare (ccmp)

2014-06-23 Thread Zhenqiang Chen
Hi, The patch adds two hooks for backends to generate conditional compare instructions. * gen_ccmp_first is for the first compare. * gen_ccmp_next is for for the following compares. The patch is separated from https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. And the original

[PATCH, 2/10] prepare ccmp

2014-06-23 Thread Zhenqiang Chen
Hi, The patch makes several functions global, which will be used when expanding ccmp instructions. The other change in this patch is to check CCMP when turning code into jumpy sequence. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org

[PATCH, 3/10] skip swapping operands used in ccmp

2014-06-23 Thread Zhenqiang Chen
Hi, Swapping operands in a ccmp will lead to illegal instructions. So the patch disables it in simplify_while_replacing. The patch is separated from https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. To make it clean. The patch adds two files: ccmp.{c,h} to hold all new ccmp related

[PATCH, 4/10] expand ccmp

2014-06-23 Thread Zhenqiang Chen
Hi, This patch includes the main logic to expand ccmp instructions. In the patch, * ccmp_candidate_p is used to identify the CCMP candidate * expand_ccmp_expr is the main entry, which calls expand_ccmp_expr_1 to expand CCMP. * expand_ccmp_expr_1 uses a recursive algorithm to expand

[PATCH, 5/10] aarch64: add ccmp operand predicate

2014-06-23 Thread Zhenqiang Chen
Hi, The patches defines ccmp operand predicate for AARCH64. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org * config/aarch64/aarch64-protos.h (aarch64_uimm5): New prototype. * config/aarch64/constraints.md (Usn): Immediate for

[PATCH, 6/10] aarch64: add ccmp CC mode

2014-06-23 Thread Zhenqiang Chen
Hi, The patches add a set of CC mode for AARCH64, which is similar as them for ARM. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org * config/aarch64/aarch64-modes.def: Define new CC modes for ccmp. * config/aarch64/aarch64.c

[PATCH, 7/10] aarch64: add function to output ccmp insn

2014-06-23 Thread Zhenqiang Chen
Hi, The patch adds three help functions to output ccmp instructions. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org * config/aarch64/aarch64-protos.h (aarch64_output_ccmp): New prototype. * config/aarch64/aarch64.c

[PATCH, 9/10] aarch64: generate conditional compare instructions

2014-06-23 Thread Zhenqiang Chen
Hi, The patches implements the two hooks for AARCH64 to generate ccmp instructions. Bootstrap and no make check regression on qemu. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org * config/aarch64/aarch64.c (aarch64_code_to_ccmode):

[PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-06-23 Thread Zhenqiang Chen
Hi, The patch enhances ifcvt to handle conditional compare instruction (ccmp) to make it work with cmov. For ccmp, ALLOW_CC_MODE is set to TRUE when calling canonicalize_condition. And the backend does not need to generate additional compare (CC, 0) for it. Bootstrap and no check regression on

[PATCH, 8/10] aarch64: ccmp insn patterns

2014-06-23 Thread Zhenqiang Chen
Hi, The patch adds two insn patterns for ccmp instructions. cbranchcc4 is introduced to generate optimized conditional branch without an additional compare against the result of ccmp. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-06-23 Zhenqiang Chen zhenqiang.c...@linaro.org *

Re: [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-06-23 Thread Andrew Pinski
On Mon, Jun 23, 2014 at 12:01 AM, Zhenqiang Chen zhenqiang.c...@linaro.org wrote: Hi, The patch enhances ifcvt to handle conditional compare instruction (ccmp) to make it work with cmov. For ccmp, ALLOW_CC_MODE is set to TRUE when calling canonicalize_condition. And the backend does not need

Re: [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-06-23 Thread Andrew Pinski
On Mon, Jun 23, 2014 at 12:09 AM, Andrew Pinski pins...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:01 AM, Zhenqiang Chen zhenqiang.c...@linaro.org wrote: Hi, The patch enhances ifcvt to handle conditional compare instruction (ccmp) to make it work with cmov. For ccmp, ALLOW_CC_MODE is set

Re: calloc = malloc + memset

2014-06-23 Thread Jakub Jelinek
On Tue, Jun 03, 2014 at 04:00:17PM +0200, Marc Glisse wrote: Ping? Ok for trunk, sorry for the delay. Jakub

Re: [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-06-23 Thread Zhenqiang Chen
On 23 June 2014 15:09, Andrew Pinski pins...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:01 AM, Zhenqiang Chen zhenqiang.c...@linaro.org wrote: Hi, The patch enhances ifcvt to handle conditional compare instruction (ccmp) to make it work with cmov. For ccmp, ALLOW_CC_MODE is set to TRUE

Re: [PATCH, 10/10] aarch64: Handle ccmp in ifcvt to make it work with cmov

2014-06-23 Thread pinskia
On Jun 23, 2014, at 12:37 AM, Zhenqiang Chen zhenqiang.c...@linaro.org wrote: On 23 June 2014 15:09, Andrew Pinski pins...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:01 AM, Zhenqiang Chen zhenqiang.c...@linaro.org wrote: Hi, The patch enhances ifcvt to handle conditional compare

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Richard Biener
On Mon, 23 Jun 2014, Jan Hubicka wrote: On Fri, 13 Jun 2014, Jan Hubicka wrote: When you extract the address and use it. For example when you do auto-parallelization and outline a part of your function it passes arrays as addresses. Or if you start to

RE: [PATCH] Change default for --param allow-...-data-races to off

2014-06-23 Thread Bernd Edlinger
Hi, On Fri, 20 Jun 2014 13:44:18, Martin Jambor wrote: Hi, On Thu, Jun 19, 2014 at 06:18:47PM +0200, Bernd Edlinger wrote: Hi, from a recent discussion on g...@gcc.gnu.org I have learned that the default of --param allow-store-data-races is still 1, and it is causing problems.

Re: [AArch64] Implement ADD in vector registers for 32-bit scalar values.

2014-06-23 Thread Marcus Shawcroft
On 19 June 2014 14:12, James Greenhalgh james.greenha...@arm.com wrote: This has been sitting waiting for comment for a while now. If we do need a mechanism to describe individual costs for alternatives, it will need applied to all the existing uses in aarch64.md/aarch64-simd.md. I think

Re: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:41 PM, Thomas Preud'homme thomas.preudho...@arm.com wrote: From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Tuesday, June 10, 2014 5:05 PM Backports are welcome - please post a patch. Sorry for the delay. Here you are: diff --git

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Martin Jambor
Hi, On Mon, Jun 23, 2014 at 04:55:36AM +0200, Jan Hubicka wrote: On Fri, 13 Jun 2014, Jan Hubicka wrote: When you extract the address and use it. For example when you do auto-parallelization and outline a part of your function it passes arrays as addresses.

Re: [PATCH] Remove bogus include path with in-tree cloog

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 6:52 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I have noticed there is a minor flaw with the include path when cloog is installed in-tree. That is, the cloog-include directory is added twice, first with absolute path, and then again with relative

Re: [PATCH][AArch64] Fix some saturating math NEON intrinsics types

2014-06-23 Thread Marcus Shawcroft
On 20 June 2014 15:14, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Sure, but it depends on https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00779.html. Is it ok to backport that one as well? This can be backported as well. /Marcus

Re: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Jakub Jelinek
On Mon, Jun 23, 2014 at 10:18:16AM +0200, Richard Biener wrote: --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -1741,6 +1741,8 @@ find_bswap_1 (gimple stmt, struct symbolic_number *n, int limit) if (n-size % BITS_PER_UNIT != 0) return NULL_TREE;

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Richard Biener
On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and found the file mpn/generic/get_str.c was

Re: [PATCH, PR61554] ICE during CCP

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 7:32 AM, Chung-Lin Tang clt...@codesourcery.com wrote: Hi Richard, In this change: https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01278.html where substitute_and_fold() was changed to use a dom walker, the calls to purge dead EH edges during the walk can alter the

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 10:02 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Fri, 20 Jun 2014 13:44:18, Martin Jambor wrote: Hi, On Thu, Jun 19, 2014 at 06:18:47PM +0200, Bernd Edlinger wrote: Hi, from a recent discussion on g...@gcc.gnu.org I have learned that the default

RE: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Thomas Preud'homme
From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Monday, June 23, 2014 4:37 PM On Mon, Jun 23, 2014 at 10:18:16AM +0200, Richard Biener wrote: --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -1741,6 +1741,8 @@ find_bswap_1 (gimple stmt, struct symbolic_number *n,

Re: [GSoC] [match-and-simplify] check for capture index

2014-06-23 Thread Richard Biener
On Wed, Jun 18, 2014 at 3:07 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Put a check for capture index. * genmatch.c (parse_capture): Add condition to check capture index. (capture_max): New constant. (stdlib.h): Include. I'd rather

Re: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Jakub Jelinek
On Mon, Jun 23, 2014 at 04:50:49PM +0800, Thomas Preud'homme wrote: Sent: Monday, June 23, 2014 4:37 PM On Mon, Jun 23, 2014 at 10:18:16AM +0200, Richard Biener wrote: --- a/gcc/tree-ssa-math-opts.c +++ b/gcc/tree-ssa-math-opts.c @@ -1741,6 +1741,8 @@ find_bswap_1 (gimple stmt,

RE: [PATCH][MIPS] Enable load-load/store-store bonding

2014-06-23 Thread Sameera Deshpande
Hi Richard, Thanks for your comments. I am working on the review comments, and will share the reworked patch soon. However, here is clarification on some of the issues raised. + if (TARGET_FIX_24K TUNE_P5600) +error (unsupported combination: %s, -mtune=p5600 -mfix-24k); + /*

RE: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Thomas Preud'homme
From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Monday, June 23, 2014 4:59 PM Host could e.g. in theory have CHAR_BIT 32, while target BITS_PER_UNIT 8 (otherwise bswap pass would give up). sizeof (unsigned HOST_WIDE_INT) could very well be 2 in that case. In this case the pass would

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Ramana Radhakrishnan
On 20/06/14 21:28, Richard Henderson wrote: There aren't too many users of the cmpelim pass, and previously they were all small embedded targets without an FPU. I'm a bit surprised that Ramana decided to enable this pass for aarch64, as that target is not so limited as the block comment for

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Sebastian Pop
Please add a FIXME note in graphite_regenerate_ast_isl saying that this is not yet a full implementation of the code generator with ISL ASTs. It would be useful to make the current graphite_regenerate_ast_isl working by calling graphite_regenerate_ast_cloog and adding the fixme note above saying

RE: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Thomas Preud'homme
From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme However although the original comments on struct symbolic_number implies that there is a mapping between host bytes (the bytes of the symbolic number) and target bytes, it isn't the

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Tobias Grosser
Thanks Sebastian for the review! It is good to see you again on the mailing list! On 23/06/2014 11:29, Sebastian Pop wrote: Please add a FIXME note in graphite_regenerate_ast_isl saying that this is not yet a full implementation of the code generator with ISL ASTs. It would be useful to make

Re: [PATCH][MIPS] Enable load-load/store-store bonding

2014-06-23 Thread Richard Sandiford
Sameera Deshpande sameera.deshpa...@imgtec.com writes: + if (TARGET_FIX_24K TUNE_P5600) +error (unsupported combination: %s, -mtune=p5600 -mfix-24k); + /* Save the base compression state and process flags as though we were generating uncompressed code. */

[PATCH]Enable elimination of IV use with unsigned type candidate

2014-06-23 Thread Bin Cheng
Hi, For below simplified case: #define LEN (32000) __attribute__((aligned(16))) float a[LEN],b[LEN]; int foo (int M) { for (int i = 0; i M; i++) a[i+M] = a[i] + b[i]; } Compiling it with command like: $ aarch64-elf-gcc -O3 -S foo.c -o foo.S -std=c99 The assembly code of vectorized loop

[PATCH 4.9 ARM] Backport r210219: Neon Intrinsics TLC - remove ML

2014-06-23 Thread Alan Lawrence
As for 4.8, I'm intending to backport the ZIP/UZP/TRN fix for ARM big-endian in r211369 of mainline. That patches arm_neon.h, so again we need to remove the OCAML code by which that file is autogenerated...ok? --Alancommit e83cb5fff3687316ff391e9e7a8c65df2d35c880 Author: Alan Lawrence

RE: [PATCH,MIPS] MIPS64r6 support

2014-06-23 Thread Matthew Fortune
Richard Sandiford rdsandif...@googlemail.com writes: Sorry for the slow review. And my slow response :-) Matthew Fortune matthew.fort...@imgtec.com writes: The initial support for MIP64r6 is intentionally minimal to make review easier. Performance enhancements and use of new MIPS64r6

[patch libgcc]: Fix PR libgcc/61585 Subscript-out-of-range in unwind-seh.c

2014-06-23 Thread Kai Tietz
Hi, this fixes a potential out-of-bound access in unwind-seh's GetGr/SetGr function. ChangeLog 2014-06-23 Kai Tietz kti...@redhat.com PR libgcc/61585 * unwind-seh.c (_Unwind_GetGR): Check for proper index range. (_Unwind_SetGR): Likewise. I will apply this patch after

Re: Fortran OpenMP UDR fixes, nested handling fixes etc.

2014-06-23 Thread Jakub Jelinek
On Sat, Jun 21, 2014 at 10:28:41AM +0200, Tobias Burnus wrote: Jakub Jelinek wrote: Bootstrap/regtest pending, does this look ok? Except for the module/resolved issues discussed elsewhere, it look good to me. So, either we need something like the following patch (incremental), or another

Re: [PATCH][AArch64] Fix some saturating math NEON intrinsics types

2014-06-23 Thread Kyrill Tkachov
On 23/06/14 09:26, Marcus Shawcroft wrote: On 20 June 2014 15:14, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Sure, but it depends on https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00779.html. Is it ok to backport that one as well? This can be backported as well. /Marcus Thanks, I've

Re: [PATCH][AArch64] Fix some saturating math NEON intrinsics types

2014-06-23 Thread Kyrill Tkachov
On 23/06/14 11:52, Kyrill Tkachov wrote: On 23/06/14 09:26, Marcus Shawcroft wrote: On 20 June 2014 15:14, Kyrill Tkachov kyrylo.tkac...@arm.com wrote: Sure, but it depends on https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00779.html. Is it ok to backport that one as well? This can be

[patch] fix std::chrono::duration literals

2014-06-23 Thread Jonathan Wakely
This fixes errors when using 0s or 1'000s to create durations. Tested x86_64-linux, committed to trunk. commit c57e645222ac9bf476ef5b6414773b5f4e2b86fc Author: Jonathan Wakely jwak...@redhat.com Date: Sun Jun 22 18:06:42 2014 +0100 * include/bits/parse_numbers.h (_Number_help): Fix

[PATCH] Fix for PR 61561

2014-06-23 Thread Marat Zakirov
Hi all, Here's my new patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). Which fixes ICE appeared due to QI/HI pattern lack in arm.md for stack pointer register. Reg. tested on arm-v7. --Marat arm.diff Description: Binary data

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

2014-06-23 Thread Marek Polacek
On Sun, Jun 22, 2014 at 10:33:57PM +0200, Gerald Pfeifer wrote: On Mon, 2 Jun 2014, Marek Polacek wrote: * c-typeck.c (parser_build_binary_op): Warn when logical not is used on the left hand side operand of a comparison. This... +/* Warn about logical not used on the left hand

Re: [patch] Update libstdc++ FAQ and ensure stable anchors in HTML docs

2014-06-23 Thread Jonathan Wakely
On 22/06/14 22:40 +0200, Gerald Pfeifer wrote: On Mon, 9 Jun 2014, Jonathan Wakely wrote: This fairly tedious patch refreshes the FAQ, including adding some notes saying This answer is old and probably no longer relevant to several answers referring to problems in the GCC 3.x era. I'm

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-06-23 Thread Jay Foad
On 2 May 2014 10:04, Kugan kugan.vivekanandara...@linaro.org wrote: Thanks for spotting it. Here is the updated patch that changes it to ARM_FE_*. +2014-05-02 Kugan Vivekanandarajah kug...@linaro.org + + * config/arm/arm.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New define. +

Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

2014-06-23 Thread James Greenhalgh
On Thu, Jun 19, 2014 at 12:49:55PM +0100, Martin Jambor wrote: Hi, On Wed, Jun 18, 2014 at 06:12:34PM +0200, Bernhard Reutner-Fischer wrote: On 18 June 2014 10:24:16 Martin Jambor mjam...@suse.cz wrote: @@ -3002,10 +3014,8 @@ try_make_edge_direct_virtual_call (struct cgraph_edge *ie,

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
Thank you for the review! -- Cheers, Roman Gareev ChangeLog_entry1 Description: Binary data ChangeLog_entry2 Description: Binary data patch1 Description: Binary data patch2 Description: Binary data

Re: [AArch64] Implement ADD in vector registers for 32-bit scalar values.

2014-06-23 Thread Kyrill Tkachov
Hi James, On 19/06/14 14:12, James Greenhalgh wrote: diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 266d7873a5a1b8dbb7f955c3f13cf370920a9c4a..7c5b5a566ebfd907b83b38eed2e214738e7e9bd4 100644 --- a/gcc/config/aarch64/aarch64.md +++

[PATCH][match-and-simplify] Remove now dead code

2014-06-23 Thread Richard Biener
This removes the non-DT matching code. Committed. Richard. 2014-06-23 Richard Biener rguent...@suse.de * genmatch.c (operand::gen_gimple_match): Remove. (predicate::gen_gimple_match): Likewise. (expr::gen_gimple_match): Likewise. (c_expr::gen_gimple_match):

[GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Prathamesh Kulkarni
* match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. Thanks and Regards, Prathamesh Index: gcc/match.pd === --- gcc/match.pd (revision 211893) +++ gcc/match.pd (working copy) @@ -138,7 +138,7 @@ along

RE: [PATCH] Change default for --param allow-...-data-races to off

2014-06-23 Thread Bernd Edlinger
Hi Martin, Well actually, I am not sure if we ever wanted to have a race condition here. Have you seen any impact of --param allow-store-data-races on any benchmark? It's trivially to write one. The only pass that checks the param is tree loop invariant motion and it does that when it

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
It seems the patch1/patch2 files you attach have the Content-Type: application/octet-stream. This makes it impossible to view them inline. Could you send them as text files? Just calling them patch1.patch or patch1.txt should make this work. Yes, sure. diff --git

[GSoC][match-and-simplify] Remove gen_gimple_match_fail

2014-06-23 Thread Prathamesh Kulkarni
* genmatch.c (gen_gimple_match_fail): Remove. (expr::gen_gimple_transform): Remove call to gen_gimple_match_fail. Change fprintf (f, if (!res)) to fprintf (f, if (!res) return false;\n) Thanks and Regards, Prathamesh Index: gcc/genmatch.c

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Richard Henderson
On 06/23/2014 02:29 AM, Ramana Radhakrishnan wrote: On 20/06/14 21:28, Richard Henderson wrote: There aren't too many users of the cmpelim pass, and previously they were all small embedded targets without an FPU. I'm a bit surprised that Ramana decided to enable this pass for aarch64, as

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. /* A - (A +- B) - -+ B */ (match_and_simplify - (minus @0 (plus @0 @1)) + (minus @0 (plus:c @0 @1)) (negate @0))

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Henderson
On 06/20/2014 02:59 PM, Kai Tietz wrote: So I suggest following change of passes.def: Index: passes.def === --- passes.def (Revision 211850) +++ passes.def (Arbeitskopie) @@ -384,7 +384,6 @@ along with GCC; see the file

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. /* A - (A +- B) - -+ B */ (match_and_simplify - (minus @0 (plus @0 @1)) +

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-06-23 Thread Richard Henderson
On 06/20/2014 01:42 PM, Marek Polacek wrote: 2014-06-20 Marek Polacek pola...@redhat.com * genpreds.c (verify_rtx_codes): New function. (main): Call it. * rtl.h (RTX_FLD_WIDTH, RTX_HWINT_WIDTH): Define. (struct rtx_def): Use them. Looks pretty good. Just a few

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Eric Botcazou
I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and found the file mpn/generic/get_str.c was miscompiled. mpn/get_str.c.132t.dse2: pretmp_183 = (sizetype) chars_per_limb_80;

RE: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Bernd Edlinger
Hi, On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one,

[AArch64] Implement some vca*_f[32,64] intrinsics

2014-06-23 Thread Kyrill Tkachov
Hi all, This patch implements some absolute compare intrinsics in arm_neon.h. Execution tests are added. Tested aarch64-none-elf, aarch64_be-none-elf, bootstrapped on aarch64 linux Ok for trunk? 2014-06-23 Kyrylo Tkachov kyrylo.tkac...@arm.com * config/aarch64/arm_neon.h (vcage_f64):

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:13 PM, Richard Henderson r...@redhat.com wrote: On 06/20/2014 02:59 PM, Kai Tietz wrote: So I suggest following change of passes.def: Index: passes.def === --- passes.def (Revision 211850) +++

Re: [GSoC][match-and-simplify] Remove gen_gimple_match_fail

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:43 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * genmatch.c (gen_gimple_match_fail): Remove. (expr::gen_gimple_transform): Remove call to gen_gimple_match_fail. Change fprintf (f, if (!res)) to fprintf (f, if (!res) return false;\n) Thanks,

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative.

[PATCH] Don't segv on __atomic_store (PR c/61553)

2014-06-23 Thread Marek Polacek
We ICEd on the following testcase since the void type has a NULL TYPE_SIZE_UNIT. I took Andrew's patch from gcc@ ML and added a testcase. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-06-23 Marek Polacek pola...@redhat.com Andrew MacLeod amacl...@redhat.com

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:25 PM, Richard Henderson r...@redhat.com wrote: On 06/20/2014 01:42 PM, Marek Polacek wrote: 2014-06-20 Marek Polacek pola...@redhat.com * genpreds.c (verify_rtx_codes): New function. (main): Call it. * rtl.h (RTX_FLD_WIDTH, RTX_HWINT_WIDTH):

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

2014-06-23 Thread Joseph S. Myers
On Mon, 23 Jun 2014, Marek Polacek wrote: I think the latter is better, incidentally, g++ doesn't warn either. The following one liner makes cc1 behave as cc1plus. Thanks for the report. Regtested/bootstrapped on x86_64. Joseph, is this ok? 2014-06-23 Marek Polacek pola...@redhat.com

Re: [Patch ARM/testsuite 00/22] Neon intrinsics executable tests

2014-06-23 Thread Christophe Lyon
On 11 June 2014 00:03, Ramana Radhakrishnan ramana@googlemail.com wrote: On Thu, Jun 5, 2014 at 11:04 PM, Christophe Lyon christophe.l...@linaro.org wrote: This is patch series is a more complete version of the patch I sent some time ago:

[PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Paul Gortmaker
We see the following on a 32bit gcc installed on 64 bit host: Reading symbols from ./i586-pokymllib32-linux-gcc...done. (gdb) run Starting program: x86-pokymllib32-linux/lib32-gcc/4.9.0-r0/image/usr/bin/i586-pokymllib32-linux-gcc Program received signal SIGSEGV, Segmentation fault.

Link not working on www.mail-archive.com

2014-06-23 Thread Lisa
Looks like there is a broken link on http://www.mail-archive.com/ftikumt2001@yahoogroups.com/msg00234.html to http://www.cs.cmu.edu/books.html. You might also want to add some of these resources I found useful...

Re: [C++ Patch] PR 33101

2014-06-23 Thread Jason Merrill
On 06/22/2014 10:42 AM, Paolo Carlini wrote: I think the below would be most of it. Today, however, I did some archeology, noticed that we would essentially revert to pre-PR9278 behavior (thus, per its audit trail, make again unhappy some people in the template metaprogramming world?!? Was that

PR61583, stage2 and stage3 compare failure due to value range loss

2014-06-23 Thread Alan Modra
This fixes a bootstrap compare failure on current mainline and 4.9 branch configured with --disable-checking, caused by losing value range info when outputting debug info. Lack of value range info leads to loop bounds not being calculated, which in turn means a j n test is not converted to j !=

[Patch, AArch64] Restructure arm_neon.h vector types' implementation.

2014-06-23 Thread Tejas Belagod
Hi, Here is a patch that restructures neon builtins to use vector types based on standard base types. We previously defined arm_neon.h's neon vector types(int8x8_t) using gcc's front-end vector extensions. We now move away from that and use types built internally(e.g. __Int8x8_t). These

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where the testsuite is ok :-) I need strlen to be after dom (for calloc.C) and before vrp (for several strlenopt-*.c). I'll

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Ramana Radhakrishnan
On 23/06/14 15:01, Richard Henderson wrote: On 06/23/2014 02:29 AM, Ramana Radhakrishnan wrote: On 20/06/14 21:28, Richard Henderson wrote: There aren't too many users of the cmpelim pass, and previously they were all small embedded targets without an FPU. I'm a bit surprised that Ramana

Re: [AArch64] Implement ADD in vector registers for 32-bit scalar values.

2014-06-23 Thread James Greenhalgh
On Mon, Jun 23, 2014 at 01:53:28PM +0100, Kyrill Tkachov wrote: On 19/06/14 14:12, James Greenhalgh wrote: diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 266d7873a5a1b8dbb7f955c3f13cf370920a9c4a..7c5b5a566ebfd907b83b38eed2e214738e7e9bd4 100644 ---

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where the testsuite is ok :-) I need strlen to be

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Jan Hubicka
I don't like this very much. It's fragile and it will be very hard to detect bugs caused by it. Please don't spread uses of the DECL_NONALIASED hack. If we are only concerned about LTO I'd rather have a in_lto_p check in may_be_aliased and trust TREE_ADDRESSABLE there. I do not like it

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Richard Biener
On June 23, 2014 6:15:10 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: I don't like this very much. It's fragile and it will be very hard to detect bugs caused by it. Please don't spread uses of the DECL_NONALIASED hack. If we are only concerned about LTO I'd rather have a in_lto_p check in

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Richard Biener wrote: On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where

[Patch] Not very subtle fix for pr61510

2014-06-23 Thread James Greenhalgh
Hi, pr61510 is a case where cgraphunit.c::analyze_functions can end up dereferencing a NULL pointer. This is, to me, the obvious way to avoid dereferencing NULL. However, I'm not very confident that this isn't just masking some horrible and subtle bug, so I'd like some review feedback on the

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Jan Hubicka
On June 23, 2014 6:15:10 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: I don't like this very much. It's fragile and it will be very hard to detect bugs caused by it. Please don't spread uses of the DECL_NONALIASED hack. If we are only concerned about LTO I'd rather have a in_lto_p

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Jeff Law
On 06/23/14 08:32, Richard Biener wrote: On Mon, Jun 23, 2014 at 4:13 PM, Richard Henderson r...@redhat.com wrote: On 06/20/2014 02:59 PM, Kai Tietz wrote: So I suggest following change of passes.def: Index: passes.def === ---

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Jeff Law
On 06/22/14 01:14, Bernd Edlinger wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and found the file mpn/generic/get_str.c was miscompiled. It's interesting you stumbled on

Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-23 Thread H.J. Lu
On Sun, Jun 22, 2014 at 11:23 AM, Uros Bizjak ubiz...@gmail.com wrote: On Sat, Jun 21, 2014 at 8:07 PM, Jakub Jelinek ja...@redhat.com wrote: --- gcc/config/i386/driver-i386.c.jj2014-05-14 14:45:54.0 +0200 +++ gcc/config/i386/driver-i386.c 2014-06-20 18:59:57.805006358

Re: [PATCH] DWARFv5 Emit DW_TAG_atomic_type.

2014-06-23 Thread Tom Tromey
Mark == Mark Wielaard m...@redhat.com writes: Mark The following is just a prototype to try out a new qualifier type tag Mark proposed for DWARFv5. There is not even a draft yet of DWARFv5, so this Mark is just based on a proposal that might or might not be adopted and/or Mark changed

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Richard Biener
On Mon, 23 Jun 2014, James Greenhalgh wrote: Hi, pr61510 is a case where cgraphunit.c::analyze_functions can end up dereferencing a NULL pointer. This is, to me, the obvious way to avoid dereferencing NULL. However, I'm not very confident that this isn't just masking some horrible and

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:38 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: *

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Henderson
On 06/23/2014 09:22 AM, Jeff Law wrote: On 06/23/14 08:32, Richard Biener wrote: Btw, there is now no DCE after peephole2? Is peephole2 expected to cleanup after itself? There were cases where we wanted to change the insns we would output to fit into the 4:1:1 issue model of the PPro, but to

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 6:19 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has

Re: Another AIX Bootstrap failure

2014-06-23 Thread Dominique Dhumieres
The tests gcc.dg/globalalias-2.c and gcc.dg/localalias-2.c fail on darwin with /opt/gcc/work/gcc/testsuite/gcc.dg/globalalias-2.c:20:2: warning: alias definitions not supported in Mach-O; ignored I think they should be protected by /* { dg-require-alias } */ Dominique

Re: [PATCH][RFC] Gate loop passes group on number-of-loops 1, add no-loops group

2014-06-23 Thread Richard Biener
On Wed, 18 Jun 2014, Jeff Law wrote: On 06/18/14 04:42, Richard Biener wrote: The following aims at reducing the number of pointless passes we run on functions containing no loops. Those are at least two copyprop and one dce pass (two dce passes when vectorization is enabled, three

Re: [PATCH] Don't segv on __atomic_store (PR c/61553)

2014-06-23 Thread Joseph S. Myers
On Mon, 23 Jun 2014, Marek Polacek wrote: We ICEd on the following testcase since the void type has a NULL TYPE_SIZE_UNIT. I took Andrew's patch from gcc@ ML and added a testcase. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-06-23 Marek Polacek pola...@redhat.com

Re: [PATCH 3/3] add hash_map class

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch adds a hash_map class so we can consolidate the boiler plate around using hash_table as a map, it also allows us to get rid of pointer_map which I do in this patch by

Re: [PATCH] Fix for invalid sanitization of trailing byte in __builtin_strlen

2014-06-23 Thread Maxim Ostapenko
Hi, when I applied this patch (r211846), I made a little mistake in output test patterns. This patch fixes this. Tested on x86_64-unknown-linux-gnu. Ok to commit? -Maxim gcc/testsuite/ChangeLog: 2014-06-23 Max Ostapenko m.ostape...@partner.samsung.com *

Re: [PATCH 2/N] allow storing values directly in hash tables

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, this patch allows you to define the type the hash table stores as elements instead of the type elements point at by having your hash descriptor define the type

  1   2   >