Re: [4.9 RFA PATCH, RTL-optimization]: Backport recent AND-alignment alias fixes to 4.9 branch

2014-11-04 Thread Uros Bizjak
Ping for [1], quoted below. [1] https://gcc.gnu.org/ml/gcc-patches/2014-10/msg03189.html Thanks, Uros. On Thu, Oct 30, 2014 at 11:38 AM, Uros Bizjak wrote: > Hello! > > I would like to backport recent alias fixes to correctly handle memory > references with AND-alignment to 4.9 branch. These pa

[PATCH][MIPS] Fix P5600 memory cost

2014-11-04 Thread Prachi Godbole
Hi, The patch below fixes the memory cost for P5600. ChangeLog: 2014-11-05 Prachi Godbole * config/mips/mips.c (mips_rtx_cost_data): Fix memory_letency cost for p5600. diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c index af6a913..558ba2f 100644 --- a/gcc/config/mips/mips.c +++

[PATCH, PR63742][ARM] Fix arm *movhi_insn_arch4 pattern for big-endian

2014-11-04 Thread Yangfei (Felix)
Hi, This patch fixes PR63742 by improving arm *movhi_insn_arch4 pattern to make it works under big-endian. The idea is simple: Use movw for certain const source operand instead of ldrh. And exclude the const values which cannot be handled by mov/mvn/movw. I am doing regression tes

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
I committed the change to go-test.exp. Thanks. The other changes are not OK. As described in gcc/testsuite/go.test/test/README.gcc, the files in gcc/testsuite/go.test/test are an exact copy of the master Go testsuite. Any changes must be made to the master Go testsuite first. I don't know what

Re: [gofrontend-dev] [PATCH 0/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote: > > This is the second set of patches to support s390[x] with Gccgo, > containing mostly architecture dependent parts that affect the > following directories: > Summary of this series: > --- > > 0001: Ports libgo to s390[x].

Re: [gofrontend-dev] [PATCH 3/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
I committed this patch. Thanks. I changed the ChangeLog entry to this, since your ChangeLog entry didn't seem accurate to me. 2014-11-04 Dominik Vogt * go.test/go-test.exp: In +build lines, require whitespace around expected strings, fix check for negation. Ian

Re: [gofrontend-dev] [PATCH 2/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
For the rest of this patch, I replied on the bug (http://gcc.gnu.org/PR63269). I'm not persuaded that the approach this patch takes is correct. Ian

Re: [gofrontend-dev] [PATCH 2/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
Part of this patch duplicates a patch that is already applied to the master Go library, so I explicitly backported that patch (https://codereview.appspot.com/111320044) instead. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 3b8f536b76d8 libgo/go

Re: [patch,gomp-4_0-branch] acc nested function support

2014-11-04 Thread Cesar Philippidis
Here's an updated version of my nested function patch. David, I tweaked the gimple class hierarchy a little bit. Here's what the updated class diagram looks like: + gimple_statement_omp | |layout: GSS_OMP. Used for code GIMPLE_OMP_SECTION | | | + gimple_statement_om

Re: nvptx offloading patches [3/n], i386 bits RFD

2014-11-04 Thread Bernd Schmidt
On 11/04/2014 10:50 PM, Jeff Law wrote: No, I don't think it's terminology. It's really that in effect we have two targets. One is a normal CPU, the other is a GPU. ie, there's nothing that says we won't have a GPU that's being driven by an ARM or PPC. What I want to avoid is GPU-isms getting

Re: [Bug libstdc++/63698] [5 Regression] std::set leaks nodes on assignment

2014-11-04 Thread Jonathan Wakely
On 4 November 2014 22:06, François Dumont wrote: > Hi > > Here is more or less the patch proposed on the ticket with the test case > also provided in the ticket. > > 2014-11-04 François Dumont > Jonathan Wakely > > PR libstdc++/63698 > * include/bits/stl_tree.h (_Reuse_or_

Re: nvptx offloading patches [1/n]

2014-11-04 Thread Jeff Law
On 11/04/14 14:08, Bernd Schmidt wrote: On 11/04/2014 10:01 PM, Jeff Law wrote: Communication between host and GPU is all done via some form of memcpy, so I wouldn't expect this to be a problem. They still need to agree on the layout of the structure. That is guaranteed by the fact that struc

[gomp4] Skip nvidia accelerator if not present

2014-11-04 Thread Tom de Vries
Thomas, this patch skips the nvidia accelerator in testing libgomp, if the nvidia accelerator is not present. OK for gomp-4_0-branch? Thanks, - Tom 2014-11-03 Tom de Vries * testsuite/libgomp.oacc-c++/c++.exp: Only use nvidia accelerator if present. * testsuite/libgomp.oacc-c/c.exp: Sa

[gomp4] Fix libgomp-oacc.c/lib-66.c testcase

2014-11-04 Thread Tom de Vries
Thomas, This patch fixes the libgomp-oacc.c/lib-66.c testcase. It allows the test to run for non-shared mem accelerators, and skips the test otherwise. ok for gomp-4_0-branch? Thanks, - Tom 2014-11-03 Tom de Vries * testsuite/libgomp.oacc-c/lib-66.c: Skip for shared memory accelerators

Re: [PATCH] PR36312

2014-11-04 Thread Jeff Law
On 10/25/14 04:20, Anthony Brandon wrote: Hi, Sorry for the delay. Here are the updated diff and changelog. gcc/testsuite/ChangeLog: 2014-10-25 Anthony Brandon PR driver/36312 * gcc.misc-tests/output.exp: New test case for identical input and output files. include/ChangeLog: 20

Re: [gofrontend-dev] [PATCH 1/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote: > See commit comment and ChangeLog for details. Committed patch 0001 with various formatting fixes, as attached. Note that libgo/runtime/runtime.c now refers to S390_HAVE_STCKF. It's not obvious to me that that is defined anywhere. Perhaps it

Re: [C PATCH] Add 'aka's on type printing in diagnostics

2014-11-04 Thread Jeff Law
On 10/25/14 09:16, Marek Polacek wrote: This patch teaches the compiler to also print the typedef-stripped version of a type when appropriate. C++ FE does this for a few years now. With this patch we're able to say note: expected 'B * {aka struct A *}' but argument is of type 'struct B *' Compa

Re: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV for powerpc*-*-linux* soft-float and e500

2014-11-04 Thread Pat Haugen
On 11/01/2014 07:20 AM, Joseph S. Myers wrote: This patch implements support for TARGET_ATOMIC_ASSIGN_EXPAND_FENV for powerpc*-*-linux* soft-float and e500, provided GCC is configured for glibc 2.19 or later on the target. The patch causes a bootstrap error on targets with glibc < 2.19 for defin

[gomp4] Set default LIBGOMP_PLUGIN_PATH

2014-11-04 Thread Tom de Vries
Thomas, this patch sets LIBGOMP_PLUGIN_PATH to the .libs dir in the build area, if LIBGOMP_PLUGIN_PATH has not been defined. This allows f.i. a gcc build without an accelerator configured, to automatically pick up the host_nonshm plugin. OK for gomp-4_0-branch? Thanks, - Tom 2014-11-03 To

Re: [RTL, Patch] Int div by constant compilation enhancement

2014-11-04 Thread Jeff Law
On 11/03/14 10:01, Alex Velenko wrote: Hi, This patch adds a mid-end check to catch division by constant case and optimize it to generate one shift, instead of two. A testacase to check the correct codegeneration for aarch64 is added. This check is not made generic, because the optimisation impl

Re: [PATCH 16/27] New file: gcc/jit/jit-playback.c

2014-11-04 Thread Jeff Law
On 10/31/14 11:02, David Malcolm wrote: This files implements the gcc::jit::playback internal API, called by the dummy "frontend" to replay the public API calls made to the library. A thin wrapper around trees. gcc/jit/ * jit-playback.c: New. + /* line_table should now be populated

Re: [gofrontend-dev] [PATCH 1/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Ian Taylor
On Tue, Nov 4, 2014 at 4:15 AM, Dominik Vogt wrote: > See commit comment and ChangeLog for details. > case "amd64", "386": > + case "s390", "s390x": Note that this doesn't do what you want. In Go, unlike C, cases do not fall through by default. So doing this means that the amd64 and

Re: [Bug libstdc++/63698] [5 Regression] std::set leaks nodes on assignment

2014-11-04 Thread François Dumont
Hi Here is more or less the patch proposed on the ticket with the test case also provided in the ticket. 2014-11-04 François Dumont Jonathan Wakely PR libstdc++/63698 * include/bits/stl_tree.h (_Reuse_or_alloc_node): Simplify constructor. Always move to the left n

Re: [PATCH]Partially fix PR61529, bound basic block frequency

2014-11-04 Thread Jeff Law
On 11/03/14 08:29, Renlin Li wrote: On 29/10/14 12:42, Teresa Johnson wrote: Hi Renlin, Are the incoming edge counts or probabilities insane in this case? I guess the patch is ok if we need to do this to handle those incoming insanitiles. But I can't approve patches myself. Not really, it's j

Re: [PATCH] x86: allow to suppress default clobbers added to asm()s

2014-11-04 Thread Jeff Law
On 11/03/14 01:11, Jan Beulich wrote: I really don't like having an option that's globally applied for this feature. THough I am OK with having a mechanism to avoid implicit clobbers on specific ASMs. Why not? That way, for projects/components knowing all their asm()s have all clobbers explici

Re: nvptx offloading patches [3/n], i386 bits RFD

2014-11-04 Thread Jeff Law
On 11/04/14 05:35, Bernd Schmidt wrote: Ports that want to be hosts for offloading may need to modify their modes.def. The patch below contains changes to i386-modes.def which modifies XFmode depending on a target switch. I'm not actually entirely sure what to do about this. Do we want to make th

Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c

2014-11-04 Thread Jeff Law
On 11/04/14 09:57, David Malcolm wrote: +#define IS_ASCII_DIGIT(CHAR) \ + ((CHAR) >= '0' && (CHAR) <='9') + +#define IS_ASCII_ALNUM(CHAR) \ + (IS_ASCII_ALPHA (CHAR) || IS_ASCII_DIGIT (CHAR)) Can't we rely on the C library to give us equivalents? I've been burned in the past by the C library

Re: [PATCH 13/27] New file: gcc/jit/jit-recording.c

2014-11-04 Thread Jeff Law
On 11/04/14 09:24, David Malcolm wrote: So presumably no multi-way branches yet? Might be better to build the API in such a way that it handles multi-way branches from the get-go rather than retrofitting later. Your call. This is an internal API. If the external API needs to support building

Re: [PATCH 12/27] New file: gcc/jit/jit-recording.h

2014-11-04 Thread Jeff Law
On 11/04/14 09:12, David Malcolm wrote: So give the complexities in interfacing with the guts of GCC, would it make sense to expose the validate method? Most of the error-checking in the API happens in the API calls in libgccjit.c, testing that the individual pieces are sane. The validate meth

Re: nvptx offloading patches [1/n]

2014-11-04 Thread Bernd Schmidt
On 11/04/2014 10:01 PM, Jeff Law wrote: Communication between host and GPU is all done via some form of memcpy, so I wouldn't expect this to be a problem. They still need to agree on the layout of the structure. That is guaranteed by the fact that structure layouts are fixed before we write o

Re: nvptx offloading patches [1/n]

2014-11-04 Thread Jeff Law
On 11/03/14 16:07, Bernd Schmidt wrote: On 11/03/2014 11:22 PM, Jeff Law wrote: On 11/01/14 05:47, Bernd Schmidt wrote: This is one of the patches required to make offloading via the LTO path work when the machines involved differ. x86 requires bigger alignments for some types than nvptx does,

Re: [x86, 2/n] Replace builtins with vector extensions

2014-11-04 Thread Marc Glisse
Ping? https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01808.html On Sat, 18 Oct 2014, Marc Glisse wrote: Hello, this time, +-* for 128 bit integer vectors. I am using an unsigned type so the compiler knows that we expect wrapping. I don't know why Intel's description of mullo insists that the

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Andrew MacLeod
On 11/04/2014 02:53 PM, Richard Biener wrote: On November 4, 2014 7:30:18 PM CET, Andrew MacLeod wrote: On 11/04/2014 12:57 PM, Richard Henderson wrote: On 11/04/2014 06:56 PM, Andrew MacLeod wrote: On 11/04/2014 12:25 PM, Richard Henderson wrote: On 11/04/2014 05:28 PM, Andrew MacLeod wrote

[committed] Remove unused variables

2014-11-04 Thread Marek Polacek
I forgot to remove two unused variables. Applying to trunk as obvious. 2014-11-04 Marek Polacek * sanopt.c (sanopt_optimize_walker): Remove unused variables. diff --git gcc/sanopt.c gcc/sanopt.c index f1d51d1..4483ff7 100644 --- gcc/sanopt.c +++ gcc/sanopt.c @@ -117,9 +117,6 @@ sanop

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Richard Biener
On November 4, 2014 7:30:18 PM CET, Andrew MacLeod wrote: >On 11/04/2014 12:57 PM, Richard Henderson wrote: >> On 11/04/2014 06:56 PM, Andrew MacLeod wrote: >>> On 11/04/2014 12:25 PM, Richard Henderson wrote: On 11/04/2014 05:28 PM, Andrew MacLeod wrote: > + bool > + default_can_comp

Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c

2014-11-04 Thread Jakub Jelinek
On Tue, Nov 04, 2014 at 07:36:26PM +0100, Marek Polacek wrote: > + FOR_EACH_VEC_ELT_REVERSE (v, i, g) > + { > + /* Remove statements for BBs that have been > + already processed. */ > + sanopt_info *si = (sanopt

Re: nvptx offloading patches [3/n], i386 bits RFD

2014-11-04 Thread Uros Bizjak
On Tue, Nov 4, 2014 at 1:35 PM, Bernd Schmidt wrote: >> Not sure how to deal with this any further out than the immediate term >> than using a hack like this. Though I'd prefer to avoid the #ifdef as it >> seems to me this shouldn't be baked in at build/configure time. > > > Yeah, I'm not expecti

Re: [PATCH v2, i386]: Fix PR 63538, With -mcmodel=medium .lrodata accesses do not use 64-bit addresses

2014-11-04 Thread Sriraman Tallam
On Tue, Nov 4, 2014 at 10:47 AM, Uros Bizjak wrote: > On Tue, Nov 4, 2014 at 10:46 AM, Uros Bizjak wrote: > >>> Following patch fixes PR 63538, where the data in the large data >>> section was accessed through 32bit address. The patch unifies places >>> where large data sections are determined an

[PATCH v2, i386]: Fix PR 63538, With -mcmodel=medium .lrodata accesses do not use 64-bit addresses

2014-11-04 Thread Uros Bizjak
On Tue, Nov 4, 2014 at 10:46 AM, Uros Bizjak wrote: >> Following patch fixes PR 63538, where the data in the large data >> section was accessed through 32bit address. The patch unifies places >> where large data sections are determined and passes all declarations >> to ix86_in_large_data_p only.

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread N.M. Maclaren
On Nov 4 2014, Jeff Law wrote: On 11/04/14 09:11, Jakub Jelinek wrote: The point is, if the target can implement just a subset of the Fortran (or C or C++) standards, then ideally if you use anything that is not supported would just cause always host fallback, the code will still work, but w

Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c

2014-11-04 Thread Marek Polacek
On Mon, Nov 03, 2014 at 04:35:00PM +0100, Jakub Jelinek wrote: > Well, in theory you could just script removing them one by one and just > make sanopt.o after each step to see if the header is or is not needed, > perhaps with some manual tweeks. I pruned those headers some more. > Perhaps in pre

Re: libgomp testsuite: (not) using a specific driver for C++, Fortran?

2014-11-04 Thread Mike Stump
On Nov 4, 2014, at 4:13 AM, Thomas Schwinge wrote: > > On Wed, 15 Oct 2014 17:46:48 +0200, I wrote: >> No matter whether it's C, C++, or Fortran source code, the libgomp >> testsuite always uses (for build-tree testing) gcc/xgcc, or (for >> installed testing) GCC_UNDER_TEST. It doesn't make use

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Andrew MacLeod
On 11/04/2014 12:57 PM, Richard Henderson wrote: On 11/04/2014 06:56 PM, Andrew MacLeod wrote: On 11/04/2014 12:25 PM, Richard Henderson wrote: On 11/04/2014 05:28 PM, Andrew MacLeod wrote: + bool + default_can_compare_and_swap_p (machine_mode mode, bool allow_libcall) + { + return can_compa

Re: Recent go changes broke alpha bootstrap

2014-11-04 Thread Uros Bizjak
On Tue, Nov 4, 2014 at 12:20 PM, Uros Bizjak wrote: >>> Bitfields can really not be represented properly in Go (think about >>> constructs like "struct { int : 1; int bf : 1; }"), I'd rather not >>> try to represent them in a predictable way. The patched code may >>> or may not give them a name,

[PATCH, testsuite]: Cleanup dumps

2014-11-04 Thread Uros Bizjak
Hello! 2014-11-04 Uros Bizjak * g++.dg/ipa/devirt-44.C (dg-options): Remove -fdump-tree-optimized. * g++.dg/ipa/devirt-45.C (dg-options): Ditto. * g++.dg/tree-prof/morefunc.C (dg-final-use): Cleanup profile ipa dump. * g++.dg/tree-prof/reorder.C (dg-final-use): Ditto. * g++

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Jeff Law
On 11/04/14 08:54, Bernd Schmidt wrote: Note that the intention is not to support Fortran (or any other language) directly targetting ptx code. The only way it's supposed to be used is as an accelerator for OpenACC offloading. Right. To reiterate for everyone, offloading is the goal of the nvptx

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Richard Henderson
On 11/04/2014 06:56 PM, Andrew MacLeod wrote: > On 11/04/2014 12:25 PM, Richard Henderson wrote: >> On 11/04/2014 05:28 PM, Andrew MacLeod wrote: >>> + bool >>> + default_can_compare_and_swap_p (machine_mode mode, bool allow_libcall) >>> + { >>> + return can_compare_and_swap_p (mode, allow_libcal

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Andrew MacLeod
On 11/04/2014 12:25 PM, Richard Henderson wrote: On 11/04/2014 05:28 PM, Andrew MacLeod wrote: + bool + default_can_compare_and_swap_p (machine_mode mode, bool allow_libcall) + { + return can_compare_and_swap_p (mode, allow_libcall); + } This is silly. I think the problem you point out can b

Go patch committed: untyped bool for logical operators

2014-11-04 Thread Ian Taylor
The Go language was tweaked to permit logical operators to return an untyped boolean value, which means that code like type myBool bool var b myBool = a < b || c < d is now permitted (previously the || operator would return the named type "bool" and an explicit conversion was required for t

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Steve Kargl
On Tue, Nov 04, 2014 at 10:20:53AM -0700, Jeff Law wrote: > On 11/04/14 09:11, Jakub Jelinek wrote: > > On Tue, Nov 04, 2014 at 07:41:42AM -0800, Steve Kargl wrote: > >> On Tue, Nov 04, 2014 at 03:34:43PM +0100, Bernd Schmidt wrote: > >>> The ptx port by its nature is lacking features that are expe

Re: [patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Richard Henderson
On 11/04/2014 05:28 PM, Andrew MacLeod wrote: > + bool > + default_can_compare_and_swap_p (machine_mode mode, bool allow_libcall) > + { > + return can_compare_and_swap_p (mode, allow_libcall); > + } This is silly. I think the problem you point out can be better fixed by moving the can_compare_

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Jeff Law
On 11/04/14 09:11, Jakub Jelinek wrote: On Tue, Nov 04, 2014 at 07:41:42AM -0800, Steve Kargl wrote: On Tue, Nov 04, 2014 at 03:34:43PM +0100, Bernd Schmidt wrote: The ptx port by its nature is lacking features that are expected on "normal" machines, such as alloca and indirect jumps. We have a

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread FX
> See https://gcc.gnu.org/wiki/Offloading and kyukhin/gomp4-offload and > branches/gomp-4_0-branch branches. Both are in the process of being merged > into trunk these days. Thanks for the link, I’ll look into it. I suppose then it makes sense to provide partial libgfortran support, assuming som

[RFC PATCH v4] Fix PR56480 aka DR374. Allow explicit specialization in enclosing namespace.

2014-11-04 Thread Markus Trippelsdorf
On 2014.11.03 at 08:47 -0600, Jason Merrill wrote: > On 11/03/2014 05:27 AM, Markus Trippelsdorf wrote: > > BTW both EDG and clang reject g++.dg/template/spec17.C: > > > > namespace io { > >template int foo(); > > } > > using namespace io; > > template<> int foo(); > > > > But I think it is a

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Steve Kargl
On Tue, Nov 04, 2014 at 04:54:54PM +0100, Bernd Schmidt wrote: > On 11/04/2014 04:41 PM, Steve Kargl wrote: > > It is unclear to me from reading the diff whether this patch > > cause gfortran on ptx to knowingly violate the fortran standard. > > If the answer is "yes, this patch causes gfortran on

Re: [PATCH 10/27] New file: gcc/jit/libgccjit.c

2014-11-04 Thread David Malcolm
On Mon, 2014-11-03 at 13:32 -0700, Jeff Law wrote: > On 10/31/14 11:02, David Malcolm wrote: > > This file implements the entrypoints of the library's public API. > > > > It performs error-checking at this boundary, before calling into the > > jit-recording.h internal API. > > > > gcc/jit/ > >

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Jonathan Wakely
On 4 November 2014 16:34, Paolo Carlini wrote: > Ah! The testsuite_allocator.h fix of yours is still unapplied, didn't know > that, sorry ;) My bad - I thought I'd committed it! Done now.

Re: The nvptx port [10/11+] Target files

2014-11-04 Thread Bernd Schmidt
On 11/04/2014 05:48 PM, Richard Henderson wrote: On 10/28/2014 03:56 PM, Bernd Schmidt wrote: +nvptx_ptx_type_from_mode (enum machine_mode mode, bool promote) +{ + switch (mode) +{ +case BLKmode: + return ".b8"; +case BImode: + return ".pred"; +case QImode: + if (

Re: The nvptx port [10/11+] Target files

2014-11-04 Thread Richard Henderson
On 10/28/2014 03:56 PM, Bernd Schmidt wrote: > +nvptx_ptx_type_from_mode (enum machine_mode mode, bool promote) > +{ > + switch (mode) > +{ > +case BLKmode: > + return ".b8"; > +case BImode: > + return ".pred"; > +case QImode: > + if (promote) > + return ".u32";

Re: [PATCH 14/27] New files: gcc/jit/jit-builtins.{c|h}

2014-11-04 Thread David Malcolm
On Mon, 2014-11-03 at 14:04 -0700, Jeff Law wrote: > On 10/31/14 11:02, David Malcolm wrote: > > These files implement support for builtins, for the > >gcc_jit_context_get_builtin_function > > API entrypoint. > > > > Only a subset of builtins are currently supported, based on those > > that I n

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
On 11/04/2014 04:46 PM, Paolo Carlini wrote: Hi, On 11/04/2014 04:32 PM, Jonathan Wakely wrote: Not a big deal of course, but unfortunately today I'm seeing *two* segfaults for pb_ds: performance/ext/pb_ds/multimap_text_insert_mem_large.cc .../libstdc++-v3/scripts/check_performance: line 41:

Re: [PATCH 13/27] New file: gcc/jit/jit-recording.c

2014-11-04 Thread David Malcolm
On Mon, 2014-11-03 at 15:03 -0700, Jeff Law wrote: > On 10/31/14 11:02, David Malcolm wrote: > > Implementation of the gcc::jit::recording internal API, so that > > libgccjit.c can record the calls that are made to the public API, for > > later playback by the dummy frontend. > > > > gcc/jit/ > >

[patch] Provide a can_compare_and_swap_p target hook.

2014-11-04 Thread Andrew MacLeod
java/builtins.c needs to call can_compare_and_swap, which happens to be provided via optabs.h. As a result, we see the following in java/builtins.c: /* FIXME: All these headers are necessary for sync_compare_and_swap. Front ends should never have to look at that. */ #include "rtl.h" #include

Re: [Patch 3/7 arc] Deprecate *_BY_PIECES_P, move to hookized version

2014-11-04 Thread Joern Rennecke
On 4 November 2014 14:24, James Greenhalgh wrote: > On Tue, Nov 04, 2014 at 12:07:56PM +, Joern Rennecke wrote: >> On 31 October 2014 15:10, James Greenhalgh wrote: >> >> > While I am there, arc defines a macro CAN_MOVE_BY_PIECES, which is >> > unused, so clean that up too. >> >> That's not a

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Richard Biener
On Tue, Nov 4, 2014 at 4:57 PM, Martin Jambor wrote: > On Tue, Nov 04, 2014 at 04:47:18PM +0100, Richard Biener wrote: >> On Tue, Nov 4, 2014 at 4:37 PM, Martin Jambor wrote: >> > Hi, >> > >> > since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing >> > because although the tested-for

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Jakub Jelinek
On Tue, Nov 04, 2014 at 05:15:52PM +0100, FX wrote: > > The point is, if the target can implement just a subset of the Fortran (or > > C or C++) standards, then ideally if you use anything that is not supported > > would just cause always host fallback, the code will still work, but will > > not be

Re: [PATCH 12/27] New file: gcc/jit/jit-recording.h

2014-11-04 Thread David Malcolm
On Mon, 2014-11-03 at 14:27 -0700, Jeff Law wrote: > On 10/31/14 11:02, David Malcolm wrote: > > This file declares the gcc::jit::recording internal API, so that > > libgccjit.c can record the calls that are made to the public API, for > > later playback by the dummy frontend. > > > > gcc/jit/ > >

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread FX
> The point is, if the target can implement just a subset of the Fortran (or > C or C++) standards, then ideally if you use anything that is not supported > would just cause always host fallback, the code will still work, but will > not be offloaded. So even supporting a subset of the standard is

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Jakub Jelinek
On Tue, Nov 04, 2014 at 07:41:42AM -0800, Steve Kargl wrote: > On Tue, Nov 04, 2014 at 03:34:43PM +0100, Bernd Schmidt wrote: > > The ptx port by its nature is lacking features that are expected on > > "normal" machines, such as alloca and indirect jumps. We have a subset > > of the C library whi

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Bernd Schmidt
On 11/04/2014 04:59 PM, FX wrote: Comments on the approach, do the Fortran maintainers have a preference how this should look? The whole thing is good enough to substantially reduce the number of failures when trying to run the Fortran testsuites on nvptx (although many remain). I’m afraid I do

Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On Tue, 4 Nov 2014, Joseph Myers wrote: > On Tue, 4 Nov 2014, Richard Biener wrote: > > > c-family/ > > * c-common.c (shorten_compare): Do not shorten mixed > > DFP and non-DFP compares. > > OK. I think it's also wrong for get_narrower to strip conversions between > binary and deci

Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Joseph Myers
On Tue, 4 Nov 2014, Richard Biener wrote: > c-family/ > * c-common.c (shorten_compare): Do not shorten mixed > DFP and non-DFP compares. OK. I think it's also wrong for get_narrower to strip conversions between binary and decimal floating point at all, as all such conversions

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread FX
> Comments on the approach, do the Fortran maintainers have a preference how > this should look? The whole thing is good enough to substantially reduce the > number of failures when trying to run the Fortran testsuites on nvptx > (although many remain). I’m afraid I don’t really see the point.

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Bernd Schmidt
On 11/04/2014 04:41 PM, Steve Kargl wrote: It is unclear to me from reading the diff whether this patch cause gfortran on ptx to knowingly violate the fortran standard. If the answer is "yes, this patch causes gfortran on ptx to violate the standard", then the patch is IMHO unacceptable. I don'

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Martin Jambor
On Tue, Nov 04, 2014 at 04:47:18PM +0100, Richard Biener wrote: > On Tue, Nov 4, 2014 at 4:37 PM, Martin Jambor wrote: > > Hi, > > > > since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing > > because although the tested-for devirtualization does happen, it is > > probably being done

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Jiong Wang
On 04/11/14 15:51, Paolo Carlini wrote: Hi, On 11/04/2014 04:37 PM, Martin Jambor wrote: Hi, since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing because although the tested-for devirtualization does happen, it is probably being done earlier and the string we are trying to match

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Paolo Carlini
Hi, On 11/04/2014 04:37 PM, Martin Jambor wrote: Hi, since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing because although the tested-for devirtualization does happen, it is probably being done earlier and the string we are trying to match is not emitted. But the important thing

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Richard Biener
On Tue, Nov 4, 2014 at 4:37 PM, Martin Jambor wrote: > Hi, > > since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing > because although the tested-for devirtualization does happen, it is > probably being done earlier and the string we are trying to match is > not emitted. But the imp

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
Hi, On 11/04/2014 04:32 PM, Jonathan Wakely wrote: Not a big deal of course, but unfortunately today I'm seeing *two* segfaults for pb_ds: performance/ext/pb_ds/multimap_text_insert_mem_large.cc .../libstdc++-v3/scripts/check_performance: line 41: 16173 Segmentation fault ./$EXE_NAME &>tmp

Re: The nvptx port [1/11+] indirect jumps

2014-11-04 Thread Richard Henderson
On 11/04/2014 04:32 PM, Bernd Schmidt wrote: > On 10/20/2014 04:19 PM, Bernd Schmidt wrote: >> ptx doesn't have indirect jumps, so CODE_FOR_indirect_jump may not be >> defined. Add a sorry. > > Looking back through all the mails it turns out this one wasn't approved yet. > Ping? Ok. r~

Re: RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Steve Kargl
On Tue, Nov 04, 2014 at 03:34:43PM +0100, Bernd Schmidt wrote: > The ptx port by its nature is lacking features that are expected on > "normal" machines, such as alloca and indirect jumps. We have a subset > of the C library which contains functions that can be implemented on the > target (exclu

[PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Martin Jambor
Hi, since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing because although the tested-for devirtualization does happen, it is probably being done earlier and the string we are trying to match is not emitted. But the important thing is that the tested devirtualization takes place. Pa

Re: The nvptx port [1/11+] indirect jumps

2014-11-04 Thread Bernd Schmidt
On 10/20/2014 04:19 PM, Bernd Schmidt wrote: ptx doesn't have indirect jumps, so CODE_FOR_indirect_jump may not be defined. Add a sorry. Looking back through all the mails it turns out this one wasn't approved yet. Ping? Bernd

Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On Tue, 4 Nov 2014, Richard Biener wrote: > > On the match-and-simplify branch we expose an issue in shorten_compare > which happily transforms (double) float-var != (double) dfp-float-var > to (float) float-var != (float) dfp-float-var which is wrong > and causes > > FAIL: c-c++-common/dfp/conv

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Jonathan Wakely
On 4 November 2014 13:13, Paolo Carlini wrote: > Hi again, > > > On 11/04/2014 05:34 AM, Jonathan Wakely wrote: >> >> On 04/11/14 03:41 +, Jonathan Wakely wrote: >>> >>> On 03/11/14 22:07 +, Jonathan Wakely wrote: On 3 November 2014 17:51, Paolo Carlini wrote: > > .

[PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On the match-and-simplify branch we expose an issue in shorten_compare which happily transforms (double) float-var != (double) dfp-float-var to (float) float-var != (float) dfp-float-var which is wrong and causes FAIL: c-c++-common/dfp/convert-bfp-12.c -std=c++11 execution test FAIL: c-c++-commo

RFC: Building a minimal libgfortran for nvptx

2014-11-04 Thread Bernd Schmidt
The ptx port by its nature is lacking features that are expected on "normal" machines, such as alloca and indirect jumps. We have a subset of the C library which contains functions that can be implemented on the target (excluding things like file I/O other than printf which is a ptx builtin).

Re: [match-and-simplify] support operator list

2014-11-04 Thread Richard Biener
On Mon, Nov 3, 2014 at 1:56 PM, Prathamesh Kulkarni wrote: > (had sent it earlier by private mail). > > The attached patch supports operator-list and it's use in for. > For now, operator-list is rejected in expression. Ok. > This patch also allows user-defined operator to be used as operator-lis

Re: [Patch 3/7 arc] Deprecate *_BY_PIECES_P, move to hookized version

2014-11-04 Thread James Greenhalgh
On Tue, Nov 04, 2014 at 12:07:56PM +, Joern Rennecke wrote: > On 31 October 2014 15:10, James Greenhalgh wrote: > > > While I am there, arc defines a macro CAN_MOVE_BY_PIECES, which is > > unused, so clean that up too. > > That's not a clean-up. This pertains to PR 39350. Well, it is a cle

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Rainer Emrich
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 11/04/2014 10:55 AM, schrieb Paolo Carlini: > .. thanks a lot Jon! (after all this parallel mode is still useful > for something ;) > > Paolo. Sorry for the terse message. I'm under heavy workload at the moment. But AFAIS now everything looks good

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
.. and also: performance/ext/pb_ds/priority_queue_text_pop_mem.cc .../libstdc++-v3/scripts/check_performance: line 41: 16905 Segmentation fault ./$EXE_NAME &>tmp.$FILE_NAME Paolo.

Re: [AArch64, Docs, Patch] Add reference to ACLE in docs.

2014-11-04 Thread Tejas Belagod
On 03/11/14 17:58, Joseph Myers wrote: On Mon, 3 Nov 2014, Tejas Belagod wrote: If I mention in a couple of sentences the level of ACLE support there is in GCC currently, this section will need to be updated every time there is an improvement in ACLE support - I guess we'll just have to remembe

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
Hi again, On 11/04/2014 05:34 AM, Jonathan Wakely wrote: On 04/11/14 03:41 +, Jonathan Wakely wrote: On 03/11/14 22:07 +, Jonathan Wakely wrote: On 3 November 2014 17:51, Paolo Carlini wrote: .. other than the above issue, I see a segmentation fault for: performance/ext/pb_ds/mul

Re: [match-and-simplify] support operator list

2014-11-04 Thread Richard Biener
On Mon, Nov 3, 2014 at 4:50 PM, Jakub Jelinek wrote: > On Mon, Nov 03, 2014 at 04:46:43PM +0100, Richard Biener wrote: >> On Mon, Nov 3, 2014 at 2:01 PM, Jakub Jelinek wrote: >> > On Mon, Nov 03, 2014 at 06:26:12PM +0530, Prathamesh Kulkarni wrote: >> >> --- gcc/match-comparison.pd (revision 21

Re: [PATCH, BUILDROBOT] SH: Fix unused variable warning (was: [SH][committed] PR 53513 - Add __builtin_sh_get_fpscr, __builtin_sh_set_fpscr)

2014-11-04 Thread Jan-Benedict Glaw
On Tue, 2014-11-04 13:21:24 +0100, Oleg Endo wrote: > On 4 Nov 2014, at 11:50, Jan-Benedict Glaw wrote: > > > > 2014-11-04 Jan-Benedict Glaw > > > >* config/sh/sh.c (emit_fpu_switch): Drop unused automatic variable. [...] > > This should fix it, ok for mainline? > > Yes, OK. Thanks for

Re: nvptx offloading patches [3/n], i386 bits RFD

2014-11-04 Thread Bernd Schmidt
On 11/03/2014 11:27 PM, Jeff Law wrote: On 11/01/14 05:57, Bernd Schmidt wrote: This is not against current trunk; it applies to gomp-4_0-branch where it is one of the necessary parts to make offloading x86->nvptx work. The issue is that the LTO file format depends on the machine_modes enum, it

Re: [PATCH] Update libgcc.texi to match implementation in libgcc/libgcc2.c

2014-11-04 Thread Kito Cheng
ping! On Tue, Oct 28, 2014 at 11:19 AM, Kito Cheng wrote: > Hi all: > > This patch update `Bit operations` section in libgcc.text, most bit > operation function is take an unsigned integer instead of signed > integer in libgcc/libgcc2.c [1], and it seem more make sense :) > > ChangeLog > 2014-10-

Re: [PATCH, BUILDROBOT] SH: Fix unused variable warning (was: [SH][committed] PR 53513 - Add __builtin_sh_get_fpscr, __builtin_sh_set_fpscr)

2014-11-04 Thread Oleg Endo
On 4 Nov 2014, at 11:50, Jan-Benedict Glaw wrote: > On Sat, 2014-10-18 12:54:33 +0200, Oleg Endo wrote: >> Hi, >> >> As discussed in the PR, this adds two new SH built-in functions >> __builtin_sh_get_fpscr __builtin_sh_set_fpscr. Tested on r216173 with >> >> make -k check RUNTESTFLAGS=

[PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Dominik Vogt
See commit comment and ChangeLog for details. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/testsuite/ChangeLog 2014-11-04 Dominik Vogt * go.test/test/ken/cplx2.go: Fix s390 test failures. 2014-11-04 Dominik Vogt * go.test/test/nilptr_s390.go: Port nilp

[PATCH 2/4] Gccgo port to s390[x] -- part II

2014-11-04 Thread Dominik Vogt
See commit comment and ChangeLog for details. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany ChangeLog 2014-11-04 Dominik Vogt * libgo/go/sync/atomic/atomic_test.go: Use LoadInt32() to access sync variables. * libgo/go/math/all_test.go (tolerance): Fix bug in cal

  1   2   >