Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

This is what I've bootstrapped and regression tested on powerpc64le-linux. I'm using Peter's testcases from this thread rather than the one in the original patch submission, because that one relies on -O0 not reducing the function down to a nop. OK to apply? PR target/71733 gcc/

Re: [PING^3] Re: Some fixes for autofdo test cases

Andi Kleen writes: Ping^3! > Andi Kleen writes: > > Ping^2! > >> Andi Kleen writes: >> >> Ping! >> >>> This fixes some of the problems with profile test cases running with autofdo >>> There are still remaining failures that need

Re: [patch, fortran] PR66310 Problems with intrinsic repeat for large number of copies

A minor question. Why with Fortran’s counted strings are you appending a null character? > On Jul 11, 2016, at 6:54 PM, Jerry DeLisle wrote: > > Attached patch sets a limit of huge-1 on the character count to avoid the > integer wrap. > > Regression tested with

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

On Tue, Jul 12, 2016 at 04:17:23PM +0200, Ulrich Weigand wrote: > Alan Modra wrote: > > The problem now is that this passes rs6000_legitimate_address_p due to > > mode_supports_vsx_dform_quad and quad_address_p being true. That > > doesn't seem correct for -mno-vsx. > > Hmm, I see in

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/12/2016 10:12 AM, Manuel López-Ibáñez wrote: On 12/07/16 16:59, Martin Sebor wrote: You're probably right. I suspect I have a tendency to overuse the quotes (e.g, the -Wplacement-new warning also quotes the sizes). If there aren't yet (I vague recall coming across something on the GCC

[PATCH] Remove struct map from plugin-nvptx

I'm not sure why the nvptx offloading plugin introduced struct map in the first place, but its current usage is both unnecessary and buggy. For instance, it doesn't properly free data mappings, and that results in bogus duplicate data mapping errors. This patch removes that struct altogether. Jim

Re: [v3 PATCH] Implement P0307R2, Making Optional Greater Equal Again.

On 11/07/16 23:41 +0300, Ville Voutilainen wrote: @@ -785,41 +785,60 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } }; + template +using __optional_relop_t = +enable_if_t::value, bool>; Should this be is_convertible<_Tp, bool> instead? template -

Re: [PATCH] Allow fwprop to undo vectorization harm (PR68961)

On Sun, Jul 10, 2016 at 10:12 AM, Uros Bizjak wrote: > On Wed, Jul 6, 2016 at 3:18 PM, Richard Biener wrote: > >>> > 2016-07-04 Richard Biener >>> > >>> > PR rtl-optimization/68961 >>> > * fwprop.c (propagate_rtx): Allow SUBREGs

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/12/2016 06:32 AM, Bernd Schmidt wrote: On 07/01/2016 08:15 PM, Martin Sebor wrote: The attached patch enhances compile-time checking for buffer overflow and output truncation in non-trivial calls to the sprintf family of functions under a new option -Wformat-length=[12]. This initial

Re: [PATCH] Lift alignment restrictions from inlining register size memcpy

> I have added a testcase that should exercise most relevant cases so > we can look for fallout on "interesting" targets. It passes on SPARC/Solaris 32-bit. > Boostrap / regtest on strict-alignment platforms welcome. Preliminary testing looks good, with a few expected regressions I guess:

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 03:44:37PM -0400, Michael Meissner wrote: > > I hope you mean for ppc only, otherwise you're breaking a lot of ports... > > Yes I mean for PowerPC only. I can change the switches name to: > > --enable-powerpc-lra > --enable-powerpc-float128 > > if it would

Re: Implement -Wswitch-fallthrough

This patch is accompanied by more than 2000 lines of new tests to get the warning covered though I'm sure folks will come up with other test cases that I hadn't considered (hi Martin S. ;). This warning is enabled by default for C/C++. I was more inclined to put this into -Wall, but our

Go patch committed: add escape analysis notes to export data

This patch by Chris Manghane changes the Go frontend to add escape analysis notes to the export data, and to read them in when importing a package. Escape analysis is still not enabled by default. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index:

[gomp4] backport fixes for PR71704

This patch contains both Jakub's OpenMP and my OpenACC fixes for PR71704. For reference, the discussion for the original patches can be found here . I'll apply this patch to gomp-4_0-branch shortly. Cesar 2016-07-12 Cesar Philippidis

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 01:21:47PM +0200, Bernd Schmidt wrote: > On 07/12/2016 12:29 PM, Richard Biener wrote: > > >Instead of adding more configury can we please enable LRA on trunk by default > >_now_? Otherwise the amount of testing it recieves won't really increase. > > I hope you mean for

[PATCH, i386]: Remove unneeded truncations to DImode in x86_64{,_zext}_immediate_operand predicates.

The immediate is checked that it fits SImode just below the unneeded truncation to DImode. 2016-07-12 Uros Bizjak * config/i386/predicates.md (x86_64_immediate_operand) : Remove unneeded truncation to DImode. : Ditto. (x86_64_zext_immediate_operand) : Ditto.

Re: [patch, fortran] PR66310 Problems with intrinsic repeat for large number of copies

On 07/12/2016 06:26 AM, Dominique d'Humières wrote: >>> 2016-07-11 Jerry DeLisle >>> >>> PR fortran/66310 >>> * simplify.c (gfc_simplify_repeat): Set max repeat to huge - 1 to allow >>> one byte for null terminating the resulting string constant. >> >> OK,

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 11:40:01AM -0600, Martin Sebor wrote: > On 07/12/2016 10:04 AM, Marek Polacek wrote: > > On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote: > > > On 07/12/2016 04:30 AM, Marek Polacek wrote: > > > > On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote: > >

Re: Implement -Wswitch-fallthrough

On 07/12/2016 10:04 AM, Marek Polacek wrote: On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote: On 07/12/2016 04:30 AM, Marek Polacek wrote: On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote: If [[fallthrough]] was approved for C++17 is there sth similar proposed for C?

Re: [PATCH] Fix FFI return type for proxy classes

> "Matthew" == Matthew Fortune writes: Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only failed Matthew> on mips-linux-gnu prior to patching libjava. Matthew> libjava/

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On 07/12/2016 06:31 PM, Segher Boessenkool wrote: Do you have a testcase? This sounds like fun :-) This is bfin-elf, gcc.c-torture/compile/pr59417.c, -O3 -fomit-frame-pointer. Bernd

Re: [PATCH] Fix FFI return type for closures in the java interpreter

> "Matthew" == Matthew Fortune writes: Matthew> Sorry for the long delay... No problem. >> This is ok. >> Could you check? I think a -m32 build ought to show it. Maybe your >> x86-64 build already did this? Matthew> Still OK to commit? Yes, thanks. Tom

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 05:17:04PM +0200, Bernd Schmidt wrote: > The Blackfin thing happens frequently with -fomit-frame-pointer when we have > > (insn 66 64 70 8 (set (reg:SI 96 [ ivtmp.32 ]) > (reg/f:SI 15 FP)) 19 {*movsi_insn} > > Which LRA transforms to an invalid insn: > > (insn 66

RE: [ARM] no-data-is-text-relative & msingle-pic-base

Ramana, Nathan, My opinion was "there is nothing wrong to run application -mno-pic-data-is-text-relative without -msingle-pic-base in a system that offset of data and text it fixed. I am not convenience we should ban it." However, what Ramana is suggesting is to error out -mno-PDITR with

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 12/07/16 16:59, Martin Sebor wrote: You're probably right. I suspect I have a tendency to overuse the quotes (e.g, the -Wplacement-new warning also quotes the sizes). If there aren't yet (I vague recall coming across something on the GCC Wiki but can't find it now), it would be helpful to

Re: Implement -Wswitch-fallthrough

On 07/11/2016 01:43 PM, Marek Polacek wrote: The switch fallthrough has been widely considered a design defect in C, a misfeature or, to use Marshall Cline's definition, evil. The overwhelming majority of the time you don't want to fall through to the next case, but it is easy to forget to

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 09:59:37AM -0600, Jeff Law wrote: > On 07/12/2016 04:30 AM, Marek Polacek wrote: > > On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote: > > > If [[fallthrough]] > > > was approved for C++17 is there sth similar proposed for C? Like a > > > keyword > > >

Re: [ARM] no-data-is-text-relative & msingle-pic-base

On 07/12/16 12:01, Ramana Radhakrishnan wrote: I am also slightly inclined to go further and error out if someone uses -mno-PDITR with -mno-SPB on the command line, after all as you say -mno-PDITR implies a non-fixed mapping while -mno-SPB implies there is some fixed mapping some where

Re: [ARM] no-data-is-text-relative & msingle-pic-base

On 12/07/16 13:02, Nathan Sidwell wrote: > Ramana, > could you review this? Sorry missed this. > > original thread https://gcc.gnu.org/ml/gcc-patches/2016-05/msg00630.html, > reproduced below: > > > currently, the documentation for -mno-pic-data-is-text-relative (-mno-PDITR) > says >

Re: Implement -Wswitch-fallthrough

On 07/12/2016 04:30 AM, Marek Polacek wrote: On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote: On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote: The switch fallthrough has been widely considered a design defect in C, a misfeature or, to use Marshall

[PATCH] Remove unused operator delete overloads (LWG 2458)

* libsupc++/new: Remove nothrow sized deletes (LWG 2458). * doc/xml/manual/intro.xml: Document DR 2458 status. * doc/html*: Regenerate. Tested x86_64-linux, committed to trunk. commit b5a6c1e6027f23c5501e9767821711d4506f9412 Author: redi

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

Does it warn for the code that Florian actually posted? I tried it with a recent (unpatched) build of trunk and got no warning (with -O2 -Wall -D_FORTIFY_SOURCE=2), but it strikes me that we ought to warn if someone passes about the above code (for the uninitialized format string, at least; I

Re: [PATCH] Introduce new param: AVG_LOOP_NITER

On 07/11/2016 04:35 PM, Jeff Law wrote: > Don't you need a corresponding change to invoke.texi? > > OK with that change. > > jeff Thanks, I've just mentioned the param in invoke.texi, installed as r238252. Martin >From c4c456c2bea9225c287f7af0e88f39cf780f815d Mon Sep 17 00:00:00 2001 From:

Re: [PATCH 2/3] Run profile feedback tests with autofdo

On Thu, Jun 23, 2016 at 3:37 PM, Andi Kleen wrote: > From: ak > > Extend the existing bprob and tree-prof tests to also run with autofdo. > The test runtimes are really a bit too short for autofdo, but it's > a reasonable sanity

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On 07/12/2016 02:48 PM, Bernd Schmidt wrote: No. You can reproduce issues with Blackfin easily by enabling LRA for it, and I described the C6X issues when the LRA patches were posted for review. That was here: https://gcc.gnu.org/ml/gcc-patches/2012-10/msg00235.html The Blackfin thing

Re: [PATCH] Fix PR rtl-optimization/71634

On 07/12/2016 04:18 PM, Bernd Schmidt wrote: > > > On 07/08/2016 04:27 PM, Martin Liška wrote: >> On 07/08/2016 02:54 PM, Martin Liška wrote: >>> On 07/08/2016 01:59 PM, Bernd Schmidt wrote: Gah, that's not right, that'll swap the numbers of kept/removed loops. I think the

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On Tue, 2016-07-12 at 08:45 -0600, Martin Sebor wrote: > On 07/12/2016 04:01 AM, Florian Weimer wrote: > > On 07/12/2016 11:54 AM, Jakub Jelinek wrote: > > > On Tue, Jul 12, 2016 at 11:51:50AM +0200, Florian Weimer wrote: > > > > On 07/01/2016 08:15 PM, Martin Sebor wrote: > > > > > The attached

Re: [PATCH] Fix Fortran DO loop fallback

On 07/12/2016 03:15 PM, Richard Biener wrote: > The scan for 1 *n_ after FRE looks still useful. Btw, the testcase > doesn't fail for me, > we _do_ hoist the division in PRE, just not with -m32 anymore. Can > you confirm this? Yeah, it works for both -m32 and -m64. This is final version of the

Re: [PATCH, ARM 6/7, ping1] Add support for CB(N)Z and (U|S)DIV to ARMv8-M Baseline

On 12/07/16 11:26, Thomas Preudhomme wrote: Hi Kyrill, Hi Thomas, On Friday 20 May 2016 14:22:48 Kyrill Tkachov wrote: Hi Thomas, On 17/05/16 11:14, Thomas Preudhomme wrote: Ping? *** gcc/ChangeLog *** 2015-11-13 Thomas Preud'homme *

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/12/2016 04:01 AM, Florian Weimer wrote: On 07/12/2016 11:54 AM, Jakub Jelinek wrote: On Tue, Jul 12, 2016 at 11:51:50AM +0200, Florian Weimer wrote: On 07/01/2016 08:15 PM, Martin Sebor wrote: The attached patch enhances compile-time checking for buffer overflow and output truncation in

Re: Implement -Wswitch-fallthrough: rs6000

On Tue, Jul 12, 2016 at 04:42:21PM +0200, Bernd Schmidt wrote: > On 07/12/2016 04:19 PM, Marek Polacek wrote: > > > >>>@@ -30191,6 +30200,7 @@ rs6000_adjust_cost (rtx_insn *insn, rtx link, > >>>rtx_insn *dep_insn, int cost) > >>> && (INSN_CODE (dep_insn) >= 0) > >>>

Re: Implement -Wswitch-fallthrough: rs6000

On 07/12/2016 04:19 PM, Marek Polacek wrote: @@ -30191,6 +30200,7 @@ rs6000_adjust_cost (rtx_insn *insn, rtx link, rtx_insn *dep_insn, int cost) && (INSN_CODE (dep_insn) >= 0) && (get_attr_type (dep_insn) == TYPE_MFFGPR)) return 2; +

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 04:22:30PM +0200, Bernd Schmidt wrote: > On 07/12/2016 04:14 PM, Jakub Jelinek wrote: > >On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote: > >>On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote: > >>>From

Re: [C++ RFC/Patch] PR c++/71665

Hi Jason, and sorry about the delay in following up, a few days of vacations... On 30/06/2016 19:49, Jason Merrill wrote: I think we should check the type before calling cxx_constant_value. Ok, I got the point. I'm not sure however how far we want to go with this and which kind of

Re: Implement -Wswitch-fallthrough

On 07/12/2016 04:14 PM, Jakub Jelinek wrote: On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote: On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote: From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html: Thanks, this is useful. We also suppress a case

Re: Implement -Wswitch-fallthrough: rs6000

On Tue, Jul 12, 2016 at 09:10:54AM -0500, Segher Boessenkool wrote: > Hi Marek, > > On Mon, Jul 11, 2016 at 09:59:39PM +0200, Marek Polacek wrote: > > 2016-07-11 Marek Polacek > > > > PR c/7652 > > * config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass):

Re: [PATCH] Fix PR rtl-optimization/71634

On 07/08/2016 04:27 PM, Martin Liška wrote: On 07/08/2016 02:54 PM, Martin Liška wrote: On 07/08/2016 01:59 PM, Bernd Schmidt wrote: Gah, that's not right, that'll swap the numbers of kept/removed loops. I think the right answer is simply for (i = 0; i < n - IRA_MAX_LOOPS_NUM; i++)

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

Alan Modra wrote: > On Tue, Jul 12, 2016 at 02:02:43PM +0200, Ulrich Weigand wrote: > > The second time around, get_secondary_mem should reuse the > > same stack slot it already allocated, and the elimination > > offsets should already be set to accommodate that stack slot, > > which means the

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote: > From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html: Thanks, this is useful. > We also suppress a case label if there is a comment that matches > [^#]fall.?thro?u, even if it's not on the last line. Our current plan

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 04:08:02PM +0200, Marek Polacek wrote: > On Tue, Jul 12, 2016 at 09:57:01AM -0400, NightStrike wrote: > > From http://security.coverity.com/blog/2013/Sep/gimme-a-break.html: > > Thanks, this is useful. > > > We also suppress a case label if there is a comment that

Re: Improve insert/emplace robustness to self insertion

On 08/07/16 17:38 +0100, Jonathan Wakely wrote: On 06/07/16 21:46 +0200, François Dumont wrote: Don't you plan to add it to the testsuite ? Done with the attached aptch. Just for completeness, I'm also adding the example from LWG 2164, which is related. Tested x86_64, committed to trunk.

Re: Implement -Wswitch-fallthrough: rs6000

Hi Marek, On Mon, Jul 11, 2016 at 09:59:39PM +0200, Marek Polacek wrote: > 2016-07-11 Marek Polacek > > PR c/7652 > * config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass): Likewise. Likewise? Like what? :-) > --- gcc/gcc/config/rs6000/rs6000.c > +++

[PATCH] Add tests and docs for LWG 2212 support

* testsuite/20_util/pair/astuple/astuple.cc: Only include . * testsuite/23_containers/array/tuple_interface/tuple_element.cc: Only include . * testsuite/23_containers/array/tuple_interface/tuple_size.cc: Likewise. * doc/xml/manual/intro.xml;

Re: Implement -Wswitch-fallthrough

On Mon, Jul 11, 2016 at 4:34 PM, Jakub Jelinek wrote: > On Mon, Jul 11, 2016 at 10:23:30PM +0200, Marek Polacek wrote: >> On Mon, Jul 11, 2016 at 01:18:02PM -0700, Andi Kleen wrote: >> > > I explained why supporting the classic lint style comment wouldn't fly. >> > >> > Not

Re: C++ OpenACC routine directive testing: templated, and "auto", trailing return type syntax

On Tue, Jul 12, 2016 at 03:50:14PM +0200, Thomas Schwinge wrote: > Hi! > > Templated, and "auto", trailing return type syntax with the C++ OpenACC > routine directive all works, but doesn't have test coverage. OK for > trunk? > > commit 7a387329674b07b8eb7e07cff665250284b4524b > Author: Thomas

C++ OpenACC routine directive testing: templated, and "auto", trailing return type syntax

Hi! Templated, and "auto", trailing return type syntax with the C++ OpenACC routine directive all works, but doesn't have test coverage. OK for trunk? commit 7a387329674b07b8eb7e07cff665250284b4524b Author: Thomas Schwinge Date: Thu Jul 7 16:12:15 2016 +0200 C++

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

On Tue, Jul 12, 2016 at 02:02:43PM +0200, Ulrich Weigand wrote: > The second time around, get_secondary_mem should reuse the > same stack slot it already allocated, and the elimination > offsets should already be set to accommodate that stack slot, > which means the second time around, the correct

Re: [patch, fortran] PR66310 Problems with intrinsic repeat for large number of copies

> > 2016-07-11 Jerry DeLisle > > > > PR fortran/66310 > > * simplify.c (gfc_simplify_repeat): Set max repeat to huge - 1 to allow > > one byte for null terminating the resulting string constant. > > OK, thanks Please hold on. I still see several problem with

Re: [PATCH] Fix Fortran DO loop fallback

On Tue, Jul 12, 2016 at 2:31 PM, Martin Liška wrote: > On 07/12/2016 12:14 PM, Richard Biener wrote: >> On Mon, Jul 11, 2016 at 4:44 PM, Jeff Law wrote: >>> On 07/08/2016 08:26 AM, Martin Liška wrote: Hello Following patch fixes fallout caused

Re: [PATCH, rs6000, libgcc] Implement temporary solution for __divkc3 and __mulkc3

On Mon, Jul 11, 2016 at 02:38:50PM -0500, Bill Schmidt wrote: > It was recently brought to my attention that glibc needs access to complex > multiply and divide for IEEE-128 floating-point in GCC 6.2 in order to move > ahead with the library implementation work. This patch enables this support >

Re: [patch, fortran] PR66310 Problems with intrinsic repeat for large number of copies

> 2016-07-11 Jerry DeLisle > > PR fortran/66310 > * simplify.c (gfc_simplify_repeat): Set max repeat to huge - 1 to allow > one byte for null terminating the resulting string constant. OK, thanks

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 02:40:28PM +0200, Bernd Schmidt wrote: > On 07/12/2016 02:15 PM, Segher Boessenkool wrote: > >How can LRA ever be made default for all targets without breaking those > >that do not want to change? > > LRA advocates would have to fix the issues with it that prevent it from

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On 07/12/2016 02:45 PM, Segher Boessenkool wrote: On Tue, Jul 12, 2016 at 02:40:28PM +0200, Bernd Schmidt wrote: On 07/12/2016 02:15 PM, Segher Boessenkool wrote: How can LRA ever be made default for all targets without breaking those that do not want to change? LRA advocates would have to

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 02:40:28PM +0200, Bernd Schmidt wrote: > On 07/12/2016 02:15 PM, Segher Boessenkool wrote: > >How can LRA ever be made default for all targets without breaking those > >that do not want to change? > > LRA advocates would have to fix the issues with it that prevent it from

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On 07/12/2016 02:15 PM, Segher Boessenkool wrote: How can LRA ever be made default for all targets without breaking those that do not want to change? LRA advocates would have to fix the issues with it that prevent it from being usable on certain targets. Based on my initial experiments with

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/01/2016 08:15 PM, Martin Sebor wrote: The attached patch enhances compile-time checking for buffer overflow and output truncation in non-trivial calls to the sprintf family of functions under a new option -Wformat-length=[12]. This initial patch handles printf directives with string,

Re: [PATCH] Fix Fortran DO loop fallback

On 07/12/2016 12:14 PM, Richard Biener wrote: > On Mon, Jul 11, 2016 at 4:44 PM, Jeff Law wrote: >> On 07/08/2016 08:26 AM, Martin Liška wrote: >>> >>> Hello >>> >>> Following patch fixes fallout caused by the patch set: >>>

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 01:31:35PM +0200, Richard Biener wrote: > On Tue, Jul 12, 2016 at 1:21 PM, Bernd Schmidt wrote: > > On 07/12/2016 12:29 PM, Richard Biener wrote: > > > >> Instead of adding more configury can we please enable LRA on trunk by > >> default > >> _now_?

Re: [RFC, v2] Test coverage for --param boundary values

On 07/11/2016 04:48 PM, Jeff Law wrote: > Seems reasonable to me -- OK for the trunk, but please be on the lookout for > these tests failing on other targets. > > jeff Thanks, the patch also works on a ppc64le-linux-gnu system. I'm going to install the patch after I'll install fix for:

Re: [PATCH 2/2] Optimize fortran loops with +-1 step.

On 07/12/2016 12:07 PM, Richard Biener wrote: > That change is certainly spurious (not in ChangeLog) and bogus given the > comment before the scan. > > Richard. Hi. I'll revert the change in ldist-1.f90 which I accidentally committed a week ago, it's going to be part of second version of the

Re: [PATCH], PR 71805, Fix PowerPC ISA 3.0 xxperm/xxpermr usage

On Tue, Jul 12, 2016 at 12:28:12AM -0400, Michael Meissner wrote: > In this patch, I have fixed the xxperm instructions to expect the second input > argument to be the same as the output argument instead of the first. I also > fixed the xxpermr instruction, which suffers from the same problem. I

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

Alan Modra wrote: > On Mon, Jul 11, 2016 at 03:26:46PM +0200, Ulrich Weigand wrote: > > However, there still seems to be another underlying problem: reload > > should never generate invalid instructions. (Playing with '?' to > > fix *inefficient* instructions is fine, but we shouldn't rely on '?'

[ARM] no-data-is-text-relative & msingle-pic-base

Ramana, could you review this? original thread https://gcc.gnu.org/ml/gcc-patches/2016-05/msg00630.html, reproduced below: currently, the documentation for -mno-pic-data-is-text-relative (-mno-PDITR) says 'Assume that each data segments are relative to text segment at load time. Therefore,

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 01:24:15PM +0200, Bernd Schmidt wrote: > On 07/11/2016 09:43 PM, Marek Polacek wrote: > > This warning is enabled by default for C/C++. I was more inclined to put > > this > > into -Wall, but our common.opt machinery doesn't seem to allow that (ugh!). > > Add me to the

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 1:21 PM, Bernd Schmidt wrote: > On 07/12/2016 12:29 PM, Richard Biener wrote: > >> Instead of adding more configury can we please enable LRA on trunk by >> default >> _now_? Otherwise the amount of testing it recieves won't really increase. > > > I

Re: Implement -Wswitch-fallthrough

On 07/11/2016 09:43 PM, Marek Polacek wrote: This warning is enabled by default for C/C++. I was more inclined to put this into -Wall, but our common.opt machinery doesn't seem to allow that (ugh!). Add me to the list of folks opposed to enabling this unconditionally or as part of any other

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On 07/12/2016 12:29 PM, Richard Biener wrote: Instead of adding more configury can we please enable LRA on trunk by default _now_? Otherwise the amount of testing it recieves won't really increase. I hope you mean for ppc only, otherwise you're breaking a lot of ports... Bernd

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Tue, Jul 12, 2016 at 12:29:04PM +0200, Richard Biener wrote: > Instead of adding more configury can we please enable LRA on trunk by default > _now_? Otherwise the amount of testing it recieves won't really increase. I agree we should change default_lra_p to return true instead of false.

Re: [patch] Fix type merging deficiency during WPA

On Mon, Jul 11, 2016 at 5:14 PM, Jan Hubicka wrote: > Hi, > Sorry for jumping in late, only now I had chance to read through the whole > discussion. > I was looking into similar problem some time ago. > >> Index: lto-streamer-out.c >>

Re: [patch] Fix type merging deficiency during WPA

On Mon, Jul 11, 2016 at 3:28 PM, Eric Botcazou wrote: >> So sth like >> >> Index: gcc/lto-streamer-out.c >> === >> --- gcc/lto-streamer-out.c (revision 238039) >> +++ gcc/lto-streamer-out.c (working

Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

On Mon, Jul 11, 2016 at 03:26:46PM +0200, Ulrich Weigand wrote: > However, there still seems to be another underlying problem: reload > should never generate invalid instructions. (Playing with '?' to > fix *inefficient* instructions is fine, but we shouldn't rely on '?' > to fix *invalid*

Re: [PATCHv2, ARM, libgcc] New aeabi_idiv function for armv6-m

On 11/07/16 18:09, Andre Vieira (lists) wrote: > On 06/07/16 11:52, Andre Vieira (lists) wrote: >> On 01/07/16 14:40, Ramana Radhakrishnan wrote: >>> >>> >>> On 13/10/15 18:01, Andre Vieira wrote: This patch ports the aeabi_idiv routine from Linaro Cortex-Strings

[PATCH] Fix FFI return type for proxy classes

Hi, As mentioned in: https://gcc.gnu.org/ml/gcc-patches/2016-06/msg01827.html there is a bug in lang/reflect/natVMProxy.cc where the return types are not promoted to ffi_arg for integer types smaller than a word. This bug will not show up on little endian architectures as the issue gets fixed

Re: Implement -Wswitch-fallthrough

On Tue, Jul 12, 2016 at 12:27:31PM +0200, Richard Biener wrote: > On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote: > > The switch fallthrough has been widely considered a design defect in C, a > > misfeature or, to use Marshall Cline's definition, evil. The overwhelming

Re: [PATCH], PowerPC support to enable -mlra and/or -mfloat128

On Mon, Jul 11, 2016 at 10:07 PM, Michael Meissner wrote: > These configuration switches will allow the PowerPC GCC developers to switch > defaults in the compiler to debug the code, before making the decision to flip > the default permanently. In the future, when

Re: Implement -Wswitch-fallthrough: lto

On Tue, Jul 12, 2016 at 12:22:55PM +0200, Richard Biener wrote: > > @@ -254,6 +260,7 @@ parse_table_entry (char *p, struct ld_plugin_symbol > > *entry, > > break; > > } > > /* FALL-THROUGH. */ > > +lto_fallthrough (); > > This shows me that it would be nice to simply

Re: Implement -Wswitch-fallthrough

On Mon, Jul 11, 2016 at 9:43 PM, Marek Polacek wrote: > The switch fallthrough has been widely considered a design defect in C, a > misfeature or, to use Marshall Cline's definition, evil. The overwhelming > majority of the time you don't want to fall through to the next

Re: [PATCH, ARM 6/7, ping1] Add support for CB(N)Z and (U|S)DIV to ARMv8-M Baseline

Hi Kyrill, On Friday 20 May 2016 14:22:48 Kyrill Tkachov wrote: > Hi Thomas, > > On 17/05/16 11:14, Thomas Preudhomme wrote: > > Ping? > > > > *** gcc/ChangeLog *** > > > > 2015-11-13 Thomas Preud'homme > > > > * config/arm/arm.c

Re: Implement -Wswitch-fallthrough: lto

On Mon, Jul 11, 2016 at 9:58 PM, Marek Polacek wrote: > 2016-07-11 Marek Polacek > > PR c/7652 > * lto-plugin.c (lto_fallthrough): Define. > (parse_table_entry): Use it. > > diff --git gcc/lto-plugin/lto-plugin.c

Re: Fix loop_only_exit_p

On Mon, 11 Jul 2016, Jan Hubicka wrote: > Hi, > while looking into loop code I noticed that loop_only_exit_p seems overly > simplistic. The purpose of this predicate is to decide whether the loop > must terminate by the exit given (so for example it is known that the number > of iteration test in

RE: [PATCH] Fix FFI return type for closures in the java interpreter

Tom Tromey writes: > > "Matthew" == Matthew Fortune writes: > > Matthew> I'm not sure this will matter if the only arch is x86 as > Matthew> ffi_arg will be 32-bit anyway there. > > Aha, right. Thanks for looking. > > Matthew> There would need

Re: [PATCH] Fix Fortran DO loop fallback

On Mon, Jul 11, 2016 at 4:44 PM, Jeff Law wrote: > On 07/08/2016 08:26 AM, Martin Liška wrote: >> >> Hello >> >> Following patch fixes fallout caused by the patch set: >> https://gcc.gnu.org/ml/gcc-regression/2016-07/msg00097.html >> >> Ready after it finished regression tests?

Re: [PATCH, PR ipa/71633] Fix inlining into thunks

On Mon, Jul 11, 2016 at 12:22 PM, Ilya Enkovich wrote: > Hi, > > Currently when we expand thunk in inliner we assume its body > has a single call. This is wrong for cases when thunk is > instrumented. It means we might try to continue inlining > for wrong edge. This

Re: [PATCH 2/2] Optimize fortran loops with +-1 step.

On Sun, Jul 10, 2016 at 9:37 AM, Andreas Schwab wrote: > marxin writes: > >> diff --git a/gcc/testsuite/gfortran.dg/ldist-1.f90 >> b/gcc/testsuite/gfortran.dg/ldist-1.f90 >> index ea3990d..2030328 100644 >> --- a/gcc/testsuite/gfortran.dg/ldist-1.f90 >>

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/12/2016 11:54 AM, Jakub Jelinek wrote: On Tue, Jul 12, 2016 at 11:51:50AM +0200, Florian Weimer wrote: On 07/01/2016 08:15 PM, Martin Sebor wrote: The attached patch enhances compile-time checking for buffer overflow and output truncation in non-trivial calls to the sprintf family of

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On Tue, Jul 12, 2016 at 11:51:50AM +0200, Florian Weimer wrote: > On 07/01/2016 08:15 PM, Martin Sebor wrote: > >The attached patch enhances compile-time checking for buffer overflow > >and output truncation in non-trivial calls to the sprintf family of > >functions under a new option

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

On 07/01/2016 08:15 PM, Martin Sebor wrote: The attached patch enhances compile-time checking for buffer overflow and output truncation in non-trivial calls to the sprintf family of functions under a new option -Wformat-length=[12]. This initial patch handles printf directives with string,

[PATCH] Lift alignment restrictions from inlining register size memcpy

The following patch does $subject which is requested in a comment in PR50417 as this restriction defeats the purpose of having memcpy as a portable and efficient way to circumvent strict-aliasing violations (or even as a portable and efficient way to do unaligned loads). Bootstrap / regtest

Re: [PATCH] disable IPA-cp cloning for functions with target_clones attribute

Hi, On Fri, Jun 24, 2016 at 01:41:05PM -0700, Evgeny Stupachenko wrote: > Hi, > > Fix ICE when IPA-cp and target_clones are applied to the same function. > Is the patch ok for trunk? I can't approve anything but since I wrote most of IPA-CP, it may count that I am fine with the patch. However,

Re: [PATCH] Allow fwprop to undo vectorization harm (PR68961)

On Tue, 12 Jul 2016, Uros Bizjak wrote: > On Tue, Jul 12, 2016 at 10:58 AM, Richard Biener wrote: > > On Sun, 10 Jul 2016, Uros Bizjak wrote: > > > >> On Wed, Jul 6, 2016 at 3:18 PM, Richard Biener wrote: > >> > >> >> > 2016-07-04 Richard Biener

  1   2   >