Re: [PR59319] output friends in debug info

2016-08-25 Thread Alexandre Oliva
On Aug 22, 2016, Richard Biener wrote: > Just throwing in a wrench from the side ... you should do this in > dwarf2out_early_finish as late there will be no frontend around anymore. Thanks for the heads up, I've adjusted my local copy to do so. > Yeah,

Re: [patch] [gsoc] [gimplefe] GIMPLE FE Project

2016-08-25 Thread Prasad Ghangal
On 24 August 2016 at 15:32, Richard Biener wrote: > On Mon, Aug 22, 2016 at 8:40 PM, Prasad Ghangal > wrote: >> On 22 August 2016 at 16:55, Trevor Saunders wrote: >>> On Sun, Aug 21, 2016 at 10:35:17PM +0530, Prasad

Always support float128 on x86

2016-08-25 Thread Joseph Myers
In , Nick reported i386-elf and ia64-elf failing to build because of float128_type_node being NULL, but being used by the back end for __float128. The global float128_type_node is only available conditionally, if target hooks indicate TFmode

Re: [PATCH] tree-optimization/71831 - __builtin_object_size poor results with no optimization

2016-08-25 Thread Martin Sebor
On 08/25/2016 01:18 PM, Jeff Law wrote: On 08/21/2016 02:29 PM, Martin Sebor wrote: gcc-71831.w.diff PR tree-optimization/71831 - __builtin_object_size poor results with no optimization gcc/testsuite/ChangeLog: 2016-08-21 Martin Sebor PR

Re: [PATCH] tree-optimization/71831 - __builtin_object_size poor results with no optimization

2016-08-25 Thread Martin Sebor
On 08/25/2016 01:02 PM, Jeff Law wrote: On 08/21/2016 02:29 PM, Martin Sebor wrote: On 08/20/2016 01:26 AM, Jakub Jelinek wrote: On Fri, Aug 19, 2016 at 04:30:47PM -0600, Martin Sebor wrote: The patch looks bigger than it actually is because: 1) It modifies the return type of the function to

Re: [RS6000] ABI_V4 ifunc

2016-08-25 Thread Richard Earnshaw (lists)
On 25/08/16 20:13, Segher Boessenkool wrote: > On Thu, Aug 25, 2016 at 11:14:49AM +0100, Richard Earnshaw (lists) wrote: >> On 24/08/16 02:55, Segher Boessenkool wrote: >> >>> If you make a ".gitattributes" >>> somewhere in your tree (I have it in the gcc/ subdir), containing >>> >>> *.md

Re: [PATCH 1/4][PR 71931] Fix libatomic tests

2016-08-25 Thread Joseph Myers
On Thu, 25 Aug 2016, Szabolcs Nagy wrote: > i'm not sure how installed testing works, if > it does not use the build tree site.exp, then > i can try to add BUILD_CC to site.exp. > (there is an EXTRA_DEJAGNU_SITE_CONFIG hook) It does not use the build tree site.exp. You generate site.exp in some

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-08-25 Thread Joseph Myers
On Wed, 24 Aug 2016, Martin Sebor wrote: > Since it's presumably a Glibc bug (bug 2509?) is this something > you believe the optimization needs to worry about? If so, can > you confirm that only Glibc versions 2.4 and prior are affected > and 2.5 is not? The code may not need to care about it,

[PATCH] PR fortran/77380

2016-08-25 Thread Steve Kargl
I plan to commit the following patch on Saturday if no one objects in the next 40 or so hours. 2016-08-25 Steven G. Kargl PR fortran/77380 * dependency.c (gfc_check_dependency): Do not assert with -fcoarray=lib. 2016-08-25 Steven G. Kargl

[PATCH] PR fortran/77372

2016-08-25 Thread Steve Kargl
I plan to commit the following patch on Saturday if no one objects in the next 40 or so hours. 2016-08-25 Steven G. Kargl PR fortran/77372 simplify.c (simplify_ieee_selected_real_kind): Check for NULL pointers. 2016-08-25 Steven G. Kargl

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-25 Thread Martin Sebor
On 08/25/2016 12:02 PM, David Malcolm wrote: On Thu, 2016-08-25 at 11:35 -0600, Martin Sebor wrote: +foo (int a, int b) +{ + int r = 0; + r += !a == (a < b); + r += !a == (a > b); + r += !a == (a >= b); + r += !a == (a <= b); + r += !a == (a != b); + r += !a == (a == b); + r += !a == (a

[Committed] PR fortran/77351

2016-08-25 Thread Steve Kargl
I've committed the following patch. tkoenig approved it in bugzilla. 2016-08-25 Steven g. Kargl PR fortran/77351 * frontend-passes.c (remove_trim,combine_array_constructor): Check for NULL pointer. 2016-08-25 Steven g. Kargl

Re: [PATCH] tree-optimization/71831 - __builtin_object_size poor results with no optimization

2016-08-25 Thread Jeff Law
On 08/21/2016 02:29 PM, Martin Sebor wrote: On 08/20/2016 01:26 AM, Jakub Jelinek wrote: On Fri, Aug 19, 2016 at 04:30:47PM -0600, Martin Sebor wrote: The patch looks bigger than it actually is because: 1) It modifies the return type of the function to bool rather than unsigned

Re: [RS6000] ABI_V4 ifunc

2016-08-25 Thread Segher Boessenkool
On Thu, Aug 25, 2016 at 11:14:49AM +0100, Richard Earnshaw (lists) wrote: > On 24/08/16 02:55, Segher Boessenkool wrote: > > > If you make a ".gitattributes" > > somewhere in your tree (I have it in the gcc/ subdir), containing > > > > *.md diff=md > > > > and then in your git config (say, in

Re: [PATCH] tree-optimization/71831 - __builtin_object_size poor results with no optimization

2016-08-25 Thread Jeff Law
On 08/21/2016 02:29 PM, Martin Sebor wrote: gcc-71831.w.diff PR tree-optimization/71831 - __builtin_object_size poor results with no optimization gcc/testsuite/ChangeLog: 2016-08-21 Martin Sebor PR tree-optimization/71831 *

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-25 Thread David Malcolm
On Thu, 2016-08-25 at 11:35 -0600, Martin Sebor wrote: > > +foo (int a, int b) > > +{ > > + int r = 0; > > + r += !a == (a < b); > > + r += !a == (a > b); > > + r += !a == (a >= b); > > + r += !a == (a <= b); > > + r += !a == (a != b); > > + r += !a == (a == b); > > + r += !a == (a || b);

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-25 Thread Martin Sebor
+foo (int a, int b) +{ + int r = 0; + r += !a == (a < b); + r += !a == (a > b); + r += !a == (a >= b); + r += !a == (a <= b); + r += !a == (a != b); + r += !a == (a == b); + r += !a == (a || b); + r += !a == (a && b); + r += !a == (!b); + + r += !a == (a ^ b); /* { dg-warning "logical

Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch

2016-08-25 Thread Martin Sebor
On 08/25/2016 10:23 AM, David Malcolm wrote: Martin: here are the fixups for your patch I needed to apply to make it work with mine. I couldn't actually get any of your existing test cases to emit locations within the string literals, due to them all being embedded in macro expansions (possibly

Re: [RS6000] ABI_V4 ifunc

2016-08-25 Thread Mike Stump
On Aug 25, 2016, at 3:14 AM, Richard Earnshaw (lists) wrote: > > On 24/08/16 02:55, Segher Boessenkool wrote: >> If you make a ".gitattributes" >> somewhere in your tree (I have it in the gcc/ subdir), containing >> >> *.md diff=md >> >> and then in your git config

[PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch

2016-08-25 Thread David Malcolm
Martin: here are the fixups for your patch I needed to apply to make it work with mine. I couldn't actually get any of your existing test cases to emit locations within the string literals, due to them all being embedded in macro expansions (possibly relating to PR c/77328), so I added a simple

[PATCH] Move class substring_loc from c-family into gcc

2016-08-25 Thread David Malcolm
This patch is intended to help Martin's new middle-end sprintf format warning. It moves most of the on-demand locations-within-strings code in c-family into gcc, into a new substring-locations.c file to go with substring-locations.h: class substring_loc, representing a source caret and source

Re: [PATCH][v2] GIMPLE store merging pass

2016-08-25 Thread Richard Biener
On August 25, 2016 3:57:11 PM GMT+02:00, Kyrill Tkachov wrote: >Hi Richard, > >On 25/08/16 14:01, Richard Biener wrote: >> On Mon, Aug 22, 2016 at 12:39 PM, Kyrill Tkachov >> wrote: >>> Hi all, >>> >>> This is a v2 of the patch at [1]

RE: [PATCH][mips] Add support for mips*r6-*-musl

2016-08-25 Thread Matthew Fortune
Szabolcs Nagy writes: > Add the musl dynamic linker names for mips r6. > > It seems DRIVER_SELF_SPECS sets the default mips isa > (MIPS_DEFAULT_ISA_LEVEL_SPEC) on *-mti-linux* or *-mti-elf, but not on > gnu linux targets (see config/mips/mti-linux.h vs config/mips/gnu- >

Re: [PATCH][v2] GIMPLE store merging pass

2016-08-25 Thread Kyrill Tkachov
Hi Richard, On 25/08/16 14:01, Richard Biener wrote: On Mon, Aug 22, 2016 at 12:39 PM, Kyrill Tkachov wrote: Hi all, This is a v2 of the patch at [1] addressing feedback from Richi. The most major changes are in the first phase of the pass that detects store

RE: [PATCH][mips] Fix linux header use in libgcc

2016-08-25 Thread Matthew Fortune
Szabolcs Nagy writes: > gcc should use libc headers, not kernel headers. > > libgcc/ > 2016-08-24 Szabolcs Nagy > > * config/mips/linux-unwind.h: Use sys/syscall.h. OK. Thanks for the fix. Matthew

Re: [RFC] ipa bitwise constant propagation

2016-08-25 Thread Jan Hubicka
> Patch for performing interprocedural bitwise constant propagation. > > 2016-08-23 Prathamesh Kulkarni > Martin Jambhor > > * common.opt: New option -fipa-cp-bit. > * doc/invoke.texi: Document -fipa-cp-bit. > *

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-25 Thread Tom de Vries
On 25/08/16 13:48, Richard Biener wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: Hi, in PR70955, ix86_canonical_va_list_type fails to recognize a __builtin_ms_va_list that was declared in a TU, because its type doesn't have the same main variant as the ms_va_list_type_node initialized in

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-25 Thread Marek Polacek
On Thu, Aug 25, 2016 at 11:17:37AM +0200, Richard Biener wrote: > On Wed, Aug 24, 2016 at 7:43 PM, Marek Polacek wrote: > > The -Wlogical-not-parentheses deliberately doesn't warn when the RHS has > > boolean type. But since in C the type of a comparison is int, we need > >

Re: Implement -Wimplicit-fallthrough (version 6)

2016-08-25 Thread Marek Polacek
On Wed, Aug 24, 2016 at 09:35:00AM -0600, Martin Sebor wrote: > > > I'm curious why this function takes the first argument by const > > > reference when the function above by const pointer. Is there > > > a subtle difference between the functions that I'm not seeing? > > > For that matter, is

Re: [PATCH][v2] GIMPLE store merging pass

2016-08-25 Thread Richard Biener
On Mon, Aug 22, 2016 at 12:39 PM, Kyrill Tkachov wrote: > Hi all, > > This is a v2 of the patch at [1] addressing feedback from Richi. > The most major changes are in the first phase of the pass that detects store > chains. > This now uses a hash_map to track multiple

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-25 Thread Marek Polacek
On Thu, Aug 25, 2016 at 08:40:20AM -0400, David Malcolm wrote: > Looks good to me, based on the above discussion. I'll try to add the > shared fixit validation code today. Thanks. Let me know if I can be of any help with that. Marek

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-25 Thread David Malcolm
On Thu, 2016-08-25 at 10:16 +0200, Marek Polacek wrote: > On Wed, Aug 24, 2016 at 04:03:10PM -0400, David Malcolm wrote: > > I was thinking about maybe: > > rich_location::add_fixit_insert_after_caret (source_location loc) > > which would add it immediately after the *caret* location of loc - >

Re: [PR72835] Incorrect arithmetic optimization involving bitfield arguments

2016-08-25 Thread Richard Biener
On Thu, Aug 11, 2016 at 1:09 AM, kugan wrote: > Hi, > > > On 10/08/16 20:28, Richard Biener wrote: >> >> On Wed, Aug 10, 2016 at 10:57 AM, Jakub Jelinek wrote: >>> >>> On Wed, Aug 10, 2016 at 08:51:32AM +1000, kugan wrote: I see it

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-25 Thread Richard Biener
On Wed, 24 Aug 2016, Tom de Vries wrote: > Hi, > > in PR70955, ix86_canonical_va_list_type fails to recognize a > __builtin_ms_va_list that was declared in a TU, because its type doesn't have > the same main variant as the ms_va_list_type_node initialized in lto1. > > This patch fixes the PR by

Re: [RS6000] ABI_V4 ifunc

2016-08-25 Thread Richard Earnshaw (lists)
On 24/08/16 02:55, Segher Boessenkool wrote: > If you make a ".gitattributes" > somewhere in your tree (I have it in the gcc/ subdir), containing > > *.md diff=md > > and then in your git config (say, in .git/config in the GCC source tree) > you have > > [diff "md"] > xfuncname =

Re: [PATCH 3/4][Ada,DJGPP] Ada support for DJGPP

2016-08-25 Thread Arnaud Charlet
Which exception handling mechanism is used by the DJGPP port? Is it (GCC) SJLJ? Arno

Re: [PATCH] Fix assembler arguments for -m16

2016-08-25 Thread Roger Pau Monne
On Mon, Aug 08, 2016 at 05:28:29PM +0200, Roger Pau Monne wrote: > On Wed, Jul 20, 2016 at 06:31:57PM +0200, Roger Pau Monne wrote: > > On Wed, Jul 06, 2016 at 04:18:49PM +0200, Roger Pau Monne wrote: > > > At the moment the -m16 option only passes the "--32" parameter to the > > > assembler on

[MPX] Fix for PR77267

2016-08-25 Thread Alexander Ivchenko
The attached patched fixes the usage of MPX in presence of "-Wl,-as-needed" option. 'make checked' on MPX-enabled machine. "--push-state" and "--pop-state" are not supported by gold at the moment. But that's OK because using MPX with gold only recommended in static build. Would that be OK for

[PATCH] Fix early late DWARF generation

2016-08-25 Thread Richard Biener
This fixes a recent regression where we generate symbolic locations while early DWARF is still in effect. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2016-08-25 Richard Biener * dwarf2out.c

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-25 Thread Richard Biener
On Wed, Aug 24, 2016 at 11:52 PM, Manuel López-Ibáñez wrote: > On 24/08/16 14:56, Richard Biener wrote: >> >> You never typoed >> >> gcc t.c -o t.c >> >> ? ;) (I did ... :/) > > > With GCC >=5 > > $ gcc t.c -o t.c > gcc: fatal error: input file ‘t.c’ is the same as output

Re: [wwwdocs] [PATCH] Add my changes to gcc-7/changes.html

2016-08-25 Thread Gerald Pfeifer
On Wed, 24 Aug 2016, David Malcolm wrote: > This covers my changes so far for gcc 7 That's lot! :-) > (I don't have a working copy of mhc, so I can't easily test the CSS > markup) Do not worry about that. The idea really is to treat the pages as standard HTML and minimize use of mhc for things

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-25 Thread Richard Biener
On Wed, Aug 24, 2016 at 7:43 PM, Marek Polacek wrote: > The -Wlogical-not-parentheses deliberately doesn't warn when the RHS has > boolean type. But since in C the type of a comparison is int, we need > to check for tcc_comparison, too. > > Bootstrapped/regtested on

Re: [PATCH 2/4][Ada,DJGPP] Ada support for DJGPP

2016-08-25 Thread Arnaud Charlet
> -#if defined (__MINGW32__) > +#if defined (__DJGPP__) > + > +/* FIXME: this is draft version only. Fix me if that is not correct */ > +/*or not complete (AP) */ This FIXME needs to be addressed. The rest of the patch is OK. Arno

Re: [Patch] Disable text mode translation in ada for Cygwin

2016-08-25 Thread Arnaud Charlet
Patch is OK

Re: [PATCH 1/3] haifa-sched.c: make ready_list an auto_vec

2016-08-25 Thread Bernd Schmidt
On 08/25/2016 08:50 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2016-08-25 Trevor Saunders * haifa-sched.c (fix_recovery_deps): Make ready_list a vector. The subject of the mail scared me, but

Re: [PATCH 3/3] make stack_slot_list a vec

2016-08-25 Thread Bernd Schmidt
On 08/25/2016 08:50 AM, tbsaunde+...@tbsaunde.org wrote: @@ -2626,8 +2626,10 @@ unshare_all_rtl_1 (rtx_insn *insn) This special care is necessary when the stack slot MEM does not actually appear in the insn chain. If it does appear, its address is unshared from all else at

Re: [PATCH 1/4][PR 71931] Fix libatomic tests

2016-08-25 Thread Szabolcs Nagy
On 24/08/16 23:08, Joseph Myers wrote: > On Wed, 24 Aug 2016, Szabolcs Nagy wrote: > >> diff --git a/libatomic/testsuite/lib/libatomic.exp >> b/libatomic/testsuite/lib/libatomic.exp >> index cafab54..e374c64 100644 >> --- a/libatomic/testsuite/lib/libatomic.exp >> +++

Re: [PATCH 2/3] make forced labels a vec

2016-08-25 Thread Bernd Schmidt
On 08/25/2016 08:50 AM, tbsaunde+...@tbsaunde.org wrote: + FOR_EACH_VEC_SAFE_ELT_REVERSE (forced_labels, i, insn) + make_label_edge (edge_cache, bb, insn, EDGE_ABNORMAL); All of these look like they'd be perfectly fine as a normal FOR_EACH_VEC_SAFE_ELT, and it would

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-25 Thread Marek Polacek
On Wed, Aug 24, 2016 at 04:03:10PM -0400, David Malcolm wrote: > I was thinking about maybe: > rich_location::add_fixit_insert_after_caret (source_location loc) > which would add it immediately after the *caret* location of loc - as > opposed to after the *finish* location of loc, or maybe just:

[PATCH 0/3] more rtl list work

2016-08-25 Thread tbsaunde+gcc
From: Trevor Saunders Hi, continueing on with getting rid of uses of rtx_insn_list and rtx_expr_list. bootstrapped + regtested patches individually on x86_64-linux-gnu, ok? Thanks! Trev Trevor Saunders (3): haifa-sched.c: make ready_list an auto_vec make

[PATCH 2/3] make forced labels a vec

2016-08-25 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2016-08-25 Trevor Saunders * cfgbuild.c (make_edges): Adjust. * cfgrtl.c (can_delete_label_p): Likewise. * dwarf2cfi.c (create_trace_edges): Likewise. * except.c

[PATCH 3/3] make stack_slot_list a vec

2016-08-25 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2016-08-25 Trevor Saunders * emit-rtl.h (struct rtl_data): Make stack_slot_list a vector. * emit-rtl.c (unshare_all_rtl_1): Adjust. (unshare_all_rtl_again): Likewise. *

[PATCH 1/3] haifa-sched.c: make ready_list an auto_vec

2016-08-25 Thread tbsaunde+gcc
From: Trevor Saunders gcc/ChangeLog: 2016-08-25 Trevor Saunders * haifa-sched.c (fix_recovery_deps): Make ready_list a vector. --- gcc/haifa-sched.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git