Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Janne Blomqvist
On Thu, Nov 17, 2016 at 9:41 AM, Thomas Koenig wrote: > Am 17.11.2016 um 00:20 schrieb Jakub Jelinek: >> >> On Thu, Nov 17, 2016 at 12:03:18AM +0100, Thomas Koenig wrote: Don't you need to test in configure if the assembler supports AVX? Otherwise if somebody

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Thomas Koenig
Am 17.11.2016 um 00:20 schrieb Jakub Jelinek: On Thu, Nov 17, 2016 at 12:03:18AM +0100, Thomas Koenig wrote: Don't you need to test in configure if the assembler supports AVX? Otherwise if somebody is bootstrapping gcc with older assembler, it will just fail to bootstrap. That's a good point.

Re: PR78319

2016-11-16 Thread Prathamesh Kulkarni
On 17 November 2016 at 03:20, Jeff Law wrote: > On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: >> >> Hi, >> As discussed in PR, this patch marks the test-case to xfail on >> arm-none-eabi. >> OK to commit ? > > You might check if Aldy's change to the uninit code helps your

Re: Fix PR78154

2016-11-16 Thread Jeff Law
On 11/16/2016 05:17 PM, Martin Sebor wrote: (I've heard some noise in C++-land about making memcpy(0,0,0) valid, but that may have just been noise) We may have read the same discussion. It would make some things a little easier in C++ (and remove what most people view as yet another

Re: [PATCH] Fix PR77848

2016-11-16 Thread Bill Schmidt
On 11/16/16 9:08 AM, Richard Biener wrote: > On Tue, Nov 15, 2016 at 9:03 PM, Bill Schmidt > wrote: >> - if ((any_pred_load_store || any_complicated_phi) >> - && !version_loop_for_if_conversion (loop)) >> + /* Since we have no cost model, always version loops

Re: [PATCH,gcc/MIPS] Make loongson3a use fused madd.d

2016-11-16 Thread Paul Hua
ping... On Thu, Nov 3, 2016 at 7:58 PM, Paul Hua wrote: > Hi Matthew, > > Thanks for your comments, update the patch. > > *** gcc/ChangeLog *** > > 2016-11-03 Chenghua Xu > > * config/mips/mips.h (ISA_HAS_FUSED_MADD4): Enable for >

Re: c-family PATCH to tidy switch diagnostics (PR c/78285)

2016-11-16 Thread Joseph Myers
On Wed, 16 Nov 2016, Marek Polacek wrote: > As pointed out in Bug 78285, some error calls should actually be inform calls. > I'm not adding any new test; existing switch-5.c covers all the cases so I > didn't > see much value in duplicating that part of the test. > > Bootstrapped/regtested on

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Joseph Myers
I'll presume you know best about the choices of stdint.h types. You may wish to consider what the correct value of use_gcc_stdint is - the default "none" (rely on the system's header), or "wrap" (use GCC's header in freestanding mode) or "provide" (always use GCC's header). Note that GCC's

Re: Fix PR78154

2016-11-16 Thread Martin Sebor
On 11/16/2016 05:17 PM, Martin Sebor wrote: On 11/16/2016 02:21 PM, Marc Glisse wrote: On Wed, 16 Nov 2016, Martin Sebor wrote: On 11/16/2016 11:49 AM, Prathamesh Kulkarni wrote: Hi Richard, Following your suggestion in PR78154, the patch checks if stmt contains call to memmove (and friends)

Re: ubsan PATCH to fix compile-time hog with operator overloading (PR sanitizer/78208)

2016-11-16 Thread Marek Polacek
On Fri, Nov 04, 2016 at 05:16:00PM +0100, Jakub Jelinek wrote: > On Fri, Nov 04, 2016 at 05:05:51PM +0100, Marek Polacek wrote: > > This is a similar case to PR sanitizer/70342. Here, we were generating > > expression > > in a quadratic fashion because of the initializer--we create SAVE_EXPR <>,

Re: Fix PR78154

2016-11-16 Thread Martin Sebor
On 11/16/2016 02:21 PM, Marc Glisse wrote: On Wed, 16 Nov 2016, Martin Sebor wrote: On 11/16/2016 11:49 AM, Prathamesh Kulkarni wrote: Hi Richard, Following your suggestion in PR78154, the patch checks if stmt contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p and returns

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 12:03:18AM +0100, Thomas Koenig wrote: > >Don't you need to test in configure if the assembler supports AVX? > >Otherwise if somebody is bootstrapping gcc with older assembler, it will > >just fail to bootstrap. > > That's a good point. The AVX instructions were added in

Re: [PATCH] libiberty: Add Rust symbol demangling.

2016-11-16 Thread Mark Wielaard
On Wed, Nov 16, 2016 at 02:56:03PM -0800, Ian Lance Taylor wrote: > On Wed, Nov 16, 2016 at 2:18 PM, David Tolnay wrote: > > FSF just confirmed that my assignment/disclaimer process has been > > completed. Ian can you take a look at your list again? > > Yes, you are good.

Re: [PATCH] Fix combine's make_extraction (PR rtl-optimization/78378)

2016-11-16 Thread Segher Boessenkool
On Wed, Nov 16, 2016 at 10:07:23PM +0100, Jakub Jelinek wrote: > If inner is a MEM, make_extraction requires that pos is a multiple of bytes > and deals with offsetting it. Or otherwise requires that pos is a multiple > of BITS_PER_WORD and for REG inner it handles that too. But if inner > is

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Jerry DeLisle
On 11/16/2016 01:30 PM, Thomas Koenig wrote: Hello world, the attached patch adds an AVX-specific version of the matmul intrinsic to the Fortran library. This works by using the target_clones attribute. For testing, I compiled this on powerpc64-unknown-linux-gnu, without any ill effects.

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Thomas Koenig
Am 16.11.2016 um 23:01 schrieb Jakub Jelinek: On Wed, Nov 16, 2016 at 10:30:03PM +0100, Thomas Koenig wrote: the attached patch adds an AVX-specific version of the matmul intrinsic to the Fortran library. This works by using the target_clones attribute. Don't you need to test in configure if

Re: [PATCH] libiberty: Add Rust symbol demangling.

2016-11-16 Thread Ian Lance Taylor
On Wed, Nov 16, 2016 at 2:18 PM, David Tolnay wrote: > FSF just confirmed that my assignment/disclaimer process has been > completed. Ian can you take a look at your list again? Yes, you are good. Thanks. Ian

Re: RFA: PATCH to gengtype to avoid putting tree_node support in front end objects

2016-11-16 Thread Jason Merrill
On Wed, Nov 16, 2016 at 1:45 PM, Moore, Catherine wrote: > /scratch/cmoore/mips-sde-elf-upstream/src/gcc-trunk-6/gcc/hash-map.h:62:12: > error: no matching function for call to 'gt_ggc_mx(rtx_def*&)' > > I configured with --target=mips-sde-elf, but I do have some

Re: [PATCH] libiberty: Add Rust symbol demangling.

2016-11-16 Thread David Tolnay
FSF just confirmed that my assignment/disclaimer process has been completed. Ian can you take a look at your list again? David On Fri, Nov 11, 2016 at 1:48 PM, David Tolnay wrote: > On Fri, Nov 11, 2016 at 10:46 AM, Ian Lance Taylor wrote: >> The patch is OK

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-16 Thread Andrew Burgess
* Mike Stump [2016-11-16 12:59:53 -0800]: > On Nov 16, 2016, at 12:09 PM, Andrew Burgess > wrote: > > My only remaining concern is the new tests, I've tried to restrict > > them to targets that I suspect they'll pass on with: > > > >/* {

c-family PATCH to tidy switch diagnostics (PR c/78285)

2016-11-16 Thread Marek Polacek
As pointed out in Bug 78285, some error calls should actually be inform calls. I'm not adding any new test; existing switch-5.c covers all the cases so I didn't see much value in duplicating that part of the test. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2016-11-16 Marek Polacek

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Jakub Jelinek
On Wed, Nov 16, 2016 at 10:30:03PM +0100, Thomas Koenig wrote: > the attached patch adds an AVX-specific version of the matmul > intrinsic to the Fortran library. This works by using the target_clones > attribute. Don't you need to test in configure if the assembler supports AVX? Otherwise if

Re: [patch,libgfortran] PR51119 - MATMUL slow for large matrices

2016-11-16 Thread Jerry DeLisle
Committed after approval on bugzilla to eliminate warnings. 2016-11-16 Jerry DeLisle PR libgfortran/51119 * Makefile.am: Remove -fno-protect-parens -fstack-arrays. * Makefile.in: Regenerate. r242517 = 026291bdda18395d7c746856dd7e4ed384856a1b

RE: [PATCH 1/4] MIPS16/GCC: Fix DImode `casesi_internal_mips16_' assembly instructions

2016-11-16 Thread Maciej W. Rozycki
On Wed, 16 Nov 2016, Matthew Fortune wrote: > OK. I have no idea what system supports 64-bit MIPS16 but given it costs > little to improve consistency here then it is at least doing no harm. No recent real hardware I believe. Among older implementations there were the NEC Vr4111 and Vr4121

Re: [PATCH] Fix up ICEs with TREE_CONSTANT references (PR c++/78373)

2016-11-16 Thread Jakub Jelinek
On Wed, Nov 16, 2016 at 04:26:36PM -0500, Jason Merrill wrote: > On Wed, Nov 16, 2016 at 4:00 PM, Jakub Jelinek wrote: > > Jason's recent patch to turn reference vars initialized with invariant > > addresses broke the first testcase below, because >singleton > > is considered

Re: PR78319

2016-11-16 Thread Jeff Law
On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: Hi, As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi. OK to commit ? You might check if Aldy's change to the uninit code helps your case (approved earlier today, so hopefully in the tree very soon). I quickly

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Mike Stump
> On Nov 16, 2016, at 11:23 AM, Krister Walfridsson > wrote: > > On Wed, 16 Nov 2016, Mike Stump wrote: > >> Looks reasonable. The biggest issue would be if any of those values changed >> through time, and the current version works for older netbsd releases,

[PATCH] PR fortran/58001 -- Handle tab in FORMAT

2016-11-16 Thread Steve Kargl
An earlier version of the attached patch lingered in bugzilla for over 3 years. I've updated the patch to include Manuel's comment #12. Regression tested on x86_64-*-freebsd. OK to commit? 2016-11-16 Steven G. Kargl PR fortran/58001 * io.c

[patch, libfortran] Add AVX-specific matmul

2016-11-16 Thread Thomas Koenig
Hello world, the attached patch adds an AVX-specific version of the matmul intrinsic to the Fortran library. This works by using the target_clones attribute. For testing, I compiled this on powerpc64-unknown-linux-gnu, without any ill effects. Also, a resulting binary reached around 15 GFlops

Re: C++ PATCH for c++/78358 (decltype and decomposition)

2016-11-16 Thread Jason Merrill
On Tue, Nov 15, 2016 at 11:31 AM, Jason Merrill wrote: > OK, (hopefully) one more patch for decltype and C++17 decomposition > declarations. I hadn't been thinking that "referenced type" meant to > look through references in the tuple case, since other parts of > [dcl.decomp]

Re: [PATCH] Fix up ICEs with TREE_CONSTANT references (PR c++/78373)

2016-11-16 Thread Jason Merrill
On Wed, Nov 16, 2016 at 4:00 PM, Jakub Jelinek wrote: > Jason's recent patch to turn reference vars initialized with invariant > addresses broke the first testcase below, because >singleton > is considered TREE_CONSTANT (because self is TREE_CONSTANT VAR_DECL and > singleton

Re: Fix PR78154

2016-11-16 Thread Marc Glisse
On Wed, 16 Nov 2016, Martin Sebor wrote: On 11/16/2016 11:49 AM, Prathamesh Kulkarni wrote: Hi Richard, Following your suggestion in PR78154, the patch checks if stmt contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p and returns true in that case. Nice. I think the list

Re: [libstdc++, testsuite] Add dg-require-thread-fence

2016-11-16 Thread Christophe Lyon
On 15 November 2016 at 12:50, Jonathan Wakely wrote: > On 14/11/16 14:32 +0100, Christophe Lyon wrote: >> >> On 20 October 2016 at 19:40, Jonathan Wakely wrote: >>> >>> On 20/10/16 10:33 -0700, Mike Stump wrote: On Oct 20, 2016, at 9:34 AM,

RE: [PATCH] microMIPS/GCC: Fix PIC call relaxation

2016-11-16 Thread Maciej W. Rozycki
On Wed, 16 Nov 2016, Matthew Fortune wrote: > > Fix `-mrelax-pic-calls' support for microMIPS code where the relocation > > produced is supposed to be R_MICROMIPS_JALR rather than R_MIPS_JALR. > > The lack of short delay support comes from a missed update to this code > > for microMIPS support

[PATCH] Fix combine's make_extraction (PR rtl-optimization/78378)

2016-11-16 Thread Jakub Jelinek
Hi! If inner is a MEM, make_extraction requires that pos is a multiple of bytes and deals with offsetting it. Or otherwise requires that pos is a multiple of BITS_PER_WORD and for REG inner it handles that too. But if inner is something different, it calls just force_to_mode to the target mode,

Re: PR61409: -Wmaybe-uninitialized false-positive with -O2

2016-11-16 Thread Jeff Law
On 11/02/2016 11:16 AM, Aldy Hernandez wrote: Hi Jeff. As discussed in the PR, here is a patch exploring your idea of ignoring unguarded uses if we can prove that the guards for such uses are invalidated by the uninitialized operand paths being executed. This is an updated patch from my

[PATCH] Fix up ICEs with TREE_CONSTANT references (PR c++/78373)

2016-11-16 Thread Jakub Jelinek
Hi! Jason's recent patch to turn reference vars initialized with invariant addresses broke the first testcase below, because >singleton is considered TREE_CONSTANT (because self is TREE_CONSTANT VAR_DECL and singleton field has constant offset), but after going into SSA form it is not supposed to

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-16 Thread Mike Stump
On Nov 16, 2016, at 12:09 PM, Andrew Burgess wrote: > My only remaining concern is the new tests, I've tried to restrict > them to targets that I suspect they'll pass on with: > >/* { dg-final-use { scan-assembler "\.section\[\t >

Re: [PATCH] Follow-up patch on enabling new AVX512 instructions

2016-11-16 Thread Uros Bizjak
On Tue, Nov 15, 2016 at 10:50 PM, Andrew Senkevich wrote: > Hi, > > this is follow-up with tests for new __target__ attributes and > __builtin_cpu_supports update. > > gcc/ > * config/i386/i386.c (processor_features): Add > F_AVX5124VNNIW,

Re: [2/9] Encoding support for AArch64 DWARF operations

2016-11-16 Thread Jason Merrill
On Wed, Nov 16, 2016 at 12:50 PM, Jason Merrill wrote: > On Fri, Nov 11, 2016 at 1:33 PM, Jiong Wang wrote: >> The encoding for new added AARCH64 DWARF operations. > > This patch seems rather incomplete; I only see a change to > dwarf2out.c, which won't

Re: Fix PR78154

2016-11-16 Thread Martin Sebor
On 11/16/2016 11:49 AM, Prathamesh Kulkarni wrote: Hi Richard, Following your suggestion in PR78154, the patch checks if stmt contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p and returns true in that case. Nice. I think the list should also include mempcpy, stpcpy, and

PR78319

2016-11-16 Thread Prathamesh Kulkarni
Hi, As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi. OK to commit ? Thanks, Prathamesh 2016-11-17 Prathamesh Kulkarni PR tree-optimization/78319 testsuite/ * gcc.dg/uninit-pred-8_a.c (foo): Mark dg-bogus test to

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-16 Thread Andrew Burgess
* Bernd Schmidt [2016-11-03 13:01:32 +0100]: > On 09/14/2016 03:00 PM, Andrew Burgess wrote: > > In an attempt to get this patch merged (as I still think that its > > correct) I've investigated, and documented a little more about how I > > think things currently work. I'm

Re: [PATCH] Handle --enable-checking={yes,assert,release} in libcpp (PR bootstrap/72823)

2016-11-16 Thread Richard Biener
On November 16, 2016 7:22:51 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >As mentioned in the PR, libcpp uses gcc_assert in a couple of places, >but guards it with ENABLE_ASSERT_CHECKING macro that is never defined >in libcpp. > >This patch arranges for it to be defined if

[PING^2][PATCH][aarch64] Improve Logical And Immediate Expressions

2016-11-16 Thread Michael Collison
Ping^2. Link to original post: https://gcc.gnu.org/ml/gcc-patches/2016-10/msg02305.html

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Krister Walfridsson
On Wed, 16 Nov 2016, Mike Stump wrote: Looks reasonable. The biggest issue would be if any of those values changed through time, and the current version works for older netbsd releases, the patch could break them. Of course, I don't have any visibility into how any of those values might

[PATCH v2 1/2, i386] cmpstrnsi needs string length

2016-11-16 Thread Aaron Sawdey
This patch adds a test to the cmpstrnsi pattern in i386.md so that it will bail out (FAIL) if neither of the strings is a constant string. It can only work as a proper strncmp if the length is not longer than both of the strings. This change is required if expand_builtin_strncmp is going to try

[PATCH v2 2/2, expand] make expand_builtin_strncmp more general

2016-11-16 Thread Aaron Sawdey
This patch makes expand_builtin_strncmp attempt to expand via cmpstrnsi even if neither of the string arguments are string constants. 2016-11-16  Aaron Sawdey   * builtins.c (expand_builtin_strncmp): Attempt expansion of strncmp via cmpstrnsi even if

[PATCH v2 0/2] strncmp builtin expansion improvement

2016-11-16 Thread Aaron Sawdey
Builtin expansion of strncmp currently only happens when at least one of the string arguments is a constant string. Two pieces are needed to enable this: 1) Fix i386.md cmpstrnsi pattern. It uses repzcmpsb which does not actually test for the zero byte ending the string. So this is only a valid

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Mike Stump
> On Nov 16, 2016, at 9:12 AM, Krister Walfridsson > wrote: > > NetBSD fails bootstrap with > stdatomic.h:55:17: error: unknown type name '__INT_LEAST8_TYPE__' > This is fixed by the following patch (only i386 and x86_64 for now. I'll > do the other ports after

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

2016-11-16 Thread Mike Stump
On Nov 16, 2016, at 10:58 AM, Mike Stump wrote: > > Yeah, I easily could have approved it as well, so no worries. Oh. I see I did approve the original patch, sorry for not catching it. Thanks for all your work.

Re: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp depend on

2016-11-16 Thread Mike Stump
On Nov 16, 2016, at 7:57 AM, Tamar Christina wrote: > > Forgot to include the committed patch. >>> This is causing all test names to depend on $srcdir. A test name >>> should never include the value of $srcdir. >> >> Sorry about that, committed a fix as r242500 under

Re: Fix PR78154

2016-11-16 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 12:19:37AM +0530, Prathamesh Kulkarni wrote: > --- a/gcc/tree-vrp.c > +++ b/gcc/tree-vrp.c > @@ -1069,6 +1069,34 @@ gimple_assign_nonzero_warnv_p (gimple *stmt, bool > *strict_overflow_p) > } > } > > +/* Return true if STMT is known to contain call to a

Re: [RFC PATCH] avoid printing type suffix with %E

2016-11-16 Thread Martin Sebor
On 11/16/2016 11:34 AM, Jeff Law wrote: On 10/26/2016 10:37 AM, Martin Sebor wrote: When formatting an integer constant using the %E directive GCC includes a suffix that indicates its type. This can perhaps be useful in some situations but in my experience it's distracting and gets in the way

Re: [PATCH v2] bb-reorder: Improve compgotos pass (PR71785)

2016-11-16 Thread Jeff Law
On 11/01/2016 10:27 AM, Segher Boessenkool wrote: For code like the testcase in PR71785 GCC factors all the indirect branches to a single dispatcher that then everything jumps to. This is because having many indirect branches with each many jump targets does not scale in large parts of the

Fix PR78154

2016-11-16 Thread Prathamesh Kulkarni
Hi Richard, Following your suggestion in PR78154, the patch checks if stmt contains call to memmove (and friends) in gimple_stmt_nonzero_warnv_p and returns true in that case. Bootstrapped+tested on x86_64-unknown-linux-gnu. Cross-testing on arm*-*-*, aarch64*-*-* in progress. Would it be OK to

Re: [PATCH][2/2] GIMPLE Frontend, middle-end changes

2016-11-16 Thread Jeff Law
On 10/28/2016 05:51 AM, Richard Biener wrote: These are the middle-end changes and additions to the testsuite. They are pretty self-contained, I've organized the changelog entries below in areas of changes: 1) dump changes - we add a -gimple dump modifier that allows most function dumps to

RE: RFA: PATCH to gengtype to avoid putting tree_node support in front end objects

2016-11-16 Thread Moore, Catherine
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Jakub Jelinek > Sent: Thursday, November 10, 2016 7:53 AM > To: Jason Merrill > Cc: gcc-patches List > Subject: Re: RFA: PATCH to

libgo patch committed: remove runtime1.goc

2016-11-16 Thread Ian Lance Taylor
This patch to libgo replaces runtime/runtime1.goc with Go and C code. This is a step toward eliminating goc2c. This drops the exported parfor code; it was needed for tests in the past, but no longer is. The Go 1.7 runtime no longer uses parfor. Bootstrapped and ran Go testsuite on

Re: [RFC PATCH] avoid printing type suffix with %E

2016-11-16 Thread Jeff Law
On 10/26/2016 10:37 AM, Martin Sebor wrote: When formatting an integer constant using the %E directive GCC includes a suffix that indicates its type. This can perhaps be useful in some situations but in my experience it's distracting and gets in the way when writing tests. Here's an example:

Re: New option -flimit-function-alignment

2016-11-16 Thread Jeff Law
On 10/14/2016 12:28 PM, Bernd Schmidt wrote: On 10/12/2016 09:27 PM, Denys Vlasenko wrote: Yes, something like "if max_skip >= func_size, temporarily lower max_skip to func_size-1" (because otherwise we can create padding bigger-or-equal to the entire function in size, which is stupid - it's

[PATCH] Handle --enable-checking={yes,assert,release} in libcpp (PR bootstrap/72823)

2016-11-16 Thread Jakub Jelinek
Hi! As mentioned in the PR, libcpp uses gcc_assert in a couple of places, but guards it with ENABLE_ASSERT_CHECKING macro that is never defined in libcpp. This patch arranges for it to be defined if ENABLE_ASSERT_CHECKING is going to be defined in gcc subdir. Bootstrapped/regtested on

[committed] Fix ICE with omp for broken_loop (PR fortran/78299)

2016-11-16 Thread Jakub Jelinek
Hi! When broken_loop is true (i.e. the OMP_FOR body doesn't return), loop->header doesn't have to be equal to body_bb, but it makes no sense to verify it. We aren't adding any loop in that case anyway. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2016-11-16 Jakub

Re: [PATCH, GCC/ARM] Make arm_feature_set agree with type of FL_* macros

2016-11-16 Thread Thomas Preudhomme
Hi, I've rebased the patch to make arm_feature_set agree with type of FL_* macros on top of trunk rather than on top of the optional -mthumb patch. That involved doing the changes to gcc/config/arm/arm-protos.h rather than gcc/config/arm/arm-flags.h. I also took advantage of the fact that

Re: [PATCH] Enable Intel AVX512_4FMAPS and AVX512_4VNNIW instructions

2016-11-16 Thread Andrew Senkevich
2016-11-16 19:21 GMT+03:00 Bernd Schmidt : > On 11/15/2016 05:31 PM, Andrew Senkevich wrote: >> >> 2016-11-15 17:56 GMT+03:00 Jeff Law : >>> >>> On 11/15/2016 05:55 AM, Andrew Senkevich wrote: 2016-11-11 14:16 GMT+03:00 Uros Bizjak

Re: [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-16 Thread Jeff Law
[ I'm catching up on a variety of things... So apologies if y'all have settled these issues. ] On 11/02/2016 01:32 PM, Jakub Jelinek wrote: But obviously not all levels of the warning can/should be enabled with -Wall/-Werror. There are cases which are worth warning by default (the case

Re: [PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Bernd Schmidt
On 11/16/2016 06:12 PM, Krister Walfridsson wrote: I'm the NetBSD maintainer, so I belive I don't need approval to commit this. But I have been absent for a long time, so it makes sense for someone to review at least this first patch. Bootstrapped and tested on i386-unknown-netbsdelf6.1 and

Re: [2/9] Encoding support for AArch64 DWARF operations

2016-11-16 Thread Jason Merrill
On Fri, Nov 11, 2016 at 1:33 PM, Jiong Wang wrote: > The encoding for new added AARCH64 DWARF operations. This patch seems rather incomplete; I only see a change to dwarf2out.c, which won't compile since the opcodes aren't defined anywhere. Jason

Re: Add SET_DECL_MODE

2016-11-16 Thread Jeff Law
On 11/16/2016 09:44 AM, Richard Sandiford wrote: This may no longer be necessary with the current version of the SVE patches, but it does at least make things consistent with the TYPE_MODE/SET_TYPE_MODE split. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Thanks, Richard

Re: [PATCH] Fix PR78305

2016-11-16 Thread Richard Biener
On November 16, 2016 5:22:17 PM GMT+01:00, Marc Glisse wrote: >On Wed, 16 Nov 2016, Michael Matz wrote: > >> Hi, >> >> On Wed, 16 Nov 2016, Marc Glisse wrote: >> > The first sentence about ORing the sign bit sounds strange (except >for a > sign-magnitude

PING [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

2016-11-16 Thread Martin Sebor
I'm looking for a review of the patch below: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00779.html Thanks On 11/08/2016 05:09 PM, Martin Sebor wrote: The -Wformat-length checker relies on the compute_builtin_object_size function to determine the size of the buffer it checks for overflow.

[PING] [PATCH, ARM] Further improve stack usage on sha512 (PR 77308)

2016-11-16 Thread Bernd Edlinger
Hi, I'd like to ping for these two patches: [PATCH, ARM] Further improve stack usage on sha512 (PR 77308) https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00523.html [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00830.html Thanks

[PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-16 Thread Bin Cheng
Hi, Currently test gfortran.dg/vect/fast-math-mgrid-resid.f checks all predictive commoning opportunities for all possible loops. This makes it fragile because vectorizer may peel the loop differently, as well as may choose different vector factors. For example, on x86-solaris, vectorizer

Re: [PATCH] warn on overflow in calls to allocation functions (bugs 77531 and 78284)

2016-11-16 Thread Martin Sebor
Attached is an updated version of the patch that also adds attribute alloc_size to the standard allocation built-ins (aligned_alloc, alloca, malloc, calloc, and realloc) and handles alloca. Besides that, I've renamed the option to -Walloc-size-larger-than to make it less similar to

[PATCH Obvious]Adjust test string wrto update dump info for gcc.target/arm/ivopts-orig_biv-inc.c

2016-11-16 Thread Bin Cheng
Hi, Dump information of IVOPT has been updated while test string gcc.target/arm/ivopts-orig_biv-inc.c is not. This patch does this. Test result checked on arm-none-eabi. Commit as obvious? Thanks, bin gcc/testsuite/ChangeLog 2016-11-16 Bin Cheng *

Re: [PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-16 Thread FX
> gcc/testsuite/ > 2016-11-16 Szabolcs Nagy > > PR libgfortran/78314 > * gfortran.dg/ieee/ieee_6.f90: Use ieee_support_halting. > > libgfortran/ > 2016-11-16 Szabolcs Nagy > > PR libgfortran/78314 > * config/fpu-glibc.h

RE: [PATCH] MIPS/GCC: Mark text contents as code or data

2016-11-16 Thread Maciej W. Rozycki
On Tue, 15 Nov 2016, Matthew Fortune wrote: > I'm a little concerned the expected output tests may be fragile over > time but let's wait and see. Indeed, but I'd rather see false negatives than false positives or no coverage at all. And I hope the pieces of expected assembly quoted will help

[PATCH] Fix NetBSD bootstrap

2016-11-16 Thread Krister Walfridsson
NetBSD fails bootstrap with stdatomic.h:55:17: error: unknown type name '__INT_LEAST8_TYPE__' This is fixed by the following patch (only i386 and x86_64 for now. I'll do the other ports after fixing some more issues -- the NetBSD support is rather broken at the moment...) I'm the NetBSD

Re: [PATCH] warn on overflow in calls to allocation functions (bugs 77531 and 78284)

2016-11-16 Thread Martin Sebor
On 11/14/2016 01:34 PM, Eric Gallager wrote: On 11/13/16, Martin Sebor wrote: Bug 77531 requests a new warning for calls to allocation functions (those declared with attribute alloc_size(X, Y)) that overflow the computation X * Z of the size of the allocated object. Bug

Re: [PATCH][PPC] Fix ICE using power9 with soft-float

2016-11-16 Thread Michael Meissner
On Wed, Nov 16, 2016 at 04:15:10PM +, Andrew Stubbs wrote: > On 16/11/16 13:10, Michael Meissner wrote: > >Yeah, SFmode and DFmode should not have the TARGET_{S,D}F_FPR checks. > > So, I can safely resolve my initial problem by simply removing them? > And that wouldn't break the other use of

Re: Use rtx_mode_t instead of std::make_pair

2016-11-16 Thread Bernd Schmidt
On 11/16/2016 05:52 PM, Richard Sandiford wrote: Using rtx_mode_t also abstracts away the representation. The fact that it's a std::pair rather than a custom class isn't important to users of the interface. Looks borderline obvious to me. OK. Bernd

[PATCH][AArch64] PR target/78362: Make sure to only take REGNO of a register

2016-11-16 Thread Kyrill Tkachov
Hi all, As the PR says we have an RTL checking failure that occurs when building libgcc for aarch64. The expander code for addsi3 takes the REGNO of a SUBREG in operands[1]. The three operands in the failing case are: {(reg:SI 78), (subreg:SI (reg:DI 77) 0), (subreg:SI (reg:DI 73 [ ivtmp.9 ])

[PATCH v2][PR libgfortran/78314] Fix ieee_support_halting

2016-11-16 Thread Szabolcs Nagy
ieee_support_halting only checked the availability of status flags, not trapping support. On some targets the later can only be checked at runtime: feenableexcept reports if enabling traps failed. So check trapping support by enabling/disabling it. Updated the test that enabled trapping to

Use rtx_mode_t instead of std::make_pair

2016-11-16 Thread Richard Sandiford
This change makes the code less sensitive to the exact type of the mode, i.e. it forces a conversion where necessary. This becomes important when wrappers like scalar_int_mode and scalar_mode can also be used instead of machine_mode. Using rtx_mode_t also abstracts away the representation. The

PING [PATCH] enable -fprintf-return-value by default

2016-11-16 Thread Martin Sebor
I'm looking for an approval of the attached patch. I've adjusted the documentation based on Sandra's input (i.e., documented the negative of the option rather than the positive; thank you for the review, btw.) On 11/08/2016 08:13 PM, Martin Sebor wrote: The -fprintf-return-value optimization

Add SET_DECL_MODE

2016-11-16 Thread Richard Sandiford
This may no longer be necessary with the current version of the SVE patches, but it does at least make things consistent with the TYPE_MODE/SET_TYPE_MODE split. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Thanks, Richard [ This patch is part of the SVE series posted here:

Re: [PATCH] Fix PR77848

2016-11-16 Thread Bill Schmidt
Thanks, Richard! I'll follow up with these changes over the next day or two. Appreciate all the help! Bill On Wed, 2016-11-16 at 16:08 +0100, Richard Biener wrote: > On Tue, Nov 15, 2016 at 9:03 PM, Bill Schmidt > wrote: > > Hi, > > > >

Re: [Patch 14/17] [libgcc, ARM] Generalise float-to-half conversion function.

2016-11-16 Thread Kyrill Tkachov
Hi James, On 11/11/16 15:42, James Greenhalgh wrote: Hi, I'm adapting this patch from work started by Matthew Wahab. Conversions from double precision floats to the ARM __fp16 are required to round only once. A conversion function for double to __fp16 to support this on soft-fp targets. This

Reorganise machmode.h headers

2016-11-16 Thread Richard Sandiford
Later patches will make machmode.h rely on wide-int.h and the new poly-int.h, so it needs to appear later in the coretypes.h include list. Previously machmode.h included insn-modes.h, which as well as the main mode enum contains configuration information like MAX_BITSIZE_MODE_ANY_INT. This still

Re: [RFC][PATCH] Speed-up use-after-scope (re-writing to SSA)

2016-11-16 Thread Jakub Jelinek
On Wed, Nov 16, 2016 at 05:01:31PM +0100, Martin Liška wrote: > + use_operand_p use_p; > + imm_use_iterator imm_iter; > + FOR_EACH_IMM_USE_FAST (use_p, imm_iter, poisoned_var) > +{ > + gimple *use = USE_STMT (use_p); > + if (is_gimple_debug (use)) > + continue; > + > +

Re: [PATCH] Fix PR78305

2016-11-16 Thread Marc Glisse
On Wed, 16 Nov 2016, Michael Matz wrote: Hi, On Wed, 16 Nov 2016, Marc Glisse wrote: The first sentence about ORing the sign bit sounds strange (except for a sign-magnitude representation). With 2's complement, INT_MIN is -2^31, the divisors are the 2^k and -(2^k). -2 * 2^30 yields INT_MIN,

Re: [PATCH] Enable Intel AVX512_4FMAPS and AVX512_4VNNIW instructions

2016-11-16 Thread Bernd Schmidt
On 11/15/2016 05:31 PM, Andrew Senkevich wrote: 2016-11-15 17:56 GMT+03:00 Jeff Law : On 11/15/2016 05:55 AM, Andrew Senkevich wrote: 2016-11-11 14:16 GMT+03:00 Uros Bizjak : --- a/gcc/genmodes.c +++ b/gcc/genmodes.c --- a/gcc/init-regs.c +++

Re: [PATCH][PPC] Fix ICE using power9 with soft-float

2016-11-16 Thread Andrew Stubbs
On 16/11/16 13:10, Michael Meissner wrote: Yeah, SFmode and DFmode should not have the TARGET_{S,D}F_FPR checks. So, I can safely resolve my initial problem by simply removing them? And that wouldn't break the other use of that predicate? But a secondary problem is the early clobber in the

Re: [PATCH] Fix PR78305

2016-11-16 Thread Michael Matz
Hi, On Wed, 16 Nov 2016, Michael Matz wrote: > > Looks good to me, thanks. > > An integer X is a power of two if and only if > X & -X == 0 (&& X != 0 if you want to exclude zero) Nonsense. It's X & -X == X (or X & (X-1) == 0) of course, and doesn't handle negative numbers. Still, no

Re: [RFC][PATCH] Speed-up use-after-scope (re-writing to SSA)

2016-11-16 Thread Martin Liška
As the patch quite significantly slowed down tramp3d, there's analysis of # of variables which are poisoned by the sanitizer: == normal variables == 24 B: 348x (5.80%) 16 B: 273x (4.55%) 8 B: 237x (3.95%) 1 B: 177x (2.95%) 4 B: 119x (1.98%) 40 B: 89x (1.48%) 144 B:

Re: [PATCH] Fix PR78305

2016-11-16 Thread Michael Matz
Hi, On Wed, 16 Nov 2016, Marc Glisse wrote: > > > The first sentence about ORing the sign bit sounds strange (except for a > > > sign-magnitude representation). With 2's complement, INT_MIN is -2^31, the > > > divisors are the 2^k and -(2^k). -2 * 2^30 yields INT_MIN, but your test > > > misses

Re: [RFC][PATCH] Speed-up use-after-scope (re-writing to SSA)

2016-11-16 Thread Martin Liška
On 11/16/2016 02:07 PM, Jakub Jelinek wrote: > On Wed, Nov 16, 2016 at 01:25:04PM +0100, Martin Liška wrote: >> >> + >> +/* Expand the ASAN_{LOAD,STORE} builtins. */ > > Stale comment. Fixed. > >> + >> +bool >> +asan_expand_poison_ifn (gimple_stmt_iterator *iter, >> +

Re: [Patch 16/17 libgcc ARM] Half to double precision conversions

2016-11-16 Thread Kyrill Tkachov
On 11/11/16 15:42, James Greenhalgh wrote: Hi, This patch adds the half-to-double conversions, both as library functions, or when supported in hardware, using the appropriate instructions. That means adding support for the __gnu_d2h_{ieee/alternative} library calls added in patch 2/4, and

Re: [PATCH 2/2] [ARC] Update target specific tests.

2016-11-16 Thread Andrew Burgess
* Claudiu Zissulescu [2016-05-30 14:32:38 +0200]: > Update the ARC specific tests. > > OK to apply? > Claudiu > > gcc/ > 2016-05-26 Claudiu Zissulescu > > * testsuite/gcc.target/arc/abitest.S: New file. > *

Re: [PING 2] [PATCH] enhance buffer overflow warnings (and c/53562)

2016-11-16 Thread Martin Sebor
I'm still looking for a review of the patch below, first posted on 10/28 and last updated/pinged last Wednesday: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00896.html Thanks On 11/09/2016 03:49 PM, Martin Sebor wrote: The attached minor update to the patch also resolves bug 77784 that

  1   2   >