Re: [PATCH] Fix ICE with LOOP_VECTORIZED ifn (PR tree-optimization/83581)

On December 30, 2017 8:42:06 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The problem on this testcase is that ldist pass changes some >GIMPLE_CONDs >into 0 != 0 or similar, but the pass doesn't perform any cleanups, then >ifcvt is run and does completely useless work of

Re: [PATCH] Fix another ICE with complex assignment (PR middle-end/83608)

On December 30, 2017 8:35:09 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The comment on convert_modes says: > Both modes may be floating, or both integer. >but as the testcase shows, with a MEM_REF with a different mode class >than a VAR_DECL as its operand we can end up with

Re: [PATCH] Fix expand_assignment stores to CONCAT (PR middle-end/83609)

On December 30, 2017 8:31:59 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >The first hunk before the if (!from...) part shows a typo I've made in >a >recent change, the last argument of simplify_gen_subreg is byte offset, >and >the subreg has same bitsize outer and inner modes, so

Re: [PATCH] Fix ICE with vector 16-bit rotate (PR middle-end/83623)

On December 30, 2017 8:27:44 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >Ths chunk of code wants to expand 16-bit rotate by 8 as bswaphi, but >if mode is a vector mode (or complex mode), trying to use bswaphi >pattern to >swap say V16HImode vector is just wrong. > >This patch

Re: [PATCH] PR 78534 Change character length from int to size_t

On 12/30/2017 12:35 PM, Janne Blomqvist wrote: > On Sat, Dec 30, 2017 at 7:16 PM, Thomas Koenig wrote: ---snip--- > > I can provide that stuff as a separate patch, or merge it into the > original megapatch and resubmit that, whichever way you prefer. I would prefer we

Re: [PATCH] PR 78534 Change character length from int to size_t

On Sat, Dec 30, 2017 at 7:16 PM, Thomas Koenig wrote: > Hi Janne, > >> To be honest, I haven't really done much testing with big strings, so >> far my focus has been on getting the existing testsuite to pass and >> getting the ABI right. > > > I agree that some of the test

[PATCH] expandargv: fix check for dynamic allocation of argument vector

When the code interpolates the contents of response files, the argument vector is reallocated to the new size. This only works if it was dynamically allocated once before -- we do not want to mess with the argv memory given to us by the init code. The code tried to detect this with a flag, but

Re: [PATCH] expandargv: fix memory leak

On Sat, 30 Dec 2017 18:27:30 +0100 Andreas Schwab wrote: > On Dez 30 2017, Daniel van Gerpen wrote: > > > When the responsefile's contents are interpolated into the argument > > vector, the pointer to original option string ("@filename") became > >

[PATCH] Fix ICE with LOOP_VECTORIZED ifn (PR tree-optimization/83581)

Hi! The problem on this testcase is that ldist pass changes some GIMPLE_CONDs into 0 != 0 or similar, but the pass doesn't perform any cleanups, then ifcvt is run and does completely useless work of duplicating dead loops and guarding them with LOOP_VECTORIZED ifns, and then during the ifcvt cfg

[C PATCH] Fix error recovery ICEs (PR c/83595)

Hi! As the patch shows, in lots of spots the C FE can return a c_expr with error_mark_node value, but uninitialized locations, so if something calls expr.get_location (), it can ICE. Other spots are already using the set_error method which sets the value to error_mark_node and in addition to

[PATCH] Fix another ICE with complex assignment (PR middle-end/83608)

Hi! The comment on convert_modes says: Both modes may be floating, or both integer. but as the testcase shows, with a MEM_REF with a different mode class than a VAR_DECL as its operand we can end up with e.g. floating point vs. integral mode etc. and convert_modes doesn't handle those cases.

[PATCH] Fix expand_assignment stores to CONCAT (PR middle-end/83609)

Hi! The first hunk before the if (!from...) part shows a typo I've made in a recent change, the last argument of simplify_gen_subreg is byte offset, and the subreg has same bitsize outer and inner modes, so using byte offset 1 makes no sense at all. Another issue that the testcase suffers from is

[PATCH] Fix ICE with vector 16-bit rotate (PR middle-end/83623)

Hi! Ths chunk of code wants to expand 16-bit rotate by 8 as bswaphi, but if mode is a vector mode (or complex mode), trying to use bswaphi pattern to swap say V16HImode vector is just wrong. This patch arranges to use bswapv16hi etc. instead in those cases, which isn't 100% clear to me from the

Re: [PATCH] expandargv: fix memory leak

On Dez 30 2017, Daniel van Gerpen wrote: > When the responsefile's contents are interpolated into the argument vector, > the pointer to original option string ("@filename") became lost. This > caused a small leak for every responsefile on the commandline. argv elements

Re: [PATCH] PR 78534 Change character length from int to size_t

Hi Janne, To be honest, I haven't really done much testing with big strings, so far my focus has been on getting the existing testsuite to pass and getting the ABI right. I agree that some of the test cases can be fixed later. However, I would really prefer if the I/O worked, because that is

Re: [patch, committed] Bug 83613 - [8 Regression] Executing gfortran.dg/inquire_internal.f90 hangs on darwin

On 12/29/2017 02:40 PM, Jerry DeLisle wrote: > Committed as obvious after regression testing on x86_64-pc-linux-gnu. > > Dominiq: Please confirm is fixed. > > Regards, > > Jerry > The actual patch, Dominiq confirmed the issue was fixed: diff --git a/libgfortran/io/unit.c

[PATCH] expandargv: fix memory leak

When the responsefile's contents are interpolated into the argument vector, the pointer to original option string ("@filename") became lost. This caused a small leak for every responsefile on the commandline. --- libiberty/argv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] PR 78534 Change character length from int to size_t

On Sat, Dec 30, 2017 at 4:59 PM, Thomas Koenig wrote: > That's all I could find for the moment. I will continue looking. > Thanks for tackling this! Thanks for testing! To be honest, I haven't really done much testing with big strings, so far my focus has been on getting

Re: [PATCH] PR 78534 Change character length from int to size_t

Hi Janne, In order to handle large character lengths on (L)LP64 targets, switch the GFortran character length from an int to a size_t. Just running some tests on gcc110 (the big-endian PPC machine from the compile farm). Something does not seem to work with I/O with long strings. With

Re: [libgomp, openacc, openmp, PR83046] Prune removed funcs from offload table

On 12/30/2017 10:54 AM, Jakub Jelinek wrote: On Fri, Dec 29, 2017 at 02:07:49PM +0100, Tom de Vries wrote: --- a/gcc/lto-streamer-out.c +++ b/gcc/lto-streamer-out.c @@ -41,6 +41,7 @@ along with GCC; see the file COPYING3. If not see #include "builtins.h" #include "gomp-constants.h"

[testsuite, PR83612] Fix 'memory cannot be printed' in gcc.dg/ubsan/object-size-9.c

Hi, I ran into the following failure: ... FAIL: gcc.dg/ubsan/object-size-9.c -O2 output pattern test, is gcc.dg/ubsan/object-size-9.c:11:13: runtime error: load of address 0x00600ff2 with insufficient space for an object of type 'char' 0x00600ff2: note: pointer points here ... The

Re: [libgomp, openacc, openmp, PR83046] Prune removed funcs from offload table

On Fri, Dec 29, 2017 at 02:07:49PM +0100, Tom de Vries wrote: > --- a/gcc/lto-streamer-out.c > +++ b/gcc/lto-streamer-out.c > @@ -41,6 +41,7 @@ along with GCC; see the file COPYING3. If not see > #include "builtins.h" > #include "gomp-constants.h" > #include "debug.h" > +#include

Re: [PATCH] Fix gcc.target/i386/avx512vpopcntdqvl-vpopcnt*-1.c FAILs

On Thu, Dec 28, 2017 at 4:18 PM, Jakub Jelinek wrote: > Hi! > > Binutils had vpopcnt[dq] support since ~ January, but only for the 512-bit > instructions, only in ~ October further support for the AVX512VPOPCNTDQ | > AVX512VL instructions has been added. So, if one is using gas

Re: [PATCH] Fix gcc.target/i386/avx512vpopcntdqvl-vpopcnt*-1.c FAILs

On Thu, Dec 28, 2017 at 4:18 PM, Jakub Jelinek wrote: > Hi! > > Binutils had vpopcnt[dq] support since ~ January, but only for the 512-bit > instructions, only in ~ October further support for the AVX512VPOPCNTDQ | > AVX512VL instructions has been added. So, if one is using gas

Re: [PATCH] Misc sse.md formatting fixes

On Thu, Dec 28, 2017 at 10:06 AM, Jakub Jelinek wrote: > Hi! > > I've noticed various formatting issues in the recently added ISA support > patterns. No functional changes, bootstrapped/regtested on x86_64-linux and > i686-linux, ok for trunk? > > OT, wonder why we have any of

New Spanish PO file for 'gcc' (version 7.2.0)

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/gcc/es.po (This file, 'gcc-7.2.0.es.po', has