Re: Extend aligned_membuf<> usage

2018-02-07 Thread François Dumont
On 06/02/2018 20:16, François Dumont wrote: On 05/02/2018 18:16, Jonathan Wakely wrote: Wouldn't it make more sense to simply make __aligned_buffer identical to __aligned_membuf for the versioned-namespace? Then at least the conditional code is only in one place. Yes, __aligned_buffer is

[PATCH] Fix -fcompare-debug failure on pr84146.c (PR target/84146)

2018-02-07 Thread Jakub Jelinek
Hi! Unfortunately, seems my rest_of_insert_endbranch fix doesn't fix -fcompare-debug on the testcase, when adding the endbr after the setjmp call with no note in between, we add it into the same bb as the setjmp call, while when adding it with -g with NOTE_INSN_CALL_ARG_LOCATION, which is already

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-07 Thread Jeff Law
On 02/06/2018 08:59 AM, Martin Sebor wrote: > On 02/06/2018 06:23 AM, Marek Polacek wrote: >> On Tue, Feb 06, 2018 at 01:57:36PM +0100, Jakub Jelinek wrote: >>> On Tue, Feb 06, 2018 at 01:46:21PM +0100, Marek Polacek wrote: --- gcc/testsuite/c-c++-common/Wstringop-truncation-3.c +++

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-07 Thread Jeff Law
On 02/06/2018 05:57 AM, Jakub Jelinek wrote: > On Tue, Feb 06, 2018 at 01:46:21PM +0100, Marek Polacek wrote: >> --- gcc/testsuite/c-c++-common/Wstringop-truncation-3.c >> +++ gcc/testsuite/c-c++-common/Wstringop-truncation-3.c >> @@ -0,0 +1,20 @@ >> +/* PR tree-optimization/84228 */ >> +/* {

Re: PATCH to fix bogus warning with -Wstringop-truncation -g (PR tree-optimization/84228)

2018-02-07 Thread Jeff Law
On 02/06/2018 05:46 AM, Marek Polacek wrote: > When -Wstringop-truncation sees a strncpy call where the specified bound > is equal to the size of the destination, it looks at the next statement > to see if it's dst[i] = '\0';, and if it is, it doesn't warn. But it > needs to look at the next

Re: [PATCH/RFC] Fix ICE in find_taken_edge_computed_goto (PR 84136)

2018-02-07 Thread Jeff Law
On 02/02/2018 02:35 PM, David Malcolm wrote: > On Thu, 2018-02-01 at 12:05 +0100, Richard Biener wrote: >> On Wed, Jan 31, 2018 at 4:39 PM, David Malcolm >> wrote: >>> PR 84136 reports an ICE within sccvn_dom_walker when handling a >>> C/C++ source file that overuses the

Re: [PATCH/RFC] Fix ICE in find_taken_edge_computed_goto (PR 84136)

2018-02-07 Thread Jeff Law
On 02/01/2018 04:05 AM, Richard Biener wrote: > On Wed, Jan 31, 2018 at 4:39 PM, David Malcolm wrote: >> PR 84136 reports an ICE within sccvn_dom_walker when handling a >> C/C++ source file that overuses the labels-as-values extension. >> The code in question stores a jump

Re: [PATCH/RFC] Fix ICE in find_taken_edge_computed_goto (PR 84136)

2018-02-07 Thread Jeff Law
On 01/31/2018 08:39 AM, David Malcolm wrote: > PR 84136 reports an ICE within sccvn_dom_walker when handling a > C/C++ source file that overuses the labels-as-values extension. > The code in question stores a jump label into a global, and then > jumps to it from another function, which ICEs after

Re: [PR tree-optimization/84224] do not ICE on malformed allocas

2018-02-07 Thread Jeff Law
On 02/06/2018 02:38 AM, Aldy Hernandez wrote: > The -Walloca pass can receive a malformed alloca, courtesy of someone > providing a faulty prototype.  This was causing an ICE because we > assumed alloca calls had at least one argument, which the testcase does > not: > > +void *alloca (); >

Re: [PATCH] Fix floating point handling in dom (PR tree-optimization/84235)

2018-02-07 Thread Jeff Law
On 02/07/2018 12:06 AM, Richard Biener wrote: > On February 6, 2018 9:40:37 PM GMT+01:00, Jakub Jelinek > wrote: >> Hi! >> >> As the following testcase shows, dom2 miscompiles floating point x - x >> into 0.0 even when x could be infinity and x - x then a NaN. >> The

Re: [PATCH] add -Wstringop-overflow to LTO options (PR 84212)

2018-02-07 Thread Martin Sebor
I went ahead and changed all the options on the list below to include LTO and tested the attached patch by configuring with --with-build-config=bootstrap-lto --disable-werror and making profiledbootstrap. Attached, besides the patch, is also the breakdown of warnings. The interesting column is

[PATCH] -Wformat: fix nonsensical "wide character" message (PR c/84258)

2018-02-07 Thread David Malcolm
PR c/84258 reports that we issue this: warning: format is a wide character string [-Wformat=] on this code: const unsigned char cuc[] = "%i"; sprintf(buf, (char *)cuc, 1); despite the absence of wide characters. This wording dates back 17.5 years to r36586: 2000-09-24 Joseph S. Myers

Re: [RFC][PR82479] missing popcount builtin detection

2018-02-07 Thread Kugan Vivekanandarajah
Hi Richard, On 1 February 2018 at 23:21, Richard Biener wrote: > On Thu, Feb 1, 2018 at 5:07 AM, Kugan Vivekanandarajah > wrote: >> Hi Richard, >> >> On 31 January 2018 at 21:39, Richard Biener >>

Re: [PATCH], Document the PowerPC --with-long-double-format={ibm,ieee} configuration options

2018-02-07 Thread Michael Meissner
On Wed, Feb 07, 2018 at 05:26:49PM -0600, Segher Boessenkool wrote: > On Wed, Feb 07, 2018 at 05:48:26PM -0500, Michael Meissner wrote: > > This patch udpates the GCC installation documentation to document the > > configuration options to set the long double type on the PowerPC: I verified > >

Re: Please accept this commit for the trunk

2018-02-07 Thread Mike Stump
On Feb 5, 2018, at 8:42 AM, Douglas Mencken wrote: > > I’m about > > “ [PATCH 2/4] [Darwin,PPC] Remove uses of LR in > restore_world ” https://gcc.gnu.org/bugzilla/attachment.cgi?id=42304 > > look at bug #84113 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84113 for >

Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target

2018-02-07 Thread Segher Boessenkool
On Wed, Feb 07, 2018 at 05:23:31PM -0600, Will Schmidt wrote: > > > /* { dg-do compile { target { powerpc64le-*-* && lp64 } } } */ > > > /* { dg-skip-if "" { powerpc*-*-darwin* } } */ > > > /* { dg-require-effective-target powerpc_vsx_ok } */ > > > -/* { dg-options "-mvsx -O2" } */ > > > +/* {

Re: [PATCH], Document the PowerPC --with-long-double-format={ibm,ieee} configuration options

2018-02-07 Thread Segher Boessenkool
On Wed, Feb 07, 2018 at 05:48:26PM -0500, Michael Meissner wrote: > This patch udpates the GCC installation documentation to document the > configuration options to set the long double type on the PowerPC: I verified > that the documentation builds. Can I install this on to the trunk? Yes

Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target

2018-02-07 Thread Will Schmidt
On Wed, 2018-02-07 at 12:28 -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Feb 07, 2018 at 11:16:12AM -0600, Will Schmidt wrote: > > Noted during review of test results on P9. Due to changes and > > improvements, > > our codegen is different for this test on power9. > > Modified the

Re: [PATCH, rs6000] fix vsxcopy test for power9

2018-02-07 Thread Will Schmidt
On Wed, 2018-02-07 at 12:02 -0600, Segher Boessenkool wrote: > Hi, > > On Wed, Feb 07, 2018 at 10:59:46AM -0600, Will Schmidt wrote: > > Noted during review of test results on P9. The vsxcopy.c test is looking > > for lxvd2x, stxvd2x instructions in generated code. For P9 targets, we will > >

[PATCH], Document the PowerPC --with-long-double-format={ibm,ieee} configuration options

2018-02-07 Thread Michael Meissner
This patch udpates the GCC installation documentation to document the configuration options to set the long double type on the PowerPC: I verified that the documentation builds. Can I install this on to the trunk? 2018-02-07 Michael Meissner *

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jakub Jelinek
On Wed, Feb 07, 2018 at 03:52:39PM -0500, Jason Merrill wrote: > > E.g. the constexpr function uses same_type_ignoring_top_level_qualifiers_p > > instead of == type comparisons, the COMPONENT_REF stuff, ... > > > For poly_* stuff, I think Richard S. wants to introduce it into the FEs at > > some

[PATCH] Fix var-tracking ICE introduced in poly_int conversion (PR debug/84252)

2018-02-07 Thread Jakub Jelinek
Hi! As mentioned in the PR, the vt_get_decl_and_offset function verifies incoming PARALLEL is usable for tracking, but if it fails, we retry vt_get_decl_and_offset on DECL_RTL and there we check only that a memory isn't larger than 16 bytes (to make sure it doesn't have more than 16 parts), but

Re: [PATCH] PowerPC PR target/84154, fix floating point to small integer conversion regression

2018-02-07 Thread Segher Boessenkool
Hi Mike, On Tue, Feb 06, 2018 at 04:34:08PM -0500, Michael Meissner wrote: > Here is the patch reworked. It bootstraps on both little/big endian power8, > and all of the tests run. Can I install this into trunk now, and into GCC 7 > after a soak period (along with the previous patch)? > +;; If

[Committed] PR fortran/82994 -- Check for a NULL pointer

2018-02-07 Thread Steve Kargl
Committed as obvious. 2018-02-07 Steven G. Kargl PR fortran/82994 * match.c (gfc_match_deallocate): Check for NULL pointer. 2018-02-07 Steven G. Kargl PR fortran/82994 * gfortran.dg/deallocate_error_3.f90: New test.

New Spanish PO file for 'gcc' (version 8.1-b20180128)

2018-02-07 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/gcc/es.po (This file, 'gcc-8.1-b20180128.es.po',

Re: [PATCH] libgcc: xtensa: fix build with -mtext-section-literals

2018-02-07 Thread Max Filippov
On Thu, Feb 1, 2018 at 9:12 AM, Max Filippov wrote: > On Wed, Jan 31, 2018 at 11:17 AM, Max Filippov wrote: >> On Wed, Jan 31, 2018 at 11:11 AM, augustine.sterl...@gmail.com >> wrote: >>> On Tue, Jan 30, 2018 at 8:02 PM, Max

libgo patch committed: Don't call funcPC from a function

2018-02-07 Thread Ian Lance Taylor
This patch changes the libgo runtime package to not call funcPC from a function. The escape analysis support is not yet good enough to avoid escaping the argument to funcPC. This causes unnecessary and often harmful memory allocation. E.g., (*cpuProfile).addExtra can be called from a signal

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jakub Jelinek
On Wed, Feb 07, 2018 at 08:36:31PM +0100, Marek Polacek wrote: > > > That was my first patch, but it was rejected: > > > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00271.html > > > > Then should we update fold_indirect_ref_1 to use the new code? Is > > there a reason for them to stay out of

Re: [C++ Patch/RFC] PR 83204 ("[6/7/8 Regression] c++ -std=c++14 ICE in maybe_undo_parenthesized_ref, at cp/semantics.c:1694")

2018-02-07 Thread Jason Merrill
OK. On Wed, Feb 7, 2018 at 4:16 PM, Paolo Carlini wrote: > Hi, > > this is essentially an RFC, I'm still fully analyzing the issue, but since I > already have something prima facie reasonable and passing the testsuite I > decided to send immediately out what I have,

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jason Merrill
On Wed, Feb 7, 2018 at 4:14 PM, Jakub Jelinek wrote: > On Wed, Feb 07, 2018 at 03:52:39PM -0500, Jason Merrill wrote: >> > E.g. the constexpr function uses same_type_ignoring_top_level_qualifiers_p >> > instead of == type comparisons, the COMPONENT_REF stuff, ... >> >> > For

[C++ Patch/RFC] PR 83204 ("[6/7/8 Regression] c++ -std=c++14 ICE in maybe_undo_parenthesized_ref, at cp/semantics.c:1694")

2018-02-07 Thread Paolo Carlini
Hi, this is essentially an RFC, I'm still fully analyzing the issue, but since I already have something prima facie reasonable and passing the testsuite I decided to send immediately out what I have, looking for further feedback / help. As fully analyzed by Jakub in the audit trail, for the

Re: [PATCH] PR fortran/82049 -- resolve a charlen if possible

2018-02-07 Thread Steve Kargl
Thanks. A version of the patch has been commit to 6-branch, 7-branch, and trunk. One regression down, many more to go. -- steve On Wed, Feb 07, 2018 at 08:10:41AM +, Paul Richard Thomas wrote: > Hi Steve, > > That's OK for trunk and, if you are possessed of the intestinal > fortitude, 6-

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jason Merrill
On Wed, Feb 7, 2018 at 3:32 PM, Jakub Jelinek wrote: > On Wed, Feb 07, 2018 at 03:23:25PM -0500, Jason Merrill wrote: >> On Wed, Feb 7, 2018 at 2:48 PM, Jakub Jelinek wrote: >> > On Wed, Feb 07, 2018 at 08:36:31PM +0100, Marek Polacek wrote: >> >> > > That was

Re: [patch, fortran] Fix PR 68560

2018-02-07 Thread Steve Kargl
On Wed, Feb 07, 2018 at 09:42:04PM +0100, Thomas Koenig wrote: > Here's an update on the patch - I realized that it is not necessary > to check for the actual argument, it is always present. > > OK for trunk? > Yes. -- Steve

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jakub Jelinek
On Wed, Feb 07, 2018 at 03:23:25PM -0500, Jason Merrill wrote: > On Wed, Feb 7, 2018 at 2:48 PM, Jakub Jelinek wrote: > > On Wed, Feb 07, 2018 at 08:36:31PM +0100, Marek Polacek wrote: > >> > > That was my first patch, but it was rejected: > >> > >

Re: [patch, fortran] Fix PR 68560

2018-02-07 Thread Thomas Koenig
Here's an update on the patch - I realized that it is not necessary to check for the actual argument, it is always present. OK for trunk? Regards Thomas 2018-02-01  Thomas Koenig  PR fortran/68560 * trans-intrinsic.c (gfc_conv_intrinsic_shape): New

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jason Merrill
On Wed, Feb 7, 2018 at 2:48 PM, Jakub Jelinek wrote: > On Wed, Feb 07, 2018 at 08:36:31PM +0100, Marek Polacek wrote: >> > > That was my first patch, but it was rejected: >> > > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00271.html >> > >> > Then should we update

Re: [openacc, committed] Fix diff_type in expand_oacc_collapse_init

2018-02-07 Thread Tom de Vries
On 02/07/2018 08:37 PM, Rainer Orth wrote: Hi Tom, this patch fixes an 8 regression in an openacc testcase. The regression was introduced by r250925, a fix for PR78266, a bug in the handling of a loop with iteration variable type range smaller than the size of the parallel dimension the loop

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-07 Thread Jason Merrill
On 02/06/2018 11:01 PM, Martin Sebor wrote: On 02/05/2018 02:52 PM, Jason Merrill wrote: On 02/04/2018 07:07 PM, Martin Sebor wrote: To resolve the underlying root cause of the P1 bug c++/83503 - bogus -Wattributes for const and pure on function template specialization, that we discussed last

Re: [openacc, committed] Fix diff_type in expand_oacc_collapse_init

2018-02-07 Thread Rainer Orth
Hi Tom, > this patch fixes an 8 regression in an openacc testcase. > > The regression was introduced by r250925, a fix for PR78266, a bug in the > handling of a loop with iteration variable type range smaller than the size > of the parallel dimension the loop is assigned to. > > The fix for the

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Marek Polacek
On Wed, Feb 07, 2018 at 01:23:49PM -0500, Jason Merrill wrote: > On Wed, Feb 7, 2018 at 12:54 PM, Marek Polacek wrote: > > On Wed, Feb 07, 2018 at 12:26:04PM -0500, Jason Merrill wrote: > >> On Fri, Jan 26, 2018 at 6:22 PM, Jakub Jelinek wrote: > >> > On

[PATCH] add -Wstringop-overflow to LTO options (PR 84212)

2018-02-07 Thread Martin Sebor
In PR 84212 the reporter asks why -Wno-stringop-overflow has no effect during LTO linking. It turns out that the reason is the same as in bug 78768: the specification in the c.opt file is missing LTO among the languages. The attached patch adds LTO to it and to -Wstringop-truncation.

Re: [SFN+LVU+IEPM v4 7/9] [LVU] Introduce location views

2018-02-07 Thread Jason Merrill
On 02/06/2018 11:02 PM, Alexandre Oliva wrote: On Feb 6, 2018, Jason Merrill wrote: On 12/11/2017 09:52 PM, Alexandre Oliva wrote: Why do we need to use a non-zero view identifier for a zero view? Why can't we always use 0 instead of the bitmap? We assign view ids

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-07 Thread David Malcolm
On Wed, 2018-02-07 at 17:26 +, Nick Clifton wrote: > Hi Martin, Hi David, > > OK - attached is a new patch that: > > * Replaces control characters with their escape equivalents. > * Includes a testcase. > > I was not sure what to do about the inconsistencies between the > behaviour of

[PATCH][GCC][ARM] Silence more re-definition warnings, make test case failure case more explicit.

2018-02-07 Thread Tamar Christina
Hi All, The previous testcase would fail on a system where the initial mode is thumb and later switches to an arm mode. This would again cause some warnings to be emitted. This patch visits all builtins defined with builtin_define_with_int_value and undefines them if they could possibly change

Re: [PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target

2018-02-07 Thread Segher Boessenkool
Hi! On Wed, Feb 07, 2018 at 11:16:12AM -0600, Will Schmidt wrote: > Noted during review of test results on P9. Due to changes and improvements, > our codegen is different for this test on power9. > Modified the existing test to target P8, and added a P9 variant with updated > counts. > diff

Re: [PATCH] C++: avoid most reserved words as misspelling suggestions (PR c++/81610 and PR c++/80567)

2018-02-07 Thread David Malcolm
On Wed, 2018-02-07 at 13:22 -0500, Jason Merrill wrote: > On Wed, Feb 7, 2018 at 1:12 PM, David Malcolm > wrote: > > On Wed, 2018-02-07 at 12:21 -0500, Jason Merrill wrote: > > > On Fri, Jan 26, 2018 at 1:12 PM, David Malcolm > > om> > > > wrote: > > > >

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jason Merrill
On Wed, Feb 7, 2018 at 12:54 PM, Marek Polacek wrote: > On Wed, Feb 07, 2018 at 12:26:04PM -0500, Jason Merrill wrote: >> On Fri, Jan 26, 2018 at 6:22 PM, Jakub Jelinek wrote: >> > On Fri, Jan 26, 2018 at 02:11:19PM +0100, Richard Biener wrote: >> >> >>

Re: [PATCH] C++: avoid most reserved words as misspelling suggestions (PR c++/81610 and PR c++/80567)

2018-02-07 Thread Jason Merrill
On Wed, Feb 7, 2018 at 1:12 PM, David Malcolm wrote: > On Wed, 2018-02-07 at 12:21 -0500, Jason Merrill wrote: >> On Fri, Jan 26, 2018 at 1:12 PM, David Malcolm >> wrote: >> > On Mon, 2017-12-11 at 17:24 -0500, Jason Merrill wrote: >> > > On Wed, Nov 22,

Re: [PATCH] C++: avoid most reserved words as misspelling suggestions (PR c++/81610 and PR c++/80567)

2018-02-07 Thread David Malcolm
On Wed, 2018-02-07 at 12:21 -0500, Jason Merrill wrote: > On Fri, Jan 26, 2018 at 1:12 PM, David Malcolm > wrote: > > On Mon, 2017-12-11 at 17:24 -0500, Jason Merrill wrote: > > > On Wed, Nov 22, 2017 at 10:36 AM, David Malcolm > > com> > > > wrote: > > >

[PATCH v6] aarch64: Add split-stack support

2018-02-07 Thread Adhemerval Zanella
Changes from previous version: - Changed the wait to call __morestack to use use a branch with link instead of a simple branch. This allows use a call instruction and avoid possible issues with later optimization passes which might see a branch outside the instruction block (as

Re: [PATCH, rs6000] fix vsxcopy test for power9

2018-02-07 Thread Segher Boessenkool
Hi, On Wed, Feb 07, 2018 at 10:59:46AM -0600, Will Schmidt wrote: > Noted during review of test results on P9. The vsxcopy.c test is looking > for lxvd2x, stxvd2x instructions in generated code. For P9 targets, we will > instead generate lxv, stxv instructions. > Thus, update the test to handle

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Marek Polacek
On Wed, Feb 07, 2018 at 12:26:04PM -0500, Jason Merrill wrote: > On Fri, Jan 26, 2018 at 6:22 PM, Jakub Jelinek wrote: > > On Fri, Jan 26, 2018 at 02:11:19PM +0100, Richard Biener wrote: > >> >> POINTER_PLUS_EXPR offets are to be interpreted as signed (ptrdiff_t) > >> >> so

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-07 Thread Nick Clifton
Hi Martin, Hi David, OK - attached is a new patch that: * Replaces control characters with their escape equivalents. * Includes a testcase. I was not sure what to do about the inconsistencies between the behaviour of #warning and #pragma GCC warning, (and the error equivalents), so I

Re: C++ PATCH to fix ICE with vector expr folding (PR c++/83659)

2018-02-07 Thread Jason Merrill
On Fri, Jan 26, 2018 at 6:22 PM, Jakub Jelinek wrote: > On Fri, Jan 26, 2018 at 02:11:19PM +0100, Richard Biener wrote: >> >> POINTER_PLUS_EXPR offets are to be interpreted as signed (ptrdiff_t) >> >> so using uhwi and then performing an unsigned division is wrong code. >> >>

Re: [PATCH] C++: avoid most reserved words as misspelling suggestions (PR c++/81610 and PR c++/80567)

2018-02-07 Thread Jason Merrill
On Fri, Jan 26, 2018 at 1:12 PM, David Malcolm wrote: > On Mon, 2017-12-11 at 17:24 -0500, Jason Merrill wrote: >> On Wed, Nov 22, 2017 at 10:36 AM, David Malcolm >> wrote: > > Original post: > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02048.html >

[PATCH, rs6000] Update vsx-vector-6-le.c tests for p9 target

2018-02-07 Thread Will Schmidt
Hi, Noted during review of test results on P9. Due to changes and improvements, our codegen is different for this test on power9. Modified the existing test to target P8, and added a P9 variant with updated counts. Sniff-tested, now runs clean on P9. OK for trunk? Thanks, -Will

Re: [PATCH, rs6000] fix requires for mergew-mergeow.c test

2018-02-07 Thread Segher Boessenkool
Hi! On Wed, Feb 07, 2018 at 10:30:05AM -0600, Will Schmidt wrote: > Noted during review of test results. The builtins-mergew-mergeow.c testcase > uses the vec_mergeo() intrinsics that did not exist before power8. Thus, > update the -requires stanza so we don't try to build/run this on earlier

Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL

2018-02-07 Thread Alexander Monakov
> On Wed, 31 Jan 2018, Wilco Dijkstra wrote: > > > The comparison order for SCHED_PRESSURE_MODEL is incorrect. If either > > instruction is not in target_bb, the ordering is not well defined. To fix > > this, give all instructions in target_bb the highest priority and sort all > > other

[PATCH, rs6000] fix vsxcopy test for power9

2018-02-07 Thread Will Schmidt
Hi, Noted during review of test results on P9. The vsxcopy.c test is looking for lxvd2x, stxvd2x instructions in generated code. For P9 targets, we will instead generate lxv, stxv instructions. Thus, update the test to handle that codegen as well. Sniff-tested on P9. OK for trunk? Thanks,

[RFC][PATCH] Stabilize a few qsort comparison functions

2018-02-07 Thread Franz Sirl
Hi, this is the result of an attempt to minimize the differences between the compile results of a Linux-based and a Cygwin64-based powerpc-eabi cross toolchain. The method used was:     - find the -fverbose-asm assembler files that differ     - compile that file again on both platforms with

Re: [PATCH] PR84068: Fix sort order of SCHED_PRESSURE_MODEL

2018-02-07 Thread Maxim Kuvyrkov
> On Feb 2, 2018, at 7:40 PM, Wilco Dijkstra wrote: > > Right, so here is version 2 which ends up much simpler: > > The comparison function for SCHED_PRESSURE_MODEL is incorrect. If either > instruction is not in target_bb, the ordering is not well defined. > Since

[PATCH, rs6000] fix requires for mergew-mergeow.c test

2018-02-07 Thread Will Schmidt
Hi, Noted during review of test results. The builtins-mergew-mergeow.c testcase uses the vec_mergeo() intrinsics that did not exist before power8. Thus, update the -requires stanza so we don't try to build/run this on earlier systems. Sniff-tested OK on P6,P7,P8,P9. OK for trunk? Thanks

Re: [PATCH 2/7] Support >26 operands in generation code.

2018-02-07 Thread Alan Hayward
> On 6 Feb 2018, at 17:03, Richard Sandiford > wrote: > > Alan Hayward writes: >> This patch adds support for CLOBBER_HIGH in the generation code. >> >> An aarch64 will require 31 clobber high expressions, plus two >> clobbers. >> >> The

C++ PATCH for c++/84182, ICE with captured lambda

2018-02-07 Thread Jason Merrill
My patch for 84126 didn't go far enough in handling the case of things in local_specializations causing trouble with partial pack expansions; it isn't enough to handle function parameters, we need to remember everything that comes from local_specializations. Tested x86_64-pc-linux-gnu, applying

[PATCH][Middle-end][version 3]2nd patch of PR78809 and PR83026

2018-02-07 Thread Qing Zhao
Hi, this is the 3rd version for this patch. the main change compared with 2nd version are: 1. do not use “compute_objsize” to get the minimum object size per Jeff and Richard’s comment. Instead, add a new function “determine_min_objsize” for this purpose. This new function calls

[PATCH, rs6000] PR84220 fix altivec_vec_sld and vec_sldw intrinsic definitions

2018-02-07 Thread Will Schmidt
Hi, Our VEC_SLD definitions were mistakenly allowing the third argument to be of an invalid type, triggering an ICE (on invalid code) later in the build process. This fixes those definitions. The nearby VEC_SLDW definitions have the same issue, those have been fixed as part of this patch too.

[PATCH] Improve # IVs generated by the vectorizer for strided loads/stores (PR84037)

2018-02-07 Thread Richard Biener
One of the issues with PR84037 is we spill IVs a lot because the vectorizer blows up the number of IVs from 7 needed for the scalar loop (after IVO) to 22. The following patch brings this down to 11 (and 7 with -mprefer-avx128 -- need to still investigate that difference). The

Re: PING [PATCH] -mjsr option bug fix

2018-02-07 Thread Nick Clifton
Hi Sebastian, > +2018-01-05 Sebastian Perta > + > + * config/rx/constraints.md: added new constraint > CALL_OP_SYMBOL_REF > + to allow or block "symbol_ref" depending on value of TARGET_JSR > + * config/rx/rx.md: use CALL_OP_SYMBOL_REF in call_internal

Re: PING [PATCH] RX movsicc degrade fix

2018-02-07 Thread Nick Clifton
Hi Sebastian, Sorry for missing this one. If it helps in the future, feel free to ping me directly. > +2018-01-09 Sebastian Perta > + > + *config/rx.md: updated "movsicc" expand to be matched by GCC > + *testsuite/gcc.target/rx/movsicc.c: new test case

Re: [PATCH, i386] Fix ix86_multiplication_cost for SKX

2018-02-07 Thread Uros Bizjak
On Wed, Feb 7, 2018 at 2:02 PM, Shalnov, Sergey wrote: > Hi, > This patch is one of the set of patches to fix SKX costs. Please post the whole series for review. Thanks, Uros. > I think multiplication costs calculation algorithm needs to be adjusted in >

[PATCH, i386] Fix ix86_multiplication_cost for SKX

2018-02-07 Thread Shalnov, Sergey
Hi, This patch is one of the set of patches to fix SKX costs. I think multiplication costs calculation algorithm needs to be adjusted in gcc/config/i386/i386.c ix86_multiplication_cost() function. For TARGET_AVX512DQ emulation is not used and single vpmullq instruction emitted. I think we have

Re: [PATCH] Revert behavior to r251316.

2018-02-07 Thread Nathan Sidwell
On 02/07/2018 07:03 AM, Martin Liška wrote: Hello. The refactoring in r251316 changed the logic when cgraph_node::record_function_versions function is called. Suggested patch reverts the logic prior to the revision. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.

[PATCH] Revert behavior to r251316.

2018-02-07 Thread Martin Liška
Hello. The refactoring in r251316 changed the logic when cgraph_node::record_function_versions function is called. Suggested patch reverts the logic prior to the revision. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. And make check RUNTESTFLAGS="i386.exp" on x86_64

[PATCH] S/390: Disable prediction of indirect branches

2018-02-07 Thread Andreas Krebbel
This patch implements GCC support for mitigating vulnerability CVE-2017-5715 known as Spectre #2 on IBM Z. In order to disable prediction of indirect branches the implementation makes use of an IBM Z specific feature - the execute instruction. Performing an indirect branch via execute prevents

[testsuite, committed] Require alloca in gcc.dg/pr83844.c

2018-02-07 Thread Tom de Vries
Hi, this patch requires effective target alloca in gcc.dg/pr83844.c. Committed. Thanks, - Tom [testsuite] Require alloca in gcc.dg/pr83844.c 2018-02-07 Tom de Vries * gcc.dg/pr83844.c: Require effective target alloca. --- gcc/testsuite/gcc.dg/pr83844.c | 1 + 1

[testsuite, committed] Require global_constructor in gcc.dg/torture/pr83055.c

2018-02-07 Thread Tom de Vries
Hi, this patch requires effective target global_constructor in gcc.dg/torture/pr83055.c. Committed. Thanks, - Tom [testsuite] Require global_constructor in gcc.dg/torture/pr83055.c 2018-02-07 Tom de Vries * gcc.dg/torture/pr83055.c: Require effective target

RE: [PATCH][GCC][ARM] Silence ARM_ARCH redefinition warning and keep better track of architecturs already emitted.

2018-02-07 Thread Tamar Christina
The testcase seems to be failing on configurations where the default thumb version differs from the one it's setting it to, Causing a warning on TARGET_ARM_ARCH_ISA_THUMB. I will submit a patch soon to undefine all relevant built-ins using builtin_define_with_int_value before setting them

[openacc, committed] Fix diff_type in expand_oacc_collapse_init

2018-02-07 Thread Tom de Vries
Hi, this patch fixes an 8 regression in an openacc testcase. The regression was introduced by r250925, a fix for PR78266, a bug in the handling of a loop with iteration variable type range smaller than the size of the parallel dimension the loop is assigned to. The fix for the regression is

Re: [PATCH] Fix floating point handling in dom (PR tree-optimization/84235)

2018-02-07 Thread Richard Biener
On Wed, 7 Feb 2018, Jakub Jelinek wrote: > On Wed, Feb 07, 2018 at 08:06:53AM +0100, Richard Biener wrote: > > >Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > > > OK. > > Committed, thanks. > > > I wonder why we have to re-implement all this in DOM. there's enough

Re: [PATCH] Small -ftrapv improvement

2018-02-07 Thread Richard Biener
On Tue, 6 Feb 2018, Jakub Jelinek wrote: > Hi! > > As mentioned on IRC, operation_could_trap_helper_p returns true > for division or modulo with -ftrapv; the operations could trap in certain > cases (e.g. division by -1 of minimum signed value, but we don't have any > library functions for

[PATCH] Fix PRs 84204, 84205 and 84223

2018-02-07 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-02-07 Richard Biener PR tree-optimization/84204 * tree-chrec.c (chrec_fold_plus_1): Remove size limiting in this place. * gcc.dg/graphite/pr84204.c: New

[PATCH,avr] Fix PR84209 code issue due to post-reload split of SP into 2 QI regs

2018-02-07 Thread Denis Chertykov
Committed. 2018-01-09 Georg-Johann Lay PR target/84209 * config/avr/avr.h (GENERAL_REGNO_P, GENERAL_REG_P): New macros. * config/avr/avr.md: Only post-reload split REG-REG moves if either register is REGERAL_REG_P. --- config/avr/avr.h (revision

Patch ping

2018-02-07 Thread Jakub Jelinek
Hi! I'd like to ping 2 patches: PR83659 cxx_fold_indirect_ref ICE fix http://gcc.gnu.org/ml/gcc-patches/2018-01/msg02211.html PR83708 __VA_OPT__ assorted fixes http://gcc.gnu.org/ml/gcc-patches/2018-01/msg00727.html Jakub

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-07 Thread Jakub Jelinek
On Tue, Feb 06, 2018 at 11:14:08AM +, Tsimbalist, Igor V wrote: > Coincidentally, I have worked on the same patch. Please look at the patch, I > uploaded it to the bug. The main differences are > > - updated the output messages to be more informative; > - updated the tests and add couple of

Re: [PATCH] Use -fcf-protection=return in cet-intrin-4.c

2018-02-07 Thread Uros Bizjak
On Tue, Feb 6, 2018 at 10:14 PM, Tsimbalist, Igor V wrote: >> -Original Message- >> From: Lu, Hongjiu >> Sent: Tuesday, February 6, 2018 10:03 PM >> To: gcc-patches@gcc.gnu.org >> Cc: Uros Bizjak ; Tsimbalist, Igor V >>

Re: [PATCH] i386: Mask out the CF_SET bit for -fcf-protection check

2018-02-07 Thread Uros Bizjak
On Tue, Feb 6, 2018 at 10:20 PM, Tsimbalist, Igor V wrote: >> -Original Message- >> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- >> ow...@gcc.gnu.org] On Behalf Of H.J. Lu >> Sent: Tuesday, February 6, 2018 10:09 PM >> To: gcc-patches@gcc.gnu.org

Re: [PATCH] Fix floating point handling in dom (PR tree-optimization/84235)

2018-02-07 Thread Jakub Jelinek
On Wed, Feb 07, 2018 at 08:06:53AM +0100, Richard Biener wrote: > >Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > OK. Committed, thanks. > I wonder why we have to re-implement all this in DOM. there's enough of > match and simplify interfaces to make it use that? It

Re: [PATCH] PR fortran/82049 -- resolve a charlen if possible

2018-02-07 Thread Paul Richard Thomas
Hi Steve, That's OK for trunk and, if you are possessed of the intestinal fortitude, 6- and 7-branches. Thanks Paul On 7 February 2018 at 02:17, Steve Kargl wrote: > The attached patch fixes PR fortran/82049. Prior to this > patch, gfortran was fouling up