Re: [PATCH] PR fortran/84346 -- Keywords invalid in statement functions

2018-02-22 Thread Thomas Koenig
Hi Steve, The attached patch fixes PR fortran/84346. A statement function always has an implicit interface. The use of keywords in a function with an implicit interface is invalid. Regression tested on x86_64-*-freebsd. OK to commit? OK. Thanks for the patch! Regards Thomas

[PATCH] Fix bogus function cast warning for functions with common arg subset

2018-02-22 Thread Siddhesh Poyarekar
Libraries like gtk/glib[1] and python[2] use functions with common argument subsets to register callbacks. The working idea behind it is to have a flag in the structure (or some other pre-determined method) that specifies how the callback is cast and called. Fix this by not throwing a warning

Re: [PATCH] correct -Wrestrict handling of arrays of arrays (PR 84095)

2018-02-22 Thread Siddhesh Poyarekar
On Friday 02 February 2018 05:15 AM, Martin Sebor wrote: > PR middle-end/84095 - false-positive -Wrestrict warnings for memcpy within > array > > gcc/ChangeLog: > > PR middle-end/84095 > * gimple-ssa-warn-restrict.c (builtin_memref::extend_offset_range): New. >

C++ PATCH for c++/84424, ICE with constexpr and __builtin_shuffle.

2018-02-22 Thread Jason Merrill
We were crashing when checking whether the value being created for v is constant, because TYPE_FIELDS is invalid for VECTOR_TYPE. But it's easy enough to just return false for a partially-initialized vector. Tested x86_64-pc-linux-gnu, applying to trunk. commit

[PATCH] PR fortran/84346 -- Keywords invalid in statement functions

2018-02-22 Thread Steve Kargl
The attached patch fixes PR fortran/84346. A statement function always has an implicit interface. The use of keywords in a function with an implicit interface is invalid. Regression tested on x86_64-*-freebsd. OK to commit? 2018-02-22 Steven G. Kargl PR

Re: [RFC PATCH] avoid applying attributes to explicit specializations (PR 83871)

2018-02-22 Thread Jason Merrill
On 02/21/2018 06:03 PM, Martin Sebor wrote: On 02/13/2018 11:33 AM, Jason Merrill wrote: On Tue, Feb 13, 2018 at 1:00 PM, Martin Sebor wrote: On 02/13/2018 07:47 AM, Jason Merrill wrote: On Mon, Feb 12, 2018 at 6:39 PM, Martin Sebor wrote: I really

patch to fix PR81572

2018-02-22 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81572 The patch was successfully bootstrapped and tested on ppc64. Committed as rev. 257915. Index: ChangeLog === --- ChangeLog (revision 257901) +++

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-22 Thread Joseph Myers
On Thu, 22 Feb 2018, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00858.html > > This is just a tweak to fix a translation bug introduced by > one of my warnings (calling warning() where warning_n() is > more appropriate), and to enhance warning_n() et al. to do >

Re: [PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-22 Thread Steve Kargl
On Thu, Feb 22, 2018 at 09:42:02PM +0200, Janne Blomqvist wrote: > Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP > statements, in order to suppress the printing of signaling FP > exceptions and the stop code. This patch adds the necessary library > changes, but for now the

[PATCH] PR fortran/84511 -- Fix C_LOC in a transfer statement

2018-02-22 Thread Steve Kargl
All, The attached patch handles C_LOC in a transfer statement such as "print *, c_loc(xxx)". The bug report contains two files that must be compiled separately to exhibit the bug. I have no idea how to write a testcase for this situation. If someone can write a testcase, I'm fine with that.

libgo patch committed: Add 64-bit RISC-V support

2018-02-22 Thread Ian Lance Taylor
This patch by Andreas Schwab adds 64-bit RISC-V support to libgo. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian 2018-02-22 Andreas Schwab * go.test/go-test.exp (go-set-goarch): Recognize riscv64-*-*. Index:

[PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-22 Thread Janne Blomqvist
Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP statements, in order to suppress the printing of signaling FP exceptions and the stop code. This patch adds the necessary library changes, but for now the new specifier is not parsed and the frontend unconditionally adds a false

Re: [PATCH] Tweak gcc.target/i386/avx2-vp{add,sub}q-3.c (PR target/82851)

2018-02-22 Thread Uros Bizjak
On Thu, Feb 22, 2018 at 7:16 PM, Jakub Jelinek wrote: > Hi! > > These tests FAIL the vp.*q.*ymm insn scan with some tunings, e.g. > -mtune=silvermont or -mtune=atom, because vectorizing it using AVX2 > is based on costs considered too expensive. > E.g. for -mtune=silvermont I

libgo patch committed: Get missing function name from symbol table in funcfileline

2018-02-22 Thread Ian Lance Taylor
This patch to libgo changes funcfileline to get missing a function name from the symbol table if possible. This copies the idea of https://golang.org/cl/92756 to funcfileline, which is used by runtime.FuncForPC, runtime.(*Frames).Next, and others. Bootstrapped and ran Go testsuite on

libgo patch committed: Add -L option for libatomic when using -pthread

2018-02-22 Thread Ian Lance Taylor
This patch to libgo adds a -L option for libatomic when using -pthread. This fixes configure checks for riscv, for which -pthread implies -latomic. This fixes GCC PR 84484. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

[PATCH] Tweak gcc.target/i386/avx2-vp{add,sub}q-3.c (PR target/82851)

2018-02-22 Thread Jakub Jelinek
Hi! These tests FAIL the vp.*q.*ymm insn scan with some tunings, e.g. -mtune=silvermont or -mtune=atom, because vectorizing it using AVX2 is based on costs considered too expensive. E.g. for -mtune=silvermont I see for VF 4: avx2-vpop-check.h:16:3: note: Cost model analysis: Vector inside of

Re: [PATCH v2] RISC-V: Support for FreeBSD

2018-02-22 Thread Jim Wilson
On Wed, Feb 21, 2018 at 10:34 PM, Kito Cheng wrote: > I don't family with copyright matters, so we can't commit this patch yet > until Ruslan send the signed copy and FSF signed it? right? Yes, I'd prefer that the FSF sign it and add it to the copyright list before we

Re: [PATCH rs6000], Move Power 8 tests, fix ICE for vec_unsigned2, vec_signed2

2018-02-22 Thread Segher Boessenkool
Hi! On Wed, Feb 21, 2018 at 11:10:25AM -0800, Carl Love wrote: > Per discussions with Segher, we felt it would be best to move the > vec_float2 test to a Power 8 test as it is only defined for Power 8 and > beyond. In doing this, I found that compiling builtins-3-runnable.c > with -mcpu=power7

Re: [PATCH, rs6000] tighten target statements for a p8 and p9 specific tests

2018-02-22 Thread Segher Boessenkool
On Wed, Feb 21, 2018 at 11:33:31AM -0600, Will Schmidt wrote: > Update the dg-requires statements for these tests to specify the target. > These tests may otherwise fail on a system missing p9 assembler support. > (Seen in a p6 environment). > > OK for trunk? Okay, thanks! Segher >

Re: [PATCH, rs6000] Update altivec-7 testcase(s).

2018-02-22 Thread Segher Boessenkool
Hi Will, On Wed, Feb 21, 2018 at 11:33:14AM -0600, Will Schmidt wrote: > This patch moves the vsx related content from the altivec-7-be test into > a new vsx-7-be test. > This fixes up some test failures as seen on older power systems. > --- /dev/null > +++

Re: [PATCH, rs6000] fold-vec-mult* testcase updates for power9

2018-02-22 Thread Segher Boessenkool
Hi! On Wed, Feb 21, 2018 at 11:32:36AM -0600, Will Schmidt wrote: > An update for the fold-vec-mult-int128-p9.c test to include more of > the instructions generated for a vec_mul() with a power9 target. > > [testsuite] > > 2018-02-21 Will Schmidt > >

Re: [PATCH] avoid bogus -Wstringop-truncation when inlining (PR 84480)

2018-02-22 Thread Martin Sebor
On 02/21/2018 07:53 PM, Jeff Law wrote: On 02/21/2018 02:19 PM, Martin Sebor wrote: The attached patch eliminates -Wstringop-truncation false positives reported in bug 84480 - bogus -Wstringop-truncation despite assignment with an inlined string literal. It does that by delegating early

[PATCH] Correct debug for -mcall-ms2sysv-xlogues stubs (PR target/83917, take 2)

2018-02-22 Thread Jakub Jelinek
Hi! On Sat, Jan 20, 2018 at 06:01:16PM -0600, Daniel Santos wrote: > Thanks.  I like the idea of commonizing the macros for consistency. Didn't see a progress on this P3 for a while, so I've written this version of the patch; no tests though, what I've been using in testing was: /* { dg-do

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread H.J. Lu
On Thu, Feb 22, 2018 at 9:10 AM, Jeff Law wrote: > On 02/22/2018 07:38 AM, Jan Hubicka wrote: > > Hi Jan, > > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg02233.html > > Is OK for trunk? I see that using register makes the problem go away and

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread Jeff Law
On 02/22/2018 07:38 AM, Jan Hubicka wrote: Hi Jan, https://gcc.gnu.org/ml/gcc-patches/2018-01/msg02233.html Is OK for trunk? >>> >>> I see that using register makes the problem go away and pushing address to >>> stack >>> seemed bit odd anyway. However how does this

Re: [PATCH] RX TARGET_RTX_COSTS function

2018-02-22 Thread Oleg Endo
On Thu, 2018-02-22 at 15:41 +, Nick Clifton wrote: > > > gcc/ChangeLog: > > > * config/rx/rx.c (rx_rtx_costs): New function. > > > (TARGET_RTX_COSTS): Override to use rx_rtx_costs. > Approved - please apply. > Thanks.  Committed as r257905. Cheers, Oleg

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread H.J. Lu
On Thu, Feb 22, 2018 at 6:38 AM, Jan Hubicka wrote: >> >> >> >> Hi Jan, >> >> >> >> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg02233.html >> >> >> >> Is OK for trunk? >> > >> > I see that using register makes the problem go away and pushing address to >> > stack >> > seemed

RE: [PATCH] RX TARGET_RTX_COSTS function

2018-02-22 Thread Sebastian Perta
Hi Oleg, Sorry, for some reason your emails did not ended up in Inbox, I was quite surprized when Nick's email started with Hi Oleg. >>Do you happen to have any other numbers on the resulting code >>size/speed? The original patch from DJ was present in my local sources since 4.7 so all the

Re: [PATCH] adjust warning_n() to take uhwi (PR 84207)

2018-02-22 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00858.html This is just a tweak to fix a translation bug introduced by one of my warnings (calling warning() where warning_n() is more appropriate), and to enhance warning_n() et al. to do the n % 100 + 100 computation so callers don't

[PATCH] PR 78534, 84509 Fix libgfortran API for PAUSE statement

2018-02-22 Thread Janne Blomqvist
This patch changes the libgfortran API for the PAUSE statement. By passing a GFC_INTEGER_8 it handles -fdefault-integer-8, and for the character version passing the length as a size_t. Regtested on x86_64-pc-linux-gnu, committed as obvious. gcc/fortran/ChangeLog: 2018-02-22 Janne Blomqvist

Re: [PATCH, GCC/ARM] Multilib mapping for Armv8-R

2018-02-22 Thread Kyrill Tkachov
Hi Thomas, On 16/02/18 10:30, Thomas Preudhomme wrote: Hi Kyrill, Thanks for the review. Here's my second attempt. I've fixed the typo you raised and added some tests (wasn't aware of those). I've also reworked the mapping somewhat, it's explain in the description below. Due to there being

[PATCH,AIX] Fixincludes for vec_malloc, vec_calloc

2018-02-22 Thread David Edelsohn
AIX stdlib.h header decides to redefine malloc and calloc when __VEC__ is defined. Hilarity ensues, such as when GCC uses __attribute__(("malloc")). Fixed with the appended fixincludes patch. Thanks, David * inclhack.def (aix_stdlib_vec_malloc): New. (aix_stdlib_vec_calloc): New. * fixincl.x:

Re: [PATCH] RX TARGET_RTX_COSTS function

2018-02-22 Thread Nick Clifton
Hi Oleg, > Ping. Sorry - I am not very good at spotting RX bugs on the gcc-patches list. :-( >> gcc/ChangeLog: >> * config/rx/rx.c (rx_rtx_costs): New function. >> (TARGET_RTX_COSTS): Override to use rx_rtx_costs. Approved - please apply. Cheers Nick

[PATCH, rs6000] Tests for builtin vec_neg updated

2018-02-22 Thread Carl Love
GCC maintainers: The following patch updates the various vec_neg tests to only run on Power 8 and beyond. The vec_neg builtin is only supported for Power 8 and beyond, as corrected in commit 257812. The fold-vec-neg-{char | floatdouble | short].c test cases did not get updated to only run on

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

2018-02-22 Thread Szabolcs Nagy
On 21/02/18 10:11, Alexandre Oliva wrote: On Feb 15, 2018, Szabolcs Nagy wrote: i see assembler slow downs with these location view patches i opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84408 [LVU] reset view at function entry, omit views at line zero

Re: [PATCH PR81228][AARCH64][gcc-7] Backport r255625 : Fix ICE by adding LTGT

2018-02-22 Thread Sudakshina Das
On 09/01/18 15:37, Sudakshina Das wrote: Hi This patch is only adding the missing LTGT to plug the ICE. This is a backport to r255625 of trunk. Testing done: Checked for regressions on bootstrapped aarch64-none-linux-gnu and added a new compile time test case that gives out LTGT to make

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread Jan Hubicka
> >> > >> Hi Jan, > >> > >> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg02233.html > >> > >> Is OK for trunk? > > > > I see that using register makes the problem go away and pushing address to > > stack > > seemed bit odd anyway. However how does this work on other types of thunk? > > Kernel

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread H.J. Lu
On Thu, Feb 22, 2018 at 6:29 AM, Jan Hubicka wrote: >> On Sun, Jan 28, 2018 at 11:56 AM, H.J. Lu wrote: >> > On Sat, Jan 27, 2018 at 2:12 PM, H.J. Lu wrote: >> >> For >> >> >> >> --- >> >> struct C { >> >> virtual ~C(); >> >>

Re: PING: [PATCH] i386: Add TARGET_INDIRECT_BRANCH_REGISTER

2018-02-22 Thread Jan Hubicka
> On Sun, Jan 28, 2018 at 11:56 AM, H.J. Lu wrote: > > On Sat, Jan 27, 2018 at 2:12 PM, H.J. Lu wrote: > >> For > >> > >> --- > >> struct C { > >> virtual ~C(); > >> virtual void f(); > >> }; > >> > >> void > >> f (C *p) > >> { > >> p->f(); > >>

Re: PING: [PATCH] i386: Add __x86_indirect_thunk_nt_reg for -fcf-protection -mcet

2018-02-22 Thread Jan Hubicka
> On Fri, Feb 2, 2018 at 8:54 AM, H.J. Lu wrote: > > nocf_check attribute can be used with -fcf-protection -mcet to disable > > control-flow check by adding NOTRACK prefix before indirect branch. > > When -mindirect-branch=thunk-extern -mindirect-branch-register is added, >

[committed] Add testcase for already fixed PR (PR c++/84496)

2018-02-22 Thread Jakub Jelinek
Hi! ICE on this testcase has been introduced in r236615 and got fixed on the trunk with r253600. I've committed the testcase to trunk, so that we don't regress in it as obvious. 2018-02-22 Jakub Jelinek PR c++/84496 * g++.dg/cpp1y/pr84496.C: New test. ---

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-22 Thread Martin Liška
On 02/22/2018 11:59 AM, Kyrill Tkachov wrote: > Hi Martin, > > On 22/02/18 08:51, Martin Liška wrote: >> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: >>> On arm we also support "native" as a value for -mcpu and -mtune. These are >>> both handled by >>> the arm_print_hint_for_cpu_option function

Re: [PATCH] RX TARGET_RTX_COSTS function

2018-02-22 Thread Oleg Endo
Ping. On Thu, 2018-02-15 at 23:07 +0900, Oleg Endo wrote: > On Wed, 2018-02-14 at 01:06 +0900, Oleg Endo wrote: > > > >   > > Do you happen to have any other numbers on the resulting code > > size/speed?  Looking at the new costs that the patch introduces, > > I'd > > expect there to be some

[parloops, PR83126], Use cached affine_ivs canonicalize_loop_ivs

2018-02-22 Thread Tom de Vries
Hi, this patch fixes an ICE in the parloops pass. The ICE (when compiling the test-case in attached patch) follows from the fact that here in gen_parallel_loop the call to canonicalize_loop_ivs fails to "base all the induction variables in LOOP on a single control one": ... /* Base all

[PATCH][AArch64] PR84114: Avoid reassociating FMA

2018-02-22 Thread Wilco Dijkstra
As discussed in the PR, the reassociation phase runs before FMAs are formed and so can significantly reduce FMA opportunities. Although reassociation could be switched off, it helps in many cases, so a better alternative is to only avoid reassociation of floating point additions. This fixes the

Re: plugin-api.h patch to add a new interface for linker plugins

2018-02-22 Thread Nick Clifton
Hi Cary, Hi Sriraman, >> Ping. Is this alright to apply now or should I wait for Stage 1? >> >> * plugin-api.h (ld_plugin_get_wrap_symbols): New >> plugin interface. > > I'd say go ahead and apply the patch in binutils, and wait for Stage 1 > to sync back to GCC, unless someone there OKs it

[og7] Fix hang when running oacc exec with CUDA 9.0 nvprof

2018-02-22 Thread Tom de Vries
Hi, when using cuda 9 nvprof with an openacc executable, the executable hangs. The scenario resulting in the hang is as follows: 1. goacc_lazy_initialize calls gomp_mutex_lock (_device_lock) 2. goacc_lazy_initialize calls acc_init_1 3. acc_init_1 calls goacc_profiling_dispatch (_info,

[testsuite] Require et alloca for pr82210.c

2018-02-22 Thread Tom de Vries
Hi, this patch requires effective target alloca in testcase pr82210.c. Committed. Thanks, - Tom [testsuite] Require et alloca for pr82210.c 2018-02-22 Tom de Vries * gcc.c-torture/execute/pr82210.c: Require effective target alloca. ---

Re: [PATCH][committed] Fix ICE in maybe_record_trace_start

2018-02-22 Thread Tom de Vries
On 02/12/2018 07:32 PM, Jeff Law wrote: diff --git a/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c new file mode 100644 index 000..0ca0b9f034b --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c @@ -0,0

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-22 Thread Kyrill Tkachov
Hi Martin, On 22/02/18 08:51, Martin Liška wrote: On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet to them as

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-22 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 11:46 AM, Janne Blomqvist wrote: > On Thu, Feb 22, 2018 at 2:36 AM, Damian Rouson > wrote: >> Hi Janne, >> >> To be more specific, the new OpenCoarrays test failures after applying the >> patch are the following

[PATCH] Fix store merging (PR tree-optimization/84503)

2018-02-22 Thread Jakub Jelinek
Hi! The long comment above the new check_no_overlap function below should hopefully explain the problem. coalesce_immediate_stores is splitting the stores from the same base into groups that we are going to optimize individually; for each successfully merged group we emit new stores at the

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-22 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 2:36 AM, Damian Rouson wrote: > Hi Janne, > > To be more specific, the new OpenCoarrays test failures after applying the > patch are the following ones: > > image_fail_test_1 (Timeout) > image_fail_and_sync_test_2 (Timeout) >

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

2018-02-22 Thread Martin Liška
On 02/21/2018 10:23 AM, Kyrill Tkachov wrote: > > On arm we also support "native" as a value for -mcpu and -mtune. These are  > both handled by > the arm_print_hint_for_cpu_option function in the same file. Can you please  > add this snippet > to them as well? Hi. Can you please test for me