[C++ PATCH] PR c++/79133

2018-07-06 Thread Ville Voutilainen
Tested on Linux-PPC64. Ok for trunk, perhaps with the change that I move the test under cpp1y, since it's a c++14 test anyway? I considered pushing the captures into the parameter scope. I don't know how to do that; changing the pushdecl_outermost_localscope to a pushdecl doesn't seem to cut it;

Re: [PATCH] [ARC] Add support for HS4x cpus.

2018-07-06 Thread Andrew Burgess
* Claudiu Zissulescu [2018-06-13 12:09:18 +0300]: > From: Claudiu Zissulescu > > This patch adds support for two ARCHS variations. > > Ok to apply? > Claudiu Sorry for the delay, this looks fine. Thanks, Andrew > > gcc/ > 2017-03-10 Claudiu Zissulescu > > *

Re: [PING][PATCH, rs6000, C/C++] Fix PR target/86324: divkc3-1.c FAILs when compiling with -mabi=ieeelongdouble

2018-07-06 Thread Peter Bergner
On 7/5/18 2:36 PM, Jeff Law wrote: > On 07/02/2018 03:50 PM, Peter Bergner wrote: >> I'd like to PING: >> >> https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01713.html >> >> I've included the entire patch below, since I missed the test cases in >> the original submission and Segher asked for some

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Jim Wilson
On Fri, Jul 6, 2018 at 12:16 AM, Arnaud Charlet wrote: >> Ada is a low priority side project for me, so if you want non-trivial changes >> it may be a while before I can get to them. There is a lot of other stuff >> higher on my priority list at the moment, such as getting native gdb support >>

Re: [PATCH, Ada] Makefile patches from initial RISC-V cross/native build.

2018-07-06 Thread Jim Wilson
On Fri, Jul 6, 2018 at 12:18 AM, Arnaud Charlet wrote: >> These are some patches I needed to complete my cross build of a native >> riscv linux Ada compiler. Some paths were different on the build machine >> and host machine. I needed to pass options into gnatmake to work around >> this, >>

Re: [PATCH] doc clarification: DONE and FAIL in define_split and define_peephole2

2018-07-06 Thread Paul Koning
> On Jul 6, 2018, at 12:20 PM, Richard Sandiford > wrote: > > Double empty line. > > OK otherwise, thanks. (Think this counts as a gen* patch.) > > Richard Thanks. Committed as shown below. paul ChangeLog: 2018-07-06 Paul Koning * doc/md.texi (define_split):

Re: [PATCH] doc clarification: DONE and FAIL in define_split and define_peephole2

2018-07-06 Thread Jeff Law
On 07/06/2018 10:20 AM, Richard Sandiford wrote: > Paul Koning writes: >> @@ -8615,6 +8639,34 @@ so here's a silly made-up example: >>"") >> @end smallexample >> >> +There are two special macros defined for use in the preparation statements: >> +@code{DONE} and @code{FAIL}. Use them with

Re: [PATCH] doc clarification: DONE and FAIL in define_split and define_peephole2

2018-07-06 Thread Richard Sandiford
Paul Koning writes: > @@ -8615,6 +8639,34 @@ so here's a silly made-up example: >"") > @end smallexample > > +There are two special macros defined for use in the preparation statements: > +@code{DONE} and @code{FAIL}. Use them with a following semicolon, > +as a statement. > + > +@table

Re: [PATCH] fold strlen() of aggregate members (PR 77357)

2018-07-06 Thread Richard Biener
On Fri, Jul 6, 2018 at 1:54 AM Martin Sebor wrote: > > GCC folds accesses to members of constant aggregates except > for character arrays/strings. For example, the strlen() call > below is not folded: > >const char a[][4] = { "1", "12" }; > >int f (void) { retturn strlen (a[1]); } > >

Re: [PATCH] Fix sigsegv on -fdump-tree-all-enumerate_locals

2018-07-06 Thread Jeff Law
On 07/06/2018 08:41 AM, Richard Biener wrote: > On Fri, Jul 6, 2018 at 3:30 PM Tom de Vries wrote: >> >> Hi, >> >> this patch fixes a sigsegv when using -fdump-tree-all-enumerate_locals, by >> handling cfun->cfg == NULL conservatively in dump_enumerated_decls. >> >> OK for trunk? > > Ok for the

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Tulio Magno Quites Machado Filho
Michael Meissner writes: > On Fri, Jul 06, 2018 at 10:16:34AM -0300, Tulio Magno Quites Machado Filho > wrote: >> I suggest to test with the following program: >> >> #include >> >> int >> main () >> { >> return !isinfl(__builtin_infl()); >> } >> >> Build it with: >> gcc

Re: calculate overflow type in wide int arithmetic

2018-07-06 Thread Richard Biener
On Fri, Jul 6, 2018 at 9:50 AM Aldy Hernandez wrote: > > > > On 07/05/2018 05:50 AM, Richard Biener wrote: > > On Thu, Jul 5, 2018 at 9:35 AM Aldy Hernandez wrote: > >> > >> The reason for this patch are the changes showcased in tree-vrp.c. > >> Basically I'd like to discourage rolling our own

Re: [PATCH] doc clarification: DONE and FAIL in define_split and define_peephole2

2018-07-06 Thread Paul Koning
Thanks Richard. Some comments, and an updated proposed patch. paul > On Jul 6, 2018, at 9:04 AM, Richard Sandiford > wrote: > > ... >> @@ -8232,6 +8256,15 @@ functionality as two separate @code{define_insn} a >> patterns. It exists for compactness, and as a maintenance tool to

Re: [PATCH] Fix sigsegv on -fdump-tree-all-enumerate_locals

2018-07-06 Thread Richard Biener
On Fri, Jul 6, 2018 at 3:30 PM Tom de Vries wrote: > > Hi, > > this patch fixes a sigsegv when using -fdump-tree-all-enumerate_locals, by > handling cfun->cfg == NULL conservatively in dump_enumerated_decls. > > OK for trunk? Ok for the tree-dfa.c part. Richard. > Thanks, > - Tom > > Fix

Re: [PATCH][debug] Handle references to skipped params in remap_ssa_name

2018-07-06 Thread Richard Biener
On Fri, Jul 6, 2018 at 12:47 PM Tom de Vries wrote: > > On 07/05/2018 01:39 PM, Richard Biener wrote: > > On Thu, Jul 5, 2018 at 1:25 PM Tom de Vries wrote: > >> > >> [ was: Re: [testsuite/guality, committed] Prevent optimization of local in > >> vla-1.c ] > >> > >> On Wed, Jul 04, 2018 at

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Segher Boessenkool
On Fri, Jul 06, 2018 at 09:46:36AM -0400, Michael Meissner wrote: > On Fri, Jul 06, 2018 at 10:16:34AM -0300, Tulio Magno Quites Machado Filho > wrote: > > I suggest to test with the following program: > > > > #include > > > > int > > main () > > { > > return !isinfl(__builtin_infl()); > > }

[PATCH] PR libstdc++/84928 use std::move in algorithms

2018-07-06 Thread Jonathan Wakely
P0616R0 altered the effects of the algorithms to use std::move on the accumulator values (resolving LWG 2055). This implements the change for C++2a, but retains the previous behaviour for older standards. * include/bits/stl_numeric.h (_GLIBCXX_MOVE_IF_20): Define macro to

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Segher Boessenkool
On Fri, Jul 06, 2018 at 09:38:02AM -0400, Michael Meissner wrote: > On Fri, Jul 06, 2018 at 06:38:55AM -0500, Segher Boessenkool wrote: > > On Fri, Jul 06, 2018 at 01:51:37AM -0400, Michael Meissner wrote: > > > case "$target:$with_long_double_format" in > > > > > - xpowerpc64*-*-linux*:*) > >

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Michael Meissner
On Fri, Jul 06, 2018 at 10:16:34AM -0300, Tulio Magno Quites Machado Filho wrote: > I suggest to test with the following program: > > #include > > int > main () > { > return !isinfl(__builtin_infl()); > } > > Build it with: > gcc -mabi=ieeelongdouble -fno-builtin -Wno-psabi -lm test-ldbl.c

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Michael Meissner
On Fri, Jul 06, 2018 at 06:38:55AM -0500, Segher Boessenkool wrote: > On Fri, Jul 06, 2018 at 01:51:37AM -0400, Michael Meissner wrote: > > case "$target:$with_long_double_format" in > > > - xpowerpc64*-*-linux*:*) > > So this case could never happen. The changelog should mention it fixes >

[PATCH] Fix sigsegv on -fdump-tree-all-enumerate_locals

2018-07-06 Thread Tom de Vries
Hi, this patch fixes a sigsegv when using -fdump-tree-all-enumerate_locals, by handling cfun->cfg == NULL conservatively in dump_enumerated_decls. OK for trunk? Thanks, - Tom Fix sigsegv on -fdump-tree-all-enumerate_locals 2018-07-06 Tom de Vries * tree-dfa.c

RE: [PATCH][GCC][ARM] Fix can_change_mode_class for big-endian

2018-07-06 Thread Tamar Christina
Hi Christoph, > 90d62e699bce9594879be2e3016c9b36c7e064c8..703632240822e762a90657096 > > >> 4b949c783df56f3 100644 > > >> --- a/gcc/config/arm/arm.c > > >> +++ b/gcc/config/arm/arm.c > > >> @@ -31508,8 +31508,8 @@ arm_can_change_mode_class > (machine_mode from, machine_mode to, > > >>{ > > >>

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Tulio Magno Quites Machado Filho
Michael Meissner writes: > This patch adds a simple check of whether the GLIBC should be capable of > switching the long double format on the PowerPC to IEEE 128-bit floating > point. > At the moment, library work is not yet finished, but I'm assuming that the > patches will be in place when

Re: [PATCH] doc clarification: DONE and FAIL in define_split and define_peephole2

2018-07-06 Thread Richard Sandiford
Paul Koning writes: > Currently DONE and FAIL are documented only for define_expand, but > they also work in essentially the same way for define_split and > define_peephole2. > > If FAIL is used in a define_insn_and_split, the output pattern cannot > be the usual "#" dummy value. > > This patch

[PATCH] Simplify linker script patterns for std::exception_ptr

2018-07-06 Thread Jonathan Wakely
* config/abi/pre/gnu.ver: Use wildcards to combine related patterns. Tested x86_64-linux and powerpc64le-linux, committed to trunk. commit 6ae49a85e8e83390225aae7dbbe01518005cf34f Author: Jonathan Wakely Date: Fri Jul 6 13:40:00 2018 +0100 Simplify linker script patterns for

[PATCH] P0935R0 Eradicating unnecessarily explicit default constructors

2018-07-06 Thread Jonathan Wakely
This is the last remaining piece of P0935R0. This adds a default constructor to each of the streambuf and stream types in so that default construction does not use the 'explicit' constructor that has a single, defaulted argument. P0935R0 Eradicating unnecessarily explicit default

Re: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Ramana Radhakrishnan
On Fri, Jul 6, 2018 at 1:13 PM, Tamar Christina wrote: >> >> >> >> So I am curious as to why this shows up in Christophe's test but not >> >> in any of your test runs or indeed the testruns with our scripts. >> >> > > The test was changed before sending out, the individual entries moved to > a

RE: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Tamar Christina
> >> > >> So I am curious as to why this shows up in Christophe's test but not > >> in any of your test runs or indeed the testruns with our scripts. > >> The test was changed before sending out, the individual entries moved to a macro. I then verified the code generation and did not rerun it

Re: [committed] [PR tree-optimization/86010] More aggressively trim partially dead mem* and str* calls

2018-07-06 Thread Christophe Lyon
Hi Jeff, On Fri, 6 Jul 2018 at 05:44, Jeff Law wrote: > > As noted in BZ 86010 we can be more aggressive when trimming tails of > mem* or str* calls in gimple DSE since trimming a tail doesn't affect > alignment and residuals are usually handled pretty efficiently in libc. > > Additionally, if

Re: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Ramana Radhakrishnan
On Fri, Jul 6, 2018 at 1:04 PM, Christophe Lyon wrote: > On Fri, 6 Jul 2018 at 13:56, Ramana Radhakrishnan > wrote: >> >> On Fri, Jul 6, 2018 at 10:16 AM, Tamar Christina >> wrote: >> > Hi All, >> > >> > This fixes a -Wpedantic error with the testcase because of extra ; left >> > after the >>

Re: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Christophe Lyon
On Fri, 6 Jul 2018 at 13:56, Ramana Radhakrishnan wrote: > > On Fri, Jul 6, 2018 at 10:16 AM, Tamar Christina > wrote: > > Hi All, > > > > This fixes a -Wpedantic error with the testcase because of extra ; left > > after the > > functions. > > > > Regtested single test on aarch64-none-elf and

Re: [committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Ramana Radhakrishnan
On Fri, Jul 6, 2018 at 10:16 AM, Tamar Christina wrote: > Hi All, > > This fixes a -Wpedantic error with the testcase because of extra ; left after > the > functions. > > Regtested single test on aarch64-none-elf and no issues. > > Committed under the GCC obvious rule. So I am curious as to

Re: [PATCH], Add configuration checks to PowerPC --with-long-double-format=ieee

2018-07-06 Thread Segher Boessenkool
On Fri, Jul 06, 2018 at 01:51:37AM -0400, Michael Meissner wrote: > case "$target:$with_long_double_format" in > - xpowerpc64*-*-linux*:*) So this case could never happen. The changelog should mention it fixes that bug (and having it as a separate patch is much preferred!) Other than this

Re: [PATCH] Fix several AVX512 intrinsic mask arguments.

2018-07-06 Thread Jakub Jelinek
On Thu, Jul 05, 2018 at 11:57:26PM +0300, Grazvydas Ignotas wrote: > I think it would be more efficient if you took care of it. I won't > have time for at least a few days anyway. Here is what I have ATM, but will still need to work on the testsuite side for it and bootstrap/regtest it. In

Re: [PATCH][debug] Handle references to skipped params in remap_ssa_name

2018-07-06 Thread Tom de Vries
On 07/05/2018 01:39 PM, Richard Biener wrote: > On Thu, Jul 5, 2018 at 1:25 PM Tom de Vries wrote: >> >> [ was: Re: [testsuite/guality, committed] Prevent optimization of local in >> vla-1.c ] >> >> On Wed, Jul 04, 2018 at 02:32:27PM +0200, Tom de Vries wrote: >>> On 07/03/2018 11:05 AM, Tom de

[committed][gcc][patch] Require sse for testcase on i686.

2018-07-06 Thread Tamar Christina
Hi All, This fixes an ABI warning generated on i686-pc-linux-gnu when using `vector_size` with no sse enabled explicitly. Regtested single test on x86_64-pc-linux-gnu with -m32 and no issues. Committed under the GCC obvious rule. Thanks, Tamar gcc/testsuite/ 2018-07-06 Tamar Christina

Re: [PATCH][debug] Handle references to skipped params in remap_ssa_name

2018-07-06 Thread Richard Biener
On Thu, Jul 5, 2018 at 4:12 PM Tom de Vries wrote: > > On 07/05/2018 01:39 PM, Richard Biener wrote: > > On Thu, Jul 5, 2018 at 1:25 PM Tom de Vries wrote: > >> > >> [ was: Re: [testsuite/guality, committed] Prevent optimization of local in > >> vla-1.c ] > >> > >> On Wed, Jul 04, 2018 at

[PATCH] include/std/variant (__accepted_index): Use void_t.

2018-07-06 Thread Jonathan Wakely
Tested powerpc64le-linux, committed to trunk. commit d66ad3c7feea986bfb95543e07b7063931d97e96 Author: Jonathan Wakely Date: Fri Jul 6 09:58:12 2018 +0100 * include/std/variant (__accepted_index): Use void_t. diff --git a/libstdc++-v3/include/std/variant

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-07-06 Thread Richard Biener
On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah wrote: > > Hi Richard, > > > It was rewrite_to_non_trapping_overflow available in tree.h. Thus > > final value replacement > > could use that before gimplifying instead of using > > rewrite_to_defined_overflow > Thanks. > > Is the attached

[PATCH] Fix PR86413

2018-07-06 Thread Richard Biener
The following fixes FAIL: gcc.dg/guality/pr48437.c -O2 -flto -fno-use-linker-plugin -flto-partition=none line 14 i == 0 because we now prune non-local/VAR_DECLs from BLOCK trees during free-lang-data (after we emitted early dwarf). gen_block_die isn't prepared for that and now refuses to

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-07-06 Thread Kugan Vivekanandarajah
Hi Richard, > It was rewrite_to_non_trapping_overflow available in tree.h. Thus > final value replacement > could use that before gimplifying instead of using rewrite_to_defined_overflow Thanks. Is the attached patch OK? I am testing this on x86_64-linux-gnu and if there is no new regressions.

[committed][aarch64][gcc][patch] Fix -Wpedantic issue with testcase.

2018-07-06 Thread Tamar Christina
Hi All, This fixes a -Wpedantic error with the testcase because of extra ; left after the functions. Regtested single test on aarch64-none-elf and no issues. Committed under the GCC obvious rule. Thanks, Tamar gcc/testsuite/ 2018-07-06 Tamar Christina *

[PATCH] RISC-V: Report error if function declare with different

2018-07-06 Thread Kito Cheng
Hi all: This patch implemented TARGET_MERGE_DECL_ATTRIBUTES hook to check the interrupter is all compatible, tested with rv32ima and rv64ima elf toolchain. gcc/ChangeLog 2018-07-06 Kito Cheng * config/riscv/riscv.c (enum riscv_privilege_levels): Add UNKNOWN_MODE.

Re: [PATCH] Move ((A & N) + B) & M -> (A + B) & M etc. optimization from fold-const.c to match.pd (PR tree-optimization/86401)

2018-07-06 Thread Richard Biener
On Thu, 5 Jul 2018, Jakub Jelinek wrote: > Hi! > > I've encountered this while testing the rotate patterns in discussion > with Jonathan for the std::__rot{l,r}, in the rotate-9.c test without > this patch f1 is optimized into a rotate, but f2 is not. > > Fixed by moving the optimization from

Re: [PATCH][GCC][mid-end] Correct subreg no-op handling for big-endian vec_select.

2018-07-06 Thread Christophe Lyon
On Thu, 28 Jun 2018 at 05:11, Jeff Law wrote: > > On 06/19/2018 08:11 AM, Tamar Christina wrote: > > Hi All, > > > > Previously GCC's no-op detection could would consider something a no-op > > even when the > > mode change is not directly possible. This caused subregs that shouldn't > > be

Re: [PATCH][GCC][ARM] Fix can_change_mode_class for big-endian

2018-07-06 Thread Christophe Lyon
Hi Tamar, On Wed, 20 Jun 2018 at 15:35, Kyrill Tkachov wrote: > > > On 20/06/18 11:33, Tamar Christina wrote: > > Hi Kyrill, > > > > Many thanks for the review! > > > > The 06/20/2018 09:43, Kyrill Tkachov wrote: > >> Hi Tamar, > >> > >> On 19/06/18 15:14, Tamar Christina wrote: > >>> Hi All, >

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Eric Botcazou
> Ada doesn't use trampolines if you define... > > > + Always_Compatible_Rep : constant Boolean := False; > > ...this to False. And also define TARGET_CUSTOM_FUNCTION_DESCRIPTORS for the architecture. -- Eric Botcazou

Re: [PATCH][GCC][AArch64] Simplify movmem code by always doing overlapping copies when larger than 8 bytes.

2018-07-06 Thread Christophe Lyon
Hi Tamar, On Tue, 3 Jul 2018 at 19:13, James Greenhalgh wrote: > > On Tue, Jun 19, 2018 at 09:09:27AM -0500, Tamar Christina wrote: > > Hi All, > > > > OK. > > Thanks, > James > > > Thanks, > > Tamar > > > > gcc/ > > 2018-06-19 Tamar Christina > > > > * config/aarch64/aarch64.c

Re: calculate overflow type in wide int arithmetic

2018-07-06 Thread Aldy Hernandez
On 07/05/2018 05:50 AM, Richard Biener wrote: On Thu, Jul 5, 2018 at 9:35 AM Aldy Hernandez wrote: The reason for this patch are the changes showcased in tree-vrp.c. Basically I'd like to discourage rolling our own overflow and underflow calculation when doing wide int arithmetic. We

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Eric Botcazou
> The result is good enough to bootstrap natively and seems to give reasonable > native testsuite results for a first attempt. The machine I'm running on > has broken icache flushing, so trampolines won't work, and I suspect that > is causing a lot of the testsuite failures. Ada doesn't use

Re: [PATCH] C++: Fix PR86083

2018-07-06 Thread Andreas Krebbel
On 06/20/2018 01:41 PM, Andreas Krebbel wrote: > When turning a user-defined numerical literal into an operator > invocation the literal needs to be translated to the execution > character set. > > Bootstrapped and regtested on s390x. x86_64 still running. > Ok to apply if x86_64 is clean? > >

Re: [PATCH, Ada] Makefile patches from initial RISC-V cross/native build.

2018-07-06 Thread Arnaud Charlet
> These are some patches I needed to complete my cross build of a native > riscv linux Ada compiler. Some paths were different on the build machine > and host machine. I needed to pass options into gnatmake to work around this, > and that required fixing some makefile rules to use $(GNATMAKE)

Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port.

2018-07-06 Thread Arnaud Charlet
> Ada is a low priority side project for me, so if you want non-trivial changes > it may be a while before I can get to them. There is a lot of other stuff > higher on my priority list at the moment, such as getting native gdb support > working. If this isn't OK as is, then I'm willing to put

Re: [PATCH] Update config.guess and config.sub

2018-07-06 Thread Sebastian Huber
On 05/07/18 18:51, Palmer Dabbelt wrote: I'm not sure what the policy is on getting config stuff approved for commit, but just FYI there's another RISC-V related patch to config.sub that changes the behavior of "riscv-*" tuples.  I'm assuming we should take both, as it's odd to sync half way

Re: [PATCH 0/3][POPCOUNT]

2018-07-06 Thread Kugan Vivekanandarajah
Hi Jeff, Thanks for looking into it. On 6 July 2018 at 08:03, Jeff Law wrote: > On 06/24/2018 08:41 PM, Kugan Vivekanandarajah wrote: >> Hi Jeff, >> >> Thanks for the comments. >> >> On 23 June 2018 at 02:06, Jeff Law wrote: >>> On 06/22/2018 03:11 AM, Kugan Vivekanandarajah wrote: When