Re: [Darwin, testsuite, committed] Fix Wnonnull on Darwin.

2019-10-21 Thread Iain Sandoe
Iain Sandoe wrote: > Martin Sebor wrote: > >> On 10/20/2019 07:27 AM, Iain Sandoe wrote: >>> Martin Sebor wrote: On 10/19/19 2:56 AM, Iain Sandoe wrote: > Andreas Schwab wrote: >> On Okt 19 2019, Iain Sandoe wrote: >> >>> This test has failed always on Darwin, because

Re: RFA [PATCH] * lock-and-run.sh: Check for process existence rather than timeout.

2019-10-21 Thread Jason Merrill
On 10/21/19 7:12 PM, Alexandre Oliva wrote: On Oct 21, 2019, Jason Merrill wrote: On Sat, Oct 19, 2019 at 12:08 AM Alexandre Oliva wrote: We might also wish to use different lock-breaking logic for that case, too, e.g. checking that the timestamp of the dir didn't change by comparing `ls

Re: gcc-wwwdocs branch master updated. cdc7bf90357701877546f8bac160d0fb9e20b334

2019-10-21 Thread Joseph Myers
On Mon, 21 Oct 2019, Mike Stump wrote: > This isn't helpful. The advanced person already knows this and the > limitations of it, and the non-advanced people are confused by the lack > of certainty. So, the web page should not say it, and saying it here, > doesn't help much as well. Trying

Re: RFA [PATCH] * lock-and-run.sh: Check for process existence rather than timeout.

2019-10-21 Thread Alexandre Oliva
On Oct 21, 2019, Jason Merrill wrote: > On Sat, Oct 19, 2019 at 12:08 AM Alexandre Oliva wrote: >> We might also wish to use different lock-breaking logic for that case, >> too, e.g. checking that the timestamp of the dir didn't change by >> comparing `ls -ld $lockdir` with what we got 30

[PATCH] Fix incorrect merge of conflictant names in `dump_graphviz`

2019-10-21 Thread Giuliano Belinassi
Hi, When using lto-dump -callgraph with two or more .o files containing distinct functions with the same name, dump_graphviz incorrectly merged those functions into a single node. This patch fixes this issue by calling `dump_name` instead of `name`, therefore concat'ing the function name with

Re: [PATCH] Use narrow mode of constant when expanding widening multiplication

2019-10-21 Thread Jozef Lawrynowicz
On Mon, 21 Oct 2019 08:40:11 +0100 Richard Sandiford wrote: > Jozef Lawrynowicz writes: > > I experienced the following ICE when working on a downstream patch for > > msp430: > > > > void > > foo (unsigned int r, unsigned int y) > > { > > __builtin_umul_overflow ((unsigned int) (-1), y, ); >

Re: [PATCH] fix constrained auto parsing issue

2019-10-21 Thread Jason Merrill
On 10/21/19 4:40 PM, Andrew Sutton wrote: In cp_parser_simple_type_specifier: if (!type && flag_concepts && decl_specs) { /* Try for a type-constraint with template arguments. We check decl_specs here to avoid trying this for a functional cast. */ ... It's subtle. Aha.

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335)

2019-10-21 Thread Jason Merrill
On 10/21/19 2:49 PM, Jakub Jelinek wrote: On Mon, Oct 21, 2019 at 01:59:38PM -0400, Jason Merrill wrote: I agree that cp_fold isn't the right place, since it does lowering for GCC internals, and consteval expansion is part of the language semantics. So it should happen before constexpr body

Re: [PATCH] fix constrained auto parsing issue

2019-10-21 Thread Andrew Sutton
In cp_parser_simple_type_specifier: if (!type && flag_concepts && decl_specs) { /* Try for a type-constraint with template arguments. We check decl_specs here to avoid trying this for a functional cast. */ ... It's subtle. Andrew Sutton On Mon, Oct 21, 2019 at 2:22 PM Jason

Re: [PATCH][PR83534] C++17: typeinfo for noexcept function lacks noexcept information

2019-10-21 Thread Jason Merrill
On 10/4/19 8:17 AM, kamlesh kumar wrote: bootstrapped and regtested on x86_64. ChangeLog: 2019-10-04 Kamlesh Kumar * rtti.c (get_tinfo_decl_dynamic): Do not call TYPE_MAIN_VARIANT for function. (get_typeid): Likewise. * g++.dg/rtti/pr83534.C: New Test.

Re: [SVE] PR91272

2019-10-21 Thread Prathamesh Kulkarni
On Fri, 18 Oct 2019 at 14:36, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to fix PR91272. > > Does it look OK ? > > > > With patch, I see following failures for aarch64-sve.exp: > > FAIL: gcc.target/aarch64/sve/clastb_1.c -march=armv8.2-a+sve > >

Re: [PATCH 11/29] [arm] Reduce cost of insns that are simple reg-reg moves.

2019-10-21 Thread Segher Boessenkool
On Mon, Oct 21, 2019 at 04:46:47PM +0100, Richard Earnshaw (lists) wrote: > On 19/10/2019 17:17, Segher Boessenkool wrote: > >Maybe we should simply disallow pseudo-to-pseudo (or even all) copies when > >combining more than two insns, always? I'll experiment. > For the 2-insn case we don't try a

Re: Ping: [C][C++] Avoid exposing internal details in aka types

2019-10-21 Thread Jason Merrill
On 10/11/19 10:17 AM, Richard Sandiford wrote: Richard Sandiford writes: Marek Polacek writes: On Thu, Oct 10, 2019 at 08:00:53PM +0100, Richard Sandiford wrote: Ping Richard Sandiford writes: The current aka diagnostics can sometimes leak internal details that seem more likely to be

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335)

2019-10-21 Thread Jakub Jelinek
On Mon, Oct 21, 2019 at 01:59:38PM -0400, Jason Merrill wrote: > I agree that cp_fold isn't the right place, since it does lowering for GCC > internals, and consteval expansion is part of the language semantics. So it > should happen before constexpr body saving, as in your patch. > > It seems

Re: [C++] Don't fold __builtin_constant_p prematurely

2019-10-21 Thread Jason Merrill
OK, thanks. On 9/27/19 2:07 PM, Marc Glisse wrote: Ping https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00808.html with one more potential reviewer in Cc. On Wed, 11 Sep 2019, Marc Glisse wrote: Ping On Tue, 3 Sep 2019, Marc Glisse wrote: On Fri, 2 Aug 2019, Marc Glisse wrote: Ping On

Re: [C++ Patch] Improve cp_parser_class_head error recovery

2019-10-21 Thread Jason Merrill
On 10/18/19 11:35 AM, Paolo Carlini wrote: Hi, a few days ago I noticed that for, say, g++.dg/parse/qualified2.C we were issuing two additional misleading errors after the first one, mentioning in particular a certain "unnamed class" (I'm reproducing only the error messages proper):

Re: C++ PATCH for c++/92062 - ODR-use ignored for static member of class template

2019-10-21 Thread Jason Merrill
On 10/11/19 4:23 PM, Marek Polacek wrote: has_value_dependent_address wasn't stripping location wrappers so it gave the wrong answer for "" in the static_assert. That led us to thinking that the expression isn't instantiation-dependent, and we skipped static initialization of A<0>::x. This

Re: [PATCH] fix constrained auto parsing issue

2019-10-21 Thread Jason Merrill
On 10/17/19 10:36 AM, Andrew Sutton wrote: This fixes a parsing bug with constrained placeholders uses as the first parameter of a constructor. +Parse with an empty set of declaration specifiers since we're +trying to match a type-specifier of the first parameter. */

Re: [C++ PATCH] Fix handling of location wrappers in constexpr evaluation (PR c++/92015)

2019-10-21 Thread Jason Merrill
On 10/17/19 3:18 AM, Jakub Jelinek wrote: Hi! As written in the PR, location wrappers are stripped by cxx_eval_constant_expression as the first thing it does after dealing with jump_target. The problem is that when this function is called on a CONSTRUCTOR, is TREE_CONSTANT and

Re: [PATCH] diagnose hard errors in concept satisfaction

2019-10-21 Thread Jason Merrill
On 10/15/19 3:57 PM, Andrew Sutton wrote: Certain errors encountered during constraint satisfaction render the program ill-formed. Emit those as errors during satisfaction and not when diagnosing constraint errors. The errors should include the full context for failure (i.e., when satisfying X,

Re: C++ PATCH for c++/92106 - ICE with structured bindings and -Wreturn-local-addr

2019-10-21 Thread Jason Merrill
On 10/15/19 2:41 PM, Jakub Jelinek wrote: On Tue, Oct 15, 2019 at 02:28:12PM -0400, Marek Polacek wrote: --- /dev/null +++ gcc/testsuite/g++.dg/cpp1z/decomp50.C @@ -0,0 +1,51 @@ +// PR c++/92106 - ICE with structured bindings and -Wreturn-local-addr. +// { dg-do compile { target c++17 } } +

Re: [C++ PATCH] Implement P1073R3: Immediate functions (PR c++/88335)

2019-10-21 Thread Jason Merrill
On 10/15/19 1:04 PM, Jakub Jelinek wrote: Hi! The following patch implements P1073R3, i.e. consteval, except that virtual consteval is not supported (I think support for that would need to include the consteval virtual methods at the end of the binfo structures after all non-consteval virtual

[Patch, fortran] PR91926 - assumed rank optional

2019-10-21 Thread Paul Richard Thomas
Please find attached a patch to keep 9-branch up to speed with trunk as far as the ISO_Fortran_binding feature is concerned. It bootstraps and regtests on 9-branch and incorporates the correction for PR92027, which caused problems for trunk on certain platforms. OK to commit? Paul 2019-10-21

Re: RFA [PATCH] * lock-and-run.sh: Check for process existence rather than timeout.

2019-10-21 Thread Jason Merrill
On 10/21/19 11:35 AM, Jason Merrill wrote: On Sat, Oct 19, 2019 at 12:08 AM Alexandre Oliva > wrote: Hello, Jason, On Oct 14, 2019, Jason Merrill mailto:ja...@redhat.com>> wrote: > Alex, you had a lot of helpful comments when I first wrote this, any

Re: [PATCH 09/29] [arm] Correctly cost addition with a carry-in

2019-10-21 Thread Segher Boessenkool
On Mon, Oct 21, 2019 at 05:06:20PM +0100, Richard Earnshaw (lists) wrote: > On 21/10/2019 16:46, Segher Boessenkool wrote: > >>>There also is the insn_cost hook, which especially for RISC-like targets > >>>is a lot easier to define. > >> > >>Easier, but not a complete replacement for rtx_costs, so

Re: [PATCH, Fortran] Allow CHARACTER literals in assignments and DATA statements - for review

2019-10-21 Thread Steve Kargl
On Mon, Oct 21, 2019 at 03:40:27PM +0100, Mark Eggleston wrote: > This is an extension to support a legacy feature supported by other > compilers such as flang and the sun compiler.  As I understand it this > feature is associated with DEC so it enabled using > -fdec-char-conversions and by

Re: [PATCH 09/29] [arm] Correctly cost addition with a carry-in

2019-10-21 Thread Richard Earnshaw (lists)
On 21/10/2019 16:46, Segher Boessenkool wrote: On Mon, Oct 21, 2019 at 03:46:53PM +0100, Richard Earnshaw (lists) wrote: On 19/10/2019 14:00, Segher Boessenkool wrote: On Fri, Oct 18, 2019 at 08:48:40PM +0100, Richard Earnshaw wrote: The cost routine for Arm and Thumb2 was not recognising

Re: gcc-wwwdocs branch master updated. cdc7bf90357701877546f8bac160d0fb9e20b334

2019-10-21 Thread Segher Boessenkool
On Mon, Oct 21, 2019 at 08:20:33AM -0700, Mike Stump wrote: > On Oct 21, 2019, at 3:30 AM, Segher Boessenkool > wrote: > > > > On Sun, Oct 20, 2019 at 06:06:30PM +0200, Gerald Pfeifer wrote: > >> On Wed, 9 Oct 2019, js...@gcc.gnu.org wrote: > >>> +Use "git commit" and "git push origin > >>>

Re: Move code out of vect_slp_analyze_bb_1

2019-10-21 Thread Richard Biener
On October 21, 2019 4:06:49 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On Mon, Oct 21, 2019 at 12:08 PM Richard Sandiford >> wrote: >>> >>> Richard Biener writes: >>> > On October 20, 2019 2:54:48 PM GMT+02:00, Richard Sandiford > wrote: >>> >>Richard Biener writes:

[arm] clean up alu+shift patterns

2019-10-21 Thread Richard Earnshaw (lists)
My DImode arithmetic patches introduced a bug on thumb2 where we could generate a register controlled shift into an ALU operation. In fairness the bug was always present, but latent. As part of cleaning this up (and auditing to ensure I've caught them all this time) I've gone through all the

Re: [PATCH 11/29] [arm] Reduce cost of insns that are simple reg-reg moves.

2019-10-21 Thread Richard Earnshaw (lists)
On 19/10/2019 17:17, Segher Boessenkool wrote: On Fri, Oct 18, 2019 at 08:48:42PM +0100, Richard Earnshaw wrote: Consider this sequence during combine: Trying 18, 7 -> 22: 18: r118:SI=r122:SI REG_DEAD r122:SI 7: r114:SI=0x1-r118:SI-ltu(cc:CC_RSB,0) REG_DEAD r118:SI

Re: [PATCH 09/29] [arm] Correctly cost addition with a carry-in

2019-10-21 Thread Segher Boessenkool
On Mon, Oct 21, 2019 at 03:46:53PM +0100, Richard Earnshaw (lists) wrote: > On 19/10/2019 14:00, Segher Boessenkool wrote: > >On Fri, Oct 18, 2019 at 08:48:40PM +0100, Richard Earnshaw wrote: > >> > >>The cost routine for Arm and Thumb2 was not recognising the idioms that > >>describe the addition

PING*2 : Fwd: [PATCH][gcov-profile/91971]Profile directory concatenated with object file path

2019-10-21 Thread Qing Zhao
Hi, This is 2nd ping of this simple patch. We are waiting for this patch for one of our important project. Please let me know whether this patch is reasonable or not. Thanks a lot. Qing > Begin forwarded message: > > From: Qing Zhao > Subject: PING: Fwd: [PATCH][gcov-profile/91971]Profile

Re: gcc-wwwdocs branch master updated. cdc7bf90357701877546f8bac160d0fb9e20b334

2019-10-21 Thread Mike Stump
On Oct 21, 2019, at 3:30 AM, Segher Boessenkool wrote: > > On Sun, Oct 20, 2019 at 06:06:30PM +0200, Gerald Pfeifer wrote: >> On Wed, 9 Oct 2019, js...@gcc.gnu.org wrote: >>> +Use "git commit" and "git push origin >>> +master" to check in the patch. >> >> I will admit I made a couple of first

Re: [PATCH 09/29] [arm] Correctly cost addition with a carry-in

2019-10-21 Thread Richard Earnshaw (lists)
On 19/10/2019 14:00, Segher Boessenkool wrote: On Fri, Oct 18, 2019 at 08:48:40PM +0100, Richard Earnshaw wrote: The cost routine for Arm and Thumb2 was not recognising the idioms that describe the addition with carry, this results in the instructions appearing more expensive than they really

Re: [PATCH] add __has_builtin (PR 66970)

2019-10-21 Thread Iain Sandoe
Hi Martin, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-10/msg00062.html > > On 10/1/19 11:16 AM, Martin Sebor wrote: >> Attached is an implementation of the __has_builtin special >> preprocessor operator/macro analogous to __has_attribute and >> (hopefully) compatible

[PATCH, Fortran] Allow CHARACTER literals in assignments and DATA statements - for review

2019-10-21 Thread Mark Eggleston
This is an extension to support a legacy feature supported by other compilers such as flang and the sun compiler.  As I understand it this feature is associated with DEC so it enabled using -fdec-char-conversions and by -fdec. It allows character literals to be assigned to numeric (INTEGER,

Re: [PATCH, OpenACC] Fortran deviceptr

2019-10-21 Thread Chung-Lin Tang
On 2019/10/19 9:04 PM, Bernhard Reutner-Fischer wrote: On 18 October 2019 17:08:54 CEST, Chung-Lin Tang wrote: Also, I've added a new libgomp.oacc-fortran/deviceptr-2.f90 testcase that actually copies out and verifies the deviceptr computation. In testcases please do not 'call abort' which

Re: [PATCH][wwwdocs] Update GCC 9 release note

2019-10-21 Thread H.J. Lu
On Sun, Oct 20, 2019 at 10:19 AM Gerald Pfeifer wrote: > > On Thu, 10 Oct 2019, H.J. Lu wrote: > > Here is the same patch for git repo. Is it OK? > > Has this been available since GCC 9.1, or has it been added later? They have been checked into GCC 9.1. > (If the latter, please add this to a

Re: [PATCH] OpenACC reference count overhaul

2019-10-21 Thread Thomas Schwinge
Hi! On 2019-10-03T09:35:04-0700, Julian Brown wrote: > This patch has been broken out of the patch supporting OpenACC 2.6 manual > deep copy last posted here: > > https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01084.html Thanks. Remeber to look into "Potential

Re: Move code out of vect_slp_analyze_bb_1

2019-10-21 Thread Richard Sandiford
Richard Biener writes: > On Mon, Oct 21, 2019 at 12:08 PM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On October 20, 2019 2:54:48 PM GMT+02:00, Richard Sandiford >> > wrote: >> >>Richard Biener writes: >> >>> On October 19, 2019 5:06:40 PM GMT+02:00, Richard Sandiford >> >>

[PATCH] Fix PR92162

2019-10-21 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-21 Richard Biener PR tree-optimization/92162 * tree-vect-loop.c (vect_create_epilog_for_reduction): Lookup STMT_VINFO_REDUC_IDX in reduc_info. * tree-vect-stmts.c

Re: Move code out of vect_slp_analyze_bb_1

2019-10-21 Thread Richard Biener
On Mon, Oct 21, 2019 at 12:08 PM Richard Sandiford wrote: > > Richard Biener writes: > > On October 20, 2019 2:54:48 PM GMT+02:00, Richard Sandiford > > wrote: > >>Richard Biener writes: > >>> On October 19, 2019 5:06:40 PM GMT+02:00, Richard Sandiford > >> wrote: > After the previous

Re: [PATCH, Fortran] Optionally suppress no-automatic overwrites recursive warning - for approval

2019-10-21 Thread Mark Eggleston
PING - OK to commit? On 02/10/2019 09:00, Mark Eggleston wrote: On 28/09/2019 17:50, Steve Kargl wrote: On Thu, Sep 26, 2019 at 09:45:28AM +0100, Mark Eggleston wrote: Original thread starts here https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01185.html OK to commit? I'm not a big fan of

Re: [Darwin, testsuite, committed] Fix Wnonnull on Darwin.

2019-10-21 Thread Iain Sandoe
Hi Martin, Martin Sebor wrote: > On 10/20/2019 07:27 AM, Iain Sandoe wrote: >> Martin Sebor wrote: >>> On 10/19/19 2:56 AM, Iain Sandoe wrote: Andreas Schwab wrote: > On Okt 19 2019, Iain Sandoe wrote: > >> This test has failed always on Darwin, because Darwin does not mark

Re: [Darwin, testsuite, committed] Fix Wnonnull on Darwin.

2019-10-21 Thread Martin Sebor
On 10/20/2019 07:27 AM, Iain Sandoe wrote: Martin Sebor wrote: On 10/19/19 2:56 AM, Iain Sandoe wrote: Andreas Schwab wrote: On Okt 19 2019, Iain Sandoe wrote: This test has failed always on Darwin, because Darwin does not mark entries in string.h with nonnull attributes. Since the

Remove vars before TLS data during OpenACC shutdown

2019-10-21 Thread Julian Brown
This patch fixes a minor issue that could occur during OpenACC shutdown on nvidia devices. The acc_shutdown_1 function freed TLS data before unmapping variables, but the nvptx libgomp plugin uses the lack of TLS data in nvptx_free as an indication that it is running from callback context of the

Re: [PATCH] Fix (hypothetical) problem with pre-reload splitters (PR target/92140)

2019-10-21 Thread Segher Boessenkool
On Mon, Oct 21, 2019 at 01:27:23PM +0200, Jakub Jelinek wrote: > On Mon, Oct 21, 2019 at 05:45:16AM -0500, Segher Boessenkool wrote: > > On Sun, Oct 20, 2019 at 09:51:22PM +0200, Uros Bizjak wrote: > > > On Sun, Oct 20, 2019 at 1:24 PM Jakub Jelinek wrote: > > > > As mentioned in the PR, the x86

Re: [PATCH] OpenACC reference count overhaul

2019-10-21 Thread Julian Brown
On Tue, 15 Oct 2019 17:30:06 +0200 Thomas Schwinge wrote: > Hi Julian! > > On 2019-10-03T09:35:04-0700, Julian Brown > wrote: > > This patch has been broken out of the patch supporting OpenACC 2.6 > > manual deep copy last posted here: > > > >

Re: [PATCH 2/2] gcc/riscv: Add a mechanism to remove some calls to _riscv_save_0

2019-10-21 Thread Andrew Burgess
Below is a new versions of this patch, I believe that this addresses the review comments from the earlier version. In addition this has been tested using Jim's idea of forcing -msave-restore (if the flag is not otherwise given) and I now see no test failures for newlib and linux toolchains. One

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-21 Thread Richard Earnshaw (lists)
On 21/10/2019 12:51, Christophe Lyon wrote: On 18/10/2019 21:48, Richard Earnshaw wrote: Each patch should produce a working compiler (it did when it was originally written), though since the patch set has been re-ordered slightly there is a possibility that some of the intermediate steps may

[committed] Backports to gcc-9-branch

2019-10-21 Thread Jakub Jelinek
Hi! I've backported following 18 patches (20 trunk commits in total) from trunk to gcc-9-branch, bootstrapped/regtested on x86_64-linux and i686-linux and committed to gcc-9-branch. Jakub 2019-10-21 Jakub Jelinek Backported from mainline 2019-08-02 Jakub Jelinek

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-21 Thread Christophe Lyon
On 18/10/2019 21:48, Richard Earnshaw wrote: Each patch should produce a working compiler (it did when it was originally written), though since the patch set has been re-ordered slightly there is a possibility that some of the intermediate steps may have missing test updates that are only

[wwwdocs] readings.html - pubs.opengroup.org has moved to https

2019-10-21 Thread Gerald Pfeifer
Committed. Gerald - Log - commit 2ae4a89035240f0df48cefdc0bd3270e193f49f9 Author: Gerald Pfeifer Date: Mon Oct 21 13:45:44 2019 +0200 pubs.opengroup.org has moved to https. diff --git a/htdocs/readings.html

[PATCH] Fix PR92161

2019-10-21 Thread Richard Biener
Bootstrapped & tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-21 Richard Biener PR tree-optimization/92161 * tree-vect-loop.c (vect_analyze_loop_2): Reset stmts def-type for reductions. * gfortran.dg/pr92161.f: New testcase. Index:

Re: [PATCH] Fix (hypothetical) problem with pre-reload splitters (PR target/92140)

2019-10-21 Thread Jakub Jelinek
On Mon, Oct 21, 2019 at 05:45:16AM -0500, Segher Boessenkool wrote: > On Sun, Oct 20, 2019 at 09:51:22PM +0200, Uros Bizjak wrote: > > On Sun, Oct 20, 2019 at 1:24 PM Jakub Jelinek wrote: > > > As mentioned in the PR, the x86 backend has various define_insn_and_split > > > patterns that are meant

Re: [PATCH] Improve debug info in ivopts optimized loops (PR debug/90231)

2019-10-21 Thread Jakub Jelinek
On Mon, Oct 21, 2019 at 06:41:46PM +0800, Bin.Cheng wrote: > The overflow check is difficult, IIUC, checks on bit precision in the > patch is not enough? Considering an unsigned 64-bit candidate with I think it can cover some cases, especially on 64-bit targets, but will leave other cases out.

[PATCH] [MIPS] PR82981 - mulditi3 pattern for MIPS64R6

2019-10-21 Thread Mihailo Stojanovic
This expands the existing MIPS mulditi3 pattern by adding support for MIPS64R6 multiplication instructions. gcc/ChangeLog: * config/mips/mips.md (mulditi3): Generate patterns for high doubleword and low doubleword result of multiplication on MIPS64R6.

Re: [PATCH] Fix (hypothetical) problem with pre-reload splitters (PR target/92140)

2019-10-21 Thread Segher Boessenkool
On Sun, Oct 20, 2019 at 09:51:22PM +0200, Uros Bizjak wrote: > On Sun, Oct 20, 2019 at 1:24 PM Jakub Jelinek wrote: > > As mentioned in the PR, the x86 backend has various define_insn_and_split > > patterns that are meant to match usually during combine, are then > > unconditionally split during

Re: [PATCH] Improve debug info in ivopts optimized loops (PR debug/90231)

2019-10-21 Thread Bin.Cheng
On Sat, Oct 19, 2019 at 2:27 PM Jakub Jelinek wrote: > > Hi! > > As mentioned in the PR, the following patch attempts to address two issues. > In remove_unused_ivs we first find the best iv_cand (we prefer primarily the > same step, next same mode and lastly constant base) and only then call >

Re: gcc-wwwdocs branch master updated. cdc7bf90357701877546f8bac160d0fb9e20b334

2019-10-21 Thread Segher Boessenkool
On Sun, Oct 20, 2019 at 06:06:30PM +0200, Gerald Pfeifer wrote: > On Wed, 9 Oct 2019, js...@gcc.gnu.org wrote: > > +Use "git commit" and "git push origin > > +master" to check in the patch. > > I will admit I made a couple of first commits without reading those > details and just used a plain

[committed][vect] Only change base alignment if more restrictive

2019-10-21 Thread Andre Vieira (lists)
Hi all, This patch was pre-approved by richi. This patch makes sure ensure_base_align only changes alignment if the new alignment is more restrictive. It already did this if we were dealing with symbols, but it now does it for all types of declarations. Committed in revision r277238.

Re: Move code out of vect_slp_analyze_bb_1

2019-10-21 Thread Richard Sandiford
Richard Biener writes: > On October 20, 2019 2:54:48 PM GMT+02:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On October 19, 2019 5:06:40 PM GMT+02:00, Richard Sandiford >> wrote: After the previous patch, it seems more natural to apply the PARAM_SLP_MAX_INSNS_IN_BB

Re: [PATCH 00/29] [arm] Rewrite DImode arithmetic support

2019-10-21 Thread Segher Boessenkool
On Sun, Oct 20, 2019 at 12:21:21PM +0100, Richard Earnshaw (lists) wrote: > On 19/10/2019 17:31, Segher Boessenkool wrote: > > I have a bunch of testcases from when I did something similar for PowerPC > > that I wanted to test... But I cannot get your series to apply. Do you > > have a git repo

[PATCH][AArch64] Implement __rndr, __rndrrs intrinsics

2019-10-21 Thread Kyrill Tkachov
Hi all, This patch implements the recently published[1] __rndr and __rndrrs intrinsics used to access the RNG in Armv8.5-A. The __rndrrs intrinsics can be used to reseed the generator too. They are guarded by the __ARM_FEATURE_RNG feature macro. A quirk with these intrinsics is that they store

Re: [PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

2019-10-21 Thread Stam Markianos-Wright
On 10/13/19 4:23 PM, Ramana Radhakrishnan wrote: >> >> Patch bootstrapped and regression tested on arm-none-linux-gnueabihf, >> however, on my native Aarch32 setup the test times out when run as part >> of a big "make check-gcc" regression, but not when run individually. >> >> 2019-10-11

[PATCH] Record externals/invariants in the SLP graph

2019-10-21 Thread Richard Biener
This patch adds SLP nodes for invariant/external operands of stmts to the SLP graph. That in turn allows to simplfy vectorized operand gathering. The new SLP nodes are not yet first-class citizens but this is a step in the correct direction plus it allows us to scrap more of the IL-operand

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-21 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the pointers. On Fri, 11 Oct 2019 at 22:33, Richard Biener wrote: > > On Fri, Oct 11, 2019 at 6:15 AM Kugan Vivekanandarajah > wrote: > > > > Hi Richard, > > Thanks for the review. > > > > On Wed, 2 Oct 2019 at 20:41, Richard Biener > > wrote: > > > > > > On Wed, Oct

Re: [PATCH] Use narrow mode of constant when expanding widening multiplication

2019-10-21 Thread Richard Sandiford
Jozef Lawrynowicz writes: > I experienced the following ICE when working on a downstream patch for msp430: > > void > foo (unsigned int r, unsigned int y) > { > __builtin_umul_overflow ((unsigned int) (-1), y, ); > } > >> msp430-elf-gcc -S tester.c -O0 > > tester.c: In function 'foo': >

[PATCH] Report errors on inconsistent OpenACC nested reduction, clauses

2019-10-21 Thread Harwath, Frederik
Hi, OpenACC requires that, if a variable is used in reduction clauses on two nested loops, then there must be reduction clauses for that variable on all loops that are nested in between the two loops and all these reduction clauses must use the same operator; this has been first clarified by

Re: [testsuite] Add test for PR91532

2019-10-21 Thread Richard Sandiford
Prathamesh Kulkarni writes: > On Sat, 19 Oct 2019 at 23:45, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > Hi Richard, >> > Sorry for not adding the test in PR91532 fix. >> > Is the attached patch OK to commit ? >> > >> > Thanks, >> > Prathamesh >> > >> > 2019-10-18

Re: Move code out of vect_slp_analyze_bb_1

2019-10-21 Thread Richard Biener
On October 20, 2019 2:54:48 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On October 19, 2019 5:06:40 PM GMT+02:00, Richard Sandiford > wrote: >>>After the previous patch, it seems more natural to apply the >>>PARAM_SLP_MAX_INSNS_IN_BB threshold as soon as we know what