Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Sandra Loosemore
On 2/1/20 8:43 AM, Bernd Edlinger wrote: diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 6ffafac..1d3fec5 100644 --- a/gcc/doc/install.texi +++ b/gcc/doc/install.texi @@ -2097,9 +2097,18 @@ option (if not used explicitly on the command line). @var{choice} can be one of

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Segher Boessenkool
On Sat, Feb 01, 2020 at 05:21:30PM +, Bernd Edlinger wrote: > On 2/1/20 6:12 PM, Jakub Jelinek wrote: > > On Sat, Feb 01, 2020 at 03:43:20PM +, Bernd Edlinger wrote: > >> I seem to remember him saying that he always has to configure with > >> --with-diagnostics-color=never, and the URLs

[PATCH] s390x: Fix popcounthi2_z196 expander [PR93533]

2020-02-01 Thread Jakub Jelinek
Hi! The following testcase started to ICE when .POPCOUNT matching has been added to match.pd; we had __builtin_popcount*, but nothing would use the popcounthi2 expander before. The problem is that the popcounthi2_z196 expander doesn't emit valid RTL: error: unrecognizable insn: (insn 138 137 139

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Bernd Edlinger
On 1/31/20 11:54 PM, Segher Boessenkool wrote: > none of which use "TERM=fancy-pants-term-v42" either. (Did anyone ever > use "dumb", anyway?) > It seems like emacs shell does set TERM=dumb, and it is certainly the right thing not to emit any control codes in that environment. Bernd.

Re: [PATCH] libgfortran: Fix and simplify IO locking [PR92836]

2020-02-01 Thread Janne Blomqvist
On Sat, Feb 1, 2020 at 6:37 PM Thomas Koenig wrote: > > Hi Janne, > > > Simplify IO locking in libgfortran. The new IO implementation avoids > > accessing units without locks, as seen in PR 92836. It also avoids > > lock inversion (except for a corner case wrt namelist query when > > reading

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Bernd Edlinger
On 2/1/20 6:12 PM, Jakub Jelinek wrote: > On Sat, Feb 01, 2020 at 03:43:20PM +, Bernd Edlinger wrote: >> I seem to remember him saying that he always has to configure with >> --with-diagnostics-color=never, and the URLs are on top of that. >> But there was no configure option for that, which,

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Bernd Edlinger
On 2/1/20 4:54 PM, Segher Boessenkool wrote: > Hi! > > On Sat, Feb 01, 2020 at 05:02:18AM +, Bernd Edlinger wrote: Definitely, if the situation with tmux is like xfce4-terminal (reportedly the 0.8 version switched to a fixed VTE, which makes the URLs invisible, but the URL

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 03:43:20PM +, Bernd Edlinger wrote: > I seem to remember him saying that he always has to configure with > --with-diagnostics-color=never, and the URLs are on top of that. > But there was no configure option for that, which, given his explanation, > made immediately

Re: [PATCH] libgfortran: Fix and simplify IO locking [PR92836]

2020-02-01 Thread Thomas Koenig
Hi Janne, Simplify IO locking in libgfortran. The new IO implementation avoids accessing units without locks, as seen in PR 92836. It also avoids lock inversion (except for a corner case wrt namelist query when reading from stdin and outputting to stdout), making it easier to verify

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Segher Boessenkool
On Sat, Feb 01, 2020 at 08:41:15AM -0500, David Malcolm wrote: > Does our existing colorization code not work with TMUX, or is it just the > new URLs that are broken? Segher? I don't know, I have colourisation turned off in GCC pretty much always on systems I use with tmux. Some other programs

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Segher Boessenkool
Hi! On Sat, Feb 01, 2020 at 05:02:18AM +, Bernd Edlinger wrote: > >> Definitely, if the situation with tmux is like xfce4-terminal (reportedly > >> the 0.8 version switched to a fixed VTE, which makes the URLs invisible, > >> but the URL feature request is pending sine 2017, with no activity

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Bernd Edlinger
On 2/1/20 2:41 PM, David Malcolm wrote: > On Sat, 2020-02-01 at 07:30 +, Bernd Edlinger wrote: >> >> On 1/31/20 11:06 PM, David Malcolm wrote: >>> On Fri, 2020-01-31 at 16:59 +, Bernd Edlinger wrote: Hi, this is patch is heavily based on David's original patch here:

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread David Malcolm
On Sat, 2020-02-01 at 07:30 +, Bernd Edlinger wrote: > > On 1/31/20 11:06 PM, David Malcolm wrote: > > On Fri, 2020-01-31 at 16:59 +, Bernd Edlinger wrote: > > > Hi, > > > > > > this is patch is heavily based on David's original patch here: > > >

Re: libgo patch committed: Update to Go1.14beta1

2020-02-01 Thread Andreas Schwab
../../../libgo/go/syscall/syscall_linux_riscv64.go:7:14: error: imported and not used: unsafe 7 | import "unsafe" | ^ ../../../libgo/go/syscall/syscall_linux_riscv64.go:13:1: error: redefinition of 'SetLen' 13 | func (iov *Iovec) SetLen(length int) { | ^

Re: [PATCH, v4] coroutines: Fix ICE on invalid (PR93458).

2020-02-01 Thread Iain Sandoe
Nathan Sidwell wrote: > On 1/30/20 9:43 AM, Iain Sandoe wrote: >> Hi Nathan, > >> however. …. >>> also, what if you find something, but it's not a type template? >> … I’ve switched the complain off on lookup_qualified_name and now check for >> a type template. > > I'm not sure that's helpful.

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Bernd Edlinger
On 2/1/20 9:55 AM, Jakub Jelinek wrote: > On Sat, Feb 01, 2020 at 07:30:15AM +, Bernd Edlinger wrote: >> @@ -239,20 +243,86 @@ colorize_init (diagnostic_color_rule_t rule) >> } >> } >> >> +/* Return URL_FORMAT_XXX which tells how we should emit urls >> + when in always mode. >> +

Re: [PATCH] fortran: Fix up TYPE_ARG_TYPES of procs with scalar VALUE optional args [PR92305]

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 09:43:30AM +0100, Tobias Burnus wrote: > Aha, there the problem was hidden! — I assumed something in the tree went > wrong, but didn't spot where. > > Does this also fix PR 92844? The full diff of test_summary for libgomp on powerpc64le-linux is: ===

Re: [PATCH] Add --with-diagnostics-urls configuration option and GCC_URLS/TERM_URLS env var

2020-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2020 at 07:30:15AM +, Bernd Edlinger wrote: > @@ -239,20 +243,86 @@ colorize_init (diagnostic_color_rule_t rule) > } > } > > +/* Return URL_FORMAT_XXX which tells how we should emit urls > + when in always mode. > + We use GCC_URLS and if that is not defined

Re: [PATCH] fortran: Fix up TYPE_ARG_TYPES of procs with scalar VALUE optional args [PR92305]

2020-02-01 Thread Tobias Burnus
Aha, there the problem was hidden! — I assumed something in the tree went wrong, but didn't spot where. Does this also fix PR 92844? Thanks for investigating and fixing the issue. – LGTM. (I think one needs to re-check this when fixing some of the VALUE bugs, but that's independent of this

[PATCH] arm: Fix ICE with movsi + cmpsi -> movsi_compare0 peephole2 [PR91913]

2020-02-01 Thread Jakub Jelinek
Hi! The following testcase ICEs on arm. The problem is that the following peephole tries to match adjacent *arm_movsi_insn + *arm_cmpsi_insn; the *arm_movsi_insn uses =rk, rk constraints and *arm_cmpsi_insn uses r, IL constraints for what is matched by the peephole2. Peephole2s work only with