Re: [PATCH v2] Fold (add -1; zero_ext; add +1) operations to zero_ext when not overflow (PR37451, part of PR61837)

2020-05-13 Thread luoxhu via Gcc-patches
On 2020/5/13 02:24, Richard Sandiford wrote: > luoxhu writes: >> + /* Fold (add -1; zero_ext; add +1) operations to zero_ext. i.e: >> + >> + 73: r145:SI=r123:DI#0-0x1 >> + 74: r144:DI=zero_extend (r145:SI) >> + 75: r143:DI=r144:DI+0x1 >> + ... >> + 31: r135:CC=cmp

Re: [PATCH PR94969]Add unit distant vector to DDR in case of invariant access functions

2020-05-13 Thread Bin.Cheng via Gcc-patches
On Thu, May 14, 2020 at 1:46 AM Jakub Jelinek via Gcc-patches wrote: > > On Wed, May 13, 2020 at 02:00:11PM +0200, Christophe Lyon via Gcc-patches > wrote: > > > > 2020-05-11 Bin Cheng > > > > > > > > PR tree-optimization/94969 > > > > * gcc.dg/tree-ssa/pr94969.c: New test. >

Re: [PATCH] RISC-V: Make unique SECCAT_SRODATA names start with .srodata

2020-05-13 Thread Palmer Dabbelt
On Tue, 12 May 2020 16:53:14 PDT (-0700), Jim Wilson wrote: This fixes a bug reported to the RISC-V sw-dev mailing list late last year. https://groups.google.com/a/groups.riscv.org/forum/#!topic/sw-dev/JV5Jdh4UjVw Keith Packard wote the obvious patch to fix it. I tested it with cross builds

Re: [PATCH] [V2] rs6000: Add vec_extracth and vec_extractl

2020-05-13 Thread Segher Boessenkool
Hi! On Wed, May 13, 2020 at 07:50:50AM -0500, Bill Schmidt wrote: > From: Kelvin Nilsen > > Add new insns vextdu[bhw]vlx, vextddvlx, vextdu[bhw]vhx, and > vextddvhx, along with built-in access and overloaded built-in > access to these insns. > > Changes from previous patch: > * Removed the

[C++] template arg comparison

2020-05-13 Thread Nathan Sidwell
When fixing up the template specialization hasher I was confused by the control flow through template_args_equal. This reorders the category checking, so it is clearer as to what kind of node can reach which point. nathan -- Nathan Sidwell 2020-05-13 Nathan Sidwell * pt.c

[C++] simplify typedef access checking

2020-05-13 Thread Nathan Sidwell
I discovered template typedef access checking was more expensive than it need be. The call of get_types_needed_access_check in the FOR_EACH_VEC_SAFE_ELT is the moral equivalent of for (size_t pos = 0; pos != strlen (string); pos++)' Let's not do that. nathan -- Nathan Sidwell 2020-05-13

[C++] canonical_type_parameter

2020-05-13 Thread Nathan Sidwell
Canonical_type_parameter shows C-like thinking. This modernizes it, which I found simpler to understand. pushed to master nathan -- Nathan Sidwell 2020-05-13 Nathan Sidwell * pt.c (canonical_type_parameter): Simplify. diff --git i/gcc/cp/pt.c w/gcc/cp/pt.c index a732ced2d8d..a36f603761c

[C++] some cleanup patches

2020-05-13 Thread Nathan Sidwell
I've committed this set of minor cleanups from the modules branch. nathan -- Nathan Sidwell 2020-05-13 Nathan Sidwell Formatting fixups & some simplifications. * pt.c (spec_hash_table): New typedef. (decl_specializations, type_specializations): Use it. (retrieve_specialization):

Re: [PATCH] c++: premature requires-expression folding [PR95020]

2020-05-13 Thread Jason Merrill via Gcc-patches
On 5/11/20 6:43 PM, Patrick Palka wrote: In the testcase below we're prematurely folding away the requires-expression to 'true' after substituting in the function's template arguments, but before substituting in the lambda's deduced template arguments. This happens because during the first

Re: [PATCH] c++: explicit(bool) malfunction with dependent expression [PR95066]

2020-05-13 Thread Jason Merrill via Gcc-patches
On 5/11/20 7:06 PM, Marek Polacek wrote: I forgot to set DECL_HAS_DEPENDENT_EXPLICIT_SPEC_P when merging two function declarations and as a sad consequence, we never tsubsted the dependent explicit-specifier in tsubst_function_decl, leading to disregarding the explicit-specifier altogether, and

Re: [PATCH] c++: SFINAE for invalid delete-expression [PR79706]

2020-05-13 Thread Jason Merrill via Gcc-patches
On 5/12/20 11:36 PM, Patrick Palka wrote: This fixes SFINAE when substitution yields an invalid delete-expression due to the pertinent deallocation function being marked deleted or otherwise inaccessible. We need to check for an erroneous result from build_op_delete_call and exit early in that

[pushed] testsuite: Support { target c++20 } in tests.

2020-05-13 Thread Jason Merrill via Gcc-patches
I'm not sure why I didn't check this in along with adding -std=c++20, since I wrote this patch at the same time. The testsuite should support both { target c++2a } and { target c++20 }. Tested x86_64-pc-linux-gnu, applying to trunk and 10. gcc/testsuite/ChangeLog 2020-05-13 Jason Merrill

libgo patch committed: Build syscall test with -static

2020-05-13 Thread Ian Lance Taylor via Gcc-patches
This libgo patch builds the syscall test with -static. This avoids problems finding libgo.so when running the test as root, which invokes the test as a child process in various limited environments. This fixes GCC PR 95061. Bootstrapped and ran Go tests on x86_64-pc-linux-gnu. Committed to

libbacktrace patch committed: Mark state unused in ztest.c test_large

2020-05-13 Thread Ian Lance Taylor via Gcc-patches
This libbacktrace patch marks the state parameter of test_large in ztest.c as ATTRIBUTE_UNUSED. The parameter is not used if HAVE_ZLIB is not defined. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. Committed to mainline. Ian 2020-05-13 Ian Lance Taylor * ztest.c

Re: ChangeLog files - server and client scripts

2020-05-13 Thread Joseph Myers
On Wed, 13 May 2020, Martin Liška wrote: > I'm sending the gcc-changelog relates scripts which should be added to contrib > folder. The patch contains: > - git_check_commit.py - checking script that verifies git message format We need a documentation patch to contribute.html or gitwrite.html

Re: [PATCH v2 1/2] RISC-V: Add shorten_memrefs pass

2020-05-13 Thread Craig Blackmore
On 12/05/2020 23:33, Jim Wilson wrote: > On Mon, Apr 27, 2020 at 10:08 AM Craig Blackmore > wrote: >> Thanks for the review. I have updated the following patch with those changes. > This looks good, and the tree is open for development work again, so I > committed both parts 1 and 2 and pushed

[PATCH] PR94397 the compiler consider "type is( real(kind(1.)) )" as a syntax error

2020-05-13 Thread Mark Eggleston
Please find attached a patch for PR94397. Commit message: Fortran  : "type is( real(kind(1.)) )" spurious syntax error PR94397 Based on a patch in the comments of the PR. That patch fixed this problem but caused the test cases for PR93484 to fail. Changed to reduce initialisation expressions

Re: [PATCH PR94969]Add unit distant vector to DDR in case of invariant access functions

2020-05-13 Thread Jakub Jelinek via Gcc-patches
On Wed, May 13, 2020 at 02:00:11PM +0200, Christophe Lyon via Gcc-patches wrote: > > > 2020-05-11 Bin Cheng > > > > > > PR tree-optimization/94969 > > > * gcc.dg/tree-ssa/pr94969.c: New test. > > The new test fails on arm and aarch64 and probably everywhere: >

libbacktrace patch committed: Treat EACCES like ENOENT

2020-05-13 Thread Ian Lance Taylor via Gcc-patches
This patch to libbacktrace treats an EACCES error when opening a file like an ENOENT error. This case happens when running the libgo syscall tests as root, when testing various ways of restricting a child process. Bootstrapped and ran libbacktrace and Go tests on x86_64-pc-linux-gnu. Committed

[PATCH resend] rs6000, pr 94833: fix vec_first_match_index for nulls

2020-05-13 Thread Carl Love via Gcc-patches
GCC maintainers: This is a resend of "[PATCH]rs6000, fix vec_first_match_index for nulls". Per the received comments the pr number was added to the subject line. I also tweaked the message to make it clear that the patch fixed issues with vectors whose elements contain zeros rather then a zero

Re: Ping: [RFA] Require powerpc_vsx_ok in gcc.target/powerpc/pr71763.c

2020-05-13 Thread Joel Brobecker
Hello, Would someone mind reviewing this patch, please? The test explicitly uses -mvsx in the compilation options, so it seems reasonable to require powerpc_vsx_ok... Thank you! > Just a friendly ping on the following patch, hopefully sufficiently > straightforward and tested to be allowed

[PATCH] c++: Implement DR 2289, Uniqueness of structured binding names [PR94553]

2020-05-13 Thread Marek Polacek via Gcc-patches
DR 2289 clarified that since structured bindings have no C compatibility implications, they should be unique in their declarative region, see [basic.scope.declarative]/4.2. The duplicate_decls hunk is the gist of the patch, but that alone would not be enough to detect the 'A' case:

[committed] c++: Fix g++.dg/parse/attr4.C test.

2020-05-13 Thread Marek Polacek via Gcc-patches
I noticed this test failing in C++11 mode. Tested x86_64-pc-linux-gnu, applying to trunk. * g++.dg/parse/attr4.C: Use c++11 in a target selector. --- gcc/testsuite/g++.dg/parse/attr4.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/parse/attr4.C

[PATCH] x86: Allow vector register pushes

2020-05-13 Thread H.J. Lu via Gcc-patches
On Wed, May 13, 2020 at 6:35 AM Uros Bizjak wrote: > > On Wed, May 13, 2020 at 3:25 PM H.J. Lu wrote: > > > > On Wed, May 13, 2020 at 6:17 AM Uros Bizjak wrote: > > > > > > On Wed, May 13, 2020 at 2:37 PM H.J. Lu wrote: > > > > > > > > On Wed, May 13, 2020 at 5:04 AM Uros Bizjak wrote: > > >

[PATCH] Don't make -gsplit-dwarf imply -g

2020-05-13 Thread Fangrui Song via Gcc-patches
On 2020-05-13, Eric Botcazou wrote: Did I mention I dislike -fsplit-dwarf? ;) Seconded, this will be confusing for almost all users. Since the option only affects debug info generation, it should be prefixed with 'g' in any case. Updating the semantics of -gsplit-dwarf is actually my

Re: [PATCH] coroutines: Implicitly movable objects should use move CTORs for co_return.

2020-05-13 Thread Nathan Sidwell
On 5/13/20 9:26 AM, Iain Sandoe wrote: Nathan Sidwell wrote: On 5/13/20 6:59 AM, Iain Sandoe wrote: @@ -1045,25 +1044,50 @@ finish_co_return_stmt (location_t kw, tree expr)    if (!crv_meth || crv_meth == error_mark_node) return error_mark_node;  -  vec *args =

Re: [PATCH] tree-optimization/33315 - common stores during sinking

2020-05-13 Thread Martin Sebor via Gcc-patches
On 5/13/20 2:20 AM, Richard Biener wrote: This implements commoning of stores to a common successor in a simple ad-hoc way. I've decided to put it into the code sinking pass since, well, it sinks stores. It's still separate since it does not really sink code into less executed places. It's

[committed] c++: Add testcase for already-fixed PR [PR70642]

2020-05-13 Thread Patrick Palka via Gcc-patches
We correctly reject the testcase in this PR ever since commit r9-7046. gcc/testsuite/ChangeLog: PR c++/70642 * g++.dg/cpp0x/alias-decl-70.C: New test. --- gcc/testsuite/ChangeLog| 5 + gcc/testsuite/g++.dg/cpp0x/alias-decl-70.C | 23

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread Uros Bizjak via Gcc-patches
On Wed, May 13, 2020 at 3:25 PM H.J. Lu wrote: > > On Wed, May 13, 2020 at 6:17 AM Uros Bizjak wrote: > > > > On Wed, May 13, 2020 at 2:37 PM H.J. Lu wrote: > > > > > > On Wed, May 13, 2020 at 5:04 AM Uros Bizjak wrote: > > > > > > > > On Wed, May 13, 2020 at 1:05 PM Uros Bizjak wrote: > > >

Re: ChangeLog files - server and client scripts

2020-05-13 Thread Martin Liška
On 5/13/20 3:24 PM, Richard Earnshaw wrote: I've just realized this doesn't give us an easy way to mark changes for the root-level ChangeLog file, unless, perhaps "@@ CL ." works? This works fine: 'ChangeLog:' as seen for instance here: commit 9ad3c1d81c129fc76594b9df5b798c380cbf03ee Author:

Re: [PATCH] coroutines: Implicitly movable objects should use move CTORs for co_return.

2020-05-13 Thread Iain Sandoe
Nathan Sidwell wrote: On 5/13/20 6:59 AM, Iain Sandoe wrote: @@ -1045,25 +1044,50 @@ finish_co_return_stmt (location_t kw, tree expr) if (!crv_meth || crv_meth == error_mark_node) return error_mark_node; - vec *args = make_tree_vector_single (expr); - co_ret_call =

Re: ChangeLog files - server and client scripts

2020-05-13 Thread Richard Earnshaw
On 13/05/2020 12:05, Martin Liška wrote: > Hi. > > I'm sending the gcc-changelog relates scripts which should be added to > contrib > folder. The patch contains: > - git_check_commit.py - checking script that verifies git message format > - git_update_version.py - a replacement of >

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread H.J. Lu via Gcc-patches
On Wed, May 13, 2020 at 6:17 AM Uros Bizjak wrote: > > On Wed, May 13, 2020 at 2:37 PM H.J. Lu wrote: > > > > On Wed, May 13, 2020 at 5:04 AM Uros Bizjak wrote: > > > > > > On Wed, May 13, 2020 at 1:05 PM Uros Bizjak wrote: > > > > > > > > On Tue, May 12, 2020 at 10:07 PM H.J. Lu wrote: > > >

Re: [PATCH] coroutines: Implicitly movable objects should use move CTORs for co_return.

2020-05-13 Thread Nathan Sidwell
On 5/13/20 6:59 AM, Iain Sandoe wrote: .. and now to the right list… I came across a build failure in a folly experimental test case where, at first, it appeared that GCC was DTRT … however, further investigation concluded that this was a case of differing interpretations between

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread Uros Bizjak via Gcc-patches
On Wed, May 13, 2020 at 2:37 PM H.J. Lu wrote: > > On Wed, May 13, 2020 at 5:04 AM Uros Bizjak wrote: > > > > On Wed, May 13, 2020 at 1:05 PM Uros Bizjak wrote: > > > > > > On Tue, May 12, 2020 at 10:07 PM H.J. Lu wrote: > > > > > > > > Update STV pass to properly count cost of XMM register

Ping: [PATCH] wwwdocs: Add D front-end section for GCC 10 changes

2020-05-13 Thread Iain Buclaw via Gcc-patches
Ping. On 07/05/2020 16:04, Iain Buclaw via Gcc-patches wrote: > Hi, > > Updated the patch to include missed changes, and slighted reworded some > entries > to make them clearer/read easier. > > OK to commit? > > Iain. > > --- > htdocs/gcc-10/changes.html | 35

Re: [PATCH] contrib/vimrc: Reduce textwidth for commit messages

2020-05-13 Thread Martin Liška
On 5/4/20 8:18 PM, Martin Liška wrote: I support the patch, And as there's no feedback I also installed the patch. Martin

[PATCH] [V2] rs6000: Add vec_extracth and vec_extractl

2020-05-13 Thread Bill Schmidt via Gcc-patches
From: Kelvin Nilsen Add new insns vextdu[bhw]vlx, vextddvlx, vextdu[bhw]vhx, and vextddvhx, along with built-in access and overloaded built-in access to these insns. Changes from previous patch: * Removed the int iterators * Created separate expansions and insns vextractl

[PATCH] add vectype parameter to add_stmt_cost hook

2020-05-13 Thread Richard Biener
This adds a vectype parameter to add_stmt_cost which avoids the need to pass down a (wrong) stmt_info just to carry this information. Useful for invariants which do not have a stmt_info associated. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2020-05-13 Richard Biener

[PATCH] Add default revisions argument for git_check_commit.py.

2020-05-13 Thread Martin Liška
A small tweak to the script that I'm going to install. Martin contrib/ChangeLog: 2020-05-13 Martin Liska * gcc-changelog/git_check_commit.py: Add default argument HEAD for revisions and improve error message output. --- contrib/gcc-changelog/git_check_commit.py | 6 +++---

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread H.J. Lu via Gcc-patches
On Wed, May 13, 2020 at 5:04 AM Uros Bizjak wrote: > > On Wed, May 13, 2020 at 1:05 PM Uros Bizjak wrote: > > > > On Tue, May 12, 2020 at 10:07 PM H.J. Lu wrote: > > > > > > Update STV pass to properly count cost of XMM register push. In 32-bit > > > mode, to convert XMM register push in

Re: ChangeLog files - server and client scripts

2020-05-13 Thread Martin Liška
The scripts were just installed to master except the git alias. I'm sending that in a separate patch. Now the alias can be used from any subfolder in a gcc git repository. Martin >From eb47191e8d8cbbda285c4df7eb2d1e98091edab9 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 13 May 2020

Re: [PR 95013] EOF location is at end of file

2020-05-13 Thread Nathan Sidwell
On 5/13/20 2:44 AM, Christophe Lyon wrote: On Wed, 13 May 2020 at 02:24, H.J. Lu via Gcc-patches [PR 95013] Fix gcc.dg/unclosed-init.c 2020-05-13 Christophe Lyon PR preprocessor/95013 * gcc.dg/unclosed-init.c: Add missing comment in dg-error. Thanks for

ChangeLog files - server and client scripts (git cherry-pick)

2020-05-13 Thread Martin Liška
On 5/13/20 1:05 PM, Martin Liška wrote: I suggest to use native 'git revert XYZ' and 'git cherry-pick -x XYZ'. I've prepared a working version of Revert format: https://github.com/marxin/gcc-changelog/tree/cherry-pick So using git cherry-pick -x HASH one gets something like: $ cat

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread Uros Bizjak via Gcc-patches
On Wed, May 13, 2020 at 1:05 PM Uros Bizjak wrote: > > On Tue, May 12, 2020 at 10:07 PM H.J. Lu wrote: > > > > Update STV pass to properly count cost of XMM register push. In 32-bit > > mode, to convert XMM register push in DImode, we do an XMM store in > > DImode, followed by 2 memory pushes

Re: [PATCH PR94969]Add unit distant vector to DDR in case of invariant access functions

2020-05-13 Thread Christophe Lyon via Gcc-patches
Hi Bin, On Mon, 11 May 2020 at 14:54, Richard Biener via Gcc-patches wrote: > > On Mon, May 11, 2020 at 7:52 AM bin.cheng via Gcc-patches > wrote: > > > > Hi, > > As analyzed in PR94969, data dependence analysis now misses dependence > > vector for specific case in which DRs in DDR have the

Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-13 Thread Christophe Lyon via Gcc-patches
On Wed, 13 May 2020 at 13:45, Srinath Parvathaneni wrote: > > Hi, > > > -Original Message- > > From: Christophe Lyon > > Sent: 13 May 2020 11:20 > > To: Srinath Parvathaneni > > Cc: gcc Patches ; Richard Earnshaw > > > > Subject: Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated

RE: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-13 Thread Srinath Parvathaneni
Hi, > -Original Message- > From: Christophe Lyon > Sent: 13 May 2020 11:20 > To: Srinath Parvathaneni > Cc: gcc Patches ; Richard Earnshaw > > Subject: Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE > vector load/store intrinsics (PR94959). > > Hi, > > > On Wed, 13

[PATCH] Remove SLP_INSTANCE_GROUP_SIZE

2020-05-13 Thread Richard Biener
This removes the SLP_INSTANCE_GROUP_SIZE member since the number of lanes throughout a SLP subgraph is not necessarily constant. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2020-05-13 Richard Biener * tree-vectorizer.h (SLP_INSTANCE_GROUP_SIZE): Remove.

[RFC PATCH v2] cgraph support for late declare variant resolution

2020-05-13 Thread Jakub Jelinek via Gcc-patches
Hi! This is a new version of the https://gcc.gnu.org/legacy-ml/gcc-patches/2019-11/msg01493.html patch. Unlike the previous version, this one actually works properly except for LTO, bootstrapped/regtested on x86_64-linux and i686-linux too. In short, #pragma omp declare variant is a directive

Re: [PATCH] x86: Properly count cost of XMM register push

2020-05-13 Thread Uros Bizjak via Gcc-patches
On Tue, May 12, 2020 at 10:07 PM H.J. Lu wrote: > > Update STV pass to properly count cost of XMM register push. In 32-bit > mode, to convert XMM register push in DImode, we do an XMM store in > DImode, followed by 2 memory pushes in SImode, instead of 2 integer > register pushes in SImode. To

ChangeLog files - server and client scripts

2020-05-13 Thread Martin Liška
Hi. I'm sending the gcc-changelog relates scripts which should be added to contrib folder. The patch contains: - git_check_commit.py - checking script that verifies git message format - git_update_version.py - a replacement of maintainer-scripts/update_version_git which bumps DATESTAMP and

[PATCH] coroutines: Implicitly movable objects should use move CTORs for co_return.

2020-05-13 Thread Iain Sandoe
.. and now to the right list… I came across a build failure in a folly experimental test case where, at first, it appeared that GCC was DTRT … however, further investigation concluded that this was a case of differing interpretations between implementations. It’s kinda unhelpful that the

Re: [PATCH] tsan: Add optional support for distinguishing volatiles

2020-05-13 Thread Marco Elver via Gcc-patches
On Wed, 6 May 2020 at 16:33, Marco Elver wrote: > > Hello, Jakub, > > On Tue, 28 Apr 2020 at 16:58, Dmitry Vyukov wrote: > > > > On Tue, Apr 28, 2020 at 4:55 PM Jakub Jelinek wrote: > > > > > > On Tue, Apr 28, 2020 at 04:48:31PM +0200, Dmitry Vyukov wrote: > > > > FWIW this is: > > > > > > > >

Re: [GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-13 Thread Christophe Lyon via Gcc-patches
Hi, On Wed, 13 May 2020 at 11:47, Srinath Parvathaneni wrote: > > Hello, > > Few MVE intrinsics like vldrbq_s32, vldrhq_s32 etc., the assembler > instructions generated by current compiler are wrong. > eg: vldrbq_s32 generates an assembly instructions `vldrb.s32 q0,[ip]`. > But as per Arm-arm

Re: [PATCH] Add -fsplit-dwarf

2020-05-13 Thread Eric Botcazou
> Did I mention I dislike -fsplit-dwarf? ;) Seconded, this will be confusing for almost all users. Since the option only affects debug info generation, it should be prefixed with 'g' in any case. -- Eric Botcazou

[GCC][PATCH][ARM]: Fix the wrong code-gen generated by MVE vector load/store intrinsics (PR94959).

2020-05-13 Thread Srinath Parvathaneni
Hello, Few MVE intrinsics like vldrbq_s32, vldrhq_s32 etc., the assembler instructions generated by current compiler are wrong. eg: vldrbq_s32 generates an assembly instructions `vldrb.s32 q0,[ip]`. But as per Arm-arm second argument in above instructions must also be a low register (<= r7).

Re: [PR77691] x86-vxworks malloc aligns to 8 bytes like solaris

2020-05-13 Thread Jonathan Wakely via Gcc-patches
On 13/05/20 04:49 -0300, Alexandre Oliva wrote: Hello, Jonathan, On May 9, 2020, Jonathan Wakely wrote: On 08/05/20 17:22 -0300, Alexandre Oliva wrote: (Couldn't r1->allocate(2, alignof(char)) possibly return a pointer that's *not* aligned? Maybe we should drop the test even if

Re: [PATCH, FORTRAN] ICE in gfc_conv_array_constructor_expr PR93497

2020-05-13 Thread Tobias Burnus
On 5/12/20 5:08 PM, Mark Eggleston wrote: fortran : ICE in gfc_conv_array_constructor_expr PR93497 "F" in "Fortran". Extra space before ":". PR fortran/93497 * decl.c (char_len_param_value) : Check whether character Likewise. (Do you like French typography? There, one uses a space

Re: [PATCH] Fix -fcompare-debug issue in purge_dead_edges [PR95080]

2020-05-13 Thread Richard Biener
On Wed, 13 May 2020, Jakub Jelinek wrote: > Hi! > > The following testcase fails with -fcompare-debug, the bug used to be latent > since introduction of -fcompare-debug. > The loop at the start of purge_dead_edges behaves differently between -g0 > and -g - if the last insn is a DEBUG_INSN, then

Re: [PATCH] Fold single imm use of a FMA if it is a negation [PR95060]

2020-05-13 Thread Richard Biener
On Wed, 13 May 2020, Jakub Jelinek wrote: > Hi! > > match.pd already has simplifications for negation of a FMA (FMS, FNMA, FNMS) > call if it is single use, but when the widening_mul pass discovers FMAs, > nothing folds the statements anymore. > > So, the following patch adjusts the

[PATCH] Fix -fcompare-debug issue in purge_dead_edges [PR95080]

2020-05-13 Thread Jakub Jelinek via Gcc-patches
Hi! The following testcase fails with -fcompare-debug, the bug used to be latent since introduction of -fcompare-debug. The loop at the start of purge_dead_edges behaves differently between -g0 and -g - if the last insn is a DEBUG_INSN, then it skips not just DEBUG_INSNs but also NOTEs until it

[PATCH] tree-optimization/33315 - common stores during sinking

2020-05-13 Thread Richard Biener
This implements commoning of stores to a common successor in a simple ad-hoc way. I've decided to put it into the code sinking pass since, well, it sinks stores. It's still separate since it does not really sink code into less executed places. It's ad-hoc since it does not perform any

[PATCH] Fold single imm use of a FMA if it is a negation [PR95060]

2020-05-13 Thread Jakub Jelinek via Gcc-patches
Hi! match.pd already has simplifications for negation of a FMA (FMS, FNMA, FNMS) call if it is single use, but when the widening_mul pass discovers FMAs, nothing folds the statements anymore. So, the following patch adjusts the widening_mul pass to handle that. I had to adjust quite a lot of

Re: testsuite: Fix up gcc.dg/asan/pr95051.c testcase [PR95051]

2020-05-13 Thread Martin Liška
On 5/12/20 9:23 PM, Jakub Jelinek wrote: Hi! On Tue, May 12, 2020 at 12:06:25PM -0700, H.J. Lu wrote: Excess errors: cc1: error: '-fsanitize=address' is incompatible with '-fsanitize=kernel-address' asan.exp adds -fsanitize=address which is incompatible with -fsanitize=kernel-address, so we

Re: [PR77691] x86-vxworks malloc aligns to 8 bytes like solaris

2020-05-13 Thread Alexandre Oliva
Hello, Jonathan, On May 9, 2020, Jonathan Wakely wrote: > On 08/05/20 17:22 -0300, Alexandre Oliva wrote: >> (Couldn't r1->allocate(2, alignof(char)) possibly return a pointer >> that's *not* aligned? Maybe we should drop the test even >> if !defined(BAD_MAX_ALIGN_T).) > Yes. > Different

Re: [PATCH] Add -fsplit-dwarf

2020-05-13 Thread Richard Biener via Gcc-patches
On Wed, May 13, 2020 at 1:40 AM Fangrui Song via Gcc-patches wrote: > > -fsplit-dwarf is similar to -gsplit-dwarf, but does not enable debugging > information by itself. This makes it easier to be plugged into a build > system without worrying that unnecessary debugging information may be >

Re: [PR 95013] EOF location is at end of file

2020-05-13 Thread Christophe Lyon via Gcc-patches
On Wed, 13 May 2020 at 02:24, H.J. Lu via Gcc-patches wrote: > > On Tue, May 12, 2020 at 2:24 PM Nathan Sidwell wrote: > > > > My recent C++ parser change to pay attention to EOF location uncovered a > > separate bug. The preprocesor's EOF logic would set the EOF location to > > be the