Re: [PATCH] avoid false positives due to compute_objsize (PR 95353)

2020-06-13 Thread Martin Sebor via Gcc-patches
On 6/13/20 3:50 PM, Sandra Loosemore wrote: On 6/2/20 6:12 PM, Martin Sebor via Gcc-patches wrote: The compute_objsize() function started out as a thin wrapper around compute_builtin_object_size(), but over time developed its own features to compensate for the other function's limitations (such

Re: [PATCH] avoid false positives due to compute_objsize (PR 95353)

2020-06-13 Thread Sandra Loosemore
On 6/2/20 6:12 PM, Martin Sebor via Gcc-patches wrote: The compute_objsize() function started out as a thin wrapper around compute_builtin_object_size(), but over time developed its own features to compensate for the other function's limitations (such as its inability to work with ranges).  The

Re: [PATCH] avoid false positives due to compute_objsize (PR 95353)

2020-06-13 Thread Martin Sebor via Gcc-patches
On 6/11/20 2:37 PM, Rainer Orth wrote: Hi Martin, The compute_objsize() function started out as a thin wrapper around compute_builtin_object_size(), but over time developed its own features to compensate for the other function's limitations (such as its inability to work with ranges). The

[PATCH] libgomp: added partial omp-tools.h for OMPD.

2020-06-13 Thread y2s1982 via Gcc-patches
This patch adds a partial omp-tools.h from OpenMP which describes function prototypes and data types used for OMPD. All feedback has been addressed. 2020-06-13 Tony Sim libgomp/ChangeLog: * Makefile.am (nodist_libsubinclude_HEADERS): Add omp-tools.h. * Makefile.in:

Re: [PATCH] libgomp: added a partial omp-tools.h for OMPD

2020-06-13 Thread y2s1982 . via Gcc-patches
Hi Jakub, When I compiled the header after adding the missing typedefs, I got warnings about nothrow attribute being ignored on typedef function declarations. Should I remove them from typedef function declarations? Cheers, Tony Sim On Sat, Jun 13, 2020 at 10:15 AM y2s1982 . wrote: > Hi

Re: [PATCH] libgomp: added a partial omp-tools.h for OMPD

2020-06-13 Thread y2s1982 . via Gcc-patches
Hi Jakub, Thank you for the valuable feedback. I especially liked the tip on how to compile the header. I will make a new patch and submit it. Cheers, Tony Sim On Sat, Jun 13, 2020 at 5:13 AM Jakub Jelinek wrote: > On Sat, Jun 13, 2020 at 11:06:52AM +0200, Jakub Jelinek via Gcc-patches >

Re: [PATCH v1 1/2][PPC64] [PR88877]

2020-06-13 Thread kamlesh kumar via Gcc-patches
Thank you all for the suggestions. This is first patch where I have just defined a struct libcall_arg_t which contains three member rtx, machine_mode and a boolean unsigned_p and will be used in passing args in emit_library_[call/value] functions. Once this patch is approved then i will create

[PATCH] Defined libcall_arg_t

2020-06-13 Thread Kamlesh Kumar via Gcc-patches
This is first patch where I have just defined a struct libcall_arg_t which contains three member rtx, machine_mode and a boolean unsigned_p and will be used in passing args in emit_library_[call/value] functions. Once this patch is approved then i will create second patch in which arg type

[PATCH] Defined libcall_arg_t

2020-06-13 Thread Kamlesh Kumar via Gcc-patches
This is first patch where I have just defined a struct libcall_arg_t which contains three member rtx, machine_mode and a boolean unsigned_p and will be used in passing args in emit_library_[call/value] functions. Once this patch is approved then i will create second patch in which arg type

Re: [PATCH] libgomp: added a partial omp-tools.h for OMPD

2020-06-13 Thread Jakub Jelinek via Gcc-patches
On Sat, Jun 13, 2020 at 11:06:52AM +0200, Jakub Jelinek via Gcc-patches wrote: > On Fri, Jun 12, 2020 at 07:51:32PM -0400, y2s1982 wrote: > > This patch adds a partial omp-tools.h from OpenMP project which > > declares function prototypes and typedefs used in OMPD. > > > > This patch also

Re: [PATCH] libgomp: added a partial omp-tools.h for OMPD

2020-06-13 Thread Jakub Jelinek via Gcc-patches
On Fri, Jun 12, 2020 at 07:51:32PM -0400, y2s1982 wrote: > This patch adds a partial omp-tools.h from OpenMP project which > declares function prototypes and typedefs used in OMPD. > > This patch also addressed all feedback. > > 2020-06-12 Tony Sim > > libgomp/ChangeLog: > > *

Re: [PATCH 1/2] RISC-V: Describe correct USEs for gpr_save pattern [PR95252]

2020-06-13 Thread Andreas Schwab
On Jun 10 2020, Kito Cheng wrote: > - Verified on rv32emc/rv32gc/rv64gc bare-metal target and rv32gc/rv64gc >linux target with qemu. Obviously not: ../../gcc/config/riscv/riscv.c:5190:21: error: comparison of integer expressions of different signedness: 'int' and 'unsigned int'

[patch, libfortran, committed] Suppress -Wstringop-overflow warning

2020-06-13 Thread Thomas Koenig via Gcc-patches
Hi, I just committed as obvious the patch below. Disable -Wstringop-overflow warning after checking code path of caller. The warning that is disabled, only on this single line, has been inspected and found to be not applicable; it is known that the size of the buffer is safe.