Re: [PATCH 5/8] intl: stop using fgrep for exgettext

2022-06-24 Thread Xi Ruoyao via Gcc-patches
On Fri, 2022-06-24 at 16:06 +, Joseph Myers wrote: > On Fri, 24 Jun 2022, Xi Ruoyao via Gcc-patches wrote: > > > fgrep has been deprecated in favor of grep -F for a long time, and > > the > > next grep release (3.8 or 4.0) will print a warning of fgrep is > > used. > > And, the fgrep command

[PATCH v2] c++: fix broken copy elision with nested TARGET_EXPRs [PR105550]

2022-06-24 Thread Marek Polacek via Gcc-patches
On Thu, Jun 02, 2022 at 05:08:54PM -0400, Jason Merrill wrote: > On 5/26/22 11:01, Marek Polacek wrote: > > In this problem, we are failing to properly perform copy elision with > > a conditional operator, so this: > > > >constexpr A a = true ? A{} : A{}; > > > > fails with: > > > >

Re: [PATCH] tilegx: Fix infinite loop in gen-mul-tables generator

2022-06-24 Thread Jeff Law via Gcc-patches
On 6/24/2022 12:19 PM, Iain Buclaw wrote: Excerpts from Jeff Law via Gcc-patches's message of Juni 22, 2022 8:16 pm: On 6/22/2022 11:30 AM, Iain Buclaw via Gcc-patches wrote: Hi, Since around GCC 10, the condition `j < (INTMAX_MAX / 10)' will get optimized into `j != 922337203685477580',

[pushed] c++: Include -Woverloaded-virtual in -Wall [PR87729]

2022-06-24 Thread Jason Merrill via Gcc-patches
This seems like a good warning to have in -Wall, as requested. But as pointed out in PR20423, some users want a warning only when a derived function doesn't override any base function. So let's put that lesser version in -Wall (and -Woverloaded-virtual=1) while leaving the semantics for the

Re: [PATCH]middle-end Use subregs to expand COMPLEX_EXPR to set the lowpart.

2022-06-24 Thread Jeff Law via Gcc-patches
On 6/15/2022 5:36 AM, Richard Sandiford wrote: Jeff Law via Gcc-patches writes: On 6/13/2022 5:54 AM, Richard Biener wrote: On Sun, Jun 12, 2022 at 7:27 PM Jeff Law via Gcc-patches wrote: [...] On a related topic, any thoughts on keeping complex objects as complex types/modes through

Add -Woverloaded-virtual to -Wall

2022-06-24 Thread Michel Zou via Gcc-patches
Hi, Here is a patch to add -Woverloaded-virtual to -Wall: https://gcc.gnu.org/bugzilla/attachment.cgi?id=49021 It should address this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87729 Regards,

Re: [PATCH] fortran, libgfortran, v2: Avoid using libquadmath for glibc 2.26+

2022-06-24 Thread Harald Anlauf via Gcc-patches
Hi Jakub, Am 24.06.22 um 12:29 schrieb Jakub Jelinek via Gcc-patches: On Thu, Jun 23, 2022 at 11:17:50PM +0200, Jakub Jelinek via Gcc-patches wrote: We currently use %rename lib liborig *lib: %{static-libgfortran:--as-needed} -lquadmath %{static-libgfortran:--no-as-needed} -lm %(libgcc)

Re: PING^2 : Re: [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain vfunc impls

2022-06-24 Thread Uros Bizjak via Gcc-patches
On Fri, Jun 24, 2022 at 8:19 PM David Malcolm wrote: > > I'd like to ping this patch: >https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html > > OK for trunk? I have no idea what patch does, but if all other targets do the same, x86 shouldn't be left behind. So, rubber-stamping OK.

[PATCH, committed] Fortran: fix checking of arguments to UNPACK when MASK is a variable [PR105813]

2022-06-24 Thread Harald Anlauf via Gcc-patches
Dear all, we failed to fully check arguments to UNPACK when the MASK argument was not simplified and considered a variable instead of an array. The fix is a one-liner. Regtested on x86_64-pc-linux-gnu and committed to mainline as obvious after an OK by Steve in the PR. Thanks, Harald From

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

2022-06-24 Thread Joseph Myers
On Fri, 24 Jun 2022, David Malcolm via Gcc-patches wrote: > > BTW, is this something simple enough I should just commit it without > > bugging > > the list for approval? > > The patch seems reasonable to me, but Joseph seems to be the expert on > i18n-related matters. > > Joseph, do we have a

Re: [PATCH] testsuite: Skip btf-bitfields-1.c if int is less than 32-bits

2022-06-24 Thread Jeff Law via Gcc-patches
On 6/23/2022 3:21 PM, Dimitar Dimitrov wrote: This test spuriously fails on AVR with: error: width of 'bitfield_c' exceeds its type 8-bit and 16-bit microcontrollers do not seem to be the target audience for BTF file format. So the least intrusive fix is to simply skip the test for

[committed] d: Give consistent error message when attribute argument not a string constant

2022-06-24 Thread Iain Buclaw via Gcc-patches
Hi, This patch adjusts all the "not a string" errors in the D attribute handlers to use the same format string for consistency. Bootstrapped and regression tested on x86_64-linux-gnu/-m32/-mx32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * d-attribs.cc

[committed] d: Add `@register' attribute to compiler and library (PR105413)

2022-06-24 Thread Iain Buclaw via Gcc-patches
Hi, This patch adds a new `@register' attribute to the D compiler and library. Addressing a feature request in PR105413. The `@register` attribute specifies that a local or `__gshared` variable is to be given a register storage-class in the C sense of the term, and will be placed into a

[committed] d: Construct indexes of ARRAY_TYPE using ARRAY_REF.

2022-06-24 Thread Iain Buclaw via Gcc-patches
Hi, This patch changes the D front-end code generation of index expressions to use an ARRAY_REF when the array expression is a ARRAY_TYPE. This is a small simplification over `((T *))[index]', which also allows eliding an unneccesary marking of TREE_ADDRESSABLE when the array expression is a

[committed] d: Merge upstream dmd 529110f66, druntime 148608b7.

2022-06-24 Thread Iain Buclaw via Gcc-patches
Hi, This patch merges the D front-end with upstream dmd 529110f66. The git revision hash of libdruntime has also been bumped, though the only changes made have been outside what is merged downstream. D front-end changes: - Import latest bug fixes to mainline. Bootstrapped and regression

Re: PING^2: Re: [PATCH 01/10] Add 'final' and 'override' to opt_pass vfunc impls

2022-06-24 Thread Jeff Law via Gcc-patches
On 6/24/2022 12:08 PM, David Malcolm via Gcc-patches wrote: On Mon, 2022-06-13 at 14:22 -0400, David Malcolm wrote: Ping for this patch:   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595444.html OK for trunk? Sorry, I though the series had been approved at some point.   In general,

Re: [PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Bernhard Reutner-Fischer via Gcc-patches
On 24 June 2022 14:35:20 CEST, Rainer Orth wrote: >Hi Xi, > >> On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote: >> >>> > -   if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v >>> > -i debian' >/dev/null 2>&1; then \ >>> > +   if $(SHELL) -c 'install-info

Go patch committed: Use bool for comma-ok if not already boolean

2022-06-24 Thread Ian Lance Taylor via Gcc-patches
This patch to the Go frontend uses bool for a comma-ok statement if the variable already has a type that is not a boolean type. This is a statement like v, ok := m[k] Otherwise we may try to convert an unnamed bool type to an interface type, which will fail. But we don't want to always use

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 14.0.0

2022-06-24 Thread David Malcolm via Gcc-patches
On Mon, 2022-06-06 at 17:49 -0400, Lewis Hyatt via Gcc-patches wrote: > Hello- > > The attached patch upgrades the cpp_wcwidth() function (needed for > computing display columns in diagnostics output) from Unicode 13 to > Unicode 14. I just mechanically followed the procedure in >

[r13-1243 Regression] FAIL: gcc.dg/torture/pr106070.c -Os execution test on Linux/x86_64

2022-06-24 Thread skpandey--- via Gcc-patches
On Linux/x86_64, b36a1c964f99758de1f3b169628965d3c3af812b is the first bad commit commit b36a1c964f99758de1f3b169628965d3c3af812b Author: Richard Biener Date: Fri Jun 24 13:37:22 2022 +0200 middle-end/106070 - bogus cond-expr folding caused FAIL: gcc.dg/torture/pr106070.c -O0

PING^2: Re: [PATCH 10/10] Add 'final' and 'override' in various places

2022-06-24 Thread David Malcolm via Gcc-patches
On Mon, 2022-06-13 at 14:30 -0400, David Malcolm wrote: > Ping re this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595443.html > > OK for trunk? > > Thanks > Dave > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > gcc/cp/ChangeLog: > > *

PING^2 : Re: [PATCH 08/10] i386: add 'final' and 'override' to scalar_chain vfunc impls

2022-06-24 Thread David Malcolm via Gcc-patches
I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html OK for trunk? Thanks Dave On Mon, 2022-06-13 at 14:30 -0400, David Malcolm wrote: > Ping for this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595440.html > > OK for trunk? > >

Re: [PATCH] tilegx: Fix infinite loop in gen-mul-tables generator

2022-06-24 Thread Iain Buclaw via Gcc-patches
Excerpts from Jeff Law via Gcc-patches's message of Juni 22, 2022 8:16 pm: > > > On 6/22/2022 11:30 AM, Iain Buclaw via Gcc-patches wrote: >> Hi, >> >> Since around GCC 10, the condition `j < (INTMAX_MAX / 10)' will get >> optimized into `j != 922337203685477580', which will result in an >>

PING^2 : Re: [PATCH 04/10] tree-switch-conversion.h: use final/override for cluster vfunc impls

2022-06-24 Thread David Malcolm via Gcc-patches
I'd like to ping this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595435.html OK for trunk? Thanks Dave On Mon, 2022-06-13 at 14:26 -0400, David Malcolm wrote: > Ping for this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595435.html > > OK for trunk? > >

PING^2 : Re: [PATCH 03/10] expr.cc: use final/override on op_by_pieces_d vfuncs

2022-06-24 Thread David Malcolm via Gcc-patches
On Mon, 2022-06-13 at 14:25 -0400, David Malcolm wrote: > Ping on this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html > > OK for trunk? > > Thanks > Dave > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > gcc/ChangeLog: > > * expr.cc: Add "final"

PING^2 Re: [PATCH 02/10] Add 'final' and 'override' on dom_walker vfunc impls

2022-06-24 Thread David Malcolm via Gcc-patches
I'd like to ping this patch again: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595436.html OK for trunk? Thanks Dave On Mon, 2022-06-13 at 14:23 -0400, David Malcolm wrote: > Ping for this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595436.html > > OK for tunk? > >

Re: kernel sparse annotations vs. compiler attributes and debug_annotate_{type, decl} WAS: Re: [PATCH 0/9] Add debug_annotate attributes

2022-06-24 Thread Yonghong Song via Gcc-patches
On 6/21/22 9:12 AM, Jose E. Marchesi wrote: On 6/17/22 10:18 AM, Jose E. Marchesi wrote: Hi Yonghong. On 6/15/22 1:57 PM, David Faust wrote: On 6/14/22 22:53, Yonghong Song wrote: On 6/7/22 2:43 PM, David Faust wrote: Hello, This patch series adds support for: - Two new

[committed] analyzer: consolidate call_string instances

2022-06-24 Thread David Malcolm via Gcc-patches
ana::call_string is a wrapper around an auto_vec of callsites, leading to non-trivial copying when copying around call_string instances, e.g. in ana::program_point. This patch consolidates call_string instances within the region_model_manager: it now owns the root/empty call_string, and each

[committed] analyzer: whitespace cleanups

2022-06-24 Thread David Malcolm via Gcc-patches
Clean up whitespace in preparation for a follow-up patch. No functional change intended. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-1249-g3752e21d8c180b. gcc/analyzer/ChangeLog: * call-string.cc (call_string::calc_recursion_depth): Whitespace

Re: [PATCH v3] rs6000: Adjust mov optabs for opaque modes [PR103353]

2022-06-24 Thread Segher Boessenkool
Hi! On Fri, Jun 24, 2022 at 09:03:59AM +0800, Kewen.Lin wrote: > on 2022/6/24 03:06, Segher Boessenkool wrote: > > On Wed, May 18, 2022 at 10:07:48PM +0800, Kewen.Lin wrote: > >> As PR103353 shows, we may want to continue to expand a MMA built-in > >> function like a normal function, even if we

Re: [PATCH] Improve reg_or_subregno to return INVALID_REGNUM when the subreg of memory is processed.

2022-06-24 Thread Segher Boessenkool
Hi! Please Cc: me on all combine patches, so that I will not miss any. On Thu, Jun 23, 2022 at 11:39:16AM +0800, liuhongt via Gcc-patches wrote: > This is follow-up to [1], return INVALID_REGNUM instead of gcc_assert, > also adjust some conditions guarded for reg_or_subregno. > > >OK, but I

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Iain Sandoe via Gcc-patches
> On 24 Jun 2022, at 17:09, Joseph Myers wrote: > > On Fri, 24 Jun 2022, Andrew Pinski via Gcc-patches wrote: > >> Though I do find that -E/-F have been part of the POSIX standard since >> at least 2004 which is interesting. > > grep -E and -F are already defined, and egrep and fgrep marked

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Joseph Myers
On Fri, 24 Jun 2022, Andrew Pinski via Gcc-patches wrote: > Though I do find that -E/-F have been part of the POSIX standard since > at least 2004 which is interesting. grep -E and -F are already defined, and egrep and fgrep marked as obsolescent, in the 1992/1993 edition of POSIX.2. --

Re: [PATCH 5/8] intl: stop using fgrep for exgettext

2022-06-24 Thread Joseph Myers
On Fri, 24 Jun 2022, Xi Ruoyao via Gcc-patches wrote: > fgrep has been deprecated in favor of grep -F for a long time, and the > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > And, the fgrep command in exgettext is no longer useful after we > migrated from SVN to Git.

[PATCH] libgfortran: Avoid using libquadmath powerpc64le fixes

2022-06-24 Thread Jakub Jelinek via Gcc-patches
Hi! Testing this on powerpc64le-linux revealed some problems with the patch when gcc is configured against glibc 2.26 through 2.31. Here is incremental patch (against the v2 patch) that fixes it. Built and tested on powerpc64le-linux with glibc 2.28, ok for trunk? 2022-06-24 Jakub Jelinek

[PATCH] PR tree-optimization/94026: Simplify (X>>8)&6 != 0 as X&1536 != 0.

2022-06-24 Thread Roger Sayle
This patch implements the missed optimization described in PR 94026, where a the shift can be eliminated from the sequence of a shift, followed by a bit-wise AND followed by an equality/inequality test. Specifically, ((X << C1) & C2) cmp C3 into (X & (C2 >> C1)) cmp (C3 >> C1) and likewise ((X >>

Re: [PATCH RFA] ubsan: do return check with -fsanitize=unreachable

2022-06-24 Thread Jason Merrill via Gcc-patches
On 6/22/22 00:04, Jason Merrill wrote: On 6/20/22 16:16, Jason Merrill wrote: On 6/20/22 07:05, Jakub Jelinek wrote: On Fri, Jun 17, 2022 at 05:20:02PM -0400, Jason Merrill wrote: Related to PR104642, the current situation where we get less return checking with just -fsanitize=unreachable

Re: Add fnspec attributes to cxa_* functions

2022-06-24 Thread Jason Merrill via Gcc-patches
On 6/23/22 09:59, Jan Hubicka via Gcc-patches wrote: Note that your email subject line is missing "[PATCH]" and a component tag like "c++:". this patch adds fnspecs for cxa_* functions in except.cc. Main goal is to make modref to see proper side-effects of functions which may throw. So in

Re: [PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Thomas Koenig via Gcc-patches
Hi, On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote: -   if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \ +   if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i debian' >/dev/null 2>&1; then \

Re: [PATCH] Enable some features for RTEMS in libstdc++

2022-06-24 Thread Jeff Law via Gcc-patches
On 6/24/2022 5:38 AM, Sebastian Huber wrote: On 23.06.22 13:39, Sebastian Huber wrote: Remove RTEMS support from crossconfig.m4 since this code is not used due to "with_newlib" being "yes". libstdc++-v3/ChangeLog: * configure: Regnerate. * configure.ac (newlib, *-rtems*): Enable

[PATCH] middle-end/106070 - bogus cond-expr folding

2022-06-24 Thread Richard Biener via Gcc-patches
The following fixes up r13-469-g9a53101caadae1b5 by properly implementing what operand_equal_for_comparison_p did. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. 2022-06-24 Richard Biener PR middle-end/106070 * match.pd (a != b ? a : b): Fix translation of

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Jonathan Wakely via Gcc-patches
On Fri, 24 Jun 2022 at 13:37, Xi Ruoyao wrote: > > On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote: > > Hi Jonathan, > > > > > > > I'll need some rework as Rainer told me "grep -E" may not work on some > > > > > Solaris systems w/o GNU grep, and the code snippet in > > > > >

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Xi Ruoyao via Gcc-patches
On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote: > Hi Jonathan, > > > > > I'll need some rework as Rainer told me "grep -E" may not work on some > > > > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in > > > > is exactly for Solaris... > > > > > > I checked that, and

Re: [PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Rainer Orth
Hi Xi, > On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote: > >> > -   if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v >> > -i debian' >/dev/null 2>&1; then \ >> > +   if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v >> > -i debian' >/dev/null

Re: [PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
On Fri, 2022-06-24 at 13:13 +0200, Bernhard Reutner-Fischer wrote: > > -   if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i > > debian' >/dev/null 2>&1; then \ > > +   if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i > > debian' >/dev/null 2>&1; then \

Re: [PATCH] RFC: Optimise SLP permutes of non-consecutive loads

2022-06-24 Thread Richard Biener via Gcc-patches
On Fri, 24 Jun 2022, Richard Sandiford wrote: > Richard Biener writes: > > On Thu, 23 Jun 2022, Richard Sandiford wrote: > >> In a reduction pair like: > >> > >> typedef float T; > >> > >> void > >> f1 (T *x) > >> { > >> T res1 = 0; > >> T res2 = 0; > >> for (int i = 0; i <

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Rainer Orth
Hi Jonathan, >> > I'll need some rework as Rainer told me "grep -E" may not work on some >> > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in >> > is exactly for Solaris... >> >> I checked that, and it's not :-) >> >> The egrep uses in extract_symvers.in are for

Re: [PATCH] Enable some features for RTEMS in libstdc++

2022-06-24 Thread Sebastian Huber
On 23.06.22 13:39, Sebastian Huber wrote: Remove RTEMS support from crossconfig.m4 since this code is not used due to "with_newlib" being "yes". libstdc++-v3/ChangeLog: * configure: Regnerate. * configure.ac (newlib, *-rtems*): Enable TLS support for all RTEMS targets

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Jonathan Wakely via Gcc-patches
On Fri, 24 Jun 2022 at 12:18, Jonathan Wakely wrote: > > On Fri, 24 Jun 2022 at 12:08, Xi Ruoyao via Libstdc++ > wrote: > > > > On Fri, 2022-06-24 at 11:00 +0100, Jonathan Wakely wrote: > > > On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ > > > wrote: > > > > > > > > egrep has been

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Jonathan Wakely via Gcc-patches
On Fri, 24 Jun 2022 at 12:08, Xi Ruoyao via Libstdc++ wrote: > > On Fri, 2022-06-24 at 11:00 +0100, Jonathan Wakely wrote: > > On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ > > wrote: > > > > > > egrep has been deprecated in favor of grep -E for a long time, and > > > the > > > next grep

Re: [PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 24 Jun 2022 15:06:32 +0800 Xi Ruoyao via Gcc-patches wrote: > fgrep has been deprecated in favor of grep -F for a long time, and the > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > Stop using fgrep so we won't see the warning. > > gcc/ChangeLog: > > *

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Xi Ruoyao via Gcc-patches
On Fri, 2022-06-24 at 11:00 +0100, Jonathan Wakely wrote: > On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ > wrote: > > > > egrep has been deprecated in favor of grep -E for a long time, and > > the > > next grep release (3.8 or 4.0) will print a warning of egrep is > > used. > > Stop

Re: [PATCH] libstdc++-v3: check for openat

2022-06-24 Thread Jonathan Wakely via Gcc-patches
On Thu, 23 Jun 2022 at 15:05, Alexandre Oliva wrote: > > On Jun 23, 2022, Jonathan Wakely wrote: > > > On Thu, 23 Jun 2022 at 12:08, Alexandre Oliva wrote: > >> > >> On Jun 22, 2022, Jonathan Wakely wrote: > >> > >> > There are other interactions between AT_CDCWD and ::openat not covered > >>

Re: [PATCH 7/8] testsuite: use grep -E instead of egrep

2022-06-24 Thread Arnaud Charlet via Gcc-patches
> egrep has been deprecated in favor of grep -E for a long time, and the > next grep release (3.8 or 4.0) will print a warning of egrep is used. > Stop using egrep so we won't see the warning. Ada part is OK, thanks. > gcc/testsuite/ChangeLog: > > * ada/acats/run_all.sh: Use grep -E

[PATCH] fortran, libgfortran, v2: Avoid using libquadmath for glibc 2.26+

2022-06-24 Thread Jakub Jelinek via Gcc-patches
On Thu, Jun 23, 2022 at 11:17:50PM +0200, Jakub Jelinek via Gcc-patches wrote: > We currently use > %rename lib liborig > *lib: %{static-libgfortran:--as-needed} -lquadmath > %{static-libgfortran:--no-as-needed} -lm %(libgcc) %(liborig) > in libgfortran.spec (on targets where we do configure in

Re: [PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Jonathan Wakely via Gcc-patches
On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ wrote: > > egrep has been deprecated in favor of grep -E for a long time, and the > next grep release (3.8 or 4.0) will print a warning of egrep is used. > Stop using egrep so we won't see the warning. > > libstdc++-v3/ChangeLog: > > *

Re: [PATCH] libstdc++: testsuite: work around bitset namespace pollution

2022-06-24 Thread Sebastian Huber
On 21.06.22 07:31, Alexandre Oliva via Gcc-patches wrote: rtems6 declares a global struct bitset in a header file included indirectly by sys/types.h, that ambiguates the unqualified references to bitset after "using namespace std" in the testsuite. Work around the namespace pollution with using

Re: [PATCH] RFC: Optimise SLP permutes of non-consecutive loads

2022-06-24 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Thu, 23 Jun 2022, Richard Sandiford wrote: >> In a reduction pair like: >> >> typedef float T; >> >> void >> f1 (T *x) >> { >> T res1 = 0; >> T res2 = 0; >> for (int i = 0; i < 100; ++i) >> { >> res1 += x[i * 2]; >> res2 += x[i * 2

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Rainer Orth
Hi Fangrui, > FWIW: glibc recently got the grep -E change and the solution is to use > plain grep -E, without $EGREP things. > Isn't setting PATH a good workaround if Solaris has the problem? > > https://sourceware.org/pipermail/libc-alpha/2022-June/139420.html while it's possible, the $PATH

Re: [PATCH] profile-count: fix /= and *= operators

2022-06-24 Thread Richard Biener via Gcc-patches
> Am 24.06.2022 um 10:14 schrieb Martin Liška : > > Hi. > > As noticed in the PR, I wrongly introduced /= and *= operators. > Problem was that these operators need to modify *this object. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed?

Re: [PATCH 2/3] lto-plugin: make claim_file_handler thread-safe

2022-06-24 Thread Richard Biener via Gcc-patches
> Am 21.06.2022 um 10:43 schrieb Martin Liška : > > On 6/21/22 09:56, Richard Biener wrote: >>> On Mon, Jun 20, 2022 at 12:20 PM Martin Liška wrote: >>> >>> On 6/20/22 11:32, Richard Biener wrote: On Thu, Jun 16, 2022 at 9:01 AM Martin Liška wrote: > > lto-plugin/ChangeLog:

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Andrew Pinski via Gcc-patches
On Fri, Jun 24, 2022 at 1:27 AM Fangrui Song via Gcc-patches wrote: > > On 2022-06-24, Rainer Orth wrote: > >Hi Xi, > > > >> On Fri, 2022-06-24 at 09:24 +0200, Rainer Orth wrote: > >> > >>> please remember that there's a world outside of GNU grep: e.g. Solaris > >>> /bin/grep doesn't support grep

Re: Add fnspec attributes to cxa_* functions

2022-06-24 Thread Richard Biener via Gcc-patches
> Am 23.06.2022 um 16:00 schrieb Jan Hubicka via Gcc-patches > : > > Hi, > this patch adds fnspecs for cxa_* functions in except.cc. Main goal is to > make > modref to see proper side-effects of functions which may throw. So in general > we get > - cxa_allocate_exception >which gets

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Fangrui Song via Gcc-patches
On 2022-06-24, Rainer Orth wrote: Hi Xi, On Fri, 2022-06-24 at 09:24 +0200, Rainer Orth wrote: please remember that there's a world outside of GNU grep: e.g. Solaris /bin/grep doesn't support grep -E (while /usr/xpg4/bin/grep does), so unconditionally replacing egrep with grep -E in several

[PATCH] profile-count: fix /= and *= operators

2022-06-24 Thread Martin Liška
Hi. As noticed in the PR, I wrongly introduced /= and *= operators. Problem was that these operators need to modify *this object. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin PR middle-end/106059 gcc/ChangeLog: *

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Rainer Orth
Hi Xi, > On Fri, 2022-06-24 at 09:24 +0200, Rainer Orth wrote: > >> please remember that there's a world outside of GNU grep: e.g. Solaris >> /bin/grep doesn't support grep -E (while /usr/xpg4/bin/grep does), so >> unconditionally replacing egrep with grep -E in several places is >> likely >> to

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
On Fri, 2022-06-24 at 09:24 +0200, Rainer Orth wrote: > please remember that there's a world outside of GNU grep: e.g. Solaris > /bin/grep doesn't support grep -E (while /usr/xpg4/bin/grep does), so > unconditionally replacing egrep with grep -E in several places is > likely > to break at least

Re: [PATCH] RFC: Optimise SLP permutes of non-consecutive loads

2022-06-24 Thread Richard Biener via Gcc-patches
On Thu, 23 Jun 2022, Richard Sandiford wrote: > In a reduction pair like: > > typedef float T; > > void > f1 (T *x) > { > T res1 = 0; > T res2 = 0; > for (int i = 0; i < 100; ++i) > { > res1 += x[i * 2]; > res2 += x[i * 2 + 1]; > } > x[0] = res1;

Re: [PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Rainer Orth
Hi Xi, > egrep and fgrep have been deprecated for a long time, and the next grep > release will emit a warning if egrep or fgrep is invoked: > > https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a951562 > > To prevent us from a lot of these warnings in the future, we should stop > using egrep

[PATCH 8/8] contrib: use grep -E instead of egrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep has been deprecated in favor of grep -E for a long time, and the next grep release (3.8 or 4.0) will print a warning of egrep is used. Stop using egrep so we won't see the warning. contrib/ChangeLog: * check_GNU_style.sh: Use grep -E instead of egrep. * test_summary:

[PATCH 7/8] testsuite: use grep -E instead of egrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep has been deprecated in favor of grep -E for a long time, and the next grep release (3.8 or 4.0) will print a warning of egrep is used. Stop using egrep so we won't see the warning. gcc/testsuite/ChangeLog: * ada/acats/run_all.sh: Use grep -E instead of egrep. *

[PATCH 6/8] fortran: use grep -F instead of fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
fgrep has been deprecated in favor of grep -F for a long time, and the next grep release (3.8 or 4.0) will print a warning of fgrep is used. Stop using fgrep so we won't see the warning. gcc/ChangeLog: * fortran/Make-lang.in: Use grep -F instead of fgrep. --- gcc/fortran/Make-lang.in |

[PATCH 5/8] intl: stop using fgrep for exgettext

2022-06-24 Thread Xi Ruoyao via Gcc-patches
fgrep has been deprecated in favor of grep -F for a long time, and the next grep release (3.8 or 4.0) will print a warning of fgrep is used. And, the fgrep command in exgettext is no longer useful after we migrated from SVN to Git. Remove the fgrep command so we won't see the warning.

[PATCH 4/8] libbacktrace: use grep -F instead of fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
fgrep has been deprecated in favor of grep -F for a long time, and the next grep release (3.8 or 4.0) will print a warning of fgrep is used. Stop using fgrep so we won't see the warning. libbacktrace/ChangeLog: * configure.ac: Use grep -F instead of fgrep. * configure:

[PATCH 3/8] libstdc++: use grep -E instead of egrep in scripts

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep has been deprecated in favor of grep -E for a long time, and the next grep release (3.8 or 4.0) will print a warning of egrep is used. Stop using egrep so we won't see the warning. libstdc++-v3/ChangeLog: * scripts/extract_symvers.in: Use grep -E instead of egrep. *

[PATCH 2/8] fixincludes: use grep -E/-F instead of egrep/fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep/fgrep has been deprecated in favor of grep -E/-F for a long time, and the next grep release (3.8 or 4.0) will print a warning if egrep or fgrep is used. Stop using egrep and fgrep so we won't see the warning. fixincludes/ChangeLog: * fixinc.in: Use grep -E instead of egrep.

Re: [PATCH] testsuite: Add new target check for no_alignment_constraints

2022-06-24 Thread Richard Biener via Gcc-patches
On Fri, Jun 24, 2022 at 2:34 AM Andrew Pinski via Gcc-patches wrote: > > On Thu, Jun 23, 2022 at 2:24 PM Dimitar Dimitrov wrote: > > > > A few testcases were marked for avr target, which has no alignment > > requirements. But those tests in fact should filter for any > > target having

[PATCH 1/8] config: use grep -E instead of egrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep has been deprecated in favor of grep -E for a long time, and the next grep release (3.8 or 4.0) will print a warning of egrep is used. Stop using egrep so we won't see the warning. ChangeLog: * configure.ac: Use grep -E instead of egrep. * config.rpath: Likewise. *

[PATCH 0/8] Stop using obsoleted egrep/fgrep

2022-06-24 Thread Xi Ruoyao via Gcc-patches
egrep and fgrep have been deprecated for a long time, and the next grep release will emit a warning if egrep or fgrep is invoked: https://git.savannah.gnu.org/cgit/grep.git/commit/?id=a951562 To prevent us from a lot of these warnings in the future, we should stop using egrep and fgrep. These

Re: [PATCH] testsuite: Handle default_packed for gcc.dg/builtin-object-size-20.c

2022-06-24 Thread Richard Biener via Gcc-patches
On Thu, Jun 23, 2022 at 11:24 PM Dimitar Dimitrov wrote: > > The gcc.dg/builtin-object-size-20.c test case assumes that the target > inserts padding between structure members. Obviously it fails for > targets which pack structures by default. > > Split the cases into two tests, so that the ones

Re: [PATCH] testsuite: Rename test-defined macros

2022-06-24 Thread Richard Biener via Gcc-patches
On Thu, Jun 23, 2022 at 11:23 PM Dimitar Dimitrov wrote: > > Epiphany, PRU, ARC and NDS32 may predefine __big_endian__ and > __little_endian__ macros. This leads to spurious warnings like: > gcc.dg/sso/memcpy-1.c:7: warning: "__little_endian__" redefined > > Fix by renaming the macros in the

Re: [PATCH] testsuite: Remove reliance on argc in lto/pr101868_0.c

2022-06-24 Thread Richard Biener via Gcc-patches
On Thu, Jun 23, 2022 at 11:23 PM Dimitar Dimitrov wrote: > > Some embedded targets do not pass any argv arguments. When argc is > zero, this causes spurious failures for lto/pr101868_0.c. Fix by > following the strategy in r0-114701-g2c49569ecea56d. Use a volatile > variable instead of argc to