Re: [PATCH 2/2] testsuite/unroll-8: Disable vectorization for varibale-factor targets

2023-11-25 Thread Andrew Pinski
On Wed, Nov 22, 2023 at 4:18 PM Jeff Law wrote: > > > > On 11/21/23 16:27, Palmer Dabbelt wrote: > > The vectorizer picks up these loops and disables unrolling on targets > > with variable vector factors. That result in better code here, but it > > trips up the unrolling tests. So just disable

[COMMITTED] Fix gcc.dg/vla-1.c

2023-11-25 Thread Andrew Pinski
r14-5628-g53ba8d669550d3 added noipa to f1 but `-fno-ipa-vrp` should have been used instead. The testcase is testing about the clone of f1 so turning off IPA VRP is the correct approach here rather than turning off of IPA on the function. gcc/testsuite/ChangeLog: PR testsuite/112691

[PATCH 2/2] Fix gcc.target/aarch64/simd/vmulxd_{f64, f32}_2.c after after IPA-VRP improvement for return values

2023-11-25 Thread Andrew Pinski
Just like the patch against gcc.target/aarch64/movk.c, the issue here is the two functions, foo32 and foo64 needed to mark as noipa so that IPA-VRP cannot propagate the return value. gcc/testsuite/ChangeLog: * gcc.target/aarch64/simd/vmulx.x (foo32): Mark as noipa rather than

[PATCH 1/2] Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by default

2023-11-25 Thread Andrew Pinski
Since contracts-tmpl-spec2.C is just testing contracts, I thought it would be better to just add `-fsigned-char` to the options rather than change the testcase to support both cases. Committed after testing on aarch64-linux-gnu. gcc/testsuite/ChangeLog: PR testsuite/108321 *

Re: [PATCH] libstdc++/complex: Remove implicit type casts in complex

2023-11-25 Thread Weslley da Silva Pereira
Hi Jonathan, Is there a way I can see my patch merged (when it gets merged)? Particularly, I want to have a link for the commit. I would like to add this as "impact on third party software" for the software https://github.com/tlapack/tlapack. Thanks, Weslley On Mon, Nov 6, 2023 at 3:44 AM

[Committed] RISC-V: Fix typo

2023-11-25 Thread Juzhe-Zhong
Fix typo. Committed. gcc/ChangeLog: * config/riscv/riscv-avlprop.cc (alv_can_be_propagated_p): Fix typo. (avl_can_be_propagated_p): Ditto. (vlmax_ta_p): Ditto. --- gcc/config/riscv/riscv-avlprop.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-25 Thread Iain Sandoe
e >> is clean? > > I was able to build a native GCC: > > /tmp/sh/i-native/bin/gcc --version --verbose > Using built-in specs. > COLLECT_AS_OPTIONS='--version' > COLLECT_GCC=/tmp/sh/i-native/bin/gcc > COLLECT_LTO_WRAPPER=/tmp/sh/i-native/lib/gcc/x86_64-pc-linux-gnu/

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-25 Thread waffl3x
I don't think so, I'm concerned that it might eat the xobj parameter if we do it that way. Besides, all we want is the lambda type anyway, I don't want to build a whole new node just to do that. Upon further consideration I think my solution does work and shouldn't cause problems. The field that

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-25 Thread Sebastian Huber
-in specs. COLLECT_AS_OPTIONS='--version' COLLECT_GCC=/tmp/sh/i-native/bin/gcc COLLECT_LTO_WRAPPER=/tmp/sh/i-native/lib/gcc/x86_64-pc-linux-gnu/14.0.0/lto-wrapper gcc (GCC) 14.0.0 20231125 (experimental) [master 9c26c91b94e] Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-25 Thread Jason Merrill
On 11/24/23 01:49, waffl3x wrote: and this in tsubst_lambda_expr that assumes iobj: /* Fix the type of 'this'. */ fntype = build_memfn_type (fntype, type, type_memfn_quals (fntype), type_memfn_rqual (fntype)); Unfortunately, putting a condition on this had some unforeseen consequences. I've

[pushed] wwwdocs: reading: Update the MicroBlaze section

2023-11-25 Thread Gerald Pfeifer
MicroBlaze is now with AMD, spelt MicroBlaze not MicroBlace, and the docs have a new address. --- htdocs/readings.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/htdocs/readings.html b/htdocs/readings.html index 2e320945..e4e68909 100644 --- a/htdocs/readings.html

[pushed] wwwdocs: gcc-13: Refer to GCC (instead of gcc)

2023-11-25 Thread Gerald Pfeifer
Refer to the overall project as GCC. Pushed. Gerald --- htdocs/gcc-13/porting_to.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-13/porting_to.html b/htdocs/gcc-13/porting_to.html index db0bf2fa..c727d66f 100644 --- a/htdocs/gcc-13/porting_to.html +++

Re: c: tree: target: C2x (...) function prototypes and va_start relaxation

2023-11-25 Thread Gerald Pfeifer
On Fri, 21 Oct 2022, Joseph Myers wrote: > C2x allows function prototypes to be given as (...), a prototype > meaning a variable-argument function with no named arguments. I noticed this did not make it into gcc-13/changes.html ? Was that intentional? Gerald

Re: [PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-25 Thread Richard Biener
On Sat, Nov 25, 2023 at 12:26 PM Sebastian Huber wrote: > > contrib/ChangeLog Did you verify an in-tree build with these works and the testsuite is clean? > * download_prerequisites: Update to gmp-6.3.0, mpfr-4.2.1, > mpc-1.3.1, isl-0.26, and gettext-0.22.4. > *

[PATCH v5] libstdc++: Remove UB from month and weekday additions and subtractions.

2023-11-25 Thread Cassio Neri
The following invoke signed integer overflow (UB) [1]: month + months{MAX} // where MAX is the maximum value of months::rep month + months{MIN} // where MIN is the maximum value of months::rep month - months{MIN} // where MIN is the minimum value of months::rep weekday + days {MAX}

Re: [wwwdocs][patch][OpenMP] gcc-14/changes.html + projects/gomp/: OpenMP update

2023-11-25 Thread Tobias Burnus
Gerald Pfeifer wrote: On Fri, 24 Nov 2023, Tobias Burnus wrote: While I expect more changes, I want to cleanup my stashed changes. Good approach! + The destory now optionally accepts the depend object as + argument. Is "depend object" a well known technical term in that context?

[pushed] doc: Complete and sort the list of front ends

2023-11-25 Thread Gerald Pfeifer
gcc: PR other/69374 * doc/install.texi (Downloading the source): Sort the list of front ends and add D, Go, and Modula-2. --- gcc/doc/install.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index

[pushed] doc: Remove obsolete notes on GCC 4.x on FreeBSD

2023-11-25 Thread Gerald Pfeifer
FreeBSD 6 and 7 have been end of life for years as have been GCC 4.x releases, so no point in detailing specifics of changes around those. gcc: PR target/69374 * doc/install.texi (Specific) <*-*-freebsd*>: Remove older contents referencing GCC 4.x. ---

Re: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606]

2023-11-25 Thread Jakub Jelinek
On Sat, Nov 25, 2023 at 12:03:56PM +, Tamar Christina wrote: > For the C99 versions of copysign, expand_COPYSIGN has optimized expansions > inplace. > One of the hooks there forces it to abs/neg. There is also code in place > for if the target > prefers integer expansion over floating

RE: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606]

2023-11-25 Thread Tamar Christina
> -Original Message- > From: Xi Ruoyao > Sent: Saturday, November 25, 2023 10:43 AM > To: Jakub Jelinek ; Segher Boessenkool > ; David Edelsohn > Cc: gcc-patches@gcc.gnu.org; Tamar Christina ; > Andrew Pinski > Subject: Re: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x)

Re: [PATCH] [gcc-wwwdocs]gcc-13/14: Mention Intel new ISA and march support

2023-11-25 Thread Gerald Pfeifer
On Mon, 17 Jul 2023, Haochen Jiang via Gcc-patches wrote: >GCC now supports the Intel CPU named Granite Rapids through > -march=graniterapids. > +The switch enables the AMX-FP16, PREFETCHI ISA extensions. Do I understand correclty that it enables AMX-FP16 and PREFETCHI? How about

[PATCH] Update GMP/MPFR/MPC/ISL/gettext to latest release

2023-11-25 Thread Sebastian Huber
contrib/ChangeLog * download_prerequisites: Update to gmp-6.3.0, mpfr-4.2.1, mpc-1.3.1, isl-0.26, and gettext-0.22.4. * prerequisites.md5: Update hash. * prerequisites.sha512: Likewise. --- contrib/download_prerequisites | 10 +- contrib/prerequisites.md5

Re: [patch][GCN] install.texi: Update GCN entry - @uref and LLVM version remark

2023-11-25 Thread Gerald Pfeifer
On Fri, 24 Nov 2023, Tobias Burnus wrote: > Stumbled over this. Same here. :-) > Comments? Thank you for fixing this. Gerald

[pushed] doc: Update ISO C++ reference

2023-11-25 Thread Gerald Pfeifer
http->https it is, once again. Gerald gcc: * doc/standards.texi (Standards): Update ISO C++ reference. --- gcc/doc/standards.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/standards.texi b/gcc/doc/standards.texi index 6eebb9426f3..4b18fa91289 100644

Re: [PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606]

2023-11-25 Thread Xi Ruoyao
On Sat, 2023-11-25 at 11:17 +0100, Jakub Jelinek wrote: > The middle-end has been changed quite recently to canonicalize > -abs (x) to copysign (x, -1) rather than the other way around. > While I agree with that at GIMPLE level, since it matches the GIMPLE > goal of as few operations as possible

[PATCH] rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606]

2023-11-25 Thread Jakub Jelinek
Hi! The middle-end has been changed quite recently to canonicalize -abs (x) to copysign (x, -1) rather than the other way around. While I agree with that at GIMPLE level, since it matches the GIMPLE goal of as few operations as possible for a canonical form (-abs (x) is 2 GIMPLE statements,

Re: [PATCH] Fix gcc.target/aarch64/movk.c testcase after IPA-VRP improvement for return values

2023-11-25 Thread Richard Sandiford
Andrew Pinski writes: > This fixes the testcase. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/movk.c: Add noipa on dummy_number_generator > and remove -fno-inline option. > > Signed-off-by: Andrew Pinski OK, thanks. Richard > --- > gcc/testsuite/gcc.target/aarch64/movk.c

[pushed] wwwdocs: readings: Update OpenPOWER link

2023-11-25 Thread Gerald Pfeifer
This is the original patch and a follow-up to fix an embarrassing markup mistake. Gerald commit 17418f262b17680a07a4493631aa0743b5fe9780 Author: Gerald Pfeifer Date: Fri Nov 24 09:33:26 2023 +0100 readings: Update OpenPOWER link The original link now redirects to a very

[PATCH] Emit funcall external declarations only if actually used.

2023-11-25 Thread Jose E. Marchesi
There are many places in GCC where alternative local sequences are tried in order to determine what is the cheapest or best alternative to use in the current target. When any of these sequences involve a libcall, the current implementation of emit_library_call_value_1 introduce a side-effect

Re: [PATCH] i386: Fix up *jcc_bt*_mask{,_1} [PR111408]

2023-11-25 Thread Uros Bizjak
On Sat, Nov 25, 2023 at 8:19 AM Jakub Jelinek wrote: > > Hi! > > The following testcase is miscompiled in GCC 14 because the > *jcc_bt_mask and *jcc_bt_mask_1 patterns have just > one argument in (match_operator 0 "bt_comparison_operator" [...]) > but as bt_comparison_operator is eq,ne, we need

[PATCH] RISC-V: Remove incorrect function gate gather_scatter_valid_offset_mode_p

2023-11-25 Thread Juzhe-Zhong
Come back to review the codes of gather/scatter, notice gather_scatter_valid_offset_mode_p looks odd. gather_scatter_valid_offset_mode_p is supposed to block vluxei64/vsuxei64 in RV32 system. However, it failed to do that since it is passing data_mode instead of index mode: