[PATCH] expandargv: fix memory leak

2017-12-30 Thread Daniel van Gerpen
When the responsefile's contents are interpolated into the argument vector, the pointer to original option string ("@filename") became lost. This caused a small leak for every responsefile on the commandline. --- libiberty/argv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] expandargv: fix memory leak

2017-12-30 Thread Daniel van Gerpen
On Sat, 30 Dec 2017 18:27:30 +0100 Andreas Schwab <sch...@linux-m68k.org> wrote: > On Dez 30 2017, Daniel van Gerpen <dan...@vangerpen.de> wrote: > > > When the responsefile's contents are interpolated into the argument > > vector, the pointer to original opti

[PATCH] expandargv: fix check for dynamic allocation of argument vector

2017-12-30 Thread Daniel van Gerpen
When the code interpolates the contents of response files, the argument vector is reallocated to the new size. This only works if it was dynamically allocated once before -- we do not want to mess with the argv memory given to us by the init code. The code tried to detect this with a flag, but